Bug 20515: Fix permission check on "ILL request" menu options
authorAndrew Isherwood <andrew.isherwood@ptfs-europe.com>
Wed, 4 Apr 2018 11:09:52 +0000 (12:09 +0100)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 16 Apr 2018 16:59:34 +0000 (13:59 -0300)
commita4ccd04d066ab304619c34adf15f9124e1cf6ee6
treeff8ef2db208dede7b813d26837944a7a28b07776
parent84327359787fe681e4ae456df330bcb4591f6291
Bug 20515: Fix permission check on "ILL request" menu options

This patch adds the following additional conditions to the display of
both the ILL Requests drop down "More" menu option and the "ILL Requests"
option on the intranet front page:

Before:

[% IF Koha.Preference('ILLModule') %]

After:

[% IF Koha.Preference('ILLModule') && (CAN_user_ill || CAN_user_superlibrarian) %]

This prevents the options being displayed to users who have no
permissions to work with ILL.

Test plan:

View both the intranet front page and "More" dropdown while logged in as
a user without ILL permissions, ensure the options do not display. Then
do the same with a user with ILL permissions, ensure the options do
display.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
koha-tmpl/intranet-tmpl/prog/en/includes/header.inc
koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt