Bug 30588: (QA follow-up) Clear waiting-for-2FA-setup in session
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Mon, 12 Sep 2022 09:02:21 +0000 (09:02 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Fri, 21 Oct 2022 14:37:02 +0000 (11:37 -0300)
commitad6530b914af64de7fd564c06218ecd940e389c3
tree0002ecf954eec0dc7b29274a9fdf2de81af38c98
parentd92b2b4c671001acf7dfd9cd0cf643f797d6f58e
Bug 30588: (QA follow-up) Clear waiting-for-2FA-setup in session

If we do not clear this session, the first login directly after setup
does not really enhances user experience ;)

Test plan:
Make sure 2FA is enforced.
Test the above. Disable your 2FA, logout and login.
Verify that you can access pages with this patch now. Without this
patch you could not.
Run these tests to provide more confidence:
t/db_dependent/Auth.t
t/db_dependent/api/v1/two_factor_auth.t
t/db_dependent/Koha/Auth/TwoFactorAuth.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
C4/Auth.pm