Bug 31485: Move _item_denied_renewal to Koha::Item
authorJoonas Kylmälä <joonas.kylmala@iki.fi>
Sun, 28 Aug 2022 20:01:19 +0000 (23:01 +0300)
committerTomas Cohen Arazi <tomascohen@theke.io>
Tue, 11 Oct 2022 13:19:20 +0000 (10:19 -0300)
commitb28a97fbe9007937d7b9052282d56e48886c3105
tree776b7f92b0ef1b8086a6dafda1a06b66689dcabb
parentf439537b202cf937616986883d283423211b7bb5
Bug 31485: Move _item_denied_renewal to Koha::Item

The question whether item is denied renewal doesn't depend on
circulation rules or the patron, it is only a property of the item and
only changes to the item's attributes can cause the return value of
the check to change, thus we should move this to be a method of
Koha::Item.

To test:
 1) Run unit tests
    $ prove t/db_dependent/Circulation.t
    $ prove t/db_dependent/Koha/Item.t

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
C4/Circulation.pm
Koha/Item.pm
t/db_dependent/Circulation.t
t/db_dependent/Koha/Item.t