Bug 10390: Add ability to delete empty invoices
authorJared Camins-Esakov <jcamins@cpbibliography.com>
Sun, 2 Jun 2013 11:50:43 +0000 (07:50 -0400)
committerGalen Charlton <gmc@esilibrary.com>
Fri, 5 Jul 2013 16:51:18 +0000 (16:51 +0000)
commitd02e2789e567158b30ad237d5efd864247dd4ead
tree1451efde9d8b3f24fc3d0ed86d7bd17919a4892f
parentd932f6ff250c3a50db379b23abfc40a77620e94b
Bug 10390: Add ability to delete empty invoices

There is currently no way to delete unused invoices (for example,
invoices created by mistake), and there really should be, since errors
and absent-mindedness can result in numerous empty invoices over the
course of years.

To test:
1) Apply patch.
2) Create three invoices in the Acquisitions module. For one of them,
   receive at least one item. For the other two, do not receive any
   items.
3) View one of the invoices that does not have any items on it.
4) Try to delete it. This should succeed.
5) View the invoice that has an item. There should not be any option
   to delete it.
6) Do an invoice search that brings up the other invoice with no items
   on it. Try to delete it from the results page. This should succeed.
7) Run the unit test:
   > prove t/Acquisition/Invoice.t
8) Sign off.

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests and QA script pass. I also did another test:

I cancelled all receipts from an existing invoice and then could
successfully delete it in the last step.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
C4/Acquisition.pm
acqui/invoice.pl
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt
t/Acquisition/Invoice.t