Bug 26635: AV expansion should ackowledge $params->{public}
authorTomas Cohen Arazi <tomascohen@theke.io>
Fri, 28 Oct 2022 14:50:13 +0000 (11:50 -0300)
committerTomas Cohen Arazi <tomascohen@theke.io>
Wed, 9 Nov 2022 17:00:43 +0000 (14:00 -0300)
commite4be0920543db3a8ded2890464db8792a129ac5b
treec9bfd467fabd5b57cb0042a79dae6e7784ddcf7a
parent15ee7885a314fdf0c98f2a10f250b7b1e8c30a52
Bug 26635: AV expansion should ackowledge $params->{public}

This patch simplifies the original implementation so it is more
readable, removing extra loops and methods and just dealing with the
coded values inline on the existing loops.

It also adds non-public attributes removal from the original list, to
address the changes introduced by bug 28948.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t \
           t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Koha/Object.pm