Bug 18150 - CanItemBeReserved doesn't work with (IndependentBranches AND ! canreserve...
authorNicolas Legrand <nicolas.legrand@bulac.fr>
Wed, 22 Feb 2017 09:11:18 +0000 (10:11 +0100)
committerBrendan A Gallagher <brendan@bywatersolutions.com>
Wed, 22 Mar 2017 17:46:07 +0000 (17:46 +0000)
commitf79cf7930d887ea157fa64bb89fb0eb130b74aae
tree1517bfecd719218190f413d0e6cafaccfb3897a0
parenta649958315c98500ebe0ea3f91c05a8067d54e58
Bug 18150 - CanItemBeReserved doesn't work with (IndependentBranches AND ! canreservefromotherbranches)

The variable $item used to be a hash, but at the end of the function,
it's a Koha object. As $item->{homebranch} doesn't yield anything and
should be $item->homebranch. It prevents people using different
branches without holds between branches from placing a hold on an item
they should be able to place hold on.

Test plan:

1. Before patch

  a. with IndependantBranches off
  b. try to place hold on an item you should be able to place hold on
  c. it should work
  d. put IndependantBranches on and canreservefromotherbranches off
  e. shouldn't work

2. after patches redo steps from (1) and everything should be working
fine.

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Note: Item is fetched twice, it's not necessary. But out of the scope of
this patch.

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
C4/Reserves.pm