Bug 33164: Ensure return claim message shows if lost item return blocked
authorAleisha Amohia <aleishaamohia@hotmail.com>
Tue, 7 Mar 2023 22:07:04 +0000 (11:07 +1300)
committerPedro Amorim <pedro.amorim@ptfs-europe.com>
Tue, 14 Nov 2023 14:58:03 +0000 (13:58 -0100)
commitf9ba89ade4684fae6ad4654882377021946a68c9
treec4f841b7b6252f023039ecee5659199aabed88fe
parent8500168c89faa52e8b0e4da97c53c74268f2a7b0
Bug 33164: Ensure return claim message shows if lost item return blocked

This fix ensures that a return claim confirmation always shows, even if
the return of lost items has been blocked by BlockReturnOfLostItems
being enabled.

To test:

1. Set BlockReturnOfLostItems system preference to Block
2. Check out an item to a patron
3. Go to the patrons page and claim a return on the item
4. Check in the item and keep checking in the item. Notice the message
"Item is lost, cannot be checked in." shows every time, but the return
claim message only shows sometimes.

5. Apply the patch and restart services

6. Check in the item and keep checking in the item. Confirm both the
lost message shows and the return claim message shows every time.
7. Confirm the return of the item is still blocked.

Sponsored-by: Pymble Ladies' College
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 1f56880812323a003d3d9d043c10c3142d397ac4)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 93276f59f14a293fdd639a6185577287693cd50c)
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
circ/returns.pl