koha.git
6 years agoBug 12792: C4::Reserves breaks my vim syntax color
Jonathan Druart [Wed, 20 Aug 2014 11:42:35 +0000 (13:42 +0200)]
Bug 12792: C4::Reserves breaks my vim syntax color

C4/Reserves.pm is unreadable with my vim configuration.
It appears I am the only one having this problem.
For an incomprehensible reason, a string constructs with
  qq/my string/;
completely breaks the syntax color for all the rest of the file (~2300l).
If I replace it with
  qq{my string};
all is fine!

Test plan:
launch
  git show HEAD
and verify this patch won't break anything.

Additionally, prove t/db_dependent/Reserves.t
This will trigger the three functions that were modified.
The prove currently fails on test 8, but the other succeeding
tests prove that this change is fine.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests pass on my installation.
No problems found.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13408: Tell librarians they may continue scanning while checkouts table is loading
Jonathan Druart [Mon, 8 Dec 2014 12:39:35 +0000 (07:39 -0500)]
Bug 13408: Tell librarians they may continue scanning while checkouts table is loading

Some librarians do not realize they can continue scanning items even if
the checkouts table has not loaded. We should have Koha tell them
explicitly that they may continue scanning barcodes.

Test Plan:
1) Apply this patch
2) Load the checkouts table on circulation.pl, note the loading message is now
   Loading... you may continue scanning.
3) Load the checkouts table on moremember.pl, note the loading message is still
   Loading...

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
This one works too!

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13566 - Change translation for 'Rotating collection' in German web installer
Marc Véron [Tue, 13 Jan 2015 04:42:02 +0000 (05:42 +0100)]
Bug 13566 - Change translation for 'Rotating collection' in German web installer

This page changes 'Wanderned Sammlungen verwalten' to 'Rotationsbestände verwalten'

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13579: Open history.txt using utf-8 encoding
Jonathan Druart [Wed, 14 Jan 2015 12:47:22 +0000 (13:47 +0100)]
Bug 13579: Open history.txt using utf-8 encoding

Test plan:
Verify about>Timeline is correctly encoded

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Replaced <encoding by <:encoding.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13579: Prefer like instead of ok to match a regex
Jonathan Druart [Wed, 14 Jan 2015 15:08:11 +0000 (16:08 +0100)]
Bug 13579: Prefer like instead of ok to match a regex

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13579: (regression tests) Encoding issues on about > timeline get tested
Tomas Cohen Arazi [Wed, 14 Jan 2015 14:45:34 +0000 (11:45 -0300)]
Bug 13579: (regression tests) Encoding issues on about > timeline get tested

This patch introduces two tests for encoding issues on about > timeline

To test:
- Apply the patch and run
  $ KOHA_USER=kohaadmin KOHA_PASS=katikoan KOHA_INTRANET_URL=http://koha-dev.biblioadmin prove t/db_dependent/www/history.t
  (adjust to your own settings, the user needs to have access to the about page)

Regards

Signed-off-by: Manuel Cohen Arazi <manuelcohenarazi@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13530: Typo in bulkmarcimport
Morag Hills [Tue, 13 Jan 2015 03:24:36 +0000 (03:24 +0000)]
Bug 13530: Typo in bulkmarcimport

GetFrameworkCode was incorrectly spelt as GetFrameworkcode on line 401.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoGRS-1 deprecation leftover used by jenkins
Tomas Cohen Arazi [Tue, 13 Jan 2015 18:30:23 +0000 (15:30 -0300)]
GRS-1 deprecation leftover used by jenkins

install_misc/environment_Makefile.PL is only used by jenkins to
automate the configuration step. This leftover doesn't affect
anyone but Jenkins so I take the liberty to push this amendment.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: (RM followup) Missing dependency in C4::Context
Tomas Cohen Arazi [Tue, 13 Jan 2015 18:27:17 +0000 (15:27 -0300)]
Bug 11944: (RM followup) Missing dependency in C4::Context

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13379: (RM followup) DBIx updates
Tomas Cohen Arazi [Tue, 13 Jan 2015 16:26:11 +0000 (13:26 -0300)]
Bug 13379: (RM followup) DBIx updates

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: DBRev 3.19.00.006
Tomas Cohen Arazi [Tue, 13 Jan 2015 16:13:02 +0000 (13:13 -0300)]
Bug 11944: DBRev 3.19.00.006

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: Fix problems introduced by bug 11515
Jonathan Druart [Thu, 4 Dec 2014 12:13:30 +0000 (13:13 +0100)]
Bug 11944: Fix problems introduced by bug 11515

The game continue...
Patch for bug 11515 introduced regression on this patch set.
To reproduce: search with utf8 characters at the opac
Test plan:
Verify that the issue described on bug 11515 is still fixed and that no
regression is found at the OPAC.

Note that I am pretty sure this patch is not enough.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: revert unneeded IsStringUTF8ish behaviour change
Tomas Cohen Arazi [Wed, 5 Nov 2014 14:59:38 +0000 (11:59 -0300)]
Bug 11944: revert unneeded IsStringUTF8ish behaviour change

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: (follow-up) Convert DB tables to utf8_unicode_ci
Jonathan Druart [Fri, 29 Aug 2014 15:38:33 +0000 (17:38 +0200)]
Bug 11944: (follow-up) Convert DB tables to utf8_unicode_ci

Some lines didn't match the regex I used!

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: Fix suggestion at the OPAC for perl v5.10
Jonathan Druart [Mon, 18 Aug 2014 15:33:32 +0000 (17:33 +0200)]
Bug 11944: Fix suggestion at the OPAC for perl v5.10

Without this patch and using Perl v5.10, on adding a suggestion at the
OPAC, the script explodes with the following error:
"cannot decode string with wide characters".

With this patch, all is fine using Perl v5.10 and v5.18.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: Convert DB tables to utf8_unicode_ci
Jonathan Druart [Thu, 24 Jul 2014 08:27:08 +0000 (10:27 +0200)]
Bug 11944: Convert DB tables to utf8_unicode_ci

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: decode uri_unescape data
Dobrica Pavlinusic [Wed, 23 Jul 2014 15:03:51 +0000 (17:03 +0200)]
Bug 11944: decode uri_unescape data

This data is passed into form so it needs to be correctly marked as
utf-8 if we want form submit to work correctly

This change fixes sort issues which use form submit.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: remove url/uri filter from query_cgi
Dobrica Pavlinusic [Wed, 23 Jul 2014 13:52:15 +0000 (15:52 +0200)]
Bug 11944: remove url/uri filter from query_cgi

We don't need to pass query_cgi through url (or uri) filter since this
will turn query string (correctly escaped inside code) back into
two-byte escaped string which CGI( -utf8 ) won't turn back into proper utf-8

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoRevert "Bug 12279: Diacritics in system preference editor broken"
Jonathan Druart [Mon, 9 Jun 2014 10:44:35 +0000 (12:44 +0200)]
Revert "Bug 12279: Diacritics in system preference editor broken"

This reverts commit 2fa2480447a58f9d5d3f7834bcfdcf62a0a95df3.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Conflicts:
admin/preferences.pl

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
http://bugs.koha-community.org/show_bug.cgi?id=11944

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
6 years agoBug 11944: (follow-up) Remove all utf8 filter from templates
Jonathan Druart [Wed, 14 May 2014 09:29:50 +0000 (11:29 +0200)]
Bug 11944: (follow-up) Remove all utf8 filter from templates

This patch removes 2 new occurrences introduced by bug 11351 and bug
10493.

Signed-off-by: Magnus Enger <digitalutvikling@gmail.com>
Removes a nasty "Template process failed: plugin error - EncodeUTF8:
plugin not found at /home/magnus/scripts/kohaclone/C4/Templates.pm line 124"
from /cgi-bin/koha/admin/itemtypes.pl

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: Fix encoding issue in C4::ItemType
Jonathan Druart [Wed, 14 May 2014 09:20:21 +0000 (11:20 +0200)]
Bug 11944: Fix encoding issue in C4::ItemType

There is no need to encode strings coming from DB.

To reproduce:
go on admin/item_circulation_alerts.pl
The headers contain bad encoded characters.

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: Remove bad FIXME in guided_report
Jonathan Druart [Thu, 8 May 2014 10:59:07 +0000 (12:59 +0200)]
Bug 11944: Remove bad FIXME in guided_report

Bug 11679 introduced a FIXME for this but it is wrong. The strings have
to be encoded before generating the ods file.

However, it is useless to decode column names.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: Fix encoding issue on search history
Jonathan Druart [Thu, 8 May 2014 10:34:24 +0000 (12:34 +0200)]
Bug 11944: Fix encoding issue on search history

Newly introduced by patches from bug 10807, the string was decoded
before to be stored in session.

To reproduce:
Enable history search
Go at the OPAC and log out
Search for something with utf-8
Go on your search history
The search description should be correctly encoded

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: Fix encoding issue for the "Did you mean" feature
Jonathan Druart [Wed, 16 Apr 2014 09:10:34 +0000 (11:10 +0200)]
Bug 11944: Fix encoding issue for the "Did you mean" feature

Test plan:
1/ Go on admin/didyoumean.pl and enable the feature for the OPAC
2/ Generate and use the french templates
3/ Launch a search at the OPAC
4/ You should see correctly encoded message

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: Fix encoding on sending emails
Jonathan Druart [Mon, 14 Apr 2014 14:33:56 +0000 (16:33 +0200)]
Bug 11944: Fix encoding on sending emails

This patch fixes 2 places where mails were badly encoded:
1/ At the opac and the intranet, on sending baskets
2/ At the opac and the intranet, on sending shelf/list

Test plan:
Shelf/List:
- Create a list with non-latin characters in the name.
- Add some items containing non-latin characters in their content.
- Send the list by email

Basket/Cart:
- Add some items containing non-latin characters in their content to
  your cart..
- Send the cart by email

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: use CGI( -utf8 ) everywhere
Jonathan Druart [Fri, 14 Mar 2014 14:26:16 +0000 (15:26 +0100)]
Bug 11944: use CGI( -utf8 ) everywhere

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: Fix encoding issue on adding a subscription
Jonathan Druart [Fri, 11 Apr 2014 13:45:10 +0000 (15:45 +0200)]
Bug 11944: Fix encoding issue on adding a subscription

If frequencies or numbering patterns contain non-latin characters, so
output was broken.

To reproduce:
- Create a frequency and a numbering pattern with non-latin characters
- Add a new subscription using these values
- The screen should not contain bad encoded characters.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: Fix fund names encoding on the parcel page
Jonathan Druart [Wed, 9 Apr 2014 13:21:50 +0000 (15:21 +0200)]
Bug 11944: Fix fund names encoding on the parcel page

On the parcel page, the subtotal values are stored in an hashref. The
key was the fund name. The fund name being encoded in utf8, the hashref
was broken.
This patch replaces this logic creating a key based on an integer.
The budget name is now stored in a new "budget_name" key.

Note: It also fixes a small ergonomic issue (a td was missing in the
tfoot).

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: Authentication
Jonathan Druart [Mon, 7 Apr 2014 14:45:59 +0000 (16:45 +0200)]
Bug 11944: Authentication

The password should be encoded before hashing.

Test plan:
- Before applying the patch, create a user with utf-8 in password
- apply patches
- try to log in
- change the password
- log out
- try to log in

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: Fix encoding issue on searching
Jonathan Druart [Mon, 17 Mar 2014 14:13:27 +0000 (15:13 +0100)]
Bug 11944: Fix encoding issue on searching

The search patch should fix non-latin character searches.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: FIX Error on editing an authority
Jonathan Druart [Mon, 7 Apr 2014 11:58:38 +0000 (13:58 +0200)]
Bug 11944: FIX Error on editing an authority

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: Some refresh don't indicate the charset to use
Jonathan Druart [Thu, 3 Apr 2014 13:54:30 +0000 (15:54 +0200)]
Bug 11944: Some refresh don't indicate the charset to use

This patch replaces occurrences of META HTTP-EQUIV=Refresh with a
redirection.

Note:
 The list of modified files has been got with the following grep:
  git grep Content-Type | grep -v -i utf | grep Refresh | grep -v translator | grep -v \.js

Test plan:
1) admin/auth_tag_structure.pl
- Go on an authority MARC framework for an authority type
(admin/auth_tag_structure.pl?authtypecode=CO for instance)
- Click on the "Add a new tag" button
- Fill fields
- Save
- You should be redirected on the auth_tag_structure.pl page
- Try to modify an existing tag
- The redirection should be done

2) admin/auth_subfields_structure.pl
- From the previous page, click on a "subfields" link
- Edit/Add a new subfields
- Save
- You should be redirected to the subfield list
- Delete a subfield
- You should be redirected to the subfield list

3) admin/authorised_values.pl
- Add/Edit an authorised value
- Save
- You should be redirected to the authorised value list (with the
  right category selected)

4) admin/categorie.pl
- Add/Edit a patron category
- Save
- You should be redirected to the category list
- Delete a patron category
- You should be redirected to the category list

5) admin/koha2marclinks.pl
- Go on the Koha to MARC mapping configuration page
- Edit a field
- Map a field and click on "OK"
- You should be redirected to the list

6) admin/marc_subfields_structure.pl
- Go on the MARC frameworks page
- Click on "MARC structure" for one on the list
- Click on "Subfields" for one on the list
- Add/Edit a subfield
- Save
- You should be redirected to the subfield list

7) admin/systempreferences.pl
- Go on the system preferences admin page
- Click on the "Local use" tab
- Add/Edit a pref
- Save
- You shold be redirected to the Local use preference list

8) serials/subscription-detail.pl
- Go on a subscription detail page
- Delete the subscription (using Edit > Delete subscription)
- You should be redirected on the serials home page

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: TT Plugins should not encode strings
Jonathan Druart [Mon, 17 Mar 2014 12:33:43 +0000 (13:33 +0100)]
Bug 11944: TT Plugins should not encode strings

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: Remove obsolete encoding routines
Jonathan Druart [Fri, 14 Mar 2014 16:22:27 +0000 (17:22 +0100)]
Bug 11944: Remove obsolete encoding routines

We don't need to decode manually which provide nice performance boost.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: Never use decode/encode in TT Plugins
Jonathan Druart [Fri, 14 Mar 2014 15:22:36 +0000 (16:22 +0100)]
Bug 11944: Never use decode/encode in TT Plugins

The EncodeUTF8 TT plugin is useless, we should NEVER use encode in
templates.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: replace uri_escape with uri_escape_utf8 everywhere
Jonathan Druart [Fri, 14 Mar 2014 15:07:11 +0000 (16:07 +0100)]
Bug 11944: replace uri_escape with uri_escape_utf8 everywhere

To reproduce, edit, index notice with utf-8 char and search for it

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: Library name variable should be decoded
Jonathan Druart [Fri, 14 Mar 2014 14:55:04 +0000 (15:55 +0100)]
Bug 11944: Library name variable should be decoded

Test on preferences.pl and on some others pages when mysql is used to
store session.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: Set ImplicitUnicode for YAML
Jonathan Druart [Fri, 14 Mar 2014 13:08:00 +0000 (14:08 +0100)]
Bug 11944: Set ImplicitUnicode for YAML

Before this patch, string for yaml files used in preferences.pl were
broken.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: Encoding UTF8 in C4::Templates
Jonathan Druart [Fri, 14 Mar 2014 10:29:34 +0000 (11:29 +0100)]
Bug 11944: Encoding UTF8 in C4::Templates

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: replace use of utf8 with Encode
Jonathan Druart [Fri, 14 Mar 2014 16:09:09 +0000 (17:09 +0100)]
Bug 11944: replace use of utf8 with Encode

See the wiki page for the explanation.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 11944: Remove all utf8 filter from templates
Jonathan Druart [Fri, 14 Mar 2014 08:16:16 +0000 (09:16 +0100)]
Bug 11944: Remove all utf8 filter from templates

This patch
- removes all html_entity usages in tt file which hide utf8 bugs
- removes all encode utf8 in tt plugins because we should get correctly
  marked data from DBIC and other sources directly (cf plugin EncodeUTF8
  used in renew.tt)
- adds some cleanup in C4::Templates::output: we now use perl utf8 file
  handler output so we don't need to decode tt variables manually.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13264: Follow up on record files: deleted fields (952/995) with items info
Zeno Tajoli [Mon, 29 Dec 2014 13:36:41 +0000 (14:36 +0100)]
Bug 13264: Follow up on record files: deleted fields (952/995) with items info

To insert items info you need to use correct code of sublibrary, not always the code is correct. Items info are not important for this test, so the fields are deleted (952 in MARC21, 995 in UNIMARC)

http://bugs.koha-community.org/show_bug.cgi?id=13264
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 13264: More tests for Latin-1 vs. UTF-8 interpretation
Zeno Tajoli [Mon, 29 Dec 2014 10:37:50 +0000 (11:37 +0100)]
Bug 13264: More tests for Latin-1 vs. UTF-8 interpretation

New tests in search_utf8.t, now are tested also records with only utf-8 chars that could see also as latin-1 chars

http://bugs.koha-community.org/show_bug.cgi?id=13264
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 13264: Update of unimarc and marc21 record to search publisher
Zeno Tajoli [Mon, 29 Dec 2014 10:36:33 +0000 (11:36 +0100)]
Bug 13264: Update of unimarc and marc21 record to search publisher

http://bugs.koha-community.org/show_bug.cgi?id=13264
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 13264: Add Latin-1 vs UTF-8 test specific records
Zeno Tajoli [Mon, 29 Dec 2014 09:25:25 +0000 (10:25 +0100)]
Bug 13264: Add Latin-1 vs UTF-8 test specific records

This patch addes two new files .mrc for marc21 and unimarc to test chars in utf8/latin-1 section only, to be sure that perl doesn't switch between utf-8 nad ISO 8859-1 inside itself.

http://bugs.koha-community.org/show_bug.cgi?id=13264
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 13264: Add tests for Latin-1 vs. UTF-8 deduction
Zeno Tajoli [Sun, 28 Dec 2014 22:14:56 +0000 (23:14 +0100)]
Bug 13264: Add tests for Latin-1 vs. UTF-8 deduction

add a test in auth_values_input_www to check chars that could be Latin-1 or UTF-8

http://bugs.koha-community.org/show_bug.cgi?id=13264
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 13264: Add more records to the marc21 aand unimarc files
Zeno Tajoli [Sun, 28 Dec 2014 20:56:05 +0000 (21:56 +0100)]
Bug 13264: Add more records to the marc21 aand unimarc files

Dupliacate record in marc21 and unimarc files, so the search finds always more than one result.

http://bugs.koha-community.org/show_bug.cgi?id=13264
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 13264: (QA followup) prevent double-encoding on the tests
Tomas Cohen Arazi [Fri, 26 Dec 2014 23:52:54 +0000 (20:52 -0300)]
Bug 13264: (QA followup) prevent double-encoding on the tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 13264: Refactor search utf8 tests and add some more
Jonathan Druart [Thu, 4 Dec 2014 12:12:00 +0000 (13:12 +0100)]
Bug 13264: Refactor search utf8 tests and add some more

t/db_dependent/www/search_utf8.t and
t/db_dependent/www/intranet_search_utf8.t were quite similar, I merged
them into a single file (t/db_dependent/www/search_utf8.t).
On the way, I added some tests for them.

Note that you will need the last patch on branch bug_11944 to see the
tests pass.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 13264: Additional test for search in intranet calatogue
Emmanuele Somma [Sat, 22 Nov 2014 20:34:23 +0000 (21:34 +0100)]
Bug 13264: Additional test for search in intranet calatogue

The utf-8 test do: insert a biblio record with tool, search the record in intranet,
delete batch upload and biblio records.

To test: prove intranet_search_utf8.t

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 13264: Follow up: in opac_utf8.t insert also delete of biblio
Zeno Tajoli [Fri, 21 Nov 2014 12:27:34 +0000 (13:27 +0100)]
Bug 13264: Follow up: in opac_utf8.t insert also delete of biblio

In previous version of the test opac_utf8.t clears import from resevoir
but it doesn't delete record from biblio table in MySQL.
This the standard work of the feature, see:
http://manual.koha-community.org/3.18/en/catalogtools.html#managestaged

Now the script deletes also record on MySQL level.
No necessary on Zebra level because it uses a temporaney Zebra index that it is
clenaned at the end of the script.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 13264: Make opac_utf8.t launch its own helper processes
Tomas Cohen Arazi [Thu, 20 Nov 2014 15:05:44 +0000 (12:05 -0300)]
Bug 13264: Make opac_utf8.t launch its own helper processes

This patch makes opac_utf8.t launch its own:
- zebrasrv process
- rebuild_zebra.pl (daemon mode)

It also takes care of killing them when finished. It sets a frecquency
of 5 seconds for the indexer, and waits 10 just in case before looking
for the indexed records.

To test:
- Just launch the tests.

Edit: fixes on the license text.

Regards
Tomas

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 13264: no need to test for MySQL
Tomas Cohen Arazi [Thu, 20 Nov 2014 15:05:24 +0000 (12:05 -0300)]
Bug 13264: no need to test for MySQL

This patch removes the test for a running MySQL process.
It is already implied by successfuly loading C4::Context.

It also fixes the license text.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 13264: Test for utf-8 on authorised values input/display/delete
Zeno Tajoli [Wed, 19 Nov 2014 20:58:54 +0000 (21:58 +0100)]
Bug 13264: Test for utf-8 on authorised values input/display/delete

This test check utf-8 support on web intranet interface for authorized values.
It test input, search and delete of utf-8 values.
If all OK it destroy values inserted

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 13264: Test for utf-8 on Opac search
Zeno Tajoli [Wed, 19 Nov 2014 20:54:01 +0000 (21:54 +0100)]
Bug 13264: Test for utf-8 on Opac search

This test need to setup zebraserver and background indexing.
You need to set also KOHA_INTRANET_URL and KOHA_OPAC_URL
in the user enviroment.

It imports sample records and retrieves them on hte OPAC through
Apache.

To run it: prove opac_utf8.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 13264: UNIMARC and MARC21 records to test UTF-8
Zeno Tajoli [Wed, 19 Nov 2014 20:47:33 +0000 (21:47 +0100)]
Bug 13264: UNIMARC and MARC21 records to test UTF-8

The records shares enough chars to do the same search ('deuteros') to
find them and check the same utf-8 chars.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 12868: Wrong variable used for borrower number
Mark Tompsett [Wed, 3 Sep 2014 23:15:12 +0000 (19:15 -0400)]
Bug 12868: Wrong variable used for borrower number

When only the card number is passed to GetMemberDetail, the
value of $borrowernumber is undefined. Even after finding the
correct borrower and providing a nice hash ($borrower), the
GetMemberAccountRecords is called with the wrong borrower number,
even though it is in the hash ($borrower).

This was fixed by changing $borrowernumber to
$borrower->{borrowernumber}, so that the hash's value will always
be used, since it is correct regardless of whether borrowernumber
or cardnumber were used to find the borrower.

TEST PLAN
---------
1) Apply both patches
2) prove -v t/db_dependent/Member.t
   -- This time the previously failing test will pass.
3) run koha QA test tools.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 12868: Improving t/db_dependent/Member.t
Mark Tompsett [Wed, 3 Sep 2014 23:09:46 +0000 (19:09 -0400)]
Bug 12868: Improving t/db_dependent/Member.t

The mock function of GetMemberAccountRecord did not properly
account for the undef case. This was corrected.

Then all 4 combinations of borrower number and card number being
defined or not were called to GetMemberDetail.

The problematic test case is where the borrower number is
undefined and the cardnumber is defined.

TEST PLAN
---------
1) Apply just this first patch.
2) prove -v t/db_dependent/Member.t
   -- This should fail!
3) Run koha QA test tools.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 12922 - Do not DIE the advance_notices.pl -cronjob if no letter of type is found!!
Olli-Antti Kivilahti [Mon, 15 Sep 2014 08:38:32 +0000 (11:38 +0300)]
Bug 12922 - Do not DIE the advance_notices.pl -cronjob if no letter of type is found!!

We failed to deliver advance_notices because a template for sms's is undefined, because we don't support
sending sms' as advance_notice.
This crashed the cronjob because digests are set to die instead of the warn used in non-digest.
And we get angry customers asking for compensation!

This patch replaces the die with warn.

TEST PREPARATION:

0. Edit the ODUEDGST letter, find an undefined letter for any trasport type.

TEST PLAN:

1. Find a borrower and from the messaging preferences set the "Advance notice" transport type to
   the undefined digest. Set the "Days in Advance" to 1.
2. Check-out something for that borrower and set the due date for tomorrow.
3. Run "misc/cronjobs/advance_notices.pl -c -n -v" from the terminal.
4. BEFORE THIS PATCH: You get an error
   "No circulation PREDUEDGST letter transported by sms at /home/koha/kohaclone/C4/Letters.pm line 609."
   and the script dies.
4. AFTER THIS PATCH: You get an error
   "No circulation PREDUEDGST letter transported by sms at /home/koha/kohaclone/C4/Letters.pm line 609."
   but the script keep on going!

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13318: Delete C4::Acq::GetParcel
Jonathan Druart [Fri, 14 Nov 2014 10:15:08 +0000 (11:15 +0100)]
Bug 13318: Delete C4::Acq::GetParcel

Test plan:
  git grep GetParcel
should not return use of this subroutine.

Signed-off-by: wajasu <matted@34813.mypacks.net>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13522: Make it explicit that scalar containd a hash ref
Colin Campbell [Tue, 6 Jan 2015 11:40:46 +0000 (11:40 +0000)]
Bug 13522: Make it explicit that scalar containd a hash ref

Prior to perl 5.12 keys can only operate on a hash. So although
$data[0] ( thats an abysmal variable name! ) will contain a hash ref
the perl compiler cannot deduce that from the context and gives
a syntax error. Add the hash sigil to make the context explicit and
the compiler can generate the correct code.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13378: Add a filter to search suggestions not linked to a fund
Jonathan Druart [Wed, 3 Dec 2014 10:35:36 +0000 (11:35 +0100)]
Bug 13378: Add a filter to search suggestions not linked to a fund

This patch adds a "None" option for the fund filter.

Test plan:
1/ Go on the suggestion search page
2/ Search suggestions not linked to a fund using the "None" option.
3/ Search all suggestions (linked or not to a fund) using the "Any" option.

Works as expected.
Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13369: table should been highlighted correctly when row are grouped
Jonathan Druart [Tue, 2 Dec 2014 09:51:08 +0000 (10:51 +0100)]
Bug 13369: table should been highlighted correctly when row are grouped

The css used to highlight the rows comes from staff-global.css
We need a more specific rule to be used.

Test plan:
Go on the fund list view and confirm that the rows are correctly
highlighted.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13407: Bumping required version of PDF::Reuse
Chris Nighswonger [Fri, 19 Dec 2014 12:47:40 +0000 (07:47 -0500)]
Bug 13407: Bumping required version of PDF::Reuse

Signed-off-by: Chris <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13407: Removing depricated code included in PDF::Reuse
Chris Nighswonger [Tue, 2 Dec 2014 17:08:04 +0000 (12:08 -0500)]
Bug 13407: Removing depricated code included in PDF::Reuse

1. Upgrade PDF::Reuse to 0.35_04. [1]
2. Run Koha's non-DB dependent test suite. You should notice some non-fatal warnings about
   the redefinition of one or two subs in PDF::Reuse. This should not affect the
   functionality of the tools for the end user.
3. Verify the functionality of the related tools.
4. Apply the attached patch.
5. Re-run Koha's non-DB dependent test suite. You should note no warnings related to PDF::Reuse.
6. Re-verify the functionality of the related tools.

[1] http://search.cpan.org/CPAN/authors/id/C/CN/CNIGHS/PDF-Reuse-0.35_04.tar.gz

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Chris <chris@bigballofwax.co.nz>
http://bugs.koha-community.org/show_bug.cgi?id=13407

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Nice one! I only corrected the bug number in the subject.

6 years agoBug 11872 - Lost overdue items should not generate fines
Kyle M Hall [Tue, 29 Jul 2014 16:39:15 +0000 (12:39 -0400)]
Bug 11872 - Lost overdue items should not generate fines

An item can be marked as lost by longoverdue.pl, but left checked out to
the patron. In this case, the item will continue to accrue fines.

Test Plan:
1) Check out an item and back date it so it is overdue and should
   generate fines.
2) Mark the item as lost by either using longoverdue.pl, or just
   by setting itemlost to 1 by directly accessing the database
3) Run fines.pl
4) Note the overdue generated a fine
5) Repeat steps 1-2
6) Apply this patch
7) Run fines.pl
8) Note a fine was not generated

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13487: Fix pagination for the item search
Jonathan Druart [Mon, 22 Dec 2014 09:52:02 +0000 (10:52 +0100)]
Bug 13487: Fix pagination for the item search

Test plan:
Go on the catalogue/itemsearch.pl page and verify that the
pagination button (First, Prev, PAGES, Next, Last) is now correctly styled.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13487: Fix pagination for basketgroup
Jonathan Druart [Mon, 22 Dec 2014 09:51:50 +0000 (10:51 +0100)]
Bug 13487: Fix pagination for basketgroup

Test plan:
Go on the acqui/basketgroup.pl page and verify that the pagination
button (First, Prev, Next, Last) is now correctly styled.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13487: DT pagination contains '...' for the full_numbers form
Jonathan Druart [Mon, 22 Dec 2014 09:44:26 +0000 (10:44 +0100)]
Bug 13487: DT pagination contains '...' for the full_numbers form

Since the DT upgrade (bug 12986), the full_numbers pagination adds a
span (containing '...'). It is not managed by the css file and is put at
the end of the page numbers ( "1 2 3 4 5 20 NEXT LAST ...", we expect "1
2 3 4 5 ... 20 NEXT LAST").

Test plan:
1/ Go on the member search and launch a search which will return more than
7 pages
2/ Without this patch, the '...' span is put at the end of the
pagination bar.
3/ With the patch it should be better placed.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13459: Fix datatables paging for patron lists
Katrin Fischer [Sat, 27 Dec 2014 20:13:58 +0000 (21:13 +0100)]
Bug 13459: Fix datatables paging for patron lists

The display of the datatables paging options for the
patron list feature is broken.

To test:
- Go to tools > patron lists
- The paging for the 'list of lists' is broken
- Select a patron list 'Add more patrons'
- Notice the paging on this page is also broken
- Apply patch
- Verify both pages now display the paging correctly

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13459: Fix datatables paging for admin > itemtypes
Katrin Fischer [Sat, 27 Dec 2014 11:58:52 +0000 (12:58 +0100)]
Bug 13459: Fix datatables paging for admin > itemtypes

To test:
- Go to administration > itemtypes
- Verify the display of the paging options is broken
- Apply patch
- Verify the display is now correct and works nicely

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13379: DBRev 3.19.00.005
Tomas Cohen Arazi [Sun, 4 Jan 2015 15:55:45 +0000 (12:55 -0300)]
Bug 13379: DBRev 3.19.00.005

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13379: Extends authorised_values.category to varchar(32)
Jonathan Druart [Wed, 3 Dec 2014 11:33:48 +0000 (12:33 +0100)]
Bug 13379: Extends authorised_values.category to varchar(32)

This patch does 2 things:
1/ It fixes a bug caused by the different data fields used for
authorised_values.category and
borrower_attribute_types.authorised_value_category (varchar(16) vs
varchar(10)).
To reproduce:
- Create a AV category with a length > 10
- Try to link a patron attribute type with this AV, it won't work.

2/ Extends this field to varchar(32): sometime 16 is not enough to
describe something

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
No koha-qa errors. Error reproduced, fixed by patch.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 12969: Fix typo
Jonathan Druart [Fri, 26 Sep 2014 13:27:52 +0000 (15:27 +0200)]
Bug 12969: Fix typo

rrpgsti should be rrpgste

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 12969: Add a subroutine to calculate VAT and prices
Jonathan Druart [Fri, 19 Sep 2014 15:09:15 +0000 (17:09 +0200)]
Bug 12969: Add a subroutine to calculate VAT and prices

This patch adds a new subroutine populate_order_with_prices in the
C4::Acquisition module.

Its goal is to refactore the VAT and prices calculation into Koha.
All scripts will use this subroutine.

Test plan:
Verify that the prices in t/Prices.t are consistent with the values
listed in the file "Prices and VAT calculation - before" submit on bug
12964.
Verify that
  prove t/Prices.t
returns green

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13346: DBRev 3.19.00.004
Tomas Cohen Arazi [Sun, 4 Jan 2015 15:38:21 +0000 (12:38 -0300)]
Bug 13346: DBRev 3.19.00.004

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13346: OpacExportOptions becomes multiple
Jonathan Druart [Wed, 26 Nov 2014 11:58:41 +0000 (12:58 +0100)]
Bug 13346: OpacExportOptions becomes multiple

The list of options is limited, the interface could be more ergonomic.

Test plan:
- verify that you are still allowed to change (add/remove) options for the
  OpacExportOptions pref.
- At the OPAC, verify the selected options appear correctly (check the
  3 pages opac-ISBDdetail.pl, opac-MARCdetail.pl and opac-detail.pl).

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 8909: MARC21 240$a (Uniform title) is not a URL
Katrin Fischer [Sun, 30 Nov 2014 06:59:24 +0000 (07:59 +0100)]
Bug 8909: MARC21 240$a (Uniform title) is not a URL

Patch removes the 'isUrl' attribute from all 240$a fields in the various
frameworks. The change removes the broken link from the staff detail
MARC tab view.

Changes are a little easier to spot with: git diff --color-words HEAD^

To test:
- Load some or all of the frameworks
- Verify that 240$a is no longer marked as being an URL

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13119 - Use XSLT to display tagged titles in the OPAC
Owen Leonard [Tue, 21 Oct 2014 16:52:54 +0000 (12:52 -0400)]
Bug 13119 - Use XSLT to display tagged titles in the OPAC

This patch updates the display of a logged-in user's tagged titles to
use the same XSLT stylesheet used by search results and Lists. This
would make for a more consistent display of information.

Unrelated change: Corrected "My tags" header to read "Your tags,"
consistent with sidebar navigation.

To test you should have multiple titles in your catalog which you have
tagged in the OPAC.

- Set the OPACXSLTResultsDisplay system preference to 'default'
- Log in to the OPAC and view the "your tags" page.
- Confirm that title information is displayed correctly. Compare to
  search results.
- Empty the OPACXSLTResultsDisplay system preference and reload the
  "your tags" page. The display should revert to the old view, showing
  title, subtitle (if any) and author (if any).
- Set the OPACXSLTResultsDisplay to a custom path pointing to a custom
  XSL file and confirm that the list of your tagged titles changes
  accordingly.

Note: A follow-up will add "action" links ("place hold," "add to cart,"
etc) consistent with other pages.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
Works as described. opac-tag.pl page displays tagged titles the same way as
result & list pages.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13496: make auth.tt use a template plugin to get the Koha version
Tomas Cohen Arazi [Mon, 29 Dec 2014 00:20:55 +0000 (21:20 -0300)]
Bug 13496: make auth.tt use a template plugin to get the Koha version

This patch makes the installer login template use the new Koha.Version
template plugin to get the correct Koha version. This way we don't need
to maintain the auth.tt file on each version change, and are sure screen
readers tell the correct version.

To test:
- Create a situation where the login screen from the installer shows
- Navigate the HTML code (Ctrl+u)
=> FAIL: "Koha 3.0 Installer" shows on the HTML code
- Apply the patch
- Reload the page
=> SUCCESS: The correct version number is shown.
- Sign off :-D

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13496: add a method for the templates to print Koha version as desired
Tomas Cohen Arazi [Sun, 28 Dec 2014 22:44:39 +0000 (19:44 -0300)]
Bug 13496: add a method for the templates to print Koha version as desired

This patch introduces a simple template plugin function that returns
the Koha version number in different suitable formats.

It introduces unit tests for the new function. They are run with

To test:
- Apply the patch
- Run
  $ prove t/Koha_Template_Plugin_Koha.t
=> SUCCESS: the tests pass.
- Sign off :-D

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13495 [QA Followup] - Re-word "Renew or return" button as well
Kyle M Hall [Fri, 2 Jan 2015 01:34:00 +0000 (20:34 -0500)]
Bug 13495 [QA Followup] - Re-word "Renew or return" button as well

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13495: Use "checked in" instead of "returned" in circulation
Katrin Fischer [Sat, 27 Dec 2014 17:48:28 +0000 (18:48 +0100)]
Bug 13495: Use "checked in" instead of "returned" in circulation

To test:
- check out one or many items on a patron account
- return the items from the checkout table
- notice that a message "Checked in" is now shown
  in the first and last column, instead of "Returned"
  as before

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
I feel dirty signing this off, but I guess we have to be consistent in
our language

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Fixed merge conflict by removing changed lines no longer needed.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 9124: Remove non-existing field mapping and auth value for 942$e
Katrin Fischer [Sat, 29 Nov 2014 12:31:26 +0000 (13:31 +0100)]
Bug 9124: Remove non-existing field mapping and auth value for 942$e

942$e is mapped to biblioitems.cn_edition, which doesn't exist and
to an authorized value CN_EDITION, which doesn't exist either.

Patch removes the wrong mapping and non-existing auth value from
the frameworks.

To test:
- git diff --color-words HEAD^ is helpful
- Check all mappings are changed and SQL is still valid

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13504: Remove the '----' marker for CHECKIN and CHECKOUT notices
Jonathan Druart [Wed, 31 Dec 2014 12:23:06 +0000 (13:23 +0100)]
Bug 13504: Remove the '----' marker for CHECKIN and CHECKOUT notices

If only 1 item exist in the message, the marker is not removed.
This marker is removed by render_metadata, but this method is only
called on appending.

Test plan:
1/ Enable the CHECKIN and/or CHECKOUT notices for a patron
2/ check and item in or out and verify that the marker is no longer
displayed in the generated notices.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13167 Stage MARC for Import hangs for biblio containing invalid ISBN-13
Frédéric Demians [Sun, 2 Nov 2014 16:41:34 +0000 (17:41 +0100)]
Bug 13167 Stage MARC for Import hangs for biblio containing invalid ISBN-13

If the ISBN of a UNIMARC record begins with 979 then the 'Stage MARC for
import' hangs.  If I use the same UNIMARC record and change 979 to 978 in the
ISBN, 'Stage MARC for import' works perfectly.

The patch deals with the fact that converting an ISBN-13 to ISBN-10 with
Business::ISBN as_isbn10() method fails if the ISBN doesn't begin with 978.

TEST PLAN:

(1) Download, and decompress the ZIP file attached to BZ.
(2) On a UNIMARC Koha instance, go in Tools > Stage MARC for import.
(3) Choose the MARC file containing the record with an ISBN begining with 979.
    Click on Upload file, then Stage to import.
(4) The Job progress bar stay at 0%.
(5) Apply the patch. Repeat steps 2-3. The upload works.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Tested in a UNIMARC installation, confirmed that the patch fixes the
problem.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13167: (QA followup) regression tests
Tomas Cohen Arazi [Sun, 4 Jan 2015 14:14:58 +0000 (11:14 -0300)]
Bug 13167: (QA followup) regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 12896: (QA followup) use C4::Bookseller in t/db_dependent/Serials/Claims.t
Tomas Cohen Arazi [Sun, 4 Jan 2015 13:53:35 +0000 (10:53 -0300)]
Bug 12896: (QA followup) use C4::Bookseller in t/db_dependent/Serials/Claims.t

As C4::Bookseller is no longer imported in C4::Acquisition the tests
fail because of an undefined function call.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 12896: Remove 2 occurrences in comments
Jonathan Druart [Thu, 6 Nov 2014 09:45:42 +0000 (10:45 +0100)]
Bug 12896: Remove 2 occurrences in comments

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Passes tests and QA script.
Full test report on the bug report.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 12896: Move the bookseller-related code into Koha::Acquisition::Bookseller
Jonathan Druart [Tue, 9 Sep 2014 13:56:56 +0000 (15:56 +0200)]
Bug 12896: Move the bookseller-related code into Koha::Acquisition::Bookseller

The C4::Acquisition module should be exploded in order to add
readability and maintainability to this part of the code.

This patch is a POC, it introduces a new Koha::Acquisition::Bookseller module and put in
it the code from GetBookSeller and GetBookSellerFromId.

Test plan:
1/ Create a bookseller, modify it.
2/ Add contacts for this bookseller
3/ Create an order, receive it, transfer it
4/ Launch the prove command on all unit tests modified by this patch and
verify that all pass.

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 12823: Alert about defining the SRU search field mappings
Marcel de Rooy [Tue, 26 Aug 2014 09:14:33 +0000 (11:14 +0200)]
Bug 12823: Alert about defining the SRU search field mappings

This is a follow-up for report 6536 (SRU search targets).
It will alert a user that saves a SRU server without field mappings.

Test plan:
Add a Z39.50 server. No confirm message.
Add a SRU server without field mappings. Cancel the confirm.
Add one field mapping. No confirm message.

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 12823: Add some hints for Host and Database
Marcel de Rooy [Tue, 26 Aug 2014 08:31:29 +0000 (10:31 +0200)]
Bug 12823: Add some hints for Host and Database

When adding or editing a SRU server, this patch adds a hint, positioned
under the Hostname field.
It also moves similar information for SRU options and XSLT into hints.

Test plan:
Add/Edit SRU server. Look at Hostname, SRU options and XSLT.
Add/Edit Z39.50 server. No hints for Hostname and SRU options.

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 1861: (RM followup) DNIx updates
Tomas Cohen Arazi [Wed, 31 Dec 2014 17:09:00 +0000 (14:09 -0300)]
Bug 1861: (RM followup) DNIx updates

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13502: Add tests to highlight the problem
Jonathan Druart [Wed, 31 Dec 2014 11:09:49 +0000 (12:09 +0100)]
Bug 13502: Add tests to highlight the problem

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13502: Code introcduced in 1861 wrongly assumes a null userid is unique
Chris Cormack [Tue, 30 Dec 2014 21:20:59 +0000 (10:20 +1300)]
Bug 13502: Code introcduced in 1861 wrongly assumes a null userid is unique

To test

1/ Create a borrower with '' as their userid, you may have to edit a
   row in the db to do this
2/ Run  perl t/db_dependent/Circulation/CheckIfIssuedToPatron.t
3/ Notice some tests fail and you see
   DBD::mysql::st execute failed: Duplicate entry '' for key 'userid'
   at /home/chrisc/git/catalyst-koha/C4/SQLHelper.pm line 184.
4/ Apply the patch
5/ Run the tests again, notice they now pass

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 1861: Add 1 test to AddMember
Jonathan Druart [Tue, 30 Dec 2014 08:51:32 +0000 (09:51 +0100)]
Bug 1861: Add 1 test to AddMember

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 1861: There is a problem introduced with an earlier patch, on this patchset
Chris Cormack [Tue, 30 Dec 2014 02:37:39 +0000 (15:37 +1300)]
Bug 1861: There is a problem introduced with an earlier patch, on this patchset

-    $data{'userid'} = Generate_Userid($data{'borrowernumber'},
$data{'firstname'}, $data{'surname'}) if $data{'userid'} eq '';
+    $data{'userid'} = Generate_Userid( $data{'borrowernumber'},
$data{'firstname'}, $data{'surname'} )
+      if ( $data{'userid'} eq '' || Check_Userid( $data{'userid'} ) );

Check_Userid returns 1 if it is unique.  So this means unique userids
will always be discarded and new ones created.

This is why all the tests depending on a userid are now failing

To test

1/ run perl t/db_dependent/Serials_2.t
2/ Notice lots of tests fail
3/ OR Add a borrower with a userid set, notice the userid is ignored
and one is generated instead
4/ Apply patch
5/ Add a new borrower, notice the userid sticks (if it is unique)
6/ Run perl t/db_dependent/Serials_2.t notice tests pass
7/ Run perl t/db_dependent/Members.t notice tests still pass

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13252 Allow for IPv6 formatted addresses in Port definition
Colin Campbell [Thu, 27 Nov 2014 16:07:23 +0000 (16:07 +0000)]
Bug 13252 Allow for IPv6 formatted addresses in Port definition

The SIP config has allowed you to specify an interface ip as
part of the listeners/service/port attributei
 e. g.  as port="127.0.0.1:6001/tcp"
with IPv6 the equivalent would normally be
   as port="[::1]:5001/tcp"
However in this case incoming connections will get rejected because
Configuration constructs a string without the brackets
This patch makes tests both formats on incoming connections so that
they are accepted as they were previously

In future the best course is not to include a port identifier in the
port definition then if the server has ipv6 it will bind to all
interfaces and accept both IPv4 and IPv6 traffic

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13252 - SIP2 server should accept IPv6 connections
Benjamin Rokseth [Thu, 13 Nov 2014 19:34:25 +0000 (20:34 +0100)]
Bug 13252 - SIP2 server should accept IPv6 connections

This small patch adds a check on the SIP2 socket connection if it is
IPv6 and resolves socket address accordingly.

Any newer Debian distro would probably default to IPv6 so it would
eventually affect all SIP servers.

Tests against running SIP server on an IPv6 box:

http://wiki.koha-community.org/wiki/Koha_SIP2_server_setup#Testing_with_Telnet

before patch:
  disconnects immediately. Log output:
  Bad arg length for Socket::unpack_sockaddr_in, length is 28, should be 16

after patch:
  operates normally

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
6 years agoBug 13341 - Hard-coded "Preview" text in OPAC openlibrary.js
Owen Leonard [Wed, 10 Dec 2014 14:02:57 +0000 (09:02 -0500)]
Bug 13341 - Hard-coded "Preview" text in OPAC openlibrary.js

The OpenLibrary JavaScript includes an untranslated string, "Preview."
This patch move the string to the template so that it can be translated.

To test, apply the patch and test that the translator picks up the
string:

1. From misc/translator run 'perl translate update [lang]' (e.g. de-DE)
2. Edit misc/translator/po/[lang]-opac-bootstrap.po and add a
   translation for the updated "Preview" string
3. Remove the "#, fuzzy" marker from that entry
4. From misc/translator run 'perl translate install [lang]'
5. Enable the [lang] translation for the OPAC in system preferences
6. Enable the OpenLibraryCovers system preference.
7. In the OPAC switch to the [lang] translation.
7. View the detail page for a title for which there is an OpenLibrary
   cover image. Below it you should see a preview link with the
   translated string you added in step 2.

Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>