koha.git
14 years agobugfix (security flaw) : the additem template was open AFTER doing actions
Paul POULAIN [Mon, 22 Oct 2007 08:19:53 +0000 (03:19 -0500)]
bugfix (security flaw) : the additem template was open AFTER doing actions

when Logguing was ON, this resulted in an internal server error, thus the discovery of this bug.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoadding <div> to each query line
Paul POULAIN [Mon, 22 Oct 2007 08:19:51 +0000 (03:19 -0500)]
adding <div> to each query line

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agomoving some systemprefs to their correct tab
Paul POULAIN [Mon, 22 Oct 2007 08:19:49 +0000 (03:19 -0500)]
moving some systemprefs to their correct tab

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agominor HTML fixes (errors detected by translator)
Paul POULAIN [Mon, 22 Oct 2007 08:19:48 +0000 (03:19 -0500)]
minor HTML fixes (errors detected by translator)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobugfix : handling biblionumber in a field < 010
Paul POULAIN [Mon, 22 Oct 2007 08:19:47 +0000 (03:19 -0500)]
bugfix : handling biblionumber in a field < 010

the bug occur only if we have a malformed biblio, so it should "never" happend, but i've seen it once ;-)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years ago#1432 : duplicated barcodes when item edited
Paul POULAIN [Mon, 22 Oct 2007 08:19:46 +0000 (03:19 -0500)]
#1432 : duplicated barcodes when item edited

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoOverdues fixes (unfinished)
Paul POULAIN [Mon, 22 Oct 2007 08:19:45 +0000 (03:19 -0500)]
Overdues fixes (unfinished)

- reindenting
- upcasing SQL
- the script at least compiles...

... but it does seem not work yet

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agouserid blanked out when editing step1 or step2
Henri-Damien LAURENT [Mon, 22 Oct 2007 08:19:44 +0000 (03:19 -0500)]
userid blanked out when editing step1 or step2

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoempty commit
Paul POULAIN [Mon, 22 Oct 2007 08:19:43 +0000 (03:19 -0500)]
empty commit

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agofixes to moredetail.pl to allow status editing using updateitem.pl
Joshua Ferraro [Mon, 22 Oct 2007 04:40:50 +0000 (23:40 -0500)]
fixes to moredetail.pl to allow status editing using updateitem.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agomarking autocomplete=off for the input box to prevent the
Joshua Ferraro [Mon, 22 Oct 2007 04:40:49 +0000 (23:40 -0500)]
marking autocomplete=off for the input box to prevent the

Also, updating circulation-home.tmpl to check the syspref
to enable autocomplete

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agofixing typo in updatedatabase
Joshua Ferraro [Mon, 22 Oct 2007 03:49:50 +0000 (22:49 -0500)]
fixing typo in updatedatabase

14 years agobump up version number
Galen Charlton [Mon, 22 Oct 2007 02:23:24 +0000 (21:23 -0500)]
bump up version number

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agocall number patch part 4 -- resolve conflict with another DB schema change
Galen Charlton [Mon, 22 Oct 2007 02:23:23 +0000 (21:23 -0500)]
call number patch part 4 -- resolve conflict with another DB schema change

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agocall number work part 3 -- now using new routines to generate call number sort keys
Galen Charlton [Mon, 22 Oct 2007 02:23:27 +0000 (21:23 -0500)]
call number work part 3 -- now using new routines to generate call number sort keys

C4/Biblio.pm - removed following functions:

_biblioitem_cn_sort
_items_cn_sort

TODO: add a new call number filing routine to emulate logic of
_biblioitem_cn_sort for compatibility purposes

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agocall number work part 2 -- added framework for call number filing routines
Galen Charlton [Mon, 22 Oct 2007 02:23:26 +0000 (21:23 -0500)]
call number work part 2 -- added framework for call number filing routines

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoclassification sources part 1 - system preferences
Galen Charlton [Mon, 22 Oct 2007 02:23:25 +0000 (21:23 -0500)]
classification sources part 1 - system preferences

Database schema definitions and system preferences support
for defining classification sources and filing rules.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoWorking on a fix for bug 1456
Chris Cormack [Mon, 22 Oct 2007 02:05:53 +0000 (21:05 -0500)]
Working on a fix for bug 1456

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoadding new syspref: CircAutocompl
Joshua Ferraro [Mon, 22 Oct 2007 01:33:21 +0000 (20:33 -0500)]
adding new syspref: CircAutocompl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoMaking Koha news display more blog-like, with add/edit/delete links if user has privi...
Owen Leonard [Mon, 22 Oct 2007 01:33:20 +0000 (20:33 -0500)]
Making Koha news display more blog-like, with add/edit/delete links if user has privileges. Delete link doesn't have javascript warning yet.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoadding missing kohaversion.pl
Joshua Ferraro [Mon, 22 Oct 2007 00:59:43 +0000 (19:59 -0500)]
adding missing kohaversion.pl
adding missing line to updatedatabase

14 years agoupdatedatabase for branch category types
Ryan Higgins [Sun, 21 Oct 2007 20:11:39 +0000 (15:11 -0500)]
updatedatabase for branch category types

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoadding branch groups search in intranet.
Ryan Higgins [Sun, 21 Oct 2007 20:11:38 +0000 (15:11 -0500)]
adding branch groups search in intranet.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoExtending branch categories : adding search domains. partial commit.
Ryan Higgins [Sun, 21 Oct 2007 20:11:37 +0000 (15:11 -0500)]
Extending branch categories : adding search domains. partial commit.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agochanging DO_NOT_REMOVE to README.txt
Joshua Ferraro [Sun, 21 Oct 2007 20:11:36 +0000 (15:11 -0500)]
changing DO_NOT_REMOVE to README.txt

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agomoving localfiles to tmp
Joshua Ferraro [Sun, 21 Oct 2007 20:11:35 +0000 (15:11 -0500)]
moving localfiles to tmp

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoimprovements to zebra configuration files
Joshua Ferraro [Sun, 21 Oct 2007 20:11:34 +0000 (15:11 -0500)]
improvements to zebra configuration files

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoimprovements to zebra configuration files
Joshua Ferraro [Sun, 21 Oct 2007 20:11:33 +0000 (15:11 -0500)]
improvements to zebra configuration files

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoChanging searchmember to do an exact search on cardnumber first.
Chris Cormack [Sat, 20 Oct 2007 21:45:31 +0000 (16:45 -0500)]
Changing searchmember to do an exact search on cardnumber first.

To speed up circulations

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoStandardizing YUI toolbar
Owen Leonard [Sat, 20 Oct 2007 21:42:06 +0000 (16:42 -0500)]
Standardizing YUI toolbar

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoVarious tweaks to menus and labels, including adding virtual shelves link to global...
Owen Leonard [Sat, 20 Oct 2007 21:42:05 +0000 (16:42 -0500)]
Various tweaks to menus and labels, including adding virtual shelves link to global nav under "More"

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoMore work on standardizing toolbars. Also standardizing form markup in /tools
Owen Leonard [Sat, 20 Oct 2007 21:42:04 +0000 (16:42 -0500)]
More work on standardizing toolbars. Also standardizing form markup in /tools

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoVarious tweaks to menus and labels, including adding virtual shelves link to global...
Owen Leonard [Sat, 20 Oct 2007 21:42:03 +0000 (16:42 -0500)]
Various tweaks to menus and labels, including adding virtual shelves link to global nav under "More"

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoFix for 1477, reserves/holds not showing in moremember.pl
Chris Cormack [Sat, 20 Oct 2007 04:25:38 +0000 (23:25 -0500)]
Fix for 1477, reserves/holds not showing in moremember.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoCirculation borrower name autocompletion
Frederic Demians [Fri, 19 Oct 2007 19:32:18 +0000 (14:32 -0500)]
Circulation borrower name autocompletion

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoAdding truncation ccl attributes which were missing in my commit.
Henri-Damien LAURENT [Fri, 19 Oct 2007 19:32:19 +0000 (14:32 -0500)]
Adding truncation ccl attributes which were missing in my commit.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agomerging some SQL commands to speed up updatedatabase
Paul POULAIN [Sat, 20 Oct 2007 16:36:18 +0000 (18:36 +0200)]
merging some SQL commands to speed up updatedatabase

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoremoving another non-existant plugin
Joshua Ferraro [Sat, 20 Oct 2007 19:39:55 +0000 (14:39 -0500)]
removing another non-existant plugin

14 years agoremoving non-existant plugin
Joshua Ferraro [Sat, 20 Oct 2007 19:29:18 +0000 (14:29 -0500)]
removing non-existant plugin

14 years agoBug Fixing : Adding item had a javascript Error.
Henri-Damien LAURENT [Fri, 19 Oct 2007 19:00:35 +0000 (21:00 +0200)]
Bug Fixing : Adding item had a javascript Error.

So.
There are no more errors on saving an item.
There are still little problems when you duplicate a subfield :
Display table is not adapted
When you reedit, all the duplicate field values are concatenated.
But apart from that, it works.
Donot have time enough to work on it these days.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agofixing mode to 755
Joshua Ferraro [Fri, 19 Oct 2007 15:33:07 +0000 (10:33 -0500)]
fixing mode to 755

14 years agofixing horrible terrible merge problem by reverting
Joshua Ferraro [Fri, 19 Oct 2007 15:20:25 +0000 (10:20 -0500)]
fixing horrible terrible merge problem by reverting

to HDL's last commit

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agofixes to marc21 bib framework
Joshua Ferraro [Fri, 19 Oct 2007 07:12:27 +0000 (02:12 -0500)]
fixes to marc21 bib framework

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agohandle new call number scheme
Joshua Ferraro [Fri, 19 Oct 2007 07:12:26 +0000 (02:12 -0500)]
handle new call number scheme

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoAdding index on userid in the borrowers table
Chris Cormack [Fri, 19 Oct 2007 05:28:03 +0000 (00:28 -0500)]
Adding index on userid in the borrowers table

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agocirculation.pl cleaned up. I think you'll like the difference. Less
Joe Atzberger [Thu, 18 Oct 2007 23:42:37 +0000 (18:42 -0500)]
circulation.pl cleaned up. I think you'll like the difference. Less

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoImproving Search : Adding truncation management (right, left, rightleft,not inside)
Henri-Damien LAURENT [Thu, 18 Oct 2007 23:53:54 +0000 (18:53 -0500)]
Improving Search : Adding truncation management (right, left, rightleft,not inside)

Bug Fixing : Do Not delete stopwords when phrase search.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoremoving marc21_ plugin that doesn't exist yet from the framework
Joshua Ferraro [Fri, 19 Oct 2007 01:39:38 +0000 (20:39 -0500)]
removing marc21_ plugin that doesn't exist yet from the framework

14 years agoPatch from Galen Charlton, removing $Id$ $Log$ and $Revision$ from files
Chris Cormack [Thu, 18 Oct 2007 23:53:55 +0000 (18:53 -0500)]
Patch from Galen Charlton, removing $Id$ $Log$ and $Revision$ from files

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agofix for bug 1501 - removed reference to marc_biblio from framework test
Galen Charlton [Thu, 18 Oct 2007 23:53:53 +0000 (18:53 -0500)]
fix for bug 1501 - removed reference to marc_biblio from framework test

Also added results of two subtests missing from the template.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agostart of reworking call number handling and other Biblio changes
Galen Charlton [Thu, 18 Oct 2007 23:53:52 +0000 (18:53 -0500)]
start of reworking call number handling and other Biblio changes

Most of this commit by Joshua Ferraro.
updatedatabase changes by Galen Charlton.

Major changes:

This commit includes a lot of fairly major changes
to Koha's Biblio handling, largest is the addition
and deletion of several columns in the biblioitems,
items tables, as well as cleanup of deletedbiblioitems,
deleteditems tables. Some of the changes are simple
cleanup, but most have to do with improvements to
storage of call numbers in Koha.

Also, I had to clean up the _koha_* routines quite a
lot to make them work -- there was lots of data just
being lost because columns weren't being updated.

I'm still not completely convinced that the items
table is being treated as authoritative for items
data, investigating further.

DB Changes (updated in kohastructure.sql and in
updatedatabases):

ADDED:
biblioitems.cn_source   ( auth value, CN_SOURCE, stores the source of the
                          call number: DDC, LCC, NLM, etc.)
biblioitems.cn_class    ( plugin, marc21_callnumber.pl, helps fill in
                          the rest of the biblio-level fields)
biblioitems.cn_item
biblioitems.cn_suffix
biblioitems.cn_sort     ( for zebra sorting, stored as a decimal number)
biblioitems.totalissues ( for counting the total times issued )

items.cn_source         ( auth value, CN_SOURCE, stores DDC, LCC, NLM, etc.)
items.itemcallnumber    ( plugin, marc21_itemcallnumber.pl, helps fill in
                          the itemcallnumber based on the record data )
items.cn_sort           ( for zebra sorting, stored as a decimal number)
items.ccode             ( auth value, CCODE, stores the Collection Code
                          of the item, can be used as call number prefix
                          by some libraries )
items.uri
items.materials
items.damaged

DELETED:
items.itype
items.cutterextra
biblioitems.classification
biblioitems.subclass
biblioitems.dewey
biblioitems.lcsort
biblioitems.lccn
biblioitems.ccode

DB version now 3.00.00.009.

Minor changes:

* Drop revision history from C4/Biblio.pm
* GetMarcAuthors now returns additional authors (7XX), not
  main authors (1XX)
* Debug warnings in C4/Search.pm commented out

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoAdding 2006 MARC 21 bibliographic update. Adjusting SQL syntax. Adjusting Koha 3...
thd [Wed, 17 Oct 2007 20:20:34 +0000 (15:20 -0500)]
Adding 2006 MARC 21 bibliographic update. Adjusting SQL syntax. Adjusting Koha 3.0 biblioitems and items tables mappings.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoviewlog.pl clean up, uses Dates.pm now
Joe Atzberger [Thu, 18 Oct 2007 23:53:51 +0000 (18:53 -0500)]
viewlog.pl clean up, uses Dates.pm now

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoadmin/stopwords.pl -- More cleanup
Joe Atzberger [Thu, 18 Oct 2007 23:42:16 +0000 (18:42 -0500)]
admin/stopwords.pl -- More cleanup

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoadmin/printers - basic cleanup
Joe Atzberger [Thu, 18 Oct 2007 23:42:15 +0000 (18:42 -0500)]
admin/printers - basic cleanup

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoOrdering items on holdingbranch for ISBD.
Henri-Damien LAURENT [Thu, 18 Oct 2007 23:42:14 +0000 (18:42 -0500)]
Ordering items on holdingbranch for ISBD.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoAdding some more information on issuehistory.
Henri-Damien LAURENT [Thu, 18 Oct 2007 23:37:02 +0000 (18:37 -0500)]
Adding some more information on issuehistory.

Adding itemnumber to issuehistory.pl API
so that one could search for issuehistory of a specific item.
(Useful for IndependantBranches)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoMinor Bug Fix : Using IntranetBiblioDefaultView in Intranet
Henri-Damien LAURENT [Thu, 18 Oct 2007 23:37:01 +0000 (18:37 -0500)]
Minor Bug Fix : Using IntranetBiblioDefaultView in Intranet

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobug Fixing bugs.koha.org 1479
Henri-Damien LAURENT [Thu, 18 Oct 2007 10:08:17 +0000 (05:08 -0500)]
bug Fixing bugs.koha.org 1479

Porting userinterface improvements from biblios to items.

I have to port that also into serialsadditems.
Maybe there could be a way to have only one place for MARCinput management.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoMinor : Adding item count to result lists.
Henri-Damien LAURENT [Thu, 18 Oct 2007 09:56:30 +0000 (04:56 -0500)]
Minor : Adding item count to result lists.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBug Fixing : If multiple mandatory subfield and one is empty, unable to save biblio.
Henri-Damien LAURENT [Thu, 18 Oct 2007 09:50:24 +0000 (04:50 -0500)]
Bug Fixing : If multiple mandatory subfield and one is empty, unable to save biblio.

Duplicate a biblio with 3 authors, blank out one among them and try to save.
It was impossible.
Now, it works.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBug fixing : itemtype values were not shown on ISBD
Henri-Damien LAURENT [Thu, 18 Oct 2007 09:19:46 +0000 (04:19 -0500)]
Bug fixing : itemtype values were not shown on ISBD

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoPatch from Joe Atzberger to remove $Id$ and $Log$ from scripts
Chris Cormack [Thu, 18 Oct 2007 09:05:39 +0000 (04:05 -0500)]
Patch from Joe Atzberger to remove $Id$ and $Log$ from scripts

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoTotal Test Overhaul! Most of these were stubs, and still are.
Joe Atzberger [Thu, 18 Oct 2007 08:46:20 +0000 (03:46 -0500)]
Total Test Overhaul! Most of these were stubs, and still are.

Input.t was replaced because it tested a now obsolete function.
Input.pm has that function commented out.
Several files were renamed to match their counterparts or
correct misspellingz.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoRenamed file to match module. Trivial change.
Joe Atzberger [Thu, 18 Oct 2007 03:19:08 +0000 (22:19 -0500)]
Renamed file to match module. Trivial change.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoAdding new circulation-home, what we ultimately hope to be a "dashboard" interface...
Owen Leonard [Thu, 18 Oct 2007 03:08:06 +0000 (22:08 -0500)]
Adding new circulation-home, what we ultimately hope to be a "dashboard" interface for circulation functions. circulation-home.pl was created by copy-and-paste, so it should be reviewed. Circulation sub-pages' breadcrumb links have been updated to point to circulation-home.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoFormatting admin entry forms, improving breadcrumb navigation.
Owen Leonard [Thu, 18 Oct 2007 02:54:19 +0000 (21:54 -0500)]
Formatting admin entry forms, improving breadcrumb navigation.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBug-Fix : Display ISBN was not correct for ISBN-13
Henri-Damien LAURENT [Wed, 17 Oct 2007 20:20:38 +0000 (15:20 -0500)]
Bug-Fix : Display ISBN was not correct for ISBN-13

Copy/Pasting formulas errors.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agofines management (bugfixes & minor improvement)
Paul POULAIN [Wed, 17 Oct 2007 20:20:37 +0000 (15:20 -0500)]
fines management (bugfixes & minor improvement)

- pay.pl fixed, the librarian can see patron fines & mark them paid
- fines2.pl fixed, the script now calculate the fines correctly from the finerules :
  * itemtype / patron category if it exist
  * itemtype / default if needed
- renamed misc/fines.pl as fines-sanop.pl
- added 2 systempreferences:
  * MaxFine: the max amount a patron can be charged for an item
  * NoReturnSetLost: how many days of late before a non returned item is marked lost & the patron charged for the full cost of replacement
(those values where hardcoded in fines2.pl
- C4/Circulation/Fines.pm has been removed (unused duplicate of C4/Overdues)

Note that SANOP feature about notify levels have NOT been ported here. I think they are too specific now, and the code is poorly written
I've renammed fines.pl to fines-sanop.pl to point that it is specific.
Thus, all notify_id related features are not used by anything (and always 0)
Can be interesting to reintroduce them, but that will probably be a large work...

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoMinor bug fix : all Branches option was not translatable
Henri-Damien LAURENT [Wed, 17 Oct 2007 20:20:36 +0000 (15:20 -0500)]
Minor bug fix : all Branches option was not translatable

Removing blank branch from search.pl to add it in template.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBug Fix : 1484
Henri-Damien LAURENT [Wed, 17 Oct 2007 20:20:35 +0000 (15:20 -0500)]
Bug Fix : 1484

guarantor is now automatically filled in when coming from add Child.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobugfix for top issues, for branch selector
Paul POULAIN [Tue, 16 Oct 2007 21:02:46 +0000 (16:02 -0500)]
bugfix for top issues, for branch selector

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoSearchMyLibraryFirst : reintroducing behaviour (from 2.2)
Paul POULAIN [Tue, 16 Oct 2007 21:02:45 +0000 (16:02 -0500)]
SearchMyLibraryFirst : reintroducing behaviour (from 2.2)

If the SearchMyLibraryFirst is set, then a logged user will automatically limit the search
to it's own library.

I also did some code cleaning

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoopac-logout fixed
Paul POULAIN [Tue, 16 Oct 2007 21:02:44 +0000 (16:02 -0500)]
opac-logout fixed

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoauthorities : Adding sorting option to opac & sorting mainentry asc by default
Paul POULAIN [Tue, 16 Oct 2007 21:02:43 +0000 (16:02 -0500)]
authorities : Adding sorting option to opac & sorting mainentry asc by default

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoInsecure should not be set to 'NO'
Paul POULAIN [Tue, 16 Oct 2007 21:02:42 +0000 (16:02 -0500)]
Insecure should not be set to 'NO'

but to '0'. No is 'true' for Perl.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoadding YUI tabs support to authority detail
Paul POULAIN [Tue, 16 Oct 2007 21:02:41 +0000 (16:02 -0500)]
adding YUI tabs support to authority detail

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoadding YUI tabs support to MARCdetail.pl
Paul POULAIN [Tue, 16 Oct 2007 21:02:40 +0000 (16:02 -0500)]
adding YUI tabs support to MARCdetail.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBUGfixing authorities editor
Paul POULAIN [Tue, 16 Oct 2007 21:02:39 +0000 (16:02 -0500)]
BUGfixing authorities editor

With the YUI tabs, the SINGLETAB feature (that hides tabs when there is only 1) was bugguy
This commit fixes the problem, and solve some other ones :
- order the fields
- resize the input size (see previous commit in addbiblio.pl)
- remove some unused code
- reindent

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoreintroducing size for fields in addbiblio
Paul POULAIN [Tue, 16 Oct 2007 21:02:38 +0000 (16:02 -0500)]
reintroducing size for fields in addbiblio

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agofix for bug 1499 - normalize ISBN before dupe check
Galen Charlton [Tue, 16 Oct 2007 21:02:37 +0000 (16:02 -0500)]
fix for bug 1499 - normalize ISBN before dupe check

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBugFixing : viewlog.pl was broken (comma missing)
Henri-Damien LAURENT [Tue, 16 Oct 2007 21:02:36 +0000 (16:02 -0500)]
BugFixing : viewlog.pl was broken (comma missing)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoAdding Biblionumber to template param list
Henri-Damien LAURENT [Tue, 16 Oct 2007 21:02:35 +0000 (16:02 -0500)]
Adding Biblionumber to template param list

This enables navigating on MARC/ISBD/Normal View

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoRemoving connexion informations from basket page.
Henri-Damien LAURENT [Tue, 16 Oct 2007 21:02:34 +0000 (16:02 -0500)]
Removing connexion informations from basket page.

It masked biblio information.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBug Fixing ISBD parser had problems with commas
Henri-Damien LAURENT [Tue, 16 Oct 2007 21:02:33 +0000 (16:02 -0500)]
Bug Fixing ISBD parser had problems with commas

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBug Fixing : userid was blanked out in partial edit.
Henri-Damien LAURENT [Tue, 16 Oct 2007 21:02:32 +0000 (16:02 -0500)]
Bug Fixing : userid was blanked out in partial edit.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agopatches for members and resultlists.
Henri-Damien LAURENT [Tue, 16 Oct 2007 21:02:31 +0000 (16:02 -0500)]
patches for members and resultlists.

--
Henri Damien LAURENT et Paul POULAIN
Consultants ind√©pendants
en logiciels libres et biblioth√©conomie (http://www.koha-fr.org)

>From 616f0a385848b9a1fee7c76ff7b1f3be090ccb66 Mon Sep 17 00:00:00 2001
From: Henri-Damien LAURENT <henridamien@koha-fr.org>
Date: Tue, 16 Oct 2007 15:20:45 +0200
Subject: [PATCH] Bug Fixing : userid was blanked out in partial edit.
Adding some checks on branch presence for independant branches

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoDates.pm: perl test to accompany Dates.pm functions.
Joe Atzberger [Tue, 16 Oct 2007 21:02:29 +0000 (16:02 -0500)]
Dates.pm: perl test to accompany Dates.pm functions.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoDates.pm: Added functions format_date and format_date_in_iso as possible drop-in...
Joe Atzberger [Tue, 16 Oct 2007 21:02:28 +0000 (16:02 -0500)]
Dates.pm: Added functions format_date and format_date_in_iso as possible drop-in replacements for

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoRevert "Minor overhaul of installer WITHOUT thorough testing. Steps broken out into"
Joshua Ferraro [Wed, 17 Oct 2007 11:58:48 +0000 (06:58 -0500)]
Revert "Minor overhaul of installer WITHOUT thorough testing. Steps broken out into"

This reverts commit b9f141a592b15339fc36f07d6350c991defaf585.

14 years agoMinor overhaul of installer WITHOUT thorough testing. Steps broken out into
Joe Atzberger [Tue, 16 Oct 2007 21:02:27 +0000 (16:02 -0500)]
Minor overhaul of installer WITHOUT thorough testing. Steps broken out into

More revision is required: CVS variables, bad use of map in void context,
overuse of multiple index lines instead of one RegExp, etc.  Koha GPL
statement at top needed.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBug Fixing : Memberentry was broken.
Henri-Damien LAURENT [Mon, 15 Oct 2007 21:01:57 +0000 (16:01 -0500)]
Bug Fixing : Memberentry was broken.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoChanging the way resident search form is displayed; Reformatting admin-home.tmpl...
Owen Leonard [Mon, 15 Oct 2007 21:01:56 +0000 (16:01 -0500)]
Changing the way resident search form is displayed; Reformatting admin-home.tmpl; Updating entry form display on admin pages.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBUGfixes in availability management
Paul POULAIN [Sun, 14 Oct 2007 21:20:51 +0000 (16:20 -0500)]
BUGfixes in availability management

- the availability status was not available on result list. This patch reintroduces that
- notforloan as itemtype was not properly managed : an itemtype that was notforloan resulted in nothing in detail. Not, the user can't place a reserve anymore, and the status is correctly displayed

the fix is for OPAC as well as staff

(owen, pls, validate cat-toolbar.inc & catalogue/detail.tmpl)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoChange to address Bug 1471
Owen Leonard [Fri, 12 Oct 2007 22:35:32 +0000 (17:35 -0500)]
Change to address Bug 1471

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoFixes for Bug 1444. Trimming whitespace and correcting javascript form submit.
Owen Leonard [Fri, 12 Oct 2007 22:35:31 +0000 (17:35 -0500)]
Fixes for Bug 1444. Trimming whitespace and correcting javascript form submit.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoFix for Bug 1480 (added items link to biblio-view-menu.inc). Cleaned up display in...
Owen Leonard [Fri, 12 Oct 2007 22:35:30 +0000 (17:35 -0500)]
Fix for Bug 1480 (added items link to biblio-view-menu.inc). Cleaned up display in moredetail.tmpl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoA couple of forgotten markup corrections.
Owen Leonard [Fri, 12 Oct 2007 22:35:29 +0000 (17:35 -0500)]
A couple of forgotten markup corrections.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoMore refinements to MARC structure pages navigation
Owen Leonard [Fri, 12 Oct 2007 22:35:28 +0000 (17:35 -0500)]
More refinements to MARC structure pages navigation

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years ago#1485 (issuing rules improvement) continued
Paul POULAIN [Fri, 12 Oct 2007 22:35:27 +0000 (17:35 -0500)]
#1485 (issuing rules improvement) continued

updating fines rules management :
- replacing '*' by default
- removing bottom line (*) that means nothing
- dealing correctly with .0000 fine values
- fixing fine storage

still fines.pl to do

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>