koha.git
15 years agoModified log reporting to allow multiple modules to be selected.
David Goldfein [Fri, 24 Apr 2009 18:21:24 +0000 (13:21 -0500)]
Modified log reporting to allow multiple modules to be selected.

Reworked ViewLog.pl and the template.  Eliminated html errors, cleaned up
the template, change mime type to text/csv and other minor changes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoNew feature - database update - Number of Returned Items to Show
Michael Hafen [Fri, 24 Apr 2009 17:53:44 +0000 (11:53 -0600)]
New feature - database update - Number of Returned Items to Show

This is the database update to add the system preference for
numReturnedItemsToShow

[RM note: DB rev 026]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoNew feature Number of Returned Items to Show
Michael Hafen [Fri, 24 Apr 2009 17:53:43 +0000 (11:53 -0600)]
New feature Number of Returned Items to Show

This adds a system preference controlled feature.  This controls how
many returned items are shown on the check-in page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoDB rev 025: ceilingDueDate syspref
Galen Charlton [Fri, 24 Apr 2009 18:06:45 +0000 (13:06 -0500)]
DB rev 025: ceilingDueDate syspref

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoNew feature ceiling Due Date - database update
Michael Hafen [Wed, 25 Feb 2009 22:08:26 +0000 (15:08 -0700)]
New feature ceiling Due Date - database update

This updates the database to add the syspref ceilingDueDate.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoNew feature ceiling Due Date.
Michael Hafen [Thu, 5 Mar 2009 21:21:56 +0000 (14:21 -0700)]
New feature ceiling Due Date.

This adds a feature and system preference: ceilingDueDate.  If this is
set to a valid ( according to dateformat syspref ) date, then calculated
due dates will be less than this date.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup and tighten Letters module.
Joe Atzberger [Fri, 19 Sep 2008 00:02:46 +0000 (19:02 -0500)]
Cleanup and tighten Letters module.

Subroutine arguments enforced w/ with more checks, explicit return undef where warranted.
Placeholders used in SQL where applicable.
One logical error corrected :
- next MESSAGE if ( lc( $message->{'message_transport_type'} eq 'rss' ) );
+ next MESSAGE if ( lc($message->{'message_transport_type'}) eq 'rss' );

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBasic reformat of section in Search.pm
Joe Atzberger [Fri, 9 Jan 2009 21:42:27 +0000 (15:42 -0600)]
Basic reformat of section in Search.pm

In for loops, replace all-inclusive conditional blocks like:
    for (@foo) {
        if (test) {
            block;
        }
    }

with conditional use of "next":
    for (@foo) {
        test or next;
        block;
    }

This reduces the number of unnecessarily nested blocks, and the
overall number of lines.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agokohabug 2934 - Wrong datatype causes artificial limit to label batch id's
Chris Nighswonger [Thu, 29 Jan 2009 10:07:09 +0000 (05:07 -0500)]
kohabug 2934 - Wrong datatype causes artificial limit to label batch id's

labels.batch_id should be int as the value is always an integer. This corrects
the problem.

[RM note: ported patch to HEAD.  DB rev 024]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUse biblioitems.itemtype as a default for items.itype
Michael Hafen [Fri, 12 Sep 2008 19:16:58 +0000 (13:16 -0600)]
Use biblioitems.itemtype as a default for items.itype

This correct the html select default in additem.pl, and enforces use of
biblioitems.itemtype as the default in Items::AddItem.  The code in
Items is to catch items added through MARC record staging.

Thanks to Joe Atzberger for suggestion.

[RM note: this patch means that an item's item-level item type,
 once that item is added or updated via additem.pl,
 now cannot be blank or NULL unless the biblio-level item type
 is blank.]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2505 followup: restored correct item type image display
Galen Charlton [Fri, 24 Apr 2009 14:57:24 +0000 (09:57 -0500)]
bug 2505 followup: restored correct item type image display

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2505: adding warnings to opac-detail.pl
Andrew Moore [Wed, 17 Dec 2008 22:32:25 +0000 (16:32 -0600)]
Bug 2505: adding warnings to opac-detail.pl

Before starting to edit opac/opac-detail.pl, I added 'use warnings' and
eliminated all of the warnings that I could get it to produce. I also
extracted two lines that prepared an amazon ISBN into a function. They
were causing a few warnings and might as well be extracted. They should
probably be moved to a module somewhere since these two lines are copied
all over our code.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoModify GoogleJacket display
Frederic Demians [Wed, 21 Jan 2009 12:28:34 +0000 (13:28 +0100)]
Modify GoogleJacket display

On detail page, when GoogleJacket is enabled,
book cover is retrieved from Google. This image
is a link to GoogleBook services: full text,
book localisation in a bookstore, etc.

This patch removes the link on book cover and
add underneath a text 'Source Google' with a
link to GoogleBook services.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBlock warning on detail.pl.
Joe Atzberger [Wed, 21 Jan 2009 01:18:20 +0000 (19:18 -0600)]
Block warning on detail.pl.

If Amazon doesn't have an avg. rating number defined, then we cannot multiply it
by 20 without the following warning:

    detail.pl: Use of uninitialized value in multiplication (*)
    at /home/user/kohaclone/catalogue/detail.pl line 228.

So the important part of this patch is || 0 on the $average_rating assignment.

[RM note: applying for whitespace cleanup]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agorefactor: removing a few unnecessary loops and moving HTML out of script into template
Andrew Moore [Wed, 17 Dec 2008 22:30:46 +0000 (16:30 -0600)]
refactor: removing a few unnecessary loops and moving HTML out of script into template

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2765: updatedatabase to increase width of ISBN columns
Galen Charlton [Fri, 24 Apr 2009 13:41:24 +0000 (08:41 -0500)]
bug 2765: updatedatabase to increase width of ISBN columns

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug fix 2765
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:26 +0000 (14:58 +0100)]
bug fix 2765

Changing isbn data from 14 to 30 in order to manage friendlier,
isbn with - inside, and multiple isbns.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup, pod fix and FIXME's added.
Joe Atzberger [Fri, 23 Jan 2009 17:57:58 +0000 (11:57 -0600)]
Cleanup, pod fix and FIXME's added.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoDB rev 022: set DBrev for bug 2945 fix
Galen Charlton [Fri, 24 Apr 2009 13:16:30 +0000 (08:16 -0500)]
DB rev 022: set DBrev for bug 2945 fix

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2945: increase size of labels_conf.formatstring (DB update)
Joe Atzberger [Wed, 4 Feb 2009 19:55:03 +0000 (13:55 -0600)]
Bug 2945: increase size of labels_conf.formatstring (DB update)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3152 OPAC reading history column headers don't line up with text
Jane Wagner [Fri, 24 Apr 2009 12:33:50 +0000 (08:33 -0400)]
Bug 3152 OPAC reading history column headers don't line up with text

Fixed template files to make column headers and text line up; moved
the <td></td> for cover art outside the various content provider IF
statements.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3128 - followup and correction
Joe Atzberger [Thu, 23 Apr 2009 22:23:24 +0000 (17:23 -0500)]
Bug 3128 - followup and correction

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3128: IE7 tweak
Joe Atzberger [Wed, 22 Apr 2009 21:16:56 +0000 (16:16 -0500)]
Bug 3128: IE7 tweak

Again, jquery has the answer, mainly because it fails cleanly and
quietly on NULL/undef elements.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofixed typos in LTFL sysprefs
Galen Charlton [Fri, 24 Apr 2009 12:38:04 +0000 (07:38 -0500)]
fixed typos in LTFL sysprefs

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3093: Enhance placing of holds in the staff interface.
Stephen Edwards [Thu, 23 Apr 2009 16:45:54 +0000 (12:45 -0400)]
bug 3093: Enhance placing of holds in the staff interface.

This patch allows staff users to request reserves on multiple
items at one time.

Added checkboxes, select-all, clear-all, and place-hold button to
staff search results page.  Place-hold button will only appear if
the user has permission to place holds for others.  Item-level
Place-Hold button will not appear for multiple holds, nor will
the vertical detail menu.

Patron input page now shows multiple items, if applicable.

Hold confirmation page shows results for multiple items, if
applicable.  Those which cannot be reserved are highlighted and
are excluded from the reservation.  The reservation is placed at
the biblio number (i.e. next available) level.

Fixed display of item type.

Removed side menu for multiple items; removed item-oriented button for multiple items.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3155 followup: tweak OPACAmazonReviews syspref
Galen Charlton [Fri, 24 Apr 2009 11:05:09 +0000 (06:05 -0500)]
bug 3155 followup: tweak OPACAmazonReviews syspref

* add to enhanced content tab of syspref editor
* during upgrade, if database has OPACAmazonEnabled
  turned on, ensure that OPACAmazonReviews is on
  as well.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoDB rev 020 -> 021: OPACAmazonReviews syspref
Frédéric Demians [Fri, 24 Apr 2009 05:15:43 +0000 (07:15 +0200)]
DB rev 020 -> 021: OPACAmazonReviews syspref

Add new OPACAmzonReviews syspref

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBugfix #3155 Disabling Amazon Reviews
Frédéric Demians [Fri, 24 Apr 2009 05:15:42 +0000 (07:15 +0200)]
Bugfix #3155 Disabling Amazon Reviews

Disable Amazon reviews without disabling Amazon book cover.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoNew Developer
Chris Cormack [Thu, 23 Apr 2009 21:59:17 +0000 (09:59 +1200)]
New Developer

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoDB rev 019 -> 020: LTFL support
Galen Charlton [Thu, 23 Apr 2009 21:11:08 +0000 (16:11 -0500)]
DB rev 019 -> 020: LTFL support

Extends Christopher Hyde's patches to add LTFL support
as follows:

* adds fr-FR system preferences
* adds updatedatabase.pl

The three new system preferences are:

LibraryThingForLibrariesEnabled - turn ON to enable LTFL support
LibraryThingForLibrariesID - client ID for LTFL service
LibraryThingForLibrariesTabbedView - put LTFL content in tabs on bib detalis page

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix XHTML validation errors in LTFL output
Galen Charlton [Thu, 23 Apr 2009 21:10:45 +0000 (16:10 -0500)]
fix XHTML validation errors in LTFL output

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFixed minor error in comment code
Christopher Hyde [Fri, 3 Apr 2009 13:27:04 +0000 (09:27 -0400)]
Fixed minor error in comment code

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoChanges Made to further optimize and condense code, include code documentation, and...
Christopher Hyde [Thu, 2 Apr 2009 14:50:35 +0000 (10:50 -0400)]
Changes Made to further optimize and condense code, include code documentation, and fix hardcoded instead of syspref'd library thing id

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoChanges made: Fixed typo/bug which had wrong order for if statement checking to see...
Christopher Hyde [Wed, 1 Apr 2009 18:03:21 +0000 (14:03 -0400)]
Changes made: Fixed typo/bug which had wrong order for if statement checking to see whether

 Committer: Christopher Hyde <chyde@ebpl.org>

modified:   koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoChanges Added to existing LTFL code to give option of placing LTFL content in Tabs...
Christopher Hyde [Wed, 1 Apr 2009 18:03:20 +0000 (14:03 -0400)]
Changes Added to existing LTFL code to give option of placing LTFL content in Tabs on OPAC details page

modified:   admin/systempreferences.pl
modified:   installer/data/mysql/en/mandatory/sysprefs.sql
modified:   koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl
modified:   opac/opac-detail.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 1546 - replacing REPLACE statements
John Beppu [Thu, 23 Apr 2009 19:35:53 +0000 (14:35 -0500)]
bug 1546 - replacing REPLACE statements

replaced REPLACE statements with a pair of INSERT and UPDATE statements.
Hopefully, these are the last ones.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoDBrev 018 -> 019
Galen Charlton [Thu, 23 Apr 2009 19:54:15 +0000 (14:54 -0500)]
DBrev 018 -> 019

Also corrected message upon addition of new
OPACShowCheckoutName syspref.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCreates a syspref & modifies template to show checked out username in OPAC
Jane Wagner [Wed, 22 Apr 2009 16:08:43 +0000 (12:08 -0400)]
Creates a syspref & modifies template to show checked out username in OPAC

Intended for corporate or special sites which require the name of the person
who has checked out an item to show in the OPAC.  Most libraries will want
to leave this turned off!

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3118: Remove comment that perturbs IE
Joe Atzberger [Wed, 22 Apr 2009 20:22:38 +0000 (15:22 -0500)]
Bug 3118: Remove comment that perturbs IE

Formatting bugs not fixed.  Class added to relevant labels.
Both CSS and jquery setting of width do not "take" in IE7.
The background-color, however, can be affected.  Go figure.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding the dev weekend and another developer to the history docs
Chris Cormack [Wed, 22 Apr 2009 23:33:41 +0000 (11:33 +1200)]
Adding the dev weekend and another developer to the history docs

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoIE bugs 3124 and 3115: z3950 search and guided_reports
Joe Atzberger [Wed, 22 Apr 2009 18:24:34 +0000 (13:24 -0500)]
IE bugs 3124 and 3115: z3950 search and guided_reports

Clip trailing comma in js list argument.

Column selection improved with jquery and submit time check.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoTypo in history docs
Chris Cormack [Wed, 22 Apr 2009 23:33:40 +0000 (11:33 +1200)]
Typo in history docs

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for Bug 3119: Add due date to the patron circulation history window
Owen Leonard [Mon, 20 Apr 2009 18:25:01 +0000 (13:25 -0500)]
Fix for Bug 3119: Add due date to the patron circulation history window

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for Bug 1877, Link to patron record from manage suggestions
Owen Leonard [Tue, 21 Apr 2009 20:19:42 +0000 (15:19 -0500)]
Fix for Bug 1877, Link to patron record from manage suggestions

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoPatch to improve auto-generated MARC21 authorities
Brian Harrington [Tue, 21 Apr 2009 16:13:22 +0000 (12:13 -0400)]
Patch to improve auto-generated MARC21 authorities

This patch makes sure that MARC21 authorities have a minimal
Leader, 008, and 040.  If an authority record is created through
BiblioAddsAuthority it generates a 670 based on information in
the bib record.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding link back to OPAC for emailed cart and lists.
Owen Leonard [Tue, 21 Apr 2009 19:12:55 +0000 (14:12 -0500)]
Adding link back to OPAC for emailed cart and lists.

Correction to previous patch: uses "online catalog" in place of "OPAC" following the example of other text on the page

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug #3101 - Changed the Print and Confirm button
Brendan A. Gallagher [Sat, 18 Apr 2009 21:15:01 +0000 (17:15 -0400)]
Bug #3101 - Changed the Print and Confirm button

Changed button to read "Print slip, Transfer and Confirm"

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix to previous patch - use 'lt', not '<', to compare date strings
Galen Charlton [Mon, 20 Apr 2009 17:13:41 +0000 (12:13 -0500)]
fix to previous patch - use 'lt', not '<', to compare date strings

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoVisual alert (red) on overdue return.
Joe Atzberger [Mon, 20 Apr 2009 17:00:15 +0000 (12:00 -0500)]
Visual alert (red) on overdue return.

This was requested by a Koha user at KohaCon09.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2847 - Added url escaping for categorie.tmpl
Cory Jaeger [Mon, 20 Apr 2009 16:57:56 +0000 (11:57 -0500)]
Bug 2847 - Added url escaping for categorie.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2847 - Fix html escaping in categorie.tmpl (more needed)
Cory Jaeger [Sun, 19 Apr 2009 22:41:55 +0000 (17:41 -0500)]
Bug 2847 - Fix html escaping in categorie.tmpl (more needed)

Added escape="html" to several TMPL_VAR tags which need it in order
to deal with quotes and other special chars in user supplied data.
Many other templates still need to have escaping added to fields which
allow free form entry.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix Bug #2925
Nicole Engard [Sun, 19 Apr 2009 15:46:16 +0000 (10:46 -0500)]
Fix Bug #2925

This patch fixes the language issue on the serial full
display on the OPAC by changing 'waited' to 'waiting'.

In addition I have made it so that the Date Received
only shows if the item is 'Available'

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFixing xhtml errors
Chris Cormack [Sun, 19 Apr 2009 14:00:05 +0000 (02:00 +1200)]
Fixing xhtml errors

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoPartial fix for Bug #3139
Nicole Engard [Sun, 19 Apr 2009 13:42:04 +0000 (08:42 -0500)]
Partial fix for Bug #3139

Standardized all references to Address and Zip/Postal Code.

Also fixed bug #3138 by making the Alt address ready City, State.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for Bug 3136, Show hold/send/tag links for lists even for non-logged-in users
Owen Leonard [Sat, 18 Apr 2009 22:22:41 +0000 (17:22 -0500)]
Fix for Bug 3136, Show hold/send/tag links for lists even for non-logged-in users

The patch adds link to "send list" and the text "Log in to place holds or add tags" (with link, similar to the log in message users see in the global lists menu).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoModification on Bug # 3102 - "Location" instead of "Localization"
Brendan A. Gallagher [Sat, 18 Apr 2009 23:15:47 +0000 (19:15 -0400)]
Modification on Bug # 3102 - "Location" instead of "Localization"

This a change to previous patch for Bug #3102 (That has been pushed to head).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofir for #2338
Paul Poulain [Sat, 18 Apr 2009 23:37:32 +0000 (01:37 +0200)]
fir for #2338

When I go to serials/claims.pl, "All Suppliers (2)" is selected in the supplier
dropdown list, and no missing issues are listed. When I choose another supplier
from that list ("Supplier 1 (2)"), then two missing issues are listed. Should
"All Suppliers" instead read "Choose a Supplier" ?

chris: I think it might be safe to remove the all suppliers option all together as its
doing nothing

paul: agreed, this patch removes the All Supplier line, that is useless, confusing & untranslatable

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix for 2336
Paul Poulain [Sat, 18 Apr 2009 23:24:05 +0000 (01:24 +0200)]
fix for 2336

When you put a library in a group it doesn't show on the details list.  The
details list has a properties column that maybe is supposed to be used for this
since there doesn't appear to be any other use for it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix for #1731
Paul Poulain [Sat, 18 Apr 2009 23:04:23 +0000 (01:04 +0200)]
fix for #1731

The "place hold" button is hidden in detail.pl when there are no items or the
items are not for loan. MARC detail should do the same.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for 2363
Paul Poulain [Sat, 18 Apr 2009 21:46:24 +0000 (23:46 +0200)]
Fix for 2363

There is a comma at the beginning that shouldn't be there and then there are
commas in the vol, no combo making it hard to read.  it should be something
like this:

Vol 28, No 7; Vol 28, No 8; Vol 28, No 9

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoNew developer added to the history
Chris Cormack [Sat, 18 Apr 2009 21:44:29 +0000 (09:44 +1200)]
New developer added to the history

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUpdate for bug 1545 allowing for the title to be edited
Chris Cormack [Sat, 18 Apr 2009 21:44:30 +0000 (09:44 +1200)]
Update for bug 1545 allowing for the title to be edited

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3141: use quoted printable encoding in cart/list emails
Galen Charlton [Sat, 18 Apr 2009 23:25:42 +0000 (18:25 -0500)]
bug 3141: use quoted printable encoding in cart/list emails

Ensure that emails sent from lists and the cart in the
OPAC have the correct quoted-printable encoding.  Otherwise,
if there is an equals sign followed by one or two characters
that look like hexadecimal digits in body of the email, the
results can look mangled in some email clients.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoSetting focus on form fields
Owen Leonard [Sat, 18 Apr 2009 21:45:22 +0000 (16:45 -0500)]
Setting focus on form fields

This patch includes an addition to the OPAC's default js (identical to one in the staff client) which lets you add a "focus" class to an element on the page and have javascript move the focus to that element (input or link).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoChange typo Localisation to Localization for Bug # 3102
Brendan A. Gallagher [Sat, 18 Apr 2009 20:42:30 +0000 (16:42 -0400)]
Change typo Localisation to Localization for Bug # 3102

[RM note: I think there are a few people who wouldn't
 call "localisation" a typo - such as our UK, NZ,
 Australian, etc. contributors ;-) ].  That said,
 I'm pushing this patch to consistent with the
 general trend of the English varient used on the
 /prog/ templates.  There's no implication that en_US
 is the "correct" version of the language.]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix for #946
Paul Poulain [Sat, 18 Apr 2009 21:01:01 +0000 (23:01 +0200)]
fix for #946

A member returns a book : it would be better to see the category of this member
in "information member" near his name.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdded Koha 3 Manual Release
Nicole Engard [Sat, 18 Apr 2009 20:21:21 +0000 (15:21 -0500)]
Added Koha 3 Manual Release

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoRepair the old repairmissingbiblionumbers script
Nahuel ANGELINETTI [Sat, 18 Apr 2009 19:58:32 +0000 (21:58 +0200)]
Repair the old repairmissingbiblionumbers script

This patch refound all the script which fix all records without any biblionumber.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3013 Fix for 007 value builder to include all material types
Jane Wagner [Sat, 18 Apr 2009 19:53:04 +0000 (15:53 -0400)]
Bug 3013 Fix for 007 value builder to include all material types

Delivered version only had Text material type; this patch includes
all 14 material types with appropriate values for each.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAllowing users to edit saved sql in guided reports. Bug 1545
Chris Cormack [Sat, 18 Apr 2009 17:59:55 +0000 (05:59 +1200)]
Allowing users to edit saved sql in guided reports. Bug 1545

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix for #908
Paul Poulain [Sat, 18 Apr 2009 19:32:43 +0000 (21:32 +0200)]
fix for #908

In an list of autorised values (Parameters >autotised values), if you delete an
autorised value after confirm, you go back to the first page of the list, and
you must return manually to the page you left before.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix for #918
Paul Poulain [Sat, 18 Apr 2009 19:34:40 +0000 (21:34 +0200)]
fix for #918

In authorities, you can create frameworks like for biblio.
But in these it's impossible to delete useless fields, because when you click on
delete button, you go back to the default framework.
SO if you confirm your deletion, it delete your field in the default framework
and so in all the framwork (I think...).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3132: Reformatting guarantor entry based on C vs. P patron types
Owen Leonard [Sat, 18 Apr 2009 19:42:10 +0000 (14:42 -0500)]
Bug 3132: Reformatting guarantor entry based on C vs. P patron types

Professional patrons might have Organizations as guarantors, so display the guarantor entry form with a single line labelled appropriately. For Child patrons display the form fields as before.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3133 - correct typos
Joe Atzberger [Sat, 18 Apr 2009 17:43:06 +0000 (12:43 -0500)]
Bug 3133 - correct typos

This corrects 3 typographical errors.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup to 3004 - fix typo
Galen Charlton [Sat, 18 Apr 2009 17:12:06 +0000 (12:12 -0500)]
followup to 3004 - fix typo

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3004) fix the opac authority search
Nahuel ANGELINETTI [Wed, 4 Mar 2009 14:42:01 +0000 (15:42 +0100)]
(bug #3004) fix the opac authority search

This patch modify the way to transfer the different args, don't use the form arrays.
And use a GET form instead of POST(we are getting datas, sending nothing).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoRemoving duplicate email form field. Fixes Bug 3010.
Owen Leonard [Sat, 18 Apr 2009 16:21:43 +0000 (11:21 -0500)]
Removing duplicate email form field. Fixes Bug 3010.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoremove last reference to deprecated syspref noOPACUserLogin
Galen Charlton [Sat, 18 Apr 2009 15:39:41 +0000 (10:39 -0500)]
remove last reference to deprecated syspref noOPACUserLogin

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2958: fix search results navigation for CCL, CQL, and PQF queries
Galen Charlton [Thu, 9 Apr 2009 14:55:41 +0000 (09:55 -0500)]
bug 2958: fix search results navigation for CCL, CQL, and PQF queries

The shortcut to build $query_cgi in C4::Search::buildQuery()
for CCL, CQL, and PQF queries is incorrect, as (for now)
the "q=" prefix is required.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoHistory docs
Chris Cormack [Sat, 18 Apr 2009 14:34:27 +0000 (02:34 +1200)]
History docs

Squashed commit of the following:

commit 143a24041dd1988e025458ccb285a64809640f45
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Apr 19 01:48:35 2009 +1200

    Updating indian news

commit 21e518389b99acd038a5f0f5a3819e66bfc32062
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Fri Apr 17 04:43:41 2009 +1200

    Adding more dehli public library news

commit a610f13cabf07d4de44e6b841be57e391301d0f3
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Thu Apr 16 02:41:48 2009 +1200

    More history work from the devel list

commit 8d7f33c548600177a2b55f46a53f9828238c6e05
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Apr 12 22:24:40 2009 +1200

    Added translation information

commit c1d20eb095275904a01090f278356ee6c1b77f71
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Apr 12 21:07:46 2009 +1200

    Up to March 2006 on the devel list

commit 45b9ea49220dc350d684e5fe175062dfc95d146c
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sat Apr 11 21:39:14 2009 +1200

    Up to August 2005 on the devel list

commit 2788b21f1efb9ace2e23cabfbd82bfc27868ab33
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sat Apr 11 20:21:01 2009 +1200

    Adding tags

commit f3b26c2eccc86a0616c5e98cedeee68ce5662abb
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sat Apr 11 20:05:03 2009 +1200

    Last little fix

commit f5e778278e9483c9ee4be24fa95692079a5ccbb4
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sat Apr 11 19:55:17 2009 +1200

    More formatting

commit 83ea369a4e0c5cb6141cf0b2dc104e0e9d0b1761
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sat Apr 11 19:32:08 2009 +1200

    Formatting tweaks

commit f5c6709268f216b52826a45f427258717e011777
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sat Apr 11 19:20:40 2009 +1200

    Tab separated text

commit 6a80241a9a77b79b4d3ab8881f0b91217d8238a5
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sat Apr 11 17:30:07 2009 +1200

    Up to May 2005 on the devel list

commit 6ea5ec539e023d3652ed097467c65f81257a2146
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sat Apr 11 16:07:30 2009 +1200

    Up to october 2003 on th devel list

commit 8e0d72b86c2da276d1fc5731e69974b135c047f2
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sat Apr 11 10:49:59 2009 +1200

    Now up to February 2003 on the devel list

commit aedcfd1c66fe2bd61c5bc5cb0aa3ae9e446d356c
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sat Apr 11 09:34:32 2009 +1200

    Adding history about paul

commit cb728d09ee3024abb3d98cca90f68514e9a6e14e
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sat Apr 11 08:41:51 2009 +1200

    Typo fix

commit 9f515f9df0450a9a797bb0abb68233eddb2d15ef
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Fri Apr 10 21:43:35 2009 +1200

    Done up to October 2002 on the devel list

commit 87382c7d2c2fb05b23eedb0840a94b729f211d16
Author: Chris Cormack <chris@deb-lap.(none)>
Date:   Fri Apr 10 20:31:22 2009 +1200

    Up to june 2002 on the developer list

commit 75d24ed5f05c45ea7c25e2c8623bec114c35ce81
Author: Chris Cormack <chris@deb-lap.(none)>
Date:   Fri Apr 10 18:47:21 2009 +1200

    Adding information from the devel list

commit 4ab492672feab94cabc2337f1c8ef01e588c90f6
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Wed Apr 8 08:47:31 2009 +1200

    Adding date for biblibre

commit 4a0153d1dbd5abdf289f9e842c8e60908286c66a
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Tue Apr 7 22:39:23 2009 +1200

    Finished the main mailing list and the announce list, working on the translate list now

commit 4c99f3809ce2539d8c2312ad76bc533ebe2a0fdf
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Tue Apr 7 21:03:07 2009 +1200

    Fixing typo

commit ad5f8685529503da0a4a214fc900a9b2fd9a880a
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Tue Apr 7 20:47:00 2009 +1200

    Adding biblibre, fixing rfp history

commit 0be5d854db10eb2d1710a940c141c1689e3e226a
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Tue Apr 7 19:47:59 2009 +1200

    More history work

commit 2b423736e5e343fbf5abe84e6e1055541bb2a7c3
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Tue Apr 7 07:04:30 2009 +1200

    Fixing dates for OLC

commit 5065f400dc369531725bfe4469b115a168110f52
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Mon Apr 6 22:07:07 2009 +1200

    More work on the history

commit d5dd62629bddded528edf5b99e1b316554ff3138
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Mon Apr 6 20:18:03 2009 +1200

    Finished committers history

commit d707b19d04f094239d0300b6a0a296b7ac93c799
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Mon Apr 6 19:57:07 2009 +1200

    Finishing off committer history

commit b15d07d0c8f299d719365dd087e98066beee19a9
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Apr 5 21:38:39 2009 +1200

    VCS history for 2007

commit 47e69aa34409389d8c203e35b70a1480351705ef
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Apr 5 21:30:21 2009 +1200

    VCS and main mailing list history for 2006

commit 3e45921c5fee7a122e745d025524970a11ef9b09
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Apr 5 20:07:26 2009 +1200

    Continuing on with the History

commit f8719ebb2bde3871c45de9b043f0260b5bd810d7
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Apr 5 19:14:08 2009 +1200

    Adding links to computerworld articles

commit 500370aa98b869edb0b0b36ca7af5a8b094f515b
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Apr 5 18:59:30 2009 +1200

    2005 vcs and main mailing list history

commit f6fad5cfba85aa4213038ce301cc84436f76df2f
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Apr 5 07:59:18 2009 +1200

    Up to June 2005

commit 43d40046e0fb9baf75b58c769632bc99346295cb
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Thu Apr 2 22:05:33 2009 +1300

    Working on 2005

commit f15da9231fffecbe2b6d35c53e9e1adf370222c1
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Thu Apr 2 09:33:09 2009 +1300

    More history work

commit 93174bbd9bde579c91a3bc49976faf118a83da52
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Tue Mar 31 22:04:56 2009 +1300

    More history

commit f2fd3c6d74ef4489100401bbbf936df1efa16d19
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Tue Mar 31 18:55:08 2009 +1300

    More 2004

commit a17646986b0abf99b121309e22fce299449a3cc4
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Tue Mar 31 18:27:29 2009 +1300

    Working on 2004

commit 5886fae2d293f801ed436a3efa8660966a31ba3e
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Tue Mar 31 13:52:07 2009 +1300

    Continuing on with the history updates

commit 1f64c51abf414d8432280023e72d5f191961a8a0
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Tue Mar 31 09:02:25 2009 +1300

    More history

commit c20b84d7d42b7774d8c5ab7f20a54f6314e4f30c
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Tue Mar 31 13:48:49 2009 +1300

    formatting fix

commit 7698ba607429e502126ccf2df1e9e9a4755fa448
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Mon Mar 30 22:02:12 2009 +1300

    And even more history

commit cac079f7541e9276710dc778527ea9c84e8d185a
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Mon Mar 30 21:45:36 2009 +1300

    COntinuing on

commit ce7402c7dbcf01483f9905b4eb75f1d89568e0d8
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Mon Mar 30 21:05:27 2009 +1300

    Continuing on

commit 3dcd055d4640160a54e88d8c6519785a390a93a7
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Mon Mar 30 20:44:41 2009 +1300

    Continuing on the history

commit cf07159fd8d400750d1878213fab7b01b45c5197
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Mon Mar 30 20:33:28 2009 +1300

    More history updates

commit a3c31379e115e9aeab44c752126f6f4878c3bf15
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Mar 29 23:16:52 2009 +1300

    More history

commit 831a385489a90f750cc760e18b598339c02aa620
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Mar 29 22:53:25 2009 +1300

    Continuing on

commit 26e38756019023dfd928538553fdf95311eee4ed
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Mar 29 22:15:11 2009 +1300

    More doc

commit bb13ea869d83f4493dc53041a0894880a5fefd66
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Mar 29 21:54:50 2009 +1300

    Continuing work on the history doc

commit 69aff74445eac3c260c081cb63e403c1025b7950
Author: Chris Cormack <chris@bigballofwax.co.nz>
Date:   Sun Mar 29 21:37:37 2009 +1300

    History documentation

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3100: increase width of alternate postal code
Galen Charlton [Thu, 9 Apr 2009 15:31:45 +0000 (10:31 -0500)]
bug 3100: increase width of alternate postal code

The alternative postal code input on the patron
editing form was only permitted 5 characters of
input.  Increase this to 10 to match the
primary zipcode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMulti-bug fix - SetMarcUnicodeFlag for records coming from Koha
Joe Atzberger [Thu, 9 Apr 2009 16:50:47 +0000 (11:50 -0500)]
Multi-bug fix - SetMarcUnicodeFlag for records coming from Koha

This has bearing on bugs 2905, 2665, 2514 and other "wide character" crashes
related to diacritics and Unicode.  This should help open the door for reliable
input of diacriticals via acquisitions.

MARC21_utf8_flag_fix.pl diagnoses and fixes existing problems with MARC data
affected by the bug.

Adding SetMarcUnicodeFlag to TransformKohaToMarc prevents the bug from corrupting
further data.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoTweak perldoc (--help) for leader_fix.pl
Joe Atzberger [Tue, 7 Apr 2009 22:37:56 +0000 (17:37 -0500)]
Tweak perldoc (--help) for leader_fix.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoScript to repair MARC21 leader/09.
Joe Atzberger [Fri, 3 Apr 2009 20:42:20 +0000 (15:42 -0500)]
Script to repair MARC21 leader/09.

Acquisitions process seems to be adding records with incorrect
representation of the MARC encoding in leader/09.  It should be
'a' meaning UTF-8, for all Koha's internalized records, but in
many cases it appears blank (for MARC-8).  This script diagnoses
and repairs the value in the leader, depending on runtime options.

The symptom of this problem is that high-value UNICODE characters
in the record will cause Koha to crash whenever it tries to parse
the MARCXML, giving a "Wide character" fatal.  While we work on
fixing the input, this script will fix the existing data.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix syntax error in fr-FR sysprefs SQL
Galen Charlton [Sat, 18 Apr 2009 13:37:40 +0000 (08:37 -0500)]
fix syntax error in fr-FR sysprefs SQL

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug: unescaped single-quote in french sys. prefs. sql file
Michael Hafen [Mon, 13 Apr 2009 21:53:42 +0000 (15:53 -0600)]
bug: unescaped single-quote in french sys. prefs. sql file

The description for autoBarcode had an unescaped single-quote.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoRe-insert useldapserver into koha-conf.xml
Joe Atzberger [Mon, 13 Apr 2009 22:05:49 +0000 (17:05 -0500)]
Re-insert useldapserver into koha-conf.xml

This doesn't insert the large and typically unused <ldapserver> block,
just the switch with a comment pointing to C4::Auth_with_ldap.  This otherwise
was undocumented requirement, making LDAP config a bit of a shot in the dark.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoremove last reference to deprecated syspref NoReturnSetLost
Galen Charlton [Tue, 14 Apr 2009 13:51:08 +0000 (08:51 -0500)]
remove last reference to deprecated syspref NoReturnSetLost

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3110 - Move Serial Preferences to Serials Tab
John Beppu [Tue, 14 Apr 2009 19:45:15 +0000 (14:45 -0500)]
bug 3110 - Move Serial Preferences to Serials Tab

- Moved the following system preferences to the Serials tab:
  OPACDisplayExtendedSubInfo
  OPACSubscriptionDisplay
  RenewSerialAddsSuggestion
  SubscriptionHistory

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCorrected: fix for Bug 3112, Emailed list contains too much whitespace
Owen Leonard [Tue, 14 Apr 2009 19:46:58 +0000 (14:46 -0500)]
Corrected: fix for Bug 3112, Emailed list contains too much whitespace

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBut 3117 : fix typo in C4::Matcher causing compilation failure.
Ryan Higgins [Wed, 15 Apr 2009 17:23:21 +0000 (10:23 -0700)]
But 3117 : fix typo in C4::Matcher causing compilation failure.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoqualify warn; sort_by is not a required search parameter
Galen Charlton [Wed, 8 Apr 2009 20:13:12 +0000 (15:13 -0500)]
qualify warn; sort_by is not a required search parameter

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix various warnings
Galen Charlton [Wed, 8 Apr 2009 20:34:45 +0000 (15:34 -0500)]
fix various warnings

* Use of uninitialized value in pattern match (m//) at C4/Biblio.pm line 1305
  (displaying MARC21 856s that don't have $3)
* Use of uninitialized value in multiplication (*) at catalogue/detail.pl line 243.
  (attemping to calculate average Amazon rating if no Amazon info
   is available)
* opac-detail.pl: Use of uninitialized value in length at C4/External/Amazon.pm line 90
  (attempting to calculate length of $isbn if it happens to be undef)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3099: fix copying patron info to deletedborrowers (DB rev 018)
Galen Charlton [Wed, 8 Apr 2009 20:52:05 +0000 (15:52 -0500)]
bug 3099: fix copying patron info to deletedborrowers (DB rev 018)

Fixes the following problem:

When deleting a patron record via the intranet or the cleanborrowers tool,
patron records are deleted but are not copied to deletedborrowers.
C4::Members::MoveMemberToDeleted() fails with the following error:

deletemem.pl: DBD::mysql::st execute failed: Column count doesn't match value
count at row 1 at C4/Members.pm line 1672.,

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3051) bad support of pagination in auth_finder
Nahuel ANGELINETTI [Mon, 23 Mar 2009 12:02:14 +0000 (13:02 +0100)]
(bug #3051) bad support of pagination in auth_finder

This patch change the page to use GET instead of post, and use independants "input"
names for searched values. Else the args are not passed to the next page due to
rewrite rules.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3049: display correct due date of renewed loans
Galen Charlton [Wed, 8 Apr 2009 19:46:01 +0000 (14:46 -0500)]
bug 3049: display correct due date of renewed loans

The intranet item display provided by moredetail.pl
would display the original due date of the item, and
would thus be incorrect if the item had been renewed
and got a different due date.

The incorrect date was coming from items.onloan,
which AddIssue() sets to the due date.  This patch
fixes the bug in two ways:

[1] AddRenewal() now updates items.onloan with the
    correct due date.
[2] Two templates were updated to display the
    due date from (indirectly) issues.date_due
    instead of items.onloan, thus making it less
    likely that the wrong value will be displayed.

This patch does *not* update items.onloan to reflect
the correct due date.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2915) C4::Biblio::DelBiblio delete the serials
Nahuel ANGELINETTI [Fri, 6 Mar 2009 10:37:55 +0000 (11:37 +0100)]
(bug #2915) C4::Biblio::DelBiblio delete the serials

This patch add the serials deletion in DelBiblio function, so now when a record is deleted all attached serials will be too.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2919 -- fix value_builder plugins for dateaccessioned, barcode
Joe Atzberger [Thu, 5 Feb 2009 19:04:20 +0000 (13:04 -0600)]
Bug 2919 -- fix value_builder plugins for dateaccessioned, barcode

This patch depends on my previous one "Begin cleanup on additem" and
fixes one bug introduced in that patch.

Overhaul of additem sections to factor out common pieces especially attributes.
Plugin js vastly simplified and reimplemented in jquery.  Performance improved.

Note that a particularly busy cataloging department should still leave
barcode blank for server-side autopopulation to avoid collision.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBegin cleanup on additem.
Joe Atzberger [Wed, 21 Jan 2009 01:18:21 +0000 (19:18 -0600)]
Begin cleanup on additem.

REFACTOR logic out of conditional branches when the assignment ($nextop) is the same.
Be sure to EXIT after printing a redirect, instead of wasting clock filling in the
template for a process the user will never see.  Remove  the now inapplicable logic for
differentiation between "/cgi-bin" and "non /cgi-bin" installations.  There is no
longer any /cgi-bin in the actual directory file path.

This does not fix the value_builder js errors like "Blurbarcode52251 is not defined",
but it does not cause them either (see Bug 2919).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMinor markup corrections for validity.
Owen Leonard [Wed, 8 Apr 2009 18:39:37 +0000 (13:39 -0500)]
Minor markup corrections for validity.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>