koha.git
12 years agoDelete unused function
Nahuel ANGELINETTI [Wed, 23 Sep 2009 09:38:51 +0000 (11:38 +0200)]
Delete unused function

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 3661 XSLT fixes
Jane Wagner [Thu, 24 Sep 2009 14:57:40 +0000 (10:57 -0400)]
Bug 3661 XSLT fixes

The XSLT results list (MARC21slim2OPACResults.xsl) did not have any separators between multiple 246 fields, so additional titles all ran together.  I added the standard semicolon or period as in other repeating fields.

The display for personal and corporate authors was also confusing.  The period after the last personal author (100/700) is very hard to see, so the display looked like the first corporate author only belonged to/was associated with the last personal author, rather than being a separate author entry.  I've added a dash at the beginning of any 110/710 entries to set off the corporate authors a bit in the display.

I added the same code to insert a dash before any 111/711 (Meeting author) as well.

This patch also adds missing text labels for text_list_bullets.png
(bibliography) and remote.png (available online).

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoMinor markup tweak and correction
Owen Leonard [Thu, 17 Sep 2009 13:44:28 +0000 (08:44 -0500)]
Minor markup tweak and correction

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoMinor interface tweaks and markup corrections.
Owen Leonard [Thu, 24 Sep 2009 16:06:16 +0000 (11:06 -0500)]
Minor interface tweaks and markup corrections.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoInterface tweaks and markup corrections.
Owen Leonard [Thu, 24 Sep 2009 16:13:02 +0000 (11:13 -0500)]
Interface tweaks and markup corrections.

Includes JavaScript to automatically change field labels based on which unit of measurement has been chosen.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoInterface tweaks and markup corrections.
Owen Leonard [Thu, 24 Sep 2009 18:20:54 +0000 (13:20 -0500)]
Interface tweaks and markup corrections.

Includes JavaScript to automatically change field labels based on which unit of measurement has been chosen.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoMinor markup and interface tweaks fo "Edit Label Layout"
Owen Leonard [Thu, 24 Sep 2009 19:54:28 +0000 (14:54 -0500)]
Minor markup and interface tweaks fo "Edit Label Layout"

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoMarkup corrections and other minor changes.
Owen Leonard [Fri, 25 Sep 2009 14:15:30 +0000 (09:15 -0500)]
Markup corrections and other minor changes.

- Clarifying error message
- Hiding batch action buttons when batch is empty

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoMarkup tweaks and corrections for label search window.
Owen Leonard [Fri, 25 Sep 2009 14:25:12 +0000 (09:25 -0500)]
Markup tweaks and corrections for label search window.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoCorrections to ensure message list appears in the proper box (Bug 3668).
Owen Leonard [Fri, 25 Sep 2009 18:54:11 +0000 (13:54 -0500)]
Corrections to ensure message list appears in the proper box (Bug 3668).

The patch sets a "flagged" variable for displaying the messages correctly, bringing it in line with the way other messages are displayed. The patch also includes some markup tweaks and a change to make display of the "add message" link javascript-dependent.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoImplementation of OPAC Message formatting
Kyle M Hall [Mon, 28 Sep 2009 13:45:30 +0000 (09:45 -0400)]
Implementation of OPAC Message formatting

This patch implements the suggestions about the new and old message system made by Owen Leonard.

Includes type fix pointed out by Owen.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoCorrecting references in the OPAC to files in intranet-tmpl (Bug 3574).
Owen Leonard [Tue, 29 Sep 2009 14:44:17 +0000 (09:44 -0500)]
Correcting references in the OPAC to files in intranet-tmpl (Bug 3574).

Adds greybox library to OPAC files, corrects reference to icons in intranet-tmpl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoUpdated help files
Nicole Engard [Tue, 22 Sep 2009 14:09:35 +0000 (10:09 -0400)]
Updated help files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoUpdated help files.
Nicole Engard [Tue, 22 Sep 2009 12:08:24 +0000 (08:08 -0400)]
Updated help files.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoSilence extraneous messages when in batch mode on build_browser_and_cloud.pl
J. David Bavousett [Fri, 18 Sep 2009 13:49:40 +0000 (09:49 -0400)]
Silence extraneous messages when in batch mode on build_browser_and_cloud.pl

The script already has a param -b for batch mode, which should silence informational
messages, but it missed a couple.  This patch fixes that.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 2505: Enabled warnings in members/messaging.pl and readingrec.pl.
Garry Collum [Mon, 21 Sep 2009 23:27:28 +0000 (19:27 -0400)]
Bug 2505: Enabled warnings in members/messaging.pl and readingrec.pl.

Fixed any warnings that appeared in the logs.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 2505: Enabled warnings in members/patronimage.pl and setdebar.pl.
Garry Collum [Tue, 22 Sep 2009 23:22:58 +0000 (19:22 -0400)]
Bug 2505: Enabled warnings in members/patronimage.pl and setdebar.pl.

Fixed resulting warnings after warnings was enabled.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 2505: Added warnings to members/members-home.pl and members/setstatus.pl
Garry Collum [Thu, 24 Sep 2009 15:47:17 +0000 (11:47 -0400)]
Bug 2505: Added warnings to members/members-home.pl and members/setstatus.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 2505: Enables warnings in members/mancredit.pl and maninvoice.pl
Garry Collum [Thu, 24 Sep 2009 17:18:49 +0000 (13:18 -0400)]
Bug 2505: Enables warnings in members/mancredit.pl and maninvoice.pl

Fixes resulting warnings.

Also corrects a couple of minor typos.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 2505: Enables warnings in member-flags.pl, member-password.pl, and member-picuplo...
Garry Collum [Thu, 24 Sep 2009 20:05:07 +0000 (16:05 -0400)]
Bug 2505: Enables warnings in member-flags.pl, member-password.pl, and member-picupload.pl.

No warnings were generated in testing after warnings were enabled.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoMerge commit 'workbuffer.org-koha/translation' into to-push
Galen Charlton [Tue, 29 Sep 2009 22:57:43 +0000 (18:57 -0400)]
Merge commit 'workbuffer.org-koha/translation' into to-push

[3.2 translation work]

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBUG 3675: Untranslatable strings in opac-basket.tmpl
Katrin Fischer [Tue, 29 Sep 2009 19:51:45 +0000 (21:51 +0200)]
BUG 3675: Untranslatable strings in opac-basket.tmpl

Makes 'Place Hold' and 'Tag' translatable.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBUG 3380 Show serial enumeration on opac holds screen
Katrin Fischer [Sun, 27 Sep 2009 21:24:22 +0000 (23:24 +0200)]
BUG 3380 Show serial enumeration on opac holds screen

Shows column Vol Info if serial enumeration is used for one of the items.
Replaces first patch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoGerman updates
Chris Cormack [Fri, 25 Sep 2009 21:30:37 +0000 (09:30 +1200)]
German updates

12 years agoFixing typo in MARC21slim2OPACResults.xsl
Chris Cormack [Wed, 23 Sep 2009 09:47:55 +0000 (21:47 +1200)]
Fixing typo in MARC21slim2OPACResults.xsl

12 years agoGerman updates for 3.2
Chris Cormack [Sun, 20 Sep 2009 18:41:26 +0000 (06:41 +1200)]
German updates for 3.2

12 years agoLast of the language updates
Chris Cormack [Sun, 20 Sep 2009 09:29:43 +0000 (21:29 +1200)]
Last of the language updates

12 years agoContinuing on with updates
Chris Cormack [Sun, 20 Sep 2009 09:14:51 +0000 (21:14 +1200)]
Continuing on with updates

12 years agoContinuing updating po files
Chris Cormack [Sun, 20 Sep 2009 08:53:42 +0000 (20:53 +1200)]
Continuing updating po files

12 years agoUpdating po files for 3.2
Chris Cormack [Sun, 20 Sep 2009 08:46:52 +0000 (20:46 +1200)]
Updating po files for 3.2

12 years agoMore new language files for 3.2
Chris Cormack [Sun, 20 Sep 2009 08:34:43 +0000 (20:34 +1200)]
More new language files for 3.2

12 years agoGetting languages ready for 3.2
Chris Cormack [Sun, 20 Sep 2009 08:09:18 +0000 (20:09 +1200)]
Getting languages ready for 3.2

12 years agoGerman updates for 3.2
Chris Cormack [Sun, 20 Sep 2009 06:19:01 +0000 (18:19 +1200)]
German updates for 3.2

12 years agoUpdates for 3.2.x - French OPAC
Chris Cormack [Sun, 30 Aug 2009 02:29:39 +0000 (14:29 +1200)]
Updates for 3.2.x - French OPAC

12 years agoMaori updated for 3.2.x
Chris Cormack [Sun, 30 Aug 2009 02:09:24 +0000 (14:09 +1200)]
Maori updated for 3.2.x

12 years agoGerman Opac updates
Chris Cormack [Sat, 29 Aug 2009 22:05:19 +0000 (10:05 +1200)]
German Opac updates

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
12 years agoEnglish NZ variant translations for 3.2
Chris Cormack [Sat, 29 Aug 2009 20:56:36 +0000 (08:56 +1200)]
English NZ variant translations for 3.2

12 years agoGerman Intranet template updates
Chris Cormack [Sat, 29 Aug 2009 20:45:57 +0000 (08:45 +1200)]
German Intranet template updates

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
12 years agoGerman Translations for 3.2 updated
Chris Cormack [Sat, 29 Aug 2009 20:37:54 +0000 (08:37 +1200)]
German Translations for 3.2 updated

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
12 years agoFixing a syntax error in german opac .po file
Chris Cormack [Sun, 16 Aug 2009 10:04:17 +0000 (22:04 +1200)]
Fixing a syntax error in german opac .po file

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
12 years agoGerman translation updates
Chris Cormack [Sun, 16 Aug 2009 08:19:02 +0000 (20:19 +1200)]
German translation updates

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
12 years agoBug-3098-Bug-3108-Bug-3545 revision to XSLT syspref patch
Jane Wagner [Wed, 16 Sep 2009 15:15:55 +0000 (11:15 -0400)]
Bug-3098-Bug-3108-Bug-3545 revision to XSLT syspref patch

The patch I sent earlier repeated a line having to do with the count of items, which mean the count was now doubling (2 items instead of 1, 4 instead of 2, etc.).  This patch removes the first, now superflous line of $xmlrecord =~ s/\<\/record\>/$itemsxml\<\/record\>/;

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 3416: Fixes filter on parcels.tmpl.
Garry Collum [Sun, 12 Jul 2009 01:33:31 +0000 (21:33 -0400)]
Bug 3416: Fixes filter on parcels.tmpl.

Changes the action of the form on parcels.tmpl from "post" to "get."  Otherwise the filter is not functional.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 3415: Adds highlighting to tables in parcel.tmpl
Garry Collum [Sat, 11 Jul 2009 22:18:49 +0000 (18:18 -0400)]
Bug 3415: Adds highlighting to tables in parcel.tmpl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 3414: Cleanup and xhthml correction of parcels.tmpl
Garry Collum [Sat, 11 Jul 2009 20:49:11 +0000 (16:49 -0400)]
Bug 3414: Cleanup and xhthml correction of parcels.tmpl

Fixes several xhtml in parcels.tmpl and enables highlighting within its data table.  Removes unnecessary variable from parcels.pl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agobug 3436: tweak cache settings for patron images
Galen Charlton [Wed, 16 Sep 2009 11:44:39 +0000 (07:44 -0400)]
bug 3436: tweak cache settings for patron images

Per suggestion by Joe Atzberger.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoDB rev 061: added ShowPatronImageInWebBasedSelfCheck (bug 3436)
Galen Charlton [Wed, 16 Sep 2009 11:43:18 +0000 (07:43 -0400)]
DB rev 061: added ShowPatronImageInWebBasedSelfCheck (bug 3436)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agobug 3436: improve error messages in self-check
Galen Charlton [Wed, 22 Jul 2009 21:43:43 +0000 (16:43 -0500)]
bug 3436: improve error messages in self-check

Improved the error messages displayed to users
by web-based self-checkout when a problem with
a loan occurs.

This changed was sponsored by the Plano Independent
School District.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agobug 3436: enhance sorting of loans (self-check)
Galen Charlton [Wed, 22 Jul 2009 21:43:42 +0000 (16:43 -0500)]
bug 3436: enhance sorting of loans (self-check)

[1] Change the default sort order of checked out
    items to have the most recent loans displayed
    first.

[2] Add the ability (via jQuery tablesorter) for
    the user to sort the list of loans.

Also fixed the formatting of the due date.

This change was sponsored by the Plano Independent School
District.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agobug 3436: add patron images to web self-check
Galen Charlton [Wed, 22 Jul 2009 21:43:41 +0000 (16:43 -0500)]
bug 3436: add patron images to web self-check

Adds a new system preference, ShowPatronImageInWebBasedSelfCheck;
if this preference is ON, a patron's image is displayed
if available when using web-based self-check.

Note: a patch for updatedatabase.pl will be made when this
change is ready to push.

This change is sponsored by the Plano Independent School
District.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoAdd predefined fee types
PTFS [Sat, 25 Jul 2009 09:22:51 +0000 (10:22 +0100)]
Add predefined fee types

Ability in system administration to define additional fee and fine options that appear in dropdown box
on the create manual invoice tab in patron fines.

To use create authorised values with the category MANUAL_INV,
Authorized Value is the description, and Description is the default fee, if any.

This work sponsered by East Brunswick Public Library, East Brunswick, NJ, USA

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
12 years agoEnsure op is defined in serials scripts
Colin Campbell [Wed, 16 Sep 2009 11:18:11 +0000 (12:18 +0100)]
Ensure op is defined in serials scripts

Set $op to an empty string if no value passed
otherwise the error-log fills with warnings on comparison

12 years agoDB rev 059->060
Galen Charlton [Wed, 16 Sep 2009 02:24:03 +0000 (22:24 -0400)]
DB rev 059->060

Bumped for new patron messaging feature.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoavoid error message since messages table does not exist yet
Galen Charlton [Wed, 16 Sep 2009 02:16:01 +0000 (22:16 -0400)]
avoid error message since messages table does not exist yet

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoNew Messaging System.
Colin Campbell [Sat, 25 Jul 2009 09:03:09 +0000 (10:03 +0100)]
New Messaging System.

This system is indended to replace the old opacnotes
  and borrowernotes fields in the borrowers table.
  This system allows an unlimited number of Libraran and OPAC notes to be
  attached to a borrower. Each note has a message, a message type,
  the data it was created, and which library created it.
  Each message can only be deleted by the library that created it unless the syspref
  AllowAllMessageDeletion has been set.

  This system may be used simultaneously with the old notes system and does not affect it in any way.

  A new database table (messages) was added for this feature.

  The System also allows for pre-defined notes for Borrower records

  To use these, just create authorised values with the category BOR_NOTES
  where the Authorized Value is the short description shown in the pulldown,
  and the description is the text that should be in the note.

  Original Author: PTFS Contractor <dbavousett@ptfs.com>

  This work co-sponsered by Middletown Township Public Library, Middletown, NJ, USA
     and East Brunswick Public Library, East Brunswick, NJ, USA

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
12 years agoDB rev 058->059 - add DisplayOPACiconsXSLT syspref
Galen Charlton [Wed, 16 Sep 2009 01:37:45 +0000 (21:37 -0400)]
DB rev 058->059 - add DisplayOPACiconsXSLT syspref

Pushing new new system preference DisplayOPACiconsXSLT created per bug 3545
as DB rev 059

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 3098, Bug 3108, Bug 3545 -- Make MARC21 XSLT obey sysprefs in OPAC
Jane Wagner [Sun, 23 Aug 2009 19:58:55 +0000 (15:58 -0400)]
Bug 3098, Bug 3108, Bug 3545 -- Make MARC21 XSLT obey sysprefs in OPAC

The MARC21slim2OPACDetail.xsl and MARC21slim2OPACResults.xsl XSLT
stylesheets do not obey any of the OPAC sysprefs, OPACURLOpenInNewWindow,
URLLinkText, or a new one added for Bug 3545, DisplayOPACiconsXSLT.
Modified C4/XSLT.pm based on code written by Fréric Demians (thanks!) to
pass the values of the sysprefs to the .xsl files.  Modified the .xsl
files to implement them.  If the respective sysprefs are set, the OPAC
results and display pages will/will not display the format/material
type/audience icons, will/will not open URLs in new browser windows,
and will/will not use the text entered in URLLinkText as generic link
text when there is no value in the 856 subfield y, 3, or z.  (Note that
if subfields y, 3, or z do contain text, the first match is what will be displayed.)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoFix for license statement on about page
Chris Cormack [Tue, 15 Sep 2009 22:49:16 +0000 (10:49 +1200)]
Fix for license statement on about page

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoUpdate some DBI interactions
Colin Campbell [Mon, 7 Sep 2009 16:31:28 +0000 (17:31 +0100)]
Update some DBI interactions

remove unnecessary calls to finish
let DBI return an array instead of looping to create one
make some SQL oneliners more succinct

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 2500 Correcting incorrect splitting of cutter numbers
Chris Nighswonger [Tue, 15 Sep 2009 13:27:13 +0000 (09:27 -0400)]
Bug 2500 Correcting incorrect splitting of cutter numbers

This patch does two things to improve the call number splitting algorithms:

1. It makes changes to ensure that cutter numbers are split correctly in ddcns

2. It moves custom/fiction/biography call number splitting to a separate algorithm.
    Before they were incorrectly placed in ddcns.

This patch also modifies the call number splitting tests to accept call numbers from the
command line to allow quick testing of any give call number against a particular algorithm.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoAvoid unnecessary warnings in reserve/modrequest.pl
Colin Campbell [Tue, 15 Sep 2009 13:06:39 +0000 (14:06 +0100)]
Avoid unnecessary warnings in reserve/modrequest.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agobug 3614 followup
Galen Charlton [Tue, 15 Sep 2009 13:19:57 +0000 (09:19 -0400)]
bug 3614 followup

* renamed default_ind_to_space to _default_ind_to_space
  as it is an internal function
* added calls to _default_ind_to_space in other places

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agobug 3614 Fix incorrect setting of indicator
Colin Campbell [Mon, 14 Sep 2009 18:26:47 +0000 (19:26 +0100)]
bug 3614 Fix incorrect setting of indicator

Pull the code into its own subr so that the dangers of
inaccurate copy & paste are avoided in future

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoupdated DB-dependent tests to reflect labels rewrite
Galen Charlton [Tue, 15 Sep 2009 12:57:53 +0000 (08:57 -0400)]
updated DB-dependent tests to reflect labels rewrite

* removed lib/KohaTest/Labels.pm, which is now completely outdated
* updated list of database tables to truncate in lib/KohaTest.pm

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agobumped up required version of Test::More
Galen Charlton [Tue, 15 Sep 2009 12:20:50 +0000 (08:20 -0400)]
bumped up required version of Test::More

Now requiring at least 0.80, the oldest version available
from CPAN, because use_ok tests were not being properly
accounted for in the test plan before 0.73.  This led
to a situation where a test script containing a use_ok test
that passes running under an earlier version of Test::More
would fail under a more recent one.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years ago(bug #3558) fix build_browser_and_cloud
Nahuel ANGELINETTI [Fri, 28 Aug 2009 21:47:50 +0000 (23:47 +0200)]
(bug #3558) fix build_browser_and_cloud

This patch, permit to take care of similar entries, if there is some diacritics or not.
(cherry picked from commit 776c177e3debedaf08fec65fbf8111675ccc93e7)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoinclude grace period when calculating overdue fine
Michael Hafen [Wed, 2 Sep 2009 20:14:59 +0000 (14:14 -0600)]
include grace period when calculating overdue fine

Before the grace period was not included in the number of days overdue when
calculating the fine.  My librarians seem to think the number of days overdue
should include the grace period.

Fine is not assessed before the grace period is up though.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoEnable warnings in serial scripts
Colin Campbell [Mon, 7 Sep 2009 12:03:10 +0000 (13:03 +0100)]
Enable warnings in serial scripts

Remove some superfluous variables
Simplify some loops over lists
Fix generated warnings
Strip whitespace from line endings

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoMoving css to correct location
Chris Nighswonger [Mon, 7 Sep 2009 14:27:11 +0000 (10:27 -0400)]
Moving css to correct location

See comments in commit b1197477d476ddaedec43392bdd92396b94b0852

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 3602: Fixes a log error for opac-search.pl if expanded_options is not defined.
Garry Collum [Sat, 12 Sep 2009 16:27:18 +0000 (12:27 -0400)]
Bug 3602: Fixes a log error for opac-search.pl if expanded_options is not defined.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 3603: Fixes XHMTL errors in catalogue/showmarc.tmpl
Garry Collum [Sun, 13 Sep 2009 14:41:43 +0000 (10:41 -0400)]
Bug 3603: Fixes XHMTL errors in catalogue/showmarc.tmpl

Missing <title> tags, missing </head> and <body>, extra </div>

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 3604: Fixes invalid XHTML in manage-marc-import.tmpl.
Garry Collum [Sun, 13 Sep 2009 15:08:35 +0000 (11:08 -0400)]
Bug 3604: Fixes invalid XHTML in manage-marc-import.tmpl.

Also adds zebra striping to <table>

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 3605: Fixes XHTML error in z3950_search.tmpl
Garry Collum [Sun, 13 Sep 2009 16:16:14 +0000 (12:16 -0400)]
Bug 3605: Fixes XHTML error in z3950_search.tmpl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 3606: fixes 'last 50 items only' link in members/readingrec.tmpl.
Garry Collum [Mon, 14 Sep 2009 02:15:31 +0000 (22:15 -0400)]
Bug 3606: fixes 'last 50 items only' link in members/readingrec.tmpl.

If a staff member clicked on 'Show all items' in a patron's reading record, and
then clicked on 'show last 50 items only,' all of the records would still be
shown.  The link for the 'last 50' items contains a switch for 'limit=full'
instead of 'limit=50'.

Also fixes some XHTML errors.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoAvoid potentially unnecessary database call in Auth
Michael Hafen [Mon, 14 Sep 2009 15:07:57 +0000 (09:07 -0600)]
Avoid potentially unnecessary database call in Auth

Auth, after verifying the session/logging in the user, calls to the database
to get the users borrowernumber.  This call is probably unnecessary because
borrowernumber is part of userenv.  Check userenv before going to the database.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBUG 3625: untranslatable strings in opac-shelves.tmpl
Katrin Fischer [Mon, 14 Sep 2009 20:49:06 +0000 (22:49 +0200)]
BUG 3625: untranslatable strings in opac-shelves.tmpl

select all, clear all, tag, place hold

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoFollow-up for Bug 3524, adding itemtype text description
Owen Leonard [Thu, 10 Sep 2009 15:19:51 +0000 (10:19 -0500)]
Follow-up for Bug 3524, adding itemtype text description

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBugs: 1172 3579 3596 fixes to patron detail in opac
Nicole Engard [Thu, 10 Sep 2009 23:46:50 +0000 (19:46 -0400)]
Bugs: 1172 3579 3596 fixes to patron detail in opac

This patch makes it so that the patron can see their
details even if the OPACPatronDetails sys pref is OFF.

It also removed the messaging options from the patron
details and leaves them on the messaging tab.

Finally it adds in address fields that were missing
previously on the update patron form.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoHandle null-or-empty to Charset::StripNonXmlChars
J. David Bavousett [Thu, 10 Sep 2009 15:10:50 +0000 (11:10 -0400)]
Handle null-or-empty to Charset::StripNonXmlChars

When rebuild_zebra.pl is run from cron, there is an occasional error
of the form:

Use of uninitialized value $str in substitution (s///) at /home/ebpl/kohaclone/C4/Charset.pm line 304.

This error is occuring when the string that is fed to Charset::StripNonXmlChars
is null or undefined, for some reason.

This fix will handle the null-or-empty condition, and thus suppress the error.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 2505: Enabled warnings in tools-home.pl, holidays.pl, exceptionHolidays.pl, and...
Garry Collum [Fri, 11 Sep 2009 15:26:57 +0000 (11:26 -0400)]
Bug 2505: Enabled warnings in tools-home.pl, holidays.pl, exceptionHolidays.pl, and newHolidays.pl

Tested for warnings after addition of 'use warnings.' No warnings were generated.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 3601: Cleanup of holiday.tmpl
Garry Collum [Fri, 11 Sep 2009 15:41:38 +0000 (11:41 -0400)]
Bug 3601: Cleanup of holiday.tmpl

Changes the word 'location' to 'library.'
Expands the description of 'exception.'

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoRemove js debugging which caused failure of "uncheck all."
Owen Leonard [Fri, 11 Sep 2009 23:53:00 +0000 (18:53 -0500)]
Remove js debugging which caused failure of "uncheck all."

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoFix for typo in previous history patch
Chris Cormack [Mon, 7 Sep 2009 10:04:57 +0000 (22:04 +1200)]
Fix for typo in previous history patch

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years ago2 new committers for the history doc
Chris Cormack [Sun, 6 Sep 2009 20:58:22 +0000 (08:58 +1200)]
2 new committers for the history doc

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 3567: Display Alternate Graphic Representation (MARC21 880) in OPAC
Wolfgang Heymans [Tue, 1 Sep 2009 08:28:06 +0000 (10:28 +0200)]
Bug 3567: Display Alternate Graphic Representation (MARC21 880) in OPAC

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoChanges to make checkouts/holds display the same on circulation and patron detail...
Owen Leonard [Fri, 28 Aug 2009 13:12:28 +0000 (08:12 -0500)]
Changes to make checkouts/holds display the same on circulation and patron detail screens (Bug 3106)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoDisplay description, avoid broken itemtype image on holds page (Bug 3524)
Owen Leonard [Fri, 28 Aug 2009 13:38:23 +0000 (08:38 -0500)]
Display description, avoid broken itemtype image on holds page (Bug 3524)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoAdding strings to translate in tags.js
Henri-Damien LAURENT [Tue, 1 Sep 2009 19:46:03 +0000 (21:46 +0200)]
Adding strings to translate in tags.js

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug Fixing 3568 : Untranslated strings
Henri-Damien LAURENT [Tue, 1 Sep 2009 08:34:08 +0000 (10:34 +0200)]
Bug Fixing 3568 : Untranslated strings

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoDB rev 054->058
Galen Charlton [Sun, 6 Sep 2009 17:54:17 +0000 (13:54 -0400)]
DB rev 054->058

055: changed OPACSearchForTitleIn per requests in bug 1934
056: Bug 1172 : Add OPACPatronDetails syspref
057: Bug 2576 : Add OPACFinesTab syspref
058: Added primary keys to language tables

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 1934: Final Patch - Fixed Default Values
Nicole Engard [Sun, 6 Sep 2009 17:45:09 +0000 (13:45 -0400)]
Bug 1934: Final Patch - Fixed Default Values

The default values had classes they didn't need assigned
to them.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 2559 Added primary keys to tables per comments
Nicole Engard [Sun, 6 Sep 2009 17:45:08 +0000 (13:45 -0400)]
Bug 2559 Added primary keys to tables per comments

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 2576: Added OPACFinesTab Syspref
Nicole Engard [Sun, 6 Sep 2009 17:45:07 +0000 (13:45 -0400)]
Bug 2576: Added OPACFinesTab Syspref

This preference allows library staff to decide whether to show
the fines tab in the OPAC for logged in patrons.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 1172: Added OPACPatronDetails system preference
Nicole Engard [Sun, 6 Sep 2009 17:45:06 +0000 (13:45 -0400)]
Bug 1172: Added OPACPatronDetails system preference

This patch allows library staff to disable the patron details
tab on the OPAC.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 1934: Changed variables per request in bug report
Nicole Engard [Sun, 6 Sep 2009 17:45:05 +0000 (13:45 -0400)]
Bug 1934: Changed variables per request in bug report

System preference now looking for brackets around variables.
ex. {TITLE} instead of TITLE

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agobug 1003: tweak GetBibliosShelves
Galen Charlton [Sun, 6 Sep 2009 17:05:06 +0000 (13:05 -0400)]
bug 1003: tweak GetBibliosShelves

* correct POD - returns *public* lists that bib
  belongs to
* use fetchall_arrayref to return results in
  one fell swoop
* corrected indentation

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 1003 Added lists to bib details pages
Nicole Engard [Thu, 27 Aug 2009 15:22:15 +0000 (11:22 -0400)]
Bug 1003 Added lists to bib details pages

This patch adds links to all public lists that a bib
record belongs to to the detail page in the OPAC and
the Inranet. If the item is not in any lists nothing
shows on the detail page.  The same goes if virtualshelves
is turned OFF.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 3582: Missing usage information for -h / --help switch for rebuild_nozebra.pl
Ricardo Dias Marques [Sun, 6 Sep 2009 16:44:13 +0000 (16:44 +0000)]
Bug 3582: Missing usage information for -h / --help switch for rebuild_nozebra.pl

Fix for Bug 3582:  Missing usage information for -h / --help switch for rebuild_nozebra.pl

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3582

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agocomment out styles in gb_styles.css
Galen Charlton [Sun, 6 Sep 2009 16:38:30 +0000 (12:38 -0400)]
comment out styles in gb_styles.css

These were added in the labels rework, but do not belong here, since
gb_styles.css should references only CSS classes responsible for
displaying the greybox itself, not the content inside it.  In particular,
the generic table styles were causing the icons added by tablesorter
to be tiled in the opac-detail template.

To finish this work, the styles should be taken out entirely and
moved to whichever lables template they were supposed to affect

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
12 years agoBug 2713 Make Marc & ISBD View match Normal template
Nicole Engard [Wed, 26 Aug 2009 17:54:40 +0000 (13:54 -0400)]
Bug 2713 Make Marc & ISBD View match Normal template

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>