koha.git
13 years agoBug 2505: Enabled warnings in opac_ISBDdetail.pl, opac-modrequest.pl, and opac-tags_s...
Garry Collum [Sat, 8 Aug 2009 18:37:26 +0000 (14:37 -0400)]
Bug 2505: Enabled warnings in opac_ISBDdetail.pl, opac-modrequest.pl, and opac-tags_subject.pl.

Enabling warnings in these files did not generate any warnings in the logs when tested.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years ago(bug #3497) show publication year, or copyrightdate
Nahuel ANGELINETTI [Wed, 5 Aug 2009 08:07:36 +0000 (10:07 +0200)]
(bug #3497) show publication year, or copyrightdate

This change the shelf view in opac, to show publication year, in the column "Year"(that was previously copyrightdate), and is there is no publication year, show copyright date.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years ago(bug #3505) fix 210c and 225a unimarc's plugins
Nahuel ANGELINETTI [Wed, 5 Aug 2009 13:14:13 +0000 (15:14 +0200)]
(bug #3505) fix 210c and 225a unimarc's plugins

This fix the 2 plugins, make 225a to work with koha 3.0, and fix 210c to be xhtml valid

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years ago(bugs #3502) search on available items in unimarc
Nahuel ANGELINETTI [Tue, 4 Aug 2009 14:30:43 +0000 (16:30 +0200)]
(bugs #3502) search on available items in unimarc

this add a "w" index, that allow to search on available items only

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3465: enhance DB update reporting by web installer
Galen Charlton [Sat, 1 Aug 2009 16:17:18 +0000 (12:17 -0400)]
bug 3465: enhance DB update reporting by web installer

This enhances the web installer so that messages from updatedatabase.pl will
be displayed to the user running a database update.  Messages printed to STDOUT
will be displayed as the update report, while messages printed to STDERR will
be displayed as update errors.

This patch introduces  a new module dependency, IPC::Cmd.
IPC::Cmd lets one run an external program such as updatedatabase.pl and easily
capture STDERR and STDOUT for further munging.  IPC::Cmd is core in Perl 5.10
and stable in Perl 5.8.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3467 followup: fix test for item found
Galen Charlton [Tue, 4 Aug 2009 01:24:26 +0000 (21:24 -0400)]
bug 3467 followup: fix test for item found

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoQuick Spine Label Printer - Minors fixes
Kyle M Hall [Mon, 3 Aug 2009 16:26:26 +0000 (16:26 +0000)]
Quick Spine Label Printer - Minors fixes

This new version of the patch does away with the need for 2 spinelabel css files.

This patch address two points brought up:
[1] (minor) if an item is not found, it should say so and return to
spinelabel-home.pl, not show an empty label
[2] (minor) can the print button be excluded from the printout?

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoCreated database-tidying cron script
J. David Bavousett [Sat, 1 Aug 2009 23:38:44 +0000 (19:38 -0400)]
Created database-tidying cron script

This little script establishes a framework for database cleanup on some regular
schedule.  Initial implementation provides for brute truncation of the sessions
table, and selective-by-age cleanup of the zebraqueue.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoAdding new committer to history
Chris Cormack [Sat, 1 Aug 2009 19:24:34 +0000 (07:24 +1200)]
Adding new committer to history

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBug 3466: Fixes xhtml errors in opac-shelves.tmpl.
Garry Collum [Sun, 2 Aug 2009 02:03:24 +0000 (22:03 -0400)]
Bug 3466: Fixes xhtml errors in opac-shelves.tmpl.

Addendum to bug 3466.  opac-shelves.tmpl contained the same xhtml error as shelves.tmpl, if the user is viewing the public list a orphaned table row (<tr>) is present.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBug 2553: Alphabetizes branches and item-type drop-down lists in opac-topissues.pl.
Garry Collum [Sun, 2 Aug 2009 02:49:53 +0000 (22:49 -0400)]
Bug 2553: Alphabetizes branches and item-type drop-down lists in opac-topissues.pl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoDB rev 038>039 (for real, this time)
Galen Charlton [Sun, 2 Aug 2009 15:06:05 +0000 (11:06 -0400)]
DB rev 038>039 (for real, this time)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agotextual cleanup of new quick spine label code
Galen Charlton [Sun, 2 Aug 2009 15:05:30 +0000 (11:05 -0400)]
textual cleanup of new quick spine label code

* perltidy
* added license header to source files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoquell warning on NULL item fields
Galen Charlton [Sun, 2 Aug 2009 15:01:55 +0000 (11:01 -0400)]
quell warning on NULL item fields

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoremoved unneeded module imports
Galen Charlton [Sun, 2 Aug 2009 14:57:41 +0000 (10:57 -0400)]
removed unneeded module imports

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoquick spoine label followup: sysprefs
Galen Charlton [Sun, 2 Aug 2009 14:51:29 +0000 (10:51 -0400)]
quick spoine label followup: sysprefs

* Added missed SpineLabelAutoPrint to updatedatabase;
  this preference controls whether labels generated
  by the new quick spine label tool are printed automatically
* put SpineLabelAutoPrint and SpineLabelFormat in the
  Cataloging section of the syspref editor
* set height and width for the SpineLabelFormat textarea
  in the syspref editor

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobumping quick spine label printing to DBrev 039
Galen Charlton [Sat, 1 Aug 2009 15:14:52 +0000 (11:14 -0400)]
bumping quick spine label printing to DBrev 039

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoQuick Spine Label Printer
Kyle M Hall [Fri, 10 Jul 2009 15:50:25 +0000 (15:50 +0000)]
Quick Spine Label Printer

This is a small tool for quickly printing spine labels using dedicated label printers.
It is located in the Tools page as Quick Spine Label Creator.
The system preference SpineLabelFormat defines which fields will be displayed.
The pref SpineLabelAutoPrint will make the print dialog pop up automatically.
The CSS file spinelabel.css controls all presentation for the labels.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoDB rev 038->039
Galen Charlton [Sat, 1 Aug 2009 13:58:20 +0000 (09:58 -0400)]
DB rev 038->039

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3440 followup: tweak updatedatabase.pl
Galen Charlton [Sat, 1 Aug 2009 13:56:51 +0000 (09:56 -0400)]
bug 3440 followup: tweak updatedatabase.pl

[1] Removed POD: not a bad idea, but if we do it,
    there should be more substance to the messages
[2] Improved description of change
[3] Removed extra 'my' qualifier.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3440: C4/Branch.pm: the branch{zip,city,country,url,notes} rows should be taken...
Sébastien Hinderer [Mon, 27 Jul 2009 08:33:27 +0000 (10:33 +0200)]
bug 3440: C4/Branch.pm: the branch{zip,city,country,url,notes} rows should be taken into account during Add and Mod operations.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3440: Modifies branches script and template so that the newly added rows are...
Sébastien Hinderer [Mon, 27 Jul 2009 09:43:24 +0000 (11:43 +0200)]
bug 3440: Modifies branches script and template so that the newly added rows are taken into account.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3440: Database structure modification.
Sébastien Hinderer [Fri, 24 Jul 2009 09:00:07 +0000 (11:00 +0200)]
bug 3440: Database structure modification.

Adds 5 columns to the `branches` table: `branchzip`, `branchcity`,
`branchcountry`, `branchurl` and `branchnote`.
I/O operations for these fields are not included.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 2505: cleanup warnings in reserve/request.pl
Galen Charlton [Sat, 1 Aug 2009 13:09:42 +0000 (09:09 -0400)]
bug 2505: cleanup warnings in reserve/request.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBug 2889: Removed toggle variable from Serials vendor search.
Garry Collum [Thu, 23 Jul 2009 03:53:00 +0000 (23:53 -0400)]
Bug 2889: Removed toggle variable from Serials vendor search.

Removed toggle variable from acqui-search-result.pl.  Added highlighting using __odd__ to acqui-search-result.tmpl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBug 2553: Additional patch for the branch drop-down in Existing Holds.
Garry Collum [Thu, 23 Jul 2009 01:07:16 +0000 (21:07 -0400)]
Bug 2553: Additional patch for the branch drop-down in Existing Holds.

Improves previous patch through the use of GetBranchesLoop. Also adds highlighting to the Existing holds table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoStop generation of unnecessary warning messages to log over undef values
Colin Campbell [Wed, 22 Jul 2009 17:07:30 +0000 (18:07 +0100)]
Stop generation of unnecessary warning messages to log over undef values

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoInstaller break utf8 for DBD::mysql
Henri-Damien LAURENT [Thu, 23 Jul 2009 11:20:07 +0000 (13:20 +0200)]
Installer break utf8 for DBD::mysql

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoMinor change to fix Bug 3086, Can't close circulation date-picker popup in Internet...
Owen Leonard [Thu, 23 Jul 2009 14:44:02 +0000 (09:44 -0500)]
Minor change to fix Bug 3086, Can't close circulation date-picker popup in Internet Explorer

I don't know why this edit fixes the problem, but it does. Tested in IE6, IE7, and IE8 on Windows XP.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoremoved redundant license statement
Galen Charlton [Sat, 1 Aug 2009 12:15:17 +0000 (08:15 -0400)]
removed redundant license statement

The standard license statement in the header is fine; please
don't confuse things by doing anything different.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoscript to remove authorities without biblio attached
Paul Poulain [Thu, 23 Jul 2009 15:23:35 +0000 (17:23 +0200)]
script to remove authorities without biblio attached

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoRemoving unused recentacquiloop markup (Bug 3439)
Owen Leonard [Thu, 23 Jul 2009 16:40:38 +0000 (11:40 -0500)]
Removing unused recentacquiloop markup (Bug 3439)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years ago(bug #3458) fix die and unimarc 700-4 plugin
Nahuel ANGELINETTI [Fri, 31 Jul 2009 14:04:01 +0000 (16:04 +0200)]
(bug #3458) fix die and unimarc 700-4 plugin

This patch, fix the unimarc 700-4 plugin, adding the plugin_parameters() function.
And add an eval, that permit to have error in plugin, but don't die the editor.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoMore XHTML corrections (Bug 3211)
Owen Leonard [Wed, 22 Jul 2009 17:48:05 +0000 (12:48 -0500)]
More XHTML corrections (Bug 3211)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoXHTML corrections (Bug 3211)
Owen Leonard [Wed, 22 Jul 2009 16:53:29 +0000 (11:53 -0500)]
XHTML corrections (Bug 3211)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 3452: Additional patch that expands the branch name and category code in Suggesti...
Garry Collum [Thu, 30 Jul 2009 23:16:41 +0000 (19:16 -0400)]
Bug 3452: Additional patch that expands the branch name and category code in Suggestions Management.

Displays the Branch name and Category description along with their codes in Suggestion Management.

Also since I joined to the branches table the 'map' function in opac-suggestions.pl to retrieve the branchname was no longer necessary.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 3434 Fix SQL Syntax Error when setting claimdate
Colin Campbell [Wed, 22 Jul 2009 14:42:57 +0000 (15:42 +0100)]
bug 3434 Fix SQL Syntax Error when setting claimdate

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug 3434) Fix generation of Serials Claims
Colin Campbell [Wed, 22 Jul 2009 16:41:00 +0000 (17:41 +0100)]
(bug 3434) Fix generation of Serials Claims

op was not being returned to claims.pl. It seems better logic
to use whether the there are ids the user has flagged for claims
to decide whether to generate the claims

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoUser will find it useful to see the date claimed
Colin Campbell [Thu, 23 Jul 2009 16:09:31 +0000 (17:09 +0100)]
User will find it useful to see the date claimed

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 3435: added missing _ in _FixAccountForLostAndReturned
Galen Charlton [Thu, 30 Jul 2009 18:35:29 +0000 (14:35 -0400)]
bug 3435: added missing _ in _FixAccountForLostAndReturned

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBugfix 2339 - Place hold button display with AllowOnShelfHolds OFF (Part 2)
Kyle M Hall [Thu, 30 Jul 2009 11:56:25 +0000 (11:56 +0000)]
Bugfix 2339 - Place hold button display with AllowOnShelfHolds OFF (Part 2)

Added code to opac-ISBDdetail.pl to match the changes made to the template file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdding missing image: Bug 3457, broken image in opac.css - new.gif
Owen Leonard [Thu, 30 Jul 2009 13:14:42 +0000 (08:14 -0500)]
Adding missing image: Bug 3457, broken image in opac.css - new.gif

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 3435 followup: tweak AddReturn cleanup
Galen Charlton [Thu, 30 Jul 2009 15:27:22 +0000 (11:27 -0400)]
bug 3435 followup: tweak AddReturn cleanup

We're returning issue information when available,
not just item information.  Fixes problem where
circ/returns.pl wasn't displaying the due date
and patron when returning a loan.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 3435: SIP2 - 3M extension for SmartChute checkin.
Joe Atzberger [Thu, 30 Jul 2009 00:56:08 +0000 (19:56 -0500)]
bug 3435: SIP2 - 3M extension for SmartChute checkin.

Implement the optional fields: CR CS CT CV CY and DA.
Also silenced some outstanding debugging print statements.
Consolidated similar accesseor subs in Patron.pm to use x_items.
Adjust SIP tests to specify correct AP (location).  Add a 3rd item
to SIPtext.pm for later use.

Note CT (destination) is currently populated with destination branch code.
We can adjust that to be destination branch name, or some combination in
a subsequent patch if necessary.

This work was sponsored by the Northeast Kansas Library system.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 3435: AddReturn overhaul.
Joe Atzberger [Thu, 30 Jul 2009 00:56:07 +0000 (19:56 -0500)]
bug 3435: AddReturn overhaul.

Required for SIP checkin implementation, but also for internal correctness.
AddReturn had too many things going on, with no guarantee of data being
available for the later calls.  At some point we started tacking on all the
branch transfer logic without testing edge cases.  In particular, $borrower
is not checked to be sure it is defined, considering the item may not have been
checked out so no borrower would be associated.  That means that CircControl
of "PatronLibrary" would be inaccurate, Circ Alerts will be totally confused
(untargeted), and the Fix... subs would fail.

Note that *many* errors are still present in _FixAccountForLostAndReturned, including
those where comments are added, such that it might behave strangely even with $borrower.

Renamed the internal subs with leading underscore, per convention.  Changed
the arguments to be scalars when only scalars are needed, not entire objects.
Added depth to WrongBranch message that includes Rightbranch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 3435: SIP Checkin extension for 3M SmartChute - partial
Joe Atzberger [Thu, 30 Jul 2009 00:56:06 +0000 (19:56 -0500)]
bug 3435: SIP Checkin extension for 3M SmartChute - partial

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 1607: Fixes the delete checkboxes in purchase suggestions.
Garry Collum [Wed, 29 Jul 2009 21:09:17 +0000 (17:09 -0400)]
Bug 1607: Fixes the delete checkboxes in purchase suggestions.

If a user views suggestions of another user, syspref (OPACViewOthersSuggestions), a selection check box for deletion appeared next to all of the suggested titles whether the logged-in user owned them or not. - fixed

Also fixes the "Clear all" and "Select all" links which appeared for anonymouse users, if AnonSuggestions is turned on.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 3056 - replace span hacking for terms in C4::Search
Joe Atzberger [Tue, 28 Jul 2009 01:47:50 +0000 (20:47 -0500)]
Bug 3056 - replace span hacking for terms in C4::Search

Reimplemented using jquery, added OSS plugin to both interfaces.  This is
another case where having a /common directory used by both OPAC and STAFF
would increase runtime efficiency and cut development time.

Removed unused variables.

I changed the OPAC .term color to match the staff interface, rather than being a
second shade of blue.  The highlight/unhighlight link is currently a bit bolder
than its neighbors, but my styling choices are provisional.  I expect the final
tweaking of CSS to come from another more capable designer, like Owen.

Note this patch may rely on previously submitted "Search.pm minor cleanup" patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoSearch.pm minor cleanup
Joe Atzberger [Wed, 8 Jul 2009 20:27:45 +0000 (15:27 -0500)]
Search.pm minor cleanup

Trying to move towards enabling warnings.
Add warn for unknown $query_type.
Use common $dbh.

push @array, ({key1=>value1...}); is the same as
push @array, {key1=>value1...};

if ( scalar(@$arrayref) > 0 ) is the same as
if (scalar @$arrayref)

Lines like:
    my @operators = @$operators if $operators;
are bad because we need @operators to be declared and in scope later,
even if it is undef.  Without $operators, the variable is not in scope.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 3452: Displays borrower category and adds links to Suggestions Management
Garry Collum [Wed, 29 Jul 2009 00:49:58 +0000 (20:49 -0400)]
Bug 3452: Displays borrower category and adds links to Suggestions Management

A couple of enhancments to Suggestions Management.

Adds a display of the borrower category of the suggesting patron for each item.

Adds links to the title and author displays so that the catalog can be quickly search for an existing bib.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoChange to layout of tag review interface (enhancement bug 3447)
Owen Leonard [Tue, 28 Jul 2009 14:08:41 +0000 (09:08 -0500)]
Change to layout of tag review interface (enhancement bug 3447)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBugfix 2339 - Place hold button display with AllowOnShelfHolds OFF
Kyle M Hall [Wed, 29 Jul 2009 13:05:52 +0000 (13:05 +0000)]
Bugfix 2339 - Place hold button display with AllowOnShelfHolds OFF

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBUG 1255 Barred users will not see renew or renew all anymore
Nicole Engard [Mon, 27 Jul 2009 13:28:21 +0000 (08:28 -0500)]
BUG 1255 Barred users will not see renew or renew all anymore

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoRevert "Bug 3226 - Extended characters inconsistantly displayed"
Galen Charlton [Tue, 28 Jul 2009 00:54:42 +0000 (20:54 -0400)]
Revert "Bug 3226 - Extended characters inconsistantly displayed"

This reverts commit 7a3bdce23dddaf09f980bcbb12c15eb1d604c1a9.

Even though patches were submitted that fixed the breakage
that this commit caused to NoZebra searchs, it turns out
this breaks code that uses SimpleSearch - clients of that
routine currently expect ISO2709 blobs, not MARCXML.

No further patches for 3226 will be pushed until a complete,
comprehensive patchset is submitted that (a) includes a
test case for the original bug and (b) demonstrates that
it doesn't break any aspect of bibliographic and authority
searching.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(Bug 3402) Serials issue name not escaped when passed forward to routing slip
J. David Bavousett [Mon, 27 Jul 2009 12:15:37 +0000 (08:15 -0400)]
(Bug 3402) Serials issue name not escaped when passed forward to routing slip

The issue descriptor was not being escaped before being passed on to the
routing slip, causing truncation.  It's truly impossible to know for sure
what will be there, so uri_escape-ing seemed the best way to ensure that
it gets handed forward and makes it all the way to the printable slip.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2935: Patch to fix location in routing slip.
Garry Collum [Fri, 24 Jul 2009 01:25:43 +0000 (21:25 -0400)]
Bug 2935: Patch to fix location in routing slip.

routing-preview.pl and routing.pl were pointing to a non-existent column in the borrowers table.  This patch replaces streetaddress with branchcode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2889: Added highlighting to Serials Subscriptions table in serials-home.tmpl.
Garry Collum [Thu, 23 Jul 2009 03:35:41 +0000 (23:35 -0400)]
Bug 2889: Added highlighting to Serials Subscriptions table in serials-home.tmpl.

Added highlighting to serials subscriptions table.  Cleaned up unused toggle variable code.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoShow claimed issues as 'Claimed' not just blank space
Colin Campbell [Wed, 22 Jul 2009 15:10:08 +0000 (16:10 +0100)]
Show claimed issues as 'Claimed' not just blank space

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix POD for GetReservesFromBiblionumber
Joe Atzberger [Wed, 22 Jul 2009 15:23:15 +0000 (10:23 -0500)]
Fix POD for GetReservesFromBiblionumber

Only one argument is needed, as the name suggests.
Also removed unused package variable, added comments.

Fix POD for GetReservesFromBiblionumber

Only one argument is needed, as the name suggests.
Also removed unused package variable, added comments.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoCleanup _Findgroupreserve.
Joe Atzberger [Wed, 22 Jul 2009 15:23:16 +0000 (10:23 -0500)]
Cleanup _Findgroupreserve.

Mostly formatting SELECT statement for readability.  Also updated POD
and added a comment.  This command:
    git diff -w C4/Reserves.pm
shows only the POD and comment chnages.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoCorrect GetItemIssue to actually return undef if item not checked out.
Joe Atzberger [Wed, 17 Jun 2009 22:37:58 +0000 (17:37 -0500)]
Correct GetItemIssue to actually return undef if item not checked out.

Updated POD for correctness.
Replaced strftime + regexp w/ C4::Dates->today.
Also removed some sth->finish statements.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoGive Overdues a few whacks with perltidy
Joe Atzberger [Sat, 20 Jun 2009 00:32:46 +0000 (19:32 -0500)]
Give Overdues a few whacks with perltidy

This was, an in part still is, some of the worst-formatted code in Koha.

Also made a few minor changes:
~ removing sth->finish
~ adding comment
~ removed whitespace error trailing spaces
~ use trinary op, like: return ( $debarredstatus eq '1' ? 1 : 0 );

Note that the logic is the same, even where I condsider it faulty.
(In the exampe case, because $debarredstatus may be undef.)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoExplicitly set _find_value's return to a string if not defined
Colin Campbell [Tue, 21 Jul 2009 10:59:09 +0000 (11:59 +0100)]
Explicitly set _find_value's return to a string if not defined

 Avoids generating a slew of warnings in the log when the undefined
 value was concatenated or used in regexps

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoCorrecting some selectors to conform with upgraded jQuery syntax (see Bug 3297).
Owen Leonard [Tue, 21 Jul 2009 17:36:00 +0000 (12:36 -0500)]
Correcting some selectors to conform with upgraded jQuery syntax (see Bug 3297).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2553: Alphabetization of branches in the catalogue stats report.
Garry Collum [Wed, 22 Jul 2009 00:36:15 +0000 (20:36 -0400)]
Bug 2553: Alphabetization of branches in the catalogue stats report.

Improvement on previous patch by using GetBranchesLoop.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2553: Alphabetization of branches in Checkout Statistics form.
Garry Collum [Wed, 22 Jul 2009 00:46:10 +0000 (20:46 -0400)]
Bug 2553: Alphabetization of branches in Checkout Statistics form.

Improvement of previous patch through the use of GetBranchLoop.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug#: 3230 Penny fine, needs fixed, just a round off. Please
Darrell Ulm [Wed, 22 Jul 2009 14:06:53 +0000 (10:06 -0400)]
Bug#: 3230 Penny fine, needs fixed, just a round off. Please

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofollowup to AddReturn patch - fix test
Galen Charlton [Wed, 22 Jul 2009 14:06:06 +0000 (09:06 -0500)]
followup to AddReturn patch - fix test

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agocheck $debug to print debug info only when wanted
Galen Charlton [Wed, 22 Jul 2009 14:08:39 +0000 (09:08 -0500)]
check $debug to print debug info only when wanted

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago3M SIP2 Extensions groundwork and Patron Info popoulation
Joe Atzberger [Wed, 22 Jul 2009 14:08:38 +0000 (09:08 -0500)]
3M SIP2 Extensions groundwork and Patron Info popoulation

This includes some initial work for the 3M SIP2 extensions.
It also better populates the Patron object with methods for
a fuller Patron Information Reponse.  This is positively affect
EnvisionWare software, as used by NEKLS.

This work was sponsored by the Northeast Kansas Library System.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 3322: Fixes expandedSearchOption in opac. Makes "fewer options" possible.
Garry Collum [Wed, 15 Jul 2009 02:16:27 +0000 (22:16 -0400)]
Bug 3322: Fixes expandedSearchOption in opac. Makes "fewer options" possible.

Copies the logic of catalogue/search.pl to fix the expanded search option in opac. When expanded search is the default, it was impossible to go to the "fewer" options.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #3421) fix the xhtml in serial biblio search
Nahuel ANGELINETTI [Wed, 15 Jul 2009 13:54:09 +0000 (15:54 +0200)]
(bug #3421) fix the xhtml in serial biblio search

This fix differents errors, and escape in bib search.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 3423 - In Cataloging, fields are not ordered by tag number
Frédéric Demians [Wed, 15 Jul 2009 19:59:56 +0000 (21:59 +0200)]
Bug 3423 - In Cataloging, fields are not ordered by tag number

In cataloging, depending on installation and how biblio framework has been
created/modified, fields are not displayed ordered by tag number. For example,
in UNIMARC you can have in tab '2':

  225
  200
  210

This patch order fields in tabs by tag and letter in the tag.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 3428: Alphabetizes the collection codes in the Advanced Search.
Garry Collum [Sun, 19 Jul 2009 00:02:24 +0000 (20:02 -0400)]
Bug 3428: Alphabetizes the collection codes in the Advanced Search.

If the advancedSearchTypes = CCODE, the code descriptions are not alphabetized, as opposed to itemtypes, which are alphabetized.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2553: Fixes the alphabetization of the drop-down lists for the Most-Circulated...
Garry Collum [Thu, 16 Jul 2009 20:50:10 +0000 (16:50 -0400)]
Bug 2553: Fixes the alphabetization of the drop-down lists for the Most-Circulated items report.

This patch alphabetizes the descriptions that appear in the  Library, Item type, and patron category drop-down lists of the Most-Circulated Items report form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2553: Alphabetizes the drop-down lists of libraries in the Existing Holds view...
Garry Collum [Thu, 16 Jul 2009 21:52:18 +0000 (17:52 -0400)]
Bug 2553: Alphabetizes the drop-down lists of libraries in the Existing Holds view of request.pl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2553: Fixes the location drop-down alphabetization for the catalog statistics...
Garry Collum [Fri, 17 Jul 2009 23:08:15 +0000 (19:08 -0400)]
Bug 2553: Fixes the location drop-down alphabetization for the catalog statistics report form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2553: Fixes drop-down alphabetization for Circulation Statistics report form.
Garry Collum [Fri, 17 Jul 2009 23:31:55 +0000 (19:31 -0400)]
Bug 2553: Fixes drop-down alphabetization for Circulation Statistics report form.

Fixes alphabetization for the item type, library and collection drop-down lists in the Checkout Statistics wizard form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2553: Fixes drop-down alphabetization in acquisitions - New order and Receive...
Garry Collum [Sat, 18 Jul 2009 00:24:56 +0000 (20:24 -0400)]
Bug 2553: Fixes drop-down alphabetization in acquisitions - New order and Receive order.

Fixes alphabetization of library dropdown in New Order, and the shelf location, item type, and collection code in the Receive Items pages.  This patch takes care of Joann's original purpose of creating the bug enhancement.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2553: Fixes location drop-down alphabetization in Serials Statistics wizard form.
Garry Collum [Fri, 17 Jul 2009 23:54:10 +0000 (19:54 -0400)]
Bug 2553: Fixes location drop-down alphabetization in Serials Statistics wizard form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 3418: Fixes the alpha order of the system preference tags.
Garry Collum [Wed, 15 Jul 2009 21:30:31 +0000 (17:30 -0400)]
Bug 3418: Fixes the alpha order of the system preference tags.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 3408: Tag cloud says login when logged in - fix.
Garry Collum [Thu, 16 Jul 2009 16:45:29 +0000 (12:45 -0400)]
Bug 3408: Tag cloud says login when logged in - fix.

Changed the logic in the html form to have the login prompt only appear if a user is not logged in.  Separated the hidemylist functionality from the "show tags from other users" option.  Created a link for "hide my tags" or "show my tags" depending on context.

The user can now choose how many tags of other users to show, and can also choose whether to show their own tags or not.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2593 : way to duplicate items
Matthias Meusburger [Fri, 17 Jul 2009 15:23:50 +0000 (17:23 +0200)]
Bug 2593 : way to duplicate items

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoCannot use the same TMPL_VAR to select ALL options.
Joe Atzberger [Mon, 20 Jul 2009 20:37:24 +0000 (15:37 -0500)]
Cannot use the same TMPL_VAR to select ALL options.

Only one select can be selected in this case.  If preselection of search type is
desired, I recommend a clean implementation w/ jquery instead of adding a conditional
for each select.  Please note, that is the only good way to get multiple preselections,
since the same .inc file will be used in each case.  So a single variable like
    <TMPL_IF NAME="index_bc_selected">
cannot be used, since it would set for ALL (3) advanced search dropdowns.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoRemove bogus "selected" logic from OPAC adv. search.
Joe Atzberger [Mon, 20 Jul 2009 22:47:42 +0000 (17:47 -0500)]
Remove bogus "selected" logic from OPAC adv. search.

The only reason the TMPL_VAR works where it does is because it is part
of the TMPL_LOOP.  It doesn't mean anything outside the loops, since
*everything* would be selected with the same variable, indiscriminantly.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoCorrect broken spacing in docs
Joe Atzberger [Fri, 17 Jul 2009 13:51:04 +0000 (08:51 -0500)]
Correct broken spacing in docs

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdd crontab instructrions.
Joe Atzberger [Fri, 17 Jul 2009 14:56:31 +0000 (09:56 -0500)]
Add crontab instructrions.

Too many people have been confused about crontab dependent functions
"not working" automatically on their installations.  This is probably
because there was no explicit step telling them to schedule the jobs.
The maintainers of the other INSTALL.* docs would be well advised
to insert similar lines in their docs, after confirming proper operation,
since cron/crontab are very system dependent.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 3226 - Extended characters inconsistantly displayed
Frédéric Demians [Wed, 15 Jul 2009 06:35:08 +0000 (08:35 +0200)]
Bug 3226 - Extended characters inconsistantly displayed

When displayed on result page, some UNIMARC biblio
records are marc8 to utf8 converted for whatever
reason! It appears that iso2709 records in Zebra can't
always properly by used to construct MARC::Record.
This patch ask Zebra to return xml record rather than
iso2709 and use it to create MARC::Record (like
C4::GetMarcBiblio). i

Fix facet display.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #3398) fix unimarc 210c plugin
Nahuel ANGELINETTI [Wed, 15 Jul 2009 09:01:27 +0000 (11:01 +0200)]
(bug #3398) fix unimarc 210c plugin

this add some args to SearchAuthority();
Fix the pagination, and fix javascript script.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoRevert "Bug 3226 - Extended characters inconsistantly displayed"
Galen Charlton [Wed, 15 Jul 2009 03:35:16 +0000 (23:35 -0400)]
Revert "Bug 3226 - Extended characters inconsistantly displayed"

This reverts commit 1ddb5df863c3166a20d55c8f852af7c5fd67e204.

13 years ago(bug #3405) fix on loan list in search result
Nahuel ANGELINETTI [Wed, 8 Jul 2009 11:46:48 +0000 (13:46 +0200)]
(bug #3405) fix on loan list in search result

The hash keys were made using a base and $item->{date_due}, but this key doesn't exists, so the possibility to have duplicate keys exists, and sometimes the others items were not shown. This patch fix this bug.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 3226 - Extended characters inconsistantly displayed
Frédéric Demians [Sat, 4 Jul 2009 04:57:37 +0000 (06:57 +0200)]
Bug 3226 - Extended characters inconsistantly displayed

When displayed on result page, some UNIMARC biblio
records are marc8 to utf8 converted for whatever
reason! It appears that iso2709 records in Zebra can't
always properly by used to construct MARC::Record.
This patch ask Zebra to return xml record rather than
iso2709 and use it to create MARC::Record (like
C4::GetMarcBiblio).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix BUG #3406 - move tag cloud above 'my tags' for ease of reading
Nicole Engard [Thu, 9 Jul 2009 12:21:04 +0000 (07:21 -0500)]
Fix BUG #3406 - move tag cloud above 'my tags' for ease of reading

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 3317: Adds author and added-author to email sent from basket (Cart).
Garry Collum [Sat, 27 Jun 2009 17:48:18 +0000 (13:48 -0400)]
Bug 3317: Adds author and added-author to email sent from basket (Cart).

Adds the author and added author fields to the email that is sent from the shopping cart.  This makes the data sent via email consistent with the data that is viewed in the basket.

There is still a problem with author authority records other than 100 tags appearing correctly in the shopping cart.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2770 follwup : force AddRenewal obey circControl system preference [revised]
Ryan Higgins [Thu, 2 Jul 2009 01:37:42 +0000 (20:37 -0500)]
Bug 2770 follwup : force AddRenewal obey circControl system preference [revised]

Also prevents infinite-length renewals by returning undef
if passed an invalid date instead of renewing with no due date.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoChanges to lists to improve behavior for users with no javascript
Owen Leonard [Tue, 30 Jun 2009 19:56:28 +0000 (14:56 -0500)]
Changes to lists to improve behavior for users with no javascript

This patch moves the creation of some js-based function links to the script so that non-functioning links will not display when javascript is turned off. Other links which require TMPL processing are hidden with CSS and shown with JS.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofix crash introduced in previous patch
Galen Charlton [Wed, 15 Jul 2009 02:00:36 +0000 (22:00 -0400)]
fix crash introduced in previous patch

In the previous patch,

-    my @subf = $field->subfields;
-    (defined @subf) or @subf = ();

is not equivalent to

+    my @subf = $field->subfields || ();

as, the results of $field->subields is interpeted in scalar
context, not list context, resutling in @subf containing
the number of subfields, not the subfield data itself, which
engenders the error

Can't use string ("1") as an ARRAY ref while "strict refs" in use

later on.  Changing the operator to 'or' instead of '||'
fixes this.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBranch auto-selection in additem
Joe Atzberger [Wed, 8 Jul 2009 21:52:18 +0000 (16:52 -0500)]
Branch auto-selection in additem

Adding a new item should pre-select the library you are logged in at, where possible.
Use GetBranchesLoop.  This solves indy branches filtering, and sort order problems.
Set default off of ->{selected}, to establish pre-selected branch.
Fix flags check in onlymine sub, so superlibrarian + other flags still gets everything.
Removed defined(@array) check, since perl -wc warns it is deprecated.
Note new FIXME for botched date processing.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoLDAP overhaul
Joe Atzberger [Tue, 30 Jun 2009 14:14:50 +0000 (09:14 -0500)]
LDAP overhaul

Allow replicate and update to be zero.
Break out logic into separate subs.
Do only one bind attempt depending on setting, instead of
necessarily failing first before trying auth_by_bind.

POD added for active directory and to document permutations of
behavior given different conditions.  Fixed mistaken debug lines
that called "print STDERR printf ...", i.e. printed the line to output
and "1" to the error log.  Added principal_name feature for generating
bind user from Koha userid.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2539. Remove unintegrated "spsuggest" code from search scripts.
Joe Atzberger [Thu, 2 Jul 2009 03:47:35 +0000 (22:47 -0500)]
Bug 2539. Remove unintegrated "spsuggest" code from search scripts.

The intent of kohaspsuggest is very confused.  It wanted to simultaneously
log every search query, and get spelling suggestions from a totally different
database_host:db_user:db_password:database.  The implementation seems
never have really made it into 3.0, however, since the only trace of the
tables it wants to query are in misc/migration_tools/22_to_30/phrase_log.sql

The job misc/spellcheck_suggest/make_spellcheck_suggest.pl does not even
target the same remote DB as the syspref tells the search code to do.  Instead, it hits the
local DB and, not finding the tables that have no way of existing in a 3.0
install, it CREATES its own tables spontaneously, using MyISAM storage, no less.
This script should be drastically overhauled, or more likely just removed.

Other fixes:
Commented out unconditional warn!
Also reduced bizarre whitespace amounts in catalogue/search.pl and
fixed warning as recommended by perl -wc:
    Scalar value @newresults[0] better written as $newresults[0]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>