koha.git
5 years agoBug 15675 - Add issue_id column to accountlines and use it for updating fines
Kyle M Hall [Tue, 26 Jan 2016 16:42:44 +0000 (16:42 +0000)]
Bug 15675 - Add issue_id column to accountlines and use it for updating fines

Right now, fines are updated based on the fine description. There are a
number of areas where this can go wrong ( date or time format changing,
title being modified, etc ). Now that issues has a unique
identifier, we should use that for selection and updating of fines.

Test Plan:
1) Apply this patch
2) Test creating and updating fines via fines.pl
   and checking in overdue items. No changes should be noted.
3) prove t/db_dependent/Circulation.t

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15721: (QA followup) pick the most probable first
Tomas Cohen Arazi [Tue, 1 Mar 2016 13:12:29 +0000 (10:12 -0300)]
Bug 15721: (QA followup) pick the most probable first

Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15721: (followup) Add apache2ctl to C4::Context::get_versions
Marc Véron [Fri, 19 Feb 2016 15:52:48 +0000 (16:52 +0100)]
Bug 15721: (followup) Add apache2ctl to C4::Context::get_versions

See comment #6

Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15721: About page does not display Apache version
Marc Véron [Tue, 2 Feb 2016 10:34:16 +0000 (11:34 +0100)]
Bug 15721: About page does not display Apache version

This patch changes about.pl to get version information from
C4::Context where applicable and fixes missing display of
the Apache version e.g. for Apache/2.2.22

To test:
- Without patch, open about page in staff client
- Remember contents of tab 'Server information'
  (e.g. make a screenshot)
- Apply patch
- Verify, that the About page displays the same information
  as before rsp. additionally displays Apache version if
  it was missing without patch.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as described
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15804: [Revised] Use standard dialog style for confirmation of MARC subfield...
Owen Leonard [Thu, 11 Feb 2016 17:23:49 +0000 (12:23 -0500)]
Bug 15804: [Revised] Use standard dialog style for confirmation of MARC subfield deletion

When deleting a MARC framework subfield, the confirmation message is not
styled. This patch modifies the template to style the confirmation
message like similar ones.

Depends on Bug 15785 - Use Font Awesome icons in confirmation dialogs

To test, apply the patch and go to Administration -> MARC framworks.

 - Click 'MARC structure' for a framework you can edit.
 - Click 'subfields' for a tag you can edit.
 - Click 'Delete' for a subfield you can delete. You should see a
   confirmation dialog styled like other "alert" type dialogs.
 - Test both canceling and confirming deletion to confirm that both
   function correctly.

Revised to fix conflicts with rollback of Bug 13618

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as expected. Revised according with bug revert 13618

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15867: Move MARC modification templates JavaScript into separate file
Owen Leonard [Fri, 19 Feb 2016 18:30:44 +0000 (13:30 -0500)]
Bug 15867: Move MARC modification templates JavaScript into separate file

The JavaScript embedded in the MARC modification templates template is
not dependent on template processing to such an extent that it can't
be safely moved to a separate file. This patch does so, adding
definition of a some translatable strings to the template.

Other minor changes: A couple of JSHint warnings corrected, a couple of
missing semicolons added to template markup.

To test, apply the patch and go to Tools -> MARC modification templates

- Confirm that The add/update form works normally with various actions
  (Add/update,Delete,Move, etc.).
- Confirm that template switching works correctly.
- Confirm that template deletion confirmation works correctly.
- Confirm that cancelling an edit works correctly

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15872: Rancor: Ctrl-Shift-X has incorrect description in "Keyboard shortcuts"
Jesse Weaver [Fri, 19 Feb 2016 21:51:58 +0000 (14:51 -0700)]
Bug 15872: Rancor: Ctrl-Shift-X has incorrect description in "Keyboard shortcuts"

Should be "Delete current subfield."

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15884 - Vendor contract deletion warning is incorrectly styled
Owen Leonard [Tue, 23 Feb 2016 14:16:13 +0000 (09:16 -0500)]
Bug 15884 - Vendor contract deletion warning is incorrectly styled

When deleting a contract in  Acquisitions -> Vendor -> Contracts, the
deletion confirmation message is not styled with the standard "dialog
alert" <div>. This patch modifies the confirmation markup to match the
standard.

To test, apply the patch and go to Acquisitions -> [ a vendor] ->
Contracts

- Try deleting a contract. The confirmation box should have the standard
  "dialog alert" class.
- Test the 'confirm' and 'cancel' actions and make sure both complete
  correctly.

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15920: Clean up and fix errors in batch checkout template
Owen Leonard [Thu, 25 Feb 2016 18:45:54 +0000 (13:45 -0500)]
Bug 15920: Clean up and fix errors in batch checkout template

The batch checkout template has some markup and JavaScript problems
which need to be resolved, including:

- Mismatched <h3></h1>
- JavaScript includes which are not used
- Incorrect DataTables configuration
- Incorrect class on warning dialogs
- Incorrect terminology: Use "checkout" instead of "issue"

This patch also changes the markup and styling of batch checkout errors,
using Font Awesome icons to retain highlighting of warnings and errors
while (I hope) improving readability.

To test, apply the patch and go to batch checkout for a patron for whom
batch checkouts are enabled.

- Check out a batch of barcodes. Include items which will trigger errors
  or warnings. For example: Invalid barcodes, lost items, items which
  are already checked out, items which are on hold for another patron,
  items which are damaged.

- When the table of items is displayed so that you can confirm the
  checkout, make sure the table is sortable.

- Think about whether the style changes on warnings and errors are an
  improvement.

- Try to initiate a batch checkout to a patron who is restricted. You
  should see an "alert" style dialog instead of a "message" style one.

- Validate the HTML and confirm that there are no errors raised by this
  template's markup.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as described

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15926: Add help for item search fields admin
Nicole C Engard [Fri, 26 Feb 2016 16:03:26 +0000 (16:03 +0000)]
Bug 15926: Add help for item search fields admin

This patch will add the missing help file to the item
search fields admin page.

To test:
* Go to administration > Item search fields
* Click Help
* Confirm help is there and correct.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15674: Use double-quote instead of simple-quote
Jonathan Druart [Tue, 1 Mar 2016 08:36:38 +0000 (08:36 +0000)]
Bug 15674: Use double-quote instead of simple-quote

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15674: Make "Column visibility" translatable
Jonathan Druart [Mon, 29 Feb 2016 07:32:14 +0000 (07:32 +0000)]
Bug 15674: Make "Column visibility" translatable

The "Column visibility" text button was not translatable, now it is.

Test plan:
1/ Update the template for a given language and translate the "Column
visibility" string
2/ Go on admin/currency.pl
=> The string should be translated.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15880 - Serials new frequency link should be a toolbar button
Owen Leonard [Mon, 22 Feb 2016 18:09:00 +0000 (13:09 -0500)]
Bug 15880 - Serials new frequency link should be a toolbar button

This patch converts the "new frequency" link to a Bootstrap-style
toolbar button in order to maintain consistency. Also included in this
patch are some other minor markup corrections:

- A colon and space after labels
- A 'Cancel' link instead of a button.
- "Required" classes for a required field.

To test, apply the patch and go to Serials -> Manage frequencies.

- Test the "New frequency" button
- Confirm that the changes to the entry form look correct.

Followed test plan, displays as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15881 - Serials new numbering pattern link should be a toolbar button
Owen Leonard [Mon, 22 Feb 2016 18:21:28 +0000 (13:21 -0500)]
Bug 15881 - Serials new numbering pattern link should be a toolbar button

This patch converts the "new numbering pattern" link to a
Bootstrap-styled toolbar button for consistency with other pages in
Koha. This patch also includes minor markup corrections:

- Standardizing on the phrase "Numbering patterns" by eliminating the
  occasional use of "number patterns."
- Removing mistaking closing slash on <select>
- Using standard "Cancel" link instead of a button.
- Adding a colon and space after labels.
- Fixing of "no existing patterns" message.

To test, apply the patch and go to Serials -> Numbering patterns

- Confirm that the "New numbering pattern" button looks correct and
  works correctly.
- Confirm that the entry form looks correct and that the cancel link
  works as expected.

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15939: Action logs - Do not default dates to today
Jonathan Druart [Tue, 1 Mar 2016 10:52:39 +0000 (10:52 +0000)]
Bug 15939: Action logs - Do not default dates to today

When accessing the modification logs from a link that does not
explicitly set the to and from dates (e.g., from patron or bib details),
no results are displayed unless the object had an action occur during
the current day.

This is a side-effect of commit 5dceb851 for bug 13813.

Test plan:
- View the modification logs of a record which has already been modified
(/tools/viewlog.pl?do_it=1&modules=CATALOGUING&action=MODIFY&object=XXX)
=> Without this patch, you won't see any logs (unless you have modified
the record today)
=> With this patch, the behavior is the same as prior bug 13813 (you can
check in 3.20.x), you will see all logs

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15842 - Cannot import patrons if the csv file does not contain privacy_guarantor_...
Kyle M Hall [Mon, 15 Feb 2016 12:58:14 +0000 (12:58 +0000)]
Bug 15842 - Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts

When importing patrons with a csv file which does not contain the privacy_guarantor_checkouts column in the header, you will get
DBIx::Class::Storage::DBI::_dbh_execute(): Column 'privacy_guarantor_checkouts' cannot be null at /home/koha/src/C4/Members.pm line 768

The same issue seems to occur for sms_provider_id.

Test Plan:
1) Attempt to import patron csv file with no privacy_guarantor_checkouts column
2) Note the error
3) Apply this patch
4) Repeat step 1
5) The error should no longer occur

NOTE: While this patch does work, should it be solved only
at this level? The issue that there is the lack of those two
fields on the tools screen still exists.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15916: Datatables - buttons area should be defined
Jonathan Druart [Mon, 29 Feb 2016 08:34:46 +0000 (08:34 +0000)]
Bug 15916: Datatables - buttons area should be defined

Commit 243b797dd11bc0ac1f475195ab765ffbf2220f8b
    Bug 15285: Update common files

Set 'B' to the default dom of Datatable constructor.
This cannot work if there is no button defined.

This patch defined an empty 'buttons' param for this constructor, DT
does not raised an error anymore when initialising.

Test plan:
Confirm that the tables on the following tables are not broken:
- circ/waitingreserves.pl
- circ/reserveratios.pl
- patron_lists/lists.pl
- virtualshelves/shelves.pl
- acqui/invoices.pl
And with datatables:
- circ/circulation.pl
- admin/currency.pl

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15923: Fix --id_list_file option for misc/export_records.pl
Jonathan Druart [Mon, 29 Feb 2016 10:56:33 +0000 (10:56 +0000)]
Bug 15923: Fix --id_list_file option for misc/export_records.pl

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15923: Take the id list file into account when exporting records
Jonathan Druart [Mon, 29 Feb 2016 08:10:59 +0000 (08:10 +0000)]
Bug 15923: Take the id list file into account when exporting records

When exporting records (tools/export.pl or misc/export_records.pl), a
file of ids (authid or biblionumber) can be passed to filter the
results.
Bug 14722 has broken this behavior.

Test plan:
Export records and specify a list of records to filter the results.
Prior to this patch, the record with the id 1 was exported.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 14168 [QA Followup] - Fix typo
Kyle M Hall [Thu, 28 Jan 2016 21:08:21 +0000 (21:08 +0000)]
Bug 14168 [QA Followup] - Fix typo

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 14168 - enhance streaming cataloging to include youtube
Mirko Tietgen [Thu, 22 Oct 2015 17:39:37 +0000 (19:39 +0200)]
Bug 14168 - enhance streaming cataloging to include youtube

Add optional embedding of YouTube videos via HTML5Media.
New syspref: HTML5MediaYouTube: Embed/Don't embed videos.
Format WEBM is hardcoded as it is the only format accepted by all
modern browsers.

Test plan:
- apply patch
- catalogue a YouTube link in 856$u
- turn on HTML5MediaEnabled and HTML5MediaYouTube
- open the record in OPAC and staff client, check that the
  'Play media' tab is showing and playing the video works.

Possible enhancements for followups:
- check available formats, offer quality choice
- accept official YT URL shortener

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Works perfectly!

Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoRevert Bug 11081 - Port Koha::Contrib::Tamil indexer into Koha code base
Kyle M Hall [Tue, 1 Mar 2016 16:38:50 +0000 (16:38 +0000)]
Revert Bug 11081 - Port Koha::Contrib::Tamil indexer into Koha code base

It has been decided that Moose should not be a dependency for Koha, and
that this patch set should be reverted to avoid it's use.

This reverts commit 43bcc1c42cd347ab1565b27038ec3350a1ecf94f.
This reverts commit e5f4a0e3d58baa722336494e178595aabf183361.
This reverts commit 6d44b0a91ad0245b45b367e543f097ba64856e5f.

5 years agoBug 15471 [QA Followup] - Revert use of raw method which is no longer used do to...
Kyle M Hall [Mon, 29 Feb 2016 16:35:15 +0000 (16:35 +0000)]
Bug 15471 [QA Followup] - Revert use of raw method which is no longer used do to the reversion of bug 13618

Revert "Bug 15471 [QA Followup] - Fix error causing visibility button to not display"

This reverts commit 8e997fbafcc635b275c6ca1211e47a4cd38c8140.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 14395 - DBRev 3.23.00.031
Kyle M Hall [Fri, 26 Feb 2016 14:33:27 +0000 (14:33 +0000)]
Bug 14395 - DBRev 3.23.00.031

5 years agoBug 14395: Unit tests
Holger Meißner [Mon, 27 Jul 2015 13:18:53 +0000 (15:18 +0200)]
Bug 14395: Unit tests

This patch adds test cases for the new syspref NoRenewalBeforePrecision.
Tests if GetSoonestRenewDate returns correct values for both 'date' and
'exact_time' settings.
Also adds a few comments related to bugs 7413 and 14101.

To test:

1) prove t/db_dependent/Circulation.t

Sponsored-by: Hochschule für Gesundheit (hsg), Germany
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
5 years agoBug 14395: Code changes
Holger Meißner [Thu, 16 Jul 2015 13:22:55 +0000 (15:22 +0200)]
Bug 14395: Code changes

This patch updates the calculation of 'No renewal before' to include the
new syspref NoRenewalBeforePrecision.

To test:

1) Check out an hour-based loan with 'No renewal before' set to 1.
   Switch syspref NoRenewalBeforePrecision between 'date' and 'exact
   time'. Confirm that with both settings the item cannot be renewed
   until exactly one hour before due.

2) Check out a day-based loan with 'No renewal before' set to 1 day.
   Confirm that:
   * with NoRenewalBeforePrecision set to 'date', renewal is possible
     at 12:00 AM on the day before due.
   * with NoRenewalBeforePrecision set to 'exact time', renewal is
     possible at 11:59 PM on the day before due.

Sponsored-by: Hochschule für Gesundheit (hsg), Germany
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
5 years agoBug 14395: Add new syspref NoRenewalBeforePrecision
Holger Meißner [Wed, 15 Jul 2015 08:49:41 +0000 (10:49 +0200)]
Bug 14395: Add new syspref NoRenewalBeforePrecision

Currently the 'NoRenwalBefore' setting is always based on the exact
DateTime of the due date. This patch introduces a new global syspref for
choosing if 'NoRenewalBefore' should instead be calculated based on date
only. This is only relevant for loans caluclated in days. Hourly loans
are not affected.

To test:

1) Apply bug 14101, then apply this patch.

2) Run installer/data/mysql/updatedatabase.pl

3) Confirm that a new syspref NoRenewalBeforePrecision is available
   in administration. It should let you choose between 'date' (default)
   and 'exact time'.

Sponsored-by: Hochschule für Gesundheit (hsg), Germany
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
5 years agoBug 15311 [QA Followup] - Remove use of .raw method as it's use was reverted
Kyle M Hall [Fri, 26 Feb 2016 14:21:16 +0000 (14:21 +0000)]
Bug 15311 [QA Followup] - Remove use of .raw method as it's use was reverted

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 15311 - DBRev 3.23.00.030
Kyle M Hall [Fri, 26 Feb 2016 14:20:39 +0000 (14:20 +0000)]
Bug 15311 - DBRev 3.23.00.030

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 15311 - Let libraries set text to display when OpacMaintenance = on
Barry Cannon [Wed, 16 Dec 2015 10:37:17 +0000 (10:37 +0000)]
Bug 15311 - Let libraries set text to display when OpacMaintenance = on

Added new systempreference OpacMaintenanceNotice.
When OpacMaintenance is ON the HTML contents of OpacMaintenanceNotice will
be displayed.
Enabling OpacMaintenance is all that is required to enable this preference.
If OpacMaintenanceNotice is undefined, the default (original) notice will
appear when OpacMaintenance is enabled.

To test:
- Enable OpacMaintenance systempreference
- Observe the default maintenance message when OPAC is viewed
- Edit OpacMaintenanceNotice systempreference, adding custom HTML
- Observe the custom HTML appear on the opac
- Remove OpacMaintenanceNotice (mindful of orphaned spaces etc.)
- Observe the default opac notice appears in the opac
- Disable OpacMaintenance
- Observce opac is back online

Moving code to atomic update and fixing merge conflict

NOTE: Accounted for an SQL typo and autoescaping of the template.
      If someone else could test this, then I would be fine with
      marking it signed off.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 14523 - Google jackets being blocked when OPAC using HTTPS
Barry Cannon [Tue, 14 Jul 2015 11:25:55 +0000 (12:25 +0100)]
Bug 14523 - Google jackets being blocked when OPAC using HTTPS

This patch changes the Google jackets URL to use HTTPS instead of HTTP.

Test Plan:
1) Enable Google Jackets
2) Ensure the Koha OPAC instance is configued to use HTTPS
3) Confirm Google jackets display correctly.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 15697 - [QA Followup] Apply change to NORMARC
Nick Clemens [Tue, 2 Feb 2016 14:31:34 +0000 (14:31 +0000)]
Bug 15697 - [QA Followup] Apply change to NORMARC

This patch switches from UNLESS MARC21 to IF UNIMARC - this way changes
apply to MARC21 and NORMARC and UNIMARC remains unaffected

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 15697: Unnecessary comma between title and subtitle on opac-detail.pl
Nick Clemens [Thu, 28 Jan 2016 20:33:58 +0000 (20:33 +0000)]
Bug 15697: Unnecessary comma between title and subtitle on opac-detail.pl

To test:
1 - Go to Administration->Keyword to MARC mapping
2 - Add a mapping (or ensure it exists)
    Field name: subtitle
    MARC field: 245
    MARC subfield: b
3 - View a record with a subtitle in the opac
4 - Note in MARC 21 you have "Title of record:, subtitle of record"
5 - Apply patch
6 - View the record again and note the comma is no longer present.

Note: this patch removes the comma only for MARC21 where subtitle is not
repeatable. UNIMARC seems to be repeatable and does not include
punctuation so I believe this may be needed there.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as described. Comma removed from title of the window and breadcrumb
section

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 14199 - DBRev 3.23.00.029
Kyle M Hall [Fri, 26 Feb 2016 14:08:03 +0000 (14:08 +0000)]
Bug 14199 - DBRev 3.23.00.029

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 14199: Modify webinstaller sql files for marc21_orgcode plugin
Marcel de Rooy [Sat, 11 Jul 2015 16:49:45 +0000 (18:49 +0200)]
Bug 14199: Modify webinstaller sql files for marc21_orgcode plugin

This patch updates the sql installer files for new installations.
Occurrences to the three plugins marc21_field_003, 040c and 040d are
replaced by marc21_orgcode.pl.
This has been generated by one sed statement.

Test plan:
[1] Run a new installation or run some of the changed sql files manually.
[2] Verify that marc21_orgcode is linked to fields previously linked to
    the three old plugins.
[3] Do a git grep on the three plugin file names. No occurrences expected.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Have tested the three english sql files:
authorities_normal_marc21.sql: 18 rows with marc21_orgcode (003 and 040a
for 9 auth codes)
marc21_framework_DEFAULT.sql: 1 row with marc21_orgcode (003) -- this patch
does not add them to 040c or 040d; no behavior change..
marc21_simple_bib_frameworks.sql: 8 rows (003 for 8 frameworks)

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
The following files do no longer need an adjustment:
installer/data/mysql/de-DE/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql
installer/data/mysql/es-ES/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql
installer/data/mysql/it-IT/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql
For details, check Bug 15097: Update MARC21 de-DE frameworks to Update 21.
And similar reports for es-ES and it-IT.
Verified this change by installing de-DE in the webinstaller. The plugin for
field 003 was correctly set to marc21_orgcode.pl.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 14199: Database revision for marc21_orgcode.pl
Marcel de Rooy [Sat, 11 Jul 2015 15:36:18 +0000 (17:36 +0200)]
Bug 14199: Database revision for marc21_orgcode.pl

This patch adds the dbrev in atomicupdate, updating the marc structure
for existing installations. (New installation in previous patch.)
And it removes the obsolete plugin files.

Test plan:
Run upgrade. Verify that new plugin is linked (for bib and auth).
Check plugin in editor.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Plugin tested, added to 040a/c/d
Test pass
No koha-qa errors

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 14199: Unify marc orgcode plugins, not overwriting existing values
Marcel de Rooy [Sat, 11 Jul 2015 15:22:41 +0000 (17:22 +0200)]
Bug 14199: Unify marc orgcode plugins, not overwriting existing values

This patch copies code from marc21_field_003.pl to create marc21_orgcode.pl
for more generic use. Other fields like 040c or 040d should use it too.
Note: The plugin is used for authorities too (003, 040a).

One behaviour change is added: If the corresponding field is already
filled, it will not be overwritten.

In the unit test marc21_orgcode already replaces marc21_field_003.

Test plan:
[1] Attach plugin marc21_orgcode to a field (e.g. 003) and test it in
    the MARC editor of Cataloguing or Authorities.
[2] Check if a value is not overwritten any more.
[3] Run unit test t/db_dependent/FrameworkPlugin.t; don't be distracted by
    the noisy warnings of marc21_field_007.pl. They will be addressed on
    another report.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 14658 - DBRev 3.23.00.028
Kyle M Hall [Fri, 26 Feb 2016 13:51:29 +0000 (13:51 +0000)]
Bug 14658 - DBRev 3.23.00.028

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 14658: Remove warning if prefs are not defined
Jonathan Druart [Mon, 15 Feb 2016 16:49:32 +0000 (16:49 +0000)]
Bug 14658: Remove warning if prefs are not defined

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 14658 - (QA followup) make it easier to grep for these syspref names
Jesse Weaver [Fri, 18 Dec 2015 17:20:07 +0000 (10:20 -0700)]
Bug 14658 - (QA followup) make it easier to grep for these syspref names

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 14658 - Split PatronSelfRegistrationBorrowerUnwantedField into two preferences...
Jesse Weaver [Mon, 17 Aug 2015 21:00:10 +0000 (15:00 -0600)]
Bug 14658 - Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing

Test plan:
  1) Make sure there is at least one field in PatronSelfRegistrationBorrowerUnwantedField.
  2) Apply patch, and update database.
  3) Check to make sure that the new system preference
     PatronSelfModificationBorrowerUnwantedField has the same value as
     PatronSelfRegistrationBorrowerUnwantedField.
  4) Verify that the same fields are hidden for self-registering a new
     borrower and edting a new one (both on the OPAC).
  5) Change PatronSelfModificationBorrowerUnwantedField, and verify that
     the two preferences correctly apply to editing vs. creating.

Signed-off-by: Michael Sauers <msauers@dospace.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 4941 - DBRev 3.23.00.027
Kyle M Hall [Fri, 26 Feb 2016 12:28:55 +0000 (12:28 +0000)]
Bug 4941 - DBRev 3.23.00.027

5 years agoBug 4941 [QA Followup] - Retain singleBranchMode in list of sysprefs passed to XSLT
Kyle M Hall [Fri, 26 Feb 2016 12:24:04 +0000 (12:24 +0000)]
Bug 4941 [QA Followup] - Retain singleBranchMode in list of sysprefs passed to XSLT

5 years agoBug 4941: Remove the singleBranchMode system preference
Jonathan Druart [Wed, 6 Jan 2016 10:41:44 +0000 (10:41 +0000)]
Bug 4941: Remove the singleBranchMode system preference

The singleBranchMode system preference does not make sense.
Either the install has only 1 library defined or several. In both case,
we can easily guess the behavior to follow.

So the idea of this patch is to replace the fetch of this syspref with a
call to count the number of libraries defined in DB.

Test plan:
1/ From a fresh Koha install, execute the DB entry to remove the pref.
2/ Define only 1 library
3/ Confirm that Koha behaves the same as before (try to change your
library, look at the facets)
4/ Create another library (or more) and reinsert the pref and set it:
  insert into systempreferences (variable, value)
    values('singleBranchMode', 1);
5/ Execute the DB entry
You should get a warning message.
6/ Repeat 3.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Does what it says, but will change behaviour for any Koha install that
has 2 branches defined, One circulation, and this preference set.
If that is an acceptable change, we might need to make sure this is noted well in the
release notes.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 4940: DB Changes
Jonathan Druart [Wed, 6 Jan 2016 10:41:42 +0000 (10:41 +0000)]
Bug 4940: DB Changes

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
http://bugs.koha-community.org/show_bug.cgi?id=4941

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 4941: Make tests non DB dependent
Jonathan Druart [Wed, 6 Jan 2016 10:41:21 +0000 (10:41 +0000)]
Bug 4941: Make tests non DB dependent

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 15798: Remove C4::Koha::displayServers
Jonathan Druart [Wed, 10 Feb 2016 17:37:11 +0000 (17:37 +0000)]
Bug 15798: Remove C4::Koha::displayServers

This subroutine is no longer is use and can be removed.

Test plan:
  git grep displayServers
should not return any results.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 15071 [QA Followup] - Update compiled css again
Kyle M Hall [Wed, 24 Feb 2016 16:45:36 +0000 (16:45 +0000)]
Bug 15071 [QA Followup] - Update compiled css again

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 15071 - In OPAC search results, "checked out" status should be more visible ...
Owen Leonard [Thu, 18 Feb 2016 02:19:30 +0000 (21:19 -0500)]
Bug 15071 - In OPAC search results, "checked out" status should be more visible - Compiled CSS

Compiled CSS file.

Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 15071 - In OPAC search results, "checked out" status should be more visible
Owen Leonard [Thu, 18 Feb 2016 02:17:10 +0000 (21:17 -0500)]
Bug 15071 - In OPAC search results, "checked out" status should be more visible

The prog template in the OPAC designated a color for the "unavailable"
class associated with items in search results which are checked out.
This class never made it into the Bootstrap theme. This patch adds it to
the Bootstrap theme's LESS file.

To test, apply the patch and search the OPAC for terms that will return
checked out items. In the list of search results, on the "availability"
line, the "Checked out" text should now be red. The change is visible
with XSLT on or off.

Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 15891 [Followup]
Kyle M Hall [Wed, 24 Feb 2016 13:34:09 +0000 (13:34 +0000)]
Bug 15891 [Followup]

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 15891: Fix errors on updatedatabase
Marcel de Rooy [Wed, 24 Feb 2016 12:39:38 +0000 (13:39 +0100)]
Bug 15891: Fix errors on updatedatabase

Two curly braces..

Test plan:
Run the update.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoDBRev Bug 15343 - Allow patrons to choose their own password on self registration
Brendan Gallagher [Wed, 24 Feb 2016 04:09:36 +0000 (04:09 +0000)]
DBRev Bug 15343 - Allow patrons to choose their own password on self registration

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15343 [QA Followup]
Nick Clemens [Fri, 5 Feb 2016 16:01:17 +0000 (16:01 +0000)]
Bug 15343 [QA Followup]

* Check for leading/trailing spaces in password
* Check hashed password in tests

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15343 [QA Follow up] Fix captcha display
Nick Clemens [Fri, 15 Jan 2016 15:53:30 +0000 (15:53 +0000)]
Bug 15343 [QA Follow up] Fix captcha display

Make captcha visible even if password field is hidden
Remove password confirmation field before submitting modification

Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15343 [QA Followup] - Fix issues
Kyle M Hall [Fri, 18 Dec 2015 19:30:13 +0000 (19:30 +0000)]
Bug 15343 [QA Followup] - Fix issues

1) "Contact information" should be "Password"
2) Don't pass sysprefs from the script to the template, use Koha.Preference()
3) minPasswordLength is optional, we cannot always assume it is set
4) Password field when does not follow convention completely when mandatory

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15343 - Allow user to set password on opac-memberentry.pl
Nick Clemens [Sat, 12 Dec 2015 02:10:06 +0000 (02:10 +0000)]
Bug 15343 - Allow user to set password on opac-memberentry.pl

This patch allows patrons to create thier own password during OPAC self
registration.  It sets the password field to be hidden by default, and
allows for a system generated password if no password is supplied and
field is not mandatory

1 - Apply patch
2 - run updatedatabase.pl
3 - Check syspref "PatronSelfRegistrationBorrowerUnwantedField" - it
should contain 'password'
4 - Check self registration on opac - there should be no change
5 - Remove 'password' from PatronSelfRegistrationBorrowerUnwantedField
6 - Password field should now be visible in OPAC self registration
7 - Register a patron: If no passwor is supplied you should get a system
generated password
8 - Register a patron with a password, your password should be used
9 - Add 'password' to PatronSelfRegistrationBorrowerMnadatoryField
10 - Attempt to register a patron with no password - it should fail
11 - Try all combinations if mismatched/short/missing passwords and view
correct error messages
12 - prove t/db_dependent/Members.t

Sponsored by : Do Space (www.dospace.org)

Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15465 [QA Followup] - Update wording, switch logo, add links
Kyle M Hall [Thu, 4 Feb 2016 22:38:32 +0000 (22:38 +0000)]
Bug 15465 [QA Followup] - Update wording, switch logo, add links

* Changed wording to not be github-centric
* Added suggested links
* Switched to more traditional logo

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15465 - Created README.md file for github
Gus [Wed, 20 Jan 2016 20:44:00 +0000 (20:44 +0000)]
Bug 15465 - Created README.md file for github

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15471 [QA Followup] - Fix error causing visibility button to not display
Kyle M Hall [Thu, 4 Feb 2016 22:13:55 +0000 (22:13 +0000)]
Bug 15471 [QA Followup] - Fix error causing visibility button to not display

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15471: Add column settings and filters to Holds queue table
Julian Maurice [Tue, 5 Jan 2016 11:24:57 +0000 (12:24 +0100)]
Bug 15471: Add column settings and filters to Holds queue table

Add column visibility menu using DataTables Buttons
Add a text filter on top of each column
Also extend page width so that the large table is better centered

Depends on bug 15285

Test plan
1. Go to Holds queue page (circ/view_holdsqueue.pl)
2. Check that table sorting and filtering work well and that you can
   hide each column
3. Go to Admin > Configure columns and change the settings for this
   table (Circulation > view_holdsqueue > holds-table). Verify that the
   settings work by going again to the Holds queue page
4. Check that filters continue to work after hiding some columns

Tested on top of 15285, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15629 [QA Followup]
Kyle M Hall [Fri, 5 Feb 2016 00:29:22 +0000 (00:29 +0000)]
Bug 15629 [QA Followup]

* Use ->id instead of ->branchcode when possible to eliminate use of that nomenclature
* Fix bad use of ->branchcode to ->{branchcode} for unblessed hashref  version of Koha::Library

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15629: Fix tests - Koha::Library does not have ->categories but ->get_categories
Jonathan Druart [Tue, 2 Feb 2016 13:58:16 +0000 (13:58 +0000)]
Bug 15629: Fix tests - Koha::Library does not have ->categories but ->get_categories

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15629: Koha::Libraries - Remove GetBranchInfo
Jonathan Druart [Wed, 20 Jan 2016 13:22:48 +0000 (13:22 +0000)]
Bug 15629: Koha::Libraries - Remove GetBranchInfo

C4::Branch::GetBranchInfo was only used once in opac/opac-suggestions.pl
The occurrence can easily be replaced by a call to Koha::Libraries->find

Test plan:
1/ Create a suggestion for library A
2/ Enable OPACViewOthersSuggestions
3/ Use a patron from library B to see the suggestions
4/ The "Suggested for" value should be correctly filled with the library
A name.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15629: Koha::Libraries - Remove ModBranch
Jonathan Druart [Wed, 20 Jan 2016 13:13:14 +0000 (13:13 +0000)]
Bug 15629: Koha::Libraries - Remove ModBranch

This subroutine was only used in tests to add/update a library.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15629: Koha::Libraries - Remove GetBranchDetail
Jonathan Druart [Wed, 20 Jan 2016 12:17:43 +0000 (12:17 +0000)]
Bug 15629: Koha::Libraries - Remove GetBranchDetail

C4::Branch::GetBranchDetail retrieved library infos, it could be easily
replaced with Koha::Libraries->find

When this change needs other big changes, the unblessed method is
called, to manipulate a hashref (as before) instead of a Koha::Library
object (for instance when $library is sent to GetPreparedLetter).

Test plan:
1/ Print a basket group, the library names should be correctly
displayed.
2/ Enable emailLibrarianWhenHoldIsPlaced and place a hold, a HOLDPLACED
notice will be generated (focus on the library name)
3/ Edit a patron and change his/her library
4/ Generate the advanced notices (misc/cronjobs/advance_notices.pl) and
have a look at the generated notices
5/ Same of overdues notices
6/ Set IndependentBranches and use a non superlibrarian user to place a
hold. The "pickup at" should be correctly filled.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15629: Koha::Libraries - Remove GetBranchesInCategory (3)
Jonathan Druart [Wed, 20 Jan 2016 11:22:19 +0000 (11:22 +0000)]
Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (3)

C4::Branch::GetBranchesInCategory is not used anymore and can be
removed.

Test plan:
  git grep GetBranchesInCategory
should not return any result.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15629: Koha::Libraries - Remove GetBranchesInCategory (2)
Jonathan Druart [Wed, 20 Jan 2016 11:22:07 +0000 (11:22 +0000)]
Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (2)

C4::Branch::GetBranchesInCategory can be replaced with
Koha::LibraryCategory->libraries

Test plan:
1/ Define some 1+ group of libraries with 1+ libraries each
2/ Go on the advanced search (OPAC and Staff) and select a group of
libraries
3/ The result should be consistent and only include record from these
libraries

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15629: Koha::Libraries - Remove GetBranchesInCategory (1)
Jonathan Druart [Wed, 20 Jan 2016 11:21:12 +0000 (11:21 +0000)]
Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (1)

For consistency, the branchcodes method of Koha::LibraryCategory should be
named libraries.
At the moment, there is only one occurrence, in admin/branches.pl

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15631: Koha::Cities - remove getidcity and GetCities
Jonathan Druart [Wed, 20 Jan 2016 15:00:33 +0000 (15:00 +0000)]
Bug 15631: Koha::Cities - remove getidcity and GetCities

C4::Members::getidcity and C4::Members::GetCities simply retrieved
cities info from the cities table.
The job done in members/memberentry.pl looked really weird and complicated.
Either I have missed something, or this patch can simplify it.

The expected behavior is:
1. Create a new patron => No city selected
2. Edit an existing patron => The borrowers.city value is selected
3. Add a guarantee => The borrowers.city of the guarantor is selected
4. Edit a guarantee => The borrowers.city of the guarantee is selected

Test plan:
Confirm that the expected behaviors are the ones before and after this patch.

Signed-off-by: Natasha <tasham_8@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15631: Koha::Cities - remove getzipnamecity
Jonathan Druart [Wed, 20 Jan 2016 14:59:48 +0000 (14:59 +0000)]
Bug 15631: Koha::Cities - remove getzipnamecity

C4::Members::getzipnamecity was not used and can be remove safely.

Test plan:
  git grep getzipnamecity
should not return any result.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15640: Removing title for links on circulation-home.tt
Aleisha [Wed, 27 Jan 2016 22:25:08 +0000 (22:25 +0000)]
Bug 15640: Removing title for links on circulation-home.tt

To test:

Go to Circulation and ensure there are no titles on hover over the links

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15662: String and translatability fix to Label Creator
Aleisha [Tue, 26 Jan 2016 02:12:38 +0000 (02:12 +0000)]
Bug 15662: String and translatability fix to Label Creator

To test:
1) Go to Tools -> Label Creator -> New label batch
2) Add an item
3) Click 'Remove selected items' button. Confirm message now reads "Please select at least one label to delete."
4) Click 'Remove duplicates' button. Confirm message now reads "Duplicate item(s) removed from batch number X: Y", all in bold.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Rewording Ok for translatability purpose

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15665: Better wording of error messages when importing MARC frameworks
Aleisha [Tue, 26 Jan 2016 04:45:51 +0000 (04:45 +0000)]
Bug 15665: Better wording of error messages when importing MARC frameworks

UPDATE: Making error messages the same

To test:
1) Go to Admin -> MARC frameworks
2) Click Import next to any framework. You won't actually be overwriting or importing anything as this is only a string fix, so it can be an existing framework
3) Click the Import button without attaching any file. Confirm it says "Please select a spreadsheet (.csv, .ods, .xml) file." and that this makes sense to you
4) Attempt to attach a file that is not a .csv, .ods or .xml file. You should instantly get an error message saying "Please select a CSV (.csv), ODS (.ods) or XML (.xml) file." Confirm this shows up and makes sense to you

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Rewording Ok. Works as described

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15671 - Show branch name instead of branch code in checkout history
Owen Leonard [Wed, 17 Feb 2016 23:27:11 +0000 (18:27 -0500)]
Bug 15671 - Show branch name instead of branch code in checkout history

When viewing the checkout history for a title the branchcode is
displayed. This patch alters the template to show the library name
instead.

To test, apply the patch and locate a title in the staff client which
has been checked out at least once. From the detail page, click
"Checkout history" in the sidebar. The "Checked out from" column of the
checkout history table should show the library name instead of the
branchcode.

Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15713: Restart zebra when rotating logfiles
Marcel de Rooy [Mon, 1 Feb 2016 12:48:06 +0000 (13:48 +0100)]
Bug 15713: Restart zebra when rotating logfiles

Somehow, it may happen that Zebra keeps writing to the old rotated logfile
with extension .log.1. I must add that although I saw that happen (a new
log was created and was empty, while Zebra kept writing to log.1 for weeks),
I cannot reproduce it every time.

By stopping the zebra server in prerotate and starting it again in
postrotate, this should not happen at all. In practice, this implies that
your Zebra server is restarted once a week.

Note: The existing sharedscripts directive makes sure that these actions
are not executed for all individual logfiles but once for all matching
logfiles (even when running multiple instances).

Test plan:
[1] Apply the change in koha-common.logrotate to the file
    /etc/logrotate.d/koha-common.
[2] Run logrotate -f /etc/logrotate.conf (forcing a logrotate).
[3] Check in zebra-error.log that your zebra server was stopped
    ('killed by signal 15').
[4] Verify that your Zebra server runs (read: has been restarted).
    (Do a search..)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15714: Add zebra_loglevels to koha-conf.xml
Marcel de Rooy [Wed, 3 Feb 2016 14:59:02 +0000 (15:59 +0100)]
Bug 15714: Add zebra_loglevels to koha-conf.xml

This patch adds a commented zebra_loglevels line to the config file.
Behavior does not change, but an admin can easily edit the variable.

Test plan:
Nothing really changed. But if you are not so sure about that, apply the
change to /etc/koha/koha-conf-site.xml.in and run koha-create. Check
that the new koha-conf contains the line and is not messed up.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15714: Remove zebra.log and add loglevels
Marcel de Rooy [Tue, 2 Feb 2016 15:40:06 +0000 (16:40 +0100)]
Bug 15714: Remove zebra.log and add loglevels

The file zebra.log is actually not used, because daemon's --output
parameter sends all message to zebra-output (making that stdout
goes there too and --stdout does nothing). We do not need any
differentiation (if any at all) here; behavior does not change.

Note: zebra-error will only contain the daemon's error messages and not
the zebra error messages! So you will probably only find messages about
stopping zebra in zebra-error.

The loglevels are by default none,fatal,warn and can be changed via the
zebra_loglevels config variable (read by koha-functions.sh). If you remove
'none', you will have request-messages in the log. You can also keep 'none'
and add 'request' to achieve something similar (undocumented however).

Some of the parameters passed to daemon when stopping zebra are
superfluous and have been removed.

Test plan:
[1] Remove the file zebra.log. Look at last lines in zebra-error and
    zebra-output.
[2] Remove zebra_loglevels from koha-conf (if present).
    Start/restart Zebra. Search to verify if Zebra runs.
    Stop Zebra and check zebra-error for a new line (killed by signal 15).
[3] Add fatal,warn in koha-conf:zebra_loglevels (do not include 'none').
    Start Zebra. Check zebra-output for a line "[log] zebra_start".
    Do a search and check zebra-output for lines with "[request]".
[4] Verify that zebra.log did not appear again.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15714: Add get_loglevels to koha-functions.sh
Marcel de Rooy [Mon, 1 Feb 2016 14:36:26 +0000 (15:36 +0100)]
Bug 15714: Add get_loglevels to koha-functions.sh

Preparing for including different log levels in koha-start-zebra.
Note that the default response is none,fatal,warn; this is equal
to the options passed to zebrasrv in koha-start-zebra (for now).

Test plan:
[1] Run on the command line: source koha-functions.sh
[2] Type get_loglevels [your_instance]
    By default, you should see: none,fatal,warn
[3] Add this line to your koha-conf:
    <zebra_loglevels>how,are,you</zebra_loglevels>
[4] Run get_loglevels [your_instance] again.
    Remove the nonsense log levels again..

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15731: Remove C4::Reports::Guided::build_authorised_value_list
Jonathan Druart [Wed, 3 Feb 2016 16:04:38 +0000 (16:04 +0000)]
Bug 15731: Remove C4::Reports::Guided::build_authorised_value_list

This subroutine has been added by
  commit 42acfbf75b7bb4ee53c6a6f035e258a0b522ce10
  Bug 7993: Save reports with Group/Subgroup hierarchy

But it has never been used (or git grep cheats me).

Test plan:
1/ git grep build_authorised_value_list
should not return any result
2/ Create a report, execute it
Everything should work fine.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15769: Remove outdated C4::Koha::slashifyDate subroutine
Jonathan Druart [Tue, 9 Feb 2016 13:40:01 +0000 (13:40 +0000)]
Bug 15769: Remove outdated C4::Koha::slashifyDate subroutine

This subroutine does not make sense anymore (Koha::DateUtils should be
used) and is no longer used.
It can be removed safely.

Test plan:
  git grep slashifyDate
should not return any results

  prove t/Koha.t
and
  prove t/db_dependent/Koha.t
should return green

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
slashifyDate removed, all test pass successfully

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15783: AddAuthorisedValue - Remove the subroutine
Jonathan Druart [Wed, 10 Feb 2016 10:32:52 +0000 (10:32 +0000)]
Bug 15783: AddAuthorisedValue - Remove the subroutine

Test plan:
  prove t/db_dependent/Koha.t
should return green

  git grep AddAuthorisedValue
should not return any results

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15783: AddAuthorisedValue - Replace existing calls
Jonathan Druart [Wed, 10 Feb 2016 10:20:01 +0000 (10:20 +0000)]
Bug 15783: AddAuthorisedValue - Replace existing calls

The C4::Koha::AddAuthorisedValue is only called twice from
reports/guided_reports.pl and insert an authorised value.
This job can be achieve easily using the Koha::AuthorisedValue module.

Test plan:
1/ Create a new guided report
2/ Use an existing group and/or subgroup of reports
3/ Save
4/ Update an existing report
5/ Use an existing group and/or subgroup of reports
6/ Save
7/ Create or update an existing report
8/ Remove its assigned group and subgroup
9/ Save

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15796: Remove C4::Koha::get_itemtypeinfos_of
Jonathan Druart [Thu, 11 Feb 2016 13:50:42 +0000 (13:50 +0000)]
Bug 15796: Remove C4::Koha::get_itemtypeinfos_of

This subroutine is no longer in use.

Test plan:
  git grep get_itemtypeinfos_of
should not return any results.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Trivial and needed removal.

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15797: Remove C4::Koha::GetKohaImageurlFromAuthorisedValues
Jonathan Druart [Wed, 10 Feb 2016 15:51:02 +0000 (15:51 +0000)]
Bug 15797: Remove C4::Koha::GetKohaImageurlFromAuthorisedValues

This subroutine is no longer in used and can be remove.

Test plan:
  git grep GetKohaImageurlFromAuthorisedValues
should not return any results.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15813: Fix list-context call to ...->guarantor in opac-memberentry.pl
Jesse Weaver [Wed, 6 Jan 2016 20:19:10 +0000 (13:19 -0700)]
Bug 15813: Fix list-context call to ...->guarantor in opac-memberentry.pl

(was: Bug 14658: (followup) fix issue with list context on DBIC call)

While working on bug 14659, it was discovered that the call to
...->guarantor in list context will cause the hash to be misaligned if
there is no guarantor.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15826 - Use Font Awesome icons in confirmation dialogs - Tools
Aleisha [Tue, 16 Feb 2016 04:29:59 +0000 (04:29 +0000)]
Bug 15826 - Use Font Awesome icons in confirmation dialogs - Tools

I only found one confirmation dialog, all the others use javascript.

To test:
Go to Tools -> Notices and Slips
Click Delete on a notice
Confirm Yes and No options still work as expected
Check Tools module in case I missed any confirm dialogs

Sponsored-by: Catalyst IT
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15827 - Unfriendly message when saving overdue notice/status triggers
Aleisha [Tue, 16 Feb 2016 02:49:33 +0000 (02:49 +0000)]
Bug 15827 - Unfriendly message when saving overdue notice/status triggers

To test:
1) Go to Tools -> Overdue notice/status triggers
2) Click Save changes (you don't have to change anything)
3) Confirm message now says 'Changes saved.' which is much nicer

Sponsored-by: Catalyst IT
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15828: Remove the required class on label
Jonathan Druart [Mon, 22 Feb 2016 11:09:37 +0000 (11:09 +0000)]
Bug 15828: Remove the required class on label

Otherwise the label is red and a bit agressive :)

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15828: Upload patron images is hard to read
Owen Leonard [Tue, 16 Feb 2016 17:49:02 +0000 (12:49 -0500)]
Bug 15828: Upload patron images is hard to read

The styling of the patron image upload form causes the text to be
smaller than it should be for the main body of a page. This patch
revises the form style and cleans up the markup a bit.

This patch also adds client-side validation of the form so that a file
upload is required, and a card number is required if an image file is
selected.

To test, apply the patch and go to Tools -> Upload patron images.

1. Confirm that the text in the form is the correct size.
2. With "Zip file" selected, confirm that submitting the form is blocked
   and the file upload marked as required.
3. With "Image file" selected, confirm that submitting the form
   with an empty card number field is blocked and the card number
   field is marked as required.
4. Confirm that uploading zip files and single images still works
   correctly.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15829 - Rotating Collections is under Patrons on Tools Home - Should be Catalog
Aleisha [Tue, 16 Feb 2016 03:22:46 +0000 (03:22 +0000)]
Bug 15829 - Rotating Collections is under Patrons on Tools Home - Should be Catalog

To test:
1) Notice Rotating Collections is under Patrons & Circ on tools-home.pl
2) Apply patch and refresh page
3) Notice it is now under Catalog and is in the same position it is in on the tools sidebar menu

Sponsored-by: Catalyst IT
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15830 - Move Rotating Collections actions into a drop-down list
Aleisha [Tue, 16 Feb 2016 04:01:13 +0000 (04:01 +0000)]
Bug 15830 - Move Rotating Collections actions into a drop-down list

To test:
1) Go to Tools -> Rotating Collections
2) Confirm actions (Add or remove items, Transfer, Edit, Delete) have moved into a drop down menu
3) Confirm all of the actions work as expected

Sponsored-by: Catalyst IT
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15858: Use Font Awesome icons in dialog alert for addorder.tt
Hector Castro [Thu, 18 Feb 2016 20:54:53 +0000 (14:54 -0600)]
Bug 15858: Use Font Awesome icons in dialog alert for addorder.tt

A warning is raised when order amount exceed budget or fund this dialog needs to be styled with Font Awesome icons.

To test:
-Add orders to a basket
-Exceed a fund or budget
-Notice about the dialog alert
-Apply patch
-Exceed again and see the new icons

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15859: Move some basic MARC editor controls into settings menu
Owen Leonard [Thu, 18 Feb 2016 16:44:52 +0000 (11:44 -0500)]
Bug 15859: Move some basic MARC editor controls into settings menu

This patch moves the following options into a "Settings" menu inspired
by the one in the advanced editor:

- Switch to advanced editor
- Show MARC tag documentation links
- Show tags
- Change framework

To test, apply the patch and open a new or existing record in the
standard MARC editor.

- Test that the 'Switch to advanced editor' button option works.
- Test that the 'Show MARC tag documenation links' option works (and
  that your choice persists across sessions).
- Test that the initial settings for 'Show tags' respects the
  'hide_marc' system preference.
- Test that the 'Show tags' option works (and that your choice persists
  across sessions).
- Test that framework switching works correctly and that the menu
  correctly reflects your choice.
- Confirm that other toolbar functions work as expected, both in regular
  editing mode and Fast Cataloging.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as expected.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 12920 [QA Followup] - Show override option below checkouts table when allowed
Kyle M Hall [Wed, 3 Feb 2016 15:22:40 +0000 (15:22 +0000)]
Bug 12920 [QA Followup] - Show override option below checkouts table when allowed

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agobug 12920 - Remove AllowRenewalLimitOverride from pl scripts and tt files, use Koha...
Natasha [Tue, 19 Jan 2016 00:56:56 +0000 (00:56 +0000)]
bug 12920 - Remove AllowRenewalLimitOverride from pl scripts and tt files, use Koha.Preference instead

Test Plan:
1) Apply this patch
2) Go to circulation.pl
3) Ensure you can still override renewal limits with pref enabled
4) Ensure you can not override renewal limits with pref disabled
5) Go to moremember.pl
6) Repeat steps 3-4

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 13474: Adding untranslatable log actions to viewlog.tt
Aleisha [Tue, 19 Jan 2016 20:29:24 +0000 (20:29 +0000)]
Bug 13474: Adding untranslatable log actions to viewlog.tt

Added 'Run'

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
(Amended to remove tab chars to make qa tools happy)
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 14097: Fixed missing test cases
Mark Tompsett [Mon, 4 Jan 2016 06:16:59 +0000 (01:16 -0500)]
Bug 14097: Fixed missing test cases

Fixed AllowPkiAuth issue caused by 15101.
Added missing AudioAlerts

TEST PLAN
---------
1) prove -v t/db_dependent/UsageStats.t
   -- should pass after applying patch
2) Run koha qa test tools

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 14097 : Changing AddReserve prototype call
Julian FIOL [Mon, 24 Aug 2015 11:51:16 +0000 (13:51 +0200)]
Bug 14097 : Changing AddReserve prototype call

In response of Joubu comment #19

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 14097 : Avoid issue if the number of syspref shared is modified
Julian FIOL [Mon, 24 Aug 2015 11:50:16 +0000 (13:50 +0200)]
Bug 14097 : Avoid issue if the number of syspref shared is modified

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com