koha.git
9 years agoMerge remote-tracking branch 'origin/new/bug_8130'
Paul Poulain [Mon, 23 Jul 2012 16:06:50 +0000 (18:06 +0200)]
Merge remote-tracking branch 'origin/new/bug_8130'

9 years agoBug 8130: Followup: errors must be a hashref
Jonathan Druart [Thu, 19 Jul 2012 11:50:08 +0000 (13:50 +0200)]
Bug 8130: Followup: errors must be a hashref

http://bugs.koha-community.org/show_bug.cgi?id=8130
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
9 years agoBug 8130: [SIGNED-OFF] Followup - Empty file upload error never displays.
Kyle M Hall [Thu, 19 Jul 2012 12:41:39 +0000 (08:41 -0400)]
Bug 8130: [SIGNED-OFF] Followup - Empty file upload error never displays.

http://bugs.koha-community.org/show_bug.cgi?id=8130
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
9 years agoBug 8130 [FOLLOW-UP] attach PDF files to a patron record
Owen Leonard [Tue, 10 Jul 2012 17:56:26 +0000 (13:56 -0400)]
Bug 8130 [FOLLOW-UP] attach PDF files to a patron record

Markup corrections:

- Hide table of files if no files are attached
- Move error messages out of table (invalid)
- Add <tr> tags to table (invalid)
- Apply standard form structure to upload form
- Add proper labels and ids to upload form
- Correct unescaped ampersands

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
9 years agoBug 8083 follow-up DBRev number
Paul Poulain [Mon, 23 Jul 2012 08:51:04 +0000 (10:51 +0200)]
Bug 8083 follow-up DBRev number

9 years agobug_8083: Explanation of update query
Srdjan [Wed, 18 Jul 2012 05:53:31 +0000 (17:53 +1200)]
bug_8083: Explanation of update query

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agobug_8083: parameters subpermissions: manage_circ_rules and parameters_remaining_permi...
Srdjan [Tue, 22 May 2012 05:56:43 +0000 (17:56 +1200)]
bug_8083: parameters subpermissions: manage_circ_rules and parameters_remaining_permissions

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
9 years agoMerge remote-tracking branch 'origin/new/bug_8268'
Paul Poulain [Mon, 23 Jul 2012 08:41:05 +0000 (10:41 +0200)]
Merge remote-tracking branch 'origin/new/bug_8268'

9 years ago8268 Followup for creating var spool subdir.
Marcel de Rooy [Mon, 16 Jul 2012 11:15:03 +0000 (13:15 +0200)]
8268 Followup for creating var spool subdir.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
This fixes breaking install on missing subdir.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8453: Add spaces to inventory options
Nicole C. Engard [Mon, 16 Jul 2012 06:43:29 +0000 (02:43 -0400)]
Bug 8453: Add spaces to inventory options

The home and current library labels were right on top
of the radio buttons. This patch just adds a bit of
space in there so that it's cleaner looking.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8458 - $stemmed_operand in C4::Search _build_stemmed_operand is not initialized...
Mark Tompsett [Tue, 17 Jul 2012 12:53:57 +0000 (20:53 +0800)]
Bug 8458 - $stemmed_operand in C4::Search _build_stemmed_operand is not initialized. Added =q{} to initialize it to the empty string at declaration time.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoMerge remote-tracking branch 'origin/new/bug_7729'
Paul Poulain [Tue, 17 Jul 2012 16:21:38 +0000 (18:21 +0200)]
Merge remote-tracking branch 'origin/new/bug_7729'

9 years agoBug 7729 : svc/new_bib: support ?items=1 to add POSTed items to the new biblio too
MJ Ray [Fri, 13 Apr 2012 16:15:21 +0000 (17:15 +0100)]
Bug 7729 : svc/new_bib: support ?items=1 to add POSTed items to the new biblio too

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8422 - Fix impossible warning in circulation.pl when OverduesBlockCirc set to...
David Cook [Thu, 12 Jul 2012 01:26:56 +0000 (11:26 +1000)]
Bug 8422 - Fix impossible warning in circulation.pl when OverduesBlockCirc set to Block

Previously, the message Patron has x overdue item(s). Checkout anyway? was shown when syspref OverduesBlockCirc was set to Ask for confirmation or Block.

This patch changes the message for Block to: Checkouts are BLOCKED because patron has overdues.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoMerge remote-tracking branch 'origin/new/bug_6720'
Paul Poulain [Tue, 17 Jul 2012 13:30:06 +0000 (15:30 +0200)]
Merge remote-tracking branch 'origin/new/bug_6720'

9 years agoBug 6720 follow-up: use authtypetext instead of summary
Jared Camins-Esakov [Sun, 15 Jul 2012 13:55:30 +0000 (09:55 -0400)]
Bug 6720 follow-up: use authtypetext instead of summary

Although auth_types.summary contains a string describing the type of
authority in MARC21, it does not in UNIMARC. auth_types.authtypetext
contains the proper label in both marcflavours.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 6720: Display the authority type in OPAC
Jared Camins-Esakov [Mon, 28 May 2012 18:49:04 +0000 (14:49 -0400)]
Bug 6720: Display the authority type in OPAC

Due to a peculiarity in the way SearchAuthorities worked, the authority
search results on the OPAC always listed the authority type that the
user searched for, rather than the authority type of the results.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, result list for OPAC search now shows the authority type
for each record.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased 20 June 2012.

Signed-off-by: Mirko Tietgen <5p4m@gmx.de>
Works as expected.

9 years agoBug 8386: Error in duplicate detection message for authorities
Jared Camins-Esakov [Mon, 9 Jul 2012 12:00:25 +0000 (08:00 -0400)]
Bug 8386: Error in duplicate detection message for authorities

If you create a new authority record and the name already exists in
your database, you get a duplicate warning. This is good, but there is
a small error in the message:

Duplicate record suspected
Is this a duplicate of HASH(0x47fa670)?

This patch corrects the error message to show the title.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Error message correctly shows the name after applying this patch.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8398 - Missing image file in staff global css
Owen Leonard [Mon, 9 Jul 2012 19:48:23 +0000 (15:48 -0400)]
Bug 8398 - Missing image file in staff global css

This patch fixes a regression introduced by the fix for
Bug 6855 (bullet point showing in wrong place on error message)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855

The patch removes the re-introduced reference to a
background image which has since been removed. Testers should
check that this patch does not re-introduce Bug 6855.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I checked the styling of the error messages in Chromium and Firefox.
The logs are no longer complaining about the missing image.
Looks good to me.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8381: Fix adding limits to search history for logged in users
Katrin Fischer [Sat, 14 Jul 2012 09:37:42 +0000 (11:37 +0200)]
Bug 8381: Fix adding limits to search history for logged in users

Due to renaming of some variables the limits were only working for 'anonymous'
users. This patch fixes some variables, so limits are also added to history
when the user is logged in.

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8381 - Paging broken in OPAC search results
Alex Arnaud [Fri, 13 Jul 2012 09:13:47 +0000 (11:13 +0200)]
Bug 8381 - Paging broken in OPAC search results

Fix also freezing for some browser when performing a search query.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Checked paging (previous, next and navigating to page numbers) works.
Browser performance is fixed too.

9 years agoBug 8063 - Followup - Bug fix
Kyle M Hall [Wed, 6 Jun 2012 13:41:02 +0000 (09:41 -0400)]
Bug 8063 - Followup - Bug fix

$OUTPUT being used but not being declared.

When trying to run this script I gat a nasty:
15:42 ~/koha.dev/koha-community (new/bug_8063 $%)$ ./misc/cronjobs/gather_print_notices.pl
Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 81.
Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 95.
Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 102.
Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 106.
Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 120.
Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 127.
Execution of ./misc/cronjobs/gather_print_notices.pl aborted due to compilation errors.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Before the patch:
$perl -wc ./misc/cronjobs/gather_print_notices.pl
Global symbol "$OUTPUT" requires explicit package name at
[...]./misc/cronjobs/gather_print_notices.pl line 81.
./misc/cronjobs/gather_print_notices.pl had compilation errors.

With this patch:
$perl -wc ./misc/cronjobs/gather_print_notices.pl
./misc/cronjobs/gather_print_notices.pl syntax OK

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8063 - Followup - Make C4/Letters.pm conform to PBP
Kyle M Hall [Tue, 22 May 2012 12:05:05 +0000 (08:05 -0400)]
Bug 8063 - Followup - Make C4/Letters.pm conform to PBP

Perlcritic reported the following errors:
Subroutine prototypes used at line 96, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 120, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 152, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 173, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 190, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 227, column 1.  See page 194 of PBP.  (Severity: 5)
"return" statement with explicit "undef" at line 228, column 31.  See page 199 of PBP.  (Severity: 5)
"return" statement with explicit "undef" at line 229, column 31.  See page 199 of PBP.  (Severity: 5)
"return" statement with explicit "undef" at line 236, column 9.  See page 199 of PBP.  (Severity: 5)
Subroutine prototypes used at line 668, column 1.  See page 194 of PBP.  (Severity: 5)
"return" statement with explicit "undef" at line 669, column 27.  See page 199 of PBP.  (Severity: 5)
Subroutine prototypes used at line 719, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 865, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 899, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 981, column 1.  See page 194 of PBP.  (Severity: 5)
"return" statement with explicit "undef" at line 982, column 28.  See page 199 of PBP.  (Severity: 5)
Subroutine prototypes used at line 1000, column 1.  See page 194 of PBP.  (Severity: 5)
"return" statement with explicit "undef" at line 1001, column 27.  See page 199 of PBP.  (Severity: 5)
"return" statement with explicit "undef" at line 1004, column 9.  See page 199 of PBP.  (Severity: 5)

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
9 years agoBug 8063 - Hold print notices do not sort by branch
Kyle M Hall [Wed, 9 May 2012 15:40:27 +0000 (11:40 -0400)]
Bug 8063 - Hold print notices do not sort by branch

Adds the option -s/--split to enable notices to be separated
into different files by borrower home library.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
9 years agoMerge remote-tracking branch 'origin/new/bug_8251'
Paul Poulain [Mon, 16 Jul 2012 11:46:31 +0000 (13:46 +0200)]
Merge remote-tracking branch 'origin/new/bug_8251'

9 years agoBug 8251 - Follow up, use 'day' instead of 'days' for Datetime::truncate
Tomas Cohen Arazi [Thu, 21 Jun 2012 14:27:20 +0000 (11:27 -0300)]
Bug 8251 - Follow up, use 'day' instead of 'days' for Datetime::truncate

As noted in comment #4 by Jonathan Druart, this should be fixed in every call
to DateTie::truncate function. This patch does exactly that.

julian_m tested that truncate( to => 'days' ) didn't actually do anything, so
it is understandable that this 'fix' might introduce new bugs as we might have
'fixed' at a higher libs level this issue.

'minutes' is used in truncate function too, so fixing.

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoMerge remote-tracking branch 'origin/new/bug_5644'
Paul Poulain [Mon, 16 Jul 2012 10:43:09 +0000 (12:43 +0200)]
Merge remote-tracking branch 'origin/new/bug_5644'

9 years agoBug 5644 : Fixing the test
Chris Cormack [Fri, 13 Jul 2012 20:25:45 +0000 (08:25 +1200)]
Bug 5644 : Fixing the test

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8351: Update wording on staged marc
Nicole C. Engard [Tue, 3 Jul 2012 04:53:37 +0000 (00:53 -0400)]
Bug 8351: Update wording on staged marc

When undoing an import the 'success' message was
poorly worded. This patch fixes that.

Signed-off-by: Mirko Tietgen <5p4m@gmx.de>
works as expected

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agobug 8322 removing additional spaces before fullstop on catalogue/detail and opac...
Chris Hall [Tue, 12 Jun 2012 04:28:56 +0000 (16:28 +1200)]
bug 8322 removing additional spaces before fullstop on catalogue/detail and opac-detail pages.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8375 - Patch for Common diacritics not shown correctly when exporting batch label...
wajasu [Fri, 6 Jul 2012 01:02:28 +0000 (20:02 -0500)]
Bug 8375 - Patch for Common diacritics not shown correctly when exporting batch label to PDF

Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoMerge remote-tracking branch 'jcamins/bug_8281_qa'
Paul Poulain [Fri, 13 Jul 2012 13:11:21 +0000 (15:11 +0200)]
Merge remote-tracking branch 'jcamins/bug_8281_qa'

9 years agoBug 8353 follow-up adding a tiny sh in misc/maintenance
Paul Poulain [Fri, 13 Jul 2012 09:53:41 +0000 (11:53 +0200)]
Bug 8353 follow-up adding a tiny sh in misc/maintenance

This script will help the sysadmin know there's a test he can use
during maintenance

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 8353 follow-up: Perltidy new test
Jared Camins-Esakov [Fri, 13 Jul 2012 12:14:11 +0000 (08:14 -0400)]
Bug 8353 follow-up: Perltidy new test

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 8353: Adds a test to check for missing sysprefs in the database
Henri-Damien LAURENT [Tue, 19 Jan 2010 11:26:24 +0000 (12:26 +0100)]
Bug 8353: Adds a test to check for missing sysprefs in the database

Adds a non-test mode (--showsql option) that displays the missing
sysprefs as sql inserts.  Some sysprefs were missed from the syspref
file due to extra spaces in the insert : fixed. The test now checks if
there are at least as many sysprefs in the database as in the syspref
file (instead of checking for the exact number)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Cherrypicked from BibLibre master, rebased onto current master, and
corrected typos, 2012-07-03

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 6394: purchase order has French strings hard coded in
Katrin Fischer [Mon, 9 Jul 2012 20:23:27 +0000 (22:23 +0200)]
Bug 6394: purchase order has French strings hard coded in

On the purchase order it said 'publié par' - instead of 'published by'.

The layout files for PDF generation in basket groups contain lots of English
strings, this change makes the template more consistent.

Currently the files are not translatable. The only way is to add translated
files to your installation.

To test:
Print a basket group as PDF. Verify string is ok for both possible settings
of system preference OrderPdfFormat:
- pdfformat::layout3pages
- pdfformat::layout2pages

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 7411: Follop-up: Add Text::Unaccent to PerlDependencies.pm
Katrin Fischer [Tue, 10 Jul 2012 06:20:09 +0000 (08:20 +0200)]
Bug 7411: Follop-up: Add Text::Unaccent to PerlDependencies.pm

Adds new dependency Text::Unaccent to PerlDependencies.pm

Module is used currently to remove diacricits from automatically
created userid (<first name>.<surname>) in the patron module.

Test scenario:
1. open About Koha > Perl modules
2. verify that Text::Unaccent is there

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoMerge remote-tracking branch 'origin/new/bug_8315'
Paul Poulain [Fri, 13 Jul 2012 12:17:59 +0000 (14:17 +0200)]
Merge remote-tracking branch 'origin/new/bug_8315'

9 years agoBug 8315 - remove use C4::* version
Dobrica Pavlinusic [Thu, 12 Jul 2012 16:01:17 +0000 (18:01 +0200)]
Bug 8315 - remove use C4::* version

This patch touches a lot of code, but basically it removes version
information from use C4::* in our code.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
All script still compiles after the patch (confirmed by pre-applypatch hook)

9 years agoBug 8283 - Replace usage of YUI Cookie utility with jQuery Cookie plugin
Owen Leonard [Fri, 22 Jun 2012 18:12:49 +0000 (14:12 -0400)]
Bug 8283 - Replace usage of YUI Cookie utility with jQuery Cookie plugin

Switching from YUI Cookie utility to jQuery Cookie plugin. The
jQuery Cookie plugin is already used elsewhere in Koha, so no new
dependencies are added. The YUI Cookie files are removed.

To test, go to batch item deletion and/or batch item modification
and submit a set of barcodes. On the confirmation screen select
or deselect columns to show. Start over and submit your barcodes
again. The confirmation screen should remember which columns you
previously selected.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 5644 : Fixing dropbox mode calculation
Chris Cormack [Fri, 29 Jun 2012 21:04:07 +0000 (09:04 +1200)]
Bug 5644 : Fixing dropbox mode calculation

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8268 follow-up: incorporate QA comments
Jared Camins-Esakov [Sat, 7 Jul 2012 12:53:49 +0000 (08:53 -0400)]
Bug 8268 follow-up: incorporate QA comments

Fixes the following things:
1. Sanitizes log output to prevent an attacker from using a specially
   crafted POST to add extra lines to the log
2. Simplify a regular expression since "..file" cannot be used to
   escape the current directory
3. Makes sure directories are consistent
4. Correct logic issues in misc/cronjobs/backup.sh

Thanks to Frere Sebastien Marie for catching these issues.

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8268: Add database dump to export tool
Jared Camins-Esakov [Mon, 18 Jun 2012 21:16:31 +0000 (17:16 -0400)]
Bug 8268: Add database dump to export tool

This patch builds on work by Lars Wirzenius for the Koha packages.

To date, the only way for a Koha librarian to obtain a complete backup
of their system has been to log into the system via SSH (or FTP) to
download the mysqldump file. This patch makes it possible for
superlibrarians in properly configured systems to download night backups
via the staff client's Export tool.

Recognizing that this is functionality with potentially very grave
security implications, system administrators must manually enable these
features in the koha-conf.xml configuration file.

The following configuration settings have been added to the koha-conf.xml
file:
* backupdir => directory where backups should be stored.
* backup_db_via_tools => whether to allow superlibrarians to download
  database backups via the Export tool. The default is disabled, and
  there is no way -- by design -- to enable this option without manually
  editing koha-conf.xml.
* backup_conf_via_tools => whether to allow superlibrarians to download
  configuration backups via the Export tool (this may be applicable to
  packages only). The default is disabled, and there is no way -- by
  design -- to enable this option without manually editing koha-conf.xml.

This commit modifies the following scripts to make use of the new
backupdir configuration option:
* koha-dump and koha-run-backups in the Debian packages
* The sample backup script misc/cronjobs/backup.sh

Note that for security reasons, superlibrarians will not be allowed
to download files that are not owned by the web server's effective user.
This imposes a de facto dependency on ITK (for Apache) or running the
web server as the Koha user (as is done with Plack).

To test:
1. Apply patch.
2. Go to export page as a superlibrarian. Notice that no additional
   export options appear because they have not been enabled.
3. Add <backupdir>$KOHADEV/var/spool</backup> to the <config> section
   of your koha-conf.xml (note that you will need to adjust that so that
   it is pointing at a logical directory).
4. Create the aforementioned directory.
5. Go to export page as a superlibrarian. Notice that no additional
   export options appear because they have not been enabled.
6. Add <backup_db_via_tools>1</backup_db_via_tools> to the <config>
   section of your koha-conf.xml
7. Go to the export page as a superlibrarian. Notice the new tab.
8. Go to the export page as a non-superlibrarian. Notice there is no
   new tab.
9. Run: mysqldump -u koha -p koha | gzip > $BACKUPDIR/backup.sql.gz
   (substituting appropriate user, password, and database name)
10. Go to the export page as a superlibrarian, and look at the "Export
    database" tab. If you are running the web server as your Koha user,
    and ran the above command as your Koha user, you should now see the
    file listed as an option for download.
11. If you *did* see the file listed, change the ownership to something
    else: sudo chown root:root $BACKUPDIR/backup.sql.gz
11a. Confirm that you no longer see the file listed when you look at the
     "Export database" tab.
12. Change the ownership on the file to your web server (or Koha) user:
    sudo chown www-data:www-data backup.sql.gz
13. Go to the export page as a superlibrarian, and look at the "Export
    database" tab. You should now see backup.sql.gz listed.
14. Choose to download backup.sql.gz
15. Confirm that the downloaded file is what you were expecting.

If you are interested, you can repeat the above steps but replace
<backup_db_via_tools> with <backup_conf_via_tools>, and instead of
creating an sql file, create a tar file.

To test packaging: run koha-dump, confirm that it still creates a
usable backup.

------

This signoff contains two changes:

10-1. If no backup/conf files were present, then the message telling you
so doesn't appear and the download button does. Made them behave
correctly.
10-2. The test for a file existing required it to be owned by the
webserver UID. This change makes it so it only has to be readable.

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
9 years agoBug 5327 : Follow up for TTParser test
Chris Cormack [Fri, 6 Jul 2012 23:35:47 +0000 (11:35 +1200)]
Bug 5327 : Follow up for TTParser test

9 years agoAdded coverage to unit test for TTParser
Duncan Tyler [Thu, 8 Dec 2011 22:29:53 +0000 (11:29 +1300)]
Added coverage to unit test for TTParser

http://bugs.koha-community.org/show_bug.cgi?id=5327
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Test passes.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 8203 follow-up: fix MARCXML export for UNIMARC
Jared Camins-Esakov [Fri, 6 Jul 2012 11:05:27 +0000 (07:05 -0400)]
Bug 8203 follow-up: fix MARCXML export for UNIMARC

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8203 follow-up: QA fixes
Jared Camins-Esakov [Thu, 5 Jul 2012 12:32:47 +0000 (08:32 -0400)]
Bug 8203 follow-up: QA fixes

Fixes the Save button functionality when YUI is set to be pulled
from Yahoo!'s servers, and adds a copyright statement to the
MARC21slim2MADS.xsl file.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Works now for both yuipaths.

9 years agoBug 8203: Add ability to save individual authorities
Jared Camins-Esakov [Wed, 30 May 2012 14:04:20 +0000 (10:04 -0400)]
Bug 8203: Add ability to save individual authorities

Adds the ability to save individual authority records in MADS, MARCXML, or
binary MARC format to the staff client.

To test:
1. Apply patch
2. View authority record in staff client
3. Try saving record as MADS, MARCXML, and MARC, and confirm that the
   resulting files are what you expect

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, tested different export options on different records.

9 years agoRevert "Bug 4460 - Amazon's AssociateID tag not used in links so referred revenue...
Paul Poulain [Wed, 11 Jul 2012 10:33:36 +0000 (12:33 +0200)]
Revert "Bug 4460 - Amazon's AssociateID tag not used in links so referred revenue lost"

This reverts commit 68ba16afe8989291df8afe54dd72fdf0f0a99fbf.

9 years agoRevert "Bug 4460 - Amazon's AssociateID tag not used in links so referred revenue...
Paul Poulain [Wed, 11 Jul 2012 10:33:16 +0000 (12:33 +0200)]
Revert "Bug 4460 - Amazon's AssociateID tag not used in links so referred revenue lost - Followup"

This reverts commit 8e05a8593535e7c79f69c3070f4ff94b0ec350d0.

9 years agoBug 8235 - allow a whitelist of modules that aren't in Debian
Robin Sheat [Mon, 11 Jun 2012 15:04:06 +0000 (16:04 +0100)]
Bug 8235 - allow a whitelist of modules that aren't in Debian

This allows modules that aren't in the main debian repos to be handled
by the list-deps script when building a control file.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 7848 - Issues data missing from circulation notices
Kyle M Hall [Thu, 29 Mar 2012 15:35:33 +0000 (11:35 -0400)]
Bug 7848 - Issues data missing from circulation notices

For the CHECKIN and CHECKOUT notices, any data that is issue specific
does not show. For example, date due.

For CHECKOUT, this is caused not passing in the issues table as part
of the 'table' hash used by C4::Letters::GetPreparedLetter.

For CHECKIN notices, we need the old_issues table instead, as the item
has already been returned.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes tests, correct information shows in notices.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 7065 follow-up DBRev number
Paul Poulain [Tue, 10 Jul 2012 10:09:20 +0000 (12:09 +0200)]
Bug 7065 follow-up DBRev number

9 years agoBug 7065 - reserves table needs a primary key
Kyle M Hall [Tue, 6 Mar 2012 15:53:30 +0000 (10:53 -0500)]
Bug 7065 - reserves table needs a primary key

Adds the primary key reserve_id to reserves and old_reserves.

Thanks to gmcharlt and jcamins for contributions.

Signed-off-by: MJ Ray <mjr@phonecoop.coop>
Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
Updated DBrev to start with 3.09... instead of 3.08...
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8256: Teach webservice to select reports by name
Jared Camins-Esakov [Fri, 15 Jun 2012 18:43:03 +0000 (14:43 -0400)]
Bug 8256: Teach webservice to select reports by name

Adds the ability to pass a hash to C4::Reports::Guided::get_saved_report
which specifies a name or id to select the report.

Test plan:
1. Create a report (or choose an existing one), and mark it public
2. Run the report using the web service: [IntranetBaseURL]/cgi-bin/koha/svc/report?id=whatever
3. Confirm you get the expected results
4. Run the report by name using the web service: [IntranetBaseURL]/cgi-bin/koha/svc/report?name=[Report name] (keep spaces in the name)
5. Confirm you get the same results
6. Run the report using the public web service: [OPACBaseURL]/cgi-bin/koha/svc/report?id=whatever
7. Confirm you get the same results
8. Run the report by name using the public web service: [OPACBaseURL]/cgi-bin/koha/svc/report?name=[Report name] (keep spaces in the name)
9. Confirm you get the same results
10. Sign off

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
- Adding, editing and deleting reports works
- id parameter works
- new name parameter works
- public and non-public works

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8301 - Display additional system information (preferences) on About page to minim...
Marc Veron [Sun, 24 Jun 2012 19:29:12 +0000 (21:29 +0200)]
Bug 8301 - Display additional system information (preferences) on About page to minimize support cases

To minimize support questions regarding common mistakes, the About
page should have an additional tab that displays warnings if depractated
and/or mutual excluding system preferences are used.

To test patch use values as displayed on screenshot attached.

New: Shows error message in Tab Server Information if Zebra server is not started
(...and changes added...)

Suggestions for other values to add are welcome.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8383: Add test to check that Perl scripts compile
Jared Camins-Esakov [Mon, 9 Jul 2012 02:06:28 +0000 (22:06 -0400)]
Bug 8383: Add test to check that Perl scripts compile

This patch adds t/db_dependent/00-strict.pl which tests that all Perl
scripts compile. I chose to use Test::Strict so that in the future we
can also have the test check that "use strict" and "use warnings" are
enabled.

To test:
1. Run t/db_dependent/00-strict.pl.
2. Run around waving your arms in the air that we have a couple of
   scripts that don't compile.
3. Actually, that's about it. You could test my patch for bug 8384 next.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Moved test to t/db_dependent

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 7143 – Bug for tracking changes to the about page
Mirko Tietgen [Sat, 7 Jul 2012 23:10:20 +0000 (01:10 +0200)]
Bug 7143 – Bug for tracking changes to the about page

This patch updates the German translators. To be applied after attachment 10681.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
9 years agoBug 7143 : Adding Stacey Walker to the history
Chris Cormack [Fri, 6 Jul 2012 21:35:03 +0000 (09:35 +1200)]
Bug 7143 : Adding Stacey Walker to the history

Signed-off-by: wajasu <matted-34813@mypacks.net>
9 years agoBug 4460 - Amazon's AssociateID tag not used in links so referred revenue lost -...
Kyle M Hall [Mon, 2 Jul 2012 12:52:57 +0000 (08:52 -0400)]
Bug 4460 - Amazon's AssociateID tag not used in links so referred revenue lost - Followup

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 4460 - Amazon's AssociateID tag not used in links so referred revenue lost
Kyle M Hall [Sat, 9 Jun 2012 13:18:00 +0000 (09:18 -0400)]
Bug 4460 - Amazon's AssociateID tag not used in links so referred revenue lost

Rewrite of patch authored by Reed Wade <reed@catalyst.net.nz>

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 8356 - moveitem.tt and linkitem.tt have cataloging typo Changed urls from catalog...
Mark Tompsett [Wed, 4 Jul 2012 15:21:31 +0000 (23:21 +0800)]
Bug 8356 - moveitem.tt and linkitem.tt have cataloging typo Changed urls from cataloging to cataloguing

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
correct typo

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8384: Some Perl scripts do not compile
Jared Camins-Esakov [Mon, 9 Jul 2012 02:28:56 +0000 (22:28 -0400)]
Bug 8384: Some Perl scripts do not compile

Fix syntax errors preventing the scripts misc/translator/text-extract2.pl
and misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl from compiling.

Remove misc/migration_tools/build6xx.pl entirely since it refers to
columns that no longer exist in the Koha database, and has seemingly
had broken encoding since Koha switched from CVS to git (or before!).

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 7299 pass itemnumber in ILSDI holditem service
Alex Arnaud [Sat, 9 Jun 2012 10:36:55 +0000 (12:36 +0200)]
Bug 7299 pass itemnumber in ILSDI holditem service

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8335 - Missing Icon PR.png or typo in MARC21slim2OPACDetail.xsl
Marc Veron [Fri, 29 Jun 2012 18:21:56 +0000 (20:21 +0200)]
Bug 8335 - Missing Icon PR.png or typo in MARC21slim2OPACDetail.xsl

Add PR.png (renamed file music.png from http://famfamfam.com/lab/icons/ )

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8271 teach SIPServer.pm to set its own lib path
Colin Campbell [Tue, 19 Jun 2012 10:24:01 +0000 (11:24 +0100)]
Bug 8271 teach SIPServer.pm to set its own lib path

SIPServer.pm requires that C4/SIP is added to its lib
path This has been done by passing this directory
to it via -I. By using FindBin it can set the path
for itself correctly. This will also work if the C4/SIP
directory tree is moved to a non-standard location
Removed the now redundant -I. from sip_run.sh

Added a variable to sip_run.sh for the koha tree to
highlight a problem with the script if you have multiple
directories in the PERL5LIB environment variable

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 7563 follow-up DBRev
Paul Poulain [Fri, 6 Jul 2012 16:26:39 +0000 (18:26 +0200)]
Bug 7563 follow-up DBRev

9 years agoMerge remote-tracking branch 'origin/new/bug_7563' into new/bug_7563
Paul Poulain [Fri, 6 Jul 2012 16:24:34 +0000 (18:24 +0200)]
Merge remote-tracking branch 'origin/new/bug_7563' into new/bug_7563

9 years agoBug 7563 - Silent print slips using Firefox PlugIn jsPrintSetup and new staff client...
Marc Veron [Fri, 29 Jun 2012 19:31:34 +0000 (21:31 +0200)]
Bug 7563 - Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 7563 - Silent print slips using Firefox PlugIn jsPrintSetup and new staff client...
Marc Veron [Fri, 29 Jun 2012 19:31:34 +0000 (21:31 +0200)]
Bug 7563 - Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference

...to version 3.09.00.021

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 6566 Checking if DB's records are properly indexed
Christophe Croullebois [Fri, 8 Jul 2011 09:52:53 +0000 (11:52 +0200)]
Bug 6566 Checking if DB's records are properly indexed

Small script that checks if each bibliorecord in the DB is properly indexed
use -h to learn more
(MT #6389)

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agobug 8323 fixing year sorting of a list
Chris Hall [Thu, 21 Jun 2012 22:36:45 +0000 (10:36 +1200)]
bug 8323 fixing year sorting of a list

Signed-off-by: Marc Veron <veron@veron.ch>
Works as expected.

Caveat: If you edit the list in Opac, change the sort and then klick 'Save',
the List always is displayed in title order. This is du to the fact that
save calls opac-shelves.pl?viewshelf=4 without the sort parameter (defaults
to 'title').
If you go back to lists, choose the list from List name, the param is
correct and the list displays in expected order.

It took quite a time to track  that down, I first thought that opac-shelves.pl
was broken.

However, current bug 8323 is not affected, signing off.

Marc

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoRevert "Added coverage to unit test for TTParser"
Paul Poulain [Fri, 6 Jul 2012 15:00:48 +0000 (17:00 +0200)]
Revert "Added coverage to unit test for TTParser"

This reverts commit 628788ad8a68ea843f37bfa63dd4854b50affd26.

9 years agoBug 8233 follow-up fixin DBRev
Paul Poulain [Fri, 6 Jul 2012 14:54:44 +0000 (16:54 +0200)]
Bug 8233 follow-up fixin DBRev

porting 2nd patch of the bug, that does not apply anymore, to fix DB version

9 years agoBug 8233: Followup: Search engine layer: Add dependencies.
Jonathan Druart [Mon, 25 Jun 2012 15:18:26 +0000 (17:18 +0200)]
Bug 8233: Followup: Search engine layer: Add dependencies.

9 years agoBug 8233: Hide the search engine configuration link for Zebra
Jonathan Druart [Mon, 25 Jun 2012 08:06:57 +0000 (10:06 +0200)]
Bug 8233: Hide the search engine configuration link for Zebra

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 8233: Replace the given statement with for
Jonathan Druart [Fri, 22 Jun 2012 14:38:20 +0000 (16:38 +0200)]
Bug 8233: Replace the given statement with for

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 8233 : SearchEngine: Add a Koha::SearchEngine module
Jonathan Druart [Wed, 13 Jun 2012 09:48:22 +0000 (11:48 +0200)]
Bug 8233 : SearchEngine: Add a Koha::SearchEngine module

First draft introducing solr into Koha :-)

List of files :
  $ tree t/searchengine/
  t/searchengine
  |-- 000_conn
  |   `-- conn.t
  |-- 001_search
  |   `-- search_base.t
  |-- 002_index
  |   `-- index_base.t
  |-- 003_query
  |   `-- buildquery.t
  |-- 004_config
  |   `-- load_config.t
  `-- indexes.yaml
  just do `prove -r t/searchengine/**/*.t`

  t/lib
  |-- Mocks
  |   `-- Context.pm
  `-- Mocks.pm
  provide a mock to SearchEngine syspref (set_zebra and set_solr).

  $ tree Koha/SearchEngine
  Koha/SearchEngine
  |-- Config.pm
  |-- ConfigRole.pm
  |-- FacetsBuilder.pm
  |-- FacetsBuilderRole.pm
  |-- Index.pm
  |-- IndexRole.pm
  |-- QueryBuilder.pm
  |-- QueryBuilderRole.pm
  |-- Search.pm
  |-- SearchRole.pm
  |-- Solr
  |   |-- Config.pm
  |   |-- FacetsBuilder.pm
  |   |-- Index.pm
  |   |-- QueryBuilder.pm
  |   `-- Search.pm
  |-- Solr.pm
  |-- Zebra
  |   |-- QueryBuilder.pm
  |   `-- Search.pm
  `-- Zebra.pm

How to install and configure Solr ?
  See the wiki page: http://wiki.koha-community.org/wiki/SearchEngine_Layer_RFC

http://bugs.koha-community.org/show_bug.cgi?id=8233
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 7787: Make the SIP server much more robust.
Marc Balmer [Wed, 21 Mar 2012 17:18:45 +0000 (18:18 +0100)]
Bug 7787: Make the SIP server much more robust.

Be liberal in what we accept, but strict in what we send:
Never exit the server process, but send a SC_RESEND message (96)
to the client if we received anything we don't understand.
 This is consistent with SIP server implementations of other ILSs.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 7286: rebuild_zebra_sliced for biblios and authorities
Julian Maurice [Mon, 2 Jul 2012 11:57:31 +0000 (13:57 +0200)]
Bug 7286: rebuild_zebra_sliced for biblios and authorities

Complete rewrite of rebuild_zebra_sliced.zsh (renamed to .sh). Main
improvements are:
  - both biblio and authority records are handled
  - records are exported only once

It also add an option --skip-index to rebuild_zebra.pl that permit to
use rebuild_zebra.pl as an 'export only' script.

Description:
Index Koha records by chunks. It is useful when some record causes
errors and stop the indexation process. With this script, if indexation
of one chunk fails, chunk is splitted in 2 (or 3) chunks, and
indexation continue on these chunks.
rebuild_zebra.pl is called only once to export records.
Splitting and indexing is handled by this script (using yaz-marcdump and
zebraidx).

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8314 Add MARCISBNs parameter to opac-detail.pl to show multiple isbns in OPAC
David Cook [Fri, 29 Jun 2012 06:53:14 +0000 (16:53 +1000)]
Bug 8314 Add MARCISBNs parameter to opac-detail.pl to show multiple isbns in OPAC

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoadded date and ISBN tests to Koha.t
Mason James [Fri, 6 Jul 2012 04:19:51 +0000 (16:19 +1200)]
added date and ISBN tests to Koha.t

modified:   Koha.t

$ prove  -v ./Koha.t

1..5
ok 1 - use C4::Koha;
ok 2 - use C4::Members;
    1..6
    ok 1 - Insert data in database
    ok 2 - GetAuthorisedValueByCode
    ok 3 - GetKohaImageurlFromAuthorisedValues
    ok 4 - lost and paid works
    ok 5 - Child area works
    ok 6 - Withdrawn works
ok 3 - Authorized Values Tests
    1..4
    ok 1 - C4::Koha->can('GetDailyQuote')
    ok 2 - Got a quote based on id.
    ok 3 - Got a random quote.
    ok 4 - Got a quote based on today's date.
ok 4 - Daily Quotes Test
    1..7
    ok 1 - slashifyDate
    ok 2 - xml_escape() returns empty string on undef input
    ok 3 - xml_escape() works as expected
    ok 4 - ... and does not change input in place
    ok 5 - _isbn_cleanup removes hyphens
    ok 6 - _isbn_cleanup removes parenthetical
    ok 7 - _isbn_cleanup converts ISBN-13 to ISBN-10
ok 5 - Date and ISBN tests
ok
All tests successful.
Files=1, Tests=5,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.48 cusr  0.06 csys =  0.57 CPU)
Result: PASS

http://bugs.koha-community.org/show_bug.cgi?id=5327

9 years agoAdded coverage to unit test for TTParser
Duncan Tyler [Thu, 8 Dec 2011 22:29:53 +0000 (11:29 +1300)]
Added coverage to unit test for TTParser

http://bugs.koha-community.org/show_bug.cgi?id=5327
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Test passes.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agobug 5327: added some tests for C4/Items.pm
Stacey Walker [Mon, 11 Jun 2012 16:06:00 +0000 (17:06 +0100)]
bug 5327: added some tests for C4/Items.pm

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge remote-tracking branch 'origin/new/bug_7818'
Paul Poulain [Fri, 6 Jul 2012 09:30:39 +0000 (11:30 +0200)]
Merge remote-tracking branch 'origin/new/bug_7818'

9 years agoBug 7818 : Following, fixing so the packages build Still need to update koha-create...
Chris Cormack [Fri, 29 Jun 2012 10:23:40 +0000 (22:23 +1200)]
Bug 7818 : Following, fixing so the packages build Still need to update koha-create to make use of the new file

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 7619 Use CRLF as default terminator
Colin Campbell [Sat, 9 Jun 2012 14:17:14 +0000 (15:17 +0100)]
Bug 7619 Use CRLF as default terminator

Most units require or tolerate CRLF as the terminator
Using only \r causes many including 3M units to signal errors
due to delay this resets CRLF to be default but adds a single
constant variable and explanation so that if you have a
"strictly conforming" unit (the 'Baby' is the only I have encountered
you know where to make the change

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoPermission for change password button in members toolbar should be borrowers instead...
Lyon3 Team [Thu, 7 Jun 2012 09:39:57 +0000 (11:39 +0200)]
Permission for change password button in members toolbar should be borrowers instead of staffaccess

http://bugs.koha-community.org/show_bug.cgi?id=8242
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 5981 follow-up DBrev number
Paul Poulain [Wed, 4 Jul 2012 14:27:44 +0000 (16:27 +0200)]
Bug 5981 follow-up DBrev number

9 years agoBug 5981 - OPAC: Add limits to search history
Alex Arnaud [Sun, 10 Jun 2012 11:14:24 +0000 (13:14 +0200)]
Bug 5981 - OPAC: Add limits to search history

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixed a conflict in updatedatabase and removed kohaversion.pl from the patch.

Patch works nicely, tested with different searches and limits.

Note: Sort options don't get into the history still.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8202 follow-up UNIMARC authority support
Paul Poulain [Tue, 3 Jul 2012 16:41:56 +0000 (18:41 +0200)]
Bug 8202 follow-up UNIMARC authority support

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 8202: Add authority export to tools/export.pl
Jared Camins-Esakov [Wed, 30 May 2012 12:10:14 +0000 (08:10 -0400)]
Bug 8202: Add authority export to tools/export.pl

Adds a separate tab on tools/export.pl for exporting authority records.

To test:
1. Try exporting authority records from the "Export data" tool

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tried different exports and everything worked nicely:
- removing fields from export (example: 942)
- limiting to one authority type
- changing the given file name
- exporting as MARC or XML

9 years agobug 7630 follow-up : welcome #186 Mark Tompsett
Paul Poulain [Tue, 3 Jul 2012 16:20:07 +0000 (18:20 +0200)]
bug 7630 follow-up : welcome #186 Mark Tompsett

9 years agoBug 7630 - Warning on moremember.pl about param without key Move "$error => 1," to...
Mark Tompsett [Fri, 29 Jun 2012 13:54:44 +0000 (21:54 +0800)]
Bug 7630 - Warning on moremember.pl about param without key Move "$error => 1," to its own conditional $template->param()

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoMerge remote-tracking branch 'origin/new/bug_3280'
Paul Poulain [Tue, 3 Jul 2012 16:17:44 +0000 (18:17 +0200)]
Merge remote-tracking branch 'origin/new/bug_3280'

9 years ago3280 Followup for privacy issue on X-Orig-IP in mail header
Marcel de Rooy [Mon, 2 Jul 2012 08:07:56 +0000 (10:07 +0200)]
3280 Followup for privacy issue on X-Orig-IP in mail header

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8281 - Remove unused YUI files
Owen Leonard [Thu, 21 Jun 2012 13:42:56 +0000 (09:42 -0400)]
Bug 8281 - Remove unused YUI files

This patch removes assets from the YUI library in the OPAC and
staff client which are unused by Koha

To test, visit pages which still use YUI components: buttons
and menus on circulation, for example. Drag-and-drop on
the basketgroups page, JSON parsing when filtering orders
on the Acquisitions Receive page (acqui/parcel.pl). All
of these pages should work without errors.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge remote-tracking branch 'origin/new/bug_8130'
Paul Poulain [Mon, 2 Jul 2012 12:53:42 +0000 (14:53 +0200)]
Merge remote-tracking branch 'origin/new/bug_8130'

9 years agoBug 8130 follow-up, removing duplicate tab
Paul Poulain [Mon, 2 Jul 2012 12:53:25 +0000 (14:53 +0200)]
Bug 8130 follow-up, removing duplicate tab

In bug 7955, http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955#c21, Nicole spotted that the "notices" tab appear twice.

This patch removes the duplicated tab that has been introduced by this feature, probably a rebase mistake

9 years agoRevert "Bug 7444: Update circ/circulation.pl to use KohaDates TT Plugin"
Paul Poulain [Fri, 29 Jun 2012 15:17:47 +0000 (17:17 +0200)]
Revert "Bug 7444: Update circ/circulation.pl to use KohaDates TT Plugin"

This reverts commit 186cfa5cb00a1c0ee7f0e4512a5f319299bb6412.