koha.git
11 years agoAdd koha-post-install-setup, a script to be run by sysadmin post-install.
Lars Wirzenius [Tue, 25 May 2010 01:44:09 +0000 (13:44 +1200)]
Add koha-post-install-setup, a script to be run by sysadmin post-install.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoReplace dependencies on koha-dev-env with list of packages.
Lars Wirzenius [Tue, 25 May 2010 01:44:08 +0000 (13:44 +1200)]
Replace dependencies on koha-dev-env with list of packages.

The dependencies are needed both at build time and at run time. Build
time needs them for running tests. To avoid duplicating the (long!)
list of dependencies, we do a little bit of trickery, and generate
a koha:Depends substvar, from all build dependencies (except debhelper),
and use ${koha:Depends} in the koha-common (not koha) Depends header.
A little bit tricky, but works.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoSplit off koha-common.
Lars Wirzenius [Tue, 25 May 2010 01:44:07 +0000 (13:44 +1200)]
Split off koha-common.

koha-common will be suitable for hosts with multiple Koha instances,
or those that otherwise need to do thing differently from the main
koha package.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoSet version number in debian/changelog to indicate upcoming 3.2.
Lars Wirzenius [Tue, 25 May 2010 01:44:06 +0000 (13:44 +1200)]
Set version number in debian/changelog to indicate upcoming 3.2.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoConvert debian/copyright file to the DEP5 format.
Lars Wirzenius [Tue, 25 May 2010 01:44:05 +0000 (13:44 +1200)]
Convert debian/copyright file to the DEP5 format.

The DEP5 format is machine-parseable, which will help keep track of
things in the future.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoSwitch to native source format.
Lars Wirzenius [Tue, 25 May 2010 01:44:04 +0000 (13:44 +1200)]
Switch to native source format.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBugfix: Install old yui stylesheets, since Koha needs them.
Lars Wirzenius [Tue, 25 May 2010 01:44:03 +0000 (13:44 +1200)]
Bugfix: Install old yui stylesheets, since Koha needs them.

Also fix paths, since we can't install them where Koha expects them,
since that location is used by the Debian packaged yui.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBugfix: Create the jquery.js symlink for opac to the right target.
Lars Wirzenius [Tue, 25 May 2010 01:44:02 +0000 (13:44 +1200)]
Bugfix: Create the jquery.js symlink for opac to the right target.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBugfix: Remove Debian packaging files remaining from old packaging effort.
Lars Wirzenius [Tue, 25 May 2010 01:44:01 +0000 (13:44 +1200)]
Bugfix: Remove Debian packaging files remaining from old packaging effort.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBugfix: Remove pointless executable bits from sql files.
Lars Wirzenius [Tue, 25 May 2010 01:44:00 +0000 (13:44 +1200)]
Bugfix: Remove pointless executable bits from sql files.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoremoved unconditional warn introduced in previous patch
Galen Charlton [Mon, 24 May 2010 15:15:18 +0000 (11:15 -0400)]
removed unconditional warn introduced in previous patch

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years ago(bug #4487) permit - and . in callnumber plugin
Nahuel ANGELINETTI [Wed, 12 May 2010 11:44:32 +0000 (13:44 +0200)]
(bug #4487) permit - and . in callnumber plugin

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoCorrect position of non-sorted table column
Owen Leonard [Wed, 12 May 2010 12:37:17 +0000 (08:37 -0400)]
Correct position of non-sorted table column

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoRevert "(bug #3798) fix changing request branch"
Galen Charlton [Mon, 24 May 2010 15:00:41 +0000 (11:00 -0400)]
Revert "(bug #3798) fix changing request branch"

This reverts commit ad01b57bcced141cf3c14f3b44e59114adf8024e.

This commit had introduced bug 4526.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoCorrected: Fix for Bug 4529, columns on circ history all screwy
Owen Leonard [Wed, 19 May 2010 13:46:12 +0000 (09:46 -0400)]
Corrected: Fix for Bug 4529, columns on circ history all screwy

- fix formatting of last renew date
- Add table zebra striping
- Other markup structure changes
- Revised template assumes that issues.branchcode == checkout library and displays
  that value instead of issues.issuingbranch (which is always empty, see Bug 2806)
  issues.branchcode seems to reflect the item's holding branch *after* having
  been updated as part of the checkout transaction.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years ago(BUG #4521) aqbudgets.pl - Transform undefined budget spent value to 0.00 value
Alex Arnaud [Tue, 18 May 2010 07:43:20 +0000 (09:43 +0200)]
(BUG #4521) aqbudgets.pl - Transform undefined budget spent value to 0.00 value

This patch tranform the undefined value of budget spent to a money value which equals 0.00.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoRemove obsolete variables from basket.pl
Colin Campbell [Tue, 18 May 2010 16:34:34 +0000 (17:34 +0100)]
Remove obsolete variables from basket.pl

basket.pl calculates variables i, odd and count which are
no longer used in the template
removing them allows some simplification of the main loop
and cuts out on an extra db call
Loop through basketgroups also made more readable
Try to dimish the number of undef warnings filling the logs

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoRemove generation of an unnecessary warning
Colin Campbell [Wed, 19 May 2010 14:00:09 +0000 (15:00 +0100)]
Remove generation of an unnecessary warning

We've checked the return for definedness and
assigned an empty string to it ao we don't want
to make it undef again

This is a good argument that cascading if-elses expecially with
long unstructured elses are a bad idea

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 4510 Script processes single supplier not an array
Colin Campbell [Wed, 19 May 2010 17:42:38 +0000 (18:42 +0100)]
Bug 4510 Script processes single supplier not an array

Script was written as though it had an array rather than
a single supplier. Replaced the excess punctuation with a single
supplier variable

replaced the C-style currency loop with a simpler perl-style one
we only need 1 loop not multiples
Changed variable name $GST to $tax_rate it's not magical and not a constant
and we all know what tax is
Fetch Contract data once rather than twice from two different modules
Correct size of discount data on display

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years ago(bug #4522) fix plugin unimarc 210$c
Nahuel ANGELINETTI [Tue, 18 May 2010 08:02:38 +0000 (10:02 +0200)]
(bug #4522) fix plugin unimarc 210$c

This patch change the way to retrieve the value to insert in the record.
The way it was done, was verry ugly.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 4517 - add authentication to reorder_members.pl
Colin Campbell [Wed, 19 May 2010 09:25:08 +0000 (10:25 +0100)]
Bug 4517 - add authentication to reorder_members.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoupdate sample news on new install with koha-community.org urls
Nicole Engard [Fri, 21 May 2010 09:01:27 +0000 (05:01 -0400)]
update sample news on new install with koha-community.org urls

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoFix for Bug 4534, Box for SQL not visible in "Create Report from SQL"
Owen Leonard [Thu, 20 May 2010 12:16:02 +0000 (08:16 -0400)]
Fix for Bug 4534, Box for SQL not visible in "Create Report from SQL"

Changed style of SQL box and altered markup for a somewhat
cleaner layout

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agomoved INSTALL.debian-lenny to INSTALL.debian
Galen Charlton [Mon, 24 May 2010 12:35:07 +0000 (08:35 -0400)]
moved INSTALL.debian-lenny to INSTALL.debian

The old INSTALL.debian was specific to Etch, which is
no longer supported by the Debian project.  Lenny
is the current Debian stable.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoupdated links to Git usage wiki page
Galen Charlton [Mon, 24 May 2010 12:32:14 +0000 (08:32 -0400)]
updated links to Git usage wiki page

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agocorrected links to mailing lists
Galen Charlton [Mon, 24 May 2010 12:26:20 +0000 (08:26 -0400)]
corrected links to mailing lists

They use http, not https.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoUpdating INSTALL documents to Reflect lists and bugs URL Changes
Chris Nighswonger [Fri, 21 May 2010 13:06:10 +0000 (09:06 -0400)]
Updating INSTALL documents to Reflect lists and bugs URL Changes

wiki links will be changed as the content is moved over

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoupdated links in README
Galen Charlton [Mon, 24 May 2010 12:14:16 +0000 (08:14 -0400)]
updated links in README

Following patch made by Chris Cormack.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoUpdating INSTALL documents
Chris Nighswonger [Thu, 20 May 2010 01:35:53 +0000 (21:35 -0400)]
Updating INSTALL documents

This provides the following updates to the INSTALL documents:

- Links updated to reflect currently available community resources at their new locations
- Removes depreciated zebraqueue instructions
- Adds notes regarding the proper usage of rebuild_zebra.pl

NOTE: Remaining links will be updated as these resources are moved over and available

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4464: properly check if a subfield is populated if it is in a textarea
Galen Charlton [Fri, 21 May 2010 17:00:58 +0000 (13:00 -0400)]
bug 4464: properly check if a subfield is populated if it is in a textarea

Subfields whose contents are longer than 100 characters are represented on the
bib form using a <textarea> instead of a text <input>.  The check on whether
at least one subfield for a mandatory field is populated wasn't not
checking for <textarea> subfields.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 2889: Adds highlighting to serials-collection.tmpl
Garry Collum [Sat, 22 May 2010 17:41:52 +0000 (13:41 -0400)]
Bug 2889: Adds highlighting to serials-collection.tmpl

Also fixes inconsistencies in the capitalization in the headings.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 3910: Removes an erroneous heading from the serials search results.
Garry Collum [Sat, 22 May 2010 14:50:31 +0000 (10:50 -0400)]
Bug 3910: Removes an erroneous heading from the serials search results.

Removes the 'Search for Serial Routing' heading from the serials search result screen.

There is no code in the template that performs a routing search, and links to the routing tables are provided in the serials search results.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4505: updated release notes
Galen Charlton [Mon, 24 May 2010 11:51:19 +0000 (07:51 -0400)]
bug 4505: updated release notes

Minimum version of Perl required to run Koha is
now 5.8.8.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 4505 - Bumping the perl version to 5.8.8 or greater
Chris Cormack [Sat, 22 May 2010 08:15:59 +0000 (20:15 +1200)]
Bug 4505 - Bumping the perl version to 5.8.8 or greater

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4802 - fix swapped files in acq help
Nicole Engard [Fri, 21 May 2010 10:48:36 +0000 (06:48 -0400)]
bug 4802 - fix swapped files in acq help

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4802 add missing order search help file
Nicole Engard [Fri, 21 May 2010 10:16:04 +0000 (06:16 -0400)]
bug 4802 add missing order search help file

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4801: fix paging in display of staged bibs and import batches
Galen Charlton [Fri, 21 May 2010 13:34:42 +0000 (09:34 -0400)]
bug 4801: fix paging in display of staged bibs and import batches

Fixed glitch where the first page of bibs in a batch (or the first
page of import batches) was displaying the entire list instead
of the correct number of records per page.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4802 add new acq help files
Nicole Engard [Fri, 21 May 2010 09:24:30 +0000 (05:24 -0400)]
bug 4802 add new acq help files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoupdate main page help file
Nicole Engard [Fri, 21 May 2010 09:08:31 +0000 (05:08 -0400)]
update main page help file

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agofix XHTML error in bib details print page
Galen Charlton [Wed, 19 May 2010 15:38:56 +0000 (11:38 -0400)]
fix XHTML error in bib details print page

"&nbsp;" is not subtitutable for a table row

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years ago(bug #4519) fix record printing
Nahuel ANGELINETTI [Mon, 17 May 2010 14:18:51 +0000 (16:18 +0200)]
(bug #4519) fix record printing

this add a js that print a record

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 4525: Invalid XHTML in currency.tmpl.
Garry Collum [Tue, 18 May 2010 19:51:54 +0000 (15:51 -0400)]
Bug 4525: Invalid XHTML in currency.tmpl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4151: fix migration_tools typo
Galen Charlton [Mon, 17 May 2010 14:50:07 +0000 (10:50 -0400)]
bug 4151: fix migration_tools typo

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 4516 (Character shift in MARC21 Field 008)
Marcel de Rooy [Mon, 17 May 2010 12:17:59 +0000 (14:17 +0200)]
Bug 4516 (Character shift in MARC21 Field 008)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBacking down the required version of Graphics::Magick
Chris Nighswonger [Mon, 17 May 2010 14:23:47 +0000 (10:23 -0400)]
Backing down the required version of Graphics::Magick

This brings the required version into line with the latest version available in the Debian and Ubuntu repos.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoEnhancement Bug 4444: Centralize Code Handling Perl Dependencies
Chris Nighswonger [Sat, 15 May 2010 22:13:13 +0000 (18:13 -0400)]
Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

Porting about.pl over to use C4::Installer::PerlModules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoEnhancement Bug 4444: Centralize Code Handling Perl Dependencies
Chris Nighswonger [Sat, 15 May 2010 22:13:14 +0000 (18:13 -0400)]
Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

Porting install.pl over to use C4::Installer::PerlModules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoEnhancement Bug 4444: Centralize Code Handling Perl Dependencies
Chris Nighswonger [Sat, 15 May 2010 22:13:15 +0000 (18:13 -0400)]
Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

This patch adds a script to allow checking the status of Koha's Perl dependencies from the
command line interface at any time. Run '$ ./koha_perl_deps.pl --help' for available options.
'$ ./koha_perl_deps.pl -c' is recommended if you like color.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoEnhancement Bug 4444: Centralize Code Handling Perl Dependencies
Chris Nighswonger [Sat, 15 May 2010 22:13:12 +0000 (18:13 -0400)]
Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

Porting Makefile.PL over to use C4::Installer::PerlModules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoEnhancement Bug 4444: Centralize Code Handling Perl Dependencies
Chris Nighswonger [Sat, 15 May 2010 22:13:11 +0000 (18:13 -0400)]
Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

This patch adds two modules: C4::Installer::PerlModule and C4::Installer::PerlDependencies. The latter provides a single point
of reference for cataloging Koha Perl dependencies. The former provides an OO style interface to the dependency catalog.

The format of C4::Installer::PerlDependencies is very simply an anonymous hash of hashes. Each second level hash takes this form:

'Foo::Bar' => {
  'usage'    => 'FooBar Feature',
  'required' => '1', # 0 if optional
  'min_ver'  => '0.01',
},

New modules can be appended to C4::Installer::PerlDependencies as needed and will be picked up by every piece of code which needs
this information.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4509: remove references to PINESISBN system preference
Galen Charlton [Fri, 14 May 2010 20:10:52 +0000 (16:10 -0400)]
bug 4509: remove references to PINESISBN system preference

This system preference never worked; also, as far as I can tell,
the PINES oISBN service was experimental, not meant for production
use, and is not currently advertised.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 4507 Don't return null vendor to claims processing
Colin Campbell [Fri, 14 May 2010 16:24:13 +0000 (17:24 +0100)]
Bug 4507 Don't return null vendor to claims processing

The empty vendor created by the select if any subscriptions
have no associated vendor generates a 'wrong-looking' display
and selecting it gives no options

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 2505 enable warnings in serials/reorder_members.pl
Colin Campbell [Sat, 15 May 2010 12:40:18 +0000 (13:40 +0100)]
Bug 2505 enable warnings in serials/reorder_members.pl

The only serials routine without warnings enabled was a
script with the least code to generate them
removed the numerous Module use declarations that were not
required
aligned the parameters for a more aesthetically pleasing effect

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 3768 (Bibliographic Framework Test)
Marcel de Rooy [Mon, 17 May 2010 09:16:02 +0000 (11:16 +0200)]
Bug 3768 (Bibliographic Framework Test)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agofix XHTML error in about.tmpl
Galen Charlton [Fri, 14 May 2010 12:40:56 +0000 (08:40 -0400)]
fix XHTML error in about.tmpl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoRevert "Bug 4450 Use more consistent error returns in C4/Creators/*"
Galen Charlton [Fri, 14 May 2010 00:20:02 +0000 (20:20 -0400)]
Revert "Bug 4450 Use more consistent error returns in C4/Creators/*"

This reverts commit 1f56a04cadc60f26b36f5599f24d0f380bc23828.

[RM note: I confirm Chris Nighswonger's testing that shows that
 the patch causes regressions, including breaking creating new
 label layouts.]

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBUG 4499: Javascript error messages not translatable
Katrin Fischer [Thu, 13 May 2010 21:30:22 +0000 (23:30 +0200)]
BUG 4499: Javascript error messages not translatable

- Administration > Patron categories > New Category (category.tmpl)
- Circulation > Checkouts > Toolbar (all tabs except Check out) (members-toolbar.inc)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBUG 4499: Javascript error messages not translatable
Katrin Fischer [Fri, 23 Apr 2010 16:37:01 +0000 (18:37 +0200)]
BUG 4499: Javascript error messages not translatable

- Cataloging > New Record (addbiblio.tmpl)
- Administration > Currencies > New Currency (currency.tmpl)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 4141 Reconcile 3.0.x and HEAD database updates for 3.2.0
Chris Nighswonger [Wed, 12 May 2010 12:00:50 +0000 (08:00 -0400)]
Bug 4141 Reconcile 3.0.x and HEAD database updates for 3.2.0

This is a partial fix addressing this error:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 at /home/koha/koha.prod/installer/data/mysql/updatedatabase.pl line 2916., referer: http://koha-staff.foobar.org/cgi-bin/koha/installer/install.pl

If there are no records in aqbudgets the result is an empty array which causes the sql to attempt to set AUTOINCREMENT to null.

This patch is being submitted on behalf of the Mapua Community Library.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoCorrect URL for Baker & Taylor ContentCafe
J. David Bavousett [Tue, 11 May 2010 17:55:09 +0000 (13:55 -0400)]
Correct URL for Baker & Taylor ContentCafe

This patch updates the URL for image links in ContentCafe

Sponsored by Plano Independent School District, Plano, TX, USA

[RM note: the previous book cover URL was for a varient of Baker
 and Taylor's service that has to do with 'bookstore integration',
 and if I remember correctly, the main difference is that the
 book jacket image had "buy now" text.  The version supplied
 in this patch should work for normal use of ContentCafe.]

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years ago(MT3318) RSS OPAC: Adding CDATA term in title and description tags.
Paul Poulain [Wed, 12 May 2010 09:17:56 +0000 (11:17 +0200)]
(MT3318) RSS OPAC: Adding CDATA term in title and description tags.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoHousekeeping in errors scripts
Colin Campbell [Wed, 12 May 2010 11:25:41 +0000 (12:25 +0100)]
Housekeeping in errors scripts

Enable warnings - remove Bug 2505 FIXME messages
Correct FSF address in License statement
To aid code analysis tools:
Call new unambiguously with arrow syntax
use noninterpolating quotes on noninterpolating strings

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoFix for Bug 4485, System preferences page uses non-standard warning style
Owen Leonard [Tue, 11 May 2010 14:14:25 +0000 (10:14 -0400)]
Fix for Bug 4485, System preferences page uses non-standard warning style

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoA couple of CSS and markup corrections
Owen Leonard [Tue, 11 May 2010 14:10:02 +0000 (10:10 -0400)]
A couple of CSS and markup corrections

- moving inline style declaration to the default stylesheet
- correcting markup structure on advanced search screen to allow
  consistent custom styling

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 4300 Display 866z summary holdings public note in OPAC
Jane Wagner [Thu, 4 Mar 2010 19:32:29 +0000 (14:32 -0500)]
Bug 4300 Display 866z summary holdings public note in OPAC

Added the 866z to the MARC21slim2OPACDetail.xsl file so that it displays
just above the 780 and 785 fields.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agostocknumber not saved properly
Paul Poulain [Fri, 26 Mar 2010 10:25:39 +0000 (11:25 +0100)]
stocknumber not saved properly

if you have a marc field, mapped to items.stocknumber, it's not saved properly in items.stocknumber

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoMT2582: Fix user deletion without permission
Matthias Meusburger [Wed, 10 Mar 2010 21:26:04 +0000 (22:26 +0100)]
MT2582: Fix user deletion without permission

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agowr-70205 Rental discount not being respected
Chris Cormack [Thu, 6 May 2010 23:24:23 +0000 (11:24 +1200)]
wr-70205 Rental discount not being respected

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoDB rev 134: DisplayMultiPlaceHold syspref
Galen Charlton [Tue, 11 May 2010 11:45:28 +0000 (07:45 -0400)]
DB rev 134: DisplayMultiPlaceHold syspref

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoFollow up to bug3093 patch
Chris Cormack [Tue, 11 May 2010 05:13:59 +0000 (17:13 +1200)]
Follow up to bug3093 patch

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 3093 add syspref to turn off multiholds button
Jane Wagner [Tue, 11 May 2010 05:13:58 +0000 (17:13 +1200)]
Bug 3093 add syspref to turn off multiholds button

Having the place multiple holds button at the top of the OPAC and staff search results has caused problems for some sites with tight holds policies; this syspref allows those sites to turn off the button.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 3928: Modified date should follow syspref
Colin Campbell [Tue, 11 May 2010 10:24:41 +0000 (11:24 +0100)]
Bug 3928: Modified date should follow syspref

Changed arriveddate format to follow syspref
Fixed a whitespace error

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 3928: Modification of date for serials.
J. David Bavousett [Tue, 11 May 2010 08:10:58 +0000 (20:10 +1200)]
Bug 3928: Modification of date for serials.

When a serial status is changed to "Arrived" or "Claimed", the "Expected on"
date is changed to the current date.

A bit of rewriting to get it to apply on master - chris@bigballowax.co.nz

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoDisplay current selected category when editing lists.
Matthew Hunt [Sun, 9 May 2010 21:20:10 +0000 (09:20 +1200)]
Display current selected category when editing lists.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoFix for Bug 4475, AmazonLocale not used consistently
Owen Leonard [Mon, 10 May 2010 16:21:58 +0000 (12:21 -0400)]
Fix for Bug 4475, AmazonLocale not used consistently

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoMarkup corrections for validity and to eliminate horizontal scrollbar
Owen Leonard [Mon, 10 May 2010 13:32:44 +0000 (09:32 -0400)]
Markup corrections for validity and to eliminate horizontal scrollbar

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoFix for Bug 4400, BIBTEX export from OPAC results in empty file
Owen Leonard [Mon, 10 May 2010 19:24:47 +0000 (15:24 -0400)]
Fix for Bug 4400, BIBTEX export from OPAC results in empty file

opac-export.pl tries to get two variables from marc2bibtex(),
but it only returns one.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 4470 Patron search result pagination bar
Frédéric Demians [Sat, 8 May 2010 06:27:51 +0000 (08:27 +0200)]
Bug 4470 Patron search result pagination bar

Obviously, Koha global pagination function could be improved. This patch
do something which belongs to this function. A CPAN module like
Data::Page could help or be an inspiration... 3.4?

There is also room for improvement in they way resultset are
constructed. The whole set is retrieved and just a subset is displayed.
It impacts performances for libraries with a great number of patrons.
The right solution would be:

  - to find the resultset size with SELECT COUNT(*)
  - to retrieved the exact subset with LIMIT and OFFSET SQL arguments

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoDo not declare variables within (bogus) conditionals
Colin Campbell [Sun, 9 May 2010 14:58:52 +0000 (15:58 +0100)]
Do not declare variables within (bogus) conditionals

if $index is unnecessary as we have made this true 5 lines above
variables should not be declared in conditionals if used outside of them
set $struct_attr to a sensible default to avoid generating warnings
in this assigment and elsewhere

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoReserve and onloan were reporting the same cardnumber, due to a little bug in detail...
Chris Cormack [Mon, 10 May 2010 04:23:17 +0000 (16:23 +1200)]
Reserve and onloan were reporting the same cardnumber, due to a little bug in detail.pl fixed by this patch

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoFix for Bug 3666, Overriding renewal limit means negative count in OPAC
Owen Leonard [Fri, 7 May 2010 17:31:37 +0000 (13:31 -0400)]
Fix for Bug 3666, Overriding renewal limit means negative count in OPAC

Setting "renewalsleft" variable to zero if it comes out negative.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoFix template errors introduced in my last patch for Bug 4208
Owen Leonard [Fri, 7 May 2010 19:14:57 +0000 (15:14 -0400)]
Fix template errors introduced in my last patch for Bug 4208

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 3671 Workaround for font display problem
Jane Wagner [Wed, 7 Oct 2009 13:52:02 +0000 (09:52 -0400)]
Bug 3671 Workaround for font display problem

If there is no 007 field, parts of the OPAC results data display in a
much smaller font than normal.  Adding a blank space in the span section
fixes it.
(cherry picked from commit 2ff55ef2a2443933881186323f5dec3fe40842dd)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4403: look in appropriate theme/lang for bib display XSL
Galen Charlton [Sat, 8 May 2010 22:59:41 +0000 (18:59 -0400)]
bug 4403: look in appropriate theme/lang for bib display XSL

Note: approach used can be described as a hack at best; the current
language should probably become a session attribute.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agofix disappearance of language chooser introduced in recent patch
Galen Charlton [Sat, 8 May 2010 22:58:36 +0000 (18:58 -0400)]
fix disappearance of language chooser introduced in recent patch

Note that xt/author/valid-templates.t did *not* catch the
missing /TMPL_IF

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoquell 'non-initialized variable defaulttab' warning
Galen Charlton [Sat, 8 May 2010 22:57:41 +0000 (18:57 -0400)]
quell 'non-initialized variable defaulttab' warning

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agofix malformed call of XSLTParse4Display
Galen Charlton [Sat, 8 May 2010 22:05:23 +0000 (18:05 -0400)]
fix malformed call of XSLTParse4Display

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoFurther corrections for Bug 4244, Use "checkouts" instead of "issues"
Owen Leonard [Wed, 5 May 2010 19:38:27 +0000 (15:38 -0400)]
Further corrections for Bug 4244, Use "checkouts" instead of "issues"

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoStyle changes to cart popup window more compact display: - compact holdings list...
Owen Leonard [Tue, 4 May 2010 15:24:28 +0000 (11:24 -0400)]
Style changes to cart popup window more compact display: - compact holdings list - adds list bullet image from the staff client

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years ago(MT #2966) fix opac-user.pl function problem
Nahuel ANGELINETTI [Wed, 10 Mar 2010 21:26:30 +0000 (22:26 +0100)]
(MT #2966) fix opac-user.pl function problem

This uncomment a uselessly commented function that is needed by opac-user. And fix this function that doesn't work properly.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 4450 Use more consistent error returns in C4/Creators/*
Colin Campbell [Thu, 6 May 2010 17:13:36 +0000 (13:13 -0400)]
Bug 4450 Use more consistent error returns in C4/Creators/*

A lot of routines were defaulting to return -1 in error conditions
but calling code was expecting a ref or object
use return with explicit undef (or emptyness in array context)
for these cases. Extended this to cases where return was not tested
( -1 might in some cases be legit data).

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit 5cf2b78b6ffa401bc82b3f913c89828c38b8e4ed)
[RM note: ... thereby undoing the revert]

11 years agoBug 4465 Fixes translated boolean syspref inversion
Frédéric Demians [Fri, 7 May 2010 05:37:17 +0000 (07:37 +0200)]
Bug 4465 Fixes translated boolean syspref inversion

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoanother FSF address fix
Galen Charlton [Fri, 7 May 2010 00:31:04 +0000 (20:31 -0400)]
another FSF address fix

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agofix two more instances of old FSF address
Galen Charlton [Fri, 7 May 2010 00:28:29 +0000 (20:28 -0400)]
fix two more instances of old FSF address

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoAdding new developers to the about page, need to do libraries next
Chris Cormack [Thu, 6 May 2010 22:03:10 +0000 (10:03 +1200)]
Adding new developers to the about page, need to do libraries next

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoAdding a new developer plus 2 new meetings to the history doc
Chris Cormack [Thu, 6 May 2010 22:03:09 +0000 (10:03 +1200)]
Adding a new developer plus 2 new meetings to the history doc

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoexclude TinyMCE from non-UTF8 file checks
Galen Charlton [Thu, 6 May 2010 23:55:44 +0000 (19:55 -0400)]
exclude TinyMCE from non-UTF8 file checks

Since Koha otherwise had made no modifications to the TinyMCE,
we'll leave it alone.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agomove misc source file test and fix scripts to xt/
Galen Charlton [Thu, 6 May 2010 23:46:51 +0000 (19:46 -0400)]
move misc source file test and fix scripts to xt/

The license and non-UTF8 file checks are closer to
author tests and don't really belong at the top level of the
Koha source tree.  Follow-up might be to converted them
to test cases in xt/author that can be run by prove(1).

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoAdd script to find source files that are not in UTF-8.
Lars Wirzenius [Thu, 25 Mar 2010 22:11:05 +0000 (11:11 +1300)]
Add script to find source files that are not in UTF-8.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoConvert to UTF-8.
Lars Wirzenius [Thu, 25 Mar 2010 22:11:11 +0000 (11:11 +1300)]
Convert to UTF-8.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>