koha.git
6 years agoBug 10904: Limit patron update request management by branch
Kyle M Hall [Thu, 10 Oct 2013 14:46:17 +0000 (10:46 -0400)]
Bug 10904: Limit patron update request management by branch

By not limiting the patron modification lists by branch, it can quickly
become overwhelming for a librarian. This patch makes the following
modifications:

* Only superlibrians will see the full list of borrowers with pending
  modifications.
* Adds the patron cardnumber after the patrons name on the modification
  list.
* Adds a link to the patron's record from the modification list.

Test Plan:
1) Apply this patch
2) Set up some pending modifications for two branches
3) Log in to the staff intranet as one of those branches
4) You should note the number of pending modifications counts
   only your logged in branch's patrons
5) Click the link, you should only see your logged in branches
   patrons in the pending modifications list.
6) You should note the cardnumber is displayed next to the patron name
7) You should note the "View record" link below each patron's name

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comments on last patch.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14198: RDA: Indexing 264 field (Zebra)
Hector Eduardo Castro Avalos [Mon, 1 Jun 2015 02:54:58 +0000 (20:54 -0600)]
Bug 14198: RDA: Indexing 264 field (Zebra)

This patch add zebra indexes to RDA 264 field.
The new Provider index is added too.
QA comments corrected.

To test:
1) Download RDA records with 264 fields from this attachment <http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36825>. Import the file and re-index/rebuild zebra. These records contain 260 and 264 fields per record.
2) Do a search with pb:Bethany two records will appear with title The guardian. Search with pl:Minneapolis too, the two records will appear.
3) Select one record of both records and delete the 260 field keeping the 264 field and save, rebuild your zebra.
4) Search again with pb:Bethany and just one record will appear. Thats mean 264 is not indexed.
5) Apply patches.
6) Rebuild your zebra but this time all biblio records.
7) Search again with pv:Bethany or Provider:Bethany, this time will appear the two records, 264 is indexed. Note that if you search again with pb only one record appear. This is because the suggestion of LOC.
10) Search with copydate:2013 only launch records with 260 fields and pv:2013 show both fields, i.e., 260 and 264.
11) Apply QA Test Tools

Sponsored-by: Universidad de El Salvador
Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14773: Move help link back out of the dropdown menu
Joonas Kylmälä [Tue, 8 Sep 2015 10:23:37 +0000 (10:23 +0000)]
Bug 14773: Move help link back out of the dropdown menu

This moves the help link back out of the dropdown menu
like it used to be.

To test:

1. Notice that in intra the help link is inside the dropdown
   menu.
2. Apply the patch
3. Notice that the help link is now clearly visible in the
   top right corner of the page.

Sponsored-by: Vaara-kirjastot
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 15073: Move FeeOnChangePatronCategory
Nicole C. Engard [Wed, 28 Oct 2015 14:30:06 +0000 (09:30 -0500)]
Bug 15073: Move FeeOnChangePatronCategory

This patch moves the FeeOnChangePatronCategory system
preference so that it's in a more logical place. Also
a few typos were fixed.

To test:

* Go to System Preferences
* Go to Patrons
* Find FeeOnChangePatronCategory and confirm

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Confirmed. No errors.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 15090: Fix date filter for Suggestions management
Marc Véron [Fri, 30 Oct 2015 14:23:30 +0000 (15:23 +0100)]
Bug 15090: Fix date filter for Suggestions management

Home > Acquisitions > Suggestions management:
Before 13813 the "from" date in filters was 0000-00-00 if not
filled, afer 13813 it's today.

This patch re-introduces 0000-00-00.

See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813#c172

To test:
- Go to Home > Acquisitions > Suggestions management
- Verify that date filters work as expected
- Verify that start dates in sql query are 0000-00-00 if no start
  dates are given
- Note: Line 185 outputs the start dates as warn if $debug is set.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 10799: Limit the SCO user to the SCO module
Jonathan Druart [Wed, 2 Sep 2015 16:13:41 +0000 (17:13 +0100)]
Bug 10799: Limit the SCO user to the SCO module

The SCO user should only be allowed to access to the SCO module.

This patch make the session ends if the user tries to access another
page after the SCO module.

Test plan:
0/ Configure the SCO module correctly
1/ Go on the sco main page (sco/sco-main.pl)
2/ Try to go somewhere else: you should not be logged in

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 15087: hardduedate should not be inserted as 0000-00-00 but NULL
Jonathan Druart [Fri, 30 Oct 2015 11:49:40 +0000 (11:49 +0000)]
Bug 15087: hardduedate should not be inserted as 0000-00-00 but NULL

This has been introduced by bug 14949, recently pushed.
So I don't think we need to update the DB, only devs will face this
problem.

The hardduedate was inserted as 0000-00-00 because was en empty string.
To be inserted as NULL, the value should be undef.

Test plan:
0/ Don't apply this patch
1/ Edit a circ rules and don't fill the hard due date
2/ Look at the DB, the value is 0000-00-00
3/ Apply this patch and confirm that the value is now NULL

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Confirmed
+--------------+----------+-------------+
| categorycode | itemtype | hardduedate |
+--------------+----------+-------------+
| *            | *        | NULL        |
+--------------+----------+-------------+

No koha-qa errors

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 15094: Update link to Windows Offline Circ
Nicole C. Engard [Fri, 30 Oct 2015 20:28:09 +0000 (15:28 -0500)]
Bug 15094: Update link to Windows Offline Circ

This patch updates the link on the main circulation
page to point to the newest release of the offline
circulation tool.

To test:

* Go to Circulation
* Click 'Get desktop application'
* Confirm the link goes to github

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Link Ok
No errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14333: followup 2 - split line to ease translation
Bernardo Gonzalez Kriegel [Mon, 26 Oct 2015 12:22:02 +0000 (09:22 -0300)]
Bug 14333: followup 2 - split line to ease translation

This patch only put in its own line inserted values.
This is necessary in order to translate this files.

To test:
1) Just check that files load normally.

http://bugs.koha-community.org/show_bug.cgi?id=14333

Signed-off-by: Zeno Tajoli <z.tajoli@cineca.it>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14333: followup - Fix labels
Bernardo Gonzalez Kriegel [Thu, 22 Oct 2015 17:02:27 +0000 (14:02 -0300)]
Bug 14333: followup - Fix labels

This patch fixes same labels on bibliographic and
authority frameworks, and one typo.

To test:
1) Remove all your frameworks
2) Check mandatory bibliographic and authority files load without problem
3) Check fixed labels

Signed-off-by: Zeno Tajoli <z.tajoli@cineca.it>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14333: Update MARC21 frameworks to Update No. 20 and 21
Bernardo Gonzalez Kriegel [Thu, 22 Oct 2015 15:34:47 +0000 (12:34 -0300)]
Bug 14333: Update MARC21 frameworks to Update No. 20 and 21

Default frameworks updated to update 20 (April 2015) and
21 (September 2015)

Update No. 20
Bibliographic
New field 884
New subfields 037$3, 037$5 and 382$e

Authority
New field 884
New subfields 046$q, 046$r and 382$e

Update No. 21
Bibliographic
New tag 348
New subfields 336$0, 337$0 and 338$0

Authority
New field 348
New sufields 336$0 and 670$w

To test:
1) Remove all your frameworks
2) Check mandatory bibliographic and authority files load without problem
3) Check new fields/subfields

Signed-off-by: Zeno Tajoli <z.tajoli@cineca.it>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 15093: Load/show saved item type group and hideinopac
Bernardo Gonzalez Kriegel [Fri, 30 Oct 2015 19:25:15 +0000 (16:25 -0300)]
Bug 15093: Load/show saved item type group and hideinopac

This patch adds loading of hideinopac and searchgroup
when showing/editing itemtypes

To test:
1) Put some values in ITEMTYPCAT auth value
2) Edit an item type, select a value for
search category & check 'Hide in OPAC'
Save
3) Results do no show on list of item types
4) Edit same item type, values are default/empty
5) Apply the patch
6) Edit again, change again, save
Now values shows in list
7) Edit again, values are now correct

Values were saved on db, but not loaded from it
How this happen?

Side note: searching for searchcategory I found

installer/data/mysql/kohastructure.sql:  searchcategory varchar(80) default NULL, -- Group this item type with others w
installer/data/mysql/updatedatabase.pl:            ADD searchcategory VARCHAR(20) DEFAULT NULL

Its varchar(80) in kohastructure and varchar(20) in updatedatabase

We need more eyes :)

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 15063: Update MARC21 es-ES frameworks to Update 21 (September 2015)
Bernardo Gonzalez Kriegel [Mon, 26 Oct 2015 13:11:12 +0000 (10:11 -0300)]
Bug 15063: Update MARC21 es-ES frameworks to Update 21 (September 2015)

This patch put in sync es-ES marc21 fields/subfields with
english ones.

To test:
1) Apply the patch
2) Remove all bib/auth frameworks
3) Load all files, check they load without errors

Signed-off-by: Zeno Tajoli <z.tajoli@cineca.it>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 15092: item type descriptions not showing in OPAC advsearch
Bernardo Gonzalez Kriegel [Sat, 31 Oct 2015 14:03:55 +0000 (11:03 -0300)]
Bug 15092: item type descriptions not showing in OPAC advsearch

Go to OPAC > Advanced Search
Tab 'Item type' only shows itemtype icons,
no descriptions. Descriptions must be shown
always

To test:
1) Go to OPAC > Advanced search
2) Check no descriptions for item types
Also check that, reloading the page, item types
shows in random order
3) Apply the patch
4) Check there are descriptions now
and order is by description

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 10937: (QA followup) updatedatabase.pl vs. kohastructure.sql field size missmatch
Tomas Cohen Arazi [Sat, 31 Oct 2015 13:22:25 +0000 (10:22 -0300)]
Bug 10937: (QA followup) updatedatabase.pl vs. kohastructure.sql field size missmatch

The bug included a discussion about this field size. And it got corrected in
kohastructure.sql to match the authorized values, but the updatedabase.pl entry
was missed on hte fix.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 15010: Import patron tool creates 'duplicate' restrictions ( debarments )
Kyle M Hall [Wed, 14 Oct 2015 12:48:30 +0000 (08:48 -0400)]
Bug 15010: Import patron tool creates 'duplicate' restrictions ( debarments )

If a patron has restrictions and a CSV file of patrons to be overwritten
is uploaded but has no debarred / debarredcomment columns, the a new
restriction will be added that combines all the existing restrictions (
i.e. a new debarment based on the existing borrowers.debarred
and borrowers.debarredcomment fields ).

Test Plan:
1) Create a patron with one or more restrictions
2) Import a CSV file that updates that patron, but with no debarred columns
3) Note a new restrictions is created
4) Delete the new restriction
5) Apply this patch
6) Re-import the CSV file again
7) Note that no new restriction is created
8) Add debarred and debarredcomment columns to the CSV file with a test
   date and description
9) Re-import the CSV file again
10) Note the new restriction is added to the patron

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Daniel Grobani <dgrobani@samuelmerritt.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 15077: Fix Fast Add framework to pass test
Bernardo Gonzalez Kriegel [Thu, 29 Oct 2015 11:44:54 +0000 (08:44 -0300)]
Bug 15077: Fix Fast Add framework to pass test

This patch fixes tab location for FA frameworks.
Not all subfields belongs to tab 0.

To test:
1) On current master, with default and fasadd fw loaded,
go to Home > Administration > MARC bibliographic framework test
it fails

2) Apply the patch
3) Delete all fw, reload all, or just default (bib & auth) and
fast add
4) Repeat 1, now test must pass

This is only on master, so no need to database update.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised. MARC bibliographic framework test passed Ok.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 15072: (followup) fix spaces and consistency
Bernardo Gonzalez Kriegel [Thu, 29 Oct 2015 16:48:20 +0000 (13:48 -0300)]
Bug 15072: (followup) fix spaces and consistency

This patch add a few spaces when required and
adds layout_id on title and breadcrumbs (for patroncards)

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 15072: (followup) Use 'New' on Patron card creator too
Tomas Cohen Arazi [Tue, 27 Oct 2015 18:22:09 +0000 (15:22 -0300)]
Bug 15072: (followup) Use 'New' on Patron card creator too

This patch makes the change on the patron cards creator tool too.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
All patches without errors.
More consistent view.
A few spaces and a little fix in followup

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 15072: (followup) We use 'New' instead of 'Create' on the UI
Tomas Cohen Arazi [Tue, 27 Oct 2015 18:20:19 +0000 (15:20 -0300)]
Bug 15072: (followup) We use 'New' instead of 'Create' on the UI

This patch makes the UI show 'New' instead of 'Create' so it matches
the buttons, and the common practice on the UI.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 15072: Breadcrumbs and titles inconsistent in Label creator
Tomas Cohen Arazi [Tue, 27 Oct 2015 18:15:16 +0000 (15:15 -0300)]
Bug 15072: Breadcrumbs and titles inconsistent in Label creator

This patch makes the page title and breadcrumbs more consistent.
It does so by removing some text (Manage...) and using Edit (id) and Create
on building both the breadcrumbs and titles.

To test:
- Traverse all the Label creator options
=> FAIL: the texts are not consistent and don't match what we use in the patron card creator.
- Apply the patch
=> SUCCESS: Terminology is consistent, titles and breadcrumbs show the same information
- Sign off :-D

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 15053: Fix fr-FR, ru-RU and uk-UK sample creator data
Bernardo Gonzalez Kriegel [Mon, 26 Oct 2015 15:01:51 +0000 (12:01 -0300)]
Bug 15053: Fix fr-FR, ru-RU and uk-UK sample creator data

Fixes other sample creators data

To test:
1 ) Apply the patch
2) Remove sample creator date
delete from creator_layouts; delete from creator_templates; delete from printers_profile
3) Load fr-FR/2-Optionel/sample_labels.sql
or ru-RU/optional/print_labels.sql
or uk-UA/optional/print_labels.sql

Without the patch this files can't be loaded
Test all of them

In case of ru and uk I removed a patron card layout

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 15053: sample_creator_data.sql now fails during a fresh install
Kyle M Hall [Fri, 23 Oct 2015 14:10:38 +0000 (10:10 -0400)]
Bug 15053: sample_creator_data.sql now fails during a fresh install

ERROR 1136 (21S01) at line 6: Column count doesn't match value count at row 1

Test Plan:
1) Start fresh install
2) Install all test data
3) Note the SQL error
4) Apply this patch
5) Repeat steps 1 and 2
6) Note no error

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
All fixed files loads without problem.
No errors found
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 11881: QA follow-up - rename class
Katrin Fischer [Sun, 25 Oct 2015 10:52:46 +0000 (11:52 +0100)]
Bug 11881: QA follow-up - rename class

A suggestion for renaming the class to be a bit more "content" then "appearance".
Strictly optional.

.ItemSummary {
    display: block; # block - line breaks, inline - all one line
}

.LabelCallNumber {
    display: inline; # inline - display, none - don't display
}

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 11881: Small improvements for Items available for reference
genevieve [Fri, 11 Sep 2015 18:54:14 +0000 (14:54 -0400)]
Bug 11881: Small improvements for Items available for reference

As said on comment #31, Items available for reference weren't displayed like Items avaible for loan. Now, they are, I wrapped them in CommasWithLinebreaks class and LabelCallNumber class

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 11881: Small improvements for the availability informations in the search results...
simith [Wed, 4 Mar 2015 19:09:56 +0000 (14:09 -0500)]
Bug 11881: Small improvements for the availability informations in the search results list on the OPAC

This patch contains small modifications to the template of OPAC search results.
Theses modifications affect the "Availability" line :
* Add a linebreak after each location.
* Add the text "Call Number:" before call numbers.

To test:

I) Apply the patch

II) Include the following test in the OPACUserCSS preference:

.searchresults .CommasWithLinebreaks {
    display: block; # block - line breaks, inline - all one line
}

.searchresults .LabelCallNumber {
    display: inline; # inline - display, none - don't display
}

III) Do a search on the OPAC

IV) Validate : check the format of availability informations for each search result (Breakline or "Call Number:" text).

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )
Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 15082: t/db_dependent/Search.t shouldn't mock the DB connection
Tomas Cohen Arazi [Thu, 29 Oct 2015 14:20:06 +0000 (11:20 -0300)]
Bug 15082: t/db_dependent/Search.t shouldn't mock the DB connection

This patch makes the t/db_dependent/Search.t tests use a real DB instead of
mocking the DB handler (which is not actually used and generates unnecesary
warnings when running the tests).

It does so by grabbing the DB configuration data using C4::Context->config()
and passing it (writing %ENV) to rewrite-config.PL, all is done in zebra_config.pl
which is only used on the Search.t file.

To test:
- Run
  $ prove t/db_dependent/Search.t
=> FAIL: Warnings are raised about DB being mocked and DBIC not recognising 'Mock'
         as a valid DB driver.
- Apply the patch
- Run
  $ prove r/db_dependent/Search.t
=> SUCCESS: Same tests results, no warning about DBIC driver.
- Sign off :-D

Disclamer: As of writing this patch, the Search.t tests pass. The patch is not dealing
with tests results, but how they use the DB.

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Test pass before & after, a 'little' less noisy
No errors

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14931: (qa followu-up) small improvements
Jonathan Druart [Wed, 28 Oct 2015 08:41:19 +0000 (08:41 +0000)]
Bug 14931: (qa followu-up) small improvements

- Avoid 1 call to dt_from_string in some cases
- Do not use $_

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14931: (Follow-up) Validate date entry in contracts
Marc Véron [Thu, 15 Oct 2015 11:01:50 +0000 (13:01 +0200)]
Bug 14931: (Follow-up) Validate date entry in contracts

 Go to Home > Acquisitions, search for an active vendor and view the vendor
- Click on 'Contracts' at the left
  (admin/aqcontract.pl)
- Create and edit contracts and verify that it works OK.
  (Note: there is no help for this page, see Bug 14929)

Amended for comment #7  25.10.2015 / mv

Signed-off-by: Jesse Weaver <pianohacker@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14931: Remove C4::Dates from files admin/aq*.pl
Marc Véron [Wed, 30 Sep 2015 16:50:42 +0000 (18:50 +0200)]
Bug 14931: Remove C4::Dates from files admin/aq*.pl

This patch removes C4::Dates from:

- admin/aqbudgets.pl
- admin/aqplan.pl
- admin/aqcontract.pl

To test:

- Apply patch

- Go to Home > Adminstration > Budgets > All funds
  (admin/aqbudgets.pl)
- Verify that everything displays as before

- Edit one of the funds and click on 'Planning - Plan by months'
  (admin/aqplan.pl)
- Verify that planning works as before

- Go to Home > Acquisitions, search for an active vendor and view the vendor
- Click on 'Contracts' at the left
  (admin/aqcontract.pl)
- Create and edit contracts and verify that it works OK.
  (Note: there is no help for this page, see Bug 14929)

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised. Tested with dateformat syspref
Dates in planning by months not needed to be on iso format, aqplan.pl
uses instead Date::Calc

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14977: Followup to fix issue with NewsChannels.t
Marc Véron [Tue, 27 Oct 2015 19:06:11 +0000 (20:06 +0100)]
Bug 14977: Followup to fix issue with NewsChannels.t

The problem was that get_opac_new returns dates already syspref-formatted.

To test:
- Apply patch
- Verify that t/db_dependent/NewsChannels.t does not fail.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14977: Remove C4::Dates from files t/db_dependent/*.t
Marc Véron [Wed, 7 Oct 2015 22:13:01 +0000 (00:13 +0200)]
Bug 14977: Remove C4::Dates from files t/db_dependent/*.t

This patch removes C4::Dates from following files:

-  t/db_dependent/Budgets.t
-  t/db_dependent/Holds.t
-  t/db_dependent/Koha_template_plugin_KohaDates.t
-  t/db_dependent/Log.t
-  t/db_dependent/NewsChannels.t

To test:
- First run all tests above
- Apply patch
- Then run tests again. The results should be the same.
  (Note: I get 2 fails with NewsChannels.t, they are the same with
   and without patch).

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
NewsChanell pass for me before patch, no after.
Followup follows :)
Rest of tests pass

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14903: (followup)Remove C4::Dates from circ/circulation.pl
Marc Véron [Tue, 27 Oct 2015 16:50:21 +0000 (17:50 +0100)]
Bug 14903: (followup)Remove C4::Dates from circ/circulation.pl

Follow up to fix QA issues from comment #15
...and amended for comment #18

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14903: Remove C4::Dates from circ/circulation.pl (and more)
Marc Véron [Fri, 9 Oct 2015 16:48:30 +0000 (18:48 +0200)]
Bug 14903: Remove C4::Dates from circ/circulation.pl (and more)

Patch to remove deprectated C4::Dates from:
- circ/circulation.pl
- C4/Circulation.pm
- koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt

To test:
- Apply patch
- Go to the checkout site (Home > Circulation > Checkouts)
- Verify that data displays properly (including for users with a card
  that expires in the  near future, see syspref 'NotifyBorrowerDeparture')
- Search for regressions
- prove -v t/db_dependent/Circulation.t

(Amended following comment #9 / #11  25.10.2015 /mv)

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14100: (QA followup) add missing mocked sysprefs
Tomas Cohen Arazi [Thu, 29 Oct 2015 13:52:08 +0000 (10:52 -0300)]
Bug 14100: (QA followup) add missing mocked sysprefs

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14100: Fix Search.t tests
Jonathan Druart [Wed, 28 Oct 2015 10:43:55 +0000 (10:43 +0000)]
Bug 14100: Fix Search.t tests

So, this one is VERY weird, let me try to explain what I have
understood.

Bisecting using run prove t/db_dependent/Search.t, I have found that the
following commit make the test fail:
  commit 0f63f89f66e40cc01ef02da3654fcfb404c9001d
    Bug 14100: Generic solution for language overlay - Item types
The error is
  DBI bind_columns: invalid number of arguments: got handle + 0, expected handle + between 1 and -1
  Usage: $h->bind_columns(\$var1 [, \$var2, ...]) at /usr/lib/i386-linux-gnu/perl5/5.20/DBI.pm line 2065.

Note that the interface (admin/itemtypes.pl) which calls the same
subroutine with the same parameter (style => 'array') works great.

The problem comes from the change in C4::Search::searchResults, if I
only apply the change done to this subroutine on 0f63f89f^1, I reproduce
the issue.

Looking closely at how %itemtypes is built, we could actually call
GetItemTypes with the style => 'hash' to get exactly what we want.
The following piece prove it for you:
    use Test::More;
    use C4::Koha;
    my $i = GetItemTypes;
    my $j = GetItemTypes(style => 'array');
    my %itemtypes;
    for my $itemtype ( @$j ) {
        $itemtypes{ $itemtype->{itemtype} } = $itemtype;
    }
    is_deeply( \%itemtypes, $i);

So changing the code accordingly and just forget this last hour...

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14100: Fix t/db_dependent/Items.t
Jonathan Druart [Wed, 28 Oct 2015 09:11:54 +0000 (09:11 +0000)]
Bug 14100: Fix t/db_dependent/Items.t

prove t/db_dependent/Items.t
Undefined subroutine &C4::Languages::getlanguage called at C4/Items.pm line 1304.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14100: Fix test xt/author/valid_templates complaining on opac-topissues.tt
Jonathan Druart [Wed, 28 Oct 2015 08:58:15 +0000 (08:58 +0000)]
Bug 14100: Fix test xt/author/valid_templates complaining on opac-topissues.tt

undef error - Undefined subroutine &C4::Languages::getlanguage called at C4/Koha.pm line 250.

Test plan:
    prove xt/author/valid-templates.t

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14722: CSV is only available for biblio records
Jonathan Druart [Mon, 19 Oct 2015 08:28:16 +0000 (09:28 +0100)]
Bug 14722: CSV is only available for biblio records

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 14722: Add POD for some options
Jonathan Druart [Mon, 19 Oct 2015 08:20:41 +0000 (09:20 +0100)]
Bug 14722: Add POD for some options

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 14722: rename the script
Jonathan Druart [Mon, 19 Oct 2015 08:11:48 +0000 (09:11 +0100)]
Bug 14722: rename the script

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 14722: Refactor the export tool
Jonathan Druart [Fri, 21 Aug 2015 16:26:44 +0000 (17:26 +0100)]
Bug 14722: Refactor the export tool

Why a refactoring was need for this script?
The export tool (tools/export.pl) can be called from the command line
and some parts of code were unnecessarity complicated (just look at the
code, you will understand).

Worse still, the script does not provide the same options for both
interface. For instance you cannot export records given a range of
biblionumbers, authids, callnumbers, etc. from the commandline.

What does this patch?
1/ Important: The script tools/export.pl does not work anymore if called from
the command line (should be in the release notes).
2/ The code used to generated a file (csv, iso2709 or xml) has been moved to a new
module (Koha::Exporter::Record) and tests have been provided.
3/ No change is done on the web interface
4/ Some new options have been added to the commandline script
(misc/export.pl):
    - starting_authid
    - ending_authid
    - authtype
    - starting_biblionumber
    - ending_biblionumber
    - itemtype
    - starting_callnumber
    - ending_callnumber
    - start_accession
    - end_accession
5/ There is a change in the behavior if an error occurs:
Can't call method "as_usmarc" on an undefined value at Koha/Exporter/Record.pm line 114.
record (number 5530) is invalid and therefore not exported because its reopening generates warnings above at Koha/Exporter/Record.pm line 117.

Before this patch, they were not displayed (using the command line).

What does not do this patch?
It does not provide the 'clean', 'timestamp' and 'deleted_barcodes' options to
the web interface (same as before).

What about the perfs?
With a DB with ~800 biblios (MARC21)
Before: perl tools/export.pl 14.79s user 0.83s system 71% cpu 21.905 total
After:  perl misc/export.pl  17.19s user 0.84s system 75% cpu 24.018 total

With a DB with ~6400 biblios (UNIMARC)
Before: perl tools/export.pl 26.55s user 0.76s system 76% cpu 35.498 total
After:  perl misc/export.pl  26.78s user 0.84s system 80% cpu 34.494 total

How to test this patch?
Test plan:
A. Web interface:
1/ On the current master, export some records, biblios and authorities (with
the 3 differents exports) playing with the different filters (item type,
libraries, callnumber, accession date, don't export items, remove
non-local items, don't export fields, etc.).
2/ Apply this patch, export again the same records, and compare the
generated files. They must be identical!
3/ Confirm that the export features on the checkout list
(circ/circulation.pl) works as before this patch.

B. The command line
1/ On the current master, export some records, biblios and authorities (with
the 2 differents exports) playing with the different options (date,
deleted_barcodes, clean).
2/ Apply this patch, export again the same records, and compare the
generated files. They must be identical!

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14722: Add Koha::Biblioitem[s]
Jonathan Druart [Mon, 24 Aug 2015 08:18:07 +0000 (09:18 +0100)]
Bug 14722: Add Koha::Biblioitem[s]

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14190: Scale search boxes in staff head
Eivin Giske Skaaren [Sun, 18 Oct 2015 14:21:01 +0000 (14:21 +0000)]
Bug 14190: Scale search boxes in staff head

In this simple patch the width gets controlled by CSS and it becomes
easy to set it in just one place.

The exact width may need to be discussed but I thought 30em made it look ok on my screen.
With this patch we get the wider search boxes with a very small change and another bug may
be created if needed to do a bigger refactor and remove stuff not needed in the html and
perhaps do this in a modern/responsive way. (Preferrably a UX/GUI developer will do this)

To test:

Apply the patch and reload the staff client. Now the search box is a bit wider and the border
etc has changed with it.

Some places with more than one search box like "Serials" will not be affected.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 12428: QA Follow-up: Wrap borrower's title in a span to make it possible to hide
Katrin Fischer [Sat, 24 Oct 2015 11:09:41 +0000 (13:09 +0200)]
Bug 12428: QA Follow-up: Wrap borrower's title in a span to make it possible to hide

I think showing the title with the user name is quite unusual for
Koha. Wrapping the title in a span with a unique class makes it
possible to hide it.

http://bugs.koha-community.org/show_bug.cgi?id=14248

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14248: Regression tests
Mark Tompsett [Thu, 22 Oct 2015 12:52:33 +0000 (08:52 -0400)]
Bug 14248: Regression tests

TEST PLAN
---------
1) apply patch
2) prove -v t/db_dependent/NewsChannels.t
3) run koha qa test tools.

Signed-off-by: Martin Persson <xarragon@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14248: Optionally display authorship for news
Martin Persson [Fri, 2 Oct 2015 06:06:06 +0000 (08:06 +0200)]
Bug 14248: Optionally display authorship for news

Test plan:

* Apply dependant patches 14246 and 14247.
* Apply current patch.
* Log into the Staff client, go to
 'Administration' -> 'Global Preferences' -> 'Tools',
  a new section titled 'News' should appear with a single option named 'NewsAuthorDisplay'.
  Available values should be 'Not at all', 'OPAC only', 'Staff client only' and
  Both OPAC and staff client'. By default the value should be 'Not at all'
  (to mimic existing behaviour, important!).

* Change the value to something different and save the changes.
* Go to 'Tools' -> 'News' and add some news items (at least 2).
* Use the MySQL command line tool to edit the opac_news table,
  removing the user id from one of the news items:
  $ mysql -u kohaadmin -p -D koha
  > SELECT `idnew`, `title`, `borrowernumber` FROM `opac_news`;
  * Make a mental note of one of the 'newid' numbers to change.
  > UPDATE `opac_news` SET `borrowernumber` = NULL WHERE `idnew` = <your-id-here>;
  * Now one of the news items will have no user id, and no author should be shown for it.
* Go to OPAC and Staff client and make sure the display modes works as intended.
  * Repeat for all values, making sure that the settings works as intended.
  * The changed news item should have no author info shown at any time.
  * The unchanged news item should show your own user name if the
    settings match the section where it is displayed.

Sponsored-By: Halland County Library
Tested on top of Bugs 1246 and 1247, works as advertised.
Note: Some whitespaces changed / removed in koha-news.tt to pass qa tools.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14247: DBRev 3.21.00.046
Tomas Cohen Arazi [Tue, 27 Oct 2015 19:12:51 +0000 (16:12 -0300)]
Bug 14247: DBRev 3.21.00.046

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14247: Rename sysprefs atomic update file
Martin Persson [Tue, 26 May 2015 13:58:45 +0000 (15:58 +0200)]
Bug 14247: Rename sysprefs atomic update file

This trivial patch changes the name of the SQL update
file to match the guidelines on the wiki.

Sponsored-by: Halland County Library
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14247: Add system preference for news display
Martin Persson [Mon, 25 May 2015 12:33:13 +0000 (14:33 +0200)]
Bug 14247: Add system preference for news display

Test plan:

* Apply dependant patch 14246 (if not done already).
* Apply current patch.
* Log into the Staff client, go to 'Administration' -> 'Global Preferences' -> 'Tools', a new section titled 'News' should appear with a single option named 'NewsAuthorDisplay'. Available values should be 'Not at all', 'OPAC only', 'Staff client only' and 'Both OPAC and staff client'. By default the value should be 'Not at all' (to mimic existing behaviour, important!).
* Change the value to something different and save the changes.
* Use the mysql command line client to connect to the Koha database:
  $ mysql -u kohaadmin -p -D koha
* Enter the following query:
  SELECT * FROM systempreferences WHERE variable = 'NewsAuthorDisplay';
* Check to make sure that the 'value' column has changed to reflect the choice you made in the above step.

Separate SQL testing (clean installation of Koha):
* Koha$ mysql -u root < create_koha_test_db.sql
* Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/kohastructure.sql
* Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/sysprefs.sql

Testing the update script works the same way:
* Koha$ echo "DELETE FROM systempreferences WHERE variable = 'NewsAuthorDisplay';" | mysql -u koha_test -D koha_test
* Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/atomicupdate/add_news_prefs.sql

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14246: DBRev 3.21.00.045
Tomas Cohen Arazi [Tue, 27 Oct 2015 19:02:33 +0000 (16:02 -0300)]
Bug 14246: DBRev 3.21.00.045

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14246: Adding Koha::Schema::Result differences
Mark Tompsett [Wed, 21 Oct 2015 23:55:08 +0000 (19:55 -0400)]
Bug 14246: Adding Koha::Schema::Result differences

Ran misc/devel/update_dbix_class_files.pl as shown on
wiki/Database_updates#updatedatabase.pl
However, only git added Borrower and Opacnews, since
those were the two affected by this patch.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14246: (fix) correct ALTER TABLE mysql syntax
Indranil Das Gupta [Sun, 14 Jun 2015 12:09:52 +0000 (17:39 +0530)]
Bug 14246: (fix) correct ALTER TABLE mysql syntax

Address bug 14246 comment 13 remark - correcting MySQL ALTER TABLE
syntax.

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14246: Update NewsChannel tests
Martin Persson [Mon, 1 Jun 2015 11:56:56 +0000 (13:56 +0200)]
Bug 14246: Update NewsChannel tests

This commit adds the new 'borrowernumber' field to the existing
test framework to make it pass. It does not include new tests.

Sponsored-by: Halland County Library
Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14246: Add borrowernumber, altered SQL
Martin Persson [Wed, 27 May 2015 05:36:33 +0000 (07:36 +0200)]
Bug 14246: Add borrowernumber, altered SQL

As suggested by kind reviewers, an AFTER statement was added to the atomic
upgrade script to ensure that the final field order is consistent is both
fresh and upgraded databases.

Also:
* UPDATE action changed to CASCADE to improve robustness.

Test plan:
* Apply first patch in this set.
* Apply this patch.
* Perform a database upgrade.
* Use mysql client to inspect field order.
  It should be identical to the kohastructure.sql order.

Sponsored-by: Halland County Library
Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14246: Add borrowernumber to koha_news
Martin Persson [Tue, 26 May 2015 11:23:34 +0000 (13:23 +0200)]
Bug 14246: Add borrowernumber to koha_news

This patch adds a new column to koha_news that links a
borrowernumber to each item. This allows Koha to display the
author for each entry which makes it suitable as a simple CMS.

Changes (from rejected patch):
* Added missing kohastructure.sql changes.
* Turned the atomic update file into a SQL file and changed name
  in accordance with wiki guidelines.
* Changed SQL syntax and naming to be consistent with existing code.
* Attached test plan to commit message.

Test plan:

* You need at least one news item, log in and add one from
  'Administration' -> 'Tools' -> 'News'.
* Apply the patch.
* Apply database upgrade (directly or indirectly).
* Go back to Staff interface and post a new news item.
* Use the mysql command line client to connect to the Koha installation's database:
  mysql -u kohaadmin -p -D koha (change username and database to values
  appropiate for your system).
* Execute the following query: SELECT title, borrowernumber FROM opac_news;
* Inspect the results, the 'borrowernumber' column should be NULL for all news items
  created before the patch was applied, and non-NULL for the new item created AFTER
  the patch was applied.

Optional: Remove database changes via:
  ALTER TABLE opac_news DROP FOREIGN KEY borrowernumber_fk;
  ALTER TABLE opac_news DROP COLUMN borrowernumber;

Sponsored-By: Halland County Library
Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 10933: (followup of the followup) fix the previous patch to work with master
Jonathan Druart [Tue, 27 Oct 2015 16:05:36 +0000 (16:05 +0000)]
Bug 10933: (followup of the followup) fix the previous patch to work with master

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14100: (RM followup) DBIx update
Tomas Cohen Arazi [Tue, 27 Oct 2015 15:52:22 +0000 (12:52 -0300)]
Bug 14100: (RM followup) DBIx update

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14100: (QA followup) fix wrong comment in kohastructure.sql
Tomas Cohen Arazi [Tue, 27 Oct 2015 15:50:32 +0000 (12:50 -0300)]
Bug 14100: (QA followup) fix wrong comment in kohastructure.sql

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14100: DBRev 3.21.00.044
Tomas Cohen Arazi [Tue, 27 Oct 2015 15:45:36 +0000 (12:45 -0300)]
Bug 14100: DBRev 3.21.00.044

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14100: Fix 3 occurrences more
Jonathan Druart [Mon, 19 Oct 2015 08:05:43 +0000 (09:05 +0100)]
Bug 14100: Fix 3 occurrences more

- opac-suggestions.pl
- opac-readingrecord.pl
- opac-reserve.pl

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14100: Fix some missing occurrences
Jonathan Druart [Wed, 14 Oct 2015 08:38:05 +0000 (09:38 +0100)]
Bug 14100: Fix some missing occurrences

This patch fixes:
- reports/bor_issues_top.pl
- sort order
- adv search and search results
- opac-topissues.pl

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14100: Move add form to the top
Jonathan Druart [Tue, 13 Oct 2015 08:52:54 +0000 (09:52 +0100)]
Bug 14100: Move add form to the top

Not sure this is the best: now the messages will make the table moves.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14100: Better errors handling
Jonathan Druart [Tue, 13 Oct 2015 08:49:55 +0000 (09:49 +0100)]
Bug 14100: Better errors handling

This patch mainly improves the errors handling.
It's now not possible to add several translations for the same entity-code-lang
combination.

It also:
- wording: Translate for other languages => into
- fixes encoding issues on add/update (was just display)
- add entity and code to the title of the pop-up window

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14100: (follow-up) Language overlay for item types
Jonathan Druart [Wed, 19 Aug 2015 09:22:24 +0000 (10:22 +0100)]
Bug 14100: (follow-up) Language overlay for item types

Display the translated description for item types in the following pages:
> admin/smart-rules.pl
> catalogue/detail.pl
> catalogue/itemsearch.pl
> catalogue/moredetail.pl
> reports/acquisitions_stats.pl
> reports/bor_issues_top.pl
> reports/cat_issues_top.pl
> reports/catalogue_out.pl
> reports/catalogue_stats.pl
> reports/issues_avg_stats.pl
> reports/issues_stats.pl
> reports/itemslost.pl
> reports/manager.pl
> reports/reserves_stats.pl
> suggestion/suggestion.pl
> tools/export.pl

> Opac:
> opac-detail.pl
> opac-MARCdetail.pl
> opac-search.pl

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14100: Generic solution for language overlay - Item types
Jonathan Druart [Thu, 30 Apr 2015 15:30:47 +0000 (17:30 +0200)]
Bug 14100: Generic solution for language overlay - Item types

Test plan:
1/ update the Schema (misc/devel/update_dbix_class_files.pl)
2/ Translate templates for some languages (es-DE, de-DE for instance)
3/ Enable them in the pref (search for 'lang') for the staff interface
4/ Go on the item type admin page (admin/itemtypes.pl)
5/ Edit one
6/ Click on the 'translate for other languages' link
7/ You are now on the interface to translate the item type's description
in the languages you want. So translate some :)
8/ Go back on the item type list view (admin/itemtypes.pl)
9/ You should see the original description (non translated)
10/ Switch the language
11/ You should see the translated description in the correct language.
If the description is non translated, the original description is
displayed.

12/ On the different page where the item type is displayed, confirm that
the translated description appears.

Think further / Todo:
1/ Update all occurrences of the item type's description (DONE)
2/ Implement for authorised values
3/ Implement for syspref value (at least textarea)
4/ Implement for branch names
5/ Centralize all the translation on a single page in the admin area
...
N/ Implement a webservice to centralize all the translations and give
the ability to sync the item types/authorised values description with
the rest of the world (push and pull).

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 11559: DBRev 3.21.00.043
Tomas Cohen Arazi [Tue, 27 Oct 2015 15:30:32 +0000 (12:30 -0300)]
Bug 11559: DBRev 3.21.00.043

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 11559: (QA followup) fix several small issues
Jesse Weaver [Mon, 26 Oct 2015 21:11:07 +0000 (15:11 -0600)]
Bug 11559: (QA followup) fix several small issues

This fixes the following:
  * Remove unneeded year on use Modern::Perl
  * Fix occasional freeze when reloading existing record
  * Fix encoding for returned record on first save to catalog

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 11559: (QA followup) replace font choices, fix macro editor
Jesse Weaver [Mon, 26 Oct 2015 20:29:54 +0000 (14:29 -0600)]
Bug 11559: (QA followup) replace font choices, fix macro editor

More specifically:
  * Use monospace font options that are more widely installed
  * Don't allow entering macros until the user loads/creates a macro

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 11559: (QA followup) fix QA issues
Jesse Weaver [Mon, 26 Oct 2015 01:34:53 +0000 (19:34 -0600)]
Bug 11559: (QA followup) fix QA issues

This fixes the following:
  * License of editor.pl
  * Remove tabs
  * Use [% interface %]
  * Re-order search fields like the old interface
  * Add license information for new libraries

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 11559: (QA followup) detect and warn about corruption caused by MARC-8
Jesse Weaver [Fri, 23 Oct 2015 17:06:39 +0000 (11:06 -0600)]
Bug 11559: (QA followup) detect and warn about corruption caused by MARC-8

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 11559: (QA followup) fix pagination bar, add Ctrl-D to macro editor
Jesse Weaver [Thu, 22 Oct 2015 22:53:11 +0000 (16:53 -0600)]
Bug 11559: (QA followup) fix pagination bar, add Ctrl-D to macro editor

Also, fix incredibly silly mistake with keyboard shortcuts popup.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 11559: (followup) fix first-character deletion, small usability issues
Jesse Weaver [Mon, 19 Oct 2015 23:47:13 +0000 (17:47 -0600)]
Bug 11559: (followup) fix first-character deletion, small usability issues

This should fix the first-character deletion bug reported by Nick, and also:

  * Fix subfield deletion
  * Attempted fix for special keys on dropdowns
  * Allow deleting empty fields
  * Fix bug with composed characters

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 11559: (QA followup) switch to new delimiter, fix minor issues
Jesse Weaver [Tue, 6 Oct 2015 22:00:49 +0000 (16:00 -0600)]
Bug 11559: (QA followup) switch to new delimiter, fix minor issues

This followup introduces a major change; instead of subfields starting
with '$<code><space>', they now start with '‡<code>'. The double-cross
character can be typed with Ctrl-D.

It also fixes the following:
  * Add UUID.pm dependency
  * Remove debugging call
  * Fix toLocaleFormat error reported by Nick Clemens
  * Ignore subfields that are marked as unrepeatable/mandatory AND
    ignored (tab is -1)
  * Mention lack of support for UNIMARC/NORMARC fixed fields in system
    preferences screen
  * Confirm when user creates new record and current record is modified
  * Perform better when importing gigantic record dump
  * Show "Edit" instead of "Import" and allow direct editing for local
    catalog records in search screen
  * Add "Keyboard shortcuts" help button to toolbar

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 11559: (followup) Prevent saving item tags, fix other issues
Jesse Weaver [Thu, 3 Sep 2015 21:47:35 +0000 (15:47 -0600)]
Bug 11559: (followup) Prevent saving item tags, fix other issues

This fixes the following issues:
  * Spaces are now allowed in indicators
  * Shift-Enter is available to insert a newline if needed
  * Item tags, if present, will prevent saving (as they are not correctly
    processed by the backend)
  * biblionumber tags (999 in MARC21) will be stripped before the record
    is saved to Koha, to prevent their modification

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 11559: (followup) Fix error when all servers are deselected
Jesse Weaver [Thu, 6 Aug 2015 21:56:36 +0000 (15:56 -0600)]
Bug 11559: (followup) Fix error when all servers are deselected

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 11559: (followup) Fix import bugs, display/parsing issues
Jesse Weaver [Thu, 6 Aug 2015 21:56:36 +0000 (15:56 -0600)]
Bug 11559: (followup) Fix import bugs, display/parsing issues

This fixes the following issues:
  * ISO2709 import fails for Unicode
  * Import only works with .mrc/.xml extensions
  * MARC21 widgets not translatable
  * Macro UI broken
  * Uppercase subfield codes forbidden
  * Tag with no valid subfields shows as error but tries to save

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 11559: (followup) Fill in default values, fix redirect and UNIMARC
Jesse Weaver [Tue, 23 Jun 2015 22:24:17 +0000 (16:24 -0600)]
Bug 11559: (followup) Fill in default values, fix redirect and UNIMARC

This fixes the following issues:
    * Help for UNIMARC tags broken
    * MARC21 resources loaded when in UNIMARC
    * Clicking on "advanced editor" in basic editor fails
    * Shift-Tab goes to the beginning of a fixed-field widget rather
      than the end

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 11559: (followup) Fix keyboard control bugs, make labels clickable
Jesse Weaver [Tue, 23 Jun 2015 22:24:17 +0000 (16:24 -0600)]
Bug 11559: (followup) Fix keyboard control bugs, make labels clickable

This fixes the following issues:
    * Labels of search server checkboxes cannot be clicked
    * Quick search fields cannot be focused
    * Search results cannot be scrolled with a keyboard

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
6 years agoBug 11559: Rancor: advanced cataloging interface
Jesse Weaver [Mon, 15 Jun 2015 21:09:27 +0000 (17:09 -0400)]
Bug 11559: Rancor: advanced cataloging interface

Full test plan is posted on bug. Test plan for system preference:

  1. Apply patch, clear cookies.
  2. Go to "Cataloging."
  3. Add new record, verify that basic editor is used.
  4. Navigate to existing record, click on "Edit record", verify that
     basic editor is used.
  5. Inside basic editor, verify that no button appears to switch to the
     advanced editor.
  6. Enable the "EnableAdvancedCatalogingEditor" syspref.
  7. Repeat above steps, should still go to basic editor, but button
     should appear to switch to the advanced editor; click it.
  8. Now, adding new records and editing existing records should go to
     the advanced editor.

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 11559: New libraries for Rancor
Jesse Weaver [Mon, 15 Jun 2015 21:06:19 +0000 (17:06 -0400)]
Bug 11559: New libraries for Rancor

Adds the following JS libraries:

  * CodeMirror - extensible text editor
  * FileSaver - shim for saving files
  * require - dependency resolver and module loader

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 11559: Supporting changes for Rancor
Jesse Weaver [Mon, 15 Jun 2015 20:57:46 +0000 (16:57 -0400)]
Bug 11559: Supporting changes for Rancor

  * Extends login screen to pass along #hash
  * Adds JSONP support to C4::Service
  * Extends humanmsg to allow per-message classes
  * Adds proper charset to results of svc/bib

Test plan:

  1. C4/Auth.pm and .../intranet/.../auth.tt: verify that login/usage
     works as expected, despite the change to pass on the fragment (...#blah)
     from the URL.
  2. C4/Service.pm and humanmsg.js: verify that editing system
     preferences (the main user of these modules) works correctly despite
     updates.
  3. svc/bib: verify that records can be correctly downloaded with the
     change of character set. This can be done in a Firebug/Chrome Devtools
     console by running `$.get('/cgi-bin/koha/svc/bib/1')` and inspecting the
     results (possibly replacing 1 with a different valid biblionumber).

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 10120: (QA followup) avoid raising warnings on upgrade
Tomas Cohen Arazi [Tue, 27 Oct 2015 15:07:27 +0000 (12:07 -0300)]
Bug 10120: (QA followup) avoid raising warnings on upgrade

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14734: Enhance 264 display in OPAC and Staff XSLT.
Winona Salesky [Wed, 16 Sep 2015 16:37:54 +0000 (12:37 -0400)]
Bug 14734: Enhance 264 display in OPAC and Staff XSLT.

Makes 264 repeatable, prefer 264 over 260. If 264/ind1=3 is present in the
record the xslt uses ind1 to determine latest 264, if no ind1=3 then all
264 fields are displayed.

Test Plan:
1) Apply this patch
2) Ensure you are using the default XSLT setting for the staff and opac record details
3) Find or create a record with multiple MARC tags 264
4) Perform a search that would show the record in the search results.
5) Review results for correct 264 display.
6) Click title to review record details.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised. 260 not showed when 264 exists, tested with multiple
records. If ind1=3 is present shows the current/latest data

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 15069: DBRev 3.21.00.042
Tomas Cohen Arazi [Tue, 27 Oct 2015 14:44:43 +0000 (11:44 -0300)]
Bug 15069: DBRev 3.21.00.042

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 15069: Update items_search_fields.authorised_values_category to varchar(32)
Jonathan Druart [Tue, 27 Oct 2015 14:29:29 +0000 (14:29 +0000)]
Bug 15069: Update items_search_fields.authorised_values_category to varchar(32)

This is a follow-up for bug 13379.
items_search_fields.authorised_values_category is now a varchar(32) but
the updatedatabase.pl did not modify it (changed only on
kohastructure.sql)

Test plan:
  SHOW CREATE TABLE items_search_fields
before and after this patch.
items_search_fields.authorised_values_category should be a varchar(32)

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 10933: (follow-up) fix the previous patch to work with master
Joonas Kylmälä [Mon, 31 Aug 2015 11:41:44 +0000 (11:41 +0000)]
Bug 10933: (follow-up) fix the previous patch to work with master

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 10933: The PurgeSearchHistory should be merge into the C4::Search::History module
Jonathan Druart [Mon, 23 Sep 2013 11:34:19 +0000 (13:34 +0200)]
Bug 10933: The PurgeSearchHistory should be merge into the C4::Search::History module

Since bug 10803 adds a C4::Search::History module, the
PurgeSearchHistory routine should be moved.

Test plan:
- run misc/cronjobs/cleanup_database.pl with the searchhistory param and
verify behavior is the same as before applying this patch.
- run prove t/Search/History.t

Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14996: Remove C4::Dates from tags/review.pl
Marc Véron [Fri, 9 Oct 2015 21:11:22 +0000 (23:11 +0200)]
Bug 14996: Remove C4::Dates from tags/review.pl

This patch removes C4::Dates from file tags/review.pl

To test:
- Create some tags
- Go to Home > Tools > Tags
- Verify that dates display properly
- Verify that the date filter works as before

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14468: (QA followup) remove useless diags
Tomas Cohen Arazi [Tue, 27 Oct 2015 13:35:02 +0000 (10:35 -0300)]
Bug 14468: (QA followup) remove useless diags

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14468: followup to fix tests
Bernardo Gonzalez Kriegel [Fri, 23 Oct 2015 16:40:45 +0000 (13:40 -0300)]
Bug 14468: followup to fix tests

This patch fix an expected  test result.
Also changes a comparison for the return value to 'delete'
layout sub, in case of success it returns 'undef' and triggers
the message 'use of uninitialized value $del_results ...'

To test:
1) Whitout this patch

prove t/db_dependent/Labels/t_Layout.t

fails.

Also note the message
"Use of uninitialized value $del_results in string ne at t/db_dependent/Labels/t_Layout.t line 110."
for using the return value of delete layout (undef on success!)

2) Apply the patch
3) Test pass and no more message

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14468: Remove warnings when creating Labels
Bernardo Gonzalez Kriegel [Sun, 28 Jun 2015 00:41:01 +0000 (21:41 -0300)]
Bug 14468: Remove warnings when creating Labels

This patch removes 2 types of warnings when
creating Labels

a) Using '0' as filling char is not to the like of prStrWidth
On C4/Creators/Layout.pm

b) A RM followup from Galen on Bug 8375 to C4/Creators/PDF.pm
makes impossible to find properly a font :(
(http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=f7ef93e758850e991091e7268b8d1b1453082df4)
on C4/Labels/Label.pm

To test:
Pre patch
1) Go to Tools > Labels
2) Create a new layout, name ABC, type 'Barcode/Biblio'
3) Create a new batch, add 2 items
4) Export as PDF using the new layout
5) Look at logs, you will find something like

a) label-create-pdf.pl: Use of uninitialized value $strwidth in numeric lt (<) at /home/bgkriegel/kohaclone/C4/Creators/Layout.pm line 233., referer: http://staffdev.koha-community.org.ar/cgi-bin/koha/labels/label-print.pl
(Only one of this kind)

b) Two related lines similar to this examples
label-create-pdf.pl: Use of uninitialized value in -e at /home/bgkriegel/kohaclone/C4/Creators/PDF.pm line 226., referer: http://staffdev.koha-community.org.ar/cgi-bin/koha/labels/label-print.pl
label-create-pdf.pl: ERROR in koha-conf.xml -- missing <font type="Ft1">/path/to/font.ttf</font> at /home/bgkriegel/kohaclone/C4/Creators/PDF.pm line 229., referer: http://staffdev.koha-community.org.ar/cgi-bin/koha/labels/label-print.pl
(many many lines x number of items on batch)

6) Apply the patch
7) Export the same PDF, no more warnings

8) Bonus 1: change main font to Courier and Helvetica
and check results
9) Bonus 2: check using arabic records

Many hours to find :(
Easy to fix

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14995: Remove C4::Dates: Delete files reservereport.pl / reservereport.tt
Marc Véron [Fri, 9 Oct 2015 19:33:03 +0000 (21:33 +0200)]
Bug 14995: Remove C4::Dates: Delete files reservereport.pl / reservereport.tt

The following files use C4::Dates, but they seem no longer to be in use:

- koha-tmpl/intranet-tmpl/prog/en/modules/reports/reservereport.tt
- reports/reservereport.pl

To verify: git grep 'reservereport'

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14949: Remove remaining C4::Dates and fix display in admin/categorie.pl
Marc Véron [Wed, 14 Oct 2015 19:51:17 +0000 (21:51 +0200)]
Bug 14949: Remove remaining C4::Dates and fix display in admin/categorie.pl

This patch removes a remaining C4::Dates from admin/categroie.pl and fixes
the display of "Enrollment period" on the confirmation screen for deleting.

To verify and test pls. refer to comments #5 and #6

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14949: (followup) Fix regression with hard due date
Marc Véron [Tue, 6 Oct 2015 13:06:25 +0000 (15:06 +0200)]
Bug 14949: (followup) Fix regression with hard due date

This patch fixes the regresseion as described in comment #3

To test:

- Go on smart-rules.pl and edit a line. Do not define a Hard due date, save.
  The value is "None defined".

- Edit the line, do not change anything and save.
  The value should be "None defined"

- Edit the line, define a hard due date, save.
  The date should display as expected.

- Edit the line agein, remove the hard due date, save.
  The value should be "None defined"

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14949: Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl
Marc Véron [Sun, 4 Oct 2015 16:25:46 +0000 (18:25 +0200)]
Bug 14949: Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl

Bug to remove C4::Dates from
 - admin/smart-rules.pl
 - admin/categorie.pl

To test:

- Apply patch

- Go to Home > Administration > Circulation and fine rules (smart-rules.pl)
- Edit or add a rule
- Verify that 'Hard due date' displays and saves fine

- Go to Home > Administration > Patron categories
- Edit or add a category
- Verify that 'Until date' displays and saves fine

Note: The date picker does not warn about wrong date formats as e.g. while
      editing patrons, but that is not in the scope of this bug

Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14997: Remove C4::Dates from tools (import / export)
Marc Véron [Sat, 10 Oct 2015 08:03:51 +0000 (10:03 +0200)]
Bug 14997: Remove C4::Dates from tools (import / export)

This patch removes C4::Dates from:

- tools/export.pl
- tools/import_borrowers.pl

Note: For testing, both need preparation without patch, see below.

To test export:
- Without patch applied, go to
  Home > Tools > Export data > Export bibliographic records
- Define Start date / End date for Accession dates
- Export bibliographic records as 'without-patch.mrc'

- Do the same with patch, export as 'with-patch.mrc
- Compare the files, they should be the same

To test Import patrons:
- Without patch
- Go to Home > Tools > Import patrons
- Create a patron category like 'TEST' (useful for filtering...)
- Prepare a file with some patrons with category TEST to import.
  Fill date of birth, enrolment date, expiry date with values
  formatted in syspref format, in iso format and garbage
- Import
- Review the imported patrons (search for category TEST)

- With patch: Change cardnumber and names in import file
- Import
- Review again and compare with results from previous import.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14915: (QA followup) Switch recent commits from Glyphicons to Font Awesome
Kyle M Hall [Mon, 26 Oct 2015 17:15:37 +0000 (13:15 -0400)]
Bug 14915: (QA followup) Switch recent commits from Glyphicons to Font Awesome

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14915: (QA followup) Replace fa-time with fa-clock-o
Katrin Fischer [Sun, 25 Oct 2015 22:12:28 +0000 (23:12 +0100)]
Bug 14915: (QA followup) Replace fa-time with fa-clock-o

Icon looks almost the same, just has a different name.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
6 years agoBug 14915: [FA 4.4] (QA followup) Replace fa-hold with fa-sticky-note-o
Katrin Fischer [Sun, 25 Oct 2015 22:01:11 +0000 (23:01 +0100)]
Bug 14915: [FA 4.4] (QA followup) Replace fa-hold with fa-sticky-note-o

Ok, this is a fun one: There is no icon like our current hold icon
in Font Awesome. So I picked fa-sticky-note-o for a replacement.

But since this is a new one, it doesn't exist in Koha yet.
I found no better match and the patch was already written...

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>