koha.git
14 years agobug 2274: adding libmime-lite-perl (MIME::Lite) to list of required debian packages
Andrew Moore [Tue, 15 Jul 2008 12:54:26 +0000 (07:54 -0500)]
bug 2274: adding libmime-lite-perl (MIME::Lite) to list of required debian packages

MIME::Lite is now a required perl module. The libmime-lite-perl debian package provides it.
Thanks to Zeno Tajoli for pointing out the omission.
http://markmail.org/message/np3m2zkafr2togez

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBug 2351 : Receive acqui order was not incrementing loop counter when saving multiple...
Ryan Higgins [Tue, 15 Jul 2008 09:03:23 +0000 (04:03 -0500)]
Bug 2351 : Receive acqui order was not incrementing loop counter when saving multiple items.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agofix "Add Tag" button in MARC framework editor
Jesse Weaver [Mon, 14 Jul 2008 20:40:37 +0000 (15:40 -0500)]
fix "Add Tag" button in MARC framework editor

This is part of bug 2282. This patch also improves the "Delete Tag" button so it brings you back to where you were.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agofix number two for 2181: Late Items in Red
Jesse Weaver [Mon, 14 Jul 2008 17:15:13 +0000 (12:15 -0500)]
fix number two for 2181: Late Items in Red

This new patch uses faster Perl string comparison when comparing dates for overdue checking.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agonew script to fix date code in accountlines
Jesse Weaver [Mon, 14 Jul 2008 17:15:14 +0000 (12:15 -0500)]
new script to fix date code in accountlines

misc/maintenance/fix_accountlines_date.pl runs through the accountlines table and converts every date in the 'description' column from us or metric format (specified on the command line) to the format in the 'dateformat' syspref.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agofix for 2177: Barcode on checkout slip
Jesse Weaver [Mon, 14 Jul 2008 17:15:15 +0000 (12:15 -0500)]
fix for 2177: Barcode on checkout slip

This patch adds barcodes to the Checkouts and Overdues section of the receipt. It also removes the Overdues section if it is empty.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoUpdated INSTALL.opensuse to install yaz
Ricardo Dias Marques [Tue, 15 Jul 2008 01:55:29 +0000 (02:55 +0100)]
Updated INSTALL.opensuse to install yaz

Changelog:
- Added step to install the yaz package. Thanks to Bob Ewart for catching this.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoAllowing people to search on all itemtypes when adding a serial subscription, workaro...
Chris Cormack [Tue, 15 Jul 2008 00:44:44 +0000 (12:44 +1200)]
Allowing people to search on all itemtypes when adding a serial subscription, workaround for the fact you cant limit by itemtype

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoFix to the Carp handling when we have a fatal cant connect to the database error
Chris Cormack [Tue, 15 Jul 2008 00:44:43 +0000 (12:44 +1200)]
Fix to the Carp handling when we have a fatal cant connect to the database error

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoFix for bug 2191: Subfield $n (Suppress in OPAC) has no effect on OPAC
Joshua Ferraro [Mon, 14 Jul 2008 19:51:07 +0000 (14:51 -0500)]
Fix for bug 2191: Subfield $n (Suppress in OPAC) has no effect on OPAC

Adding missing OpacSuppression syspref

14 years agobug 2347 [2/2]: database chagnes (adds to version 098)
Andrew Moore [Mon, 14 Jul 2008 17:20:02 +0000 (12:20 -0500)]
bug 2347 [2/2]: database chagnes (adds to version 098)

I'm removing RSS from the message_transports table now. I forgot that before.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobug 2347 [1/2]: removing RSS from optional and mandatory sql scripts
Andrew Moore [Mon, 14 Jul 2008 17:20:01 +0000 (12:20 -0500)]
bug 2347 [1/2]: removing RSS from optional and mandatory sql scripts

The RSS message_transport_type was recently removed (until we get it implemented). It
is now being removed from the other tables that reference it.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBarcodes test - make DB-dependent feedback a diag (not a test).
Joe Atzberger [Mon, 14 Jul 2008 17:45:34 +0000 (12:45 -0500)]
Barcodes test - make DB-dependent feedback a diag (not a test).

I also added a SKIP block in case of constructor failure and improved
the layout of existing diag lines.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoFix for bug: 2323: Conference name search fails in staff interface.
Joshua Ferraro [Mon, 14 Jul 2008 18:05:04 +0000 (13:05 -0500)]
Fix for bug: 2323: Conference name  search fails in staff interface.
wrdl missing from definition on adv search page in staff client

14 years agoFix to 2277: patron cardnumber is not a required field
Joshua Ferraro [Mon, 14 Jul 2008 17:57:20 +0000 (12:57 -0500)]
Fix to 2277: patron cardnumber is not a required field

Note to sysadmins: you'll need to add 'cardnumber' to the
syspref manually.

14 years agoFix for 1863: Result list for 'scan' index searches incorrect after first page
Joshua Ferraro [Mon, 14 Jul 2008 16:33:13 +0000 (11:33 -0500)]
Fix for 1863: Result list for 'scan' index searches incorrect after first page

14 years agoFix for bug 2116: Disable_Dictionary Syspref depreciated
Joshua Ferraro [Mon, 14 Jul 2008 16:05:43 +0000 (11:05 -0500)]
Fix for bug 2116: Disable_Dictionary  Syspref depreciated

It has been replaced by the syspref OpacAuthorities

14 years agoFix for bug 2115: OpacMaintenance wasn't working
Joshua Ferraro [Mon, 14 Jul 2008 16:01:44 +0000 (11:01 -0500)]
Fix for bug 2115: OpacMaintenance wasn't working

14 years agoFix for 2184
Joshua Ferraro [Mon, 14 Jul 2008 13:39:14 +0000 (08:39 -0500)]
Fix for 2184

14 years agoUpdates to online help
NCE [Mon, 14 Jul 2008 12:50:59 +0000 (08:50 -0400)]
Updates to online help

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoFinal fix for 2008: Daily reconciliation report broken
Joshua Ferraro [Sat, 12 Jul 2008 15:04:27 +0000 (10:04 -0500)]
Final fix for 2008: Daily reconciliation report broken

Stuff that hasn't ever worked in Koha gets commented out in 3.0 ;-)

14 years agoPartial fix for 2084: opac-topissues.pl is both EXPERIMENTAL and
Joshua Ferraro [Sat, 12 Jul 2008 14:52:17 +0000 (09:52 -0500)]
Partial fix for 2084: opac-topissues.pl is both EXPERIMENTAL and
very proc hungry and we needed to warn systems admins and turn it
OFF by default.

14 years agoFixing bug with the way authority ID query was being generated
Joshua Ferraro [Sat, 12 Jul 2008 14:33:17 +0000 (09:33 -0500)]
Fixing bug with the way authority ID query was being generated
in XSL stylesheet

14 years agoFix for bug2234: noOPACHolds syspref unused, superceded by RequestOnOpac
Joshua Ferraro [Sat, 12 Jul 2008 14:12:41 +0000 (09:12 -0500)]
Fix for bug2234: noOPACHolds syspref unused, superceded by RequestOnOpac
Note to systems maintainers: please delete from your systems manually.

14 years agoFix for bug 2342: Searching on more than 1 itemtype breaks
Joshua Ferraro [Sat, 12 Jul 2008 14:09:14 +0000 (09:09 -0500)]
Fix for bug 2342: Searching on more than 1 itemtype breaks

The problem was that the 'mc-' was removed from the checkboxes a while back and
that's what triggers the automatic application of OR boolean searching. I've
added it back to the templates and modified the ccl.properties file to include
mapping for itype,itemtype and ccode

14 years agoExtra comma caused js error in IE6; _() function allows translation script to pick...
Owen Leonard [Sat, 12 Jul 2008 01:04:10 +0000 (20:04 -0500)]
Extra comma caused js error in IE6; _() function allows translation script to pick up strings in Javascript.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoHide User Tags link when TagsEnabled preference is turned off. Change to Auth.pm...
Owen Leonard [Sat, 12 Jul 2008 00:50:58 +0000 (19:50 -0500)]
Hide User Tags link when TagsEnabled preference is turned off. Change to Auth.pm allows TagsEnabled preference to work on login screens.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoReport cleanup - fix highlight, add debugging feedback
Joe Atzberger [Fri, 11 Jul 2008 23:17:04 +0000 (18:17 -0500)]
Report cleanup - fix highlight, add debugging feedback

The debugging feedback (default style: hidden) is necessary to
investigate client reports where even after "backfill_statistics"
this report still fails to return results.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoFurther fixes to Labels.pm including escaping '(' and ')' for the PDF distiller
Chris Nighswonger [Fri, 11 Jul 2008 11:40:19 +0000 (07:40 -0400)]
Further fixes to Labels.pm including escaping '(' and ')' for the PDF distiller

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoAdditional help files
Nicole Engard [Fri, 11 Jul 2008 20:47:01 +0000 (16:47 -0400)]
Additional help files

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoFormatting additem form with nicer layout.
Owen Leonard [Fri, 11 Jul 2008 15:42:51 +0000 (10:42 -0500)]
Formatting additem form with nicer layout.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoRevert "fix for 2181: Late Items in Red"
Joshua Ferraro [Fri, 11 Jul 2008 02:30:03 +0000 (21:30 -0500)]
Revert "fix for 2181: Late Items in Red"

This used Date::Manip which we went to great lengths to remove about a year ago.

This reverts commit 36b2897430b27a6b8a12f6684d32bc64e026073f.

14 years agoBugfix 2343 : Do not supply default expiry date to patron entry page.
Ryan Higgins [Thu, 10 Jul 2008 22:07:52 +0000 (18:07 -0400)]
Bugfix 2343 : Do not supply default expiry date to patron entry page.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBug 2274: reducing MIME::Lite requirement to 3.0
Andrew Moore [Thu, 10 Jul 2008 20:49:12 +0000 (15:49 -0500)]
Bug 2274: reducing MIME::Lite requirement to 3.0

There has been a report of difficulties installing MIME::Lite 3.01. Only 3.0 is really necessary, so I'm relaxing the requirements.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoFurther update to allow notforloan < 0 items to be placed on hold. This is a workarou...
Ryan Higgins [Thu, 10 Jul 2008 20:38:28 +0000 (16:38 -0400)]
Further update to allow notforloan < 0 items to be placed on hold. This is a workaround for the lack of a notforhold flag.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoTemplate error prevented chosen branch from being preselected after form submission.
Owen Leonard [Thu, 10 Jul 2008 20:24:41 +0000 (15:24 -0500)]
Template error prevented chosen branch from being preselected after form submission.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoAllow holds to be placed on items with notforloan set as a negative value. See http...
Ryan Higgins [Thu, 10 Jul 2008 20:20:39 +0000 (16:20 -0400)]
Allow holds to be placed on items with notforloan set as a negative value. See wiki.koha.org/doku.php?id=en:development:kohastatuses

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoAdding javascript to deselect appropriate input fields when 'next available copy...
Owen Leonard [Thu, 10 Jul 2008 18:29:43 +0000 (13:29 -0500)]
Adding javascript to deselect appropriate input fields when 'next available copy' is checked or unchecked. Changing checkboxes to radio buttons to prevent multiple selections. Note: with javascript off, an item-level hold will be placed for the selected item even if the 'next available copy' box is checked.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agofix for 2181: Late Items in Red
Jesse Weaver [Thu, 10 Jul 2008 18:21:28 +0000 (13:21 -0500)]
fix for 2181: Late Items in Red

Modified overdue check in circ/circulation.pl to use Date::Manip's Date_Cmp. This would likely be useful other places in the file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoNomenclature update: s/Reserved on/Hold placed on/ and also updated translations
Joshua Ferraro [Thu, 10 Jul 2008 18:31:10 +0000 (13:31 -0500)]
Nomenclature update: s/Reserved on/Hold placed on/ and also updated translations

14 years agoFallout from removing Date.pm, two places still used it
Joshua Ferraro [Thu, 10 Jul 2008 17:06:37 +0000 (12:06 -0500)]
Fallout from removing Date.pm, two places still used it

14 years agobug 2329: removing unused RSS transport type - DB version 098.
Andrew Moore [Thu, 10 Jul 2008 16:34:38 +0000 (11:34 -0500)]
bug 2329: removing unused RSS transport type - DB version 098.

I didn't implement a way for patrons to get their advance notices and other
messages through RSS, so I'm removing it from the list of available transport types.
This will cause the "RSS" column in the patron messasging pages to be
unavailable. When we implement RSS, we can add it back in and the checkboxes will return.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoCorrecting text wrapping on labels
Chris Nighswonger [Thu, 10 Jul 2008 09:16:59 +0000 (05:16 -0400)]
Correcting text wrapping on labels

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobug 2284: ModMember can erase the dateofbirth field
Andrew Moore [Thu, 10 Jul 2008 14:32:56 +0000 (09:32 -0500)]
bug 2284: ModMember can erase the dateofbirth field

patch to C4::Members::ModMember to prevent it from deleting the dateofbirth field when none is supplied.

I also added a KohaTest::random_date method to help generate randomish dates for the test suite.
Added some tests for Member::ModMember. This is an easy method to test, and this bug shows that it
could use some closer examiniation.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobug 1980 [3/3]: remove bug workaround from pagination links
Andrew Moore [Thu, 10 Jul 2008 14:12:38 +0000 (09:12 -0500)]
bug 1980 [3/3]: remove bug workaround from pagination links

yesterday, the C4::Output::pagination_bar had a bug in it that I was crudely working around.
atz fixed that bug this morning. This patch removes the workaround. Thanks, atz!

I'm sending along atz's patch again with my signoff. It needs to be applied before this, as does the
other 1980 patch. I have sent that along (again), too, with a modified subject line. That makes a total of 3 patches for 1980.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobug 2329 [1/1]: remove RSS from list of transport options for patron messaging
Andrew Moore [Thu, 10 Jul 2008 13:45:27 +0000 (08:45 -0500)]
bug 2329 [1/1]: remove RSS from list of transport options for patron messaging

I didn't implement a way for patrons to get their advance notices and other messages
through RSS, so I'm removing it from the list of available transport types.
This will cause the "RSS" column in the patron messasging pages to be unavailable.
When we implement RSS, we can add it back in and the checkboxes will return.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBugfix pagination_bar to work with only one param/value pair.
Joe Atzberger [Thu, 10 Jul 2008 13:31:16 +0000 (08:31 -0500)]
Bugfix pagination_bar to work with only one param/value pair.

A valid test of this patch is this command:
perl -MC4::Output -e 'print pagination_bar("my/script?query=foobar",5,2,"page"),"\n";'

The output before patch begins:
&nbsp;<a href="my/script?query=foobar?page=1" rel="start">&lt;&lt;</a>
and AFTER patch:
&nbsp;<a href="my/script?query=foobar&amp;page=1" rel="start">&lt;&lt;</a>

The double "?" in QUERY_STRING are now avoided.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobug 2274: correcting call to new interface of overdue_notices.pl
Andrew Moore [Thu, 10 Jul 2008 13:06:48 +0000 (08:06 -0500)]
bug 2274: correcting call to new interface of overdue_notices.pl

I changed the interface to overdue_notices.pl at the last moment and forgot to correct one call to it.
This corrects circ/overdue.pl to call misc/cronjobs/overdue_notices.pl with the correct parameters.

Even better would be to move most of the code from overdue_notices.pl to a method somewhere
that both of these programs could call. It's inappropriate to call a cronjob from one of our CGIs.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoTotal overhaul of broken "Items with no checkouts" report.
Joe Atzberger [Wed, 9 Jul 2008 23:36:40 +0000 (18:36 -0500)]
Total overhaul of broken "Items with no checkouts" report.

Previous implementation was a crude copy/paste from a larger report.
CSV output was and is not functional (disabled in interface accordingly).
Output now includes and is sorted by itemcallnumber, because the purpose
of this report is to isolate uncirculating items to cull from the shelves.
Output also includes a summary at the top, with links to individual tables
below when broken out by a grouping.  Also included in the feedback but
default styled to display="none" are the actual SQL queries.  This is
incredibly useful for debugging and should probably be done in all reports.

Yet TODO: allow date range for checkouts and instead of
"no checkouts" (=0) allow the query to filter based on =x, >x, <x, etc.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agouseless line that generates zillions of "Useless use of a variable in void context...
Paul POULAIN [Thu, 10 Jul 2008 09:19:34 +0000 (11:19 +0200)]
useless line that generates zillions of "Useless use of a variable in void context" in apache logs

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobug 1980: updateing calls to SimpleSearch to limit number of things returned
Andrew Moore [Wed, 9 Jul 2008 20:52:24 +0000 (15:52 -0500)]
bug 1980: updateing calls to SimpleSearch to limit number of things returned

C4::Search::SimpleSearch was alredy patched to let you pass in the number of results you want back.
These instances were not using the new API. This patch makes all calls to SimpleSearch specify a limit.

I improved the documentation of SimpleSearch a bit to include the third returned value.

I believe there's a bug in C4::Output::pagination_bar, in that it doesn't deal well with URLs
with only one pair of parameter=value passed to it. I'm getting around this by passing in a second
pair that does nothing.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobug 2296: removing depreceated C4::Date module
Andrew Moore [Wed, 9 Jul 2008 17:08:14 +0000 (12:08 -0500)]
bug 2296: removing depreceated C4::Date module

The C4::Date module is deprecated. It is also no longer used anywhere in Koha.
This patch removes it and the associated tests.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobug 2274 [5/5]: removing some warnings
Andrew Moore [Wed, 9 Jul 2008 16:56:43 +0000 (11:56 -0500)]
bug 2274 [5/5]: removing some warnings

running misc/cronjobs/overdue_notices.pl with warnings on has uncovered some warnings in
C4::Members. This patch eliminates them.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobug 2274 [4/5]: removing obsolete misc/cronjobs/overduenotices*.pl programs
Andrew Moore [Wed, 9 Jul 2008 16:56:42 +0000 (11:56 -0500)]
bug 2274 [4/5]: removing obsolete misc/cronjobs/overduenotices*.pl programs

These three programs have been replaced by misc/cronjobs/overdue_notices.pl:

 overduenotices-30.pl
 overduenotices-csv.pl
 overduenotices.pl

This patch deletes them.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBug 2274 [3/5]: consolidating overdue notice cronjobs into one
Andrew Moore [Wed, 9 Jul 2008 16:56:41 +0000 (11:56 -0500)]
Bug 2274 [3/5]: consolidating overdue notice cronjobs into one

This patch adds the misc/cronjobs/overdue_notices.pl script that is intended to replace
overduenotices.pl, overduenotices-30.pl and overduenotices-csv.pl. It adds messages to
the message_queue to be sent later (by process_message_queue.pl). It also marks borrowers
as debarred if their issues become too overdue.

It is intended to be run from cron nightly with usage something like:
0 2 * * * misc/cronjobs/overdue_notices.pl

C4::Members:
 - improved documentation on ModMember
 - made ModMember return a useful value (the return value of the database call)
 - added a DebarMember method
 - adding t/lib/KohaTest/Members/DebarMember.pm to test ModMember

misc/cronjobs/overdue_notices.pl
 - designed to replace overduenotices.pl, overduenotices-30.pl, and overduenotice-csv

Changes to C4::Letters:
 - EnqueueLetter now lets you pass in to_address and from_address which can override defaults
 - _send_message_by_email pays attention to these defaults.
 - now handles attachments with MIME::Lite

C4::Overdues
 - added GetBranchcodesWithOverdueRules
   - added t/lib/KohaTest/Overdues/GerBranchcodesWithOverdueRules.pm to test that.

circ/overdue.pl
 - replaced call to obsolete overduenotices-csv.pl with call to overdue_notices.pl

KohaTest:
 - added three helper methods: random_phone, random_email, random_ip
   - these can be used to populate example records
 - you can now pass an optional lengh to random_string

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBug 2274 [2/5]: adding MIME::Lite to list of required modules
Andrew Moore [Wed, 9 Jul 2008 16:56:40 +0000 (11:56 -0500)]
Bug 2274 [2/5]: adding MIME::Lite to list of required modules

formerly, the overdues cronjobs were crafting their own MIME message attachments (poorly). This
patch adds a dependency on MIME::Lite, the de facto standard perl module for forming usable
emails with MIME attachments. MIME::Lite is pure perl and well supported on numerous platforms:
http://testers.cpan.org/show/MIME-Lite.html

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobug 2274 [1/5] database changes (DB rev 097) to add email address to message_queue...
Andrew Moore [Wed, 9 Jul 2008 16:56:39 +0000 (11:56 -0500)]
bug 2274 [1/5] database changes (DB rev 097) to add email address to message_queue table

I added three fields to the message_queue table:
 - to_address
 - from_address
 - content_type: necessary to hold email header for attachments
I changed one field in message_queue:
 - borrowernumber can now be NULL for messages sent to the admin

These can be used to override the default addresses used. By default, emails are sent to
the borrowers.email address and sent from the KohaAdminEmailAddress syspref address. These
values are still used if the to_address or from_address values are NULL. These changes
are necessary to let overdue_notices.pl be backwards compatible.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoadding pod spelling test
Andrew Moore [Wed, 9 Jul 2008 16:55:11 +0000 (11:55 -0500)]
adding pod spelling test

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoAdding some further help files
Nicole Engard [Thu, 10 Jul 2008 13:11:46 +0000 (09:11 -0400)]
Adding some further help files

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agofix for 2316: editing MARC subfield structure limits on subfield codes
Joshua Ferraro [Wed, 9 Jul 2008 03:50:04 +0000 (22:50 -0500)]
fix for 2316: editing MARC subfield structure limits on subfield codes

This is one place that TMPL EXPRs actually made sense, against my better
judgement. It's already used in this template, so if someone wants to clean
it up, feel free.

14 years agoUpdates to German translation
Joshua Ferraro [Wed, 9 Jul 2008 01:24:39 +0000 (20:24 -0500)]
Updates to German translation

14 years agoadding warnings for CGI::Session
Joshua Ferraro [Wed, 9 Jul 2008 01:21:08 +0000 (20:21 -0500)]
adding warnings for CGI::Session

14 years agoadding a note about Perl 5.10 to installation docs
Joshua Ferraro [Wed, 9 Jul 2008 01:09:45 +0000 (20:09 -0500)]
adding a note about Perl 5.10 to installation docs

Use Perl 5.8 (a library Koha depends on,
MARC::File::XML may not work with Perl 5.10, see:
http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2309),

14 years agofix for 2008: Daily reconciliation report broken
Joshua Ferraro [Wed, 9 Jul 2008 01:02:34 +0000 (20:02 -0500)]
fix for 2008: Daily reconciliation report broken

Stuff that hasn't ever worked in Koha gets commented out in 3.0 ;-)

14 years agoUpdated INSTALL.opensuse for openSUSE 11.0 Final
Ricardo Dias Marques [Wed, 9 Jul 2008 01:18:06 +0000 (02:18 +0100)]
Updated INSTALL.opensuse for openSUSE 11.0 Final

Changelog:

- openSUSE 11.0 Final seems to not have a "User Settings" section anymore. Deleting this section of the document.
- "Hardware Clock Set to UTC" option in openSUSE 11.0 install is now a checkbox. Updating section to reflect this

- Updating perl Makefile.PL output as of the Koha 3 snapshot development version available today (07-Jul-2008)
- Added Algorithm::CheckDigits installation (with output) and removed output from Biblio::EndnoteStyle
- Deleted section Install the "Algorithm::CheckDigits" Perl Module from the end of document, because it now get's installed
- Clarified kind of problems (related to JSON::Syck) that CGI::Session::Serialize::yaml prevents
- Added explanation of answering Yes to "Install the Zebra configuration files" in a NOZEBRA installation, like this one
- Added explanation of "fr" (French) choice for my Koha install
- Updated output of "make test"
- Deleted 2nd make test (because now we run it only once)
- Updated last lines of "make install" output
- Now the errors we get in make install are no longer related to C4::Labels but only to connections to data sources
- Added "SMS::Send" Perl Module installation
- Added POE::Test::Loops dependency to POE Section
- Added (new?) dependencies for PDF::Reuse (Text::PDF::TTFont0 and Font::TTF)
- Removed 2nd installation of PDF::Reuse::Barcode because it seems to be no longer necessary (1st installation now succeeds)
- Moved perl-Data-Showtable to the "Install DBD::MySQL" section where it really belongs
- Added note that says that if the software repositories are already set up, we may leave yast
- Added info to log in as root after system reboot
- Updated date of last modification to 7 July 2008
- Corrected some minor typos

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agofix for 2311: linking images to authorized values - need a "no image" option
Joshua Ferraro [Wed, 9 Jul 2008 00:21:49 +0000 (19:21 -0500)]
fix for 2311: linking images to authorized values - need a "no image" option

14 years agoImprove Z39.50 result checking and display a little:
MJ Ray [Fri, 20 Jun 2008 08:17:15 +0000 (09:17 +0100)]
Improve Z39.50 result checking and display a little:

1. Replaces display hostname with servername as shown on the selection screen.
2. If the record download errors, try to display the error.
3. A more useful warning if $DEBUG is set.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoPartial apply of a patch from Frederic, this ensures that
Joshua Ferraro [Tue, 8 Jul 2008 23:19:58 +0000 (18:19 -0500)]
Partial apply of a patch from Frederic, this ensures that
Context is cached; the remaining syspref cacheing will be
delayed until 3.2 as it needs to be paired with an as yet
unwritten setter for sysprefs

14 years agoMore changes to update-child process. Many scripts missing necessary data for checkin...
Owen Leonard [Tue, 8 Jul 2008 14:28:55 +0000 (09:28 -0500)]
More changes to update-child process. Many scripts missing necessary data for checking how to process an update-child request. Also cleaning up update-child.tmpl for formatting. Minor text change (translation problem?)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoScripts missing check for Child category type would not correctly show 'update child...
Owen Leonard [Tue, 8 Jul 2008 13:25:52 +0000 (08:25 -0500)]
Scripts missing check for Child category type would not correctly show 'update child patron' link in toolbar.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoPartial fix for bug 2319: OPAC Shelf Browse results in a 404 error
Joshua Ferraro [Tue, 8 Jul 2008 22:52:52 +0000 (17:52 -0500)]
Partial fix for bug 2319: OPAC Shelf Browse results in a 404 error

This patch fixes instances where thereis no Next or Previous item on the shelf
that were previous resulting in 404 errors

14 years agofix for 2322: Failure to reach amazon.com to retrieve enhanced content causes fatal...
Joshua Ferraro [Tue, 8 Jul 2008 21:31:04 +0000 (16:31 -0500)]
fix for 2322: Failure to reach amazon.com to retrieve enhanced content causes fatal error in Koha

14 years agobugfixing (itemtype summary) : it summary is defined, the icon & author were not...
Paul POULAIN [Fri, 20 Jun 2008 15:36:58 +0000 (17:36 +0200)]
bugfixing (itemtype summary) : it summary is defined, the icon & author were not displayed

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoPrior to this patch, XSL and scan indexes conflicted.
Joshua Ferraro [Tue, 8 Jul 2008 20:59:09 +0000 (15:59 -0500)]
Prior to this patch, XSL and scan indexes conflicted.
This patch resolves the issue by passing $scan to the
searchResults function to toggle XSL for scan results

14 years agoFix for bug 2312: Advanced search - search limit appearing twice of limit not the...
Joshua Ferraro [Tue, 8 Jul 2008 20:57:58 +0000 (15:57 -0500)]
Fix for bug 2312: Advanced search - search limit appearing twice of limit not the item type

14 years agobugfixing scan index
Paul POULAIN [Fri, 20 Jun 2008 15:36:56 +0000 (17:36 +0200)]
bugfixing scan index

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoFix for 2308: On-line help editing doesn't work
Joshua Ferraro [Tue, 8 Jul 2008 20:22:28 +0000 (15:22 -0500)]
Fix for 2308: On-line help editing doesn't work

14 years agoPatches bug #2308
Frederic Demians [Fri, 4 Jul 2008 14:10:59 +0000 (16:10 +0200)]
Patches bug #2308

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agofix to deal with 0088 & 0089 chars during indexing
Paul POULAIN [Tue, 8 Jul 2008 19:43:16 +0000 (21:43 +0200)]
fix to deal with 0088 & 0089 chars during indexing

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agofrench updated
Paul POULAIN [Tue, 8 Jul 2008 19:43:15 +0000 (21:43 +0200)]
french updated

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoUpdates to translations sent via email prior to release
Joshua Ferraro [Tue, 8 Jul 2008 19:37:40 +0000 (14:37 -0500)]
Updates to translations sent via email prior to release

14 years agoUpdates for translations on translate.koha.org prior to release
Joshua Ferraro [Tue, 8 Jul 2008 18:44:06 +0000 (13:44 -0500)]
Updates for translations on translate.koha.org prior to release

14 years agobug 1909: add delete field/subfield button to MARC editor
Galen Charlton [Tue, 8 Jul 2008 17:12:01 +0000 (12:12 -0500)]
bug 1909: add delete field/subfield button to MARC editor

A button to delete (non-mandatory) subfields and fields
is added to the bib and authority MARC editors.  This button,
which displays as a hypen or minus sign after the plus sign
to clone a field, acts as follows:

[1] When deleting a whole MARC field, if at least
    one other repeat of that field exists, deletes
    the field from the editor page.  If the field
    to be deleted is the last instance of that tag,
    the contents of the field are cleared, not removed.
    This allows one to delete all 650 tags, then
    add a new one without having to reload the
    record in the editor.

[2] When deleting a subfield, if at least one other
    repeat of that subfield and its tag occurs
    *anywhere else in the record, not necessarily in the same tag*,
    deletes the subfield.
    Otherwise, if the subfield is the last occurrence
    of that tag/subfield combination, clears the input
    form instead.

Documentation note: new screenshots for MARC editor, plus
description of the '-' button.

Credit to MJ Ray for introducing the '-' button
and the UnCloneField JavaScript function.

Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoTry to edit help, don't test, for some reason -w wasn't working
Joshua Ferraro [Tue, 8 Jul 2008 14:43:30 +0000 (10:43 -0400)]
Try to edit help, don't test, for some reason -w wasn't working

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobug 2203 [2/2]: use textareas for MARC21 authority 6XX
Galen Charlton [Tue, 8 Jul 2008 14:33:36 +0000 (09:33 -0500)]
bug 2203 [2/2]: use textareas for MARC21 authority 6XX

Use textareas for the 6XX fields when editing MARC21
authority records - these fields, not the 5XX, contain
the lengthy notes.

Note that because of the previous patch, both text inputs
and textareas permit entry of up to 9999 characters.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobug 2203 [1/2]: increase input maxlength in MARC editor
Galen Charlton [Tue, 8 Jul 2008 14:33:35 +0000 (09:33 -0500)]
bug 2203 [1/2]: increase input maxlength in MARC editor

The maximum length allowed for input into a subfield in
the MARC editor has been increased to 9999 charaacters
(from 255), permitting data entry of a field that meets
the maximum MARC field limit of 9999 octets.

Also set the maximum length for the leader form input
to 24 characters and the length for the MARC21 008
to 40 characters.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobug 2315: no crash if subfield code is a metacharacter
Galen Charlton [Mon, 7 Jul 2008 22:17:05 +0000 (17:17 -0500)]
bug 2315: no crash if subfield code is a metacharacter

When generating the display form of a heading that
happens to (invalidly) have a regular expression
metacharacter as a subfield label, do not crash.

An example of such a heading field is:

  <datafield tag="650" ind1=" " ind2="0">
    <subfield code="a">Dalziel, Andrew (Fictitious character</subfield>
    <subfield code=")">xFiction.</subfield>
  </datafield>

The error message associated with the crash is:

  Unmatched ) in regex; marked by <-- HERE in m/) <-- HERE / at
  /home/koha-pro/kohaclone/C4/Heading/MARC21.pm line 220.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agofix for 2286: Remove link to Network Printers
Joshua Ferraro [Tue, 8 Jul 2008 05:37:45 +0000 (00:37 -0500)]
fix for 2286: Remove link to Network Printers

14 years agoFix for 2160: My Lists Tab on OPAC Profile
Joshua Ferraro [Tue, 8 Jul 2008 05:18:40 +0000 (00:18 -0500)]
Fix for 2160: My Lists Tab on OPAC Profile

14 years agoImproving the list of itemtypes to match the bridge iconset
Joshua Ferraro [Tue, 8 Jul 2008 04:32:51 +0000 (23:32 -0500)]
Improving the list of itemtypes to match the bridge iconset

14 years agoUpdating for translation (capitalization normalization)
Joshua Ferraro [Tue, 8 Jul 2008 04:32:27 +0000 (23:32 -0500)]
Updating for translation (capitalization normalization)

14 years agoBug 1881: Managing Suggestions - default SUGGEST authorised values
Joshua Ferraro [Tue, 8 Jul 2008 04:31:51 +0000 (23:31 -0500)]
Bug 1881: Managing Suggestions - default SUGGEST authorised values

14 years agobug 2295 [followup 2/2]: initialize data in startup method
Galen Charlton [Mon, 7 Jul 2008 17:54:52 +0000 (12:54 -0500)]
bug 2295 [followup 2/2]: initialize data in startup method

It was observed that the %thash and @formats variables
were not being properly initalized during a make single-test run.

To ensure initialization, created startup and shutdown
methods to initialize those values as part of the
test object.

I have not yet investigated why the original way of
setting up %thash and @formats did not work.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobug 2295 [followup 1/2]: added name to one of tests in icondirectories.t
Galen Charlton [Mon, 7 Jul 2008 17:54:48 +0000 (12:54 -0500)]
bug 2295 [followup 1/2]: added name to one of tests in icondirectories.t

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobug 2295 [4/4]: moving C4::Labels tests into t/lib/KohaTest
Andrew Moore [Mon, 7 Jul 2008 17:54:49 +0000 (12:54 -0500)]
bug 2295 [4/4]: moving C4::Labels tests into t/lib/KohaTest

t/Labels.t was dependent on a working test database, so I'm moving those
tests into t/lib/KohaTest

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobug 2295 [3/4]: moving C4::Items tests into t/lib/KohaTest
Andrew Moore [Mon, 7 Jul 2008 17:54:50 +0000 (12:54 -0500)]
bug 2295 [3/4]: moving C4::Items tests into t/lib/KohaTest

The t/Items.t tests were actually dependent on the database, so I'm moving them
into t/lib/KohaTest.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobug 2295 [2/4]: moving icondirectories.t from t to xt
Andrew Moore [Mon, 7 Jul 2008 17:54:47 +0000 (12:54 -0500)]
bug 2295 [2/4]: moving icondirectories.t from t to xt

the icondirectories.t test depends on the database, so it needed to be
moved. But, it's really more of an author test since it's testinging the
correct structure of our distribution, so I'm moving it to xt/author.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobug 2295 [1/4]: moving C4::Dates tests into database dependent tests
Andrew Moore [Mon, 7 Jul 2008 17:54:51 +0000 (12:54 -0500)]
bug 2295 [1/4]: moving C4::Dates tests into database dependent tests

the t/Dates.t tests were actually databasase dependent. This patch replaces
t/Dates.t with t/lib/KohaTest/Dates/Usage.pm that relies on a database.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBUGFIX : unimarc leader is 24, not 25. Fixing the javascript test
Paul POULAIN [Wed, 2 Jul 2008 17:48:01 +0000 (19:48 +0200)]
BUGFIX : unimarc leader is 24, not 25. Fixing the javascript test

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBug#: 1989
DeAndre Carroll [Thu, 3 Jul 2008 18:01:12 +0000 (13:01 -0500)]
Bug#: 1989

Changed date popups in scheduler.tmpl to a date picker element
Made corresponding changes to scheduler.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>