koha.git
14 years agoBUGFIX : encoding problem & security problem
Paul POULAIN [Thu, 10 Apr 2008 08:41:16 +0000 (10:41 +0200)]
BUGFIX : encoding problem & security problem

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBugfix: Handling cases where the image is the correct pixel dimensions
Chris Nighswonger [Thu, 10 Apr 2008 06:35:53 +0000 (02:35 -0400)]
Bugfix: Handling cases where the image is the correct pixel dimensions

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoavoid crashes if record in result set is corrupted
Joshua Ferraro [Fri, 11 Apr 2008 09:50:51 +0000 (05:50 -0400)]
avoid crashes if record in result set is corrupted

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoadded jQuery plugin Treeview 1.4.0
Galen Charlton [Fri, 4 Apr 2008 20:19:56 +0000 (15:19 -0500)]
added jQuery plugin Treeview 1.4.0

This plugin by Jörn Zaeffererr handles creating an
expandable and collapsible tree from an unordered list, and
will initially be used for the enhanced user permissions page.
The plugin is dual-licensed: MIT and GPL.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoAdd Default location to Staff client login.
Ryan Higgins [Thu, 10 Apr 2008 18:42:28 +0000 (13:42 -0500)]
Add Default location to Staff client login.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoremove hardcoded ccode & loc authorized values from opac-detail.
Ryan Higgins [Thu, 10 Apr 2008 18:19:08 +0000 (13:19 -0500)]
remove hardcoded ccode & loc authorized values from opac-detail.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoStill tinkering with moredetail.tmpl; Haven't solved anchor problem.
Owen Leonard [Thu, 10 Apr 2008 19:04:02 +0000 (14:04 -0500)]
Still tinkering with moredetail.tmpl; Haven't solved anchor problem.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoAdding anchor link to updateitem redirect; Markup corrections for cat_issues_top...
Owen Leonard [Thu, 10 Apr 2008 19:03:53 +0000 (14:03 -0500)]
Adding anchor link to updateitem redirect; Markup corrections for cat_issues_top.tmpl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoQuotes in shelf name prevented editing of shelf name.
Owen Leonard [Thu, 10 Apr 2008 19:03:44 +0000 (14:03 -0500)]
Quotes in shelf name prevented editing of shelf name.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoQuotes in shelf name were causing js error.
Owen Leonard [Thu, 10 Apr 2008 19:03:38 +0000 (14:03 -0500)]
Quotes in shelf name were causing js error.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoMarkup corrections and standardizations.
Owen Leonard [Thu, 10 Apr 2008 19:03:29 +0000 (14:03 -0500)]
Markup corrections and standardizations.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBugfix for 1931 as well as a major overhaul in the presentation of the search results.
Chris Nighswonger [Thu, 10 Apr 2008 14:29:22 +0000 (10:29 -0400)]
Bugfix for 1931 as well as a major overhaul in the presentation of the search results.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agorenamed CheckSpecificUserPermissions to GranularPermissions
Galen Charlton [Thu, 10 Apr 2008 16:37:49 +0000 (11:37 -0500)]
renamed CheckSpecificUserPermissions to GranularPermissions

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agofix crash when attempting login as user w/o 'catalogue' permission
Galen Charlton [Thu, 10 Apr 2008 16:37:48 +0000 (11:37 -0500)]
fix crash when attempting login as user w/o 'catalogue' permission

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agogranular permissions - updated Tools
Galen Charlton [Thu, 10 Apr 2008 16:37:47 +0000 (11:37 -0500)]
granular permissions - updated Tools

Updated all scripts appearing on the tools page
to respect a granular permission defined for
each of them.

The tools menu and home page have been changed so
that only the specific tools that a user has
access are displayed.  This is simple, but depending on
the module and circumstance, it may be better to
display functions that the user has does not have
access to, but disable the links and do some sort
of visual styling to indicate that a function exists
but requires additional privileges to access.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agogranular permissions - update CGI script for permissions editor
Galen Charlton [Thu, 10 Apr 2008 16:37:46 +0000 (11:37 -0500)]
granular permissions - update CGI script for permissions editor

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agogranular permissions - setting user permissions
Galen Charlton [Thu, 10 Apr 2008 16:37:45 +0000 (11:37 -0500)]
granular permissions - setting user permissions

Adjusted the user permissions editing page as follows:

* Replaced table with a list
* Implemented a tree control using the jQuery Treeview plugin
* When CheckSpecificUserPermissions is ON, if a module
  flag has specific (i.e., children) permissions, allow
  them to be edited - this is where the tree control
  comes in.
* Added some hooks and an initial stab at the CSS
  to style the permissions editor tree.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoCAN_user_permission => CAN_user_permissions
Galen Charlton [Thu, 10 Apr 2008 16:37:44 +0000 (11:37 -0500)]
CAN_user_permission => CAN_user_permissions

Adjusted so that there wasn't a difference between
the 'permissions' code in userflags.flag and the
template variable.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agogranular permissions - C4::Auth
Galen Charlton [Thu, 10 Apr 2008 16:37:43 +0000 (11:37 -0500)]
granular permissions - C4::Auth

Enhanced the permission-checking functions in C4::Auth
(e.g., get_template_and_user, checkauth, check_api_auth, etc.).

If the CheckSpecificUserPermissions syspref is OFF, the behavior
of those APIs is unchanged.

If CheckSpecificUserPermissions is ON, then the value of each
key in the flagsrequired hash is considered during
the permissions check:

  1. if the value is 1, the staff user must have
     all privileges for the userflags flag (or module)
     referred to by the hash key, e.g.,

     { flaqsrequired => { tools => 1 } }

     In terms of the database, this means that the
     corresponding bit must be set in borrowers.flags.

  2. If the value is '*', the staff user must
     have at least one of the permissions for the
     userflag/module, but it doesn't matter which one.

     In terms of the database, this means ether that the
     corresponding bit must be set in borrowers.flags or
     that there at least is one row in user_permissions
     for the staff user and bit/module combination.

  3. If the value is any other string, it must be
     a permissions code defined in the permissions table.
     The staff user must have that specific permission
     or have access to all functions of the module

     In terms of the database, this means ether that the
     corresponding bit must be set in borrowers.flags or
     that there is a matching row in user_permissions
     for the staff user, bit/module, subpermission
     code combination.

In addition, get_template_and_user is modified so that the
CAN_user_XXX variables that it sets also includes the
subpermissions available (CAN_user_XXX_YYY, e.g.,
CAN_user_tools_import_patrons).  The template variables
for the specific permissions are set regardless of whether
CheckSpecificUserPermissions is ON or OFF so that the templates
don't have to test for that syspref explicitly.

In addition, the meaning of CAN_user_XXX has changed slightly -
CAN_user_tools, for example, is set to 1 in the template if the
user has access to *any* of the tools functions.  This was done
to simply the logic for deciding whether to display a menu
item in the staff interface are not.  This does mean that
when specific subpermissions are added to (say) the circulate
module, each use of CAN_user_circulate will need to be examined
to see if the intent is to allow the user to get at a circ
menu or page or if the user really should be required to have
all circulate functions.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agogranular permissions - created DB tables
Galen Charlton [Thu, 10 Apr 2008 16:37:42 +0000 (11:37 -0500)]
granular permissions - created DB tables

First big commit in a project to add more granular
staff user permissions to Koha.

* Created two new database tables

permissions:
  stores a list of defined permissions; each
  permission is to be interpreted as a child
  of a top-level permission defined in the
  existing user flags.  For example, Tools (bit 13)
  now has a separate sub-permission for each
  individual tool.

  The columns are
    module_bit  = FK referencing userflags.bit
    code        = code, e.g., import_patrons
    description = e.g., "Import patron data"

user_permissions:
  stores a list of the specific permissions that
  a staff user actually has.   For example, if
  staff user 123 has only the 'import_patrons' subpermission
  of 'Tools' (module_bit = 13), that would be represented
  by having (123, 13, 'import_patrons' in user_permissions.

  user_permissions and borrowers.flags are now interpreted
  as follows (assuming the CheckSpecificUserPermissions syspref
  is ON):
    * If the appropriate bit (e.g., bit 13 for Tools) is set
      in borrowers.flags, the staff user can access all
      Tools functions.  There should be no rows in user_permissions
      for that staff user and userflag bit combination.
    * If the bit is not set in borrowers.flags, but one or
      more rows are present in user_permissions for that
      staff user and bit combination, the staff user can
      access the specified sub-functions.
    * If the bit is not set in borrower.flags and there are
      no rows in user_permissions for that staff user and
      bit combination, the user cannot access any of the functions.

  Note that this means that if a staff user can access all
  functions for a module (because the bit is set in borrowers.flags),
  the user will automatically be able access any new subfunctions
  added to permissions by a database update.

  The columns are:
    borrowernumber = FK referencing borrowers.borrowernumber
    module_bit, code = FK referencing permissions

* Added a new system preference, CheckSpecificUserPermissions

If this system preference is ON, staff users can be assigned
specific permissions which will be respected during
authorization checks.  If this system preference is OFF, the
current userflags semantics will continue to apply.

* Defined sub-permissions for Tools.  The list of specific
  tools permissions is now:

  edit_news          Write news for the OPAC and staff interfaces
  label_creator      Create printable labels and barcodes from catalog and patron data
  edit_calendar      Define days when the library is closed
  moderate_comments  Moderate patron comments
  edit_notices       Define notices
  edit_notice_status_triggers     Set notice/status triggers for overdue items
  view_system_logs   Browse the system logs
  inventory          Perform inventory (stocktaking) of your catalogue
  stage_marc_import  Stage MARC records into the reservoir
  manage_staged_marc Manage staged MARC records, including completing and reversing imports
  export_catalog     Export bibliographic and holdings data
  import_patrons     Import patron data
  delete_anonymize_patrons    Delete old borrowers and anonymize circulation history (deletes borrower reading history)
  batch_upload_patron_images  Upload patron images in batch or one at a time
  schedule_tasks     Schedule tasks to run

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agofixed XHTML error
Galen Charlton [Thu, 10 Apr 2008 16:37:41 +0000 (11:37 -0500)]
fixed XHTML error

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobug 2006: do not crash when paying a lost item fine
Galen Charlton [Thu, 10 Apr 2008 14:12:44 +0000 (09:12 -0500)]
bug 2006: do not crash when paying a lost item fine

Qualified call to MarkIssueReturned with 'C4::Circulation'.
It looks like there is still a subtle bug with exporting
subs between modules that use each other.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoFix for installer languages so that only the staff client languages are visible to...
Joshua Ferraro [Thu, 10 Apr 2008 19:46:47 +0000 (15:46 -0400)]
Fix for installer languages so that only the staff client languages are visible to the installer

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoimproving english of maintenance page
Joshua Ferraro [Thu, 10 Apr 2008 06:45:21 +0000 (02:45 -0400)]
improving english of maintenance page

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobug 1953: removing potential SQL injection in C4::Acquisition::GetParcels
Andrew Moore [Wed, 9 Apr 2008 20:46:45 +0000 (15:46 -0500)]
bug 1953: removing potential SQL injection in C4::Acquisition::GetParcels

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobug 2009: fix to include "type" so that adding items to label batches works.
Andrew Moore [Wed, 9 Apr 2008 15:36:06 +0000 (10:36 -0500)]
bug 2009: fix to include "type" so that adding items to label batches works.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoInclude file required after modifications to opac-topissues.tmpl
Owen Leonard [Wed, 9 Apr 2008 13:59:01 +0000 (08:59 -0500)]
Include file required after modifications to opac-topissues.tmpl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoChanges to "Most Popular" interface: adding some default parameters to link so that...
Owen Leonard [Wed, 9 Apr 2008 13:58:52 +0000 (08:58 -0500)]
Changes to "Most Popular" interface: adding some default parameters to link so that page displays results right away. When results are shown, search form is moved into side bar, like facets. Adding tablesorter and 'place hold' links.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoAdding whitespace to allow wrapping of long subject hierarchies
Owen Leonard [Wed, 9 Apr 2008 13:58:45 +0000 (08:58 -0500)]
Adding whitespace to allow wrapping of long subject hierarchies

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoFormatting patron expiration date output (or was there a reason why this was commente...
Owen Leonard [Wed, 9 Apr 2008 13:58:37 +0000 (08:58 -0500)]
Formatting patron expiration date output (or was there a reason why this was commented out previously?)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoFix for Bug 1828 (
Owen Leonard [Wed, 9 Apr 2008 13:58:28 +0000 (08:58 -0500)]
Fix for Bug 1828 (

Edit Details link for expired member in circulation.pl incorrect)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoIdentifying "waiting at" branch on screen.
Owen Leonard [Wed, 9 Apr 2008 13:58:20 +0000 (08:58 -0500)]
Identifying "waiting at" branch on screen.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoAdding auto-focus to patrons resident search; Highlighting overdues count in patron...
Owen Leonard [Wed, 9 Apr 2008 13:58:14 +0000 (08:58 -0500)]
Adding auto-focus to patrons resident search; Highlighting overdues count in patron list.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoPrettying up holds print/confirm button, correcting markup in transfer slip.
Owen Leonard [Wed, 9 Apr 2008 13:58:09 +0000 (08:58 -0500)]
Prettying up holds print/confirm button, correcting markup in transfer slip.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoHighlight waiting and transfered items in the user's holds list. Statuses on transfer...
Owen Leonard [Wed, 9 Apr 2008 13:58:01 +0000 (08:58 -0500)]
Highlight waiting and transfered items in the user's holds list. Statuses on transfered items not working properly, though (Bug 2002).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoadd items.enumchron to _koha_new_item.
Ryan Higgins [Wed, 9 Apr 2008 12:16:37 +0000 (07:16 -0500)]
add items.enumchron to _koha_new_item.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBugfix: Correcting misspelled variable
Chris Nighswonger [Wed, 9 Apr 2008 11:36:38 +0000 (07:36 -0400)]
Bugfix: Correcting misspelled variable

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoAdding use of C4::Debug for debugging
Chris Nighswonger [Wed, 9 Apr 2008 11:28:25 +0000 (07:28 -0400)]
Adding use of C4::Debug for debugging

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobugfix : independantbranches behaviour
Paul POULAIN [Tue, 8 Apr 2008 20:14:14 +0000 (22:14 +0200)]
bugfix : independantbranches behaviour

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBiblioAddsAuthorities improvement/fix
Paul POULAIN [Tue, 8 Apr 2008 20:14:13 +0000 (22:14 +0200)]
BiblioAddsAuthorities improvement/fix

this commit restore a better behaviour :
- if ON : the librarian can enter manually an authority-linked marc field. and if it does not exist in the authorities file, it will be created automatically
- if OFF : the authority must exist in the authority file, and the librarian can't enter if manually in the MARC editor

This patch just deals with the OFF case (the ON was already here). With OFF the behaviour is now the same as in 2.2

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoAdding OPACItemHolds syspref in sql syspref, added by owen on april 1st
Paul POULAIN [Tue, 8 Apr 2008 20:14:12 +0000 (22:14 +0200)]
Adding OPACItemHolds syspref in sql syspref, added by owen on april 1st

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoreintroducing the limit on itemtype when searching a biblio in subscription add
Paul POULAIN [Fri, 4 Apr 2008 09:16:01 +0000 (11:16 +0200)]
reintroducing the limit on itemtype when searching a biblio in subscription add

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoReintroducing history dates for serial-issue (see previous commit for staff // feature)
Paul POULAIN [Fri, 4 Apr 2008 09:16:00 +0000 (11:16 +0200)]
Reintroducing history dates for serial-issue (see previous commit for staff // feature)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoreintroducing history manual modification feature
Paul POULAIN [Fri, 4 Apr 2008 09:15:59 +0000 (11:15 +0200)]
reintroducing history manual modification feature

The history start date and enddate is also useful to modify manually for the same reason : your serial collection may be older than your Koha serial management.

This commit reintroduce the feature.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobugfix for saving issuing rules
Paul POULAIN [Tue, 1 Apr 2008 14:01:43 +0000 (16:01 +0200)]
bugfix for saving issuing rules

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agouse HomeOrHoldingBranch to determine if a return is valid or not
paul [Tue, 1 Apr 2008 14:01:36 +0000 (16:01 +0200)]
use HomeOrHoldingBranch to determine if a return is valid or not

in fact, i'm not 100% sure of this bugfix : I don't see the case where a return should be done directly to homebranch, when the check out has been done at holdingbranch
so maybe we could hardcode 'holdingbranch' instead of using HomeOrHoldingBranch

the patch as written won't break anything existing.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoFixing bug 2005: ISBN Search
Joshua Ferraro [Wed, 9 Apr 2008 09:15:37 +0000 (05:15 -0400)]
Fixing bug 2005: ISBN Search

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoAddRenewal - handle opac-renewal, empty branch arg.
Joe Atzberger [Tue, 8 Apr 2008 22:43:52 +0000 (17:43 -0500)]
AddRenewal - handle opac-renewal, empty branch arg.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoAllow param "bornum" as in template, not just "borrowernumber". Added FIXMEs.
Joe Atzberger [Tue, 8 Apr 2008 22:43:51 +0000 (17:43 -0500)]
Allow param "bornum" as in template, not just "borrowernumber". Added FIXMEs.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoPartial fixes to enable unapi for non-zebra and non-public-facing sru
Joshua Ferraro [Tue, 8 Apr 2008 13:15:24 +0000 (09:15 -0400)]
Partial fixes to enable unapi for non-zebra and non-public-facing sru

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobug 2004: changes to guided reports on items
Galen Charlton [Tue, 8 Apr 2008 21:08:12 +0000 (16:08 -0500)]
bug 2004: changes to guided reports on items

* Added items.location and items.ccode to list of
  columns available for limiting
* choice of item type column (i.e., biblioitems.itemtype
  or items.itype) to limit by now respects
  item-level_itypes syspref

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agobug 1980: changes to label-item-search.pl to allow pagination over large result sets
Andrew Moore [Tue, 8 Apr 2008 19:04:20 +0000 (14:04 -0500)]
bug 1980: changes to label-item-search.pl to allow pagination over large result sets

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBug 1980: some cleanup, getting ready to add pagination to label-item-search.pl
Andrew Moore [Tue, 8 Apr 2008 19:04:19 +0000 (14:04 -0500)]
Bug 1980: some cleanup, getting ready to add pagination to label-item-search.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoDates.pm - trivial perldoc corrections
Joe Atzberger [Tue, 8 Apr 2008 16:28:40 +0000 (11:28 -0500)]
Dates.pm - trivial perldoc corrections

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoNOTE: REQUIRES INSTALLATION OF Image::Magick; Adding image scaling/resizing capabilit...
Chris Nighswonger [Tue, 8 Apr 2008 15:04:06 +0000 (11:04 -0400)]
NOTE: REQUIRES INSTALLATION OF Image::Magick; Adding image scaling/resizing capability to picture-upload.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoQuell 7 warnings: "my" variable $irule masks earlier declaration in same scope.
Joe Atzberger [Tue, 8 Apr 2008 14:50:19 +0000 (09:50 -0500)]
Quell 7 warnings: "my" variable $irule masks earlier declaration in same scope.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoAdding max-width to patron image in sidebar, correcting some markup in picture uploads.
Owen Leonard [Tue, 8 Apr 2008 13:14:20 +0000 (08:14 -0500)]
Adding max-width to patron image in sidebar, correcting some markup in picture uploads.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoAdding COinS support to cart pop-up; Hide similar items in opac-details if no similar...
Owen Leonard [Tue, 8 Apr 2008 13:14:14 +0000 (08:14 -0500)]
Adding COinS support to cart pop-up; Hide similar items in opac-details if no similar items are found.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoFixes for tablesorter problems when there are no checkouts from today; Other markup...
Owen Leonard [Tue, 8 Apr 2008 13:14:08 +0000 (08:14 -0500)]
Fixes for tablesorter problems when there are no checkouts from today; Other markup corrections.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoSome minor markup corrections, style fixes.
Owen Leonard [Tue, 8 Apr 2008 13:14:02 +0000 (08:14 -0500)]
Some minor markup corrections, style fixes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoTweaking display of resident search form; Tweaking labels breakcrumbs; Formatting...
Owen Leonard [Tue, 8 Apr 2008 13:13:56 +0000 (08:13 -0500)]
Tweaking display of resident search form; Tweaking labels breakcrumbs; Formatting tools menu.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoCompleting table sort js integration for checkouts and holds.
Owen Leonard [Tue, 8 Apr 2008 13:13:50 +0000 (08:13 -0500)]
Completing table sort js integration for checkouts and holds.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoSome formatting changes, bringing displays in circ and moremember more in line with...
Owen Leonard [Tue, 8 Apr 2008 13:13:34 +0000 (08:13 -0500)]
Some formatting changes, bringing displays in circ and moremember more in line with each other

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoFix calls to CalcFine, and make fines obey CircControl syspref (get homebranch withss...
Ryan Higgins [Mon, 7 Apr 2008 22:47:48 +0000 (17:47 -0500)]
Fix calls to CalcFine, and make fines obey CircControl syspref (get homebranch withssue data).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoadding MARC21 record descriptions as per loc.gov//marc/bibliographic/
Joshua Ferraro [Tue, 8 Apr 2008 01:25:11 +0000 (21:25 -0400)]
adding MARC21 record descriptions as per loc.gov//marc/bibliographic/

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoadding additional statuses display for XSL
Joshua Ferraro [Tue, 8 Apr 2008 00:02:18 +0000 (20:02 -0400)]
adding additional statuses display for XSL

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoadding Library of Congress Classification to display
Joshua Ferraro [Mon, 7 Apr 2008 22:39:14 +0000 (18:39 -0400)]
adding Library of Congress Classification to display

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoremoving escape=url as it broke '=' for q=query
Joshua Ferraro [Mon, 7 Apr 2008 22:23:07 +0000 (18:23 -0400)]
removing escape=url as it broke '=' for q=query

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoadding famfamfam iconset, improving isbn for amazon content, etc.
Joshua Ferraro [Mon, 7 Apr 2008 22:06:10 +0000 (18:06 -0400)]
adding famfamfam iconset, improving isbn for amazon content, etc.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoCleaning up XSL to display a few additional MARC21 fields
Joshua Ferraro [Thu, 27 Mar 2008 02:31:38 +0000 (22:31 -0400)]
Cleaning up XSL to display a few additional MARC21 fields

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoCorrecting screen help for patron image upload from moremember.pl
Chris Nighswonger [Mon, 7 Apr 2008 14:45:46 +0000 (10:45 -0400)]
Correcting screen help for patron image upload from moremember.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoAdd a working fines script, some changes to CalcFine and Circulation.pm
Ryan Higgins [Mon, 7 Apr 2008 08:28:01 +0000 (03:28 -0500)]
Add a working fines script, some changes to CalcFine and Circulation.pm

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoShow enumchron, copynumber in opac detail iff present.
Ryan Higgins [Mon, 7 Apr 2008 05:27:31 +0000 (00:27 -0500)]
Show enumchron, copynumber in opac detail iff present.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoAdd Logging module 'SYSTEMPREFERENCE', log adds, mods & deletes.
Ryan Higgins [Mon, 7 Apr 2008 03:09:24 +0000 (22:09 -0500)]
Add Logging module 'SYSTEMPREFERENCE', log adds, mods & deletes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoFix authorised_value '0' problem with last commit on detail.pl
Ryan Higgins [Mon, 7 Apr 2008 01:39:00 +0000 (20:39 -0500)]
Fix authorised_value '0' problem with last commit on detail.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoMore cleanup of location & ccode authval handling.
Ryan Higgins [Sat, 5 Apr 2008 17:55:52 +0000 (12:55 -0500)]
More cleanup of location & ccode authval handling.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoRemove hardcoded LOC AND CCODE authvals; fix no display of location on staff details...
Ryan Higgins [Sat, 5 Apr 2008 00:05:07 +0000 (19:05 -0500)]
Remove hardcoded LOC AND CCODE authvals; fix no display of location on staff details page.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agofrench translation updated
Paul POULAIN [Fri, 4 Apr 2008 09:16:02 +0000 (11:16 +0200)]
french translation updated

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoadding Ç as equivale nt to c for frenchies
Paul POULAIN [Tue, 1 Apr 2008 14:01:44 +0000 (16:01 +0200)]
adding Ç as equivale nt to c for frenchies

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agosome fixes to unimarc authorities ordering
paul [Tue, 1 Apr 2008 14:01:42 +0000 (16:01 +0200)]
some fixes to unimarc authorities ordering

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBUGFIX : using " instead of ' to avoid javascript failure
paul [Tue, 1 Apr 2008 14:01:41 +0000 (16:01 +0200)]
BUGFIX : using " instead of ' to avoid javascript failure

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBUGFIX renewal
paul [Tue, 1 Apr 2008 14:01:40 +0000 (16:01 +0200)]
BUGFIX renewal

otherwise, the new issuedate will be empty

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoThe link field is now a CCL index, so it must be longer than 5 char long
paul [Tue, 1 Apr 2008 14:01:39 +0000 (16:01 +0200)]
The link field is now a CCL index, so it must be longer than 5 char long

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoSome missing sysprefs in french
paul [Tue, 1 Apr 2008 14:01:38 +0000 (16:01 +0200)]
Some missing sysprefs in french

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoBug Fixing : Editing items was broken when using diacritics.
Henri-Damien LAURENT [Thu, 27 Mar 2008 08:21:02 +0000 (09:21 +0100)]
Bug Fixing : Editing items was broken when using diacritics.

Encoding was wrong

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoa reminder about tags for the RM
Joshua Ferraro [Fri, 4 Apr 2008 21:35:21 +0000 (17:35 -0400)]
a reminder about tags for the RM

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agodon't show famfamfam for a language v3.00.00-beta2
Joshua Ferraro [Fri, 4 Apr 2008 19:28:48 +0000 (15:28 -0400)]
don't show famfamfam for a language

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoMore work on label printing tool
Chris Nighswonger [Thu, 3 Apr 2008 14:58:25 +0000 (10:58 -0400)]
More work on label printing tool

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoRemoving a stray warn
Chris Nighswonger [Wed, 2 Apr 2008 14:42:03 +0000 (10:42 -0400)]
Removing a stray warn

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoCommenting out Dumper
Chris Nighswonger [Wed, 2 Apr 2008 14:34:11 +0000 (10:34 -0400)]
Commenting out Dumper

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoSome coding improvement and misc changes to BIBBAR labels
Chris Nighswonger [Wed, 2 Apr 2008 14:29:53 +0000 (10:29 -0400)]
Some coding improvement and misc changes to BIBBAR labels

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoSome markup corrections, breadcrumb improvement, and other minor changes.
Owen Leonard [Tue, 1 Apr 2008 20:58:43 +0000 (15:58 -0500)]
Some markup corrections, breadcrumb improvement, and other minor changes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoCorrecting table-sorter js for different table structures (Amazon content on or off...
Owen Leonard [Tue, 1 Apr 2008 20:58:32 +0000 (15:58 -0500)]
Correcting table-sorter js for different table structures (Amazon content on or off, item-level-itemtypes on or off)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoChanges to allow librarian to turn off item-level holds in the OPAC. Requires the...
Owen Leonard [Tue, 1 Apr 2008 20:58:23 +0000 (15:58 -0500)]
Changes to allow librarian to turn off item-level holds in the OPAC. Requires the addition of OPACItemHolds system pref ("Allow OPAC users to place hold on specific items. If OFF, users can only request next available copy." Type: YesNo). Also modifying redirect to show Holds tab in opac-user.pl.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoAdd backtrace printing option through SetEnv KOHA_BACKTRACES 1
MJ Ray [Tue, 1 Apr 2008 18:29:18 +0000 (19:29 +0100)]
Add backtrace printing option through SetEnv KOHA_BACKTRACES 1

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agomore XHTML corrections for new circ reports
Galen Charlton [Tue, 1 Apr 2008 17:01:10 +0000 (12:01 -0500)]
more XHTML corrections for new circ reports

Note: I question the use of GROUP_CONCAT(... SEPARATOR '<br/>'),
because that puts knowledge of the output mechanism (currently HTML)
into the SQL query.  However, I am not fixing this right now.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoSQL cleanup in new circ scripts: use placeholders
Galen Charlton [Tue, 1 Apr 2008 17:01:09 +0000 (12:01 -0500)]
SQL cleanup in new circ scripts: use placeholders

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agouse C4::Debug instead of checking DEBUG env var directly
Galen Charlton [Tue, 1 Apr 2008 17:01:08 +0000 (12:01 -0500)]
use C4::Debug instead of checking DEBUG env var directly

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agofixed typo in template
Galen Charlton [Tue, 1 Apr 2008 17:01:07 +0000 (12:01 -0500)]
fixed typo in template

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
14 years agoXHTML fixes for various circ templates
Galen Charlton [Tue, 1 Apr 2008 17:01:06 +0000 (12:01 -0500)]
XHTML fixes for various circ templates

Signed-off-by: Joshua Ferraro <jmf@liblime.com>