koha.git
9 years agoMerge branch 'bug_9106' into 3.12-master
Jared Camins-Esakov [Wed, 28 Nov 2012 20:42:43 +0000 (15:42 -0500)]
Merge branch 'bug_9106' into 3.12-master

9 years agoMerge branch 'bug_6680' into 3.12-master
Jared Camins-Esakov [Wed, 28 Nov 2012 13:31:25 +0000 (08:31 -0500)]
Merge branch 'bug_6680' into 3.12-master

9 years agoFollow up to Bug 6680: tiny up download lists formats
Nicole C. Engard [Wed, 7 Sep 2011 15:48:01 +0000 (11:48 -0400)]
Follow up to Bug 6680: tiny up download lists formats

Explains what uses RIS, and replaces iso2709 with 'MARC'.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Simply change, all tests pass.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 6680 - simple tidy-up of cart download format descriptions
Robin Sheat [Wed, 7 Sep 2011 06:54:42 +0000 (18:54 +1200)]
Bug 6680 - simple tidy-up of cart download format descriptions

Explains what uses RIS, and replaces iso2709 with 'MARC'.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Simple change, all tests pass.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 9098 Replace tabulations by spaces in opac-user.pl
Lyon3 Team [Mon, 19 Nov 2012 10:39:12 +0000 (11:39 +0100)]
Bug 9098 Replace tabulations by spaces in opac-user.pl

There was a bunch of tabulations from line 157 and followings

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
The following command show us there is no change:
  git show HEAD --ignore-all-space
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_7143' into 3.12-master
Jared Camins-Esakov [Wed, 28 Nov 2012 13:24:54 +0000 (08:24 -0500)]
Merge branch 'bug_7143' into 3.12-master

9 years agoBug 7143: Small fix for About page
Katrin Fischer [Wed, 28 Nov 2012 07:23:17 +0000 (08:23 +0100)]
Bug 7143: Small fix for About page

Adding missing version numbers:

Frédéric Demians (3.4, 3.6, 3.8, and 3.10 Translation Manager)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 7143 About changes for 3.12
Marcel de Rooy [Mon, 26 Nov 2012 09:21:45 +0000 (10:21 +0100)]
Bug 7143 About changes for 3.12

Proposing a new section for current release team.

Signed-off-by: Marc Veron <veron@veron.ch>
Section appears on about page as expected.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Looks ok to me, passes tests.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_2832' into 3.12-master
Jared Camins-Esakov [Wed, 28 Nov 2012 13:17:58 +0000 (08:17 -0500)]
Merge branch 'bug_2832' into 3.12-master

9 years agoBug 2832: [SIGNED-OFF] Followup: Add a default value
Jonathan Druart [Wed, 24 Oct 2012 14:19:24 +0000 (16:19 +0200)]
Bug 2832: [SIGNED-OFF] Followup: Add a default value

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Makes sense, and works as advertised.

9 years agoBug 9132: Paging through OPAC authority search results does not work (followup 1...
Fridolyn SOMERS [Fri, 23 Nov 2012 11:14:03 +0000 (12:14 +0100)]
Bug 9132: Paging through OPAC authority search results does not work (followup 1) input with and_ora instread of and_or

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 9132: Paging through OPAC authority search results does not work
Fridolyn SOMERS [Fri, 23 Nov 2012 11:13:44 +0000 (12:13 +0100)]
Bug 9132: Paging through OPAC authority search results does not work

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixes paging in authority result list in OPAC.
All tests pass.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 9142 - Remove the use of subtests
Tomas Cohen Arazi [Mon, 26 Nov 2012 13:39:51 +0000 (10:39 -0300)]
Bug 9142 - Remove the use of subtests

Debian stable's version of Test::More is older than the one I used on my
12.04 dev box, and doesn't support subtests, which I used to avoid side
effects between different test scenarios.

This patch removes that subtest definition.

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests pass.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_9025' into 3.12-master
Jared Camins-Esakov [Sun, 25 Nov 2012 23:41:55 +0000 (18:41 -0500)]
Merge branch 'bug_9025' into 3.12-master

9 years agoBug 9025: Adding new icons for itemtypes from Sudoc
Sophie Meynieux [Wed, 7 Nov 2012 17:48:43 +0000 (18:48 +0100)]
Bug 9025: Adding new icons for itemtypes from Sudoc

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Checked that new images show up when managing itemtypes and
authorised values and can be selected and used.
Checked about page for license information.
All tests pass.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_9020' into 3.12-master
Jared Camins-Esakov [Sun, 25 Nov 2012 23:36:09 +0000 (18:36 -0500)]
Merge branch 'bug_9020' into 3.12-master

9 years agoBug 9020: follow-up fixes french translation for permissions
Paul Poulain [Tue, 20 Nov 2012 16:02:36 +0000 (17:02 +0100)]
Bug 9020: follow-up fixes french translation for permissions

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests pass.
Installed Koha with all French sample data and checked that
all permissions were translated and diacritics were displayed
correctly.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_9059' into 3.12-master
Jared Camins-Esakov [Sun, 25 Nov 2012 23:34:00 +0000 (18:34 -0500)]
Merge branch 'bug_9059' into 3.12-master

9 years agoBug 9059: Followup
Marcel de Rooy [Wed, 14 Nov 2012 13:02:54 +0000 (14:02 +0100)]
Bug 9059: Followup

Removes last occurrence of dependent= parameter. See also report 7368.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests.
Tested successfully in Chromium and Firefox in Ubuntu.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 9059: Increase size of opac-sendbasket window
Marcel de Rooy [Mon, 12 Nov 2012 11:20:20 +0000 (12:20 +0100)]
Bug 9059: Increase size of opac-sendbasket window

Change window settings for opac-sendbasket. If you need to login
first, the window should be much larger.

Typo dependant should be dependent. Note that this setting is
ignored in much browsers. Will submit another patch to cover more occurrences.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 8515 - OPAC password change does not obey OpacPasswordChange
Owen Leonard [Fri, 2 Nov 2012 16:40:08 +0000 (12:40 -0400)]
Bug 8515 - OPAC password change does not obey OpacPasswordChange

The OPAC change password template enforces the OpacPasswordChange
preference by preventing the form from appearing. However, the
script doesn't contain any check for OpacPasswordChange so it is
vulnerable to someone submitting data to it by some other means.

This patch adds a check for OpacPasswordChange to the script and
revises the template logic in order to show the right warning
in all circumstances.

To test, turn off OpacPasswordChange and navigate manually to
opac-passwd.pl. You should see a warning that you can't change
your password.

Turn on OpacPasswordChange load the change password page and
save the page to your desktop. Turn off OpacPasswordChange and
submit a password change via the saved page. Without the patch
this would result in a password change. After the patch it
should not.

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Confirmed bug and made sure patch fixes it.
Passes all tests and perlcritic.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_7358' into 3.12-master
Jared Camins-Esakov [Sun, 25 Nov 2012 23:20:32 +0000 (18:20 -0500)]
Merge branch 'bug_7358' into 3.12-master

9 years agoBug 7358: reaffect a closed basket to a closed basketgroup
Jonathan Druart [Wed, 22 Aug 2012 11:37:31 +0000 (13:37 +0200)]
Bug 7358: reaffect a closed basket to a closed basketgroup

The list of basketgroups when looking at a closed basket show all the
basketgroups.
It should not be possible to affect a basket to a closed basketgroup,
since this basketgroup should have been sent to a supplier.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_9073' into 3.12-master
Jared Camins-Esakov [Sun, 25 Nov 2012 23:09:14 +0000 (18:09 -0500)]
Merge branch 'bug_9073' into 3.12-master

9 years agoBug 9073 - Download option from the cart should match the menu button in lists
Owen Leonard [Tue, 20 Nov 2012 17:27:25 +0000 (12:27 -0500)]
Bug 9073 - Download option from the cart should match the menu button in lists

This patch moves the staff client Cart download choices into a toolbar
menu button instead of requiring that the user make the choice via a form
in the pop-up window.

To test, add items to Cart in the staff client. Open the cart and
choose a download option from the Download menu. Your download
should complete correctly without the page changing or reloading.

Unrelated edit: Eliminating duplicate document.ready() block by
consolidating a couple of lines of JavaScript.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Checked all export formats can be selected and downloaded, including
CSV profiles.
All tests and perlcritic pass.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 9115 - basket window should close automatically when placing a hold
Owen Leonard [Tue, 20 Nov 2012 14:49:19 +0000 (09:49 -0500)]
Bug 9115 - basket window should close automatically when placing a hold

If you choose to place a hold from the Cart pop-up, the entire
holds process (possibly including login) takes place in the cart
window. Upon completion of the operation you're left with a second
window which has lost its context as the Cart.

This patch revises the hold process so that when you click the
hold link in the cart the operation is moved to the main window
and the Cart window closes.

Since the holdSel() function doesn't require interaction with
template variables I have moved it to basket.js along with the
described changes.

To test, put items in your Cart and open it. Select items to
place on hold and click the "Place hold" link. The cart
should close, and the items you selected should appear on the
place hold screen in the main window.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Checked in Firefox and Chromium in Ubuntu, works nicely.
All tests pass.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_8660' into 3.12-master
Jared Camins-Esakov [Fri, 23 Nov 2012 21:39:37 +0000 (16:39 -0500)]
Merge branch 'bug_8660' into 3.12-master

9 years agoBug 8660: follow-up: Porting changes to ccsr theme
Fridolyn SOMERS [Thu, 18 Oct 2012 10:23:32 +0000 (12:23 +0200)]
Bug 8660: follow-up: Porting changes to ccsr theme

Signed-off-by: Mason James <mtj@kohaaloha.com>
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 8660: Tag status does not show on multiple tag add
Fridolyn SOMERS [Wed, 22 Aug 2012 14:10:06 +0000 (16:10 +0200)]
Bug 8660: Tag status does not show on multiple tag add

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Passed-QA-by: Paul Poulain <paul.poulain@biblibre.com>
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_8986' into 3.12-master
Jared Camins-Esakov [Fri, 23 Nov 2012 18:35:24 +0000 (13:35 -0500)]
Merge branch 'bug_8986' into 3.12-master

9 years agoBug 8986: Followup FIX a JS error if there is no valid card number
Jonathan Druart [Mon, 19 Nov 2012 16:11:21 +0000 (17:11 +0100)]
Bug 8986: Followup FIX a JS error if there is no valid card number

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
I can't reproduce the JS error but the template changes are correct
with regard to how the page should handle errors.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 8986: Batch patron modification template corrections
Owen Leonard [Tue, 30 Oct 2012 13:51:31 +0000 (09:51 -0400)]
Bug 8986: Batch patron modification template corrections

Many minor template changes:

- Correcting title and headings
- Adding translation to string in JavaScript
- Tweaking table sorter
- Wrapping card number in link to patron detail page
- Adding standard styles to "clear" links (see patron attributes)
- Terminiology corrections (borrower-> patron, cardnumber -> card number)
- Capitalization corrections
- Improve display of extended attributes

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_8899' into 3.12-master
Jared Camins-Esakov [Fri, 23 Nov 2012 18:30:32 +0000 (13:30 -0500)]
Merge branch 'bug_8899' into 3.12-master

9 years agoBug 8899 [Revised] Remove unused CSS declarations from staff client CSS
Owen Leonard [Fri, 12 Oct 2012 14:26:52 +0000 (10:26 -0400)]
Bug 8899 [Revised] Remove unused CSS declarations from staff client CSS

Using an add-on for Firefox called CSS Usage I found some
instances of CSS in staff-global.css which are unused. Unused
selectors were confirmed by a search of the code.

Testers can't exactly check the whole staff client for things
which look off, but can confirm by their own search that
the removed CSS has no corresponding markup.

Revision adds back lines which were discoverd by QA to be in use.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 5521 - item edit form appears if no items found
Owen Leonard [Tue, 30 Oct 2012 14:53:39 +0000 (10:53 -0400)]
Bug 5521 - item edit form appears if no items found

This patch changes the template so that if no items are
found the page doesn't show "The following barcodes were found"
and doesn't show the item edit form.

To test, submit a batch which contains no valid barcodes.
Compare to a batch which contains some or all valid barcodes.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
All tests succeed.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_8546' into 3.12-master
Jared Camins-Esakov [Fri, 23 Nov 2012 18:02:31 +0000 (13:02 -0500)]
Merge branch 'bug_8546' into 3.12-master

9 years agoBug 8546 - Error in description of OPAC Advanced Search Publication date range search
Owen Leonard [Fri, 2 Nov 2012 18:48:25 +0000 (14:48 -0400)]
Bug 8546 - Error in description of OPAC Advanced Search Publication date range search

The publication date range search description in the OPAC suggests
that a search like "-1987" or "2008-" is not inclusive when it
actually is. This patch corrects the description.

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 8983: Typo in UNIMARCslim2OPACResults.xsl
Fridolyn SOMERS [Tue, 30 Oct 2012 10:20:05 +0000 (11:20 +0100)]
Bug 8983: Typo in UNIMARCslim2OPACResults.xsl

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 8163: Click to populate XSLT preferences with "default" or empty values
Owen Leonard [Tue, 29 May 2012 19:07:32 +0000 (15:07 -0400)]
Bug 8163: Click to populate XSLT preferences with "default" or empty values

This patch adds markup and JavaScript to the system preferences
interface so that the user can click "default" or "empty" to populate
an XSLT-related pref with those vaules.

To test, open system preferences for the OPAC or staff client. In
the description for an XSLT-related preference click the "default"
link to populate the field with "default." Click the "leave empty"
link to empty the field.

Revised according to Julian Maurice's suggestion for a more
generic, flexible way to implement it.

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_8664' into 3.12-master
Jared Camins-Esakov [Fri, 23 Nov 2012 17:12:59 +0000 (12:12 -0500)]
Merge branch 'bug_8664' into 3.12-master

9 years agoBug 8664 - Add floating toolbar with save button to system preferences editor
Owen Leonard [Wed, 22 Aug 2012 12:48:38 +0000 (08:48 -0400)]
Bug 8664 - Add floating toolbar with save button to system preferences editor

This patch adds a copy of the "save" button in a toolbar at
the top of the system preferences editor. The toolbar becomes
fixed at the top of the page when you scroll down, exactly like
the toolbar on addbiblio.pl.

Because multiple save buttons might appear when the system prefs
page displays search results, the toolbar does not appear in
this case.

To test, open the system preferences editor and change a setting.
Try saving both with the button in the toolbar and the button at
the top of the page. Test scrolling to confirm that the toolbar
"sticks" to the top of the page when you scroll down.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_8758' into 3.12-master
Jared Camins-Esakov [Fri, 23 Nov 2012 16:44:55 +0000 (11:44 -0500)]
Merge branch 'bug_8758' into 3.12-master

9 years agoMerge branch 'bug_2832' into 3.12-master
Jared Camins-Esakov [Fri, 23 Nov 2012 16:44:26 +0000 (11:44 -0500)]
Merge branch 'bug_2832' into 3.12-master

Conflicts:
kohaversion.pl

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoUpdate kohaversion for 3.11.000.001
Jared Camins-Esakov [Fri, 23 Nov 2012 16:42:34 +0000 (11:42 -0500)]
Update kohaversion for 3.11.000.001

9 years agoMerge branch 'bug_2832' into 3.12-master
Jared Camins-Esakov [Fri, 23 Nov 2012 16:41:48 +0000 (11:41 -0500)]
Merge branch 'bug_2832' into 3.12-master

Conflicts:
installer/data/mysql/nb-NO/1-Obligatorisk/system_preferences.sql
installer/data/mysql/updatedatabase.pl

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_9008' into 3.12-master
Jared Camins-Esakov [Fri, 23 Nov 2012 16:40:46 +0000 (11:40 -0500)]
Merge branch 'bug_9008' into 3.12-master

9 years agoUpdate history to reflect 3.10.0 and 3.8.7 releases
Jared Camins-Esakov [Fri, 23 Nov 2012 16:38:29 +0000 (11:38 -0500)]
Update history to reflect 3.10.0 and 3.8.7 releases

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoAdding 3.10 release notes
Paul Poulain [Fri, 23 Nov 2012 15:27:57 +0000 (16:27 +0100)]
Adding 3.10 release notes

9 years agoBumping version to 3.10.0 and adding sponsors that are were not already written
Paul Poulain [Mon, 19 Nov 2012 16:16:33 +0000 (17:16 +0100)]
Bumping version to 3.10.0 and adding sponsors that are were not already written

Sponsored-by: Central Kansas Library System (CKLS), Plum Creek Library System and Washoe County Library System
Sponsored-by: Los Gatos Public Library and Harrison Carmel Public Library
Sponsored-by: Talking Tech
Sponsored-by: VOKAL
Sponsored-by: Brooklyn Law School Library
Sponsored-by: North Central Regional Library (NCRL)
Sponsored-by: Washoe County Library System
Sponsored-by: Corpus Christi Public Libraries
Sponsored-by: Northeast Kansas Library System (NEKLS)
Sponsored-by: Université d'Aix-Marseille
Sponsored-by: Université de Rennes 2
Sponsored-by: Université de Lyon 3
Sponsored-by: Université de St Etienne
Sponsored-by: BdP de la Meuse
9 years agoBug 9122: fix the problem when writing-off a fine
Paul Poulain [Fri, 23 Nov 2012 13:32:42 +0000 (14:32 +0100)]
Bug 9122: fix the problem when writing-off a fine

The problem was introduced by the addition of accountlines_id in bug 7671

The WriteOffFee sub was called with accountlines_id as second parameter
but still dealing with the accountno column.

As a result, the UPDATE was failing (updating nothing), and the fine
note written off even if the writeoff itself was saved. In other words:
the writeoff was not "attached" to the fine.

This patch fixes the problem.

Test plan: do what katrin says in initial description of the problem:
- add some fines manually, I did 'new card' and sundry
- try writing off all of them or one of them
- the fine is correctly written off

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 9106 - Filtering list of uncertain price list by owner empties order information
Owen Leonard [Mon, 19 Nov 2012 16:00:15 +0000 (11:00 -0500)]
Bug 9106 - Filtering list of uncertain price list by owner empties order information

The form which filters the list of orders with uncertain prices
includes a parameter which tells the script to modify the orders,
resulting in order information being lost. This patch removes
the unnecessary form field.

To test you must have orders with uncertain prices, preferably from
more than one user. Go to the uncertain prices page. Before applying
this patch, submitting the "orders from" form would cause the page
to refresh with no results. This is because the script cleared the
orders of price, quantity, etc. information.

After applying this patch the uncertain prices list should refresh
and show the correct results, either your orders ("me") or all
("Everyone").

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 9078 - fixing exceptions broke tests
Tomas Cohen Arazi [Wed, 21 Nov 2012 15:54:46 +0000 (12:54 -0300)]
Bug 9078 - fixing exceptions broke tests

Fixing the holiday exceptions arised a problem with how the test data was constructed.
This made several tests fail.

This patch fixes the add_holiday function. Tests should pass now.

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passed-QA-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 9078 - is_holiday should honour holiday exceptions
Tomas Cohen Arazi [Wed, 21 Nov 2012 13:43:11 +0000 (10:43 -0300)]
Bug 9078 - is_holiday should honour holiday exceptions

Make is_holiday return 0 for holiday exceptions.

Note: This patch makes several current ok tests fail. My first guess is test data is not
constructed ok. More on this later.

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passed-QA-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_8800' into 3.12-master
Jared Camins-Esakov [Thu, 22 Nov 2012 14:20:07 +0000 (09:20 -0500)]
Merge branch 'bug_8800' into 3.12-master

9 years agoBug 8800 - useDaysMode=Datedue wrong behaviour (revisited)
Tomas Cohen Arazi [Fri, 21 Sep 2012 15:50:26 +0000 (12:50 -0300)]
Bug 8800 - useDaysMode=Datedue wrong behaviour (revisited)

useDaysMode=Datedue wasn't used as advertised in the docs. Added
next_open_day and prev_open_day subs to Koha::Calendar and some tests for them.

- Koha::Calendar->addDate was rewritten in a more sane way (also split into
  addHours and addDays for convenience).
- Fixed a bug introduced in Bug 8966 regarding dt truncation and dtSets->contains
- Minor docs typos
- Use the passed Calendar mode or default to 'Calendar' in Koha::Calendar->_mockinit.
- Tests

I'm writing some db-dependent tests for is_holiday, and hopefully for CalcDateDue so any
rewrite/followup doesn't break things.

Regards
To+

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passed-QA-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 9064: Increment version number
Jared Camins-Esakov [Thu, 22 Nov 2012 14:04:05 +0000 (09:04 -0500)]
Bug 9064: Increment version number

Database update for bug 9064 has been given version 3.09.00.067

9 years agoBug 9064: fix statistics.ccode column
Paul Poulain [Wed, 21 Nov 2012 12:46:59 +0000 (13:46 +0100)]
Bug 9064: fix statistics.ccode column

From updatedatabase.pl:
    $dbh->do("ALTER TABLE statistics ADD COLUMN ccode VARCHAR ( 10 ) NULL AFTER associatedborrower");
From kohastructure.sql:
  `ccode` int(11) default NULL, -- foreign key from the items table, links transaction to a specific collection code

The variant in updatedatabase.pl is probably what was wanted.

This patch fixes the kohastructure and add another updatedatabase.pl, in case someone has a broken install.
This should not happen, because 3.10.0 still not released, but just in case...

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_8954' into 3.12-master
Jared Camins-Esakov [Tue, 20 Nov 2012 19:40:15 +0000 (14:40 -0500)]
Merge branch 'bug_8954' into 3.12-master

9 years agoBug 8954: Make languages list in advanced search translatable (revision 1)
Mathieu Saby [Thu, 8 Nov 2012 23:49:49 +0000 (00:49 +0100)]
Bug 8954: Make languages list in advanced search translatable (revision 1)

In opac-search.pl and search.pl, this patch moves the $lang variable from the end to the begining of the script, and use it as a parameter for getAllLanguages.
In Languages.pm, getAllLanguages function is modified :
- if no parameter is passed to the function, it returns english languages names
- if a $lang parameter conforming to RFC4646 syntax is passed :
-- the function returns languages names translated in $lang if possible
-- if a language name is not translated in $lang in database, the function returns english language name
To test, set your opac and staff interface in english and in other languages and check search.pl and opac-search.pl :
- If language names in your languages_description table are translated in the same language you use for your GUI, the language names in dropdown list will be translated in this language (+native name).
- If your GUI is in english, or in a language into whitch languages names are not translated in languages_description, the dropdown list will stay in english (+native name).

Signed-off-by: Marc Veron <veron@veron.ch>
Patch behaves as expected.

With Opac language set to French I got all languages with French language name.
With German (de-DE), I got only a few with German language names (and all other with English ones),
this was due to missing entries for de-DE in table language_descriptions.
This behaviour is consistent with the description above.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested language list in OPAC and staff advanced search is translated
properly after applying the patch. Checked that language switcher still
works like it should.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Fixed typo in POD.

9 years agoMerge branch 'bug_8844' into 3.12-master
Jared Camins-Esakov [Tue, 20 Nov 2012 19:24:46 +0000 (14:24 -0500)]
Merge branch 'bug_8844' into 3.12-master

9 years agoMerge branch 'bug_9024' into 3.12-master
Jared Camins-Esakov [Tue, 20 Nov 2012 19:14:15 +0000 (14:14 -0500)]
Merge branch 'bug_9024' into 3.12-master

9 years agoBug 9024: Fix typo
Mirko Tietgen [Tue, 20 Nov 2012 16:39:01 +0000 (17:39 +0100)]
Bug 9024: Fix typo

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 9024: Add missing sample data to existing files
Katrin Fischer [Wed, 7 Nov 2012 15:04:06 +0000 (16:04 +0100)]
Bug 9024: Add missing sample data to existing files

Adds missing authorised values (enhancement)

Adds missing slip notice templates (bug fix)
Koha will complain if you try to print a slip and there is no notice
defined for them, so this is not really an improvement, but kind of a bug fix.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Passed-QA-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 9024: Adding sample patron attributes to German web installer
Katrin Fischer [Wed, 7 Nov 2012 14:39:48 +0000 (15:39 +0100)]
Bug 9024: Adding sample patron attributes to German web installer

Adds SHOW_BCODE as sample patron attribute to the German web installer.

To test:
- Run the web installer in German, make sure the new sample data shows up
and can be installed.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Passed-QA-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_9017' into 3.12-master
Jared Camins-Esakov [Tue, 20 Nov 2012 19:10:59 +0000 (14:10 -0500)]
Merge branch 'bug_9017' into 3.12-master

9 years agoBug 9017 - Quote of the day: Table footer not translated
Marc Veron [Wed, 7 Nov 2012 12:56:42 +0000 (13:56 +0100)]
Bug 9017 - Quote of the day: Table footer not translated

The strings for the table footer of the QOD feature are translated in /datatables-strings.inc, but they did not show up in staff client due to missing code in quotes.tt -> $(document).ready(function(), part "oLanguage"
Code added as appropriate.
See: http://datatables.net/usage/i18n

Additionally, quotes.tt had a stray </script> tag after [% INCLUDE 'datatables-strings.inc' %]

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 9070: [SIGNED-OFF] authority searches in auth_finder error out
Jared Camins-Esakov [Tue, 13 Nov 2012 16:02:24 +0000 (11:02 -0500)]
Bug 9070: [SIGNED-OFF] authority searches in auth_finder error out

When using authority records imported into Koha from elsewhere, you
can get an error like:
    Can't use string ("HASH(0xbc6c{30)") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 363.
in authorities/auth_finder.pl. This patch fixes that error.

To test:
1) You will need records imported from elsewhere.
2) Use the authority control plugin in a bib record to search for one of
   those headings.
3) Observe you get a nasty error.
4) Apply patch.
5) Repeat step 2.
6) Observe the error is gone.
7) Sign off.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Works as advertised. No warning about "defined(%hash) is deprecated"
under perl v5.10.1.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 8971 - Sort holds queue report using DataTables
Owen Leonard [Thu, 25 Oct 2012 16:38:46 +0000 (12:38 -0400)]
Bug 8971 - Sort holds queue report using DataTables

Replacing the old tablesorter plugin with DataTables on
this page will fix sorting bugs related to whitespace and
markup in table cells which tablesorter couldn't handle.

I have also taken the liberty of changing the default sort
from patron to call number, assuming that the librarian
uses this list to pull items from the shelf, and the shelf
is organized by call number.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_9023' into 3.12-master
Jared Camins-Esakov [Tue, 20 Nov 2012 13:05:28 +0000 (08:05 -0500)]
Merge branch 'bug_9023' into 3.12-master

9 years agoBug 9023: Update installer text files
Katrin Fischer [Wed, 7 Nov 2012 14:21:17 +0000 (15:21 +0100)]
Bug 9023: Update installer text files

Corrected some information about the provided sample data and corrected
text files to obey capitalization rules.

To test:
I suggest taking a look at the patch file and also taking a look at the
English web installer, checking if it works, if there are typos or wrong
information.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 9023: Remove NY Z39.50 servers from installer txt files
Katrin Fischer [Wed, 7 Nov 2012 13:54:52 +0000 (14:54 +0100)]
Bug 9023: Remove NY Z39.50 servers from installer txt files

Broken Z39.50 targets were removed with patch for bug 3782, but are still
mentioned in the text files.

This patch corrects that mistake.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_9020' into 3.12-master
Jared Camins-Esakov [Tue, 20 Nov 2012 13:00:32 +0000 (08:00 -0500)]
Merge branch 'bug_9020' into 3.12-master

9 years agoBug 9020 - Translate new permissions for 3.10 nb-NO
Magnus Enger [Mon, 12 Nov 2012 11:00:44 +0000 (12:00 +0100)]
Bug 9020 - Translate new permissions for 3.10 nb-NO

To test:
- Apply the patch
- Check that installer/data/mysql/nb-NO/1-Obligatorisk/userpermissions.sql
  can be loaded into the DB without errors (you might have to do "DELETE
  FROM permissions" first)
- Check that there are no English strings when you edit the permissions
  of a patron

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 9020: [SIGNED-OFF] Translate new permissions for 3.10 de-DE
Katrin Fischer [Wed, 7 Nov 2012 13:01:49 +0000 (14:01 +0100)]
Bug 9020: [SIGNED-OFF] Translate new permissions for 3.10 de-DE

To test:
- Run the web installer in German
- Check that all permissions for a staff patron are translated

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
I did not do a complete install, but I:
- Applied the patch
- Loaded installer/data/mysql/de-DE/mandatory/userpermissions.sql
  into MySQL without any trouble
- Logged in to the staff client and found no untranslated permissions
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 8844: UNIMARC_sync_date_created_with_marc_biblio.pl creates a modification log
Fridolyn SOMERS [Fri, 28 Sep 2012 16:43:50 +0000 (18:43 +0200)]
Bug 8844: UNIMARC_sync_date_created_with_marc_biblio.pl creates a modification log

Signed-off by : Mathieu Saby <mathieu.saby@univ-rennes2.fr>

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_8975' into 3.12-master
Jared Camins-Esakov [Tue, 20 Nov 2012 12:42:48 +0000 (07:42 -0500)]
Merge branch 'bug_8975' into 3.12-master

9 years agoBug 8975 - search results should say on order in staff client
Owen Leonard [Fri, 2 Nov 2012 15:40:52 +0000 (11:40 -0400)]
Bug 8975 - search results should say on order in staff client

In order to allow holds on items with notforloan = -1, processing
of "unavailable" items in Search.pm was altered to exclude items
with notforloan < 0. (See Bug 2341: items marked 'on order' not
 reserveable from search results). Doing so meant that such items
were excluded from the list, in staff client search results, of
items which are unavailable.

This patch changes the logic of that processing so that items
with notforloan < 0 are considered unavailable, but can still
be placed on hold.

To test, edit a record with a single item and view that record
in search results. When the item is is on order (notforloan -1)
it should say so. The holds link should be INactive only if:

- item is withdrawn AND/OR
- item is lost AND/OR
- item is damaged (and AllowHoldsOnDamagedItems is off) AND/OR
- item is not for loan, with notforloan > 0

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
All tests pass (note that a reindex is required if changing item
statuses - which is why my first tests failed).

Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 7932 [Revised] Twitter share doesn't work with socialnetworks
Owen Leonard [Thu, 1 Nov 2012 15:21:37 +0000 (11:21 -0400)]
Bug 7932 [Revised] Twitter share doesn't work with socialnetworks

The only way I can get this to work consistently is to use
Twitter's own code as documented here:

https://dev.twitter.com/docs/tweet-button

This requires that we use the tweet button generated by Twitter
rather than the smaller image we were using before. Using the
documented options for generating a custom button produced the
same inconsistent behavior this patch attempts to fix.

Because of the change of appearance I moved the Twitter button
to last in line so that similarly-sized buttons were grouped. I
also changed the configuration of the Google+ button to exclude
the count, saving some horizontal space.

Revision removes explicit declaration of share URL. I think when
testing this previously I assumed it was required when in fact
the share URL wasn't working because it was a localhost address.

Localhost addresses are apparently rejected by Twitter. Testers
beware.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Passed-QA-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_9046' into 3.12-master
Jared Camins-Esakov [Tue, 20 Nov 2012 12:32:29 +0000 (07:32 -0500)]
Merge branch 'bug_9046' into 3.12-master

9 years agoBug 9046: Followup FIX perl v5.10 raises an error if itemnumbers if undefined
Jonathan Druart [Mon, 12 Nov 2012 09:18:30 +0000 (10:18 +0100)]
Bug 9046: Followup FIX perl v5.10 raises an error if itemnumbers if undefined

If the itemnumbers parameter is undef, perl raises an error :
"Can't use an undefined value as an ARRAY reference"

Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_7368' into 3.12-master
Jared Camins-Esakov [Tue, 20 Nov 2012 12:24:55 +0000 (07:24 -0500)]
Merge branch 'bug_7368' into 3.12-master

9 years agoBug 7368: Removing occurrences of dependant= feature in javascript open calls
Marcel de Rooy [Mon, 12 Nov 2012 12:17:04 +0000 (13:17 +0100)]
Bug 7368: Removing occurrences of dependant= feature in javascript open calls

The window feature dependant= should have been written as dependent=
Note that this feature is ignored in most/current browsers.
Since the feature was misspelled, removing it will not change any
behavior or hurt anybody.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Passed-QA-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_8997' into 3.12-master
Jared Camins-Esakov [Tue, 20 Nov 2012 12:20:23 +0000 (07:20 -0500)]
Merge branch 'bug_8997' into 3.12-master

9 years agoBug 8997: Unnecessary call to getAllLanguages
Paul Poulain [Wed, 31 Oct 2012 17:22:14 +0000 (18:22 +0100)]
Bug 8997: Unnecessary call to getAllLanguages

In C4/Language, getTranslatedLanguages calls getAllLanguage, passes it
to _build_languages_arrayref, that does nothing of it. Removing this
dead code will clean & reduce SQL overhead

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
I tried switching between languages and enabling and disabling
languages, and could not see any change with the patch applied.

Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_8880' into 3.12-master
Jared Camins-Esakov [Tue, 20 Nov 2012 12:19:17 +0000 (07:19 -0500)]
Merge branch 'bug_8880' into 3.12-master

9 years agoBug 8880 - Uninitialized variables trigger error log entries
Mark Tompsett [Fri, 5 Oct 2012 12:33:47 +0000 (20:33 +0800)]
Bug 8880 - Uninitialized variables trigger error log entries

Simply by logging in, clicking Circulation, clicking the
'Check out' link, error log entries were generated.

This patch ensures $findborrower, $barcode, and $print are all
initialized by adding "|| q{}" onto their initializations.
This reduces the silent error log entries generated.

As this patch would overlap with bug 8826 in the initialization
of hashes to prevent other error logs, those changes are in this
patch. Applying this patch without having applied the patch for
bug 8826.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 8750 - Chronological terms authorities not correctly indexed (trivial fix)
Tomas Cohen Arazi [Mon, 10 Sep 2012 18:27:53 +0000 (15:27 -0300)]
Bug 8750 - Chronological terms authorities not correctly indexed (trivial fix)

Patch re-done so it applies, had that double-utf8 problem

There was no entry in authority's record.abs for indexing chronological
terms. They couldn't be searched and (obviously) linked.

I've added those entries using the index names defined in
authorities/etc/bib1.att

Regards
To+

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Passed-QA-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_9058' into 3.12-master
Jared Camins-Esakov [Tue, 20 Nov 2012 12:02:00 +0000 (07:02 -0500)]
Merge branch 'bug_9058' into 3.12-master

9 years agoBug 9058 - Norwegian default for CalendarFirstDayOfWeek
Magnus Enger [Mon, 12 Nov 2012 11:16:48 +0000 (12:16 +0100)]
Bug 9058 - Norwegian default for CalendarFirstDayOfWeek

Sets a sensible default for CalendarFirstDayOfWeek in
installer/data/mysql/nb-NO/1-Obligatorisk/system_preferences.sql

To test:
- Do a complete web install in Norwegian
  OR
- Load installer/data/mysql/nb-NO/1-Obligatorisk/system_preferences.sql
  into MySQL from the command line
- Check that CalendarFirstDayOfWeek is set to 'Monday' and that
  calendars display Monday as the first day of the week.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_9107' into 3.12-master
Jared Camins-Esakov [Tue, 20 Nov 2012 11:57:38 +0000 (06:57 -0500)]
Merge branch 'bug_9107' into 3.12-master

9 years agoBug 9107: Increment version number
Jared Camins-Esakov [Tue, 20 Nov 2012 11:57:22 +0000 (06:57 -0500)]
Bug 9107: Increment version number

Database update for bug 9107 has been given version 3.09.00.066

9 years agoBug 9107: remove the syspref from the database, as well
Paul Poulain [Tue, 20 Nov 2012 10:44:18 +0000 (11:44 +0100)]
Bug 9107: remove the syspref from the database, as well

The syspref has been introduced during 3.9, so only a few libraries
should have it, but for consistency it must be removed.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 9107: Remove the obsolete DidYouMeanFromAuthorities syspref
Jared Camins-Esakov [Mon, 19 Nov 2012 16:29:30 +0000 (11:29 -0500)]
Bug 9107: Remove the obsolete DidYouMeanFromAuthorities syspref

Even though the DidYouMeanFromAuthorities syspref was replaced by a "Did
You Mean?" configuration page, the syspref was showing up in the
syspref editor on the Searching tab.

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 9046: FIX wrong test on an arrayref instead of an array
Jonathan Druart [Fri, 9 Nov 2012 17:34:40 +0000 (18:34 +0100)]
Bug 9046: FIX wrong test on an arrayref instead of an array

EmbedItemsInMarcBiblio does not embed items when the itemnumbers param
is given. That breaks the export tools (used from commandline).

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_9085' into 3.12-master
Jared Camins-Esakov [Tue, 20 Nov 2012 11:50:46 +0000 (06:50 -0500)]
Merge branch 'bug_9085' into 3.12-master

9 years agoBug 9085 - Installer will not run with DEBUG set
Chris Nighswonger [Wed, 14 Nov 2012 20:36:21 +0000 (15:36 -0500)]
Bug 9085 - Installer will not run with DEBUG set

This is due to raising all db errors combined with the fact that attempts
to make selections from a non-existent systempreferences table raises db errors.

The installer should run even with DEBUG set, otherwise dropping and recreating
a development database becomes somewhat of a chore. This patch adds code to
check for the existence of the systempreferece table. If the table exists, then
RaiseError is enabled on the database handle. Otherwise it is disabled to allow
the installer to run without throwing an error.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
The installer can now be run both with and without DEBUG set.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 9066: VirtualShelves db access not Plack+MariaDB compatible
Jared Camins-Esakov [Tue, 13 Nov 2012 14:25:42 +0000 (09:25 -0500)]
Bug 9066: VirtualShelves db access not Plack+MariaDB compatible

The $dbh database handle in C4::VirtualShelves was declared at the
module level, which means under Plack it is initialized only once, when
the server first starts. With the default MySQL configuration this is
not a problem, since the MySQL connection does not time out, but the
MariaDB default configuration does time out, resulting in every page
that calls any sub in C4::VirtualShelves failing after a certain period.
This patch eliminates the module-level $dbh variable and replaces it
with $dbh handles in each subroutine that requires it.

To test:
Confirm that Virtual Shelves functionality still works as expected. The
problem is not reproducible when using Apache or Plack+MySQL, but if
everything works after the patch has been applied, the changes are safe.

Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 8968 "Add to cart" translatable on OPAC result page
Frédéric Demians [Thu, 25 Oct 2012 08:07:54 +0000 (10:07 +0200)]
Bug 8968 "Add to cart" translatable on OPAC result page

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 7500 [Lists follow-up] Use CSS Sprites for faster page loading
Owen Leonard [Thu, 8 Nov 2012 17:19:05 +0000 (12:19 -0500)]
Bug 7500 [Lists follow-up] Use CSS Sprites for faster page loading

I just noticed there were a couple of instances where the lists
page referred to an image which was removed in a previous patch
for Bug 7500. This patch corrects it.

To test, edit a list in the OPAC. The breadcrumbs menu should
have no broken images.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge branch 'bug_6428' into 3.12-master
Jared Camins-Esakov [Tue, 13 Nov 2012 14:48:16 +0000 (09:48 -0500)]
Merge branch 'bug_6428' into 3.12-master