koha.git
10 years agoBug 6362: fixes display to re-embed items in OPAC MARC view
ruth@bywatersolutions.com [Tue, 24 May 2011 19:56:38 +0000 (15:56 -0400)]
Bug 6362: fixes display to re-embed items in OPAC MARC view

This patch is a followon to repair a side-effect of Bug 5579.  A
similar patch is already pushed to make this change for ISBD view.

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6350 - Keeping history page up to date
Chris Cormack [Thu, 2 Jun 2011 23:37:33 +0000 (11:37 +1200)]
Bug 6350 - Keeping history page up to date

10 years agoBug 6437: Added div with id yui-main around advsearch form
Elliott Davis [Tue, 31 May 2011 12:35:27 +0000 (07:35 -0500)]
Bug 6437: Added div with id yui-main around advsearch form

Testing: Make sure div shows up directly above form

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6380 - Z39.50 Cataloging Search needs a way to try search again, even if results...
Liz Rea [Fri, 20 May 2011 15:29:00 +0000 (10:29 -0500)]
Bug 6380 - Z39.50 Cataloging Search needs a way to try search again, even if results are found

This patch adds a nice button to the results page to "Try Another Search" even if results are found. It also makes the "no results found" try again link a proper button.

To test:
Do a search for something that will give results -- there should now be a button to "Try Another Search"

Do a search for something that returns no results -- The link for "Try Another Search" should now be a proper button.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
[EDIT: Form slightly changed in order to remember biblio and framework. Link is no official html method value btw.]

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6361 - make the packages work with koha 3.4
Robin Sheat [Thu, 19 May 2011 08:57:23 +0000 (20:57 +1200)]
Bug 6361 - make the packages work with koha 3.4

This commit does the following:
* Merge the changelog from the releases of 3.2
* Adds a command 'koha-upgrade-to-3.4' that does the MARC item splitting
  stuff.
* Adds a debconf note to make sure people know that they need to run
  the above command.
* Fixes the inclusion of jQuery in the packages.
* Makes build-git-snapshot build packages with a 3.5 version.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 5918 : Use the default messaging preferences if the user does not select any
Chris Cormack [Tue, 31 May 2011 22:34:02 +0000 (10:34 +1200)]
Bug 5918 : Use the default messaging preferences if the user does not select any

Signed-off-by: Jesse Weaver <pianohacker@gmail.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoMerge remote-tracking branch 'kc/new/bug_5683' into kcmaster
Chris Cormack [Wed, 1 Jun 2011 21:12:29 +0000 (09:12 +1200)]
Merge remote-tracking branch 'kc/new/bug_5683' into kcmaster

10 years agoFixing permissions, no need for this file to be executable
Chris Cormack [Wed, 1 Jun 2011 21:05:37 +0000 (09:05 +1200)]
Fixing permissions, no need for this file to be executable

10 years agoBug 5683 follow-up: calls to ModBiblio can still fail
Jared Camins-Esakov [Wed, 6 Apr 2011 12:58:07 +0000 (08:58 -0400)]
Bug 5683 follow-up: calls to ModBiblio can still fail

Because C4::Charset directly manipulates the MARC::Record object, bad data has
to be cleaned in ModBiblio before the call into C4::Charset. The corrupted
records can also break the Zebra index. After this fix has been applied, it
would probably be a good idea to run the misc/maintenance/touch_all_biblios.pl
script to ensure that this problem has been cleared up.

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoMerge remote-tracking branch 'kc/master' into new/bug_5683
Chris Cormack [Wed, 1 Jun 2011 21:02:50 +0000 (09:02 +1200)]
Merge remote-tracking branch 'kc/master' into new/bug_5683

10 years agoAdd unit tests to ensure bug 5683 doesn't reappear
Jared Camins-Esakov [Wed, 6 Apr 2011 14:07:29 +0000 (10:07 -0400)]
Add unit tests to ensure bug 5683 doesn't reappear

Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
10 years agoBug 6429 : Fixing numbering of developers
Chris Cormack [Mon, 30 May 2011 21:10:21 +0000 (09:10 +1200)]
Bug 6429 : Fixing numbering of developers

10 years ago6429: Sync history/about
Marcel de Rooy [Mon, 30 May 2011 12:14:03 +0000 (14:14 +0200)]
6429: Sync history/about

Adding new developers (including myself :-)
Adding Rijksmuseum.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years ago6429: Sync history/about
Marcel de Rooy [Mon, 30 May 2011 11:19:39 +0000 (13:19 +0200)]
6429: Sync history/about

Some initial corrections in history/about to improve syncing.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoUpdating about page
Chris Cormack [Sun, 29 May 2011 10:52:59 +0000 (22:52 +1200)]
Updating about page

10 years agoFix for Bug 6338 - Datepickers on OPAC hold form does not work
Owen Leonard [Wed, 11 May 2011 14:51:01 +0000 (10:51 -0400)]
Fix for Bug 6338 - Datepickers on OPAC hold form does not work

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoFix for Bug 6306 - It is not possible edit news
Owen Leonard [Fri, 20 May 2011 19:38:51 +0000 (15:38 -0400)]
Fix for Bug 6306 - It is not possible edit news

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6415: Can't make patron card batch
Katrin Fischer [Fri, 27 May 2011 05:46:06 +0000 (07:46 +0200)]
Bug 6415: Can't make patron card batch

TT corrections from bug 6343 for label creator were also needed for patron card creator.

- Manage Batch and New Batch were missing the branch info
- Add link on patron search was missing batch id parameter

To test:
- Check branch is correctly shown on pages 'Manage Batch' and 'New Batch'
- Check you can create a new batch and add names to it by using the 'Add'
right to the patron's name

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoFix for Bug 6408 - column alignment off on the patron categories admin
Owen Leonard [Wed, 25 May 2011 16:55:22 +0000 (12:55 -0400)]
Fix for Bug 6408 - column alignment off on the patron categories admin

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6365: Missing information about tab number when mandatory fields unfilled
Janusz Kaczmarek [Wed, 18 May 2011 16:19:28 +0000 (18:19 +0200)]
Bug 6365: Missing information about tab number when mandatory fields unfilled

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoFix for Bug 6364 - Display of item availability broken on OPAC detail screen
Owen Leonard [Wed, 18 May 2011 15:01:20 +0000 (11:01 -0400)]
Fix for Bug 6364 - Display of item availability broken on OPAC detail screen

Owen:

The markup for showing item availability has been moved to an include
file. The include lacked the scope declaration for the item results
loop. Adding the scope declaration to the include file means it can't
be used by other template unless within the same scope, but I'm not
aware of a better way to do it given the number of variables in use.

Frédéric:

I confirm the bug.

I propose a alternative solution which solve the bug and keep its
versability-reusability to the include file. With this solution, when including
item-status.inc, the foreach loop variable name, which can change from template
to template, is renamed by using a local variable definition: ie a variable
name specified after file name in the INCLUDE directive, this variable
temporalily masking any existing variable.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6347 - Fix for itemlevel holds in OPAC
Chris Cormack [Mon, 16 May 2011 21:23:52 +0000 (09:23 +1200)]
Bug 6347 - Fix for itemlevel holds in OPAC

Edits by Owen:

- More variable scope corrections
- Minor markup and style tweak
- Table column span correction

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
- Item level holds can be placed and hold saved
- Table and layout are ok now

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoFix for Bug 6300 - can't get to other pages of marc import
Owen Leonard [Wed, 11 May 2011 14:56:39 +0000 (10:56 -0400)]
Fix for Bug 6300 - can't get to other pages of marc import

T:T variable scope error.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoMerge remote-tracking branch 'kc/new/bug_6170' into kcmaster
Chris Cormack [Sun, 29 May 2011 01:56:32 +0000 (13:56 +1200)]
Merge remote-tracking branch 'kc/new/bug_6170' into kcmaster

10 years agoFollow-up fix for Bug 6170 'More options' in advanced search broken
Owen Leonard [Mon, 16 May 2011 19:42:12 +0000 (15:42 -0400)]
Follow-up fix for Bug 6170 'More options' in advanced search broken

Simplifying markup in the staff client advanced search:

- Moving IDs to fieldsets and removing redundant divs
- Removing unused section
- Adding missing IDs and fieldsets

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoFix for Bug 6417 - Template variable errors in Guided Reports
Owen Leonard [Wed, 25 May 2011 16:52:23 +0000 (12:52 -0400)]
Fix for Bug 6417 - Template variable errors in Guided Reports

Looks like the T:T conversion script missed these instances
of TMPL markup because they had line breaks:

<!-- TMPL_VAR
NAME="name" -->

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoFix for Bug 6332, Hold forms missing 'clear date' link
Owen Leonard [Fri, 13 May 2011 15:11:46 +0000 (11:11 -0400)]
Fix for Bug 6332, Hold forms missing 'clear date' link

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoFix for Bug 5020 - on patron record sex should be gender
Owen Leonard [Tue, 24 May 2011 17:00:29 +0000 (13:00 -0400)]
Fix for Bug 5020 - on patron record sex should be gender

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoFix for Bug 6378 - Misaligned columns on tags approval page
Owen Leonard [Fri, 20 May 2011 14:48:13 +0000 (10:48 -0400)]
Fix for Bug 6378 - Misaligned columns on tags approval page

T:T variable scope correction.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBUG6091 Remove undeclared syspref OPACAdvSearchInputCount
Fridolyn SOMERS [Wed, 6 Apr 2011 14:04:55 +0000 (16:04 +0200)]
BUG6091 Remove undeclared syspref OPACAdvSearchInputCount

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoAdd entries so Z39.50 public server works
Tomas Cohen Arazi [Wed, 30 Mar 2011 14:38:42 +0000 (11:38 -0300)]
Add entries so Z39.50 public server works

I added a comment on the file so the user uncomments the appropriate koha-conf.xml sections.

To+

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6342 Help link doesn't popup anymore contextual help page
Frédéric Demians [Sun, 15 May 2011 05:23:03 +0000 (07:23 +0200)]
Bug 6342 Help link doesn't popup anymore contextual help page

Fix help.pl script to deal with Template Toolkit.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoFix for Bug 6370 - news showing that it's for the opac when it's for the librarian...
Owen Leonard [Fri, 20 May 2011 19:22:11 +0000 (15:22 -0400)]
Fix for Bug 6370 - news showing that it's for the opac when it's for the librarian interface

T:T variable scope error.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6351: Unable to delete branch-specific circulation rule
D Ruth Bavousett [Tue, 17 May 2011 15:45:48 +0000 (11:45 -0400)]
Bug 6351: Unable to delete branch-specific circulation rule

The URL on the page did not have a branchcode, so the delete failed silently, and
returned the user to the "All" rules page.  Turns out, the array for the rules was
not being populated with the branchcode!

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoMerge remote-tracking branch 'kc/new/enh/bug_5579' into kcmaster
Chris Cormack [Fri, 27 May 2011 08:28:12 +0000 (20:28 +1200)]
Merge remote-tracking branch 'kc/new/enh/bug_5579' into kcmaster

10 years agoBug 5579: further fancifying remove_items_from_biblioitems.pl
ruth@bywatersolutions.com [Tue, 24 May 2011 19:56:13 +0000 (15:56 -0400)]
Bug 5579: further fancifying remove_items_from_biblioitems.pl

This patch adds a progress indicator to remove_items_from_biblioitems.pl, with
the user option of silencing it with --silent.

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6340: Pagination bar on guided reports result page broken
Katrin Fischer [Sat, 14 May 2011 10:36:25 +0000 (12:36 +0200)]
Bug 6340: Pagination bar on guided reports result page broken

The pagination on the guided reports page was not showing up.
TT problem.

To test:
Add a sql report with more than 20 results.
Example: select * from borrowers
Without the patch, only the first 20 results will show and no pagination bar.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6258 - Guided reports wizard 'Build new' brings up empty page
Liz Rea [Fri, 20 May 2011 19:41:20 +0000 (14:41 -0500)]
Bug 6258 - Guided reports wizard 'Build new' brings up empty page

Patch fixes a TT error that caused Build New to be empty.

To test:
Click More -> Reports, you should see the welcome page and be able to step through creating the report.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoFix for Bug 3140 - It is possible to email someone else's private list
Owen Leonard [Tue, 17 May 2011 15:07:03 +0000 (11:07 -0400)]
Fix for Bug 3140 - It is possible to email someone else's private list

Adding check for ShelfPossibleAction("view") to make sure the logged
in user has permission to view the selected list when downloading
or emailing a list.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoFix for Bug 6395, Cannot create routing list
Owen Leonard [Tue, 24 May 2011 19:15:18 +0000 (15:15 -0400)]
Fix for Bug 6395, Cannot create routing list

Some old TMPL tags got left behind.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6343: TT issues in label creator
Katrin Fischer [Fri, 20 May 2011 19:14:56 +0000 (21:14 +0200)]
Bug 6343: TT issues in label creator

- Manage Batch had no branch set
- New Batch had no branch set
- Add link on item result list was broken, missing the batchid

To test:
Create a new batch and add items one by one. Look at 'Manage batches'.
Check that the branch in the top right corner is always correctly shown and set.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
10 years agoBug 5658 can't delete subfields in frameworks
Fridolyn SOMERS [Mon, 23 May 2011 13:07:28 +0000 (09:07 -0400)]
Bug 5658 can't delete subfields in frameworks

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6401 fix to the history file
ruth@bywatersolutions.com [Tue, 24 May 2011 19:57:08 +0000 (15:57 -0400)]
Bug 6401 fix to the history file

This patch adds Ian Walls' name to the history file, so he can be found.

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 3580 Sort the facets categories so they don't move every search.
Frédérick Capovilla [Thu, 24 Feb 2011 17:30:09 +0000 (12:30 -0500)]
Bug 3580 Sort the facets categories so they don't move every search.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6350 : Updating history docs
Chris Cormack [Tue, 17 May 2011 03:36:01 +0000 (15:36 +1200)]
Bug 6350 : Updating history docs

http://bugs.koha-community.org/show_bug.cgi?id=6350
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoFix for bug 6367 - 'Preview MARC' hover button does not show correct MARC record
Owen Leonard [Wed, 18 May 2011 18:05:47 +0000 (14:05 -0400)]
Fix for bug 6367 - 'Preview MARC' hover button does not show correct MARC record

Misplaced line of JavaScript meant that the menu always grabbed
the ID of the last item in the search results.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoImprove error message when translation installation fails
Frédéric Demians [Wed, 18 May 2011 05:23:21 +0000 (07:23 +0200)]
Improve error message when translation installation fails

For Translator Manager (myself...). A translation installation may fail because
translator hasn't enter properly string parameters (%s). With this patch, the
message ID is displayed not only the parameter.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug #6131 - change index "Author-name-personal" for "Personal-name"
Alex Arnaud [Fri, 13 May 2011 14:19:09 +0000 (16:19 +0200)]
Bug #6131 - change index "Author-name-personal" for "Personal-name"

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6320 - Provide language filter selection in adv an id inside a div
Tomas Cohen Arazi [Fri, 6 May 2011 17:11:17 +0000 (14:11 -0300)]
Bug 6320 - Provide language filter selection in adv an id inside a div

Basically, put the language filter selection fieldset inside a <div> with its
own id so it can be hidden through OPACUserCSS variable.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6315: Fix depreciated constructions in C4::Serials
Colin Campbell [Fri, 6 May 2011 11:50:39 +0000 (12:50 +0100)]
Bug 6315: Fix depreciated constructions in C4::Serials

Perl 5.14 will issue warnings in cases where it is assumed that
() will magically appear around qw() as the interpreter
will stop fooling itself that they are there
Added the missing () in the couple of cases they were required

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoMerge remote-tracking branch 'kc/new/bug_6312' into kcmaster
Chris Cormack [Sun, 15 May 2011 08:38:00 +0000 (20:38 +1200)]
Merge remote-tracking branch 'kc/new/bug_6312' into kcmaster

10 years agoBug 6312: Remove references to login being OPAC only
Nicole C. Engard [Thu, 5 May 2011 16:25:29 +0000 (12:25 -0400)]
Bug 6312: Remove references to login being OPAC only

This patch changes the 'opac login' label to read 'username'
since it can be used in the staff client and the opac

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6218: patron gets dot added if no first name
conan (aka Fernando Canizo) [Wed, 20 Apr 2011 20:04:37 +0000 (17:04 -0300)]
Bug 6218: patron gets dot added if no first name

Trivial fix, now it choose surname if firstname is empty and behaves
like before (firstname.surname) if both are provided.

Signed-off-by: Frederic Demians <frederic@tamil.fr>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6152: Document DOM authority index config
Jared Camins-Esakov [Sat, 9 Apr 2011 15:29:07 +0000 (11:29 -0400)]
Bug 6152: Document DOM authority index config

Add a note so developers know not to edit authority-zebra-indexdefs.xsl directly
but to instead edit authority-koha-indexdefs.xml and use the
koha-indexdefs-to-zebra.xsl stylesheet to generate the former from the latter.

Signed-off-by: Frederic Demians <frederic@tamil.fr>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 5995 : MT2892: Fix security issue in CAS intranet login
Matthias Meusburger [Fri, 5 Feb 2010 11:00:15 +0000 (12:00 +0100)]
Bug 5995 : MT2892: Fix security issue in CAS intranet login

Users could log in intranet using their cardnumber, with superlibrarian
rights.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6330 - Change hold language from 'until' to 'since'
Nicole C. Engard [Wed, 11 May 2011 19:46:29 +0000 (15:46 -0400)]
Bug 6330 - Change hold language from 'until' to 'since'

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoFix for Bug 6284, Reports Filters Need Prettying
Owen Leonard [Sat, 30 Apr 2011 02:01:49 +0000 (22:01 -0400)]
Fix for Bug 6284, Reports Filters Need Prettying

1. Moved the form to the left under the menu
2. Added a calendar next to date (and a date format tip)
3. Styled the form like other filter forms for consistency's sake
4. Formatted on-screen message to match standard style

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6320 Generate Next button doesn't generate next issue
Frédéric Demians [Tue, 10 May 2011 17:25:05 +0000 (13:25 -0400)]
Bug 6320 Generate Next button doesn't generate next issue

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoFix for Bug 6295 - misaligned columns in opac suggestions list
Owen Leonard [Tue, 10 May 2011 17:09:38 +0000 (13:09 -0400)]
Fix for Bug 6295 - misaligned columns in opac suggestions list

Template variable scope error.

NOTE: this bug only applies when OPACViewOthersSuggestions is turned on; otherwise there is nothing to fix.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6308 - Show number of comments - new patch
Magnus Enger [Tue, 10 May 2011 16:48:09 +0000 (12:48 -0400)]
Bug 6308 - Show number of comments - new patch

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoMerge remote-tracking branch 'kc/new/bug_5449' into kcmaster
Chris Cormack [Sun, 8 May 2011 20:25:36 +0000 (08:25 +1200)]
Merge remote-tracking branch 'kc/new/bug_5449' into kcmaster

10 years agoBug 6294: {BIBLIONUMBER} parsing for SearchForTitleIn
Ian Walls [Tue, 3 May 2011 15:37:46 +0000 (11:37 -0400)]
Bug 6294: {BIBLIONUMBER} parsing for SearchForTitleIn

Adds support for parsing of the biblionumber into the SearchForTitleIn system preference, allowing
external sites with APIs (like Facebook or Twitter) to do link-backs to the details page for the
title.

Sample code for implementing Facebook "like" links and Twitter "tweet this" are included on the bug report

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6031 : Fix for syntax (bashism crept into a pure sh script)
Chris Cormack [Mon, 2 May 2011 00:39:35 +0000 (12:39 +1200)]
Bug 6031 : Fix for syntax (bashism crept into a pure sh script)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6282: HomeOrHoldingBranchReturn missing from pref file
Colin Campbell [Thu, 28 Apr 2011 15:47:07 +0000 (16:47 +0100)]
Bug 6282: HomeOrHoldingBranchReturn missing from pref file

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoFixing a template error
Chris Cormack [Thu, 28 Apr 2011 23:39:18 +0000 (11:39 +1200)]
Fixing a template error

10 years agoRewriting the valid templates test to test template toolkit
Chris Cormack [Thu, 28 Apr 2011 23:33:19 +0000 (11:33 +1200)]
Rewriting the valid templates test to test template toolkit

10 years agoMerge remote branch 'kc/new/enh/bug_6033' into kcmaster
Chris Cormack [Thu, 28 Apr 2011 21:34:58 +0000 (09:34 +1200)]
Merge remote branch 'kc/new/enh/bug_6033' into kcmaster

10 years agoBug 6033 : Follow up fix for bug that crept in with conversion to template toolkit
Chris Cormack [Thu, 28 Apr 2011 21:33:35 +0000 (09:33 +1200)]
Bug 6033 : Follow up fix for bug that crept in with conversion to template toolkit

10 years agoBug 6265: Authority search in OPAC not exact
Katrin Fischer [Mon, 25 Apr 2011 19:55:40 +0000 (21:55 +0200)]
Bug 6265: Authority search in OPAC not exact

The search for linked records from the full heading page was not exact.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6001 : batchRebuildBiblioTables.pl doesn't crash anymore when GetMarcBiblio fails...
Matthias Meusburger [Thu, 1 Apr 2010 14:07:25 +0000 (16:07 +0200)]
Bug 6001 : batchRebuildBiblioTables.pl doesn't crash anymore when GetMarcBiblio fails. Unprocessed biblionumbers are displayed at the end of the execution instead.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoMerge remote branch 'kc/new/enh/bug_6143' into kcmaster
Chris Cormack [Thu, 28 Apr 2011 20:55:19 +0000 (08:55 +1200)]
Merge remote branch 'kc/new/enh/bug_6143' into kcmaster

10 years agoFollow Up for Bug 6143: New numSearchRSSResults preferences
Nicole C. Engard [Thu, 28 Apr 2011 16:31:06 +0000 (12:31 -0400)]
Follow Up for Bug 6143: New numSearchRSSResults preferences

This patch updates the language in the pref file to match the format
used in other areas of the preferences by making the preference value
part of a sentence.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 5509 - use an XML parser to get values from config
Robin Sheat [Thu, 16 Dec 2010 05:05:43 +0000 (18:05 +1300)]
Bug 5509 - use an XML parser to get values from config

Using sed and regex was causing issues when LDAP connection details were
added.

See
http://stackoverflow.com/questions/1732348/regex-match-open-tags-except-xhtml-self-contained-tags/1732454#1732454
for more information.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6033 : Template changes
Chris Cormack [Wed, 27 Apr 2011 23:26:42 +0000 (11:26 +1200)]
Bug 6033 : Template changes

10 years agoBug 6033 : wr77488 : report selection filter
Srdjan Jankovic [Wed, 6 Apr 2011 02:56:45 +0000 (14:56 +1200)]
Bug 6033 : wr77488 : report selection filter

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 3543: split NLM call numbers in label creator
Jared Camins-Esakov [Wed, 13 Apr 2011 14:03:03 +0000 (10:03 -0400)]
Bug 3543: split NLM call numbers in label creator

Split NLM call numbers using the same rules as those used for Library of
Congress call numbers.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6259: AllowHoldPolicyOverride causes every hold to need override
Ian Walls [Mon, 25 Apr 2011 22:30:22 +0000 (18:30 -0400)]
Bug 6259: AllowHoldPolicyOverride causes every hold to need override

Adds a check to make sure that the item is actually unavailable before requiring the override

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 5445: Nicer breadcrumbs when ordering from different sources
Katrin Fischer [Mon, 25 Apr 2011 22:27:34 +0000 (18:27 -0400)]
Bug 5445: Nicer breadcrumbs when ordering from different sources

Replaces previous patch. Also fixes ordering from existing records.

While it was possible to go back to vendor and basket page when ordering
from a new suggestion the other odering options missed those 'crumbs'.

This patch makes the breadcrumbs for all orderings options consistent and
makes it possible to navigate back to the vendor or basket from all
pages.

- from existing record
- from staged record
- from external source
- from empty record

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6143 : Fixing missing sysprefs
Chris Cormack [Tue, 26 Apr 2011 10:28:09 +0000 (22:28 +1200)]
Bug 6143 : Fixing missing sysprefs

10 years agoBumping the database number
Chris Cormack [Tue, 26 Apr 2011 08:51:37 +0000 (20:51 +1200)]
Bumping the database number

10 years agoBug #6143 - New feature: capability to limit the RSS results
Stéphane Delaune [Mon, 11 Apr 2011 12:04:36 +0000 (14:04 +0200)]
Bug #6143 - New feature: capability to limit the RSS results

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 3202: creating new 'child' categorytype patrons doesn't set branch properly
Ian Walls [Thu, 21 Apr 2011 04:46:34 +0000 (00:46 -0400)]
Bug 3202: creating new 'child' categorytype patrons doesn't set branch properly

If a guarantor search is not being performed, the creation of any Child category_type patron will
not default to the currently logged in branch, but rather the first branch alphabetically.

Adding a test for the existence of any guarantor branch data before assigning it clears up this problem

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6153: Display imprint subfields in order
Jared Camins-Esakov [Sun, 10 Apr 2011 21:32:26 +0000 (17:32 -0400)]
Bug 6153: Display imprint subfields in order

Prior to this patch, the imprint (field 260) was displayed out-of-order on the
MARC21 XSLT record detail page. For example, the following data:
=260  \\$aNew York :$bHarper,$c2003$g(2005 printing)
Displayed as:
Harper, New York : 2003 (2005 printing)
Instead of:
New York : Harper, 2003 (2005 printing)

Even more problematically, the following data:
=260  \\$a[S.l. :$bs.n.],$c1860.
Displayed as:
s.n.], [S.l. : 1860
Instead of:
[S.l. : s.n.], 1860.

This patch changes the MARC21 OPAC Details display to display the imprint
subfields in the proper order (as the Results display already does).

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6194 Suppress punctuation when no location
Colin Campbell [Mon, 18 Apr 2011 03:35:21 +0000 (23:35 -0400)]
Bug 6194 Suppress punctuation when no location

Template was showing empty parentheses when no location
data was present. Punctuation should be dependent on
the variable being set

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6257: Fix broken MARC documentation links
Katrin Fischer [Sun, 24 Apr 2011 15:58:45 +0000 (17:58 +0200)]
Bug 6257: Fix broken MARC documentation links

Another TT issue.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6263: shelf browser broken in 3.4
Katrin Fischer [Mon, 25 Apr 2011 16:35:28 +0000 (12:35 -0400)]
Bug 6263: shelf browser broken in 3.4

Another problem with TT.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoMove nb-NO-i-staff-prog-v-3002000.po -> nb-NO-i-staff-t-prog-v-3002000.po
Magnus Enger [Mon, 25 Apr 2011 09:34:04 +0000 (11:34 +0200)]
Move nb-NO-i-staff-prog-v-3002000.po -> nb-NO-i-staff-t-prog-v-3002000.po

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6228: Show active currency in system preferences
Katrin Fischer [Mon, 25 Apr 2011 09:25:13 +0000 (11:25 +0200)]
Bug 6228: Show active currency in system preferences

Some system preferences like maxoutstanding should show the
active currency behind the value. The code for this was not
translated to Template Toolkit.

Will change strings, so probably for 3.4.1

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoFix for Bug 2941 Transfers cannot be canceled once initiated
Owen Leonard [Fri, 22 Apr 2011 20:57:38 +0000 (16:57 -0400)]
Fix for Bug 2941 Transfers cannot be canceled once initiated

This patch includes the changes by Catalyst found at
http://git.catalyst.net.nz/gw?p=koha.git;a=shortlog;h=refs/heads/bug_2941
and adds a "cancel transfer" link to the transferstoreceive
script, including a redirect check to send the user back to
that report.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agohistory.txt updates for April 2011 releases
Galen Charlton [Fri, 22 Apr 2011 14:23:05 +0000 (10:23 -0400)]
history.txt updates for April 2011 releases

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoAdd missing library to release notes
Nicole C. Engard [Fri, 22 Apr 2011 14:20:08 +0000 (10:20 -0400)]
Add missing library to release notes

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoUpdate ALL Koha translation files v3.04.00
Frédéric Demians [Fri, 22 Apr 2011 08:37:54 +0000 (10:37 +0200)]
Update ALL Koha translation files

10 years agotextual improvements to release notes
Galen Charlton [Fri, 22 Apr 2011 02:42:42 +0000 (22:42 -0400)]
textual improvements to release notes

* typo and usage improvements
* alphabetize sponsoring libraries

Thanks to Brendan Gallagher for suggestions.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBumping version number for release
Chris Cormack [Fri, 22 Apr 2011 01:27:37 +0000 (13:27 +1200)]
Bumping version number for release

10 years agoFixing typo in the release notes
Chris Cormack [Thu, 21 Apr 2011 23:31:44 +0000 (11:31 +1200)]
Fixing typo in the release notes

10 years agoBug 6251: Acq: receiving orders
Katrin Fischer [Thu, 21 Apr 2011 22:48:19 +0000 (00:48 +0200)]
Bug 6251: Acq: receiving orders

- numbered pagination links are broken, previous and next work
- link to order line missing supplier id

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6250: Link to order in uncertain prices list broken
Katrin Fischer [Thu, 21 Apr 2011 22:06:08 +0000 (00:06 +0200)]
Bug 6250: Link to order in uncertain prices list broken

Missing URL parameter.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6249: Can't order accepted suggestions
Katrin Fischer [Thu, 21 Apr 2011 21:55:56 +0000 (23:55 +0200)]
Bug 6249: Can't order accepted suggestions

Order link was missing URL parameters.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6248: Acq: order from staged marc file broken
Katrin Fischer [Thu, 21 Apr 2011 21:10:26 +0000 (23:10 +0200)]
Bug 6248: Acq: order from staged marc file broken

Corrects missing parameters in urls for
- single order from staged marc file
- bulk order from staged marc file

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
10 years agoBug 6247: Acq: order already existing record broken
Katrin Fischer [Thu, 21 Apr 2011 20:44:16 +0000 (22:44 +0200)]
Bug 6247: Acq: order already existing record broken

Another URL missing parameters.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>