koha.git
11 years agoBug 4817: Point to README.Debian in koha package description, postinst output.
Lars Wirzenius [Thu, 27 May 2010 04:42:41 +0000 (16:42 +1200)]
Bug 4817: Point to README.Debian in koha package description, postinst output.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoWhitespace removal, removal of U+FEFF character
Owen Leonard [Wed, 26 May 2010 18:32:41 +0000 (14:32 -0400)]
Whitespace removal, removal of U+FEFF character

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoAdded "dialog alert" class to "No Results Found" message on the patron
Cindy Murdock Ames [Wed, 26 May 2010 16:56:26 +0000 (12:56 -0400)]
Added "dialog alert" class to "No Results Found" message on the patron
search so the alert stands out.  Previously no css was applied to it so
it was just plain text.  Librarians weren't noticing it.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years ago(MT #2565) fix aqplan csv export, and turn off debug
Nahuel ANGELINETTI [Wed, 26 May 2010 14:06:45 +0000 (16:06 +0200)]
(MT #2565) fix aqplan csv export, and turn off debug

This fix the csv export that doesn't export correctly the budget name, it's empty column.
And it turn off some SQL debug that slow down the result of the page and the csv export.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4508: fix crash when editing patron attributes or message prefs
Galen Charlton [Wed, 26 May 2010 14:51:09 +0000 (10:51 -0400)]
bug 4508: fix crash when editing patron attributes or message prefs

When editing patron attributes or messaging preferences on the
patron editor, Koha would crash with the following error:

Software error:
Can't use an undefined value as an ARRAY reference at
/home/koha/kohaclone/C4/SQLHelper.pm line 186.

This would occur only when editing the specific attribute
or message preferences section, not when editing the entire
patron record.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoSet upload target to squeeze-dev.
Lars Wirzenius [Wed, 26 May 2010 06:52:58 +0000 (18:52 +1200)]
Set upload target to squeeze-dev.

Since we're uploading a git snapshot, this is not meant for
production, and thus it should not be uploaded to squeeze,
but for squeeze-dev.

Documentation for the pockets will appear in the apt
repository or the wiki once it is ready.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoUpdate README.Debian for koha-common with post-install setup.
Lars Wirzenius [Wed, 26 May 2010 06:53:00 +0000 (18:53 +1200)]
Update README.Debian for koha-common with post-install setup.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoUpdate README.Debian for koha.deb package.
Lars Wirzenius [Wed, 26 May 2010 06:53:01 +0000 (18:53 +1200)]
Update README.Debian for koha.deb package.

One bug fix (three steps, not two, are automated in koha-post-install-setup).
Also add a note about the need to possibly edit ports.conf.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoUse a native Debian package.
Lars Wirzenius [Wed, 26 May 2010 06:52:57 +0000 (18:52 +1200)]
Use a native Debian package.

Since the packaging is part of the upstream source, there's no point
in having a Debian version.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoAdd dependency on apache2-mpm-itk for koha-common.
Lars Wirzenius [Wed, 26 May 2010 06:52:59 +0000 (18:52 +1200)]
Add dependency on apache2-mpm-itk for koha-common.

The way things are set up, each Koha instance runs under its own
user account. At least for now, this requires apache2-mpm-itk.
Later we can investigate other possibilities.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoMake sure the temporary version number comes before 3.2.
Lars Wirzenius [Wed, 26 May 2010 04:18:34 +0000 (16:18 +1200)]
Make sure the temporary version number comes before 3.2.

This way, upgrades from the temporary ones to the final release
will happen automatically.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4816: require authentication for placerequest.pl
Galen Charlton [Wed, 26 May 2010 03:27:20 +0000 (23:27 -0400)]
bug 4816: require authentication for placerequest.pl

Otherwise, it was possible to construct a URL to place
hold requests without authorization.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4386: fix email hold filled notifications
Galen Charlton [Wed, 26 May 2010 03:27:21 +0000 (23:27 -0400)]
bug 4386: fix email hold filled notifications

Call to GetMembers() was using the old parameter style.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoremoved needless imports of the YAML module
Galen Charlton [Tue, 25 May 2010 21:32:19 +0000 (17:32 -0400)]
removed needless imports of the YAML module

Removed instances of 'use YAML' that were either completely
unnecessary or which were used only in debug code.  Also
removed a needless import of Data::Dumper.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 4199: Adds ability to print routing slip. Patch 2.
Garry Collum [Sat, 22 May 2010 19:01:20 +0000 (15:01 -0400)]
Bug 4199: Adds ability to print routing slip. Patch 2.

Previous patch added an invalid XHTML element.  This patch fixes it.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 4199: Adds ability to print routing slip from serials-collection.
Garry Collum [Sat, 22 May 2010 18:54:46 +0000 (14:54 -0400)]
Bug 4199: Adds ability to print routing slip from serials-collection.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 4805: Fixes multiple subscriptionid's being passed to serials-collection.
Garry Collum [Sun, 23 May 2010 23:55:26 +0000 (19:55 -0400)]
Bug 4805: Fixes multiple subscriptionid's being passed to serials-collection.

This is a replacement patch for my previous patch.

This patch insures that only unique subscriptionids are defined in the serials-edit form.  Multiple ids are passed to serials-collection, but not multiple copies of the same id.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agofix another link to koha-community.org
Galen Charlton [Tue, 25 May 2010 19:23:49 +0000 (15:23 -0400)]
fix another link to koha-community.org

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agofix a common "developement" typo
Galen Charlton [Tue, 25 May 2010 18:38:38 +0000 (14:38 -0400)]
fix a common "developement" typo

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4377: ensure HOLD_PRINT letter added during installation and upgrade (DBrev 135)
Galen Charlton [Tue, 25 May 2010 16:36:03 +0000 (12:36 -0400)]
bug 4377: ensure HOLD_PRINT letter added during installation and upgrade (DBrev 135)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4311: respect OPACXSLTResultsDisplay
Galen Charlton [Tue, 25 May 2010 15:00:29 +0000 (11:00 -0400)]
bug 4311: respect OPACXSLTResultsDisplay

Check OPACXSLTResultsDisplay instead of XSLTResultsDisplay when
determining whether to use the XSLT bib results stylesheet for
OPAC search results.

In the process, added a new $search_context parameter to
C4::Search::searchResults() to specify whether results
are to be served up for the staff interface or for the
OPAC.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4018: remove duplicate unAPI link when XSLT bib details display on
Galen Charlton [Tue, 25 May 2010 13:21:24 +0000 (09:21 -0400)]
bug 4018: remove duplicate unAPI link when XSLT bib details display on

The unAPI link is now added only in opac-detail.tmpl.  More than
one unAPI link in the same page was causing a bit of indigestion
for Zotero, which interprets multiple unAPI links as specifying
more than one resource on a given page.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoInstall the admin scripts.
Lars Wirzenius [Tue, 25 May 2010 01:44:27 +0000 (13:44 +1200)]
Install the admin scripts.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoMake koha-create be able to handle manual database creation.
Lars Wirzenius [Tue, 25 May 2010 01:44:26 +0000 (13:44 +1200)]
Make koha-create be able to handle manual database creation.

This is necessary if we do not have access to DB server with sufficient
permissions. The DB server is used for other things, that may well be
the case.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoAdd support for a remote mysql server.
Lars Wirzenius [Tue, 25 May 2010 01:44:25 +0000 (13:44 +1200)]
Add support for a remote mysql server.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoUse /etc/mysql/koha-common.cnf instead of the Debian one.
Lars Wirzenius [Tue, 25 May 2010 01:44:24 +0000 (13:44 +1200)]
Use /etc/mysql/koha-common.cnf instead of the Debian one.

koha-common.postinst now creates a symlink to the Debian one.
The sysadmin may replace that manually with something that allows
Koha to access a remote mysql server.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoAdd koha-foreach, a script to run a command for each Koha instance.
Lars Wirzenius [Tue, 25 May 2010 01:44:22 +0000 (13:44 +1200)]
Add koha-foreach, a script to run a command for each Koha instance.

Use script to enable the build_Holds_queue.pl cron job.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoCentralize creation of Koha instance dirs.
Lars Wirzenius [Tue, 25 May 2010 01:44:21 +0000 (13:44 +1200)]
Centralize creation of Koha instance dirs.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoAdd scripts to start, stop, restart Zebra, and rebuild its indexes.
Lars Wirzenius [Tue, 25 May 2010 01:44:20 +0000 (13:44 +1200)]
Add scripts to start, stop, restart Zebra, and rebuild its indexes.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoAdd koha-upgrade-schema, a script to upgrade the database schema.
Lars Wirzenius [Tue, 25 May 2010 01:44:19 +0000 (13:44 +1200)]
Add koha-upgrade-schema, a script to upgrade the database schema.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoAdd koha-dump-defaults, a script to dump a defaults file.
Lars Wirzenius [Tue, 25 May 2010 01:44:18 +0000 (13:44 +1200)]
Add koha-dump-defaults, a script to dump a defaults file.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoAdd koha-reset-passwd, a script for resetting a user's password.
Lars Wirzenius [Tue, 25 May 2010 01:44:17 +0000 (13:44 +1200)]
Add koha-reset-passwd, a script for resetting a user's password.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoAdd koha-enable, a script to re-enable a Koha instance.
Lars Wirzenius [Tue, 25 May 2010 01:44:16 +0000 (13:44 +1200)]
Add koha-enable, a script to re-enable a Koha instance.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoAdd koha-disable, a script to disable a Koha instance.
Lars Wirzenius [Tue, 25 May 2010 01:44:15 +0000 (13:44 +1200)]
Add koha-disable, a script to disable a Koha instance.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoAdd koha-restore, a script to restore a Koha instance from a dump.
Lars Wirzenius [Tue, 25 May 2010 01:44:14 +0000 (13:44 +1200)]
Add koha-restore, a script to restore a Koha instance from a dump.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoAdd koha-list, a script to list all Koha instances.
Lars Wirzenius [Tue, 25 May 2010 01:44:13 +0000 (13:44 +1200)]
Add koha-list, a script to list all Koha instances.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoAdd koha-dump, a script to dump a Koha site.
Lars Wirzenius [Tue, 25 May 2010 01:44:12 +0000 (13:44 +1200)]
Add koha-dump, a script to dump a Koha site.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoAdd koha-remove, a script to remove a Koha instance.
Lars Wirzenius [Tue, 25 May 2010 01:44:11 +0000 (13:44 +1200)]
Add koha-remove, a script to remove a Koha instance.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoAdd koha-create, a script to create a new Koha instance.
Lars Wirzenius [Tue, 25 May 2010 01:44:10 +0000 (13:44 +1200)]
Add koha-create, a script to create a new Koha instance.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoAdd koha-post-install-setup, a script to be run by sysadmin post-install.
Lars Wirzenius [Tue, 25 May 2010 01:44:09 +0000 (13:44 +1200)]
Add koha-post-install-setup, a script to be run by sysadmin post-install.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoReplace dependencies on koha-dev-env with list of packages.
Lars Wirzenius [Tue, 25 May 2010 01:44:08 +0000 (13:44 +1200)]
Replace dependencies on koha-dev-env with list of packages.

The dependencies are needed both at build time and at run time. Build
time needs them for running tests. To avoid duplicating the (long!)
list of dependencies, we do a little bit of trickery, and generate
a koha:Depends substvar, from all build dependencies (except debhelper),
and use ${koha:Depends} in the koha-common (not koha) Depends header.
A little bit tricky, but works.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoSplit off koha-common.
Lars Wirzenius [Tue, 25 May 2010 01:44:07 +0000 (13:44 +1200)]
Split off koha-common.

koha-common will be suitable for hosts with multiple Koha instances,
or those that otherwise need to do thing differently from the main
koha package.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoSet version number in debian/changelog to indicate upcoming 3.2.
Lars Wirzenius [Tue, 25 May 2010 01:44:06 +0000 (13:44 +1200)]
Set version number in debian/changelog to indicate upcoming 3.2.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoConvert debian/copyright file to the DEP5 format.
Lars Wirzenius [Tue, 25 May 2010 01:44:05 +0000 (13:44 +1200)]
Convert debian/copyright file to the DEP5 format.

The DEP5 format is machine-parseable, which will help keep track of
things in the future.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoSwitch to native source format.
Lars Wirzenius [Tue, 25 May 2010 01:44:04 +0000 (13:44 +1200)]
Switch to native source format.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBugfix: Install old yui stylesheets, since Koha needs them.
Lars Wirzenius [Tue, 25 May 2010 01:44:03 +0000 (13:44 +1200)]
Bugfix: Install old yui stylesheets, since Koha needs them.

Also fix paths, since we can't install them where Koha expects them,
since that location is used by the Debian packaged yui.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBugfix: Create the jquery.js symlink for opac to the right target.
Lars Wirzenius [Tue, 25 May 2010 01:44:02 +0000 (13:44 +1200)]
Bugfix: Create the jquery.js symlink for opac to the right target.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBugfix: Remove Debian packaging files remaining from old packaging effort.
Lars Wirzenius [Tue, 25 May 2010 01:44:01 +0000 (13:44 +1200)]
Bugfix: Remove Debian packaging files remaining from old packaging effort.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBugfix: Remove pointless executable bits from sql files.
Lars Wirzenius [Tue, 25 May 2010 01:44:00 +0000 (13:44 +1200)]
Bugfix: Remove pointless executable bits from sql files.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoremoved unconditional warn introduced in previous patch
Galen Charlton [Mon, 24 May 2010 15:15:18 +0000 (11:15 -0400)]
removed unconditional warn introduced in previous patch

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years ago(bug #4487) permit - and . in callnumber plugin
Nahuel ANGELINETTI [Wed, 12 May 2010 11:44:32 +0000 (13:44 +0200)]
(bug #4487) permit - and . in callnumber plugin

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoCorrect position of non-sorted table column
Owen Leonard [Wed, 12 May 2010 12:37:17 +0000 (08:37 -0400)]
Correct position of non-sorted table column

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoRevert "(bug #3798) fix changing request branch"
Galen Charlton [Mon, 24 May 2010 15:00:41 +0000 (11:00 -0400)]
Revert "(bug #3798) fix changing request branch"

This reverts commit ad01b57bcced141cf3c14f3b44e59114adf8024e.

This commit had introduced bug 4526.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoCorrected: Fix for Bug 4529, columns on circ history all screwy
Owen Leonard [Wed, 19 May 2010 13:46:12 +0000 (09:46 -0400)]
Corrected: Fix for Bug 4529, columns on circ history all screwy

- fix formatting of last renew date
- Add table zebra striping
- Other markup structure changes
- Revised template assumes that issues.branchcode == checkout library and displays
  that value instead of issues.issuingbranch (which is always empty, see Bug 2806)
  issues.branchcode seems to reflect the item's holding branch *after* having
  been updated as part of the checkout transaction.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years ago(BUG #4521) aqbudgets.pl - Transform undefined budget spent value to 0.00 value
Alex Arnaud [Tue, 18 May 2010 07:43:20 +0000 (09:43 +0200)]
(BUG #4521) aqbudgets.pl - Transform undefined budget spent value to 0.00 value

This patch tranform the undefined value of budget spent to a money value which equals 0.00.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoRemove obsolete variables from basket.pl
Colin Campbell [Tue, 18 May 2010 16:34:34 +0000 (17:34 +0100)]
Remove obsolete variables from basket.pl

basket.pl calculates variables i, odd and count which are
no longer used in the template
removing them allows some simplification of the main loop
and cuts out on an extra db call
Loop through basketgroups also made more readable
Try to dimish the number of undef warnings filling the logs

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoRemove generation of an unnecessary warning
Colin Campbell [Wed, 19 May 2010 14:00:09 +0000 (15:00 +0100)]
Remove generation of an unnecessary warning

We've checked the return for definedness and
assigned an empty string to it ao we don't want
to make it undef again

This is a good argument that cascading if-elses expecially with
long unstructured elses are a bad idea

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 4510 Script processes single supplier not an array
Colin Campbell [Wed, 19 May 2010 17:42:38 +0000 (18:42 +0100)]
Bug 4510 Script processes single supplier not an array

Script was written as though it had an array rather than
a single supplier. Replaced the excess punctuation with a single
supplier variable

replaced the C-style currency loop with a simpler perl-style one
we only need 1 loop not multiples
Changed variable name $GST to $tax_rate it's not magical and not a constant
and we all know what tax is
Fetch Contract data once rather than twice from two different modules
Correct size of discount data on display

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years ago(bug #4522) fix plugin unimarc 210$c
Nahuel ANGELINETTI [Tue, 18 May 2010 08:02:38 +0000 (10:02 +0200)]
(bug #4522) fix plugin unimarc 210$c

This patch change the way to retrieve the value to insert in the record.
The way it was done, was verry ugly.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 4517 - add authentication to reorder_members.pl
Colin Campbell [Wed, 19 May 2010 09:25:08 +0000 (10:25 +0100)]
Bug 4517 - add authentication to reorder_members.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoupdate sample news on new install with koha-community.org urls
Nicole Engard [Fri, 21 May 2010 09:01:27 +0000 (05:01 -0400)]
update sample news on new install with koha-community.org urls

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoFix for Bug 4534, Box for SQL not visible in "Create Report from SQL"
Owen Leonard [Thu, 20 May 2010 12:16:02 +0000 (08:16 -0400)]
Fix for Bug 4534, Box for SQL not visible in "Create Report from SQL"

Changed style of SQL box and altered markup for a somewhat
cleaner layout

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agomoved INSTALL.debian-lenny to INSTALL.debian
Galen Charlton [Mon, 24 May 2010 12:35:07 +0000 (08:35 -0400)]
moved INSTALL.debian-lenny to INSTALL.debian

The old INSTALL.debian was specific to Etch, which is
no longer supported by the Debian project.  Lenny
is the current Debian stable.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoupdated links to Git usage wiki page
Galen Charlton [Mon, 24 May 2010 12:32:14 +0000 (08:32 -0400)]
updated links to Git usage wiki page

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agocorrected links to mailing lists
Galen Charlton [Mon, 24 May 2010 12:26:20 +0000 (08:26 -0400)]
corrected links to mailing lists

They use http, not https.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoUpdating INSTALL documents to Reflect lists and bugs URL Changes
Chris Nighswonger [Fri, 21 May 2010 13:06:10 +0000 (09:06 -0400)]
Updating INSTALL documents to Reflect lists and bugs URL Changes

wiki links will be changed as the content is moved over

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoupdated links in README
Galen Charlton [Mon, 24 May 2010 12:14:16 +0000 (08:14 -0400)]
updated links in README

Following patch made by Chris Cormack.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoUpdating INSTALL documents
Chris Nighswonger [Thu, 20 May 2010 01:35:53 +0000 (21:35 -0400)]
Updating INSTALL documents

This provides the following updates to the INSTALL documents:

- Links updated to reflect currently available community resources at their new locations
- Removes depreciated zebraqueue instructions
- Adds notes regarding the proper usage of rebuild_zebra.pl

NOTE: Remaining links will be updated as these resources are moved over and available

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4464: properly check if a subfield is populated if it is in a textarea
Galen Charlton [Fri, 21 May 2010 17:00:58 +0000 (13:00 -0400)]
bug 4464: properly check if a subfield is populated if it is in a textarea

Subfields whose contents are longer than 100 characters are represented on the
bib form using a <textarea> instead of a text <input>.  The check on whether
at least one subfield for a mandatory field is populated wasn't not
checking for <textarea> subfields.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 2889: Adds highlighting to serials-collection.tmpl
Garry Collum [Sat, 22 May 2010 17:41:52 +0000 (13:41 -0400)]
Bug 2889: Adds highlighting to serials-collection.tmpl

Also fixes inconsistencies in the capitalization in the headings.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 3910: Removes an erroneous heading from the serials search results.
Garry Collum [Sat, 22 May 2010 14:50:31 +0000 (10:50 -0400)]
Bug 3910: Removes an erroneous heading from the serials search results.

Removes the 'Search for Serial Routing' heading from the serials search result screen.

There is no code in the template that performs a routing search, and links to the routing tables are provided in the serials search results.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4505: updated release notes
Galen Charlton [Mon, 24 May 2010 11:51:19 +0000 (07:51 -0400)]
bug 4505: updated release notes

Minimum version of Perl required to run Koha is
now 5.8.8.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 4505 - Bumping the perl version to 5.8.8 or greater
Chris Cormack [Sat, 22 May 2010 08:15:59 +0000 (20:15 +1200)]
Bug 4505 - Bumping the perl version to 5.8.8 or greater

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4802 - fix swapped files in acq help
Nicole Engard [Fri, 21 May 2010 10:48:36 +0000 (06:48 -0400)]
bug 4802 - fix swapped files in acq help

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4802 add missing order search help file
Nicole Engard [Fri, 21 May 2010 10:16:04 +0000 (06:16 -0400)]
bug 4802 add missing order search help file

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4801: fix paging in display of staged bibs and import batches
Galen Charlton [Fri, 21 May 2010 13:34:42 +0000 (09:34 -0400)]
bug 4801: fix paging in display of staged bibs and import batches

Fixed glitch where the first page of bibs in a batch (or the first
page of import batches) was displaying the entire list instead
of the correct number of records per page.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4802 add new acq help files
Nicole Engard [Fri, 21 May 2010 09:24:30 +0000 (05:24 -0400)]
bug 4802 add new acq help files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoupdate main page help file
Nicole Engard [Fri, 21 May 2010 09:08:31 +0000 (05:08 -0400)]
update main page help file

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agofix XHTML error in bib details print page
Galen Charlton [Wed, 19 May 2010 15:38:56 +0000 (11:38 -0400)]
fix XHTML error in bib details print page

"&nbsp;" is not subtitutable for a table row

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years ago(bug #4519) fix record printing
Nahuel ANGELINETTI [Mon, 17 May 2010 14:18:51 +0000 (16:18 +0200)]
(bug #4519) fix record printing

this add a js that print a record

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 4525: Invalid XHTML in currency.tmpl.
Garry Collum [Tue, 18 May 2010 19:51:54 +0000 (15:51 -0400)]
Bug 4525: Invalid XHTML in currency.tmpl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4151: fix migration_tools typo
Galen Charlton [Mon, 17 May 2010 14:50:07 +0000 (10:50 -0400)]
bug 4151: fix migration_tools typo

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 4516 (Character shift in MARC21 Field 008)
Marcel de Rooy [Mon, 17 May 2010 12:17:59 +0000 (14:17 +0200)]
Bug 4516 (Character shift in MARC21 Field 008)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBacking down the required version of Graphics::Magick
Chris Nighswonger [Mon, 17 May 2010 14:23:47 +0000 (10:23 -0400)]
Backing down the required version of Graphics::Magick

This brings the required version into line with the latest version available in the Debian and Ubuntu repos.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoEnhancement Bug 4444: Centralize Code Handling Perl Dependencies
Chris Nighswonger [Sat, 15 May 2010 22:13:13 +0000 (18:13 -0400)]
Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

Porting about.pl over to use C4::Installer::PerlModules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoEnhancement Bug 4444: Centralize Code Handling Perl Dependencies
Chris Nighswonger [Sat, 15 May 2010 22:13:14 +0000 (18:13 -0400)]
Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

Porting install.pl over to use C4::Installer::PerlModules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoEnhancement Bug 4444: Centralize Code Handling Perl Dependencies
Chris Nighswonger [Sat, 15 May 2010 22:13:15 +0000 (18:13 -0400)]
Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

This patch adds a script to allow checking the status of Koha's Perl dependencies from the
command line interface at any time. Run '$ ./koha_perl_deps.pl --help' for available options.
'$ ./koha_perl_deps.pl -c' is recommended if you like color.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoEnhancement Bug 4444: Centralize Code Handling Perl Dependencies
Chris Nighswonger [Sat, 15 May 2010 22:13:12 +0000 (18:13 -0400)]
Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

Porting Makefile.PL over to use C4::Installer::PerlModules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoEnhancement Bug 4444: Centralize Code Handling Perl Dependencies
Chris Nighswonger [Sat, 15 May 2010 22:13:11 +0000 (18:13 -0400)]
Enhancement Bug 4444: Centralize Code Handling Perl Dependencies

This patch adds two modules: C4::Installer::PerlModule and C4::Installer::PerlDependencies. The latter provides a single point
of reference for cataloging Koha Perl dependencies. The former provides an OO style interface to the dependency catalog.

The format of C4::Installer::PerlDependencies is very simply an anonymous hash of hashes. Each second level hash takes this form:

'Foo::Bar' => {
  'usage'    => 'FooBar Feature',
  'required' => '1', # 0 if optional
  'min_ver'  => '0.01',
},

New modules can be appended to C4::Installer::PerlDependencies as needed and will be picked up by every piece of code which needs
this information.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4509: remove references to PINESISBN system preference
Galen Charlton [Fri, 14 May 2010 20:10:52 +0000 (16:10 -0400)]
bug 4509: remove references to PINESISBN system preference

This system preference never worked; also, as far as I can tell,
the PINES oISBN service was experimental, not meant for production
use, and is not currently advertised.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 4507 Don't return null vendor to claims processing
Colin Campbell [Fri, 14 May 2010 16:24:13 +0000 (17:24 +0100)]
Bug 4507 Don't return null vendor to claims processing

The empty vendor created by the select if any subscriptions
have no associated vendor generates a 'wrong-looking' display
and selecting it gives no options

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 2505 enable warnings in serials/reorder_members.pl
Colin Campbell [Sat, 15 May 2010 12:40:18 +0000 (13:40 +0100)]
Bug 2505 enable warnings in serials/reorder_members.pl

The only serials routine without warnings enabled was a
script with the least code to generate them
removed the numerous Module use declarations that were not
required
aligned the parameters for a more aesthetically pleasing effect

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 3768 (Bibliographic Framework Test)
Marcel de Rooy [Mon, 17 May 2010 09:16:02 +0000 (11:16 +0200)]
Bug 3768 (Bibliographic Framework Test)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoNew Developer to the history
Chris Cormack [Mon, 17 May 2010 09:25:11 +0000 (21:25 +1200)]
New Developer to the history

11 years agoBug 4394 REVISED Allow opaccolorstylesheet syspref to use an external URL
Jane Wagner [Tue, 4 May 2010 12:15:55 +0000 (08:15 -0400)]
Bug 4394 REVISED Allow opaccolorstylesheet syspref to use an external URL

Previous code would only allow for an auxiliary stylesheet on the same server.  This checks for
http in the opaccolorstylesheet syspref.  If it's found, sets a different variable pointing to the
remote server location.  If not found, retains the previous css directory path.

Also modifies the description of opaccolorstylesheet in the installer files to reflect current
usage as an auxiliary stylesheet.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agofix XHTML error in about.tmpl
Galen Charlton [Fri, 14 May 2010 12:40:56 +0000 (08:40 -0400)]
fix XHTML error in about.tmpl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoRevert "Bug 4450 Use more consistent error returns in C4/Creators/*"
Galen Charlton [Fri, 14 May 2010 00:20:02 +0000 (20:20 -0400)]
Revert "Bug 4450 Use more consistent error returns in C4/Creators/*"

This reverts commit 1f56a04cadc60f26b36f5599f24d0f380bc23828.

[RM note: I confirm Chris Nighswonger's testing that shows that
 the patch causes regressions, including breaking creating new
 label layouts.]

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBUG 4499: Javascript error messages not translatable
Katrin Fischer [Thu, 13 May 2010 21:30:22 +0000 (23:30 +0200)]
BUG 4499: Javascript error messages not translatable

- Administration > Patron categories > New Category (category.tmpl)
- Circulation > Checkouts > Toolbar (all tabs except Check out) (members-toolbar.inc)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBUG 4499: Javascript error messages not translatable
Katrin Fischer [Fri, 23 Apr 2010 16:37:01 +0000 (18:37 +0200)]
BUG 4499: Javascript error messages not translatable

- Cataloging > New Record (addbiblio.tmpl)
- Administration > Currencies > New Currency (currency.tmpl)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 4141 Reconcile 3.0.x and HEAD database updates for 3.2.0
Chris Nighswonger [Wed, 12 May 2010 12:00:50 +0000 (08:00 -0400)]
Bug 4141 Reconcile 3.0.x and HEAD database updates for 3.2.0

This is a partial fix addressing this error:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 at /home/koha/koha.prod/installer/data/mysql/updatedatabase.pl line 2916., referer: http://koha-staff.foobar.org/cgi-bin/koha/installer/install.pl

If there are no records in aqbudgets the result is an empty array which causes the sql to attempt to set AUTOINCREMENT to null.

This patch is being submitted on behalf of the Mapua Community Library.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>