koha.git
8 years agoBug 8585 : Add System Preference to specify Holds to Pull List Start Date
David Cook [Fri, 10 Aug 2012 02:31:30 +0000 (12:31 +1000)]
Bug 8585 : Add System Preference to specify Holds to Pull List Start Date

Currently, Koha creates a default value of 2 days ago (-2) for the start date of the Holds to pull List. This system preference allows users to specify their own default start date for this list, since users might not want to have to manually change the date all the time when they already know the set date period they want to view.

The system preference value is specified as a positive integer, which is then passed as a negative integer in the handler script. This saves users from having to include a qualifer to the sys pref value.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 8737 - Incorrect icon at login in staff client
Mark Tompsett [Fri, 7 Sep 2012 05:34:04 +0000 (13:34 +0800)]
Bug 8737 - Incorrect icon at login in staff client

Added the following missing code to ensure the correct icon
is used when logged out:
   IntranetFavicon => C4::Context->preference('IntranetFavicon')
This was added into an existing $template->param() call.

Not to be confused with the koha logo on the login page, the
icon is a 16x16 pixel graphic in the browser tab. The default
is found at .../intranet-tmpl/prog/en/includes/favicon.ico.

If the "IntranetFavicon" system preference is set, it should be
used by the staff client regardless of login state. It was not
being used in the "AUTH rejected" section of Auth.pm, but the
OpacFavicon variable was being set. This explains why the
"OpacFavicon" system preference works for the OPAC client, but
not the staff client upon logout.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8728 : Adjust Reserves.t test for resdate and expdate and test setup/teardown
wajasu [Wed, 5 Sep 2012 16:35:42 +0000 (11:35 -0500)]
Bug 8728 : Adjust Reserves.t test for resdate and expdate and test setup/teardown

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Works better now, creats biblio records, and cleans up after itself as
well.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8711 - alternating colors messed up on reports
Owen Leonard [Thu, 6 Sep 2012 19:21:03 +0000 (15:21 -0400)]
Bug 8711 - alternating colors messed up on reports

Patch adds the "zebra-striping" option to the
table sorter initialization and changes the row
color CSS to match the tablesorter's to prevent
conflicts.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoAdd a warning if a Z39.50 search is started from biblio edition page.
Frédérick Capovilla [Fri, 30 Sep 2011 19:11:01 +0000 (15:11 -0400)]
Add a warning if a Z39.50 search is started from biblio edition page.

Warn the user that the current biblio record might be overwritten by
this action.

http://bugs.koha-community.org/show_bug.cgi?id=8583
Signed-off-by: Marc Veron <veron@veron.ch>
Woks as expected. I prefer this solution with an explicit warning,
since several times I acidentally changed a record  :-)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8674 follow-up Fix perlcritic error
Paul Poulain [Tue, 2 Oct 2012 15:48:03 +0000 (17:48 +0200)]
Bug 8674 follow-up Fix perlcritic error

8 years agoBug 8674: Followup: Add POD for misc/batchdeletebiblios.pl
Jonathan Druart [Thu, 30 Aug 2012 08:33:38 +0000 (10:33 +0200)]
Bug 8674: Followup: Add POD for misc/batchdeletebiblios.pl

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8674: Adds script batchdeletebiblios
Jonathan Druart [Thu, 23 Aug 2012 12:28:42 +0000 (14:28 +0200)]
Bug 8674: Adds script batchdeletebiblios

This script batch deletes biblios which contain a biblionumber
present in file passed in parameter.
If one biblio has items, it is not deleted.

http://bugs.koha-community.org/show_bug.cgi?id=8674

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created file with biblionumbers for bibs with and without items.
Only the bibs without items were deleted.

8 years agoBug 7992: New plugin stocknumberAV
Jonathan Druart [Thu, 30 Aug 2012 13:31:14 +0000 (15:31 +0200)]
Bug 7992: New plugin stocknumberAV

Bugzilla description (from delaye):
1 / Create a list of authorised values(INVENTORY_NUMBER). In which the
code is the prefix and the description the last number assigned.

2/A space between the prefix and number.

3 / From a holding record, after indicate the prefix when you click on
the plugin -> koha search the last number from authorised values
assigned in the list and increment n +1 level meter

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Works as advertised (see provisos below). Tested the following:
1) INVENTORY category has only authorised value 'PR' => PR prefix filled
   in, everything else gives an error.
2) INVENTORY category has two authorised values, both work.
3) INVENTORY category has no authorised values, nothing is incremented
4) Barcode contains numbers, nothing is changed.
Two potential gotchas (neither of them significant enough to warrant
changing, in my opinion):
1) Prefixes must consist only of uppercase alphabetical characters.
2) Negative numbers are padded with zeros to the left of the negative
   sign.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8350: warning in logs when searching for nonexistent ISBN
Mark Tompsett [Thu, 30 Aug 2012 07:06:07 +0000 (15:06 +0800)]
Bug 8350: warning in logs when searching for nonexistent ISBN

Searching for a 10 or 13 digit numeric string that does not exist in
one's catalog will fail to affect SQL statement correctly
in C4::Breeding. Moved string substitution, which was triggering error
when search was undefined, and fixed if statements accordingly.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8818: make sure we load modules before using them
Jared Camins-Esakov [Tue, 25 Sep 2012 23:38:32 +0000 (19:38 -0400)]
Bug 8818: make sure we load modules before using them

An eval { eval "require $module;" }; was replaced with
eval { eval { require $module; }; }; which is a no-op, meaning that
the linker was not getting loaded, and the catalog module was throwing
up a big nasty error every time someone tried to save a record with a
heading. This patch replaces the require with can_load from
Module::Load::Conditional, which is PBP-friendly, and offers equivalent
functionality.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 5335 follow-up: fixing Perl error
Paul Poulain [Mon, 1 Oct 2012 16:47:28 +0000 (18:47 +0200)]
Bug 5335 follow-up: fixing Perl error

commenting wrong code, until Jonathan is back

see http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335#c52
and comment 53

8 years agoBug_7913-Follow-up, hide button for subs with items
Lyon3 Team [Mon, 1 Oct 2012 08:45:12 +0000 (04:45 -0400)]
Bug_7913-Follow-up, hide button for subs with items

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoReceiving serials in a loop
Lyon3 Team [Tue, 22 May 2012 13:43:02 +0000 (15:43 +0200)]
Receiving serials in a loop

generate the number of issues entered from a message box and apply
'arrived' status.

http://bugs.koha-community.org/show_bug.cgi?id=7913
Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com>
8 years agoBug 7642 follow-up fix POD
Paul Poulain [Mon, 1 Oct 2012 15:42:23 +0000 (17:42 +0200)]
Bug 7642 follow-up fix POD

The patch for bug 7642 did not introduce this error, but the QA tools detected it, so I fixed it

8 years agoBug 7642 - fix the lost display of tag sizes
Robin Sheat [Fri, 28 Sep 2012 23:34:32 +0000 (11:34 +1200)]
Bug 7642 - fix the lost display of tag sizes

This fixes the display of different sized words for differently popular
tags. It is a bit of a refactor of that part of the system, moving
logic to more sensible places (and removing an unused method on the
way.)

Note that it isn't an attempt to reproduce what was there previously,
just to do something similar, and in an easier to change fashion.

Sponsored-By: New Zealand Educational Institute
Signed-off-by: Marc Veron <veron@veron.ch>
Works as expected.

8 years agoBug 3387 follow-up: fix perlcritic error
Paul Poulain [Mon, 1 Oct 2012 15:35:45 +0000 (17:35 +0200)]
Bug 3387 follow-up: fix perlcritic error

8 years agoBug 3387 follow-up DBRev number
Paul Poulain [Mon, 1 Oct 2012 15:10:29 +0000 (17:10 +0200)]
Bug 3387 follow-up DBRev number

8 years agoBug 3387 - WITHDRAWN items shouldn't check in
Kyle M Hall [Tue, 17 Jul 2012 13:42:59 +0000 (09:42 -0400)]
Bug 3387 - WITHDRAWN items shouldn't check in

Adds a system preference BlockReturnOfWithdrawnItems to control
whether or not Koha should allow a withdrawn item to be returned
or not.

Also fixes the behavior where Koha will attempt to use a withdrawn
item to fill a hold.

Test Plan:
1) Set BlockReturnOfWithdrawnItems to "Block" ( this is the default )
2) Check an item out to a patron
3) Mark item as withdrawn
4) Attempt to return the item, you should still see the item on the
   borrower's record
5) Set BlockReturnOfWithdrawnItems to "Don't Block"
6) Attempt to return the item, you should see the item is no longer
   on the borrower's record.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoHolidays Test Plan - DB Dependent
Kyle M Hall [Mon, 18 Jun 2012 11:28:15 +0000 (07:28 -0400)]
Holidays Test Plan - DB Dependent

This test file is meant to be used with the sample database
with a minimum of the sample libraries and sample holidays installed.

http://bugs.koha-community.org/show_bug.cgi?id=8110
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agobug 8110 - add branchcode MPL to sample holidays to facilitate automated testing.
Liz Rea [Tue, 19 Jun 2012 15:36:23 +0000 (10:36 -0500)]
bug 8110 - add branchcode MPL to sample holidays to facilitate automated testing.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoMerge remote-tracking branch 'origin/new/bug_8209'
Paul Poulain [Mon, 1 Oct 2012 14:39:52 +0000 (16:39 +0200)]
Merge remote-tracking branch 'origin/new/bug_8209'

8 years agoBug 8209 follow-up: another correction for BuildSummary API
Jared Camins-Esakov [Thu, 13 Sep 2012 15:33:44 +0000 (11:33 -0400)]
Bug 8209 follow-up: another correction for BuildSummary API

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8581: don't display parentheses when we don't have a type
Jared Camins-Esakov [Mon, 6 Aug 2012 18:04:32 +0000 (14:04 -0400)]
Bug 8581: don't display parentheses when we don't have a type

Prior to this patch, see also references in certain authority records
(most notably GND records) were being followed by empty parentheses in
the search results display. This patch resolves that problem.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8726: add CSS to CCSR theme
Jared Camins-Esakov [Mon, 24 Sep 2012 17:34:45 +0000 (13:34 -0400)]
Bug 8726: add CSS to CCSR theme

8 years agoBug 8726: Followup FIX save didyoumean syspref
Jonathan Druart [Thu, 20 Sep 2012 12:22:19 +0000 (14:22 +0200)]
Bug 8726: Followup FIX save didyoumean syspref

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoBug 8726 follow-up: fix QA issues
Jared Camins-Esakov [Thu, 20 Sep 2012 11:39:16 +0000 (07:39 -0400)]
Bug 8726 follow-up: fix QA issues

Fixes several perlcritic complaints, and some overflow in the
configuration page. Also notes that Did You Mean is not yet
enabled on the staff client.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Sorry about the problematic last attempt at uploading. I missed a
patch when squashing. It is now included.

8 years agoBug 8726: ExplodedTerms suggestion plugin (jQueryUI)
Jared Camins-Esakov [Fri, 14 Sep 2012 13:12:14 +0000 (09:12 -0400)]
Bug 8726: ExplodedTerms suggestion plugin (jQueryUI)

When working with hierarchical subject headings, it is sometimes helpful
to do a search for all records with a specific subject, plus
broader/narrower/related subjects. This patch adds a suggestion plugin for
these "exploded" subject searches to Koha. Note that this patch depends on
both bug 8211 AND bug 8209.

To test (NOTE: this test plan covers both 8211 and 8726):
1) Make sure you have a bunch of hierarchical subjects. I created
   geographical subjects for "Arizona," "United States," and "Phoenix,"
   and linked them together using 551s, and made sure I had a half
   dozen records linking to each (but not all to all three).
2) Do a search for su-br:Arizona (or choose "Subject and broader terms"
   on the advanced search screen with "more options" displayed), and
   check that you get the records with the subject "Arizona" and the
   records with the subject "United States"
3) Do a search for su-na:Arizona (or choose "Subject and narrower terms"
   on the advanced search screen with "more options" displayed), and
   check that you get the records with the subject "Arizona" and the
   records with the subject "Phoenix"
4) Do a search for su-rl:Arizona (or choose "Subject and related terms"
   on the advanced search screen with "more options" displayed), and
   check that you get the records with the subject "Arizona," the
   records with the subject "United States," and the records with the
   subject "Phoenix"
5) Ensure that other searches still work (keyword, subject, ccl,
   whatever)
6) Use "Did you mean?" page in admin section to enable ExplodedTerms
   plugin
7) Do a keyword search on the OPAC, confirm that searching for exploded
   terms is suggested.
8) Do a subject search on the OPAC, confirm that searching for exploded
   terms is suggested.
9) Do a non-keyword, non-subject search on the OPAC, confirm that
   searching for exploded terms is NOT suggested.
10) Disable ExplodedTerms plugin and enable AuthorityFile plugin.
11) Do search on OPAC, confirm suggestions are made from authority file.
12) Sign off

Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Split into two patches. This patch includes only the jQueryUI upgrade

8 years agoBug 8726: ExplodedTerms suggestion plugin (functionality)
Jared Camins-Esakov [Fri, 14 Sep 2012 13:08:10 +0000 (09:08 -0400)]
Bug 8726: ExplodedTerms suggestion plugin (functionality)

When working with hierarchical subject headings, it is sometimes helpful
to do a search for all records with a specific subject, plus
broader/narrower/related subjects. This patch adds a suggestion plugin for
these "exploded" subject searches to Koha. Note that this patch depends on
both bug 8211 AND bug 8209.

To test (NOTE: this test plan covers both 8211 and 8726):
1) Make sure you have a bunch of hierarchical subjects. I created
   geographical subjects for "Arizona," "United States," and "Phoenix,"
   and linked them together using 551s, and made sure I had a half
   dozen records linking to each (but not all to all three).
2) Do a search for su-br:Arizona (or choose "Subject and broader terms"
   on the advanced search screen with "more options" displayed), and
   check that you get the records with the subject "Arizona" and the
   records with the subject "United States"
3) Do a search for su-na:Arizona (or choose "Subject and narrower terms"
   on the advanced search screen with "more options" displayed), and
   check that you get the records with the subject "Arizona" and the
   records with the subject "Phoenix"
4) Do a search for su-rl:Arizona (or choose "Subject and related terms"
   on the advanced search screen with "more options" displayed), and
   check that you get the records with the subject "Arizona," the
   records with the subject "United States," and the records with the
   subject "Phoenix"
5) Ensure that other searches still work (keyword, subject, ccl,
   whatever)
6) Use "Did you mean?" page in admin section to enable ExplodedTerms
   plugin
7) Do a keyword search on the OPAC, confirm that searching for exploded
   terms is suggested.
8) Do a subject search on the OPAC, confirm that searching for exploded
   terms is suggested.
9) Do a non-keyword, non-subject search on the OPAC, confirm that
   searching for exploded terms is NOT suggested.
10) Disable ExplodedTerms plugin and enable AuthorityFile plugin.
11) Do search on OPAC, confirm suggestions are made from authority file.
12) Sign off

Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Split into two patches. This patch includes only the functionality.

8 years agoBug 7351 : feature that allows to delete a range of dates
christophe croullebois [Sun, 15 Jul 2012 13:10:47 +0000 (15:10 +0200)]
Bug 7351 : feature that allows to delete a range of dates

Four new options, one for single holidays, one for the repeatable holidays.
One to create exceptions on a range of dates, one to delete exceptions in a range of dates.
Note that the exceptions are not deleted if you delete a range of repeatable dates.
But if you delete a range of single holidays the exeptions inside will be deleted.

Signed-off-by: Stephane Delaye <stephane.delaye@biblibre.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 5335 follow-up fixing template
Paul Poulain [Fri, 28 Sep 2012 09:26:23 +0000 (11:26 +0200)]
Bug 5335 follow-up fixing template

There were 2 invalid T::T construction, with a [% IF %] inside a HTML tag

8 years agoBug 5335 follow-up fix test
Paul Poulain [Fri, 28 Sep 2012 09:19:56 +0000 (11:19 +0200)]
Bug 5335 follow-up fix test

The gst column is now called gstrate.

8 years agoBug 8659 Remove and readd the inactive funds in javascript to make it work in all...
Maxime Pelletier [Tue, 21 Aug 2012 22:02:31 +0000 (18:02 -0400)]
Bug 8659 Remove and readd the inactive funds in javascript to make it work in all browsers

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8702: System preferences search does not allow accented letters
Fridolyn SOMERS [Tue, 18 Sep 2012 13:59:37 +0000 (15:59 +0200)]
Bug 8702: System preferences search does not allow accented letters

This bug enables accented/diacritic system preference text to be matched
when searching for sysprefs.

Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8780 - Lower dependency version for DateTime::TimeZone
Mark Tompsett [Tue, 18 Sep 2012 05:15:18 +0000 (13:15 +0800)]
Bug 8780 - Lower dependency version for DateTime::TimeZone

The fresh install of Debian, with the debian.koha-community.org
repository, only has version 1.20 by default. As only the most
basic functionality is being used, this version number should be
lowered from 1.26 to 1.20 in ./C4/Installer/PerlDependencies.pm
to make git installations cleaner.

Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 5356 follow-up DBRev number
Paul Poulain [Mon, 24 Sep 2012 19:32:48 +0000 (21:32 +0200)]
Bug 5356 follow-up DBRev number

8 years agoBug 5356: Followup: remove useless code
Jonathan Druart [Fri, 21 Sep 2012 08:30:34 +0000 (10:30 +0200)]
Bug 5356: Followup: remove useless code

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 5356: Followup: Add basket billing and delivery place on export pdf (layout3pages)
Jonathan Druart [Tue, 4 Sep 2012 08:03:27 +0000 (10:03 +0200)]
Bug 5356: Followup: Add basket billing and delivery place on export pdf (layout3pages)

8 years agoBug 5356: delivery place and billing place centralised in basket management
Jonathan Druart [Wed, 25 Jul 2012 08:25:16 +0000 (10:25 +0200)]
Bug 5356: delivery place and billing place centralised in basket management

- adding 2 select option in basdketheader.tmpl (delivery and billing
   place)
- adding 2 more fields in basket csv export

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested together with patches for bug 7302.

8 years agoMerge remote-tracking branch 'origin/new/bug_8523'
Paul Poulain [Fri, 21 Sep 2012 14:37:25 +0000 (16:37 +0200)]
Merge remote-tracking branch 'origin/new/bug_8523'

Conflicts:
kohaversion.pl

8 years agoBug 8523 follow-up OPAC styles for ccsr theme
Paul Poulain [Fri, 21 Sep 2012 14:35:20 +0000 (16:35 +0200)]
Bug 8523 follow-up OPAC styles for ccsr theme

8 years agoBug 8523 follow-up fixing perlcritic
Paul Poulain [Fri, 21 Sep 2012 14:30:36 +0000 (16:30 +0200)]
Bug 8523 follow-up fixing perlcritic

8 years agoBug 8523 follow-up DBRev number
Paul Poulain [Fri, 21 Sep 2012 13:16:30 +0000 (15:16 +0200)]
Bug 8523 follow-up DBRev number

8 years agoBug 8523: Display auth hierarchies w/all marcflavours
Jared Camins-Esakov [Wed, 1 Aug 2012 19:12:30 +0000 (15:12 -0400)]
Bug 8523: Display auth hierarchies w/all marcflavours

This commit adds support for displaying authority hierarchies for all
flavours of MARC, not just UNIMARC. Display now uses the jQuery
jstree plugin, selected with the help of Owen Leonard, resulting in a
much faster experience for users.

Be aware that the jstree file uses tabs rather than 4-space indentation,
which I left as-is so as to make it easier to integrate upstream
releases in the future.

To test:
1) Enable the AuthDisplayHierarchy syspref
2) Create authority records with a hierarchy of see also fields
   (in MARC21/NORMARC, you'll be using 5xx fields for this, with a
   subfield $w=g for broader terms and subfield $w=h for narrower
   terms)
3) View the authorities in the OPAC, noting the hierarchical view at
   the top of the page.

This initial patch does not create bidirection linkages from
unidirectional links in MARC21 authorities. This means that when moving
up the authority hierarchy, lower levels will disappear. This is
intentional, as the first patch is intended merely to ensure that
AuthDisplayHierarchy functions the same for all marcflavours. A future
patch will add a cron job to generate the bidirectional linkages, once
we are sure that the hierarchy functionality for UNIMARC and
MARC21/NORMARC coexists peaceably.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Resolved conflicts in updatedatabase.pl, sysprefs.sql and in one of
the CSS files.

Test plan:

1) Run t/AuthoritiesMarc.t
New tests complete without any errors.

2) Make sure updatedatabase works correctly.
Update works nicely, new system preference is also added to syspref.sql

3) Make sure new terms are translatable.
Created new po files for de-DE and checked for new terms.
All translations appear correctly.

4) Make sure everything works with AuthDisplayHieararchy OFF
- Add authority
- Edit authority
- Delete authority

5) Test feature with AuthDisplayHieararchy ON
- Add authority
- Edit authority
- Delete authority

6) Add a couple of hierarchically linked authorities
Note: links have to be created in both directions

Example:
151 $aGermany
  551 $a Baden-Württemberg $w h

151 $aBaden-Württemberg
  551 $a Konstanz $w h
  551 $a Germany $w g

151 $aKonstanz
  551 $a Baden-Württemberg $w g
  551 $a Fürstenberg $w h
  551 $a Paradies $w h

151 $a Fürstenberg
  551 $a Konstanz $w g

151 $a Paradies
  551 $a Konstanz $w g

Tree shows up nicely above the authority record
- in staff
- in OPAC
  - on the normal view tab
  - on the MARC view tab

7) Checking the logs for warnings
- no Javascript errors or warnings
- no warnings or errors in log files

8 years agoBug 5335 follow-up DBRev number
Paul Poulain [Fri, 21 Sep 2012 08:36:56 +0000 (10:36 +0200)]
Bug 5335 follow-up DBRev number

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 5335 follow-up DBRev number
Paul Poulain [Fri, 21 Sep 2012 08:36:56 +0000 (10:36 +0200)]
Bug 5335 follow-up DBRev number

8 years agoBug 5335 - More granular VAT
Jonathan Druart [Fri, 24 Feb 2012 15:24:05 +0000 (16:24 +0100)]
Bug 5335 - More granular VAT

Signed-off-by: Pierre Angot <tredok.pierre@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoMerge remote-tracking branch 'origin/new/bug_8606'
Paul Poulain [Thu, 20 Sep 2012 12:58:39 +0000 (14:58 +0200)]
Merge remote-tracking branch 'origin/new/bug_8606'

8 years agoRevert "Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModul...
Paul Poulain [Thu, 20 Sep 2012 12:49:18 +0000 (14:49 +0200)]
Revert "Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModules.pm"

This reverts commit afff4e8d6a427d231746b024a0d6f98438e7f2c6.

8 years agoBug 8606 - Talking Tech broken by user-configurable slips feature - QA Followup
Kyle M Hall [Wed, 19 Sep 2012 15:54:52 +0000 (11:54 -0400)]
Bug 8606 - Talking Tech broken by user-configurable slips feature - QA Followup

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(not tested it actually fixes talking tech, trusting signoff & sounds
logical)

8 years agoBug 8606 - Talking Tech broken by Bug 7001
Koha user [Tue, 7 Aug 2012 12:09:19 +0000 (08:09 -0400)]
Bug 8606 - Talking Tech broken by Bug 7001

The patches for bug 7001 removed the parseletter subroutine from
C4::Letters without updating the talking tech script to use the
new alternative. This patch rectifies that situation.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
8 years agoBug 8692: Authorities search form does not correspond to current search query
Fridolyn SOMERS [Mon, 27 Aug 2012 12:50:32 +0000 (14:50 +0200)]
Bug 8692: Authorities search form does not correspond to current search query

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
The correct tab is now visible on load. The problem with authtypecode
showing up in the search box is specific to UNIMARC, so I could not
check that it was gone, but I am comfortable signing off on this.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoRevert "Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm"
Paul Poulain [Thu, 20 Sep 2012 11:29:59 +0000 (13:29 +0200)]
Revert "Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm"

This reverts commit 48d5f30226c75b260ddfa6b85ee8f87878902e0e.

8 years agoBug 6679 - fix 3 perlcritic violations in C4/Auth.pm, and enabled warnings
Mason James [Tue, 26 Jun 2012 16:54:11 +0000 (04:54 +1200)]
Bug 6679 - fix 3 perlcritic violations in C4/Auth.pm, and enabled warnings

Subroutine prototypes used at line 561, column 1.  See page 194 of PBP.  (Severity: 5)

Bareword file handle opened at line 606, column 5.  See pages 202,204 of PBP.  (Severity: 5)

Two-argument "open" used at line 606, column 5.  See page 207 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch reintroduces 'use warnings' in C4/Auth.pm.
Keep attentive to new warning messages in your log

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Print.pm
Mason James [Tue, 26 Jun 2012 17:02:00 +0000 (05:02 +1200)]
Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Print.pm

Bareword file handle opened at line 80, column 9.  See pages 202,204 of PBP.  (Severity: 5)

Two-argument "open" used at line 80, column 9.  See page 207 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
http://perldoc.perl.org/functions/open.html
For three or more arguments if MODE is |- , the filename is interpreted
as a command to which output is to be piped, and if MODE is -| , the
filename is interpreted as a command that pipes output to us. I

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Creators/PDF.pm
Mason James [Tue, 26 Jun 2012 14:28:26 +0000 (02:28 +1200)]
Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Creators/PDF.pm

- "return" statement with explicit "undef" at line 171, column 8.  See page 199 of PBP.  (Severity: 5)

- "return" statement with explicit "undef" at line 201, column 8.  See page 199 of PBP.  (Severity: 5)

- Bareword file handle opened at line 212, column 11.  See pages 202,204 of PBP.  (Severity: 5)

- Two-argument "open" used at line 212, column 11.  See page 207 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
8 years agoBug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Installer.pm
Mason James [Tue, 26 Jun 2012 14:20:58 +0000 (02:20 +1200)]
Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Installer.pm

- Bareword file handle opened at line 157, column 13.  See pages 202,204 of
PBP.  (Severity: 5)

- I/O layer ":utf8" used at line 157, column 13.  Use ":encoding(UTF-8)" to get strict validation.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
http://perldoc.perl.org/functions/open.html
    open(my $fh, "<:encoding(UTF-8)", "filename")
        || die "can't open UTF-8 encoded filename: $!";

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/BackgroundJob.pm
Mason James [Tue, 26 Jun 2012 17:09:10 +0000 (05:09 +1200)]
Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/BackgroundJob.pm

"return" statement with explicit "undef" at line 234, column 5.  See page 199 of PBP.  (Severity: 5)

"return" statement with explicit "undef" at line 256, column 9.  See page 199 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModules.pm
Mason James [Tue, 26 Jun 2012 17:07:46 +0000 (05:07 +1200)]
Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModules.pm

Expression form of "eval" at line 71, column 9.  See page 161 of PBP.  (Severity: 5)

Expression form of "eval" at line 85, column 13.  See page 161 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/ItemCirculationAlertPrefere...
Mason James [Tue, 26 Jun 2012 17:04:49 +0000 (05:04 +1200)]
Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/ItemCirculationAlertPreference.pm

"return" statement with explicit "undef" at line 170, column 13.  See page 199 of PBP.  (Severity: 5)

"return" statement with explicit "undef" at line 407, column 9.  See page 199 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Utils.pm
Mason James [Tue, 26 Jun 2012 16:57:58 +0000 (04:57 +1200)]
Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Utils.pm

Subroutine prototypes used at line 38, column 1.  See page 194 of PBP.  (Severity: 5)

Subroutine prototypes used at line 43, column 1.  See page 194 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Items.pm
Mason James [Tue, 26 Jun 2012 14:50:50 +0000 (02:50 +1200)]
Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Items.pm

"return" statement with explicit "undef" at line 508, column 44.  See page 199 of PBP.  (Severity: 5)
"return" statement with explicit "undef" at line 2267, column 5.  See page 199 of PBP.  (Severity: 5)
Variable declared in conditional statement at line 2642, column 21.  Declare variables outside of the condition.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Message.pm
Mason James [Tue, 26 Jun 2012 14:48:25 +0000 (02:48 +1200)]
Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Message.pm

"return" statement with explicit "undef" at line 109, column 9.  See page 199 of PBP.  (Severity: 5)
"return" statement with explicit "undef" at line 145, column 9.  See page 199 of PBP.  (Severity: 5)
"return" statement with explicit "undef" at line 319, column 9.  See page 199 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Output.pm
Mason James [Tue, 26 Jun 2012 14:44:47 +0000 (02:44 +1200)]
Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Output.pm

"return" statement with explicit "undef" at line 128, column 74.  See page 199 of PBP.  (Severity: 5)
Subroutine prototypes used at line 270, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 308, column 1.  See page 194 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
8 years agoBug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/SQLHelper.pm
Mason James [Tue, 26 Jun 2012 14:37:09 +0000 (02:37 +1200)]
Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/SQLHelper.pm

Subroutine prototypes used at line 251, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 287, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 317, column 1.  See page 194 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Branch.pm
Mason James [Tue, 26 Jun 2012 14:31:06 +0000 (02:31 +1200)]
Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Branch.pm

Subroutine prototypes used at line 157, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 375, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 385, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 418, column 1.  See page 194 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/ShelfBrowser.pm
Mason James [Tue, 26 Jun 2012 14:10:11 +0000 (02:10 +1200)]
Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/ShelfBrowser.pm

- Variable declared in conditional statement at line 183, column 5.  Declare  variables outside of the condition.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 - [SIGNED-OFF] fix 5 perlcritic violations in C4/Serials.pm
Mason James [Tue, 26 Jun 2012 14:02:26 +0000 (02:02 +1200)]
Bug 6679 - [SIGNED-OFF] fix 5 perlcritic violations in C4/Serials.pm

- Subroutine prototypes used at line 161, column 1.  See page 194 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 - [SIGNED-OFF] fix 6 perlcritic violations in C4/Barcodes/hbyymmincr.pm
Mason James [Tue, 26 Jun 2012 13:53:05 +0000 (01:53 +1200)]
Bug 6679 - [SIGNED-OFF] fix 6 perlcritic violations in C4/Barcodes/hbyymmincr.pm

- Subroutine prototypes used at line 45, column 1.  See page 194 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 - [SIGNED-OFF] fix 7 perlcritic violations in C4/Biblio.pm
Mason James [Tue, 26 Jun 2012 13:30:33 +0000 (01:30 +1200)]
Bug 6679 - [SIGNED-OFF] fix 7 perlcritic violations in C4/Biblio.pm

- Expression form of "eval" at line 492, column 12.  See page 161 of PBP.  (Severity: 5)

- "return" statement with explicit "undef" at line 891, column 5.  See page 199 of PBP.  (Severity: 5)

- Subroutine prototypes used at line 1148, column 1.  See page 194 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Barcodes.pm
Mason James [Tue, 26 Jun 2012 13:22:21 +0000 (01:22 +1200)]
Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Barcodes.pm

- "return" statement with explicit "undef" at line 57, column 2.  See page 199 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Circulation.pm
Mason James [Tue, 26 Jun 2012 13:20:37 +0000 (01:20 +1200)]
Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Circulation.pm

- "return" statement with explicit "undef" at line 994, column 39.  See page 199 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/Koha.pm
Mason James [Tue, 26 Jun 2012 13:12:24 +0000 (01:12 +1200)]
Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/Koha.pm

- Subroutine prototypes used at line 115, column 1.  See page 194 of PBP.  (Severity: 5)

- "return" statement with explicit "undef" at line 1112, column 4.  See page 199 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm
Mason James [Tue, 26 Jun 2012 13:08:34 +0000 (01:08 +1200)]
Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm

- Subroutine prototypes used at line 86, column 1.  See page 194 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 - [SIGNED-OFF] fix 15 perlcritic violations in C4/ImportExportFramework.pm
Mason James [Tue, 26 Jun 2012 04:39:27 +0000 (16:39 +1200)]
Bug 6679 - [SIGNED-OFF] fix 15 perlcritic violations in C4/ImportExportFramework.pm

Bareword file handle opened at line 558, column 17.  See pages 202,204 of PBP.  (Severity: 5)

Two-argument "open" used at line 558, column 17.  See page 207 of PBP.  (Severity: 5)

http://bugs.koha-community.org/show_bug.cgi?id=6679
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 - [SIGNED-OFF]fixing 23 '"return" statement with explicit "undef"' violation...
Mason James [Tue, 26 Jun 2012 03:55:46 +0000 (15:55 +1200)]
Bug 6679 - [SIGNED-OFF]fixing 23 '"return" statement with explicit "undef"' violations in C4/Tags.pm

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 -[SIGNED-OFF] fix 12 perlcritic violations in C4/Context.pm
Mason James [Tue, 26 Jun 2012 12:34:43 +0000 (00:34 +1200)]
Bug 6679 -[SIGNED-OFF] fix 12 perlcritic violations in C4/Context.pm

"return" statement with explicit "undef" at line 486, column 5.  See page 199 of PBP.  (Severity: 5)

Subroutine prototypes used at line 548, column 1.  See page 194 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 - [SIGNED-OFF] fix 12 perlcritic violations in C4/Auth_with_ldap.pm
Mason James [Tue, 26 Jun 2012 12:38:42 +0000 (00:38 +1200)]
Bug 6679 - [SIGNED-OFF] fix 12 perlcritic violations in C4/Auth_with_ldap.pm

Subroutine prototypes used at line 73, column 1.  See page 194 of PBP.  (Severity: 5)

"return" statement with explicit "undef" at line 74, column 24.  See page 199 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 6679 - fix 12 perlcritic violations in C4/External/BakerTaylor.pm
Mason James [Tue, 26 Jun 2012 12:43:07 +0000 (00:43 +1200)]
Bug 6679 - fix 12 perlcritic violations in C4/External/BakerTaylor.pm

Subroutine prototypes used at line 82, column 1.  See page 194 of PBP.  (Severity: 5)

"return" statement with explicit "undef" at line 83, column 22.  See page 199 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoMerge remote-tracking branch 'origin/new/bug_5339'
Paul Poulain [Thu, 20 Sep 2012 08:19:44 +0000 (10:19 +0200)]
Merge remote-tracking branch 'origin/new/bug_5339'

8 years agoBug 5339 follow-up
Paul Poulain [Thu, 20 Sep 2012 08:19:19 +0000 (10:19 +0200)]
Bug 5339 follow-up

 * fix english error
 * if the invoice is closed, don't display a "finish receiving" link, but a "view invoice" one

8 years agoBug 5339: Unit tests for invoices related subroutines
Julian Maurice [Wed, 19 Sep 2012 13:02:49 +0000 (15:02 +0200)]
Bug 5339: Unit tests for invoices related subroutines

These tests use DBD::Mock to check if SQL queries are correctly built.
Actually, we only check bound parameters.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 5339: ergonomic changes
Julian Maurice [Wed, 19 Sep 2012 12:08:28 +0000 (14:08 +0200)]
Bug 5339: ergonomic changes

- "Finish receive" on parcel.pl now redirect to acqui/invoice.pl,
  allowing the librarian to modify invoice informations (freight,
  billing date, ...) and close invoice.
- The librarian can now close (or reopen) the invoice and modify invoice
  informations in 1 operation (instead of 2)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 5339: Fix t/db_dependant/Acquisition.t
Julian Maurice [Thu, 20 Sep 2012 07:11:58 +0000 (09:11 +0200)]
Bug 5339: Fix t/db_dependant/Acquisition.t

8 years agoMerge remote-tracking branch 'origin/new/bug_8185'
Paul Poulain [Wed, 19 Sep 2012 16:47:58 +0000 (18:47 +0200)]
Merge remote-tracking branch 'origin/new/bug_8185'

8 years agoBug 6679 Avoid critic failure caused by ambiguous code
Colin Campbell [Wed, 19 Sep 2012 16:23:27 +0000 (17:23 +0100)]
Bug 6679 Avoid critic failure caused by ambiguous code

If countitems not set to 1 it was not being declared
but is referred to outside this scope, generating
runtime warnings and test failure

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 2060 follow-up DBRev & updatedatabase
Paul Poulain [Wed, 19 Sep 2012 15:25:19 +0000 (17:25 +0200)]
Bug 2060 follow-up DBRev & updatedatabase

8 years agoBug 2060 follow-up: add support for UNIMARCAUTH
Jared Camins-Esakov [Fri, 14 Sep 2012 12:46:04 +0000 (08:46 -0400)]
Bug 2060 follow-up: add support for UNIMARCAUTH

The staged MARC management script was not correctly informing
the decoder ring that we had UNIMARC authorities, and the decoder
ring was dutifully trying to turn the authority records into a
bibliographic box of cereal.

8 years agoBug 2060: Update command line MARC import scripts
Jared Camins-Esakov [Mon, 25 Jun 2012 15:38:19 +0000 (11:38 -0400)]
Bug 2060: Update command line MARC import scripts

Expose authority import functionality to the command line import
scripts, and rename them from commit_biblios_file.pl and
stage_biblios_file.pl to commit_file.pl and stage_file.pl.

To test (note that these instructions assume you have a MARC21
installation and are using the provided sample file):
1. Find a file of authorities (a sample file with MARC21 authorities
   is attached to bug 7475) and download it to your server
2. Stage the file using the following command (replace <filename> with
   the name of the file you saved in step 1):
   > misc/stage_file.pl --file <filename> --authorities
3. Note the batch number the script assigns to your batch
4. Commit the records using the following command (replace <batchnumber>
   with the batch number you made note of in step 3):
   > misc/commit_file.pl --batch-number <batchnumber>
5. Index the authorities Zebraqueue (or wait)
6. Confirm that the new authorities appear.
7. Create a matching rule with the following settings:
   Code: AUTHTEST
   Description: Personal name main entry
   Match threshold: 999
   Record type: Authority record
   Search index: Heading-main
   Score: 1000
   Tag: 100
   Subfields: a
   Offset: 0
   Length: 0
   (note the ID of this matching rule)
8. Stage the authority file again, this time using the following
   command:
   > misc/stage_file.pl --file <filename> --authorities \
     --match <matchingrule>
7. Revert the import with the following command:
   > misc/commit_file.pl --batch-number <batchnumber> --revert
8. Index the authorities Zebraqueue (or wait)
9. Confirm that the records have been removed
10. Import an authority record with the Stage MARC/Manage staged MARC
    tools in exactly the way you would for a bibliographic record,
    but choose "Authority" instead of "Bibliographic" for the record
    type.

Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
Testing plan delivers as it should.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased on latest master 11 September 2012

8 years agoBug 7475: Teach matching rules to handle authorities
Jared Camins-Esakov [Mon, 25 Jun 2012 15:34:59 +0000 (11:34 -0400)]
Bug 7475: Teach matching rules to handle authorities

* Add the code necessary to handle authorities with matching rules and
  import batches.
* Update all the scripts that use the matcher and import batch code
  to use the new API.
* Add authority records to the matching rules interface in the staff
  client.

http://bugs.koha-community.org/show_bug.cgi?id=2060
Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased on latest master 11 September 2012

8 years agoBug 7475: Update configuration
Jared Camins-Esakov [Mon, 25 Jun 2012 16:36:45 +0000 (12:36 -0400)]
Bug 7475: Update configuration

In order to make matching rules more useful for MARC21 authorities,
this patch adds special indexes on previous see-from headings and
LCCN. This patch does not change UNIMARC authority configuration in
any way. Also modifies the Koha schema in preparation for adding
authority import and matching to the Staging tools.

To install:
1. Run installer/data/mysql/atomicupdate/importauthorities.pl
2. Update the following four files in your koha-dev:
    etc/zebradb/authorities/etc/bib1.att
    etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml
    etc/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl
    etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl
3. Reindex your authorities:
    misc/migration_tools/rebuild_zebra.pl -a -r -v

NOTE TO RM: this patch adds an atomicupdate file that needs to be
incorporated into updatedatabase.pl if bug 7167 is not pushed.

http://bugs.koha-community.org/show_bug.cgi?id=2060

Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased on master 1 August 2012
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased on master 11 September 2012

8 years agoA follow-up will be added though, because we understood why I had some javascript...
Paul Poulain [Wed, 19 Sep 2012 15:02:14 +0000 (17:02 +0200)]
A follow-up will be added though, because we understood why I had some javascript error and jonathan didn't. It's because I've plack + debug
Bug 8117 follow-up: explicitely list tables to dataTable

debug panel in plack adds a lot of <table> (without any id)
thus, when you call
$("table").dataTable(...)
there's a javacscript error because datatable can't handle the plack <table> !

The solution has been to explicitely name the tables to dataTable (which is a good thing anyway)
        $("#activeperiodst,#inactiveperiodst").dataTable($.extend(true, {}, dataTablesDefaults, {

8 years agoBug 8117 follow-up remove perl warning
Paul Poulain [Wed, 19 Sep 2012 14:29:46 +0000 (16:29 +0200)]
Bug 8117 follow-up remove perl warning

first & last were already defined, removing my

8 years agoBug 8117: Followup: remove h3 title (duplicate infos)
Jonathan Druart [Fri, 3 Aug 2012 12:18:27 +0000 (14:18 +0200)]
Bug 8117: Followup: remove h3 title (duplicate infos)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8117: Divide budget periods into two tabs
Jonathan Druart [Fri, 20 Jul 2012 14:21:17 +0000 (16:21 +0200)]
Bug 8117: Divide budget periods into two tabs

Budget periods are now divided into two tabs : active and inactive
budget periods.

The original author of this patch is Julian Maurice

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Michael Davis <m.r.davis@cranfield.ac.uk>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoMerge remote-tracking branch 'origin/new/bug_6448'
Paul Poulain [Wed, 19 Sep 2012 14:12:23 +0000 (16:12 +0200)]
Merge remote-tracking branch 'origin/new/bug_6448'

8 years agoBug 6448 - carp on invalid barcode
Dobrica Pavlinusic [Fri, 3 Aug 2012 22:03:11 +0000 (00:03 +0200)]
Bug 6448 - carp on invalid barcode

This is consistent with implementation of other barcode types
which all carp instead of die on invalid barcodes.

8 years agoBug 8185: Change some more strings from Italian to English
Mirko Tietgen [Sat, 11 Aug 2012 19:47:05 +0000 (21:47 +0200)]
Bug 8185: Change some more strings from Italian to English

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Two additional corrections

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8185: plugin for linking records in MARC21
Zeno Tajoli [Fri, 3 Aug 2012 13:03:59 +0000 (15:03 +0200)]
Bug 8185: plugin for linking records in MARC21

This plugin works like the unimarc plugin unimarc_field_4XX. It
 insert: $9 -> biblionumber $w -> 001 $t -> 245$a (title )
 $x -> 022$a (ISSN) $z -> 020$a (ISBN) The search is done on
 'any' index. Data are inserted only in the working record.
 To insert data in the connected record, you need to open
 the other record.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoBug 8624: Move famfamfam out of theme directory
Jared Camins-Esakov [Mon, 13 Aug 2012 00:50:28 +0000 (20:50 -0400)]
Bug 8624: Move famfamfam out of theme directory

The patch moves the famfamfam image set out of the
koha-tmpl/opac-tmpl/prog/famfamfam into koha-tmpl/opac-tmpl/famfamfam

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>