koha.git
8 years agoBug 8443: Suggestions publication year and copyright date
Fridolyn SOMERS [Tue, 6 Nov 2012 08:50:48 +0000 (09:50 +0100)]
Bug 8443: Suggestions publication year and copyright date

Main patch correcting suggestions search :
- allow filtering on copyrightdate, manageddate and accepteddate
- entered dates remains in filter during search
- empty and null values are in the same tab
- null/empty values are not present in filers comboboxes

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_9309' into 3.12-master
Jared Camins-Esakov [Wed, 16 Jan 2013 03:02:22 +0000 (22:02 -0500)]
Merge branch 'bug_9309' into 3.12-master

8 years agoBug 9309 - Make OPACurlOpenInNewWindow be respected for 856$u
Robin Sheat [Thu, 20 Dec 2012 02:45:33 +0000 (15:45 +1300)]
Bug 9309 - Make OPACurlOpenInNewWindow be respected for 856$u

If a biblio record contained a URL, and the OPAC was using the "normal"
(non-XSLT) display for records, then these links would never open a new
window. With this patch, they will.

Test plan:
1) have a biblio containing an 856$u link
2) set OPACurlOpenInNewWindow to "true"
3) do not use XSLT for displaying the detail pages in the OPAC
4) view the record, click the link, and note that it opens in the
   current window.
5) apply the patch
6) reload the detail page, click the link, and note that it opens a new
   window.

Sponsored-By: National Institute of Water and Atmospheric Research
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_9306' into 3.12-master
Jared Camins-Esakov [Wed, 16 Jan 2013 02:55:01 +0000 (21:55 -0500)]
Merge branch 'bug_9306' into 3.12-master

8 years agoBug 9306: Update descriptions for the 4 SeparateHoldings prefs
Nicole C. Engard [Fri, 28 Dec 2012 14:33:49 +0000 (09:33 -0500)]
Bug 9306: Update descriptions for the 4 SeparateHoldings prefs

Patch updates the text of the SeparateHoldings and OpacSeparateHoldings
preference descriptions to be more readable.

To test, apply the patch and check the text of the preferences.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Description and test plan added.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_7657' into 3.12-master
Jared Camins-Esakov [Wed, 16 Jan 2013 02:52:04 +0000 (21:52 -0500)]
Merge branch 'bug_7657' into 3.12-master

8 years agoBug 7657 - Google and OpenLibrary image conflict
Owen Leonard [Thu, 3 Jan 2013 17:53:23 +0000 (12:53 -0500)]
Bug 7657 - Google and OpenLibrary image conflict

The JavaScript files which output Google and OpenLibrary cover images
each assumes it is the only source for cover images running. Each script
isn't specific enough to filter out markup generated by the other. This
patch corrects the specificity of the selector looking for markup
related to Google and OpenLibrary covers.

To test, enable both Google and OpenLibrary cover images in the OPAC.
Perform a search which will return results which include titles which
have covers from both services. Confirm that these covers appear
correctly and that "no cover" information still works correctly.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Added corrected Javascript to CCSR theme.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_8883' into 3.12-master
Jared Camins-Esakov [Wed, 16 Jan 2013 01:05:02 +0000 (20:05 -0500)]
Merge branch 'bug_8883' into 3.12-master

8 years agoBug 8883: 'opacsmallimage' doesn't work in ccsr theme
Martin Renvoize [Mon, 31 Dec 2012 13:07:02 +0000 (13:07 +0000)]
Bug 8883: 'opacsmallimage' doesn't work in ccsr theme

This patch makes it possible to customize the CCSR theme using the
opacsmallimage system preference. It also enables the LibraryName
preference for opacsmallimage alt text.

To test, set the opacsmallimage preference and switch to the CCSR
theme. Your custom image should appear. Set the LibraryName preference
and confirm that the alt attribute of the custom logo changes
accordingly.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
This patch works correctly, although it lacked a description and test
plan, which I have added. I would have used IF instead of UNLESS because
to me that seems more readable, but it's not a deal-breaker.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_9215' into 3.12-master
Jared Camins-Esakov [Tue, 15 Jan 2013 04:28:50 +0000 (23:28 -0500)]
Merge branch 'bug_9215' into 3.12-master

8 years agoBug 9215 - non translatable string in manage-marc-import
Owen Leonard [Mon, 31 Dec 2012 16:41:19 +0000 (11:41 -0500)]
Bug 9215 - non translatable string in manage-marc-import

Status information about staged MARC record batches was being pulled
directly from the import_batches table where they are stored as English
strings. This patch puts a check on the status value into the template
so that translatable strings can be embedded.

To test, apply the patch and view both the table of staged MARC record
batches and details about individual batches. In the default 'en'
translation you should see import statuses displayed with a capital
letter ("Staged"). This indicates that the status is now being pulled
from the template.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_9182' into 3.12-master
Jared Camins-Esakov [Tue, 15 Jan 2013 04:24:02 +0000 (23:24 -0500)]
Merge branch 'bug_9182' into 3.12-master

8 years agoBug 9182: fix on sortable columns on Saved reports
Adrien Saurat [Fri, 4 Jan 2013 16:07:40 +0000 (17:07 +0100)]
Bug 9182: fix on sortable columns on Saved reports

When displaying the Saved reports, since 3.10 the number of columns is
higher but the datasorter parameters have not been changed accordingly.
It's thus impossible to sort on the author or the creation date, for
example.

TEST PLAN :
1) Check sortable columns before applying : some useful columns are not
sortable, while the last columns are sortable (but don't need to be).

2) Once the patch is applied, the "non sortable" columns are the correct
ones.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Colums for saved reports are all sortable correctly now.
All tests and qa script pass.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_7143' into 3.12-master
Jared Camins-Esakov [Tue, 15 Jan 2013 04:22:17 +0000 (23:22 -0500)]
Merge branch 'bug_7143' into 3.12-master

8 years agoBug 7143 updating history and about page
Chris Cormack [Thu, 27 Dec 2012 20:51:46 +0000 (09:51 +1300)]
Bug 7143 updating history and about page

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Changes look to be correct

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branches '3.12-master' and 'bug_7143' into bug_7143
Jared Camins-Esakov [Tue, 15 Jan 2013 04:21:29 +0000 (23:21 -0500)]
Merge branches '3.12-master' and 'bug_7143' into bug_7143

8 years agoMerge branch 'bug_6574' into 3.12-master
Jared Camins-Esakov [Tue, 15 Jan 2013 04:17:25 +0000 (23:17 -0500)]
Merge branch 'bug_6574' into 3.12-master

8 years agoBug 6574 - js error in en-GB and en-NZ translations due to improper quoting
Liz Rea [Fri, 28 Dec 2012 00:24:45 +0000 (13:24 +1300)]
Bug 6574 - js error in en-GB and en-NZ translations due to improper quoting

To replicate:

* install en-NZ translation (or en-GB)
* activate the new language, and select it for use
* pretend you are going to issue a book to a member (search for a member from "check out" in header)
* without the patch, the toolbar will be incorrect. The toolbar will also be incorrect on moremember.pl.

To test:
* apply the patch
* re-generate the en-NZ or en-GB translation
* activate the new language, or select it for use
* pretend you are going to issue a book to a member (search for a member from "check out" in header)
* with the patch, the toolbar will appear to be correct. It will also be correct on moremember.pl.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_8557' into 3.12-master
Jared Camins-Esakov [Tue, 15 Jan 2013 04:08:49 +0000 (23:08 -0500)]
Merge branch 'bug_8557' into 3.12-master

8 years agoBug 8557 - Unexpected behavior with scanners
Liz Rea [Wed, 12 Dec 2012 02:09:27 +0000 (15:09 +1300)]
Bug 8557 - Unexpected behavior with scanners

This is an alternative to the original implementation - this one works in chrome as well as firefox.

To test:

1)
Set syspref 'AcqCreateItem' to 'Create Item when receiving an order.'

2)
Create a basket for a vendor, add an order line.

3)
Search for this vendor using Vendor search

4)
Receive Shipment for this vendor and choose the title you ordered in 2)

5) You will get the dialog to create related item(s)

6)
Fill in Item 0 through o (see screenshot)

7)
Scan Barcode for field p - Barcode

7)
Result: Scanner sends a [return], form closes and you had no chance to fill in fields t - z

Signed-off-by: Marc Veron <veron@veron.ch>
Tested with Chrome Version 23.0.1271.97 m  and Firefox 17.0.1, both behave as expected.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested with Firefox and Chromium in Ubuntu.

Additional test done:
1) Add a new subscription, choose 'receive adds items'
2) Receive an issue, fill out $p with a barcode
3) Make sure hitting enter in the barcode field does not send the form.

All tests pass and QA script pass.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_9126' into 3.12-master
Jared Camins-Esakov [Tue, 15 Jan 2013 04:01:15 +0000 (23:01 -0500)]
Merge branch 'bug_9126' into 3.12-master

8 years agoBug 9126: Do not return from Check too early.
Julian Maurice [Wed, 21 Nov 2012 16:38:28 +0000 (17:38 +0100)]
Bug 9126: Do not return from Check too early.

If there is no errors, it should continue instead of returning true.

+ move a block of code at the end of Check function. This avoid
detaching and re-attaching a HTML block if there are errors.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
The following queries show us the issues:
select count(*) from items;
select * from aqorders_items where ordernumber=XX;

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
To test:

AcqCreateItem = receive
UniqueItemFields = barcode

1) Create a new basket
2) Create a new order with quantity > 1
3) Close the basket and create a new invoice/shipment
4) Receive only 1 item.
   - Fill out the first item form with item type only. Click add.
   - Don't change second item form at all.
   - Click save.

Before patch:
2 items are created on the record, both with the selected itemtype.

After patch:
Only 1 item is created, which is correct.

Signed-off-by: Elliott Davis <elliott@bywatersolions.com>
Seems to work as described by the test plan
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_9360' into 3.12-master
Jared Camins-Esakov [Tue, 15 Jan 2013 03:53:01 +0000 (22:53 -0500)]
Merge branch 'bug_9360' into 3.12-master

8 years agobug 9360 - Clean borrowers tool wording and layout problematic
Liz Rea [Tue, 8 Jan 2013 03:51:45 +0000 (16:51 +1300)]
bug 9360 - Clean borrowers tool wording and layout problematic

To test:

Verify that the text has been changed to "Batch patron deletion/anonymization in the following places:

* tools-home
* the page title
* the heading on cleanborrowers
* the menu on cleanborrowers

Verify that the tool still works as intended.

This (finally) fixes the things Owen pointed out.
changes check-out to checkout per Galen.

Signed-off-by: Marc Veron <veron@veron.ch>
Behaves as expected.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Fix indentation and tabulations characters
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_8433' into 3.12-master
Jared Camins-Esakov [Sun, 13 Jan 2013 13:42:53 +0000 (08:42 -0500)]
Merge branch 'bug_8433' into 3.12-master

8 years agoBug 8433 Remove unused 'use English'
Colin Campbell [Thu, 12 Jul 2012 16:11:14 +0000 (17:11 +0100)]
Bug 8433 Remove unused 'use English'

Adding a use English to mosules which dont may
waste a few CPU cycles and bytes of storage
but doesnt add anything to the sum of human happiness

Remove unnecessary use English's
Removed already commented out but equally unnrcessary
use Exporter in same modules

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_9292' into 3.12-master
Jared Camins-Esakov [Sun, 13 Jan 2013 13:39:00 +0000 (08:39 -0500)]
Merge branch 'bug_9292' into 3.12-master

8 years agoBug 9292 - Remove dead code related to 'publictype'
Kyle M Hall [Fri, 14 Dec 2012 19:40:14 +0000 (14:40 -0500)]
Bug 9292 - Remove dead code related to 'publictype'

This patch removes the superflous code related to 'publictype' which
is a key set for item hashes in some perl files. This key is never
used or stored.

Test Plan:
1) Apply patch
2) Test catalogue/detail.pl, opac/opac-detail.pl and opac/opac-user.pl
3) You should not see any changes in behavior

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_9065' into 3.12-master
Jared Camins-Esakov [Sun, 13 Jan 2013 13:32:21 +0000 (08:32 -0500)]
Merge branch 'bug_9065' into 3.12-master

8 years agoBug 9065 - set correct permission for upload local cover image
Fridolyn SOMERS [Wed, 9 Jan 2013 09:40:24 +0000 (10:40 +0100)]
Bug 9065 - set correct permission for upload local cover image

This patch fixes a problem where if a staff user has the
upload_local_cover_images permission (and is not a superlibrarian
and does not have all of the tools permissions), trying to use the
"Tools -> Upload local cover image" will fail with "You do not have
permissions [...]".

To test after applying the patch:

- Create a staff uesr that has just the catalogue and
  upload_local_cover_images permission.
- Log in as that staff user.
- Go to "Tools -> Upload local cover image".
- Verify that one is given the form to upload a cover image.
- Without the patch, one will be presented with the login
  form instead.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
mysql> select * from permissions where code="upload_cover_images";
Empty set (0.00 sec)

mysql> select * from permissions where code="upload_local_cover_images";
+------------+---------------------------+---------------------------+
| module_bit | code                      | description               |
+------------+---------------------------+---------------------------+
|         13 | upload_local_cover_images | Upload local cover images |
+------------+---------------------------+---------------------------+
1 row in set (0.00 sec)

"git grep upload_cover_images" returns 0 result.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_8977' into 3.12-master
Jared Camins-Esakov [Wed, 9 Jan 2013 13:18:34 +0000 (08:18 -0500)]
Merge branch 'bug_8977' into 3.12-master

8 years agoMerge branch 'bug_9076' into 3.12-master
Jared Camins-Esakov [Tue, 8 Jan 2013 03:02:20 +0000 (22:02 -0500)]
Merge branch 'bug_9076' into 3.12-master

8 years agoBug 9076 - QA Followup - Rename GetBorrowersWhoHaveNotBorrowedSince to GetBorrowersTo...
Kyle M Hall [Tue, 11 Dec 2012 19:07:48 +0000 (14:07 -0500)]
Bug 9076 - QA Followup - Rename GetBorrowersWhoHaveNotBorrowedSince to GetBorrowersToExpunge

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoBug 9076: Followup: FIX ergonomic issues
Jonathan Druart [Tue, 20 Nov 2012 13:34:09 +0000 (14:34 +0100)]
Bug 9076: Followup: FIX ergonomic issues

If no criteria is given, the form was submitted.
Labels were wrong

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoBug 9076 - Followup - Perltidy cleanborrowers.pl
Kyle M Hall [Wed, 14 Nov 2012 16:41:07 +0000 (11:41 -0500)]
Bug 9076 - Followup - Perltidy cleanborrowers.pl

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoBug 9076 - Add ability to delete borrowers by expiration date and category code to...
Kyle M Hall [Wed, 14 Nov 2012 16:40:21 +0000 (11:40 -0500)]
Bug 9076 - Add ability to delete borrowers by expiration date and category code to cleanborrowers.pl

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Tested per plan, works. Staff category is not shown, and patch passes automated testing.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_9335' into 3.12-master
Jared Camins-Esakov [Tue, 8 Jan 2013 02:13:11 +0000 (21:13 -0500)]
Merge branch 'bug_9335' into 3.12-master

8 years agoBug 9335 - humanMsg popups don't disapear in webkit browsers
Martin Renvoize [Mon, 31 Dec 2012 16:50:22 +0000 (16:50 +0000)]
Bug 9335 - humanMsg popups don't disapear in webkit browsers

The popup message that appears after saving changes to system
preferences should dissapear upon any user actions (i.e mouse
click, mouse move, typing) but this does not happen in modern
webkit based browsers since jQuery was updated.

This patch adds the suggested fix to the jQuery plugin code as
suggested on https://code.google.com/p/humanmsg/issues/detail?id=9

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Tested with Google Chrome on Windows 7

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Tested with Google Chrome 22 and Firefox on Debian
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Tested with the following browsers:
  Mac: Chrome 23, Firefox 16.0.2, Opera 11.61, Safari 5.1.7
  Windows: IE8, Firefox 3.6.26

8 years agoMerge branch 'bug_9141' into 3.12-master
Jared Camins-Esakov [Tue, 8 Jan 2013 01:49:12 +0000 (20:49 -0500)]
Merge branch 'bug_9141' into 3.12-master

8 years agoBug 9141 - Untranslatable strings on "pay an amount..." page
Owen Leonard [Mon, 26 Nov 2012 01:30:57 +0000 (20:30 -0500)]
Bug 9141 - Untranslatable strings on "pay an amount..." page

Moving text of an error message from the script into the
template. To test, submit an amount which is greater
than the amount due. You should see an error message
displayed correctly with a properly-formatted currency
amount.

Signed-off-by: Marc Veron <veron@veron.ch>
Patch behaves as expected.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_9346' into 3.12-master
Jared Camins-Esakov [Tue, 8 Jan 2013 01:47:41 +0000 (20:47 -0500)]
Merge branch 'bug_9346' into 3.12-master

8 years agoBug 9346 - acqui/neworderempty.pl ignores exchange rates and destroys user data on...
Dobrica Pavlinusic [Thu, 3 Jan 2013 22:38:17 +0000 (23:38 +0100)]
Bug 9346 - acqui/neworderempty.pl ignores exchange rates and destroys user data on page load

This restores behaviour of new order form before Bug 5335 merge

Test scenario:

1. load Receipt summary for existing customer
2. take note of Unit cost and Order cost
3. open existing order line and verify that Replacement cost,
   Budgeted cost and Total are not re-calculated on page load
4. change currency and verify that costs are updated
   (change currency to system default and all values should become
   same as vendor price)
5. change Quantity, get alert "You can't add a new item, please create a new order line"
   and verify that Total still reflects correct value

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Elliott Davis <elliott@bywatersolions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_9331' into 3.12-master
Jared Camins-Esakov [Tue, 8 Jan 2013 01:35:47 +0000 (20:35 -0500)]
Merge branch 'bug_9331' into 3.12-master

8 years agoBug 9331 - Untranslatable strings in ajax.js
Owen Leonard [Mon, 31 Dec 2012 15:59:59 +0000 (10:59 -0500)]
Bug 9331 - Untranslatable strings in ajax.js

This patch moves untranslatable strings from ajax.js into the template
where they can be picked up by the translation script.

To test that preference-related error messages continue to work,
open the system preferences editor in two tabs. Log out in one tab and
try to save a system preference in the other. You should see correct
error messages.

To test that error strings are now translatable, run "perl translate update
 <lang>" from misc/translator, then check if the affected strings shows
up in the po file.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Still works, and is now translatable

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_8984' into 3.12-master
Jared Camins-Esakov [Fri, 4 Jan 2013 13:40:00 +0000 (08:40 -0500)]
Merge branch 'bug_8984' into 3.12-master

8 years agoBug 8984: make Zebra more UNIMARC compliant
Mathieu Saby [Thu, 6 Dec 2012 18:00:07 +0000 (19:00 +0100)]
Bug 8984: make Zebra more UNIMARC compliant

This patch makes the following changes to record.abs, biblio-koha-indexdefs.xml and biblio-zebra-indexdefs.xsl :
- adding new (sub)fields to Identifier-standard index : 011f/g ; 012a ; 013a/z ; 014a/z ; 015a/z ; 016a/z ; 017a/z, 040a/z, 071z, 072z, 073z
- adding 1 new subfield to Publisher index : 071b (may contain the name of a music publisher)
- adding new (sub)fields to Author and  Identifier-standard index (for the $9) : 716, 72X, 730 - adding new (sub)fields to Note : 334$a (award note)
- correcting 207 and 208
- suppressing 308a and 328a in Note (useless as complete fields are indexed in same index)
- adding (sub)fields to Title index : 411t, 421-425t, 433-437t, 442-444t, 446-456t, 462-463t, 470-488t, 560
- adding (sub)fields to Subject and  Identifier-standard index (for the $9) : 608, 615, 616, 617, 620, 621
- adding some classifications index : 670, 675, 686 - adding some comments (to make easier further modifications and to identify non unimarc fields : 414-420, 603, 630-636, 646)

To test :
- take a record and fill some of the missing fields (e.g 488t, 608, 720, 012a) with some data as "field488", "field608" etc
- try to find the record => not possible
- apply the patch, copy the new record.abs in etc/zebradb/biblios/etc and rebuild zebra
- try to find the record => should be ok
- check nothing else is broken...
- same test with DOM indexing activated

http://bugs.koha-community.org/show_bug.cgi?id=8984
Signed-off-by: Zeno Tajoli <tajoli@cilea.it>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_8924' into 3.12-master
Jared Camins-Esakov [Fri, 4 Jan 2013 13:25:49 +0000 (08:25 -0500)]
Merge branch 'bug_8924' into 3.12-master

8 years agoBug 8924: Some modules erroneously skipped by 00-load
Jared Camins-Esakov [Tue, 1 Jan 2013 00:45:58 +0000 (19:45 -0500)]
Bug 8924: Some modules erroneously skipped by 00-load

Several patterns were being skipped unnecessarily in t/00-load.t:
* C4::Cache* - no longer exists
* C4::Record - no longer requires database
* C4::Serials - no longer requires database

To test:
1) Unset KOHA_CONF and/or shut down MySQL.
2) Run `prove t/00-load.t`
3) If the test passes, the patch is good.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
144 tests passing.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_9102' into 3.12-master
Jared Camins-Esakov [Fri, 4 Jan 2013 13:14:03 +0000 (08:14 -0500)]
Merge branch 'bug_9102' into 3.12-master

8 years agoBug 9102 : Set HttpOnly on the CGISESSID cookie
Chris Cormack [Sun, 18 Nov 2012 07:01:37 +0000 (20:01 +1300)]
Bug 9102 : Set HttpOnly on the CGISESSID cookie

https://www.owasp.org/index.php/HttpOnly

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
To test, use curl

Before the patch

% curl -I http://192.168.2.135
HTTP/1.1 200 OK
Date: Sun, 18 Nov 2012 06:56:49 GMT
Server: Apache/2.2.22 (Ubuntu)
Pragma: no-cache
Cache-control: no-cache
Content-script-type: text/javascript
Content-style-type: text/css
Set-Cookie: CGISESSID=19689f6e7d8ec94c25269fecebf2f009; path=/
Vary: Accept-Encoding
Content-Type: text/html; charset=UTF-8

After patch

 % curl -I http://192.168.2.135
HTTP/1.1 200 OK
Date: Sun, 18 Nov 2012 07:01:04 GMT
Server: Apache/2.2.22 (Ubuntu)
Pragma: no-cache
Cache-control: no-cache
Content-script-type: text/javascript
Content-style-type: text/css
Set-Cookie: CGISESSID=da25baf03c0bc1e2c512a627028e43e6; path=/; HttpOnly
Vary: Accept-Encoding
Content-Type: text/html; charset=UTF-8
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_7919' into 3.12-master
Jared Camins-Esakov [Wed, 2 Jan 2013 21:51:37 +0000 (16:51 -0500)]
Merge branch 'bug_7919' into 3.12-master

8 years agoBug 7919: FIX the "all" categories method
Jonathan Druart [Mon, 17 Dec 2012 10:04:07 +0000 (11:04 +0100)]
Bug 7919: FIX the "all" categories method

The C4::Category->all method must return fields from the categories
table only.
Without this patch, there is 2 "categorycode" values, the second one is
sometimes undef (if no branch limitation).

same for the GetBorrowercategoryList routine (some category codes are
undefined)

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Signed off for also fixing problems with patron searching noted by Katrin.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Problems fixed by this patch include:
- on patron search result list the category description is shown again
- it's possible to limit a patron search to a patron category again

All tests pass.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_9052' into 3.12-master
Jared Camins-Esakov [Sun, 30 Dec 2012 23:36:34 +0000 (18:36 -0500)]
Merge branch 'bug_9052' into 3.12-master

Conflicts:
koha-tmpl/opac-tmpl/prog/en/css/sco.css

8 years agoBug 9052 - followup: fix the YUI CSS locations for SCO
Robin Sheat [Tue, 18 Dec 2012 04:48:46 +0000 (17:48 +1300)]
Bug 9052 - followup: fix the YUI CSS locations for SCO

This is followup to the previous YUI-fixing patch, and simply causes the
self-checkout page to load the YUI files via the sco CSS file,
and that gets re-written at package build time to work.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested on a package installation using packages built by
Mirko Tietgen and a git dev installation.

To test:
1) Enable WebBasedSelfCheck system preference
2) Enter login date for staff user in AutoSelfCheckAllowed... prefernces
3) Go to the self checkout page:
   .../cgi-bin/koha/sco/sco-main.pl
4) Verify all pages have the usual look, CSS, Javascript and images
   look normal
5) Verify the same is true for translated templates

Manual: http://manual.koha-community.org/3.10/en/selfcheckout.html
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_8877' into 3.12-master
Jared Camins-Esakov [Sat, 29 Dec 2012 01:22:18 +0000 (20:22 -0500)]
Merge branch 'bug_8877' into 3.12-master

8 years agoBug 8877 [ENH] MARC21 field 511 missing from XSLT
Mirko Tietgen [Thu, 4 Oct 2012 21:02:00 +0000 (23:02 +0200)]
Bug 8877 [ENH] MARC21 field 511 missing from XSLT

Adds MARC21 field 511 to the OPAC XSLT file.

Signed-off-by: Marc Veron <veron@veron.ch>
COntents of field 511 appears as expected.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch changes OPAC XSLT display,
511 is shown as defined by the MARC21 standard.
If 1st indicator is 1, the label cast is shown in front of the 511 field.
If 1st indicator is 0 or empty, no label is shown.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_9209' into 3.12-master
Jared Camins-Esakov [Sat, 29 Dec 2012 01:16:12 +0000 (20:16 -0500)]
Merge branch 'bug_9209' into 3.12-master

8 years agoBug 9209: Skip tests for older DBD::Mock
Jared Camins-Esakov [Fri, 28 Dec 2012 01:14:57 +0000 (20:14 -0500)]
Bug 9209: Skip tests for older DBD::Mock

Because the calendar tests require a more recent version of DBD::Mock
than has been packaged by Debian, it makes sense to skip all the tests
requiring the database when only an older version is present.

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Works as advertised
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoBug 9209 - Mocked Koha::Calendar tests
Tomas Cohen Arazi [Tue, 4 Dec 2012 18:14:59 +0000 (15:14 -0300)]
Bug 9209 - Mocked Koha::Calendar tests

Using specific method for populating the internal data structures from Koha::Calendar
has yielded to the non-detection of several bugs. There are also several tests that where
db_dependent which is not always desirable.

I propose the use of DBD::Mock (::Session) for using the actual code used by Koha in production
for testing, mocking the DB queries itselves.

I also took the time to repeat several tests in different syspref configurations (they applied
only to daysMode=Calendar, and now cover all confs).

Notes:
- I used DBD:Mock 1.45 as previous version (1.43, from 12.04) was broken
- Some tests revealed a bug on days_between as I see it... reporting as Bug #9211

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_9272' into 3.12-master
Jared Camins-Esakov [Sat, 29 Dec 2012 01:13:40 +0000 (20:13 -0500)]
Merge branch 'bug_9272' into 3.12-master

8 years agoBug 9272: Eliminate error when deleting authorized value
Jonathan Druart [Wed, 12 Dec 2012 15:47:37 +0000 (16:47 +0100)]
Bug 9272: Eliminate error when deleting authorized value

Try to delete an authorized value. if you don't get any error, this
patch works.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Enabled debug, tried with and without Plack, works fine for both.

Signed-off-by: Elliott Davis <elliott@bywatersolions.com>
Works as advertised. Follows coding guidelines.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoRevert "Bug 8378 - <fine> syntax not working on overdues anymore"
Jared Camins-Esakov [Fri, 28 Dec 2012 03:34:41 +0000 (22:34 -0500)]
Revert "Bug 8378 - <fine> syntax not working on overdues anymore"

This reverts commit 40f9914e60e002ae4cbf10d09cff8bbf32abd8fe.

Per Colin's report (confirmed by Mathieu and Julian):
  "I've had some problems with this patch. With it applied I found
  overdues for multiple users getting the same user's overdue message
  text, eg user 1 gets their correct message but users 2, 3 and 4
  get it as well. reverting the patch corrected this. I've not tracked
  down the cause as yet."

8 years agoMerge branch 'bug_9284' into 3.12-master
Jared Camins-Esakov [Fri, 28 Dec 2012 00:02:31 +0000 (19:02 -0500)]
Merge branch 'bug_9284' into 3.12-master

8 years agoBug 9284 - JavaScript should follow rules recommended by JSHint
Owen Leonard [Thu, 13 Dec 2012 20:56:21 +0000 (15:56 -0500)]
Bug 9284 - JavaScript should follow rules recommended by JSHint

Coding style corrections to members.js:

- Mixed tab/space indentation converted to spaces.
- Converted "!=" and "==" to "!==" and "===" for comparisons with ''.
- Adding missing semicolons.

To test, create or edit a patron and confirm that validation hasn't been
broken by the changes to members.js: Invalid date, empty required
fields, guarantor popup, restricted-until field display, etc.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_8299' into 3.12-master
Jared Camins-Esakov [Thu, 27 Dec 2012 23:50:50 +0000 (18:50 -0500)]
Merge branch 'bug_8299' into 3.12-master

8 years agoBug 8299 - overdue_notice.pl shows error messages
Mason James [Tue, 11 Dec 2012 13:43:29 +0000 (02:43 +1300)]
Bug 8299 - overdue_notice.pl shows error messages

fixes 2 warnings...

 Use of uninitialized value in pattern match (m//) at /usr/share/koha/bin/cronjobs/overdue_notices.pl line 659.
 Use of uninitialized value in pattern match (m//) at /usr/share/koha/bin/cronjobs/overdue_notices.pl line 670.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_8712' into 3.12-master
Jared Camins-Esakov [Thu, 27 Dec 2012 23:40:45 +0000 (18:40 -0500)]
Merge branch 'bug_8712' into 3.12-master

8 years agoBug 8712 - We should use WAI-ARIA guidelines to help with accessibility
Srikanth Dhondi [Tue, 16 Oct 2012 23:10:05 +0000 (12:10 +1300)]
Bug 8712 - We should use WAI-ARIA guidelines to help with accessibility

Added title to the search box

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_6261' into 3.12-master
Jared Camins-Esakov [Thu, 27 Dec 2012 23:37:28 +0000 (18:37 -0500)]
Merge branch 'bug_6261' into 3.12-master

8 years agoBug 6261 [Revised] Consolidate patron toolbar include files
Owen Leonard [Thu, 15 Nov 2012 20:33:23 +0000 (15:33 -0500)]
Bug 6261 [Revised] Consolidate patron toolbar include files

The staff client has two almost identical include files which
can be consolidated: circ-toolbar.inc and members-toolbar.inc.
This patch marges the slight differences between them and
eliminates circ-toolbar.inc, that being the one which was used
on fewer pages.

In order to accommodate the different "destination" variable
for operations which redirect back either to circ or patrons,
circulation.pl defines "destination" in the template.

Revision corrects a redirect error in setstatus.pl which
predates this patch but which never showed up until now.

To test, perform various operations from the toolbar on at least
two pages: circulation.pl and moremember.pl.

Operations: Edit, add child, duplicate, change password, print (all
options), search to hold, renew, set permissions, delete, update child
to adult, and export checked-in barcodes. In most cases simply
confirming that the link takes you to the right place is enough.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_9289' into 3.12-master
Jared Camins-Esakov [Thu, 27 Dec 2012 23:33:29 +0000 (18:33 -0500)]
Merge branch 'bug_9289' into 3.12-master

8 years agoBug 9289 - Adjacent checkbox behavior broken on circulation.pl
Owen Leonard [Fri, 14 Dec 2012 17:45:04 +0000 (12:45 -0500)]
Bug 9289 - Adjacent checkbox behavior broken on circulation.pl

This patch fixes the behavior of adjacent checkboxes in the list of
checkouts on circulation.pl. Checkboxes in both the "renew" and "check
in" columns should not be able to be checked at the same time.

A line was commented out (by me) which was necessary to this working
correctly. I'm guessing it was done in debugging and left by mistake.

To test, load a patron for checkout who has items checked out. You
should not be able to check boxes in both the "renew" and "check in"
columns in the same row, whether you click the checkbox itself or the
containing table cell.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoRevert "Bug 7167: New version for updatedatabase"
Jared Camins-Esakov [Thu, 27 Dec 2012 19:02:56 +0000 (14:02 -0500)]
Revert "Bug 7167: New version for updatedatabase"

This reverts commit c9cb55ef4710bfee111e6e2721f3ca2bf58d98f7.

8 years agoRevert "Bug 7167 follow-up setting DBrevision, before pushing"
Jared Camins-Esakov [Thu, 27 Dec 2012 19:02:55 +0000 (14:02 -0500)]
Revert "Bug 7167 follow-up setting DBrevision, before pushing"

This reverts commit 49d6b750cd09abfe8943720c1648894ce3aaced2.

8 years agoRevert "Bug 7167: Followup: Removes useless global variables"
Jared Camins-Esakov [Thu, 27 Dec 2012 19:02:54 +0000 (14:02 -0500)]
Revert "Bug 7167: Followup: Removes useless global variables"

This reverts commit 754392ed88a22aac43172d7e12f4621dae8d8484.

8 years agoRevert "Bug 7167: Adds Unit tests for C4::Update::Database"
Jared Camins-Esakov [Thu, 27 Dec 2012 19:02:52 +0000 (14:02 -0500)]
Revert "Bug 7167: Adds Unit tests for C4::Update::Database"

This reverts commit 69c19e28b49d1732601c79c9aacf8de4b754b9d8.

8 years agoRevert "Bug 7167: Set final updatedatabase.pl version"
Jared Camins-Esakov [Thu, 27 Dec 2012 19:02:50 +0000 (14:02 -0500)]
Revert "Bug 7167: Set final updatedatabase.pl version"

This reverts commit c34017336c3cd03f471b1c5100b9f6b4dbe589db.

8 years agoBug 7167: Set final updatedatabase.pl version
Jared Camins-Esakov [Thu, 27 Dec 2012 16:17:00 +0000 (11:17 -0500)]
Bug 7167: Set final updatedatabase.pl version

8 years agoBug 7167: Adds Unit tests for C4::Update::Database
Jonathan Druart [Mon, 3 Dec 2012 14:27:46 +0000 (15:27 +0100)]
Bug 7167: Adds Unit tests for C4::Update::Database

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
8 years agoBug 7167: Followup: Removes useless global variables
Jonathan Druart [Mon, 3 Dec 2012 15:39:10 +0000 (16:39 +0100)]
Bug 7167: Followup: Removes useless global variables

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
8 years agoBug 7167 follow-up setting DBrevision, before pushing
Paul Poulain [Wed, 28 Nov 2012 13:48:28 +0000 (14:48 +0100)]
Bug 7167 follow-up setting DBrevision, before pushing

The 2 files C4/Auth.pm and install.pl *must* have the $version variable
set to what is the last old-mechanism for updatedatabase

This patch set to 3.11.00001 that is the last number when I QA this patch

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
8 years agoBug 7167: New version for updatedatabase
Jonathan Druart [Thu, 14 Jun 2012 09:46:57 +0000 (11:46 +0200)]
Bug 7167: New version for updatedatabase

This patch use DataTable, see BUG|BZ 6836
      - css/datatables.css
      - lib/jquery/plugins/jquery.dataTables.min.js
      - js/datatables.js

http://bugs.koha-community.org/show_bug.cgi?id=7167

Bug 7167 follow-up

Major changes:
* creating database tables for update on the fly, the  1st time the update script is called
* version is checked on mainpage.pl (and here only). If syspref Version differ from kohaversion.pl, the old updatedatabase is launched. If there are updates missing from new mechanism, the updatedatabase page is reached
* kohaversion check on each page is now useless in Auth.pm, removed dead code
* Updated installer: at the end of the process, retrieve all updates and automatically mark them "OK", as they're included in installer

Minor changes:
* adding copyright
* adding poddoc
* updating a warning, for better clarity
* switching from $$var to $var->
* small TT glitch fixed in updatedatabase.tt
* about.pl now returns the Version systempreference PLUS all the patches that have been applied

Bug 7167 follow-up perlcritic & numbers display & partial apply depending on DEBUG

* add use strict to updatedatabase, that is now perlcritic compliant
* partial apply of DB revs is now managed by DEBUG env variable = if DEBUG=0, the user can just apply every DBrev. If DEBUG=1, we're in a dev env, the user know has the option to apply DBrevs one by one
Display:
* in updatedatabase, small spelling changes
* in about.pl, remove 0 just after . (3.06.01 is displayed as 3.6.1)
* improve the display of applied numbers on about.pl
 - before this patch, if you have N, N+1, N+2, N+3 and N+10 DB rev applied, about was displaying : , N+1 / N+2 / N+3 / N+10
 - after this patch you have N......N+3 / N+10
* add ORDER BY into list_versions_already_knows to have number retrieved in the same order whatever the order they are applied

http://bugs.koha-community.org/show_bug.cgi?id=6679
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167: Improve the update.pl script

 * Added CLI options to update.pl
 * Call update.pl from the installer.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167: Now, we check versions on mainpage.pl and after login

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167: Reimplementing Marcel's suggestions & fixes

 * Fixing the bugguy old version check (that was made against 3.0900000 instead of 3.0900027 -the last current kohaversion number
 * in the CLI script, if there is nothing to report, just say it

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Bug 7167: Remove check_coherency

As suggested by Katrin, we've removed the call to check_coherency. It intended to provide readable comments when some SQL was wrong. Removing this sub result in the SQL error being displayed. That's OK because the sysadmin or the developer can google the error, understand it, then fix it.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167: Changing in .sql parsing

We first split on delimiter and then extract comments. You can now put
\n for delimiter comments.
ex:

DELIMITER ;
-- this is a comment
SELECT * FROM  my_table;
-- another comment

Before this patch, we had to write:
DELIMITER ;
-- this is a comment;
SELECT * FROM  my_table;
-- another comment;

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167: Add .pl and .sql examples

Those files are in version directory, so will never be executed by the updater
If you want to provide an update, do it in a 3.09/ directory (if your update is expected for 3.10 version)

Note that the updater use a md5sum checker. So, if the same update is in 2 different places, it will be detected. That will be handy for changes made on both stable and master: a library running stable will get the update when updating. When upgrading to the next major release, Koha will detect the patch has already been applied, and no error will be thrown. With the previous mechanism, a DBRev ported to stable was re-executed when upgrading to master, resulting in a nasty (but usually harmless) error message

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167: Improve display + factorize get_queries

Despite it's size, this patch is dealing with display questions only:
 * The text "comments" and "queries" was hardcoded in ajax-updatedb-getinfo.pl script. It has been replaced by a JSON call, returning 2 separate values, "comments:" and "queries:" is now in the template, making it translatable
 * Some minor tweak in the display (like putting things in bold, displaying OK in green, warnings in yellow and KO in red)
 * Reordering the column headers for more readability:
    * Status column is merged with availability, column is after status
    * Status/availability terms more clear: "Not applied" instead of "unknown", "Applied and OK", "Applied and failed", "Applied and forced" are the 3 other statuses
    * Removed one click to display comments on DBREv not yet applied: before the patch, one had to click "Show details", then "Get comments", now, "Get comments" is enough

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167: FIX typos & moving a script to a proper place

* renamed availables to available
* renamed already_knows to already_applied
* fixed FSF & copyright headers
* removing a "use strict" because we already had use Modern::Perl
* fixed a tiny typo in about.tt

* moving update.pl to misc/bin because it's a CLI script

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167: Add dependency File::Find::Rule

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167: We want to execute non-numeric version with the -all option

Dealing with Marcel comment 100:
> Note that the current code around line 52/53 does not
> handle that correctly:
> Argument "\x{74}\x{65}..." isn't numeric in numeric ge (>=) at
> installer/data/mysql/update.pl line 52.

Now, a non-numeric DBRev will be applied if you provide the --all parameter, without throwing the error

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167 reindentation & removing dead code

* The if (! defined $ENV{PERL5LIB}... block was wrongly intented
* The 3 lines running update.pl are useless: the update (new mechanism) is run from admin/updatedatabase.pl script. This part of install.pl is run only when you have "old style" DB revisions.

Summary:
 * old mechanism = it's run as previously, by reaching the installer/install.pl?step=3 page, that applies all revisions
 * new mechanism = when you log-in or reach mainpage.pl, you reach admin/updatedatabase.pl, where you can see what will be run, and run it

Tiny side effect = the check for old mechanism is now done *after* authentification (thus it's not done on each page call). It means that the user will have to enter login/password twice :
 * first to log-in to Koha
 * second to run installer/updatedatabase.pl?step=3
As the old mechanism is deprecated, we can expect this will happend only a few time in the history of a setup, it's not a big deal.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167: Don't raise an error in routine TableExists

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167: FIX merge

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167: Add .pl and .sql examples

Those files are in version directory, so will never be executed by the updater
If you want to provide an update, do it in a 3.09/ directory (if your update is expected for 3.10 version)

Note that the updater use a md5sum checker. So, if the same update is in 2 different places, it will be detected. That will be handy for changes made on both stable and master: a library running stable will get the update when updating. When upgrading to the next major release, Koha will detect the patch has already been applied, and no error will be thrown. With the previous mechanism, a DBRev ported to stable was re-executed when upgrading to master, resulting in a nasty (but usually harmless) error message

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 7167 follow-up fix POD syntax to please koha-qa.pl
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoAdd Bernardo Gonzalez Kriegel to history
Jared Camins-Esakov [Thu, 27 Dec 2012 15:17:27 +0000 (10:17 -0500)]
Add Bernardo Gonzalez Kriegel to history

Welcome, Bernardo, you are the 198th committer to Koha!

8 years agoBug 9315: Bad version of String::Random reported by koha_perl_deps.pl
Bernardo Gonzalez Kriegel [Fri, 21 Dec 2012 22:22:45 +0000 (19:22 -0300)]
Bug 9315: Bad version of String::Random reported by koha_perl_deps.pl

This patch fixes version number of String::Random as reported by
koha_perl_deps.pl

To test (on master)
1) run perl koha_perl_deps.pl -u, it will show as required String::Random version 1.4
2) apply the patch
3) run koha_perl_deps.pl -u, it will show (or not) as required String::Random version 0.22

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Patch works correctly according to the test plan.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge branch 'bug_7368' into 3.12-master
Jared Camins-Esakov [Thu, 27 Dec 2012 15:14:45 +0000 (10:14 -0500)]
Merge branch 'bug_7368' into 3.12-master

8 years agoBug 7368: Update GetXmlBiblio documentation
Marcel de Rooy [Mon, 10 Dec 2012 08:30:08 +0000 (09:30 +0100)]
Bug 7368: Update GetXmlBiblio documentation

Only changing some documentation about GetXmlBiblio

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Added the word 'contain'

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
8 years agoMerge branch 'bug_7143' into 3.12-master
Jared Camins-Esakov [Thu, 27 Dec 2012 15:12:16 +0000 (10:12 -0500)]
Merge branch 'bug_7143' into 3.12-master

8 years agoBug 7143 adding Kiriaki Roditi as translator
Paul Poulain [Tue, 18 Dec 2012 17:14:06 +0000 (18:14 +0100)]
Bug 7143 adding Kiriaki Roditi as translator

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoBug 9183: Refactor ZOOM event loop
Jared Camins-Esakov [Sat, 1 Dec 2012 03:45:48 +0000 (22:45 -0500)]
Bug 9183: Refactor ZOOM event loop

Prior to this patch, there were three identical ZOOM event loops in
C4::Search. This is wasteful, and goes against all good programming
practice. This patch refactors the ZOOM event loops into a separate
subroutine which is called by SimpleSearch, searchResults, and
GetDistinctValues call.

The new routine, _ZOOM_event_loop process the ZOOM event loop and,
once it has been fully processed, passes control to a closure provided
by the calling routine for processing the results, and destroys the
result sets.

To test (after applying patch):
1) Do a regular bibliographic search that should return results.
2) Do a search in the Cataloging module that should return results.
3) If you get results from both searches, the patch works.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoBug 9009: Increment version number
Jared Camins-Esakov [Thu, 27 Dec 2012 15:05:56 +0000 (10:05 -0500)]
Bug 9009: Increment version number

Database update for bug 9009 has been given version 3.11.00.014

8 years agoBug 9009 - Add separate user js and css for SCO module
Kyle M Hall [Mon, 5 Nov 2012 17:22:24 +0000 (12:22 -0500)]
Bug 9009 - Add separate user js and css for SCO module

Add system preferences SCOUserCSS and SCOUserJS to define separate CSS and JavaScript for the Self Checkout Module.

Test plan:
1) Apply patch
2) Run updatedatabase.pl
3) Add something arbitrary to the new sysprefs SCOUserCSS and SCOUserJS ( such as TestCSS and TestJS ).
4) Load the SCO module in a browser, and view the HTML, verify the CSS and JS values in the system preferences have been included.

Signed-off-by: Marc Veron <veron@veron.ch>
I tested with an alert('hello') as JavaScript and some background-color for the CSS. Worked as expected.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoBug 9162: Increment version number
Jared Camins-Esakov [Thu, 27 Dec 2012 14:57:27 +0000 (09:57 -0500)]
Bug 9162: Increment version number

Database update for bug 9162 has been given version 3.11.00.013

8 years agoBUG 9162 - Add a system preference to set which notes fields appears on title notes...
Vitor FERNANDES [Wed, 28 Nov 2012 11:07:54 +0000 (11:07 +0000)]
BUG 9162 - Add a system preference to set which notes fields appears on title notes/description separator

Added a new system preference to control the fields to not appear in the separator.
Change GetMarcNotes to use the system preference created to only appear the fields that aren't in the list,

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
FIX some indentation in C4/Biblio.pm
+FIX 1 end of parentheses in sysprefs.sql
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoBug 9206: Increment version number
Jared Camins-Esakov [Thu, 27 Dec 2012 14:48:58 +0000 (09:48 -0500)]
Bug 9206: Increment version number

Database update for bug 9206 has been given version 3.11.00.012

8 years agoBug 9206: Followup QA FIX
Jonathan Druart [Wed, 26 Dec 2012 13:52:52 +0000 (14:52 +0100)]
Bug 9206: Followup QA FIX

- Fix indentation
- It is useless to loop on all items. If at least 1 item is already
  issued, we want to return 1.

8 years agoBug 9206 - Only allow place holds in records that the patron don't have in his posses...
Kyle M Hall [Fri, 14 Dec 2012 14:13:49 +0000 (09:13 -0500)]
Bug 9206 - Only allow place holds in records that the patron don't have in his possession - QA Followup

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
8 years agoBug 9206 - Only allow place holds in records that the patron don't have in his possession
Vitor FERNANDES [Tue, 4 Dec 2012 15:57:35 +0000 (15:57 +0000)]
Bug 9206 - Only allow place holds in records that the patron don't have in his possession

Added a system preference to turn on/off this feature.
By default the system allow the patron to place holds even if it is in his possession.
Script to place holds check if the system preference is off and if patron has at least one item to block holds.
Messages to say that are already in patron possession added to templates.
Method to check if patron has one issue from one record added to C4::Circulation

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoBug 8377 follow-up: fix update message
Jared Camins-Esakov [Thu, 27 Dec 2012 14:45:50 +0000 (09:45 -0500)]
Bug 8377 follow-up: fix update message

Add the bug number to the updatedatabase message.

8 years agoBug 8377: Increment version number
Jared Camins-Esakov [Thu, 27 Dec 2012 14:28:29 +0000 (09:28 -0500)]
Bug 8377: Increment version number

Database update for bug 8377 has been given version 3.11.00.011

8 years agoBug 8377: Followup move style in a css file and do not pass template to a pm
Jonathan Druart [Fri, 9 Nov 2012 14:12:59 +0000 (15:12 +0100)]
Bug 8377: Followup move style in a css file and do not pass template to a pm

1/ It's better to set style of the video marked in a css file.

2/ Replace some
  for my $i in (0..#$array)
with
  for my $element in (@array)

3/ the routine in a pm returns a hash not the $template variable

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>