koha.git
8 years agoMerge remote-tracking branch 'origin/new/bug_8520'
Paul Poulain [Fri, 14 Sep 2012 15:39:12 +0000 (17:39 +0200)]
Merge remote-tracking branch 'origin/new/bug_8520'

8 years agoBug 8520 - Authorities summary incorrect on posible duplicate notice
Tomas Cohen Arazi [Mon, 3 Sep 2012 18:01:38 +0000 (15:01 -0300)]
Bug 8520 - Authorities summary incorrect on posible duplicate notice

We didn't notice this one with jcamins when we fixed this bug.

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8428 - can't save contracts
Owen Leonard [Thu, 23 Aug 2012 17:01:02 +0000 (13:01 -0400)]
Bug 8428 - can't save contracts

When I replaced the old calendar widget with the jQueryUI version
we lost a JavaScript function which is required by a couple of
pages: Date_from_syspref. This patch adds the function back
to the calendar include and corrects variables in the two
affected templates to make it work again.

To test:

- create a new contract. Submitting should work properly and
  without JavaScript errors.
- Open the serials claims page (serials/claims.pl) and filter
  the results by date. Submitting the filter form should
  work properly and without JavaScript errors.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Both tests passed.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoMerge remote-tracking branch 'origin/new/bug_7417'
Paul Poulain [Fri, 14 Sep 2012 15:22:47 +0000 (17:22 +0200)]
Merge remote-tracking branch 'origin/new/bug_7417'

8 years agoBug 7417 follow-up: fix a perlcritic violation
Jared Camins-Esakov [Thu, 13 Sep 2012 17:39:13 +0000 (13:39 -0400)]
Bug 7417 follow-up: fix a perlcritic violation

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 8653 remove erroneous whitespace blocking indexing
Colin Campbell [Thu, 16 Aug 2012 17:19:20 +0000 (18:19 +0100)]
Bug 8653 remove erroneous whitespace blocking indexing

The superfluous whitespace after the definition of subject
tag $9s is causing an error when carried over into dom config
files so that the authority links fail to index

Also removed the (harmless) trailing space in the equivalent
Unimarc files

A good editor and git can help in not creating excess whitespace

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years ago7675 New script for changing selinux file labels on perl scripts
Marcel de Rooy [Thu, 8 Mar 2012 13:36:42 +0000 (14:36 +0100)]
7675 New script for changing selinux file labels on perl scripts

On some Linux distributions like RedHat, Fedora, CentOS you can use SELinux for enhanced security. Among others, this involves file labeling (security context). In other distributions SELinux can be installed additionally.

The attached script lets you update and restore such labels on the perl scripts in a Koha installation.

July 18, 2012: Added opac/svc.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 8629: update of statistics fields on fund selection in order creation/edition
Fridolyn SOMERS [Mon, 13 Aug 2012 11:55:11 +0000 (13:55 +0200)]
Bug 8629: update of statistics fields on fund selection in order creation/edition

Signed-off-by: Marc Veron <veron@veron.ch>
Followed test plan in comment #1
Behaves as described in the test plan.
Useful feature!

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 4173: Followup: Document KohaAuthorisedValues plugin
Kyle M Hall [Thu, 6 Sep 2012 13:23:08 +0000 (09:23 -0400)]
Bug 4173: Followup: Document KohaAuthorisedValues plugin

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 4173: Followup: put the lib into a variable
Jonathan Druart [Wed, 25 Jul 2012 14:20:30 +0000 (16:20 +0200)]
Bug 4173: Followup: put the lib into a variable

Prevent 2 calls instead of 1

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 4173 - Statuses not appearing in the OPAC
Kyle M Hall [Thu, 12 Jul 2012 14:48:12 +0000 (10:48 -0400)]
Bug 4173 - Statuses not appearing in the OPAC

For the authorised values LOST and DAMAGED, if an OPAC description
is defined for the given value, display that description in the OPAC
rather than the generic description.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
8 years agoBug 8420: tool statisticfines.pl and hourly loan
Fridolyn SOMERS [Mon, 27 Aug 2012 07:43:04 +0000 (09:43 +0200)]
Bug 8420: tool statisticfines.pl and hourly loan

Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoMerge remote-tracking branch 'origin/new/bug_8743'
Paul Poulain [Fri, 14 Sep 2012 14:07:36 +0000 (16:07 +0200)]
Merge remote-tracking branch 'origin/new/bug_8743'

Conflicts:
installer/data/mysql/updatedatabase.pl

8 years agoBug 8743 follow-up, throw a more explanatory error message
Paul Poulain [Fri, 14 Sep 2012 13:59:50 +0000 (15:59 +0200)]
Bug 8743 follow-up, throw a more explanatory error message

When testing bug 8743, I discovered a missing index in my authority file.
The error message was
"CCL parsing error (10014) Unknown qualifier ZOOM"

which is not very helpfull because it does not show the query that was made.
This patch add the query itself after the zebra error

8 years agoBug 8743: ZOOM error when merging authority change to biblios
Jared Camins-Esakov [Sun, 9 Sep 2012 12:18:05 +0000 (08:18 -0400)]
Bug 8743: ZOOM error when merging authority change to biblios

The merge fails and the following errors appear in the log:
[Sun Sep 02 23:38:10 2012] [error] [client 75.149.175.233] ZOOM error 25
"Specified element set name not valid for specified database" (addinfo:
"F") from diag-set 'Bib-1', referer:
http://****/cgi-bin/koha/authorities/authorities.pl?authid=3010
[Sun Sep 02 23:38:11 2012] [error] [client 75.149.175.233] Premature end of
script headers: authorities.pl, referer:
http://****/cgi-bin/koha/authorities/authorities.pl?authid=3010

Test plan:
1) Set dontmerge to "Do"
2) Find an authority that is linked to a bib record.
3) Edit the main entry of the authority.
4) Save the authority record.
5) Notice that you got a nasty error and the bib record was not updated.
6) Apply patch.
7) Edit the main entry of the authority again (you can just set it back
   to what it was to start with).
8) Save authority record.
9) Notice that there was no error, and the bib record was updated.
10) Sign off.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8002 follow-up for the follow-up, DBRev number
Paul Poulain [Fri, 14 Sep 2012 13:46:08 +0000 (15:46 +0200)]
Bug 8002 follow-up for the follow-up, DBRev number

8 years agoBug 8002: FIX Change datatype from varchar 1 to 10 for borrower_attribute_types.categ...
Jonathan Druart [Thu, 6 Sep 2012 14:03:42 +0000 (16:03 +0200)]
Bug 8002: FIX Change datatype from varchar 1 to 10 for borrower_attribute_types.category_code

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8002: FIX Change datatype from varchar 1 to 10 for borrower_attribute_types.categ...
Jonathan Druart [Thu, 6 Sep 2012 14:03:42 +0000 (16:03 +0200)]
Bug 8002: FIX Change datatype from varchar 1 to 10 for borrower_attribute_types.category_code

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 6976 Close loophole allowing borrowers extra holds via opac
Colin Campbell [Tue, 28 Aug 2012 13:34:55 +0000 (14:34 +0100)]
Bug 6976 Close loophole allowing borrowers extra holds via opac

The check that the max number of reserves has
not been reached needs to take account of the fact
that we may have added enouch reserves to
reach the limit while this script is running.
Add a check against the incrementing count

The variable canreserve was only used when looping
through multiple holds but was not being
reinitialized on every iteration
make variable local to loop it is used in and
initialize to zero

Have used perltidy to correct the indention of
the while loop as it was misleading to the reader

Some numeric comparisons were using a string operator
fix them before strange bugs manifest themselves

The loophole manifests thus:
borrowers are only allowed Y holds.
If holds are done individually, it is
obeying that law i.e. X has held Y separate books –
 when I tried to do a 6th
book it told me that I could not place a hold.
However, if a borrower checks the catalogue,
gets the intial list up and clicks items on the “results”
box and then clicks “place hold” they can hold more than Y
items Please enter the commit message for your changes. Lines starting

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8447: Make sure we have enough subfields for broader_headings
Jared Camins-Esakov [Fri, 7 Sep 2012 14:58:53 +0000 (10:58 -0400)]
Bug 8447: Make sure we have enough subfields for broader_headings

Thanks to wajasu for providing the debugging information, as I cannot
seem to duplicate the problem, even seeing where it could come from.

Fix corrects cases where upon save, a software error complaing about
indicators being wrong as a side effect of a poorly autogenerated
biblio/authority record.

Behvior with this fix causes existing bilio data to to be preserved
while linking to the authority via subtag 9.

Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8418: load repeating holidays hash correctly
Colin Campbell [Tue, 14 Aug 2012 14:38:05 +0000 (15:38 +0100)]
Bug 8418: load repeating holidays hash correctly

The repeating holidays structure was being loaded in
a different order to how it was tested

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8656 Calendar needs to load both exception and nonexception dates
Colin Campbell [Mon, 20 Aug 2012 14:24:58 +0000 (15:24 +0100)]
Bug 8656 Calendar needs to load both exception and nonexception dates

single_holidays and exception_holidays were both being selected
with the same parameter with the result that single holidays were not
being loaded.

Have removed the retrieval of the unused parameters title and
description.

In effect the distinction is not meaningful for these routines and
the two structures could become one. This patch just fixes the
current bug

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8071: link between bib and authorities with the authid
Fridolyn SOMERS [Wed, 25 Jul 2012 15:59:54 +0000 (17:59 +0200)]
Bug 8071: link between bib and authorities with the authid

Do not automatically populate $9 in bibliographic headings when the
$9 is set in the authorized heading field of the authority record.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8719: Private lists always sorted by title
Adrien Saurat [Tue, 4 Sep 2012 11:59:35 +0000 (13:59 +0200)]
Bug 8719: Private lists always sorted by title

Virtualshelves:
The private lists were sorted by title, even when author or date was selected.
This patch corrects this behaviour.

Signed-off-by: Marc Veron <veron@veron.ch>
With this patch lists sort as expected.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8721: Fixes minor typo in AllowItemsOnHoldCheckout
Nicole C. Engard [Tue, 4 Sep 2012 15:22:48 +0000 (11:22 -0400)]
Bug 8721: Fixes minor typo in AllowItemsOnHoldCheckout

Small string fix to remove repeated word.

Signed-off-by: Marc Veron <veron@veron.ch>
Tiny typo fix

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8730 - browse overlaying powered by
Owen Leonard [Thu, 6 Sep 2012 19:02:29 +0000 (15:02 -0400)]
Bug 8730 - browse overlaying powered by

This patch adds a "z-index" property to the CSS for
the browse results menu so that it will appear
on top of the "Powered by Koha" link.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8641 - Add information warning about log-in as root user to About->System information
Marc Veron [Tue, 14 Aug 2012 18:45:22 +0000 (20:45 +0200)]
Bug 8641 - Add information warning about log-in as root user to About->System information

Add warning to 'About->System information' if an user is logged in as
database admiinsitrative user (root user).

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8017 reduce manipulation of GetAllIssues return
Colin Campbell [Fri, 27 Apr 2012 17:20:08 +0000 (18:20 +0100)]
Bug 8017 reduce manipulation of GetAllIssues return

GetAllIssues can produce large lists
For performance purposes:
Dont loop over the list without cause
Dont do expensive processing in the loop
Dont needlessly copy the array
Do display formatting in the template
Dont extract the barcode list unless we are producing it
Reduce db calls by using the data to hand

Make the table in the template a bit more readable
where everything was stuffed into one line

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 4118 follow-up DBRev number
Paul Poulain [Thu, 13 Sep 2012 16:51:08 +0000 (18:51 +0200)]
Bug 4118 follow-up DBRev number

8 years agoBug 4118 - Add Collection Code to Statistics Table
Kyle M Hall [Fri, 5 Feb 2010 16:04:53 +0000 (16:04 +0000)]
Bug 4118 - Add Collection Code to Statistics Table

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
8 years agoBug 7583 follow-up DBRev number
Paul Poulain [Thu, 13 Sep 2012 16:42:06 +0000 (18:42 +0200)]
Bug 7583 follow-up DBRev number

8 years agoBug 8339 - div id="login" should be id="login_controls" in header.inc
Mark Tompsett [Tue, 11 Sep 2012 16:57:43 +0000 (00:57 +0800)]
Bug 8339 - div id="login" should be id="login_controls" in header.inc

After experiencing what I believe was stale CSS, I have
implemented oleonard's suggested fix which does work. That is:
header.inc change login to login_controls, and in
staff-global.css change the #login to #login_controls.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7583 follow-up: Prevent users to cancel receipt if they can't
Julian Maurice [Mon, 13 Aug 2012 14:34:35 +0000 (16:34 +0200)]
Bug 7583 follow-up: Prevent users to cancel receipt if they can't

Disable the link for cancelling instead of displaying an error message
after the click. This is only valid if parent order line is received,
not if it's deleted.
When the user gets his mouse over the disabled link, he gets a message
telling him which order (ordernumber) blocks him so he knows immediately
which receipt to cancel.
Also improve error messages for non technical people

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7583: Cancel a receipt
Julian Maurice [Wed, 8 Aug 2012 09:06:45 +0000 (11:06 +0200)]
Bug 7583: Cancel a receipt

In acqui/parcel.pl, there is now the possibility to cancel a receipt.
In "Already received" table, just click on "Cancel receipt" and the
order line will go back to pending orders.
If it was a partial receipt, order line is merged to its 'parent' line.
Attached items are modified so that they become attached to the merged
order line.
If AcqCreateItem is 'receiving', attached items are deleted.
If an order line was first partially received, and then completed. You
must cancel the 'parent' order line before cancelling the 'child'.

Signed-off-by: Marc Veron <veron@veron.ch>
The patch behaves like expected, and the feature is really helpfull.

Just a tiny remark about the following message:

-------------
Cannot cancel receipt. Possible reasons :
You are trying to cancel the receipt of an order line whose parent order line is already received. Cancel this parent order line and retry.
-------------

Maybe it would be good
- to explain a little bit more why it happend and re-word the message for non technical people (not everybody understands 'parent' the same way)

- prevent the situation to happen (e.g. forbid order lines to be deleted if they are already received) - but that would be in the scope of an other bug, I think.

I think such things could be fixed in the future during the ongoing work for Acquisitions module. Signing off.

8 years agoBug 8677 - table overlapping to the right on holds waiting
Owen Leonard [Fri, 7 Sep 2012 15:23:08 +0000 (11:23 -0400)]
Bug 8677 - table overlapping to the right on holds waiting

Converting layout to 100% flexible width to allow
table to expand as needed.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8716 - make the routing list reordering function work
Robin Sheat [Tue, 4 Sep 2012 14:53:36 +0000 (16:53 +0200)]
Bug 8716 - make the routing list reordering function work

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 3456: Show internalnotes when receiving serials
Julian Maurice [Wed, 22 Aug 2012 10:29:13 +0000 (12:29 +0200)]
Bug 3456: Show internalnotes when receiving serials

Shows nonpublic note on serials receipt page.

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agofix bug 7068 - autobarcode not working when duplicating patrons
MJ Ray [Fri, 7 Sep 2012 16:40:26 +0000 (17:40 +0100)]
fix bug 7068 - autobarcode not working when duplicating patrons

.. by blanking cardnumber in the code and showing it in the template,
instead of just not showing it in the template

Autobarcode now correctly fills in on a duplicated patron.

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8598 - No patron image or home library on Files & Statistics tabs
Owen Leonard [Fri, 7 Sep 2012 16:12:03 +0000 (12:12 -0400)]
Bug 8598 - No patron image or home library on Files & Statistics tabs

Adding the necessary code for patron image, patron
home library, patron category description, and patron
extended attributes to show in the left-hand sidebar.

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7968 follow-up typo fixes
Paul Poulain [Thu, 13 Sep 2012 16:08:38 +0000 (18:08 +0200)]
Bug 7968 follow-up typo fixes

* changing "export" to "export checkouts", will differentiate better for translation
* fixing english typo in alert when csv profile is not defined

8 years agoBug 7986 follow-up DBRev numbers
Paul Poulain [Thu, 13 Sep 2012 16:07:41 +0000 (18:07 +0200)]
Bug 7986 follow-up DBRev numbers

8 years agoBug 7986: Export issues for patron
Jonathan Druart [Wed, 4 Jul 2012 15:02:12 +0000 (17:02 +0200)]
Bug 7986: Export issues for patron

In the circulation page, you can now export (as csv or iso2709) a list
of items which are currently checked out by a borrower.

3 export types:
- iso2709 with items: Export the items list in iso2709 format with item
  informations.
- iso2709 without items: Export the items list in iso2709 format without
  item informations.
- CSV: Export the items list based on a csv profil.

2 new system preferences:
- DontExportFields: a list of fields not to be export
- CsvProfileForExport: The Csv profile name used for the csv export

Test plan:
- Fill the CsvProfileForExport syspref
- go on the borrower circulation page containing checkouts
- Select one or more items and export them to the 3 different formats.
- check if the result file is what you expected

- Test there is no regression with the export authority
- Test there is no regression using tools/export.pl with the command
  line interface

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8761 Dont inadvertantly use slices
Colin Campbell [Tue, 11 Sep 2012 17:49:35 +0000 (18:49 +0100)]
Bug 8761 Dont inadvertantly use slices

Assignment to a single element slice is better written
as a scalar - This generates a compile time warning as it
can lead to odd behaviour see perldiag for details
This corrects some cases which were added in a recent
commit

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7143 tiny follow-up, removing tabs
Paul Poulain [Thu, 13 Sep 2012 15:55:37 +0000 (17:55 +0200)]
Bug 7143 tiny follow-up, removing tabs

8 years agoBug 7143: Adding Kathryn Tyree to the history and About page.
Melia Meggs [Tue, 11 Sep 2012 21:38:28 +0000 (16:38 -0500)]
Bug 7143: Adding Kathryn Tyree to the history and About page.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
8 years agoBug 7500 [FOLLOW-UP, revised][Social networks] Use CSS Sprites for faster page loading
Owen Leonard [Mon, 14 May 2012 12:51:58 +0000 (08:51 -0400)]
Bug 7500 [FOLLOW-UP, revised][Social networks] Use CSS Sprites for faster page loading

This patch adds a new sprite image for social network links.
The page markup has been modified to accommodate the image-
replacement technique used to display the images.

When testing be sure to clear your cache to load the new CSS.

Revision: Rebased, and unused social network images removed.

8 years agoBug 7500 [FOLLOW-UP][Missing images] Use CSS Sprites for faster page loading
Owen Leonard [Wed, 16 May 2012 14:25:41 +0000 (10:25 -0400)]
Bug 7500 [FOLLOW-UP][Missing images] Use CSS Sprites for faster page loading

- Adds shelf browser navigational arrows to the main sprite.
- Removes "caret.gif" (a sort of breadcrumbs separator in the OPAC) and replaces
  it with a similar Unicode arrow entity.
- Replaces item-bullet.gif (a custom list bullet used in the Cart) with data URI
  encoding the image in the CSS

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 7500 [FOLLOW-UP][Star ratings] Use CSS Sprites for faster page loading
Owen Leonard [Tue, 15 May 2012 19:29:33 +0000 (15:29 -0400)]
Bug 7500 [FOLLOW-UP][Star ratings] Use CSS Sprites for faster page loading

Combines two star ratings sprites into one and makes
the corresponding CSS changes. The two original images
have been removed.

To test, view star ratings on search results and the detail page.
Try setting star ratings on the detail page.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 3461 follow-up DBRev number
Paul Poulain [Thu, 13 Sep 2012 15:27:52 +0000 (17:27 +0200)]
Bug 3461 follow-up DBRev number

8 years agoBug 3462: Links in authorities should be hyperlinks
Jared Camins-Esakov [Wed, 30 May 2012 20:29:54 +0000 (16:29 -0400)]
Bug 3462: Links in authorities should be hyperlinks

Make see also links in both the OPAC and authority module search results
into hyperlinks and not just textual strings.

To test:
1. Do a search for an authority that will bring up a heading with a
   see also reference in the staff client and the OPAC.
2. Confirm that the see also references listed in the search results
   are now hyperlinks, which work.

Also quiets an unnecessary warning about an uninitialized value.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased 26 July 2012

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased on master 1 August 2012

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased on master 6 August 2012

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased on master 11 September 2012

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch works nicely and is a great improvement.

Tests:
- Checked links for existing and non existing "see alsos" give correct
  search results
- Verified links show up for all "see alsos" in a result list
- Verified links are properly linked with the correct names
- Checked logs don't show errors

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 7417: Include see from references in bibliographic searches
Jared Camins-Esakov [Sat, 2 Jun 2012 17:32:25 +0000 (13:32 -0400)]
Bug 7417: Include see from references in bibliographic searches

This patch adds the Koha::Indexer::RecordNormalizer and
Koha::Indexer::MARC::RecordNormalizer::EmbedSeeFromHeadings packages
to enable the inclusion of alternate forms of headings in bibliographic
searches. When the new syspref IncludeSeeFromInSearches is turned on
(default is off) rebuild_zebra.pl will insert see from headings from
authority records into bibliographic records when indexing, so that a
search on an obsolete term will turn up relevant records.

To test:
1) Enable IncludeSeeFromInSearches
2) Add a heading that has an alternate form to a record (for example,
   "Cooking" has the alternate form "Cookery," if you have authority
   records from LC)
3) Index the zebraqueue (or reindex if you haven't indexed your system
   yet)
4) Confirm that if you search for "Cookery" you get the record you
   just modified

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased on master 5 August 2012
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased on master 11 September 2012

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Also checked:
- Verified database update works correctly
- Checked system preference and its description
- Checked staff/opac detail pages with feature on/off
- Checked staff/opac search facets
- Downloaded and tested records in various formats
- Tried different searches for 'see from' entries of authorities
- Ran all unit tests

No problems found.

8 years agoMerge remote-tracking branch 'origin/new/bug_8209'
Paul Poulain [Thu, 13 Sep 2012 12:01:08 +0000 (14:01 +0200)]
Merge remote-tracking branch 'origin/new/bug_8209'

8 years agoBug 8209 follow-up: fix failing test in AuthorityFile suggestion plugin
Jared Camins-Esakov [Thu, 13 Sep 2012 11:38:58 +0000 (07:38 -0400)]
Bug 8209 follow-up: fix failing test in AuthorityFile suggestion plugin

The BuildSummary output changed slightly, resulting in labels not
showing up and a test failing.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agobug 8649: quiet a variable use warning
Galen Charlton [Thu, 16 Aug 2012 18:46:13 +0000 (14:46 -0400)]
bug 8649: quiet a variable use warning

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agobug 8649: create a temp directory for Zebra for C4::Search tests
Galen Charlton [Thu, 16 Aug 2012 18:38:32 +0000 (14:38 -0400)]
bug 8649: create a temp directory for Zebra for C4::Search tests

The Zebra test uses Unix-domain sockets, which won't work if
Koha is being installed or tested from an NFS- or SSHFS-mounted
clone.  Therefore, create (and clenaup) a temporary directory on
(hopefully) a normal filesytem to run the test.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agobug 8649: make sure we can exit if a test fails
Galen Charlton [Thu, 16 Aug 2012 17:23:49 +0000 (13:23 -0400)]
bug 8649: make sure we can exit if a test fails

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agobug 8649: make sure C4::Context is fully mocked-up before tests
Galen Charlton [Thu, 16 Aug 2012 17:04:00 +0000 (13:04 -0400)]
bug 8649: make sure C4::Context is fully mocked-up before tests

This fixes failures of the test cases to run for me
on Perl 5.10.1 using prove -v t/db_dependent/Search.t

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 8649: Add unit test for C4::Search
Jared Camins-Esakov [Mon, 13 Aug 2012 22:01:37 +0000 (18:01 -0400)]
Bug 8649: Add unit test for C4::Search

This patch adds a unit test for C4::Search in t/db_dependent. In order
to test the functioning of the Zebra search, this patch actually includes
an entire Zebra sandbox, and pre-indexed files, which are stored in
t/db_dependent/data (the configuration files are generated on the fly).

This test depends on Test::Warn, Test::MockModule, and DBD::Mock.

To test:
1) Run the test. There should be no failures, and no warnings.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 8209 follow-up DBRev number
Paul Poulain [Thu, 13 Sep 2012 09:48:42 +0000 (11:48 +0200)]
Bug 8209 follow-up DBRev number

8 years agoBug 8209: "Did you mean?" from authorities
Jared Camins-Esakov [Thu, 19 Jul 2012 12:02:40 +0000 (08:02 -0400)]
Bug 8209: "Did you mean?" from authorities

One of the ideas behind authority records is that users who search for
one term should have related terms (according to the authority file)
suggested to them. At the moment, Koha doesn't do that. Adding an
authority searching step to regular searches and displaying any
suggestions in a "Did you mean" bar at the top of the results would be
very useful.

This commit adds a Koha::SuggestionEngine class which is in charge of
getting suggestions from individual suggestion engine plugins, which
much be in the Koha::SuggestionEngine::Plugin::* namespace, and extend
Koha::SuggestionEngine::Base. Suggestions are loaded asynchronously
using AJAX, and a link to a page with suggestions is provided for users
with Javascript turned off.

The AuthorityFile suggestion engine plugin looks up the specified search
terms in the authority file and then suggests searches for records using
matching authorities.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased 2 August 2012 and incorporated QA feedback

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Test plan:
- Verified database update added system preference correctly,
  pref defaults to OFF
- Verified search results and detail pages in OPAC and staff
  still worked the same as before
  * for no results
  * with results
- Activated system preference and tested various searches
  * Searches from simple search
  * Searches from advanced search
  * Search links in records
- Deactivated Javascript - verified fallback works correctly

Notes:

- Suggested terms can include autorities with no linked records.
- When combining more than one search option using advanced search
  this results in "no suggestions" more often. Feature works best
  from simple search.

Overall great feature making use of authorities in a user friendly way!

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased on latest master 2012-09-10
Signed-off-by: wajasu <matted-34813@mypacks.net>
8 years agoBug 8431 follow-up : |html_line_break in 2 tempates
Paul Poulain [Thu, 13 Sep 2012 09:22:58 +0000 (11:22 +0200)]
Bug 8431 follow-up : |html_line_break in 2 tempates

if the attribute is in more than 1 line, we must add |html_line_break to display it properly

Doing that in member details (staff & opac)

8 years agobug 8431 follow-up DBRev number
Paul Poulain [Thu, 13 Sep 2012 09:22:01 +0000 (11:22 +0200)]
bug 8431 follow-up DBRev number

+ removing useless ` in DB columns

8 years agoBug 8431 - Followup - Switch from text input to textarea
Kyle M Hall [Tue, 24 Jul 2012 15:23:05 +0000 (11:23 -0400)]
Bug 8431 - Followup - Switch from text input to textarea

Switch the text input to a textarea will make editing larger
borrower attritube values much easier. Since modern browsers
allow for dynamic resizing of textareas, we can keep it small
by default and let the library resize it if neccessary.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
8 years agoBug 8431 - Increase the borrower attribute field size from 64 characters to 255
Kyle M Hall [Thu, 12 Jul 2012 15:29:10 +0000 (11:29 -0400)]
Bug 8431 - Increase the borrower attribute field size from 64 characters to 255

Some libraries would like to store more verbose data in a borrower attribute field.
This commit increases the maximum length of a borrower attribute from 64 characters
to 255 characters.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 8644 [OPAC] jQueryUI CSS file should not contain customizations
Owen Leonard [Thu, 6 Sep 2012 12:27:20 +0000 (08:27 -0400)]
Bug 8644 [OPAC] jQueryUI CSS file should not contain customizations

This patch moves jQueryUI customizations into the main CSS
file for the OPAC. In order to get the corrected
default version of jquery-ui.css I have upgraded all core
jQueryUI files.

Testers should look at examples of each of the various jQueryUI
widgets we use in the OPAC to confirm continued functinality: tabs
and datepickers.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8644 [staff client] jQueryUI CSS file should not contain customizations
Owen Leonard [Wed, 5 Sep 2012 18:37:32 +0000 (14:37 -0400)]
Bug 8644 [staff client] jQueryUI CSS file should not contain customizations

This patch moves jQueryUI customizations into the main CSS
file for the staff client. In order to get the corrected
default version of jquery-ui.css I have upgraded all core
jQueryUI files.

Testers should look at examples of each of the various jQueryUI
widgets we use in Koha to confirm continued functinality: tabs,
autocomplete, datepickers, and slider (in specify due date popup).

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
8 years agoBug 8028 - Followup
Kyle M Hall [Fri, 7 Sep 2012 16:17:23 +0000 (12:17 -0400)]
Bug 8028 - Followup

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8028 - Make table collapsing on parcel.pl sticky - Hide link for 5 or fewer items.
Kyle M Hall [Mon, 16 Jul 2012 17:11:04 +0000 (13:11 -0400)]
Bug 8028 - Make table collapsing on parcel.pl sticky - Hide link for 5 or fewer items.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
8 years agoBug 8028 - Make table collapsing on parcel.pl sticky
Kyle M Hall [Wed, 28 Mar 2012 17:00:54 +0000 (13:00 -0400)]
Bug 8028 - Make table collapsing on parcel.pl sticky

The tables on parcel.pl default to show only the first
five items in the table, and librarians must click the
a link to display all the items. Every time the page is
reloaded, the table gets re-collapsed, and the librarian
must again click the link. Parcel.pl should remember
which way the table is set and keep it that way until
it is changed again.

This is accomplished by adding two cookies for this page,
one for each table. This cookie stores the state of the
table ( collapsed, or uncollapsed ) and sets each table
to the correct state on each page load.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Works as expected.

But a "funny" behaviour, if I have only 1 item (or < 6):
  All 1 items are displayed. Click here to show only the first 5 items.
and
  Only the first 5 items are displayed. Click here to show all 1 items.

8 years agoBug 5911 follow-up DBREv number
Paul Poulain [Wed, 12 Sep 2012 14:54:45 +0000 (16:54 +0200)]
Bug 5911 follow-up DBREv number

8 years agoMerge remote-tracking branch 'origin/new/bug_8251'
Paul Poulain [Wed, 12 Sep 2012 14:45:05 +0000 (16:45 +0200)]
Merge remote-tracking branch 'origin/new/bug_8251'

8 years agoBug 8251 Do not try to debar patrons if returns are not overdue
Colin Campbell [Wed, 5 Sep 2012 10:58:54 +0000 (11:58 +0100)]
Bug 8251 Do not try to debar patrons if returns are not overdue

If a period of suspension is configured in the issuing rules
a calculation to debar the patron was called on all returns
It should be limited to overdue returns

Renamed _FixFineDaysOnReturn subroutine to _debar_user_on_return
which is more descriptive of its purpose
Removed some unnecessary or duplicated processing
Changed visibility of $today so it didnt need
calculating twice
Removed declaration of a datedue variable that is
never used

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8496 - show local cover images on lists view in opac
Owen Leonard [Wed, 25 Jul 2012 18:05:00 +0000 (14:05 -0400)]
Bug 8496 - show local cover images on lists view in opac

Adding display of local cover images to lists view.
Also adding display of OpenLibrary covers since those were
also missing.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Tested with local cover images and with other cover images.
Lists work as expected with all services.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8708 [Revised] RSS feed for new comments is broken
Owen Leonard [Fri, 31 Aug 2012 13:04:13 +0000 (09:04 -0400)]
Bug 8708 [Revised] RSS feed for new comments is broken

Removing white space from the beginning of the file
so that XML processing will work correctly.

Before the patch, viewing the page
(/cgi-bin/koha/opac-showreviews.pl?format=rss) in a browser
which supports RSS handling (ex: Firefox)  will show you
unformatted and broken-looking text. After the patch the
page will trigger the browser's built-in RSS-handling format.

Revision: Template now includes comment pointing out that the <xml>
declaration must not have any white space before it.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 5911 follow-up DBRev number
Paul Poulain [Wed, 12 Sep 2012 13:31:14 +0000 (15:31 +0200)]
Bug 5911 follow-up DBRev number

8 years agobug_5911: Transport Cost Matrix
Srdjan [Wed, 5 Sep 2012 00:47:21 +0000 (12:47 +1200)]
bug_5911: Transport Cost Matrix

Create transport_cost table,  added UseTransportCostMatrix syspref.
transport_cost table contains branch to branch transfer
costs. These are used for filling inter-branch hold transfers.

Moved GetHoldsQueueItems() from .pl to HoldsQueue.pm

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8412: add color icon set
Nicole C. Engard [Fri, 3 Aug 2012 15:17:53 +0000 (11:17 -0400)]
Bug 8412: add color icon set

My goal here is to make it so that libraries can use
one of the authorized values (shelving location or
collection code) to store the color of the material
and then make that searchable on the advanced search
page.

To do this for collection codes you'd need to add
the following jqueries:

intranetuserjs

$(document).ready(function(){
$("#advsearch-tab-ccode a:contains('Collection')").text("Color");
$("#holdings th:contains('Collection')").text("Color");
});

opacuserjs

$(document).ready(function(){
$("#advsearch-tab-ccode a:contains('Collection')").text("Color");
$('#item_ccode').text("Color");
});

And update the frameworks to change the 952$8 label to say Color.

The following SQL could be used to add these colors to the CCODE
authorized value category if you planned on using these this way.
If you wanted to use these colors for another authorized value
you'd have to edit this to use that category:

insert into authorised_values (category, authorised_value, lib,
 lib_opac, imageurl) values ('CCODE','000000','Black','','colors/000000.png');
insert into authorised_values (category, authorised_value, lib,
 lib_opac, imageurl) values ('CCODE','66cc66','Bright Green','','colors/66cc66.png');
insert into authorised_values (category, authorised_value, lib,
 lib_opac, imageurl) values ('CCODE','99cc33','Olive','','colors/99cc33.png');
insert into authorised_values (category, authorised_value, lib,
 lib_opac, imageurl) values ('CCODE','3333cc','Dark Blue','','colors/3333cc.png');
insert into authorised_values (category, authorised_value, lib,
 lib_opac, imageurl) values ('CCODE','006600' ,'Dark Green','','colors/006600.png');
insert into authorised_values (category, authorised_value, lib,
 lib_opac, imageurl) values ('CCODE','6600cc','Plum','','colors/6600cc.png');
insert into authorised_values (category, authorised_value, lib,
 lib_opac, imageurl) values ('CCODE','6666cc','Purple','','colors/6666cc.png');
insert into authorised_values (category, authorised_value, lib,
 lib_opac, imageurl) values ('CCODE','9999cc','Light Purple','','colors/9999cc.png');
insert into authorised_values (category, authorised_value, lib,
 lib_opac, imageurl) values ('CCODE','660000' ,'Burgundy','','colors/660000.png');
insert into authorised_values (category, authorised_value, lib,
 lib_opac, imageurl) values ('CCODE','663333' ,'Brown','','colors/663333.png');
insert into authorised_values (category, authorised_value, lib,
 lib_opac, imageurl) values ('CCODE','990000' ,'Red','','colors/990000.png');
insert into authorised_values (category, authorised_value, lib,
 lib_opac, imageurl) values ('CCODE','996633' ,'Tan','','colors/996633.png');
insert into authorised_values (category, authorised_value, lib,
 lib_opac, imageurl) values ('CCODE','999999' ,'Gray','','colors/999999.png');
insert into authorised_values (category, authorised_value, lib,
 lib_opac, imageurl) values ('CCODE','cc66cc','Pink','','colors/cc66cc.png');
insert into authorised_values (category, authorised_value, lib,
 lib_opac, imageurl) values ('CCODE','cc99cc','Bubble Gum','','colors/cc99cc.png');
insert into authorised_values (category, authorised_value, lib,
 lib_opac, imageurl) values ('CCODE','cc3333' ,'Orange','','colors/cc3333.png');
insert into authorised_values (category, authorised_value, lib,
 lib_opac, imageurl) values ('CCODE','cc6666' ,'Peach','','colors/cc6666.png');
insert into authorised_values (category, authorised_value, lib,
 lib_opac, imageurl) values ('CCODE','cc9999' ,'Rose','','colors/cc9999.png');
insert into authorised_values (category, authorised_value, lib,
 lib_opac, imageurl) values ('CCODE','cccc00' ,'Gold','','colors/cccc00.png');
insert into authorised_values (category, authorised_value, lib,
 lib_opac, imageurl) values ('CCODE','ffff33' ,'Yellow','','colors/ffff33.png');
insert into authorised_values (category, authorised_value, lib,
 lib_opac, imageurl) values ('CCODE','ffffcc','Cream','','colors/ffffcc.png');
insert into authorised_values (category, authorised_value, lib,
 lib_opac, imageurl) values ('CCODE','ffffff','White','','colors/ffffff.png');

I'll add this tip to a blog post and to the manual once this
set of icons has been pushed to Koha.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoMerge remote-tracking branch 'origin/new/bug_8089'
Paul Poulain [Wed, 12 Sep 2012 12:14:35 +0000 (14:14 +0200)]
Merge remote-tracking branch 'origin/new/bug_8089'

8 years agoRevert "Bug 8089: Use Koha::Cache for all caching"
Paul Poulain [Wed, 12 Sep 2012 11:46:00 +0000 (13:46 +0200)]
Revert "Bug 8089: Use Koha::Cache for all caching"

This reverts commit 215abc8024d93f1b6a10f26427a65bd64d106e52.

The 3 patches for bug 8089 have been reverted, because they break
jenkins & Koha.
A follow-up has been provided, but it does not solve the problem on my
test server, it just changes the error message.

After a discussion with jared, Dobrica should work on another patch, so
the best option is to revert.

8 years agoRevert "Bug 8089: Cache sysprefs using Koha::Cache"
Paul Poulain [Wed, 12 Sep 2012 11:45:51 +0000 (13:45 +0200)]
Revert "Bug 8089: Cache sysprefs using Koha::Cache"

This reverts commit 499f44fa1d0086d4430215648679fd368017df6c.

8 years agoRevert "Bug 8089: Correct cache timeout to 1000"
Paul Poulain [Wed, 12 Sep 2012 11:45:40 +0000 (13:45 +0200)]
Revert "Bug 8089: Correct cache timeout to 1000"

This reverts commit eefeef0c1ff606dc15ad6105537c5e6fb8f7393d.

8 years agoMerge remote-tracking branch 'origin/new/bug_8408'
Paul Poulain [Fri, 7 Sep 2012 16:42:21 +0000 (18:42 +0200)]
Merge remote-tracking branch 'origin/new/bug_8408'

8 years agoBug 8408 - Followup 2 - Add reference to renewing items.
Kyle M Hall [Fri, 3 Aug 2012 11:57:24 +0000 (07:57 -0400)]
Bug 8408 - Followup 2 - Add reference to renewing items.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoBug 8408 - Followup - Fix broken messages.
Kyle M Hall [Fri, 3 Aug 2012 11:53:33 +0000 (07:53 -0400)]
Bug 8408 - Followup - Fix broken messages.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoBug 8678: XSLT stylesheets output XML, but HTML is needed
Jared Camins-Esakov [Thu, 23 Aug 2012 16:27:49 +0000 (12:27 -0400)]
Bug 8678: XSLT stylesheets output XML, but HTML is needed

Because we are embedding the results of XSLT stylesheets in HTML, we
need to output HTML instead of XML. Outputting XML results in
non-standard-compliant (or at least non-Firefox-compliant) markup.

To test:
View a variety of XSLT-rendered pages on the OPAC and intranet, and
confirm that all look as expected.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoMerge remote-tracking branch 'origin/new/bug_8204'
Paul Poulain [Fri, 7 Sep 2012 16:34:28 +0000 (18:34 +0200)]
Merge remote-tracking branch 'origin/new/bug_8204'

8 years agoBug 8204 follow-up: don't display OpacNav on auth details
Jared Camins-Esakov [Mon, 27 Aug 2012 13:03:30 +0000 (09:03 -0400)]
Bug 8204 follow-up: don't display OpacNav on auth details

Based on the way we handle the bib details page, it seems we should
not be displaying OpacNav on the authority details pages on the OPAC.
This patch removes them.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
8 years agoBug 8089: Correct cache timeout to 1000
Jared Camins-Esakov [Sun, 20 May 2012 12:18:52 +0000 (08:18 -0400)]
Bug 8089: Correct cache timeout to 1000

There was a typo in the original patch for bug 8089 which set the cache
timeout on getAllLanguages to 10000. Correct it to 1000.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8089: Cache sysprefs using Koha::Cache
Jared Camins-Esakov [Tue, 15 May 2012 11:14:01 +0000 (07:14 -0400)]
Bug 8089: Cache sysprefs using Koha::Cache

Cache sysprefs using Koha::Cache in a way that is safe even for
caching-related sysprefs. This lays the groundwork for removing
caching configuration from the httpd.conf and configuring it
using sysprefs.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
8 years agoBug 8089: Use Koha::Cache for all caching
Jared Camins-Esakov [Mon, 14 May 2012 11:27:29 +0000 (13:27 +0200)]
Bug 8089: Use Koha::Cache for all caching

1. Replace all instances of memoize_memcached with appropriate calls
into Koha::Cache:
* reports/guided_reports.pl
* C4::Biblio::GetMarcStructure
* C4::Languages::getFrameworkLanguages
* C4::Languages::getAllLanguages
* C4::SQLHelper::GetPrimaryKeys
* C4::SQLHelper::_get_columns

2. Replace all references to memcached with the appropriate calls into
Koha::Cache in C4::Context.

Test plan :
* have DEBUG env set to 1
* reach addbiblio page to test the patch in Biblio.pm, or setup more than 1
  language
* you should see in the logs that you're reading and writing from cache
* run the test suite twice both with and without the following environment
  variables set:
export MEMCACHED_SERVERS=127.0.0.1:11211
export MEMCACHED_NAMESPACE=KOHA
export CACHING_SYSTEM=memcached

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
I'm unsure about some of the caching times 10000 is a long long time,
but other than that, works fine.

8 years agoBug 8206: make authority search indexes consistent
Jared Camins-Esakov [Sun, 15 Jul 2012 13:30:58 +0000 (09:30 -0400)]
Bug 8206: make authority search indexes consistent

This commit makes the search indexes used for search authorities in the
staff client and OPAC more consistent by using the Mainentry,
Match, and Any indexes for both, and adjusting the labels so that they
correctly describe what the indexes do.

Note that the Match index was chosen instead of the Match-heading index
because Match-heading has the additional attribute of being for phrase
searches and exact matches, whereas Match is used for keyword matching,
and is more applicable with GRS-1 indexed records (thanks to the
well-known limitations of GRS-1 and exact matching of headings).

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
No problem detected in UNIMARC

8 years agoBug 8206 follow-up: Add Match index to MARC21 record.abs
Jared Camins-Esakov [Thu, 5 Jul 2012 13:15:04 +0000 (09:15 -0400)]
Bug 8206 follow-up: Add Match index to MARC21 record.abs

Although the Match index was correctly configured for UNIMARC
authorities and MARC21 authorities indexed with DOM, the Match
index was inadvertantly removed from the record.abs file for
MARC21 authorities at some point. Since the Match index is required
to make best use of the new search options, this patch adds it
back in.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
8 years agoBug 8206: Specify index in OPAC authority search
Jared Camins-Esakov [Wed, 30 May 2012 15:02:51 +0000 (11:02 -0400)]
Bug 8206: Specify index in OPAC authority search

Adds a dropdown to allow the user to choose to search the 'mainentry,'
and 'match-heading'indexes, in addition to the 'any' index which is
the default.

To test (you will need authority records with see-from and
see-also headings):
1. Go to the browse subjects and authors section in the OPAC
2. Do a search for a fairly generic term that is used as a
   see-also term in a lot of records. Note that your search
   results include both the record that you wanted and all
   the other records that refer to it.
3. Apply the patch.
4. Repeat the search from step 2. Notice there is no change
   to the results.
5. Repeat the search from step 2, but choose "in main entry"
   and observe that you are now only seeing authority records
   with the search entered in their main entry.
6. Repeat the search from step 2, but choose "in any heading"
   and observe that the results are the same as in step 2. This
   is intentional, so that in the future notes in authorities
   can be made searchable.
7. Search for an obsolete form of heading with the "in keyword"
   option selected. Notice what results you get.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely. Hiding the new options can be done with CSS:

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
8 years agoBug 5327: Testing c4 Images
Bart Jorgensen [Thu, 23 Aug 2012 04:58:24 +0000 (16:58 +1200)]
Bug 5327: Testing c4 Images

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
tested the 9 previous patches, that introduces many new unit tests using
the Mock Module.

8 years agoBug 5327: Unit tests for C4 socialdata
Bart Jorgensen [Thu, 23 Aug 2012 05:46:41 +0000 (17:46 +1200)]
Bug 5327: Unit tests for C4 socialdata

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoBug 5327 : Fixing a typo in the test that was causing a false fail
Chris Cormack [Wed, 5 Sep 2012 18:29:15 +0000 (06:29 +1200)]
Bug 5327 : Fixing a typo in the test that was causing a false fail

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
t/db_dependent/Items.t was failing despite valid data before patch,
works fine after

8 years agoAdded tests to installer_perlmodules
Bart Jorgensen [Thu, 16 Aug 2012 05:43:17 +0000 (17:43 +1200)]
Added tests to installer_perlmodules

http://bugs.koha-community.org/show_bug.cgi?id=5327
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
8 years agoAdded a mock-db table and tested a line
Bart Jorgensen [Thu, 9 Aug 2012 05:01:56 +0000 (17:01 +1200)]
Added a mock-db table and tested a line

http://bugs.koha-community.org/show_bug.cgi?id=5327
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests pass!

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
8 years agoAdded and tested a mock-db tested a couple of features
Bart Jorgensen [Wed, 8 Aug 2012 09:23:55 +0000 (21:23 +1200)]
Added and tested a mock-db tested a couple of features

http://bugs.koha-community.org/show_bug.cgi?id=5327
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests pass!

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
8 years agoBug 5327 Tests for C4::Matcher
Bart Jorgensen [Thu, 2 Aug 2012 04:56:58 +0000 (16:56 +1200)]
Bug 5327 Tests for C4::Matcher

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>