koha.git
8 years agoMerge remote-tracking branch 'origin/new/bug_7955'
Paul Poulain [Wed, 1 Aug 2012 14:07:08 +0000 (16:07 +0200)]
Merge remote-tracking branch 'origin/new/bug_7955'

8 years agoBug 7955: Followup : Check the syspref value (avoid sql injection)
Jonathan Druart [Tue, 10 Jul 2012 14:00:54 +0000 (16:00 +0200)]
Bug 7955: Followup : Check the syspref value (avoid sql injection)

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Works as expected. Fields with disallowed characters do not show up.
Added 'if $debug' to an pseudo-unconditional warn.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8207 follow-up DBrev
Paul Poulain [Wed, 1 Aug 2012 13:46:38 +0000 (15:46 +0200)]
Bug 8207 follow-up DBrev

8 years agoBug 8207: Allow see also fields in auths to link to thesauri
Jared Camins-Esakov [Thu, 28 Jun 2012 22:29:12 +0000 (18:29 -0400)]
Bug 8207: Allow see also fields in auths to link to thesauri

Right now if you were to link a field in an authority to a thesaurus, it
would not work properly. The authority type frameworks require some
adjustments to allow see also headings to be linked to thesauri (such as
adding subfield $9).

This patch adds subfield $9 and thesaurus links to existing installs
for those 5xx fields (under MARC21 and NORMARC only) which do not yet
have any subfield $9 or thesauri configured, as well as adding that to
new English language installs. There will be a follow-up patch adding
the subfields to new non-English language install files later, once
it is clear that the changes proposed and demonstrated in the English
files are accepable to the community.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested frameworks install cleanly on a new installation.

Tested database update and made sure, that configuration and subfields
of a field were not changed if
- a $9 subfield already existed for a 5xx field
- a $9 subfield and a link to another thesaurus in $a existed
- no $9 but a link to another thesaurus in $a existed

This seems safe to me.

8 years agoMerge remote-tracking branch 'origin/new/bug_8204'
Paul Poulain [Wed, 1 Aug 2012 12:59:23 +0000 (14:59 +0200)]
Merge remote-tracking branch 'origin/new/bug_8204'

8 years agoBug 8204 follow-up: quiet warn
Jared Camins-Esakov [Fri, 27 Jul 2012 11:53:06 +0000 (07:53 -0400)]
Bug 8204 follow-up: quiet warn

Also removes unnecessary variable declaration. Thanks to Jonathan Druart
for spotting it.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
8 years agoBug 7143: Updating history and about file
Chris Cormack [Thu, 26 Jul 2012 11:00:18 +0000 (23:00 +1200)]
Bug 7143: Updating history and about file

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoMerge remote-tracking branch 'origin/new/bug_8233'
Paul Poulain [Wed, 1 Aug 2012 11:53:43 +0000 (13:53 +0200)]
Merge remote-tracking branch 'origin/new/bug_8233'

8 years agoBug 8233: We can't load test on Koha::SearchEngine::*
Jonathan Druart [Wed, 25 Jul 2012 12:19:48 +0000 (14:19 +0200)]
Bug 8233: We can't load test on Koha::SearchEngine::*

As a temporary measure, don't try to load the search engine modules
in t/00-load.t.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
8 years agoMerge remote-tracking branch 'origin/new/bug_8486'
Paul Poulain [Wed, 1 Aug 2012 10:38:23 +0000 (12:38 +0200)]
Merge remote-tracking branch 'origin/new/bug_8486'

8 years agoBug 8486 - Follow up making the tests db independent
Chris Cormack [Sat, 28 Jul 2012 08:07:36 +0000 (20:07 +1200)]
Bug 8486 - Follow up making the tests db independent

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Makes the test db independant by specifying the date format. Thus, there is no call to ->preference() that retrieve a systempreference

8 years agoBug 8204: fix UNIMARC display
Jared Camins-Esakov [Thu, 26 Jul 2012 15:49:36 +0000 (11:49 -0400)]
Bug 8204: fix UNIMARC display

UNIMARC display of authorities in the OPAC wasn't working due to
changes in the BuildSummary function since the code was originally
developed.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8204: Add user friendly authority view to OPAC
Jared Camins-Esakov [Thu, 31 May 2012 11:24:29 +0000 (07:24 -0400)]
Bug 8204: Add user friendly authority view to OPAC

Up until now, the only authority view in the OPAC was a
rather-unfriendly expanded MARC view. This patch adds a user-friendly
view similar to the biblio details view.

Specific features to be aware of:
* Right-to-left text in the MARC21 880 field will show up in the
  appropriate location with the appropriate alignment and wrapping
* There is very little CSS styling. Any suggestions for how to make
  the display more attractive would be gratefully received.

To test:
1) Do a search for an authority in the OPAC.
2) Choose an authority record to view.
3) Observe that the view is more user-friendly and polished.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works very nicely now. The old view is still available, but the
user is presented with a nicer non-MARC view first.

8 years agoBug 8208 follow-up: move Clear and Create new buttons out of results
Jared Camins-Esakov [Mon, 9 Jul 2012 12:56:27 +0000 (08:56 -0400)]
Bug 8208 follow-up: move Clear and Create new buttons out of results

Turns "Clear" and "Create new" links into buttons that are visible
before a search is performed, so that the user does not have to do
a search just to clear the field or create a new authority. This
commit also changes the formatting from textual links to buttons.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Nicer and more logical display.
Allows creating of a new authority without doing a search first
or when no results were found.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8208: Add fast-add link to auth finder plugin
Jared Camins-Esakov [Mon, 2 Jul 2012 16:51:08 +0000 (12:51 -0400)]
Bug 8208: Add fast-add link to auth finder plugin

When performing subject analysis, it is not uncommon to find that an
authority record you need does not exist. This commit adds a link in
the search results to enable the cataloger to create an authority on
the fly and have the heading populated by the new authority.

To test:
1. Use the auth finder plugin the cataloguing module to search for a
   heading you do not have an authority record for.
2. Click the "Create new" link.
3. Fill in your authority and save it.
4. Note that the heading field was populated with the data you entered
   in the authority record.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
1) Added a new authority using the plugin
2) Used an existing authority using the plugin
3) Created a new authority in the authority module

All worked nicely.

8 years agoBug 7153 - Show Open Library as Search Target in "More Searches" in OPAC detail page
Savitra sirohi [Sat, 5 Nov 2011 04:21:03 +0000 (00:21 -0400)]
Bug 7153 - Show Open Library as Search Target in "More Searches" in OPAC detail page

Update syspref OPACSearchForTitleIn to include Open Library as a target in More Searches in the OPAC detail page

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8470: remove depreciated H:T:P test
Mason James [Wed, 18 Jul 2012 05:24:29 +0000 (17:24 +1200)]
Bug 8470: remove depreciated H:T:P test

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 7420 tiny bugfix
Paul Poulain [Wed, 25 Jul 2012 16:31:50 +0000 (18:31 +0200)]
Bug 7420 tiny bugfix

The printing at the end, in verbose mode was not displaying variables properly because the print was '' and not ""

9 years agoBug 7420 follow-up DBRev number
Paul Poulain [Wed, 25 Jul 2012 16:31:10 +0000 (18:31 +0200)]
Bug 7420 follow-up DBRev number

9 years ago[PATCH] bug_7420: Added overduefinescap to issuingrules
Elliott Davis [Wed, 11 Jul 2012 03:38:28 +0000 (22:38 -0500)]
[PATCH] bug_7420: Added overduefinescap to issuingrules

Replaced existing MaxFine syspref logic with overduefinescap.
Repurposed MaxFine to be the overall overdue limit for all items
overdue. Implemented new MaxFine logic in UpdateFine().

Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
Tested according to Srdjan's test plan and everything worked like he said it would.  I set fined equal to $2 and max fine equal to $1.      When I ran the fines script for overdue items fines assessed were only $1.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agobug 8486 tiny follow-up, removing `
Paul Poulain [Wed, 25 Jul 2012 14:55:30 +0000 (16:55 +0200)]
bug 8486 tiny follow-up, removing `

9 years agoBug 8486 Merge Calendar test files
Colin Campbell [Wed, 25 Jul 2012 09:55:56 +0000 (10:55 +0100)]
Bug 8486 Merge Calendar test files

Moves the tests previously in t/Kalendar.t to t/Calendar.t
and removes the old file.
Note the existing minimal test of C4/Calendar still called in
t/Calendar

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8486 Correct calculation of days_between
Colin Campbell [Tue, 24 Jul 2012 14:16:10 +0000 (15:16 +0100)]
Bug 8486 Correct calculation of days_between

Thee were errors in the calculation used for days_between
which caused incorrect values to be returned
Added tests to validate calculation

NB Tests still need to be provided for the hourly
calculations

9 years agoMerge remote-tracking branch 'origin/new/bug_7889'
Paul Poulain [Wed, 25 Jul 2012 13:08:50 +0000 (15:08 +0200)]
Merge remote-tracking branch 'origin/new/bug_7889'

9 years agoBug 7889 - Use standard style for errors and messages
Owen Leonard [Fri, 18 May 2012 12:57:15 +0000 (08:57 -0400)]
Bug 7889 - Use standard style for errors and messages

Correcting the markup of error messages in three places:
catalogue merge, CSV profile editing, and opac comments.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years ago7368 Adjustments for Perl dependencies
Marcel de Rooy [Wed, 18 Jul 2012 13:03:36 +0000 (15:03 +0200)]
7368 Adjustments for Perl dependencies

HTML::FormatText is used by Template::Plugin::HtmlToText which is called in the template for opac-sendbasket.pl.
This is not a core Perl 5.10 module. I had to install it additionally on a test server. So I am adding it to PerlDependencies.
I just picked an old version 1.23 that I still could find as min_ver.

Changed the version information for Test::Strict too (not required, only for tests).

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 7302 tiny follow-up removing </td><td>
Paul Poulain [Tue, 24 Jul 2012 16:34:52 +0000 (18:34 +0200)]
Bug 7302 tiny follow-up removing </td><td>

to have the Export as CSV in the same cell as other buttons

9 years agoBug 7302: Followup: rename "Client number" column with "Account number"
Jonathan Druart [Mon, 11 Jun 2012 08:29:23 +0000 (10:29 +0200)]
Bug 7302: Followup: rename "Client number" column with "Account number"

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 7302: Export basketgroup as CSV
Jonathan Druart [Thu, 16 Feb 2012 13:32:03 +0000 (14:32 +0100)]
Bug 7302: Export basketgroup as CSV

Adds new action export for basketgroup.
This action is available only if your basketgroup is closed.
This export generates a csv file with order informations.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested together with bug 5356.

9 years agoBug 8376: New script to export borrowers misc/export_borrowers.pl
Julian Maurice [Fri, 6 Jul 2012 10:31:48 +0000 (12:31 +0200)]
Bug 8376: New script to export borrowers misc/export_borrowers.pl

This script prints to standard output what is returned by
GetMemberDetails in CSV format.
Exported fields can be specified with option -f. If no -f option is
specified, all fields are exported.

Signed-off-by: Gaetan Boisson <gaetan.boisson@biblibre.com>
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Amended with some code to better handle bad data.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8434 - Notice generation fails for Advanced Notices, Item Due, and Overdues when...
David Cook [Fri, 13 Jul 2012 01:50:04 +0000 (11:50 +1000)]
Bug 8434 - Notice generation fails for Advanced Notices, Item Due, and Overdues when run in shell (due to error in Letters.pm)

Patch introduces a check for C4::Context->userenv in Letters.pm, so that script doesn't fail when it calls to C4::Context->userenv->{branch}, when run from shell.

Without the check, Advanced Notices, Item Due, and Overdues fail to generate.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 7367 - One "the" too many
Magnus Enger [Mon, 23 Jul 2012 11:26:19 +0000 (13:26 +0200)]
Bug 7367 - One "the" too many

On line 123 it says "of the the last". One "the" is probably enough.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoMerge remote-tracking branch 'origin/new/bug_8062'
Paul Poulain [Tue, 24 Jul 2012 15:31:07 +0000 (17:31 +0200)]
Merge remote-tracking branch 'origin/new/bug_8062'

9 years ago8062 Followup for HTML::FormatText
Marcel de Rooy [Wed, 18 Jul 2012 13:58:37 +0000 (15:58 +0200)]
8062 Followup for HTML::FormatText

The dependency is not used in opac-sendbasket. But there is a require of HTML::FormatText in the code of Template::Plugin::HTMLToText.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
9 years agoBug 8392: Avoid having an untranslatable age range
Frédéric Demians [Mon, 9 Jul 2012 15:45:11 +0000 (17:45 +0200)]
Bug 8392: Avoid having an untranslatable age range

Currently, error message reports an age range in English. For example '0 to
17'. With this patch, the 'to' is not in the .pl file anymore.

Ruth could you sign-off this fix?

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8392: Category age ranges not being enforced
D Ruth Bavousett [Mon, 9 Jul 2012 14:18:03 +0000 (10:18 -0400)]
Bug 8392: Category age ranges not being enforced

This patch works around the redefinition of an array that was causing the
enforcement of age ranges to not-happen.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
I can confirm the bug and the solution.

9 years agoBug 8440: Dates does not appear in suggestions management
Fridolyn SOMERS [Fri, 13 Jul 2012 14:23:02 +0000 (16:23 +0200)]
Bug 8440: Dates does not appear in suggestions management

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8414 - Intranet header toplinks display white rather than blue in < IE8
David Cook [Wed, 11 Jul 2012 23:13:10 +0000 (09:13 +1000)]
Bug 8414 - Intranet header toplinks display white rather than blue in < IE8

Removes IE7 hash hack which caused head toplinks to display white rather than dark blue against light blue background

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8448 - Holds Awaiting Pickup : Cancelling a hold on a waiting item with multiple...
David Cook [Mon, 16 Jul 2012 04:13:31 +0000 (14:13 +1000)]
Bug 8448 - Holds Awaiting Pickup : Cancelling a hold on a waiting item with multiple holds displays a blank screen instead of a warning prompt

When you cancel a hold in the "Hold Waiting" tab of Holds Awaiting Pickup, you should be prompted to retain or transfer the hold for the next patron in the queue. However, instead of seeing this prompt, you are just shown white screen that fails to alert you to the fact that there are more holds on that item!

There is a missing FOREACH reference in waitingreserves.tt. The template tries to directly reference the hash within the cancel_results array, but we need to access the array before we can access the hash.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8442 - labels creator fixes for plack
Dobrica Pavlinusic [Thu, 19 Jul 2012 17:12:13 +0000 (19:12 +0200)]
Bug 8442 - labels creator fixes for plack

- remove all exit(1) and replace them with __END__ which benefits CGI
- insert correct =cut markers at end of POD (required for CGI::Compile
  under plack to correctly parse source code and exeute it)
- scope variables with our which are used inside sub for plack

Signed-off-by: Mirko Tietgen <5p4m@gmx.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBugFix - ReturnToShelvingCart
Kyle M Hall [Thu, 8 Oct 2009 12:13:13 +0000 (12:13 +0000)]
BugFix - ReturnToShelvingCart

If the ReturnToShelvingCart syspref is on, and something needs to go in transit,
the shelving cart setting is overriding the transit.

What seems to be happening is this:
  * Item is checked in, and flagged as needing to go in transit from A to B.
  * Item is immediately flagged as shelving cart, though.  Current display says both shelving cart and in transit.
  * After the cart-to-shelf script runs, item comes out of transit and
    shows as being available at the destination library, although it hasn't
    arrived yet and no one has manually checked it in.

http://bugs.koha-community.org/show_bug.cgi?id=3701

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8439 - Printing basketgroup does not work on plack
Dobrica Pavlinusic [Mon, 16 Jul 2012 10:43:24 +0000 (12:43 +0200)]
Bug 8439 - Printing basketgroup does not work on plack

scope $input CGI object with our for plack

Signed-off-by: Mirko Tietgen <5p4m@gmx.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8476: Little bug in OPAC XSLT on OPACURLOpenInNewWindow
Fridolyn SOMERS [Thu, 19 Jul 2012 13:29:12 +0000 (15:29 +0200)]
Bug 8476: Little bug in OPAC XSLT on OPACURLOpenInNewWindow

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
I know where it comes from: vim cut-and-paste...

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 6716 tiny follow-up, mysql want a space after the --
Paul Poulain [Mon, 23 Jul 2012 16:26:21 +0000 (18:26 +0200)]
Bug 6716 tiny follow-up, mysql want a space after the --

9 years agoBug 6716: Update z3950servers documentation
Nicole C. Engard [Thu, 19 Jul 2012 02:08:27 +0000 (22:08 -0400)]
Bug 6716: Update z3950servers documentation

The new timeout field was not documented.

9 years agoBug 6716: Document search_history table
Nicole C. Engard [Thu, 19 Jul 2012 02:06:10 +0000 (22:06 -0400)]
Bug 6716: Document search_history table

9 years agoBug 6716: Document saved_sql table
Nicole C. Engard [Thu, 19 Jul 2012 02:04:34 +0000 (22:04 -0400)]
Bug 6716: Document saved_sql table

9 years agoBug 6716: Update reserves table
Nicole C. Engard [Thu, 19 Jul 2012 02:01:13 +0000 (22:01 -0400)]
Bug 6716: Update reserves table

This table had one field that I hadn't documented
before and two new fields for hold suspensions. All
of these are now updated.

9 years agoBug 6716: Update documentation for the letter table
Nicole C. Engard [Thu, 19 Jul 2012 01:59:13 +0000 (21:59 -0400)]
Bug 6716: Update documentation for the letter table

The letter table is now for slips and notices, and
had other changes necessary.

9 years agoBug 6716: document import_record_matches table
Nicole C. Engard [Wed, 18 Jul 2012 14:11:34 +0000 (10:11 -0400)]
Bug 6716: document import_record_matches table

9 years agoBug 6716: Document import_batches table
Nicole C. Engard [Wed, 18 Jul 2012 14:07:37 +0000 (10:07 -0400)]
Bug 6716: Document import_batches table

9 years agoBug 6716: Document tags tables
Nicole C. Engard [Wed, 18 Jul 2012 13:34:08 +0000 (09:34 -0400)]
Bug 6716: Document tags tables

I did not document the 'tags' table in this patch
because it looks like this table is unused, so I
need confirmation of that before marking it as
'unused.'

9 years agoBug 6716: Document patronimage table
Nicole C. Engard [Fri, 13 Jul 2012 18:36:08 +0000 (14:36 -0400)]
Bug 6716: Document patronimage table

9 years agoBug 6716: document issuingrules table
Nicole C. Engard [Fri, 13 Jul 2012 18:32:34 +0000 (14:32 -0400)]
Bug 6716: document issuingrules table

9 years agoBug 6716: Document branch_borrower_circ_rules table
Nicole C. Engard [Fri, 13 Jul 2012 16:12:22 +0000 (12:12 -0400)]
Bug 6716: Document branch_borrower_circ_rules table

9 years agoBug 6716: Document branch_item_rules table
Nicole C. Engard [Thu, 12 Jul 2012 13:20:26 +0000 (09:20 -0400)]
Bug 6716: Document branch_item_rules table

9 years agoBug 6716: Document the biblio_framework table
Nicole C. Engard [Thu, 12 Jul 2012 13:13:53 +0000 (09:13 -0400)]
Bug 6716: Document the biblio_framework table

9 years agoBug 6716: Document aqbasket table
Nicole C. Engard [Thu, 12 Jul 2012 03:32:47 +0000 (23:32 -0400)]
Bug 6716: Document aqbasket table

9 years agoBug 6716: Document action_logs table
Nicole C. Engard [Thu, 12 Jul 2012 03:24:50 +0000 (23:24 -0400)]
Bug 6716: Document action_logs table

9 years agoBug 6716: Update ratings table documentation
Nicole C. Engard [Thu, 12 Jul 2012 03:20:28 +0000 (23:20 -0400)]
Bug 6716: Update ratings table documentation

This patch adds a comment to the table and updates the field
descriptions with a bit more information.

9 years agoBug 6716: Document branchtransfers table
Nicole C. Engard [Thu, 12 Jul 2012 03:17:38 +0000 (23:17 -0400)]
Bug 6716: Document branchtransfers table

9 years agoBug 6716: Document aqorders_items table
Nicole C. Engard [Thu, 12 Jul 2012 03:13:27 +0000 (23:13 -0400)]
Bug 6716: Document aqorders_items table

9 years agoBug 6716: Document the aqorders table
Nicole C. Engard [Thu, 12 Jul 2012 03:05:31 +0000 (23:05 -0400)]
Bug 6716: Document the aqorders table

This table has a lot of fields that I never see any values in.
All have been noted in the documentation and I welcome any
additional info about how these fields might be used.

9 years agoBug 6716: Document aqbudgets and aqbudgetperiods tables
Nicole C. Engard [Thu, 12 Jul 2012 01:58:21 +0000 (21:58 -0400)]
Bug 6716: Document aqbudgets and aqbudgetperiods tables

9 years agoMerge remote-tracking branch 'origin/new/bug_8130'
Paul Poulain [Mon, 23 Jul 2012 16:06:50 +0000 (18:06 +0200)]
Merge remote-tracking branch 'origin/new/bug_8130'

9 years agoBug 8130: Followup: errors must be a hashref
Jonathan Druart [Thu, 19 Jul 2012 11:50:08 +0000 (13:50 +0200)]
Bug 8130: Followup: errors must be a hashref

http://bugs.koha-community.org/show_bug.cgi?id=8130
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
9 years agoBug 8130: [SIGNED-OFF] Followup - Empty file upload error never displays.
Kyle M Hall [Thu, 19 Jul 2012 12:41:39 +0000 (08:41 -0400)]
Bug 8130: [SIGNED-OFF] Followup - Empty file upload error never displays.

http://bugs.koha-community.org/show_bug.cgi?id=8130
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
9 years agoBug 8130 [FOLLOW-UP] attach PDF files to a patron record
Owen Leonard [Tue, 10 Jul 2012 17:56:26 +0000 (13:56 -0400)]
Bug 8130 [FOLLOW-UP] attach PDF files to a patron record

Markup corrections:

- Hide table of files if no files are attached
- Move error messages out of table (invalid)
- Add <tr> tags to table (invalid)
- Apply standard form structure to upload form
- Add proper labels and ids to upload form
- Correct unescaped ampersands

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
9 years agoBug 8083 follow-up DBRev number
Paul Poulain [Mon, 23 Jul 2012 08:51:04 +0000 (10:51 +0200)]
Bug 8083 follow-up DBRev number

9 years agobug_8083: Explanation of update query
Srdjan [Wed, 18 Jul 2012 05:53:31 +0000 (17:53 +1200)]
bug_8083: Explanation of update query

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agobug_8083: parameters subpermissions: manage_circ_rules and parameters_remaining_permi...
Srdjan [Tue, 22 May 2012 05:56:43 +0000 (17:56 +1200)]
bug_8083: parameters subpermissions: manage_circ_rules and parameters_remaining_permissions

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
9 years agoMerge remote-tracking branch 'origin/new/bug_8268'
Paul Poulain [Mon, 23 Jul 2012 08:41:05 +0000 (10:41 +0200)]
Merge remote-tracking branch 'origin/new/bug_8268'

9 years ago8268 Followup for creating var spool subdir.
Marcel de Rooy [Mon, 16 Jul 2012 11:15:03 +0000 (13:15 +0200)]
8268 Followup for creating var spool subdir.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
This fixes breaking install on missing subdir.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8453: Add spaces to inventory options
Nicole C. Engard [Mon, 16 Jul 2012 06:43:29 +0000 (02:43 -0400)]
Bug 8453: Add spaces to inventory options

The home and current library labels were right on top
of the radio buttons. This patch just adds a bit of
space in there so that it's cleaner looking.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8458 - $stemmed_operand in C4::Search _build_stemmed_operand is not initialized...
Mark Tompsett [Tue, 17 Jul 2012 12:53:57 +0000 (20:53 +0800)]
Bug 8458 - $stemmed_operand in C4::Search _build_stemmed_operand is not initialized. Added =q{} to initialize it to the empty string at declaration time.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoMerge remote-tracking branch 'origin/new/bug_7729'
Paul Poulain [Tue, 17 Jul 2012 16:21:38 +0000 (18:21 +0200)]
Merge remote-tracking branch 'origin/new/bug_7729'

9 years agoBug 7729 : svc/new_bib: support ?items=1 to add POSTed items to the new biblio too
MJ Ray [Fri, 13 Apr 2012 16:15:21 +0000 (17:15 +0100)]
Bug 7729 : svc/new_bib: support ?items=1 to add POSTed items to the new biblio too

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8422 - Fix impossible warning in circulation.pl when OverduesBlockCirc set to...
David Cook [Thu, 12 Jul 2012 01:26:56 +0000 (11:26 +1000)]
Bug 8422 - Fix impossible warning in circulation.pl when OverduesBlockCirc set to Block

Previously, the message Patron has x overdue item(s). Checkout anyway? was shown when syspref OverduesBlockCirc was set to Ask for confirmation or Block.

This patch changes the message for Block to: Checkouts are BLOCKED because patron has overdues.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoMerge remote-tracking branch 'origin/new/bug_6720'
Paul Poulain [Tue, 17 Jul 2012 13:30:06 +0000 (15:30 +0200)]
Merge remote-tracking branch 'origin/new/bug_6720'

9 years agoBug 6720 follow-up: use authtypetext instead of summary
Jared Camins-Esakov [Sun, 15 Jul 2012 13:55:30 +0000 (09:55 -0400)]
Bug 6720 follow-up: use authtypetext instead of summary

Although auth_types.summary contains a string describing the type of
authority in MARC21, it does not in UNIMARC. auth_types.authtypetext
contains the proper label in both marcflavours.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 6720: Display the authority type in OPAC
Jared Camins-Esakov [Mon, 28 May 2012 18:49:04 +0000 (14:49 -0400)]
Bug 6720: Display the authority type in OPAC

Due to a peculiarity in the way SearchAuthorities worked, the authority
search results on the OPAC always listed the authority type that the
user searched for, rather than the authority type of the results.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, result list for OPAC search now shows the authority type
for each record.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased 20 June 2012.

Signed-off-by: Mirko Tietgen <5p4m@gmx.de>
Works as expected.

9 years agoBug 8386: Error in duplicate detection message for authorities
Jared Camins-Esakov [Mon, 9 Jul 2012 12:00:25 +0000 (08:00 -0400)]
Bug 8386: Error in duplicate detection message for authorities

If you create a new authority record and the name already exists in
your database, you get a duplicate warning. This is good, but there is
a small error in the message:

Duplicate record suspected
Is this a duplicate of HASH(0x47fa670)?

This patch corrects the error message to show the title.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Error message correctly shows the name after applying this patch.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8398 - Missing image file in staff global css
Owen Leonard [Mon, 9 Jul 2012 19:48:23 +0000 (15:48 -0400)]
Bug 8398 - Missing image file in staff global css

This patch fixes a regression introduced by the fix for
Bug 6855 (bullet point showing in wrong place on error message)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855

The patch removes the re-introduced reference to a
background image which has since been removed. Testers should
check that this patch does not re-introduce Bug 6855.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I checked the styling of the error messages in Chromium and Firefox.
The logs are no longer complaining about the missing image.
Looks good to me.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8381: Fix adding limits to search history for logged in users
Katrin Fischer [Sat, 14 Jul 2012 09:37:42 +0000 (11:37 +0200)]
Bug 8381: Fix adding limits to search history for logged in users

Due to renaming of some variables the limits were only working for 'anonymous'
users. This patch fixes some variables, so limits are also added to history
when the user is logged in.

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8381 - Paging broken in OPAC search results
Alex Arnaud [Fri, 13 Jul 2012 09:13:47 +0000 (11:13 +0200)]
Bug 8381 - Paging broken in OPAC search results

Fix also freezing for some browser when performing a search query.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Checked paging (previous, next and navigating to page numbers) works.
Browser performance is fixed too.

9 years agoBug 8063 - Followup - Bug fix
Kyle M Hall [Wed, 6 Jun 2012 13:41:02 +0000 (09:41 -0400)]
Bug 8063 - Followup - Bug fix

$OUTPUT being used but not being declared.

When trying to run this script I gat a nasty:
15:42 ~/koha.dev/koha-community (new/bug_8063 $%)$ ./misc/cronjobs/gather_print_notices.pl
Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 81.
Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 95.
Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 102.
Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 106.
Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 120.
Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 127.
Execution of ./misc/cronjobs/gather_print_notices.pl aborted due to compilation errors.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Before the patch:
$perl -wc ./misc/cronjobs/gather_print_notices.pl
Global symbol "$OUTPUT" requires explicit package name at
[...]./misc/cronjobs/gather_print_notices.pl line 81.
./misc/cronjobs/gather_print_notices.pl had compilation errors.

With this patch:
$perl -wc ./misc/cronjobs/gather_print_notices.pl
./misc/cronjobs/gather_print_notices.pl syntax OK

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8063 - Followup - Make C4/Letters.pm conform to PBP
Kyle M Hall [Tue, 22 May 2012 12:05:05 +0000 (08:05 -0400)]
Bug 8063 - Followup - Make C4/Letters.pm conform to PBP

Perlcritic reported the following errors:
Subroutine prototypes used at line 96, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 120, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 152, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 173, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 190, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 227, column 1.  See page 194 of PBP.  (Severity: 5)
"return" statement with explicit "undef" at line 228, column 31.  See page 199 of PBP.  (Severity: 5)
"return" statement with explicit "undef" at line 229, column 31.  See page 199 of PBP.  (Severity: 5)
"return" statement with explicit "undef" at line 236, column 9.  See page 199 of PBP.  (Severity: 5)
Subroutine prototypes used at line 668, column 1.  See page 194 of PBP.  (Severity: 5)
"return" statement with explicit "undef" at line 669, column 27.  See page 199 of PBP.  (Severity: 5)
Subroutine prototypes used at line 719, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 865, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 899, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 981, column 1.  See page 194 of PBP.  (Severity: 5)
"return" statement with explicit "undef" at line 982, column 28.  See page 199 of PBP.  (Severity: 5)
Subroutine prototypes used at line 1000, column 1.  See page 194 of PBP.  (Severity: 5)
"return" statement with explicit "undef" at line 1001, column 27.  See page 199 of PBP.  (Severity: 5)
"return" statement with explicit "undef" at line 1004, column 9.  See page 199 of PBP.  (Severity: 5)

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
9 years agoBug 8063 - Hold print notices do not sort by branch
Kyle M Hall [Wed, 9 May 2012 15:40:27 +0000 (11:40 -0400)]
Bug 8063 - Hold print notices do not sort by branch

Adds the option -s/--split to enable notices to be separated
into different files by borrower home library.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
9 years agoMerge remote-tracking branch 'origin/new/bug_8251'
Paul Poulain [Mon, 16 Jul 2012 11:46:31 +0000 (13:46 +0200)]
Merge remote-tracking branch 'origin/new/bug_8251'

9 years agoBug 8251 - Follow up, use 'day' instead of 'days' for Datetime::truncate
Tomas Cohen Arazi [Thu, 21 Jun 2012 14:27:20 +0000 (11:27 -0300)]
Bug 8251 - Follow up, use 'day' instead of 'days' for Datetime::truncate

As noted in comment #4 by Jonathan Druart, this should be fixed in every call
to DateTie::truncate function. This patch does exactly that.

julian_m tested that truncate( to => 'days' ) didn't actually do anything, so
it is understandable that this 'fix' might introduce new bugs as we might have
'fixed' at a higher libs level this issue.

'minutes' is used in truncate function too, so fixing.

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoMerge remote-tracking branch 'origin/new/bug_5644'
Paul Poulain [Mon, 16 Jul 2012 10:43:09 +0000 (12:43 +0200)]
Merge remote-tracking branch 'origin/new/bug_5644'

9 years agoBug 5644 : Fixing the test
Chris Cormack [Fri, 13 Jul 2012 20:25:45 +0000 (08:25 +1200)]
Bug 5644 : Fixing the test

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8351: Update wording on staged marc
Nicole C. Engard [Tue, 3 Jul 2012 04:53:37 +0000 (00:53 -0400)]
Bug 8351: Update wording on staged marc

When undoing an import the 'success' message was
poorly worded. This patch fixes that.

Signed-off-by: Mirko Tietgen <5p4m@gmx.de>
works as expected

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agobug 8322 removing additional spaces before fullstop on catalogue/detail and opac...
Chris Hall [Tue, 12 Jun 2012 04:28:56 +0000 (16:28 +1200)]
bug 8322 removing additional spaces before fullstop on catalogue/detail and opac-detail pages.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8375 - Patch for Common diacritics not shown correctly when exporting batch label...
wajasu [Fri, 6 Jul 2012 01:02:28 +0000 (20:02 -0500)]
Bug 8375 - Patch for Common diacritics not shown correctly when exporting batch label to PDF

Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoMerge remote-tracking branch 'jcamins/bug_8281_qa'
Paul Poulain [Fri, 13 Jul 2012 13:11:21 +0000 (15:11 +0200)]
Merge remote-tracking branch 'jcamins/bug_8281_qa'

9 years agoBug 8353 follow-up adding a tiny sh in misc/maintenance
Paul Poulain [Fri, 13 Jul 2012 09:53:41 +0000 (11:53 +0200)]
Bug 8353 follow-up adding a tiny sh in misc/maintenance

This script will help the sysadmin know there's a test he can use
during maintenance

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 8353 follow-up: Perltidy new test
Jared Camins-Esakov [Fri, 13 Jul 2012 12:14:11 +0000 (08:14 -0400)]
Bug 8353 follow-up: Perltidy new test

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 8353: Adds a test to check for missing sysprefs in the database
Henri-Damien LAURENT [Tue, 19 Jan 2010 11:26:24 +0000 (12:26 +0100)]
Bug 8353: Adds a test to check for missing sysprefs in the database

Adds a non-test mode (--showsql option) that displays the missing
sysprefs as sql inserts.  Some sysprefs were missed from the syspref
file due to extra spaces in the insert : fixed. The test now checks if
there are at least as many sysprefs in the database as in the syspref
file (instead of checking for the exact number)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Cherrypicked from BibLibre master, rebased onto current master, and
corrected typos, 2012-07-03

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoBug 6394: purchase order has French strings hard coded in
Katrin Fischer [Mon, 9 Jul 2012 20:23:27 +0000 (22:23 +0200)]
Bug 6394: purchase order has French strings hard coded in

On the purchase order it said 'publié par' - instead of 'published by'.

The layout files for PDF generation in basket groups contain lots of English
strings, this change makes the template more consistent.

Currently the files are not translatable. The only way is to add translated
files to your installation.

To test:
Print a basket group as PDF. Verify string is ok for both possible settings
of system preference OrderPdfFormat:
- pdfformat::layout3pages
- pdfformat::layout2pages

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>