koha.git
10 years agoBug 8271 teach SIPServer.pm to set its own lib path
Colin Campbell [Tue, 19 Jun 2012 10:24:01 +0000 (11:24 +0100)]
Bug 8271 teach SIPServer.pm to set its own lib path

SIPServer.pm requires that C4/SIP is added to its lib
path This has been done by passing this directory
to it via -I. By using FindBin it can set the path
for itself correctly. This will also work if the C4/SIP
directory tree is moved to a non-standard location
Removed the now redundant -I. from sip_run.sh

Added a variable to sip_run.sh for the koha tree to
highlight a problem with the script if you have multiple
directories in the PERL5LIB environment variable

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 7563 follow-up DBRev
Paul Poulain [Fri, 6 Jul 2012 16:26:39 +0000 (18:26 +0200)]
Bug 7563 follow-up DBRev

10 years agoMerge remote-tracking branch 'origin/new/bug_7563' into new/bug_7563
Paul Poulain [Fri, 6 Jul 2012 16:24:34 +0000 (18:24 +0200)]
Merge remote-tracking branch 'origin/new/bug_7563' into new/bug_7563

10 years agoBug 7563 - Silent print slips using Firefox PlugIn jsPrintSetup and new staff client...
Marc Veron [Fri, 29 Jun 2012 19:31:34 +0000 (21:31 +0200)]
Bug 7563 - Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 7563 - Silent print slips using Firefox PlugIn jsPrintSetup and new staff client...
Marc Veron [Fri, 29 Jun 2012 19:31:34 +0000 (21:31 +0200)]
Bug 7563 - Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference

...to version 3.09.00.021

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 6566 Checking if DB's records are properly indexed
Christophe Croullebois [Fri, 8 Jul 2011 09:52:53 +0000 (11:52 +0200)]
Bug 6566 Checking if DB's records are properly indexed

Small script that checks if each bibliorecord in the DB is properly indexed
use -h to learn more
(MT #6389)

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agobug 8323 fixing year sorting of a list
Chris Hall [Thu, 21 Jun 2012 22:36:45 +0000 (10:36 +1200)]
bug 8323 fixing year sorting of a list

Signed-off-by: Marc Veron <veron@veron.ch>
Works as expected.

Caveat: If you edit the list in Opac, change the sort and then klick 'Save',
the List always is displayed in title order. This is du to the fact that
save calls opac-shelves.pl?viewshelf=4 without the sort parameter (defaults
to 'title').
If you go back to lists, choose the list from List name, the param is
correct and the list displays in expected order.

It took quite a time to track  that down, I first thought that opac-shelves.pl
was broken.

However, current bug 8323 is not affected, signing off.

Marc

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoRevert "Added coverage to unit test for TTParser"
Paul Poulain [Fri, 6 Jul 2012 15:00:48 +0000 (17:00 +0200)]
Revert "Added coverage to unit test for TTParser"

This reverts commit 628788ad8a68ea843f37bfa63dd4854b50affd26.

10 years agoBug 8233 follow-up fixin DBRev
Paul Poulain [Fri, 6 Jul 2012 14:54:44 +0000 (16:54 +0200)]
Bug 8233 follow-up fixin DBRev

porting 2nd patch of the bug, that does not apply anymore, to fix DB version

10 years agoBug 8233: Followup: Search engine layer: Add dependencies.
Jonathan Druart [Mon, 25 Jun 2012 15:18:26 +0000 (17:18 +0200)]
Bug 8233: Followup: Search engine layer: Add dependencies.

10 years agoBug 8233: Hide the search engine configuration link for Zebra
Jonathan Druart [Mon, 25 Jun 2012 08:06:57 +0000 (10:06 +0200)]
Bug 8233: Hide the search engine configuration link for Zebra

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
10 years agoBug 8233: Replace the given statement with for
Jonathan Druart [Fri, 22 Jun 2012 14:38:20 +0000 (16:38 +0200)]
Bug 8233: Replace the given statement with for

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
10 years agoBug 8233 : SearchEngine: Add a Koha::SearchEngine module
Jonathan Druart [Wed, 13 Jun 2012 09:48:22 +0000 (11:48 +0200)]
Bug 8233 : SearchEngine: Add a Koha::SearchEngine module

First draft introducing solr into Koha :-)

List of files :
  $ tree t/searchengine/
  t/searchengine
  |-- 000_conn
  |   `-- conn.t
  |-- 001_search
  |   `-- search_base.t
  |-- 002_index
  |   `-- index_base.t
  |-- 003_query
  |   `-- buildquery.t
  |-- 004_config
  |   `-- load_config.t
  `-- indexes.yaml
  just do `prove -r t/searchengine/**/*.t`

  t/lib
  |-- Mocks
  |   `-- Context.pm
  `-- Mocks.pm
  provide a mock to SearchEngine syspref (set_zebra and set_solr).

  $ tree Koha/SearchEngine
  Koha/SearchEngine
  |-- Config.pm
  |-- ConfigRole.pm
  |-- FacetsBuilder.pm
  |-- FacetsBuilderRole.pm
  |-- Index.pm
  |-- IndexRole.pm
  |-- QueryBuilder.pm
  |-- QueryBuilderRole.pm
  |-- Search.pm
  |-- SearchRole.pm
  |-- Solr
  |   |-- Config.pm
  |   |-- FacetsBuilder.pm
  |   |-- Index.pm
  |   |-- QueryBuilder.pm
  |   `-- Search.pm
  |-- Solr.pm
  |-- Zebra
  |   |-- QueryBuilder.pm
  |   `-- Search.pm
  `-- Zebra.pm

How to install and configure Solr ?
  See the wiki page: http://wiki.koha-community.org/wiki/SearchEngine_Layer_RFC

http://bugs.koha-community.org/show_bug.cgi?id=8233
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
10 years agoBug 7787: Make the SIP server much more robust.
Marc Balmer [Wed, 21 Mar 2012 17:18:45 +0000 (18:18 +0100)]
Bug 7787: Make the SIP server much more robust.

Be liberal in what we accept, but strict in what we send:
Never exit the server process, but send a SC_RESEND message (96)
to the client if we received anything we don't understand.
 This is consistent with SIP server implementations of other ILSs.

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 7286: rebuild_zebra_sliced for biblios and authorities
Julian Maurice [Mon, 2 Jul 2012 11:57:31 +0000 (13:57 +0200)]
Bug 7286: rebuild_zebra_sliced for biblios and authorities

Complete rewrite of rebuild_zebra_sliced.zsh (renamed to .sh). Main
improvements are:
  - both biblio and authority records are handled
  - records are exported only once

It also add an option --skip-index to rebuild_zebra.pl that permit to
use rebuild_zebra.pl as an 'export only' script.

Description:
Index Koha records by chunks. It is useful when some record causes
errors and stop the indexation process. With this script, if indexation
of one chunk fails, chunk is splitted in 2 (or 3) chunks, and
indexation continue on these chunks.
rebuild_zebra.pl is called only once to export records.
Splitting and indexing is handled by this script (using yaz-marcdump and
zebraidx).

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 8314 Add MARCISBNs parameter to opac-detail.pl to show multiple isbns in OPAC
David Cook [Fri, 29 Jun 2012 06:53:14 +0000 (16:53 +1000)]
Bug 8314 Add MARCISBNs parameter to opac-detail.pl to show multiple isbns in OPAC

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoadded date and ISBN tests to Koha.t
Mason James [Fri, 6 Jul 2012 04:19:51 +0000 (16:19 +1200)]
added date and ISBN tests to Koha.t

modified:   Koha.t

$ prove  -v ./Koha.t

1..5
ok 1 - use C4::Koha;
ok 2 - use C4::Members;
    1..6
    ok 1 - Insert data in database
    ok 2 - GetAuthorisedValueByCode
    ok 3 - GetKohaImageurlFromAuthorisedValues
    ok 4 - lost and paid works
    ok 5 - Child area works
    ok 6 - Withdrawn works
ok 3 - Authorized Values Tests
    1..4
    ok 1 - C4::Koha->can('GetDailyQuote')
    ok 2 - Got a quote based on id.
    ok 3 - Got a random quote.
    ok 4 - Got a quote based on today's date.
ok 4 - Daily Quotes Test
    1..7
    ok 1 - slashifyDate
    ok 2 - xml_escape() returns empty string on undef input
    ok 3 - xml_escape() works as expected
    ok 4 - ... and does not change input in place
    ok 5 - _isbn_cleanup removes hyphens
    ok 6 - _isbn_cleanup removes parenthetical
    ok 7 - _isbn_cleanup converts ISBN-13 to ISBN-10
ok 5 - Date and ISBN tests
ok
All tests successful.
Files=1, Tests=5,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.48 cusr  0.06 csys =  0.57 CPU)
Result: PASS

http://bugs.koha-community.org/show_bug.cgi?id=5327

10 years agoAdded coverage to unit test for TTParser
Duncan Tyler [Thu, 8 Dec 2011 22:29:53 +0000 (11:29 +1300)]
Added coverage to unit test for TTParser

http://bugs.koha-community.org/show_bug.cgi?id=5327
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Test passes.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agobug 5327: added some tests for C4/Items.pm
Stacey Walker [Mon, 11 Jun 2012 16:06:00 +0000 (17:06 +0100)]
bug 5327: added some tests for C4/Items.pm

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
10 years agoMerge remote-tracking branch 'origin/new/bug_7818'
Paul Poulain [Fri, 6 Jul 2012 09:30:39 +0000 (11:30 +0200)]
Merge remote-tracking branch 'origin/new/bug_7818'

10 years agoBug 7818 : Following, fixing so the packages build Still need to update koha-create...
Chris Cormack [Fri, 29 Jun 2012 10:23:40 +0000 (22:23 +1200)]
Bug 7818 : Following, fixing so the packages build Still need to update koha-create to make use of the new file

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 7619 Use CRLF as default terminator
Colin Campbell [Sat, 9 Jun 2012 14:17:14 +0000 (15:17 +0100)]
Bug 7619 Use CRLF as default terminator

Most units require or tolerate CRLF as the terminator
Using only \r causes many including 3M units to signal errors
due to delay this resets CRLF to be default but adds a single
constant variable and explanation so that if you have a
"strictly conforming" unit (the 'Baby' is the only I have encountered
you know where to make the change

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoPermission for change password button in members toolbar should be borrowers instead...
Lyon3 Team [Thu, 7 Jun 2012 09:39:57 +0000 (11:39 +0200)]
Permission for change password button in members toolbar should be borrowers instead of staffaccess

http://bugs.koha-community.org/show_bug.cgi?id=8242
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 5981 follow-up DBrev number
Paul Poulain [Wed, 4 Jul 2012 14:27:44 +0000 (16:27 +0200)]
Bug 5981 follow-up DBrev number

10 years agoBug 5981 - OPAC: Add limits to search history
Alex Arnaud [Sun, 10 Jun 2012 11:14:24 +0000 (13:14 +0200)]
Bug 5981 - OPAC: Add limits to search history

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixed a conflict in updatedatabase and removed kohaversion.pl from the patch.

Patch works nicely, tested with different searches and limits.

Note: Sort options don't get into the history still.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 8202 follow-up UNIMARC authority support
Paul Poulain [Tue, 3 Jul 2012 16:41:56 +0000 (18:41 +0200)]
Bug 8202 follow-up UNIMARC authority support

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
10 years agoBug 8202: Add authority export to tools/export.pl
Jared Camins-Esakov [Wed, 30 May 2012 12:10:14 +0000 (08:10 -0400)]
Bug 8202: Add authority export to tools/export.pl

Adds a separate tab on tools/export.pl for exporting authority records.

To test:
1. Try exporting authority records from the "Export data" tool

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tried different exports and everything worked nicely:
- removing fields from export (example: 942)
- limiting to one authority type
- changing the given file name
- exporting as MARC or XML

10 years agobug 7630 follow-up : welcome #186 Mark Tompsett
Paul Poulain [Tue, 3 Jul 2012 16:20:07 +0000 (18:20 +0200)]
bug 7630 follow-up : welcome #186 Mark Tompsett

10 years agoBug 7630 - Warning on moremember.pl about param without key Move "$error => 1," to...
Mark Tompsett [Fri, 29 Jun 2012 13:54:44 +0000 (21:54 +0800)]
Bug 7630 - Warning on moremember.pl about param without key Move "$error => 1," to its own conditional $template->param()

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoMerge remote-tracking branch 'origin/new/bug_3280'
Paul Poulain [Tue, 3 Jul 2012 16:17:44 +0000 (18:17 +0200)]
Merge remote-tracking branch 'origin/new/bug_3280'

10 years ago3280 Followup for privacy issue on X-Orig-IP in mail header
Marcel de Rooy [Mon, 2 Jul 2012 08:07:56 +0000 (10:07 +0200)]
3280 Followup for privacy issue on X-Orig-IP in mail header

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoMerge remote-tracking branch 'origin/new/bug_8130'
Paul Poulain [Mon, 2 Jul 2012 12:53:42 +0000 (14:53 +0200)]
Merge remote-tracking branch 'origin/new/bug_8130'

10 years agoBug 8130 follow-up, removing duplicate tab
Paul Poulain [Mon, 2 Jul 2012 12:53:25 +0000 (14:53 +0200)]
Bug 8130 follow-up, removing duplicate tab

In bug 7955, http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955#c21, Nicole spotted that the "notices" tab appear twice.

This patch removes the duplicated tab that has been introduced by this feature, probably a rebase mistake

10 years agoRevert "Bug 7444: Update circ/circulation.pl to use KohaDates TT Plugin"
Paul Poulain [Fri, 29 Jun 2012 15:17:47 +0000 (17:17 +0200)]
Revert "Bug 7444: Update circ/circulation.pl to use KohaDates TT Plugin"

This reverts commit 186cfa5cb00a1c0ee7f0e4512a5f319299bb6412.

10 years agobug 6350 (history.txt) fixing typo
Paul Poulain [Fri, 29 Jun 2012 14:52:20 +0000 (16:52 +0200)]
bug 6350 (history.txt) fixing typo

decmember is not a month afaik ;-)

10 years agoBug 6350 : Updating history
Chris Cormack [Sat, 23 Jun 2012 07:35:55 +0000 (19:35 +1200)]
Bug 6350 : Updating history

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 8217: Followup: move code to the document.ready function
Jonathan Druart [Mon, 18 Jun 2012 08:45:08 +0000 (10:45 +0200)]
Bug 8217: Followup: move code to the document.ready function

Signed-off-by: Mirko Tietgen <5p4m@gmx.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 8318: Update StatisticsFields preference language
Paul Poulain [Fri, 29 Jun 2012 14:47:16 +0000 (16:47 +0200)]
Bug 8318: Update StatisticsFields preference language

Patch rewritten  from the original one from nengard, that I couldn't apply for an unknown reason

This patch changes around the wording of the StatisticsFields
preference to make it clearer where these values will show.

Signed-off-by: Marc Veron <veron@veron.ch>
10 years agoBug 3280 Restrict Send basket feature
Frère Sébastien Marie [Mon, 5 Dec 2011 09:11:46 +0000 (10:11 +0100)]
Bug 3280 Restrict Send basket feature

In order to prevent spamming using sendbasket.pl, some counter-measure are done:
 - permit send basket only for authenticated user
 - permit send basket only if basket contains items
 - use username & email for 'Reply-To' field (with fallback to KohaAdminEmailAddress)
 - add field X-Orig-IP with IP of sender
 - add field X-Abuse-Report with KohaAdminEmailAddress

Note: we don't use forged 'To' address with patron email in order to
prevent be marked as spam (by SPF for example).

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 8311: Fix scoping error in C4::Auth
Jared Camins-Esakov [Mon, 25 Jun 2012 16:11:35 +0000 (12:11 -0400)]
Bug 8311: Fix scoping error in C4::Auth

There is a mis-scoped function call in C4::Auth, on line 154, where
GetMembers is called without explicit scoping and before
'require C4::Members;'. This does not actually have any functional
ramifications as far as I can tell, but it would be a good idea to fix
it.

This patch also corrects a bit of indenting in that area, because it was
an unnecessary challenge to understand the code with the mis-indenting.

Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 6557 follow-up UNIMARC 942$0 in default french frameworks
Paul Poulain [Fri, 29 Jun 2012 13:25:11 +0000 (15:25 +0200)]
Bug 6557 follow-up UNIMARC 942$0 in default french frameworks

10 years agoBug 6557 follow-up DBRev number
Paul Poulain [Fri, 29 Jun 2012 12:44:55 +0000 (14:44 +0200)]
Bug 6557 follow-up DBRev number

10 years agoBug 6557: Record bib popularity in totalissues
Jared Camins-Esakov [Fri, 18 May 2012 00:05:29 +0000 (20:05 -0400)]
Bug 6557: Record bib popularity in totalissues

Because updating the total issues count associated with a bibliographic
record on issue could cause a significant load on the server, this
commit adds the syspref UpdateTotalIssuesOnCirc (which defaults to OFF
to match existing behavior). The syspref has the following description:

  Do/Do not update a bibliographic record's total issues count whenever
  an item is issued (WARNING! This increases server load significantly;
  if performance is a concern, use the update_totalissues.pl cron job
  to update the total issues count).

Bug 6557: automatically increment totalissues

Adds the ability to automatically increment biblioitems.totalissues
whenever an item is issued.

To test:
1) Choose a record with at least one item that can circulate
2) Check the value of 942$0 (you may need to look at the plain MARC view
   on the OPAC). Most likely there won't be any 942$0 at all
3) Enable UpdateTotalIssuesOnCirc
4) Check out the item you selected
5) Check the value of 942$0 (you may need to look at the plain MARC view
   on the OPAC). That value should now be one greater than before
6) Discharge the item
7) Disable UpdateTotalIssuesOnCirc
8) Check out the item you selected again
9) Check the value of 942$0 (you may need to look at the plain MARC view
   on the OPAC). That value should not have changed

Bug 6557: add script to update totalissues from stats

NAME
       update_totalissues.pl

SYNOPSIS
         update_totalissues.pl --use-stats
         update_totalissues.pl --use-items
         update_totalissues.pl --commit=1000
         update_totalissues.pl --since='2012-01-01'
         update_totalissues.pl --interval=30d

DESCRIPTION
       This batch job populates bibliographic records' total issues count
       based on historical issue statistics.

       --help  Prints this help

       -v|--verbose
               Provide verbose log information (list every bib modified).

       --use-stats
               Use the data in the statistics table for populating total
               issues.

       --use-items
               Use items.issues data for populating total issues. Note that
               issues data from the items table does not respect the --since
               or --interval options, by definition. Also note that if both
               --use-stats and --use-items are specified, the count of biblios
               processed will be misleading.

       -s|--since=DATE
               Only process issues recorded in the statistics table since
               DATE.

       -i|--interval=S
               Only process issues recorded in the statistics table in the
               last N units of time. The interval should consist of a number
               with a one-letter unit suffix. The valid suffixes are h
               (hours), d (days), w (weeks), m (months), and y (years). The
               default unit is days.

       --incremental
               Add the number of issues found in the statistics table to the
               existing total issues count. Intended so that this script can
               be used as a cron job to update popularity information during
               low-usage periods. If neither --since or --interval are
               specified, incremental mode will default to processing the
               last twenty-four hours.

       --commit=N
               Commit the results to the database after every N records are
               processed.

       --test  Only test the popularity population script.

WARNING

If the time on your database server does not match the time on your Koha
server you will need to take that into account, and probably use the
--since argument instead of the --interval argument for incremental
updating.

=== TESTING PLAN ===

NOTE: in order to test this script, you will need to have some sort of
circulation data already existing in your Koha installation.

1) Disable UpdateTotalIssuesOnCirc
2) Run: misc/cronjobs/update_totalissues.pl --use-items -t -v
3) If you have total checkout data in your item records (i.e. anything
   in 952$l), you should see messages like "Processing bib 43 (1 issues)"
4) Choose one of the lines that shows more than 0 issues, and view the
   record with that biblionumber in the staff client, choosing the "Items"
   tab (moredetail.pl). Add up the "Total checkouts" listed for each item,
   and confirm it matches what the script reported
5) Run: misc/cronjobs/update_totalissues.pl --use-stats -t -v
6) If you have any circulation statistics in your database (i.e. any
   'issue' entries in your statistics table), you should see messages
   like "Processing bib 43 (1 issues)";
7) Choose one of the lines and view the record with that biblionumber in
   the staff client, choosing the "Items" tab (moredetail.pl). If you
   count the number of checkouts listed in each item's checkout history,
   the total should match what the script reported.
8) Check out an item
9) Run: misc/cronjobs/update_totalissues.pl --use-stats
   --incremental --interval=1h -t -v
10) You should see one line reporting a single circ for the bib record
    associated with the item you just checked out (there may be more if
    you checked out any books in the hour prior to running these tests
11) If the results in steps 4, 7, and 10 match the predictions, the
    script worked

This patch to Koha was sponsored by the Arcadia Public Library and the
Arcadia Public Library Foundation in honor of Jackie Faust-Moreno, late
director of the Arcadia Public Library.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Tested this with my test data - numbers are correct and updated appropriately.

More importantly - if I do a popularity search, the most popular items *come up first*. Amazing.

10 years agoBug 8315 - fix 'C4::Output 3.02' errors in Koha
Mason James [Tue, 26 Jun 2012 03:58:30 +0000 (15:58 +1200)]
Bug 8315 - fix 'C4::Output 3.02' errors in Koha

modified:   opac/opac-ratings-ajax.pl
modified:   opac/opac-tags.pl
modified:   tags/review.pl

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years ago7161 Followup for indentation openlibrary.js
Marcel de Rooy [Wed, 27 Jun 2012 12:34:24 +0000 (14:34 +0200)]
7161 Followup for indentation openlibrary.js

Only whitespace changes to fix indentation after tab removal.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug-7161 Open Library - Larger image, Read, borrow and checked-out status
Amit Gupta [Sat, 5 Nov 2011 07:36:23 +0000 (03:36 -0400)]
Bug-7161 Open Library - Larger image, Read, borrow and checked-out status

To test:
1. go into system administration and search for "cover"
2. change "OpenLibraryCovers" to "add" and all other to "don't show"
3. verify that opac search results have small covers, while
   detail page has big ones

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Addressing M. de Rooy's concerns

* remove console.log
* removed some comments that looked like debug code?
* remove ebook display -  I couldn't get it to work properly, and we want the bigger images. So it's gone.
* remove get_cover

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
June 27, 2012: Removing unused function keys from openlibrary.js.

10 years agoBug 8321: Fix OPACShowBarcode description
Nicole C. Engard [Tue, 26 Jun 2012 05:58:02 +0000 (01:58 -0400)]
Bug 8321: Fix OPACShowBarcode description

This preference had a few grammar errors and repeated the
word 'show.' This patch resolves those issues.

Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 8313 - add ASHS to 'Koha team' page, for sponsorship of the 'star-ratings' feature
Mason James [Mon, 25 Jun 2012 17:12:04 +0000 (05:12 +1200)]
Bug 8313 - add ASHS to 'Koha team' page, for sponsorship of the 'star-ratings' feature

Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 8319: Update headings on Patron Statistics tab
Nicole C. Engard [Tue, 26 Jun 2012 05:23:31 +0000 (01:23 -0400)]
Bug 8319: Update headings on Patron Statistics tab

The patron statistics tab had had headings that were too
hard to understand for the average library user. This patch
changes the language to something less technical.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 8130 follow-up DBRev number
Paul Poulain [Thu, 28 Jun 2012 11:53:50 +0000 (13:53 +0200)]
Bug 8130 follow-up DBRev number

10 years agoBug 8130 - attach PDF files to a patron record
Kyle M Hall [Mon, 21 May 2012 20:42:53 +0000 (16:42 -0400)]
Bug 8130 - attach PDF files to a patron record

Adds the ability to attach unlimited arbitrary files to
a borrower record.

Test Plan:
1) Enable system preference EnableBorrowerFiles
2) Look up borrower record, click 'Files' tab on left
3) Upload a file, download the file, delete the file.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
rebased for current master.

Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
rebased again; some indentation issues in include menus.

10 years agoBug 6939 DefaultClassificationSource should be default in 942
Colin Campbell [Mon, 18 Jun 2012 10:23:42 +0000 (11:23 +0100)]
Bug 6939 DefaultClassificationSource should be default in 942

A logic bug in the original code adding DefaultClassificationSource
caused the default not to be used (the last used value was used instead)
The bug was fixed in additem by bug 2398 but addbiblio's use
of the code was not fixed.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 8205 follow-up DBRev number
Paul Poulain [Thu, 28 Jun 2012 07:22:58 +0000 (09:22 +0200)]
Bug 8205 follow-up DBRev number

10 years agoBug 8205: Add OPACShowUnusedAuthorities syspref
Jared Camins-Esakov [Wed, 30 May 2012 21:29:29 +0000 (17:29 -0400)]
Bug 8205: Add OPACShowUnusedAuthorities syspref

Rather than list authorities that are not actually used by a library,
this commit introduces a new syspref: OPACShowUnusedAuthorities to
enable libraries to hide unused authorities in the OPAC authority browser.

To test:
1) Do a search in the OPAC authority browser that brings up multiple
   results, including some that are used in the bibliographic database
   and some that are not.
2) Observe that the results include both used and unused authorities.
3) Set OPACShowUnusedAuthorities to "Do not."
4) Repeat the same search as in step 1.
5) Observe that the results no longer include unused authorities.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Preference is implemented cleanly and works like advertised.
As a note: The unused authority records will be hidden from display,
but the result list paging does not adjust for the hidden records.
So the result pages will show more or less records total, depending
on how many records are hidden.

10 years agoBug 8279: CAS Debugging improvements
Matthias Meusburger [Thu, 21 Jun 2012 08:39:16 +0000 (10:39 +0200)]
Bug 8279: CAS Debugging improvements

  Adds more precise debug informations for easier CAS troubleshootings resolution.

  Before this patch, whenever ticket validation failed, the debug message was "Invalid ticket".
  But ticket validation may fail for other reasons: CAS server not reachable, casServerUrl syspref is wrong...

  This patch adds the reason for ticket validation failing.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 8288 - showmarc.tt should not include full doc-head-close.inc
Owen Leonard [Fri, 22 Jun 2012 15:52:32 +0000 (11:52 -0400)]
Bug 8288 - showmarc.tt should not include full doc-head-close.inc

showmarc.tt and opac-showmarc.tt are used to load a plain view
of a MARC record and thus do not need the full set of page assets
loaded with other pages (CSS and JavaScript). Removing the
standard doc-head-close include will reduce the load time of
these pages.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 7304 followup DBRev number
Paul Poulain [Wed, 27 Jun 2012 14:56:08 +0000 (16:56 +0200)]
Bug 7304 followup DBRev number

10 years agoBug 7304: More permissions for budgets
Julian Maurice [Fri, 18 May 2012 07:12:43 +0000 (09:12 +0200)]
Bug 7304: More permissions for budgets

- Possibility to add users to a budget
- Restrictions changed to:
  - None
  - Owner
  - Owner and users
  - Owner, users and library
- Restricted users cannot spent on these budgets (they cannot modify them
  either)

Modified pages:
 - admin/aqbudgets.pl
 - admin/aqplan.pl
 - suggestion/suggestion.pl
 - acqui/acqui-home.pl
 - acqui/addorderiso2709.pl
 - acqui/basket.pl
 - acqui/neworderempty.pl

Unit tests in t/Budgets/CanUserUseBudget.t and t/Budgets/CanUserModifyBudget.t

Bug 7304 tmp

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 7905: Follow up - Multi-line subscription notes
Katrin Fischer [Sat, 16 Jun 2012 12:18:36 +0000 (14:18 +0200)]
Bug 7905: Follow up - Multi-line subscription notes

This patch adds the TT filter to other places where we are displaying the
subscription notes:

- OPAC detail page, subscription tab
- OPAC subscription brief history page
- Staff detail page, subscription tab

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 7905: display serial notes on several lines
Adrien Saurat [Thu, 5 Apr 2012 14:43:08 +0000 (16:43 +0200)]
Bug 7905: display serial notes on several lines

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch works and makes use of TT filters!

I agree the display could be improved to work a bit nicer
for long lines or multi-line comments, but this is still a nice
improvement.

10 years agoBug 5345: DataTables integration in acquisition module [5]
Jonathan Druart [Fri, 17 Feb 2012 14:56:30 +0000 (15:56 +0100)]
Bug 5345: DataTables integration in acquisition module [5]

basketgroup.tt

http://bugs.koha-community.org/show_bug.cgi?id=8105
Signed-off-by: Marijana Glavica <mglavica@ffzg.hr>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 8181 [REVISED] Replace DynArch calendar widget with jQueryUI version
Owen Leonard [Tue, 24 Apr 2012 14:49:15 +0000 (10:49 -0400)]
Bug 8181 [REVISED] Replace DynArch calendar widget with jQueryUI version

All instances of the old DynArch calendar have been replaced with
jQueryUI versions and the old library files have been removed.

calendar.inc has been modified to include jQueryUI localization
strings and global configuration options. Just add a "datepicker"
class to an input field to trigger a datepicker prompt.

If you would like two fields in one from to limit each other (one
is date from, one is date to), add these classes to each:
"datepickerfrom" and "datepickerto." This will prevent an invalid
entry, e.g. a date in the latter which falls before the former.

jQueryUI is now upgraded to the latest verision, 1.8.21.

Edit: Now with proper translatability, date formatting, first day
of the week handling, and RTL support.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
QA Comment:  rebased on current master; minor merge conflicts with other patches pushed

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 8191 : Adding a new value to 8 position of coded data field 100
Sophie Meynieux [Tue, 5 Jun 2012 15:44:25 +0000 (17:44 +0200)]
Bug 8191 : Adding a new value to 8 position of coded data field 100

From july 2012, unimarc norm evolves and the value k "monograph with both publication date and print date" must be added for this position.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Checked the new value shows up and is correctly copied into the field.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 8255: allow local cover images to be cached
Jared Camins-Esakov [Fri, 15 Jun 2012 17:59:55 +0000 (13:59 -0400)]
Bug 8255: allow local cover images to be cached

At the moment, local cover images cannot be cached by the web browser
or any intermediate reverse proxies. This results in an unnecessary
load on the server, and is entirely unnecessary.

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoMerge remote-tracking branch 'origin/new/bug_7143'
Paul Poulain [Mon, 25 Jun 2012 16:01:28 +0000 (18:01 +0200)]
Merge remote-tracking branch 'origin/new/bug_7143'

10 years ago7143 Followup for timeline
Marcel de Rooy [Thu, 21 Jun 2012 09:01:15 +0000 (11:01 +0200)]
7143 Followup for timeline

Fixes few tabs within date; adds a regex to fix mistakes with spaces.

Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 7368 - General staff client typo omnibus
Marc Veron [Mon, 25 Jun 2012 07:59:36 +0000 (09:59 +0200)]
Bug 7368 - General staff client typo omnibus

Corrects 2 typos, see comment #9

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 6090: Do not enqueue empty messages
Julian Maurice [Thu, 8 Mar 2012 12:50:47 +0000 (13:50 +0100)]
Bug 6090: Do not enqueue empty messages

This patch avoid enqueuing messages that have an empty body. It can
happen when letter is empty or becomes empty after being processed by
parseletter

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 8194 - Layout problem on subscription add when showing manual history
Owen Leonard [Fri, 15 Jun 2012 14:36:33 +0000 (10:36 -0400)]
Bug 8194 - Layout problem on subscription add when showing manual history

Markup errors were causing display problems when the "manual history"
section is shown.

To test, apply the patch, load the subscription add page, and check
the "manual history" checkbox. The "Serials planning" section
should appear directly below the "manual history" section.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 7379: display of copy number description (AV)
Adrien Saurat [Sat, 9 Jun 2012 14:44:28 +0000 (15:44 +0100)]
Bug 7379: display of copy number description (AV)

The biblio/items detail pages (staff and OPAC) display
the copynumber description if an authorized value
is configured accordingly.

Signed-off-by: Gaetan Boisson <gaetan.boisson@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 8224 - Make authorized values appear in planning list
Alex Arnaud [Mon, 11 Jun 2012 08:58:24 +0000 (10:58 +0200)]
Bug 8224 - Make authorized values appear in planning list

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I can confirm the bugs on current master and this patch fixes both problems.

- Pull down list for "Planning" on the budget page was not showing
  categories of authorized values
- Planning page showed the categories, but budget_period_id was
  missing from the URL

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 8241: Remove text fragment from Z39.50-Server search
Katrin Fischer [Sun, 17 Jun 2012 05:41:25 +0000 (07:41 +0200)]
Bug 8241: Remove text fragment from Z39.50-Server search

Removes an accidently added "curr" from below the search options
for administration > Z39.50 client targets.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 8241 - Remove stray references to YUI autocomplete
Owen Leonard [Tue, 12 Jun 2012 13:46:12 +0000 (09:46 -0400)]
Bug 8241 - Remove stray references to YUI autocomplete

- Removing unused references to YUI assets in authorities/auth_finder.tt
- Removing unneeded call to autocomplete JS in help-top.inc and
  adding new jQuery dependencies.
- Minor HTML markup corrections to auth-finder-search.inc discovered
  in debugging the patch.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested:
- help files on various pages
- auth finder plugin in cataloguing
- authority search in authorities module

10 years agoBug 8282: Bug in modules list in about.pl
Matthias Meusburger [Thu, 21 Jun 2012 13:41:54 +0000 (15:41 +0200)]
Bug 8282: Bug in modules list in about.pl

  Last modules were not displayed if the number of modules did not match the number of rows of the table (when $number_of_modules % 4 != 0)

Signed-off-by: Marc Veron <veron@veron.ch>
Added some code to about.tt to have empty the last remaining cells, not sure if an other signoff is needed.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 8289 Upgrading from 2.2 does not work anymore
Paul Poulain [Fri, 22 Jun 2012 09:10:18 +0000 (11:10 +0200)]
Bug 8289 Upgrading from 2.2 does not work anymore

The updatedatabase22to30.pl script update the engine from MyISAM to InnoDB for most tables.

However, the TYPE=InnoDB was deprecated, and is not removed.
The correct syntax is now ENGINE=InnoDB

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
10 years agoBug 8272 - OPAC : date expiration format
Owen Leonard [Tue, 19 Jun 2012 17:08:28 +0000 (13:08 -0400)]
Bug 8272 - OPAC : date expiration format

Adding TT date filter to output of expiration date
on OPAC user page.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 8043 - today's checkouts are in Previous checkouts in circulation.pl
Kyle M Hall [Thu, 14 Jun 2012 10:33:51 +0000 (06:33 -0400)]
Bug 8043 - today's checkouts are in Previous checkouts in circulation.pl

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 8251 - Patrons get incorrectly debarred
Tomas Cohen Arazi [Fri, 15 Jun 2012 17:51:42 +0000 (14:51 -0300)]
Bug 8251 - Patrons get incorrectly debarred

Patrons get incorrectly debarred because of the use of Datetime->delta_days
wich happens to always return a positive number.

Also changed the use of Datetime->truncate function so it follows the docs,
using 'day' instead of 'days' (which is used in DateTime::Duration).

This patch has been tested against master.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 8154: The export today's checked in barcodes generated file is always empty
Jonathan Druart [Mon, 18 Jun 2012 08:19:12 +0000 (10:19 +0200)]
Bug 8154: The export today's checked in barcodes generated file is always empty

Comparation of date and datetime is always false

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Exported file contains the list of checked in items.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 8267 - Overdue notices not working
Kyle M Hall [Mon, 18 Jun 2012 14:08:23 +0000 (10:08 -0400)]
Bug 8267 - Overdue notices not working

The variable $i was being re-used and overwriting the necessary value that was being passed to a subroutine. Renaming $i to $j fixed it. I also added an extra safety check within parse_letter that would also have prevented this bug.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 3708 follow-up DBRev number
Paul Poulain [Wed, 20 Jun 2012 21:11:20 +0000 (23:11 +0200)]
Bug 3708 follow-up DBRev number

10 years agoBug 3708 - Add another customizable region to the OPAC: right sidebar nav
Paul Poulain [Wed, 20 Jun 2012 21:11:06 +0000 (23:11 +0200)]
Bug 3708 - Add another customizable region to the OPAC: right sidebar nav

This patch creates a new system preference, OpacNavRight, in
which the librarian can add HTML which will appear on the OPAC
main page under the login form. If the user is logged in the content
will appear in place of the login form.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 4255 - Add item type to facet list
Meenakshi.R [Wed, 30 May 2012 10:36:33 +0000 (16:06 +0530)]
Bug 4255 - Add item type to facet list

This is for MARC 21 only.

Made following changed:

- In getFacets in C4/Koha.pm added item type facet for 952y and 942c
- In getRecords in C4:Search.pm added code to get description of itemtype codes
- facets.inc in both staff and opac to show item types related label in the facets block

To test:

Add records such that a certain itype (say BK) is present in both 942c and 952y in two DIFFERENT records.

Run a search where both test records are present. Test to see if itype types are presented in the facets block (both OPAC and staff).

Click on the itype (say BK), both the test records should appear in the refined results. This shows that the feature works for both 942c and 952y.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Ian Walls <koha.sekjal@gmail.com>
QA Comment: fixed capitalization in template includes according to HTML4 coding
guideline ("Item types" instead of "ItemTypes")

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 5910: [SIGNED-OFF] only add "All authority types" for UNIMARC
Jared Camins-Esakov [Sun, 10 Jun 2012 14:16:16 +0000 (10:16 -0400)]
Bug 5910: [SIGNED-OFF] only add "All authority types" for UNIMARC

UNIMARC is the only marcflavour that does not already have an option
for searching all authority types, so check that the marcflavour is
UNIMARC before displaying the additional "All authority types" option.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 5910: allow users to search on all auth types
Paul Poulain [Tue, 9 Aug 2011 14:50:50 +0000 (16:50 +0200)]
Bug 5910: allow users to search on all auth types

Add search on "all authorities types" option in the authorities type select

rewritten for T::T

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
10 years agoMerge remote-tracking branch 'origin/new/bug_6634'
Paul Poulain [Wed, 20 Jun 2012 20:19:06 +0000 (22:19 +0200)]
Merge remote-tracking branch 'origin/new/bug_6634'

10 years agobug 6634 : 3 more cases of manager_id not populated
Maxime Pelletier [Wed, 28 Mar 2012 21:26:01 +0000 (17:26 -0400)]
bug 6634 : 3 more cases of manager_id not populated

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 6774 follow-up DBRev number
Paul Poulain [Wed, 20 Jun 2012 20:04:51 +0000 (22:04 +0200)]
Bug 6774 follow-up DBRev number

10 years agoBug 6774 Display barcode on OPAC detail page(Correcting Typo).
Amit Gupta [Fri, 7 Oct 2011 05:27:24 +0000 (10:57 +0530)]
Bug 6774 Display barcode on OPAC detail page(Correcting Typo).

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Rebased to current master, works in my tests, but needs another set of eyes.
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
10 years agoBug 7447 allow to specify a date in overdue_notice.pl
Paul Poulain [Mon, 16 Jan 2012 16:19:26 +0000 (17:19 +0100)]
Bug 7447 allow to specify a date in overdue_notice.pl

This patch add a new parameter to overdue_notices.pl, that is a date.
If you add --date=YYYY-MM-DD when running overdue_notices, it will generate overdues as if you were on date provided

that's usefull if you want to relaunch an overdue calculation that has failed, of after changing your circ rules

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoAdding Claire Hernandez as contributor + adding missing contributors in about.tt
Paul Poulain [Wed, 20 Jun 2012 19:49:40 +0000 (21:49 +0200)]
Adding Claire Hernandez as contributor + adding missing contributors in about.tt

10 years agoBug 7642 - remove the cloud weight from the tags
Robin Sheat [Sun, 10 Jun 2012 13:32:56 +0000 (14:32 +0100)]
Bug 7642 - remove the cloud weight from the tags

Signed-off-by: Stacey Walker <stacey@catalyst-eu.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 7857 - [SIGNED-OFF] database upgrade fails with plack
Dobrica Pavlinusic [Mon, 18 Jun 2012 08:32:00 +0000 (10:32 +0200)]
Bug 7857 - [SIGNED-OFF] database upgrade fails with plack

This patch fixes PERL5LIB path injection to include installer dir
which is required

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 7857 - database upgrade fails with plack
Dobrica Pavlinusic [Fri, 30 Mar 2012 20:03:20 +0000 (22:03 +0200)]
Bug 7857 - database upgrade fails with plack

Updating database structure

Update errors :

    Can't locate C4/Context.pm in @INC (@INC contains: /etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl /usr/local/lib/perl/5.10.0 /usr/local/share/perl/5.10.0 .) at /srv/koha/installer/data/mysql/updatedatabase.pl line 37.
    BEGIN failed--compilation aborted at /srv/koha/installer/data/mysql/updatedatabase.pl line 37.

It seems that plack cleans enviroment, so we have to re-instart PERL5LIB
so script invocation won't fail.

It also fixes exit 1 which fail with plack.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 7857 - invalidate cached preferences after SetVersion
Dobrica Pavlinusic [Thu, 5 Apr 2012 12:15:30 +0000 (14:15 +0200)]
Bug 7857 - invalidate cached preferences after SetVersion

This allows plack to correctly move to login page after database upgrade

10 years agoBug 7955 follow-up spelling fixes
Paul Poulain [Wed, 20 Jun 2012 19:31:43 +0000 (21:31 +0200)]
Bug 7955 follow-up spelling fixes

* removing useless upper cases
* s/precedent/previous/ and s/Actual/Current/ to be consistent with other Koha pages

10 years agoBug 7955 follow-up DBRev number
Paul Poulain [Wed, 20 Jun 2012 19:30:54 +0000 (21:30 +0200)]
Bug 7955 follow-up DBRev number

10 years agoBug 7955: Statistics tab for Patron checkouts
Jonathan Druart [Fri, 13 Apr 2012 14:21:32 +0000 (16:21 +0200)]
Bug 7955: Statistics tab for Patron checkouts

This patch adds a new 'statistics' tab in the Patron module.
For a borrower, this tab contains a table with:
- number of checkout for today
- number of checkin for today
- "precedent state", the number of checkouts the patron had yesterday on
  its library card
- "actual state", the number of checkouts on the borrower card at the current date

A new syspref (StatisticsFields) contains a list of fields (separated by
pipe (|) on which the table results is based. The default value is
location|itype|ccode

Signed-off-by: Mathilde Formery <mathilde.formery@ville-nimes.fr>
10 years agoBug 7994: Fix pref yaml errors
Claire Hernandez [Mon, 11 Jun 2012 13:52:10 +0000 (15:52 +0200)]
Bug 7994: Fix pref yaml errors

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
10 years agoBug 7994: scripts to check yaml files
Claire Hernandez [Mon, 23 Apr 2012 13:11:46 +0000 (15:11 +0200)]
Bug 7994: scripts to check yaml files

$ prove yaml_valid.t
checks a closed list of files
$ perl yaml_valid.pl -f myfile.yaml
try to load a yaml file with YAML::LoadFile and show errors

(both files pertidied)

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>