koha.git
13 years agoadded dependencies for new OAI-PMH server
Galen Charlton [Wed, 1 Apr 2009 16:49:43 +0000 (11:49 -0500)]
added dependencies for new OAI-PMH server

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdd a UNIMARC to Dublin Core XSL
Frédéric Demians [Thu, 26 Mar 2009 20:54:25 +0000 (21:54 +0100)]
Add a UNIMARC to Dublin Core XSL

This XSL transforms XML UNIMARC biblio record into
its DC representation. It is the equivalent of
MARC21slimOAIDC.xsl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdd another OAI server
Frederic Demians [Thu, 26 Mar 2009 20:54:24 +0000 (21:54 +0100)]
Add another OAI server

This OAI server has those characteristics:

   * It doesn't use C4::OAI anymore.
   * It uses HTTP::OAI library which is easily expandable.
   * XML result is not build anymore directly but using
     XML::SAX::Writer. It should solve encoding and XML related issues.
   * It returns two formats: oai_dc and marcxml.
   * DC is generated from biblioitems.marcxml by applying XSLT
     (MARC21slim2OAIDC.xsl or UNIMARCslim2OAIDC.xsl).
   * It uses the same tokens as previous OAI server (thanks Philippe
     Jaillon).
   * There is no more sets (it wasn't operational in previous version).

Add two new dependencies:

   * HTTP::OAI
   * XML::SAX::Writer
     available as a Debian package: libxml-sax-writer-perl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoadd } that slipped out because of bad merge
Galen Charlton [Wed, 1 Apr 2009 16:02:48 +0000 (11:02 -0500)]
add } that slipped out because of bad merge

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug #3071 - Z39.50 search result highlights are mixed
Frédéric Demians [Sun, 29 Mar 2009 08:55:34 +0000 (10:55 +0200)]
Bug #3071 - Z39.50 search result highlights are mixed

This patch modifies z3950 search result page in order to
use jquery to highlight rows rather than an explicit
css class.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdd Babeltheque OPAC enhanced content
Frédéric Demians [Sat, 28 Mar 2009 07:23:42 +0000 (08:23 +0100)]
Add Babeltheque OPAC enhanced content

www.babeltheque.com is a LibraryThings for Libraries equivalent.
This patch enables this service on OPAC.

  * Replace previous patch in order to apply onto last master HEAD
    and solve conflicts induced by last pushed pateches:
    1bb9f76e66fd962930007964a2f918665dc3a956
  * Modify kohaversion.pl
  * It uses v3.01.00.016 slot.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix Amazon cover for UNIMARC
Frédéric Demians [Mon, 30 Mar 2009 06:42:22 +0000 (08:42 +0200)]
Fix Amazon cover for UNIMARC

In UNIMARC, 010 tag contains ISBN. In UNIMARC, ISBN with '-'
are valid. This patch modify ISBN normalization in order to
automaticaly suppress '-' before sending ISBN to Amazon
to get book cover.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoReformatting receipt template and CSS to be more readable.
Owen Leonard [Sun, 29 Mar 2009 23:46:39 +0000 (18:46 -0500)]
Reformatting receipt template and CSS to be more readable.

A narrow printable area is unsuitable for a three-column table of information. Changing to paragraph sections for each item. Also correcting terminology: issue -> checkout

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBUG-1503: fixes broken matching for 'hidden' values.
Mason James [Sun, 29 Mar 2009 23:54:15 +0000 (12:54 +1300)]
BUG-1503: fixes broken matching for 'hidden' values.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2913) show "--" on repeated fields
Nahuel ANGELINETTI [Wed, 14 Jan 2009 12:26:51 +0000 (13:26 +0100)]
(bug #2913) show "--" on repeated fields

This patch just transform the script to set the field title as "--" if it was already shown.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofix to ignore 600$2 'Source of heading' fields for MARC21 subject display
Mason James [Wed, 1 Apr 2009 04:11:13 +0000 (17:11 +1300)]
fix to ignore 600$2 'Source of heading' fields for MARC21 subject display

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdding patron address to select patron form.
Owen Leonard [Mon, 30 Mar 2009 16:15:04 +0000 (11:15 -0500)]
Adding patron address to select patron form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #3057) mandatory subfield edition
Nahuel ANGELINETTI [Wed, 25 Mar 2009 15:12:06 +0000 (16:12 +0100)]
(bug #3057) mandatory subfield edition

modify the "name" of mandatory input field.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoConvert opac-reserve to use GetBranchesLoop.
Joe Atzberger [Tue, 24 Mar 2009 21:36:11 +0000 (16:36 -0500)]
Convert opac-reserve to use GetBranchesLoop.

Removed irrelevant and unused variables dealing with branches.
Also pulled default branch from userenv when not specified as a param.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoImprove performance and fault tolerance for sync_items...
Joe Atzberger [Mon, 23 Mar 2009 21:25:21 +0000 (16:25 -0500)]
Improve performance and fault tolerance for sync_items...

Pulled the GetMarcFromKohaField outside the loop, since we only need to
check it once.  Same for $item_sth.  Added safety checks for success of
delete_field and GetMarcItem, with warnings on failure.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agocleanup some of value_builder MARC21 plugins
Joe Atzberger [Fri, 13 Mar 2009 19:22:43 +0000 (14:22 -0500)]
cleanup some of value_builder MARC21 plugins

Tons of unnecessary dependencies removed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoperltidy some ugly value_builder plugins
Joe Atzberger [Fri, 13 Mar 2009 19:22:42 +0000 (14:22 -0500)]
perltidy some ugly value_builder plugins

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agowhitespace cleanup and remove editor comments
Joe Atzberger [Wed, 18 Mar 2009 22:21:48 +0000 (17:21 -0500)]
whitespace cleanup and remove editor comments

No functionality affected.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #3063) fix unimarc 4xx plugin with cloned field
Nahuel ANGELINETTI [Thu, 26 Mar 2009 12:59:37 +0000 (13:59 +0100)]
(bug #3063) fix unimarc 4xx plugin with cloned field

this patch fix the unimarc plugin 4xx to work with cloned fields, the id of the div wasn't replaced when the field was cloned.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoInstructions and packages required for Debian Lenny Installation
Frederic Demians [Fri, 13 Mar 2009 07:14:58 +0000 (08:14 +0100)]
Instructions and packages required for Debian Lenny Installation

INSTALL.debian-lenny
    Instructions for installing Koha on Debian Lenny.
    Based on INSTALL.debian. Almost all Perl modules are now available
    via Debian packages. MySQL installation is simplified.

debian-lenny.packages
    List of all Lenny packages required by Koha.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug #3036 Avoid command-line installer blocking on opensolaris plateform
Frederic Demians [Fri, 13 Mar 2009 19:47:25 +0000 (20:47 +0100)]
Bug #3036 Avoid command-line installer blocking on opensolaris plateform

Koha installation/upgrade on OpenSolaris 'seems' to work.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofixes error below...
Mason James [Sun, 15 Mar 2009 05:52:35 +0000 (18:52 +1300)]
fixes error below...

 bookcount.pl: Illegal Date 'Item has no branch transfers record' does not match 'iso' format: yyyy-mm-dd at /home/mason/git/kap-k3-2/circ/bookcount.pl line 88

tested on 3.0.x

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofixes many 'Use of uninitialized value in string eq at ...' warnings.. at admin/branc...
Mason James [Mon, 16 Mar 2009 11:49:01 +0000 (00:49 +1300)]
fixes many 'Use of uninitialized value in string eq at ...' warnings.. at admin/branches.pl line 242.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoChanging "Waiting to be pulled" to "Pending" as per Bug 3033 'Holds "Waiting to be...
Owen Leonard [Mon, 16 Mar 2009 15:23:41 +0000 (10:23 -0500)]
Changing "Waiting to be pulled" to "Pending" as per Bug 3033 'Holds "Waiting to be pulled" falsely implies that items are available'

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoMinor bug fix Documentation update : 3039
Henri-Damien LAURENT [Mon, 16 Mar 2009 20:34:39 +0000 (21:34 +0100)]
Minor bug fix Documentation update : 3039

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoHiding labels for add to list options when user isn't logged in or options don't...
Owen Leonard [Tue, 17 Mar 2009 20:02:43 +0000 (15:02 -0500)]
Hiding labels for add to list options when user isn't logged in or options don't exist. Fixes Bug 3043.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoquietens a noisy debug pop-up, when debugging
Mason James [Wed, 18 Mar 2009 03:19:34 +0000 (16:19 +1300)]
quietens a noisy debug pop-up, when debugging

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2958 - notforloan (8008) is a numeric field.
Joe Atzberger [Thu, 19 Mar 2009 19:06:26 +0000 (14:06 -0500)]
Bug 2958 - notforloan (8008) is a numeric field.

Update index to allow searching for "On Order" items, -1 value.
Example:
http://atz.dev.kohalibrary.com/cgi-bin/koha/opac-search.pl?q=ccl=notforloan:-1

Without this patch, search for "-1" is normalized to "1".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoInvalid field 'expiry' referenced.
Joe Atzberger [Wed, 18 Mar 2009 22:21:49 +0000 (17:21 -0500)]
Invalid field 'expiry' referenced.

This caused a warning from C4::Dates on every execution, since the value
passed to format_date was undefined.  Now we reference the correct field
and check for a populated value before trying to reformat it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug Fix : weight field was broken in UNIMARC
Henri-Damien LAURENT [Tue, 24 Mar 2009 13:45:29 +0000 (14:45 +0100)]
Bug Fix : weight field was broken in UNIMARC

Title-cover was not defined in record.abs
So the relevance ranking was broken.
This patch corrects that
For UNIMARC people, please reindex

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix for Bug 3062, "place hold on lists different font"
Owen Leonard [Fri, 27 Mar 2009 20:31:52 +0000 (15:31 -0500)]
Fix for Bug 3062, "place hold on lists different font"

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoconvert '&' to '&amp;' in Syndetics URLs
Galen Charlton [Fri, 27 Mar 2009 23:07:08 +0000 (18:07 -0500)]
convert '&' to '&amp;' in Syndetics URLs

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoDB rev 014 -> 015
Galen Charlton [Fri, 27 Mar 2009 22:24:18 +0000 (17:24 -0500)]
DB rev 014 -> 015

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoChanged syndetics base URI from syndetics.com to www.syndetics.com
Daniel Sweeney [Tue, 10 Mar 2009 16:10:43 +0000 (11:10 -0500)]
Changed syndetics base URI from syndetics.com to syndetics.com

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdded upc to content_identifier_exists criteria.
Daniel Sweeney [Tue, 10 Mar 2009 15:56:30 +0000 (10:56 -0500)]
Added upc to content_identifier_exists criteria.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdded content_identifier_exists test to opac-detail.tmpl to prevent broken images...
Daniel Sweeney [Fri, 6 Mar 2009 16:00:40 +0000 (10:00 -0600)]
Added content_identifier_exists test to opac-detail.tmpl to prevent broken images in Syndetics content for some titles.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix for LL Bug 405: Syndetics Enhanced Content: some cover imags are being generated...
Joshua Ferraro [Thu, 5 Mar 2009 22:29:01 +0000 (16:29 -0600)]
Fix for LL Bug 405: Syndetics Enhanced Content: some cover imags are being generated as IMGs but show as broken images

Adds new template variable to test for enhanced content identifiers

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix for LL Bug 404: Syndetics Enhanced Content: Excerpts show with embedded HTML...
Joshua Ferraro [Thu, 5 Mar 2009 19:30:29 +0000 (13:30 -0600)]
Fix for LL Bug 404: Syndetics Enhanced Content: Excerpts show with embedded HTML tags and entity references

XMLout needed the NoEscape option set

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoSyndetics Enhancement: adds upc/oclc to the functions to retrive non-image data
Joshua Ferraro [Thu, 5 Mar 2009 16:10:06 +0000 (10:10 -0600)]
Syndetics Enhancement: adds upc/oclc to the functions to retrive non-image data

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoSyndetics and Amazon bugfix enhancements
Joshua Ferraro [Thu, 5 Mar 2009 00:48:41 +0000 (18:48 -0600)]
Syndetics and Amazon bugfix enhancements

This patch resolves a number of problems related to Enhanced Content:

1. Previously, there was no syspref for controlling whether or not to display
Amazon.com cover images apart from other content. This had the side effect
of preventing use of amazon.com content alongside use of another provider's
images. This patch introduces AmazonCoverImages and OPACAmazonCoverImages,
and changes the name of AmazonContent to AmazonEnabled.

So, for instance, you can now enable OPACAmazonSimilarItems yet utilize
SyndeticsCoverImages for displaying those similar items.

NOTE TO DOCUMENTATION TEAM: please update references to AmazonContent
and OPACAmazonContent to comply with the above.

2. Fixes some semantically incorrect uses of AmazonContent (now OPACAmazonEnabled)
on the OPAC side.

3. Resolves once and for all, the normalization of ISBN,UPC,EAN and OCLC numbers
for all enhanced content elements; These elements can be normalized using the
new functions in C4::Koha; I've replaced use of the various previously used
variables $xisbn,$norm_isbn,$clean_isbn, etc with $isbn, and the template
variable normalized_isbn.

We finally have a single, consistant place to retrieve normalize values for
these fields given a particular record.

4. Adds Syndetics attribution statements to display of all Syndetics content
'enhanced content provide by Syndetics' or 'Enhanced Description from Syndetics'

5. Adds an option to view the large cover image on the detail page on the OPAC
when using SyndeticsCoverImages; this option is controlled by a new system
preference: SyndeticsCoverImageSize which has two values: MC (medium) LC (large)

6. Adds UPC and OCLC numbers for Syndetics enhanced content queries especially
helpful for finding enhanced content for DVD and Music materials

7. Adds capability to display Syndetics images to opac-user for checkouts and overdues

8. Updates to systempreferences.sql, and updatedatabase.pl database revision 015

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoSecond patch to address LL Bug 367 Titles without ISBNs display "no cover image avail...
Joshua Ferraro [Mon, 16 Feb 2009 16:42:36 +0000 (10:42 -0600)]
Second patch to address LL Bug 367 Titles without ISBNs display "no cover image available" while titles with ISBNS that don't match a Syndetics cover display nothing

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdd Syndetics AuthorNotes, Awards, Series
Joshua Ferraro [Mon, 16 Feb 2009 16:28:00 +0000 (10:28 -0600)]
Add Syndetics AuthorNotes, Awards, Series

This patch also includes a new function to retrieve the index
page from Syndetics and parse it for available content prior to
retrieving content; this is done to speed up syndetics content
by not retrieving content that doesn't exist for an item. However,
Syndetics continues to be a very slow service compared to Amazon.com
and other enhanced content services

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix for LL bug 367 Titles without ISBNs display "no cover image available"
Joshua Ferraro [Thu, 12 Feb 2009 18:59:22 +0000 (12:59 -0600)]
Fix for LL bug 367 Titles without ISBNs display "no cover image available"

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdds Syndetics Reviews
Joshua Ferraro [Sun, 8 Feb 2009 18:59:21 +0000 (12:59 -0600)]
Adds Syndetics Reviews

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdds support for Syndetics Excerpts and Editions
Joshua Ferraro [Fri, 6 Feb 2009 22:52:27 +0000 (16:52 -0600)]
Adds support for Syndetics Excerpts and Editions

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdd Syndetics Summaries and TOC
Joshua Ferraro [Fri, 6 Feb 2009 20:34:32 +0000 (14:34 -0600)]
Add Syndetics Summaries and TOC

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdding Syndetics Cover Images to OPAC Detail Page, including shelf browser
Joshua Ferraro [Fri, 6 Feb 2009 19:31:54 +0000 (13:31 -0600)]
Adding Syndetics Cover Images to OPAC Detail Page, including shelf browser

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdds Syndetics Cover Images to Results Page on OPAC
Joshua Ferraro [Fri, 6 Feb 2009 19:11:06 +0000 (13:11 -0600)]
Adds Syndetics Cover Images to Results Page on OPAC

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdd System Prefs for Syndetics to Auth
Joshua Ferraro [Fri, 6 Feb 2009 19:06:47 +0000 (13:06 -0600)]
Add System Prefs for Syndetics to Auth

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoMove Amazon.pm to External/ directory
Joshua Ferraro [Fri, 6 Feb 2009 18:52:08 +0000 (12:52 -0600)]
Move Amazon.pm to External/ directory

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoDatabase Revisions for Syndetics Solutions Enhanced Content
Joshua Ferraro [Fri, 6 Feb 2009 18:27:16 +0000 (12:27 -0600)]
Database Revisions for Syndetics Solutions Enhanced Content

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix for Bug 3031, Standardize OPAC login form labels.
Owen Leonard [Wed, 11 Mar 2009 23:52:31 +0000 (18:52 -0500)]
Fix for Bug 3031, Standardize OPAC login form labels.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofix error introduced in a previous commit
Galen Charlton [Wed, 11 Mar 2009 15:28:44 +0000 (10:28 -0500)]
fix error introduced in a previous commit

Change to GetReservesFromBiblionumber() had effect
of causing all requests of constrainttype other
than 'o' to not be included in result.

while ($foo) {
    $bar or next;
    # do stuff
    # do other stuff
}

is not equivalent to

while ($foo) {
    if ($bar) {
        # do stuff
    }
    # do other stuff

}

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 3028: remove reservefix.pl cronjob
Galen Charlton [Wed, 11 Mar 2009 14:09:30 +0000 (09:09 -0500)]
bug 3028: remove reservefix.pl cronjob

Removed cronjob, which was written to work around
a bug in 2.2 that no longer applies and is specific
to a single library in any event.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoTest for LCCN splitting.
Joe Atzberger [Sat, 7 Mar 2009 00:27:50 +0000 (18:27 -0600)]
Test for LCCN splitting.

This test establishes what LCCN splitting is required to do
to be considered successful.  See Bug 2691.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoCorrecting delete patron button to use TMPL_VAR instead of DOM query. Fixes Bug 3014...
Owen Leonard [Sat, 7 Mar 2009 16:34:42 +0000 (10:34 -0600)]
Correcting delete patron button to use TMPL_VAR instead of DOM query. Fixes Bug 3014, Can't delete restricted patron from circulation screen.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix for Bug 3015: Check-in screen displays branch name inconsistently
Owen Leonard [Sat, 7 Mar 2009 17:41:50 +0000 (11:41 -0600)]
Fix for Bug 3015: Check-in screen displays branch name inconsistently

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoChanges to tabindex values to improve keyboard access.
Owen Leonard [Mon, 9 Mar 2009 13:38:06 +0000 (08:38 -0500)]
Changes to tabindex values to improve keyboard access.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoSort collection codes by description for dropdown.
Joe Atzberger [Mon, 9 Mar 2009 18:51:58 +0000 (13:51 -0500)]
Sort collection codes by description for dropdown.

Collection code descriptions were otherwise displaying in an
unsorted order.  The result was not readable for any sufficiently
large number of ccodes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix for Bug 3027, Hide RSS option in patron messaging. Also includes some markup...
Owen Leonard [Wed, 11 Mar 2009 13:24:57 +0000 (08:24 -0500)]
Fix for Bug 3027, Hide RSS option in patron messaging. Also includes some markup cleanup.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoCorrect perldoc
Joe Atzberger [Mon, 9 Mar 2009 18:51:57 +0000 (13:51 -0500)]
Correct perldoc

Indentations misformatted for code blocks.  Also updated reference to
GetBranchesLoop.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoUI tweaks to OPAC holds screen following addition of multiple holds functionality...
Owen Leonard [Mon, 9 Mar 2009 19:27:39 +0000 (14:27 -0500)]
UI tweaks to OPAC holds screen following addition of multiple holds functionality. Addition of subtitle and copy number to output.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2691 - LCCN split (for labels)
Joe Atzberger [Mon, 9 Mar 2009 20:19:31 +0000 (15:19 -0500)]
Bug 2691 - LCCN split (for labels)

This corresponds with the test I submitted earlier and essentially
overrides the partial improvement from Nighswonger under Bug 2500.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoResubmitting: tweaks to search results page, including using amazonisbn to pull cover...
Owen Leonard [Mon, 9 Mar 2009 19:51:25 +0000 (14:51 -0500)]
Resubmitting: tweaks to search results page, including using amazonisbn to pull cover image and inline display of itemtype images to improve display.

The previous method for displaying itemtype images relied on setting a background-image for a list item. This method didn't take into account the possibility of varying sizes for images, resulting in overlap with some images. This patch also includes some changes to improve readability of holdings information.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFixed a typo that kept branches out of the Advance Notice and Item Due notifications.
Daniel Sweeney [Mon, 9 Mar 2009 21:44:36 +0000 (16:44 -0500)]
Fixed a typo that kept branches out of the Advance Notice and Item Due notifications.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoResubmitting: fixes print statements with missing 'STDERR' in Auth_with_ldap.pm,
Mason James [Tue, 10 Mar 2009 01:50:53 +0000 (14:50 +1300)]
Resubmitting: fixes print statements with missing 'STDERR' in Auth_with_ldap.pm,

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #3025) multiple check-in of a multiple times reserved item go wrong
Nahuel ANGELINETTI [Tue, 10 Mar 2009 14:28:17 +0000 (15:28 +0100)]
(bug #3025) multiple check-in of a multiple times reserved item go wrong

This patch check that an item is not "Waiting" before do something in GetOtherReserves(because is the item is waiting, we don't need to do something).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2617: Add strict (and warnings), partial fix.
Joe Atzberger [Tue, 10 Mar 2009 21:41:00 +0000 (16:41 -0500)]
Bug 2617: Add strict (and warnings), partial fix.

These are some of the simpler scripts to add strict to.
Corrected perldoc for Bookfund.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoInstallAuth doesn't have setlanguagecookie to export.
Joe Atzberger [Tue, 10 Mar 2009 21:40:59 +0000 (16:40 -0500)]
InstallAuth doesn't have setlanguagecookie to export.

Only installer/install uses InstallAuth, and it gets setlanguagecookie
from C4::Export.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoTrivial correction to comment.
Joe Atzberger [Tue, 10 Mar 2009 21:40:58 +0000 (16:40 -0500)]
Trivial correction to comment.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdd larger values to numerical limit.
Joe Atzberger [Mon, 9 Mar 2009 18:58:28 +0000 (13:58 -0500)]
Add larger values to numerical limit.

Client requested additional values in dropdown for numerical limit.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFixing catalogue_out errors.
Joe Atzberger [Tue, 10 Mar 2009 21:41:01 +0000 (16:41 -0500)]
Fixing catalogue_out errors.

This script ran against biblioitems.itemtype instead of items.itype.
With that corrected, biblioitems is not used by the query.

Report also failed to check whether the item was currently checked out
(i.e., in the issues table) before declaring it an inactive,
uncirculating item!

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBranchoverdues circ report reworking.
Joe Atzberger [Tue, 27 Jan 2009 00:24:10 +0000 (18:24 -0600)]
Branchoverdues circ report reworking.

branchoverdues.pl
~ Removed unused variables.
~ Use elsif where applicable.
~ Added many FIXMEs.
~ Added help description.
~ Changed link to more accurate description.
~ REFACTORED branchoverdues-specific function in C4 for obvious consolidation.

This report is still of questionable value, since it's dataset has such strange
hardcoded limitations.  It is not clear that "FU" type fines and notifys=0 are
reliable or useful indicators to query on, in hardcoded form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2854) add the possibility to make a fuzzy search on the barcode
Nahuel Angelinetti [Tue, 9 Dec 2008 16:28:41 +0000 (17:28 +0100)]
(bug #2854) add the possibility to make a fuzzy search on the barcode

This patch add a field that permit to make a "like" and "not like" filter on barcode in the catalog report.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoRemove outmoded (and possibly dangerous) cronjob.
Joe Atzberger [Fri, 6 Mar 2009 20:19:56 +0000 (14:19 -0600)]
Remove outmoded (and possibly dangerous) cronjob.

This script is superceded by rebuild_zebra and the sync_items scripts.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2863) add the borrowers branchcodes in suggestion list
Nahuel ANGELINETTI [Fri, 12 Dec 2008 16:47:25 +0000 (17:47 +0100)]
(bug #2863) add the borrowers branchcodes in suggestion list

Not a big patch, just add the borrower branchcode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agomerge_authority : Bug fixing
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:19 +0000 (14:58 +0100)]
merge_authority : Bug fixing

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofix permissions error
Galen Charlton [Fri, 6 Mar 2009 19:17:04 +0000 (13:17 -0600)]
fix permissions error

13 years agofix the sql request to work in all mysqls
Nahuel Angelinetti [Thu, 4 Dec 2008 15:45:30 +0000 (16:45 +0100)]
fix the sql request to work in all mysqls

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoLibraries (branches) should be sorted by branchname.
Joe Atzberger [Tue, 30 Dec 2008 19:50:15 +0000 (13:50 -0600)]
Libraries (branches) should be sorted by branchname.

The display sorted by code, resulting in nonsensical order
for the users, who don't know or see the codes.  Note,
this data should come from GetBranchesLoop, when that
function is availabled (from a separate patch).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAllow all argument forms to GetBranchesLoops.
Joe Atzberger [Tue, 30 Dec 2008 19:42:10 +0000 (13:42 -0600)]
Allow all argument forms to GetBranchesLoops.

Allow arguments to be specified in the negative (i.e. 0).
Allow function to be called with no arguments.

This supercedes the patch titled:
Allow GetBranchesLoop to intuit IndependantBranches if not specified in argument.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAllow GetBranchesLoop to intuit IndependantBranches if not specified in argument.
Joe Atzberger [Thu, 18 Dec 2008 03:35:21 +0000 (21:35 -0600)]
Allow GetBranchesLoop to intuit IndependantBranches if not specified in argument.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdd GetBranchLoop since so many pages use exactly the same code.
Joe Atzberger [Thu, 30 Oct 2008 05:07:40 +0000 (00:07 -0500)]
Add GetBranchLoop since so many pages use exactly the same code.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agocatalogue_out report cleanup.
Joe Atzberger [Thu, 18 Dec 2008 03:36:05 +0000 (21:36 -0600)]
catalogue_out report cleanup.

Warnings enabled, comparison adjusted to accomodate undef.
Hardcoded CGI::scrolling_list removed.
Sort order on item types corrected.  Unused dependencies commented out.
GetBranchesLoop used instead of copy/paste code.

NOTE: CSV output is not fixed by this patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdd mc-loc definition for ccl.properties.
Ryan Higgins [Thu, 8 Jan 2009 18:03:42 +0000 (13:03 -0500)]
Add mc-loc definition for ccl.properties.

Advances search limit by shelving location doesn't work due to
missing ccl definition in default installation.  Once updated,
the zebradb will need to be reindexed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2811)[3.2] fix opac-renew.pl part
Nahuel ANGELINETTI [Wed, 7 Jan 2009 13:33:23 +0000 (14:33 +0100)]
(bug #2811)[3.2] fix opac-renew.pl part

This patch only fix a "security" failure that permit a user to renew his loan using directly the opac-renew.pl url.
Now, we check that opacrenewalallowed is set to on to permit the renewal in opac.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAddReserve had bogus prepare statement.
Joe Atzberger [Tue, 13 Jan 2009 23:11:06 +0000 (17:11 -0600)]
AddReserve had bogus prepare statement.

This patch was not fully tested because the actual behavior intended
by constraints 'o' and 'e' was apparently never implemented here.
But it had no chance of success as with:
    my $sth = $dbh->prepare("");

This uses the inteneded query, removes unneeded $sth->finish calls and
fixes *some* redeclaration of my $variables in the same scope, as
would be needed to run under warnings pragma.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBasic cleanup of fixup_cardnumber
Joe Atzberger [Wed, 21 Jan 2009 01:18:23 +0000 (19:18 -0600)]
Basic cleanup of fixup_cardnumber

Avoid warning on syspref "checkdigit" undefined.
Functionality essentially unchanged.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2904: fix display of URLs in UNIMARC
Galen Charlton [Fri, 6 Mar 2009 18:17:39 +0000 (12:17 -0600)]
bug 2904: fix display of URLs in UNIMARC

This based on a patch by Nahuel ANGELINETTI; done to
merge changes with Mason's patch for 2951.  The original
patch description is:

in the previous patch the field used for link "name" was 856$z, but the unimarc doesn't specify this, it say to use the 856$2 fi
This patch make koha to use the 856$2."

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agocorrected patch for bug 2951
Mason James [Thu, 12 Feb 2009 23:15:57 +0000 (12:15 +1300)]
corrected patch for bug 2951

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofollowup to library transfer limits: DB rev => 014
Galen Charlton [Wed, 4 Mar 2009 22:15:33 +0000 (16:15 -0600)]
followup to library transfer limits: DB rev => 014

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofollowup: assign BranchTransferLimitsType to Circulation
Galen Charlton [Wed, 4 Mar 2009 22:15:34 +0000 (16:15 -0600)]
followup: assign BranchTransferLimitsType to Circulation

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoThis patch allows the Branch Transfer Limits feature to limit transfers either by...
koha [Wed, 4 Mar 2009 22:15:32 +0000 (16:15 -0600)]
This patch allows the Branch Transfer Limits feature to limit transfers either by itemtype ( like the original commit ) or collection code ( new feature ).

[Note inserted by RM: this patch is by Kyle Hall]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2703: Changed spent.pl select statment to include joins between tables.
James Winter [Wed, 4 Mar 2009 20:57:01 +0000 (15:57 -0500)]
bug 2703: Changed spent.pl select statment to include joins between tables.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2991: Request hold on multiple items at one time.
Stephen Edwards [Thu, 5 Mar 2009 00:10:03 +0000 (19:10 -0500)]
bug 2991: Request hold on multiple items at one time.

Updated the results, cart, and shelf pages to include a button
or link to initiate a hold request based on checked items.

Updated the request CGI scripts to handle multiple biblio items.

Updated the reserve confirmation page to display multiple items,
with an optional list of copies for each one.

Turned on warnings in opac/opac-reserve.pl and fixed resulting
warnings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoMarkup and style corrections.
Owen Leonard [Thu, 5 Mar 2009 20:37:49 +0000 (14:37 -0600)]
Markup and style corrections.

Corrects case of "onclick" and creates new style for "send" link rather than re-using inapplicable toolbar ID.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2772: bad image location
Nahuel Angelinetti [Mon, 10 Nov 2008 16:16:16 +0000 (17:16 +0100)]
bug 2772: bad image location

This patch make Page.pm to use the getitemtypeinfo function to generate the imageurl, and check (in the template) if an
image is set.
Before this patch, always the "Alt" information was shown, because the url wasn't right.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2978) fix differents bugs in marc editor
Nahuel ANGELINETTI [Mon, 23 Feb 2009 11:12:49 +0000 (12:12 +0100)]
(bug #2978) fix differents bugs in marc editor

This patch fix two bugs:

 * tag duplication
If you try to duplicate an autority tag, the javascript call is kept, and the id is not modified, and fields are not emptied.

 * openAuth() call
The id called on duplicated fields is not the great id.
And the different values sent to auth_finder.pl to pre-fetch datas from firstname, etc... send values from all same tags, and not from the selected tag.
(cherry picked from commit 40115eb110c94935e1b3fe6ba3a3c9ea35a473a4)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2933) change popup names containing space chars
Nahuel ANGELINETTI [Thu, 29 Jan 2009 14:29:19 +0000 (15:29 +0100)]
(bug #2933) change popup names containing space chars

This patch change all call to open.window that have a window identifier which contains space chars.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoUsing openAuth function for authorities Searching
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:11 +0000 (14:58 +0100)]
Using openAuth function for authorities Searching

Adding two js functions :
getSubfieldcode(tagsubfieldid)  returns the subfieldcode from tagsubfieldid
(tag_XXX_subfield_Y_WWWW_TTTT returns Y)
getTagInputnameFilter(tagsubfieldid)
(tag_XXX_subfield_Y_WWWW_TTTT returns tag_XXX_subfield_._WWWW)

I think those two functions are much useful when cataloguing.

openAuth now takes all the information for Heading search of authorities.

TODO A javascript DOM Navigation would be better.
This js works, but is surely slower than DOM would be.
Still, it seems that our DOM tree is quite hard to decode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>