koha.git
13 years agonew author test for syntax errors in HTML templates
Galen Charlton [Wed, 29 Apr 2009 21:51:11 +0000 (16:51 -0500)]
new author test for syntax errors in HTML templates

Added a new author test to look for syntax errors
in the HTML templates.  Run by doing

prove xt/author/valid-templates.t

from the root of a Koha source tree.

This test will help catch the following errors:

* unbalanced TMPL_IF, TMPL_UNLESS, and TMPL_LOOP contructs, e.g.,
  cases where a TMPL_IF is not closed by a /TMPL_IF.
* references to nonexistant include files
* syntax errors within a HTML::Template::Pro tag

This test currently ignores errors related to TMPL_IF EXPR, which
is currently deprecated for use in Koha -- this may be made
stricter in the future.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofix XHTML validation error introduced in previous patch
Galen Charlton [Fri, 1 May 2009 21:17:26 +0000 (16:17 -0500)]
fix XHTML validation error introduced in previous patch

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoEnhancements/fixes for OPAC advanced search screen
Jane Wagner [Wed, 29 Apr 2009 18:14:56 +0000 (14:14 -0400)]
Enhancements/fixes for OPAC advanced search screen

Fixed opac-search.pl for correct test of expanded options and
to pass variable for MARC21 to advanced search screen.

Added Publication Date Range search to advanced search screen

Removed obsolete item type code section from advanced search screen
(wasn't displaying anyway because expanded options wasn't working,
superceded by site-specific item type searches).

Changed wording on Additional Content Types pulldown to make clear
it's limited to Books/Printed Materials -- this is basing off the
008 positions 24-27, but the options (and those positions) are only
valid for Book material types. Other material types have different
008 settings in those positions.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoRemove unused $toggle code
Joe Atzberger [Thu, 30 Apr 2009 17:15:12 +0000 (12:15 -0500)]
Remove unused $toggle code

Some trivial other cleanups also.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdding the creation of sql library on the wiki
Chris Cormack [Thu, 30 Apr 2009 21:41:08 +0000 (09:41 +1200)]
Adding the creation of sql library on the wiki

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoSyndetics: add support for AVSUMMARY and AVPROFILE
Galen Charlton [Thu, 30 Apr 2009 20:09:42 +0000 (15:09 -0500)]
Syndetics: add support for AVSUMMARY and AVPROFILE

Added support for the Syndetics AV summary and AV profile
data elements.  The AV summary is displayed in the description
tab if present, while the AV profile is displayed as
a link off of the OPAC bib details page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoSyndetics: start switch to XML::LibXML to parse results
Galen Charlton [Thu, 30 Apr 2009 19:10:34 +0000 (14:10 -0500)]
Syndetics: start switch to XML::LibXML to parse results

XML::Simple doesn't handle mixed content, which is a
problem because reviews provided by Syndetics sometimes
contain HTML tags.  Furthermore, it's often easier to write
XPath to extract bits of an XML document than trying
to play with XML::Simple's options.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoSyndetics: add fiction notes/title profile link
Galen Charlton [Thu, 30 Apr 2009 19:29:54 +0000 (14:29 -0500)]
Syndetics: add fiction notes/title profile link

If a Syndetics title profile (AKA fiction notes page) exists
and is avaailable to the user, add a link to to in the OPAC
detail page.

TODO: add a system preference

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoCorrect comparison which was using an octal number
Colin Campbell [Fri, 1 May 2009 08:32:27 +0000 (09:32 +0100)]
Correct comparison which was using an octal number

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdding Liz Rea to the history.txt
Chris Cormack [Thu, 30 Apr 2009 03:33:13 +0000 (15:33 +1200)]
Adding Liz Rea to the history.txt

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoSyndetics: handle variations in reviews XML output
Galen Charlton [Thu, 30 Apr 2009 17:25:27 +0000 (12:25 -0500)]
Syndetics: handle variations in reviews XML output

For some reason different Syndetics users get
slightly different results when requesting
an XML-formatted review, so it's necessary to
handle both observed variations:

Here's one variation:

...
<Notes>
    <Fld520 I1="BLANK" I2="BLANK">
    <a>This is a review

And another:
...
<Notes>
    <Fld520 I1="BLANK" I2="BLANK">
        This is a review

This patch fixes a bug where some users the
source of a review but not the review itself.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofix to C4::Koha::_isbn_cleanup
Galen Charlton [Thu, 30 Apr 2009 18:06:24 +0000 (13:06 -0500)]
fix to C4::Koha::_isbn_cleanup

Both valid ISBN-10s and -13s can use 'X' as a checkdigit
value.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoVerbiage clarification in intranet advsearch.tmpl
root [Thu, 30 Apr 2009 16:42:23 +0000 (11:42 -0500)]
Verbiage clarification in intranet advsearch.tmpl

Changed verbiage from Limit type to: match any of the following to Limit to any of the following:

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix for Bug 2767, cart and lists buttons missing on opac-search.pl
Owen Leonard [Thu, 30 Apr 2009 16:40:14 +0000 (11:40 -0500)]
Fix for Bug 2767, cart and lists buttons missing on opac-search.pl

This fix adds alternate markup to be included on the advanced search page in order to mimic the placement of the cart and lists buttons on other opac pages.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoLibraryspeak extinction in OPAC: Verbiage Change opac-advsearch.tmpl
Liz Rea [Thu, 30 Apr 2009 16:30:26 +0000 (11:30 -0500)]
Libraryspeak extinction in OPAC: Verbiage Change opac-advsearch.tmpl

Changed verbiage from Limit type to: match any of the following to Limit to any of the following:

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 3177 - haspermission offers bogus option
Joe Atzberger [Thu, 30 Apr 2009 15:04:38 +0000 (10:04 -0500)]
Bug 3177 - haspermission offers bogus option

$intflags was never used or returned if hashref instead of userid was passed.
Also cleaned up needless passing of $dbh.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 3179: Typo in C4::Circulation function call causes fatal error
Ryan Higgins [Thu, 30 Apr 2009 21:35:10 +0000 (14:35 -0700)]
Bug 3179: Typo in C4::Circulation function call causes fatal error

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoWhoops I typo'd Garry's name - fixed
Chris Cormack [Wed, 29 Apr 2009 21:52:13 +0000 (09:52 +1200)]
Whoops I typo'd Garry's name - fixed

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoUsability change: widened the search type dropdown from 9em to 10em so that it doesn...
root [Wed, 29 Apr 2009 18:14:45 +0000 (13:14 -0500)]
Usability change: widened the search type dropdown from 9em to 10em so that it doesn't look cramped.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoUpdating history docs for new developer
Chris Cormack [Wed, 29 Apr 2009 20:24:19 +0000 (08:24 +1200)]
Updating history docs for new developer

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoUsability change: Added example of 5.00 to fines/manual credit and fines/manual invoi...
Liz Rea [Wed, 29 Apr 2009 16:22:53 +0000 (11:22 -0500)]
Usability change: Added example of 5.00 to fines/manual credit and fines/manual invoice to remind folks that they do not have to add the dollar sign (or other international money symbol) before the amount.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoOPAC Advanced Search - have user's branch selected by default
Michael Hafen [Tue, 28 Apr 2009 20:16:31 +0000 (14:16 -0600)]
OPAC Advanced Search - have user's branch selected by default

If SearchMyLibraryFirst is on, and the user is logged in, then have
their branch selected in the Location And Availability drop-down.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoCheckout page - Check Out's table sortable on barcode
Michael Hafen [Tue, 28 Apr 2009 20:24:17 +0000 (14:24 -0600)]
Checkout page - Check Out's table sortable on barcode

Add the barcode column of the Check Out's table to the tablesorter
setup.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agominPasswordLength not returning user back to systempreferences.pl?tab=Patrons. Incorr...
Garry Collum [Wed, 29 Apr 2009 02:55:21 +0000 (22:55 -0400)]
minPasswordLength not returning user back to systempreferences.pl?tab=Patrons. Incorrect reference MinPasswordLength fixed. Could not find bug report.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 3126: remove comma for IE7
Joe Atzberger [Tue, 28 Apr 2009 17:08:31 +0000 (12:08 -0500)]
Bug 3126: remove comma for IE7

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 3130 and general cleanup
Joe Atzberger [Tue, 28 Apr 2009 23:23:36 +0000 (18:23 -0500)]
Bug 3130 and general cleanup

Javascript error in FF and IE when loading page and no data matches criteria.
This was because it was passing more holds than necessary to the template and
letting a template conditional inside the loop control whether to display or not.
That doesn't make sense, and it forces the table to be displayed even when all
rows FAIL the conditional.  jquery.tablesorter was confused trying to be added
on top of an empty table with nothing to sort.

There were several other errors addressed by this patch:
 ~ 13 unused variables deleted.
 ~ regexps run on user-supplied $var before checking $var defined
 ~ decimal ratio prohibited and silently replaced with "3"

I also added the hold ratio to a column display, with a jquery tweak to put it in
the ratio input box on click.  Hidden .sql div now contains the actual query run,
like the other wizard reports.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2505 adding warnings to opac-authorities-home and fixing warnings generated
Chris Cormack [Tue, 28 Apr 2009 23:32:27 +0000 (11:32 +1200)]
Bug 2505 adding warnings to opac-authorities-home and fixing warnings generated

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBugs 2822, 2551, 3163 fixes to XSLT
Jane Wagner [Tue, 28 Apr 2009 12:01:25 +0000 (08:01 -0400)]
Bugs 2822, 2551, 3163 fixes to XSLT

Resent with additional comments.

Bug 2822 -- for leader6 types of i (nonmusical) or j (musical), the hitlist
uses an icon and label of Sound while the record display page uses
Music.  Modified record display to use Sound.

Bug 2551 -- for leader7 type of i says it's type Serial which is incorrect.
The bug report suggested Integrating Resource" but the latest install's
hitlist page uses Continuing Resource.  Changed the record display page
to also use Continuing Resource.

Bug 3163 -- if you have a 110 or 710 with a subfield a and a subfield b,
there's no space between them (on either hitlist or record display).
The two headings run together in the display.  Modified the utils file
to force a space.

The XSLT files referenced two icons which did not exist (globe.png and
drive_remote.png. Replaced those with icons from the same subject area
(world.png and drive_web.png).  Also, corrected spelling of icon name
from pencile.png to pencil.png.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofix DOS newlines in MARC21slimUtils.xsl
Galen Charlton [Tue, 28 Apr 2009 13:58:05 +0000 (08:58 -0500)]
fix DOS newlines in MARC21slimUtils.xsl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 3156 followup Fix display of LTFL content when not displaying it in tabs.
Chris Catalfo [Tue, 28 Apr 2009 12:36:29 +0000 (12:36 +0000)]
bug 3156 followup Fix display of LTFL content when not displaying it in tabs.

LTFL content needs to appear in div rather than span elements.  This patch simply replaces the LTFL span elements with divs to fix Bug 3156: LTFL content not displaying if LibraryThingForLibrariesTabbedView sys pref is Off.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofix to remove blank newlines from labels
Mason James [Fri, 16 Jan 2009 08:16:27 +0000 (21:16 +1300)]
fix to remove blank newlines from labels

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agodon't try to resolve if WEBSERVER_IP is set and now use WEBSERVER_HOST.
Marc Chantreux [Thu, 8 Jan 2009 00:52:44 +0000 (00:52 +0000)]
don't try to resolve if WEBSERVER_IP is set and now use WEBSERVER_HOST.

as it crashed the installer when DNS doesn't respond as expected.

it will now use the WEBSERVER_HOST described in the doc but unused in the script.

TODO:

- lot of koha-httpd.conf generation is useless if you plan to use vhosts strategy
- on some recent linux distributions, $(getent hosts `hostname`) will give us
  127.0.0.1. this is to not mess up the MTA when there is no network. Don't
  you think there would be an error message in this case?
- default domain is localdomain .. this is not a good idea but i haven't a better one.
  can a network guru fix that ?

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2750) Cannot return to another branch if the independantbranch option is set...
Nahuel ANGELINETTI [Tue, 23 Dec 2008 14:14:27 +0000 (15:14 +0100)]
(bug #2750) Cannot return to another branch if the independantbranch option is set as ON

The code was modified to change the holding branch ONLY if the return to the right branch is done. If you set IndependantBranch to on, you must return the document to the HomeBranch.
And verify the return is done before show the message that allow to transfert the document to another branch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2961) change the workflow of the new issue
Nahuel ANGELINETTI [Mon, 27 Apr 2009 15:13:08 +0000 (17:13 +0200)]
(bug #2961) change the workflow of the new issue

This patch change the operations, it add a new expected if no one expected exists, else it create new excepted, and set the others as "late"

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2915 followup - small efficiency improvement
Galen Charlton [Mon, 27 Apr 2009 15:31:03 +0000 (10:31 -0500)]
bug 2915 followup - small efficiency improvement

Following up on a suggestion by Joe Atzberger, save
a database query by not counting the subscriptions
to delete; instead, simply fetch a list of them.

No user-visible change.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2893: tweaks to AllowNotForLoanOverride (DB rev 030)
Galen Charlton [Mon, 27 Apr 2009 19:39:36 +0000 (14:39 -0500)]
bug 2893: tweaks to AllowNotForLoanOverride (DB rev 030)

* moved to DB rev 030
* assigned AllowNotForLoanOverride to circulation syspref category
* added a hint to the circulation operator: when the
  AllowNotForLoanOverride is ON, if the operator attempts
  to check out an item that is normally not for loan due to
  its item type or because the item is explicitly marked as
  not-for-loan, the operator is given the chance to check
  out the item anyway.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2893) Allow loan forcing if a syspref is set
Nahuel ANGELINETTI [Thu, 8 Jan 2009 13:15:31 +0000 (14:15 +0100)]
(bug #2893) Allow loan forcing if a syspref is set

If the syspref 'AllowNotForLoanOverride'(YESNO) is set to YES, the librarian is able to force a loan on an item set as "not for
loan".
If the item is not for loan and the syspref is set to YES, koha will ask to the librarian if he really want to check-out it, else
do nothing.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago_set_defaults_for_add easier to read
Marc Chantreux [Fri, 16 Jan 2009 09:23:27 +0000 (09:23 +0000)]
_set_defaults_for_add easier to read

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2920 Display AmazonReviews syspref in the enhanced content category
Frédéric Demians [Mon, 27 Apr 2009 14:17:36 +0000 (16:17 +0200)]
Bug 2920 Display AmazonReviews syspref in the enhanced content category

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2559: fix search limit on Spanish language (DB rev 029)
Galen Charlton [Mon, 27 Apr 2009 12:29:05 +0000 (07:29 -0500)]
bug 2559: fix search limit on Spanish language (DB rev 029)

Fixes bug where searching with the language limit set
to Spanish would instead retrieve Russian records.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFollowup (1 of 2) to: Correct iso639_2_code for Spanish is "spa" not "rus".
Joe Atzberger [Thu, 23 Oct 2008 20:56:22 +0000 (15:56 -0500)]
Followup (1 of 2) to: Correct iso639_2_code for Spanish is "spa" not "rus".

updatedatabase change deferred for now.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoCorrect iso639_2_code for Spanish is "spa" not "rus".
Joe Atzberger [Mon, 13 Oct 2008 16:46:14 +0000 (11:46 -0500)]
Correct iso639_2_code for Spanish is "spa" not "rus".

The result of this apparent copy/paste error is that adv. search
limits by Language=Spanish would return results for Russian!

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 3114 - IE7 spacing needs width: 100% to avoid line collapse.
Joe Atzberger [Fri, 24 Apr 2009 22:31:53 +0000 (17:31 -0500)]
Bug 3114 - IE7 spacing needs width: 100% to avoid line collapse.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 3161: don't display blank language chooser
Galen Charlton [Sun, 26 Apr 2009 16:45:24 +0000 (11:45 -0500)]
bug 3161: don't display blank language chooser

If more than one translation is installed but only one is active, a blank div
is displayed at the bottom of all pages in the intranet (and in the OPAC if the
opacchangelanguages system preference is ON), taking a bit of vertical real
estate needlessly.

Changed so that <div> for the language chooser is output
only if there is more than one enabled language.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoWhoops missed Brendan's commit, fixed the history now
Chris Cormack [Mon, 27 Apr 2009 00:17:21 +0000 (12:17 +1200)]
Whoops missed Brendan's commit, fixed the history now

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2505 fixing warnings, I think we have them all for opac-search.pl now
Chris Cormack [Mon, 27 Apr 2009 04:08:21 +0000 (16:08 +1200)]
bug 2505 fixing warnings, I think we have them all for opac-search.pl now

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2920 DB Rev 028 AmazonReviews syspref
Frédéric Demians [Mon, 27 Apr 2009 05:49:58 +0000 (07:49 +0200)]
Bug 2920 DB Rev 028 AmazonReviews syspref

Add AmazonReviews syspref.

DOCUMENTATION:

  AmazonReviews is OPACAmazonReviews counterpart,
  except that in staff interface Editorial Review
  is displayed alone, without reader reviews.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2920 Fixes Amazon content use in pro interface
Frédéric Demians [Mon, 27 Apr 2009 05:49:57 +0000 (07:49 +0200)]
Bug 2920 Fixes Amazon content use in pro interface

This patch fixes Amazon content use in pro interface :

* Control Amazon Editorial Review by a new syspref:
  AmazonReviews.
* /catalogue/detail.tmpl doesn't display Amazon reader reviews.
  It displays only Editorial review in Description tab.
  This patch disable request for AWS reader reviews.
* Use Amazon TLD for linking book cover to local
  Amazon Search Inside.
* Minor clean up on C4::External::Amazon.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBugfix #2920 Avoid doing unecessary calls to Amazon Web Services
Frédéric Demians [Sat, 25 Apr 2009 07:24:54 +0000 (09:24 +0200)]
Bugfix #2920 Avoid doing unecessary calls to Amazon Web Services

This patch modifies how AWS is called. AWS is now called
depending on syspref. It works completly for OPAC; it
has to be refined for intranet.

For OPAC:

  * If OPACAmazonReviews is set, AWS EditorialReview and
    Reviews (users) are grabed.
  * If OPACAmazonSimilarItems is set, AWS Similarities info
    are grabed.
  * If nothing is asked, AWS is not called anymore,
    sparing server bandwidth.

For intranet:

  It works as it used to work. AWS is called if AmazonEnabled
  is set whatever how other syspref are set.

  TODO:

    * Add a AmazonReviews syspref
    * Request Amazon content depending on AmazonSimilarities
      and AmazonReviews syspref

DOCUMENTATION:

  It should be explained that Amazon services related syspref
  have two levels:

  * AmazonEnable / OPACAmazonEnable
  * Other: OPACAmazonReviews (new), OPACAmazonSimilarProduct,
    OPACAmazonCover

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2505: fix more warnings in opac-search.pl
Galen Charlton [Sun, 26 Apr 2009 15:23:55 +0000 (10:23 -0500)]
bug 2505: fix more warnings in opac-search.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2505 Adding use warnings, and fixing the warnings generated
Chris Cormack [Sat, 25 Apr 2009 04:49:48 +0000 (16:49 +1200)]
Bug 2505 Adding use warnings, and fixing the warnings generated

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 3148 : Database revision to make zebraqueue.biblio_auth_number as big as auth_hea...
Ryan Higgins [Sat, 25 Apr 2009 17:29:01 +0000 (13:29 -0400)]
Bug 3148 : Database revision to make zebraqueue.biblio_auth_number as big as auth_header.authid.

If you've never truncated your zebraqueue table, you might want to
update your index and truncate it before applying this patch and running updatedatabase.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofix warning in C4::AuthoritiesMarc::merge()
Galen Charlton [Sun, 26 Apr 2009 14:48:42 +0000 (09:48 -0500)]
fix warning in C4::AuthoritiesMarc::merge()

"my" variable @X masks earlier declaration in same scope at C4/AuthoritiesMarc.pm line 1200

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoimproved POD for C4::Serials::HasSubscriptionExpired()
Galen Charlton [Sun, 26 Apr 2009 14:48:41 +0000 (09:48 -0500)]
improved POD for C4::Serials::HasSubscriptionExpired()

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix :Fatal Errors occurs when date is not a regular date
Henri-Damien LAURENT [Fri, 6 Mar 2009 11:03:21 +0000 (12:03 +0100)]
Fix :Fatal Errors occurs when date is not a regular date

When the start date or the "current date" is not a regular date
the transformation and checkdate fails because there is no
Year/Month/Date
This patch makes it fail more 'silenty' for the users and raises an
error that could be coped with.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2937) use check_date in C4::Serials::hassubscriptionexpired
Nahuel ANGELINETTI [Fri, 30 Jan 2009 15:48:02 +0000 (16:48 +0100)]
(bug #2937) use check_date in C4::Serials::hassubscriptionexpired

This patch change the date check in hassubscriptionexpired to use Date_Calc::check_date

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoRemoving map calls in void context
Henri-Damien LAURENT [Sat, 22 Nov 2008 21:23:28 +0000 (22:23 +0100)]
Removing map calls in void context

Thanks Joe.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoproblem saving authority with ? and other special characters [resend]
Henri-Damien LAURENT [Wed, 19 Nov 2008 14:38:37 +0000 (15:38 +0100)]
problem saving authority with ? and other special characters [resend]

Filtering those signs in order not to have them interpreted.
Removing some warns

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug Fix : 2494
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:24 +0000 (14:58 +0100)]
Bug Fix : 2494

Adds some rewriting
bug fix for merging
AddAuthority had some problem with updating existing data.
ModAuthority adds a new Syspref called MergeAuthoritiesOnUpdate which is used to launch or disable biblios update when updating an authority

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoMerging authorities caused an encoding problem in biblios
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:23 +0000 (14:58 +0100)]
Merging authorities caused an encoding problem in biblios

MARC::File::USMARC::decode is not aware of encoding as MARC::File::XML is
So it caused a problem when decoding information and updating biblios.
Now uses MARC::File::XML
Encoding is OK

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug Fix : Adding Some error proofs to HaveSubscriptionExpired
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:18 +0000 (14:58 +0100)]
Bug Fix : Adding Some error proofs to HaveSubscriptionExpired

Date::Calc::CalcDays was throwing error 500 when one serial had an undefined date.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdd items.itemnotes to the Notes/Comments search in Marc21
Michael Hafen [Thu, 20 Nov 2008 18:08:40 +0000 (11:08 -0700)]
Add items.itemnotes to the Notes/Comments search in Marc21

This uncomments the 952$z and assigns it to the Notes index in
marc21

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBUG:3072 small work-around patch to restore authorities searching
Mason James [Thu, 2 Apr 2009 05:01:07 +0000 (18:01 +1300)]
BUG:3072 small work-around patch to restore authorities searching

this is a work-around fix, until a future patch arrives to define the missing 'Heading-Main' zebra-index.

for 3.0.x

[RM note: also included in HEAD so that I can include the UNIMARC(A)
 updates by HDL]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoImproving UNIMARC(A) compliance
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:34 +0000 (14:58 +0100)]
Improving UNIMARC(A) compliance

Adding some fields to index.
Adding also some indexes in order to be able to query specific fields.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug Fixing : searching on mainmainentry was disabled
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:13 +0000 (14:58 +0100)]
Bug Fixing : searching on mainmainentry was disabled

Adding Heading-Main as new index code in order to search only on Heading-main when $a selected.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoMinor Feature : username when cataloguing
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:14 +0000 (14:58 +0100)]
Minor Feature : username when cataloguing

biblios can now be added librarian name automatically when cataloguing.
add "user" in the Default value of the biblio

[RM doc note: in other words, if in the MARC framework you set
 the default value of a subfield to 'user', the username of the
 cataloger will be entered into that subfield whenever you create
 or modify that bib in the Koha bib editor.]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2776 : emailPurchaseSuggestions syspref deprecated
Ryan Higgins [Wed, 12 Nov 2008 03:31:34 +0000 (22:31 -0500)]
Bug 2776 : emailPurchaseSuggestions syspref deprecated

This patch removes the system preference from new installations.
No db revision is supplied to remove the system pref from existing installations.
It is recommended for administrators to use the scripts provided in the misc/ directory
to ensure that their system preferences are in sync with those used in code.
Admins should remove this preference from existing installations manually.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdding some Error proof on GetAuthority
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:20 +0000 (14:58 +0100)]
Adding some Error proof on GetAuthority

return undef if there is a problem

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoRestoring startsby search on authorities.
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:12 +0000 (14:58 +0100)]
Restoring startsby search on authorities.

[RM note: fixes bug 2792]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBUG-3160: fixes 'itemlost' check on item return.
Mason James [Sat, 25 Apr 2009 01:18:58 +0000 (13:18 +1200)]
BUG-3160: fixes 'itemlost' check on item return.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofix XHTML error - duplicate tabindex
Galen Charlton [Sat, 25 Apr 2009 01:35:52 +0000 (20:35 -0500)]
fix XHTML error - duplicate tabindex

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofix default authority search in bib editor
Galen Charlton [Sat, 25 Apr 2009 01:35:53 +0000 (20:35 -0500)]
fix default authority search in bib editor

When clicking on the '...' of an headings field
in the bib editor, the authority search that
popped up did not take the default search
string from the bib field.  Fixed by making
sure that openAuth is always used to do the
popup link.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 3127 - Stub function prevents undefined reference
Joe Atzberger [Fri, 24 Apr 2009 20:09:55 +0000 (15:09 -0500)]
Bug 3127 - Stub function prevents undefined reference

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoNew developer for history.txt
Chris Cormack [Fri, 24 Apr 2009 20:11:02 +0000 (08:11 +1200)]
New developer for history.txt

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 3159: allow editing child patron that has no valid guarantor
Galen Charlton [Sat, 25 Apr 2009 00:46:36 +0000 (19:46 -0500)]
bug 3159: allow editing child patron that has no valid guarantor

If a patron with a child patron category is not linked
to a guarantor (or a valid one), it was not possible to edit
the child patron's record.  When attempt, no changes were saved
and the following error is recorded in the Apache error log:

memberentry.pl: DBD::mysql::st execute failed: Cannot add or
update a child row: a foreign key constraint
fails (`gmc_koha/borrowers`, CONSTRAINT `borrowers_ibfk_2`
FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) ...

This patch fixes this bug, allowing a child patron record to be
edited even if it has no guarantor.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agochanged OAI-PMH implementation
Galen Charlton [Fri, 24 Apr 2009 16:25:05 +0000 (11:25 -0500)]
changed OAI-PMH implementation

Replaced older OAI-PMH server implementation
with new one by Frédéric Demians.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoMake js prompts translatable using _("...") and comment out unused vars.
Joe Atzberger [Fri, 24 Apr 2009 17:30:19 +0000 (12:30 -0500)]
Make js prompts translatable using _("...") and comment out unused vars.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoRevisions to auto-generated authorities patch
Brian Harrington [Fri, 24 Apr 2009 18:39:54 +0000 (14:39 -0400)]
Revisions to auto-generated authorities patch

It turns out that the "blank" record created by MARC::Record->new()
has a leader, so now I explicitly create one in addbiblio.pl.  I
also realized I can't count. :-)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoModified log reporting to allow multiple modules to be selected.
David Goldfein [Fri, 24 Apr 2009 18:21:24 +0000 (13:21 -0500)]
Modified log reporting to allow multiple modules to be selected.

Reworked ViewLog.pl and the template.  Eliminated html errors, cleaned up
the template, change mime type to text/csv and other minor changes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoNew feature - database update - Number of Returned Items to Show
Michael Hafen [Fri, 24 Apr 2009 17:53:44 +0000 (11:53 -0600)]
New feature - database update - Number of Returned Items to Show

This is the database update to add the system preference for
numReturnedItemsToShow

[RM note: DB rev 026]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoNew feature Number of Returned Items to Show
Michael Hafen [Fri, 24 Apr 2009 17:53:43 +0000 (11:53 -0600)]
New feature Number of Returned Items to Show

This adds a system preference controlled feature.  This controls how
many returned items are shown on the check-in page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoDB rev 025: ceilingDueDate syspref
Galen Charlton [Fri, 24 Apr 2009 18:06:45 +0000 (13:06 -0500)]
DB rev 025: ceilingDueDate syspref

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoNew feature ceiling Due Date - database update
Michael Hafen [Wed, 25 Feb 2009 22:08:26 +0000 (15:08 -0700)]
New feature ceiling Due Date - database update

This updates the database to add the syspref ceilingDueDate.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoNew feature ceiling Due Date.
Michael Hafen [Thu, 5 Mar 2009 21:21:56 +0000 (14:21 -0700)]
New feature ceiling Due Date.

This adds a feature and system preference: ceilingDueDate.  If this is
set to a valid ( according to dateformat syspref ) date, then calculated
due dates will be less than this date.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoCleanup and tighten Letters module.
Joe Atzberger [Fri, 19 Sep 2008 00:02:46 +0000 (19:02 -0500)]
Cleanup and tighten Letters module.

Subroutine arguments enforced w/ with more checks, explicit return undef where warranted.
Placeholders used in SQL where applicable.
One logical error corrected :
- next MESSAGE if ( lc( $message->{'message_transport_type'} eq 'rss' ) );
+ next MESSAGE if ( lc($message->{'message_transport_type'}) eq 'rss' );

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBasic reformat of section in Search.pm
Joe Atzberger [Fri, 9 Jan 2009 21:42:27 +0000 (15:42 -0600)]
Basic reformat of section in Search.pm

In for loops, replace all-inclusive conditional blocks like:
    for (@foo) {
        if (test) {
            block;
        }
    }

with conditional use of "next":
    for (@foo) {
        test or next;
        block;
    }

This reduces the number of unnecessarily nested blocks, and the
overall number of lines.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agokohabug 2934 - Wrong datatype causes artificial limit to label batch id's
Chris Nighswonger [Thu, 29 Jan 2009 10:07:09 +0000 (05:07 -0500)]
kohabug 2934 - Wrong datatype causes artificial limit to label batch id's

labels.batch_id should be int as the value is always an integer. This corrects
the problem.

[RM note: ported patch to HEAD.  DB rev 024]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoUse biblioitems.itemtype as a default for items.itype
Michael Hafen [Fri, 12 Sep 2008 19:16:58 +0000 (13:16 -0600)]
Use biblioitems.itemtype as a default for items.itype

This correct the html select default in additem.pl, and enforces use of
biblioitems.itemtype as the default in Items::AddItem.  The code in
Items is to catch items added through MARC record staging.

Thanks to Joe Atzberger for suggestion.

[RM note: this patch means that an item's item-level item type,
 once that item is added or updated via additem.pl,
 now cannot be blank or NULL unless the biblio-level item type
 is blank.]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2505 followup: restored correct item type image display
Galen Charlton [Fri, 24 Apr 2009 14:57:24 +0000 (09:57 -0500)]
bug 2505 followup: restored correct item type image display

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2505: adding warnings to opac-detail.pl
Andrew Moore [Wed, 17 Dec 2008 22:32:25 +0000 (16:32 -0600)]
Bug 2505: adding warnings to opac-detail.pl

Before starting to edit opac/opac-detail.pl, I added 'use warnings' and
eliminated all of the warnings that I could get it to produce. I also
extracted two lines that prepared an amazon ISBN into a function. They
were causing a few warnings and might as well be extracted. They should
probably be moved to a module somewhere since these two lines are copied
all over our code.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoModify GoogleJacket display
Frederic Demians [Wed, 21 Jan 2009 12:28:34 +0000 (13:28 +0100)]
Modify GoogleJacket display

On detail page, when GoogleJacket is enabled,
book cover is retrieved from Google. This image
is a link to GoogleBook services: full text,
book localisation in a bookstore, etc.

This patch removes the link on book cover and
add underneath a text 'Source Google' with a
link to GoogleBook services.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBlock warning on detail.pl.
Joe Atzberger [Wed, 21 Jan 2009 01:18:20 +0000 (19:18 -0600)]
Block warning on detail.pl.

If Amazon doesn't have an avg. rating number defined, then we cannot multiply it
by 20 without the following warning:

    detail.pl: Use of uninitialized value in multiplication (*)
    at /home/user/kohaclone/catalogue/detail.pl line 228.

So the important part of this patch is || 0 on the $average_rating assignment.

[RM note: applying for whitespace cleanup]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agorefactor: removing a few unnecessary loops and moving HTML out of script into template
Andrew Moore [Wed, 17 Dec 2008 22:30:46 +0000 (16:30 -0600)]
refactor: removing a few unnecessary loops and moving HTML out of script into template

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2765: updatedatabase to increase width of ISBN columns
Galen Charlton [Fri, 24 Apr 2009 13:41:24 +0000 (08:41 -0500)]
bug 2765: updatedatabase to increase width of ISBN columns

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug fix 2765
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:26 +0000 (14:58 +0100)]
bug fix 2765

Changing isbn data from 14 to 30 in order to manage friendlier,
isbn with - inside, and multiple isbns.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoCleanup, pod fix and FIXME's added.
Joe Atzberger [Fri, 23 Jan 2009 17:57:58 +0000 (11:57 -0600)]
Cleanup, pod fix and FIXME's added.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoDB rev 022: set DBrev for bug 2945 fix
Galen Charlton [Fri, 24 Apr 2009 13:16:30 +0000 (08:16 -0500)]
DB rev 022: set DBrev for bug 2945 fix

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2945: increase size of labels_conf.formatstring (DB update)
Joe Atzberger [Wed, 4 Feb 2009 19:55:03 +0000 (13:55 -0600)]
Bug 2945: increase size of labels_conf.formatstring (DB update)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 3152 OPAC reading history column headers don't line up with text
Jane Wagner [Fri, 24 Apr 2009 12:33:50 +0000 (08:33 -0400)]
Bug 3152 OPAC reading history column headers don't line up with text

Fixed template files to make column headers and text line up; moved
the <td></td> for cover art outside the various content provider IF
statements.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 3128 - followup and correction
Joe Atzberger [Thu, 23 Apr 2009 22:23:24 +0000 (17:23 -0500)]
Bug 3128 - followup and correction

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>