koha.git
5 years ago Bug 15332: Sent DateTime object to DBIx::Class, not formatted dates
Jonathan Druart [Fri, 18 Dec 2015 15:01:15 +0000 (15:01 +0000)]
 Bug 15332: Sent DateTime object to DBIx::Class, not formatted dates

If formatted dates are sent to DBIx::Class on update/insert, the date
will be set as 0000-00-00 (except if the format is yyyy-mm-dd).

Test plan:
Use the batch patron modification tools to update the dateenrolled or
dateexpiry values for at least 1 patron.
Without this patch, the modified value will be updated to 0000-00-00,
with this patch, the correct value will be set.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15217 Remove redundant duplicate var declaration
Colin Campbell [Thu, 19 Nov 2015 14:17:10 +0000 (14:17 +0000)]
 Bug 15217 Remove redundant duplicate var declaration

remove superfluous second declaration of template, borrowernumber and
cookie which are never used

Also removed the variables @results and @results_array which are
declared but not used

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  As suggested by Colin, perl -wc catalogue/search.pl doesn't complain
  anymore after applying the patch. perlcritic confirms the 2 variables
  were unused.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15228: Switch "Items in batch number"
Hector Castro [Mon, 23 Nov 2015 01:52:39 +0000 (19:52 -0600)]
 Bug 15228: Switch "Items in batch number"

Yet another line to switch "Items in batch number" to
"Patrons in batch number"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15228: Patron card batches - Improve translatability
Katrin Fischer [Sun, 22 Nov 2015 01:04:12 +0000 (02:04 +0100)]
 Bug 15228: Patron card batches - Improve translatability

This patch removes the \n\n from a translatable string
as those don't translate correctly to new lines.

It also switches 'item' for 'patron' to avoid confusion
with catalog items.

To test:
1) Trigger changed error message
- Create a new batch with 1 patron entry
- Select patron in list using the checkbox
- Click 'Remove selected patrons' in toolbar
- Verify alert displays correctly

2) Verify that the page no longer uses "items" but
   patrons instead.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15101: Correct typo AllowPkiAuth vs AllowPKIAuth
Jonathan Druart [Wed, 25 Nov 2015 16:45:50 +0000 (16:45 +0000)]
 Bug 15101: Correct typo AllowPkiAuth vs AllowPKIAuth

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15101: Don't display sys pref AllowPkiAuth under CAS heading
Katrin Fischer [Sun, 22 Nov 2015 01:43:36 +0000 (02:43 +0100)]
 Bug 15101: Don't display sys pref AllowPkiAuth under CAS heading

The system preference AllowPkiAuth display under the heading
CAS authentication, but is actually a separate authentication
option. Patch creates a separate heading for it.

To test:
- Go to Administration > System preferences > Tab Administration
- Verify that AllowPkiAuth is now displayed separately

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15229: Same fix for circulation.tt template (normal checkouts)
Jonathan Druart [Wed, 25 Nov 2015 16:14:35 +0000 (16:14 +0000)]
 Bug 15229: Same fix for circulation.tt template (normal checkouts)

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15229: Fix tiny typos in error messages of batch checkout page
Katrin Fischer [Sun, 22 Nov 2015 00:48:31 +0000 (01:48 +0100)]
 Bug 15229: Fix tiny typos in error messages of batch checkout page

Patch fixes some small spelling errors on the batch checkouts
page. Also switches 'reserves' to 'holds'.

To test:
- Read the patch and verify that the changes are correct.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Changes are correct, patch fixes capitalization and typo

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15224: Label creator - fix tiny typo 'itemnunber'
Katrin Fischer [Sun, 22 Nov 2015 01:13:12 +0000 (02:13 +0100)]
 Bug 15224: Label creator - fix tiny typo 'itemnunber'

To test:
- Go to Tools > Label creator > New > Label batch
- Check text displayed in grey next to the text input
  field

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15220: Fix typo in circ rules help
Nicole C. Engard [Thu, 19 Nov 2015 15:31:01 +0000 (09:31 -0600)]
 Bug 15220: Fix typo in circ rules help

MaxFinesystem should be MaxFine system

To test:

* visit circ & fine rules
* click help
* confirm typo fixed

Signed-off-by: Thomas Misilo <misilot@fit.edu>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15238: Better translatability for Installer Step 1
Marc Véron [Sat, 21 Nov 2015 02:25:56 +0000 (03:25 +0100)]
 Bug 15238: Better translatability for Installer Step 1

This Bug streamlines html in installer/step1.tt for better translatibility.

To test:
Reviwe code and verify that changes in text make sense.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
To reproduce in Debian environment, remove a required module with
dpkg -r. Rewording Ok for translation purposes

Bug 15238: (followup) Remove word 'Note:'

'Note: ' removed as requested in comment #3

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Word 'Note' removed

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15237: Quote of the day: Better translatibility for editor and help
Marc Véron [Sat, 21 Nov 2015 02:09:55 +0000 (03:09 +0100)]
 Bug 15237: Quote of the day: Better translatibility for editor and help

This patch moves  html markup out of explanatory text in Quote of the day editor and help
for better translatibility (Home > Tools > Quote Editor).

To test:
- Apply patch
- Go to Home > Tools > Quote Editor and related Help
- Verify that text changes make sense.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Rewording Ok for translation purposes

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Amended patch: Make consistent space after "Note:" (inside the br tag)

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15236: Better translatibility in "Connect biblio.biblionumber to a MARC subfield"
Marc Véron [Sat, 21 Nov 2015 01:32:30 +0000 (02:32 +0100)]
 Bug 15236: Better translatibility in "Connect biblio.biblionumber to a MARC subfield"

This patch moves html markup out of explanatory sentence in koha2marclinks.tt ("Connect
biblio.biblionumber to a MARC subfield") for better translatability.

To test:

- Apply patch
- Go to Home > Administration < Koha to MARC mapping
  and edit a tag
- Verify that text change makes sense

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Rewording Ok for translation purposes

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15233: (followup) Remove 2 sentences.
Marc Véron [Wed, 2 Dec 2015 23:10:28 +0000 (00:10 +0100)]
 Bug 15233: (followup) Remove 2 sentences.

This patch removes 2 sentences (see comment #8)

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15233: Cataloging subfield editors: Clean up html and streamline text for better...
Marc Véron [Sat, 21 Nov 2015 01:10:24 +0000 (02:10 +0100)]
 Bug 15233: Cataloging subfield editors: Clean up html and streamline text for better translatability

This patch removes bold markup from explanatory text in auth_subfields_structure.tt
and makes it the same as in marc_subfields_structure.tt for better translatibility.

To test:
- Apply patch
- Verify that string changes make sense and that the explanatory text is the same in both files.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Rewording Ok for translation purposes

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15232: Advanced Cataloging Editor: Fix translation issues
Marc Véron [Sat, 21 Nov 2015 00:31:00 +0000 (01:31 +0100)]
 Bug 15232: Advanced Cataloging Editor: Fix translation issues

This patch makes
koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc to comply with
Coding guidlines to avoid translation issues: "JS3: Avoid strings which
mix text and markup Text mustn't contain HTML tags."

To test:
- Apply patch
- Verify that code changes are correct (html markup moved out of
  function _(...) )
- Bonus test: Enable syspref 'EnableAdvancedCatalogingEditor' and verify
  that it works as before

With type fix from: Hector Castro <hector.hecaxmmx@gmail.com>

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years agoBug 15231: (followup) Remove stray </b> tag
Marc Véron [Wed, 2 Dec 2015 05:33:32 +0000 (06:33 +0100)]
Bug 15231: (followup) Remove stray </b> tag

This patch removes a stray </b> tag (see comment #4) and a superfluous blank.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years agoBug 15231 - Import patrons: Remove string splitting by html tags to avoid weird trans...
Marc Véron [Fri, 20 Nov 2015 21:58:40 +0000 (22:58 +0100)]
Bug 15231 - Import patrons: Remove string splitting by html tags to avoid weird translations

Some of the strings in Home > Tools > Import patrons contain html tags and therefore are
splitted in the translation tool. This makes it nearly impossible to create correct translations
from the partial strings.
Additinally, the notes for Extended patron attributes never displayed (due to a bug).

To test:
- Apply patch
- Enable Syspref 'ExtendedPAtronAttributes'
- Go to Home > Tools > Import patrons and verify, that the Notes at the right of the
  screen make sense

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Split html tags removed, notes at right side it displayed correctly

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15301: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence
Marc Véron [Wed, 2 Dec 2015 14:34:44 +0000 (15:34 +0100)]
 Bug 15301: branchtransfers.tt: Remove ambiguous "To" and fix splitted sentence

The file intranet-tmpl/prog/en/modules/circ/branchtransfers.tt contains two
ambiguous words 'to' and a sentence splitted up by html tags, leading to weird
translations. Example in German: "Sie können keine Exemplare aus itemtype
transferieren BK für: Airfield"

To test:
- Apply patch

- Set up transfer policies for item types and collection codes in
  Home > Administration > Set library checkin and transfer policy
  Make sure that you have rules that deny and others that allow transfers

- Verify that syspref 'UseBranchTransferLimits' is set to 'Enforce'

- Set 'BranchTransferLimitTypes' to 'item type'

- Go to Home > Circulation > Transfers
- Transfer an item that is allowed for item type
  - Verify that the table of transferred items displays information
    about Item type, Collection code and Destination

- Transfer an item that is not allowed for the item type
  - Verify that the information about not allowing the transfer displays
    properly and is meaningfull

- Set 'BranchTransferLimitTypes' to 'collection code'

- Repeat the transfer steps above for allowed / not allowed collection code

(Amended to add ids to table and 8 columns, see comment #2)
(Amended for comment #5)
Followup for comment #8

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15300: Translatability: Replace ambiguous 'From' and 'To' in members-update.tt
Marc Véron [Wed, 2 Dec 2015 11:39:59 +0000 (12:39 +0100)]
 Bug 15300: Translatability: Replace ambiguous 'From' and 'To' in members-update.tt

This patch replaces semantically ambigous words "From" and "To" in
koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt
for better translatability.

To test:
- Apply patch
- Make sure that patrons can request detail changes in OPAC
  (sysprefs opacuserlogin, OPACPatronDetails)
- Log in to OPAC, request a change of personal details
  (cgi-bin/koha/opac-memberentry.pl)
- Log in to staff client
- Click link 'Patrons requesting modifications' or go to
  Home > Patrons > Update patron records
- Verify that table headers make sense

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Rewording Ok for translation purpose

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15366 - Fix breadcrumbs and html page title in guided reports
Marc Véron [Sun, 13 Dec 2015 21:39:53 +0000 (22:39 +0100)]
 Bug 15366 - Fix breadcrumbs and html page title in guided reports

This patch fixes following issues with breadcrumbs and html page title
in Home > Reports > Guided reports wizard:

- Sometimes, breadcrumbs display a stray > at the end

- While creating a report, steps are not displayed in breadcrumbs and
  do not appear in html page title
- html page title is divided by newlines

To test:
- Apply patch
- Go to Home > Reports > Guided reports wizard
- Go to all pages including the steps for creating a new report and
  verify
  - that the breadcrumbs display properly and make sense
  - in html source, the page title makes sense and displays on one line.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as descrived

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15365: Translatability: Fix issue on Administration > Circulation and fine rules
Marc Véron [Sun, 13 Dec 2015 19:34:46 +0000 (20:34 +0100)]
 Bug 15365: Translatability: Fix issue on Administration > Circulation and fine rules

Fix translatability issue on smart-rules.tt to prevent odd translations (Sentences
splitted by tags and newlines).

To test:
- Apply patch
- Go to Administration > Circulation and fine rules
- Verify that the lines "Note: " and "Important: " below "Default holds policy by
  item type" make sense and are not splitted by tags and (in html) by newlines.

(Amended to fix commit message)

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
strong Note and Important displayed Ok for translation purpose

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15363: Translatability: Fix issue with ambiguous 'all' on Administration > Set...
Marc Véron [Sun, 13 Dec 2015 10:58:52 +0000 (11:58 +0100)]
 Bug 15363: Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy

In branch_transfer_limits.tt, set ambiguous word 'all' (separated by tags) into a
translatable context.

To test:
Apply patch
- Go to Home > Administration > Set library checkin and transfer policy
- Verify that the word 'all' is no longer separated by tags
  in "For all collection codes: " rsp. "For all item types: "
  (Switch with syspref 'BranchTransfersLimitsType')

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works well for translation purpose

Bug 15363: (followup) Move tags inside if statements

Followup for comment #3

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years agoBug 15362: Translatability: Fix issue on Administration 'Did you mean?'
Marc Véron [Sun, 13 Dec 2015 09:47:53 +0000 (10:47 +0100)]
Bug 15362: Translatability: Fix issue on Administration 'Did you mean?'

Fix sentence splitting by tags on didyoumean.tt leading to odd translations.

To test:
- Apply patch
- Go to Home > Administration > Did you mean?
- Verify that the information below the title displays properly and makes sense.
- Disable Javascript, reload page
- Verify that the warning about missing Javascript displays properly and makes sense.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as descrived. Removed em tags for translation purpose

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15361: Translatability: Fix issue on Administration Columns settings
Marc Véron [Sun, 13 Dec 2015 09:08:41 +0000 (10:08 +0100)]
 Bug 15361: Translatability: Fix issue on Administration Columns settings

This patch rewords the following sentence that is not correctly translatable due to
splitting b tags:
Changes made below will only apply to item subfields that are mapped to the items table.

To test:
- Apply patch
- Verify that the rewording makes sese and that no sentences are split by tags.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Rewording message displayed Ok for translation purpose

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15346: Translatability: fix sentence splitting issue in memberentrygen.tt
Marc Véron [Wed, 9 Dec 2015 20:31:29 +0000 (21:31 +0100)]
 Bug 15346: Translatability: fix sentence splitting issue in memberentrygen.tt

Fix sentences in memberentrygen.tt that are split by <strong> tags, leading to
wrong capitalization in German (because it can not be decided if a string is part
of a sentence or a standalone sentence).
Example: Es sind Keine Bibliotheken definiert.

To test:
- Apply patch
- To trigger the messages, you have to edit a patron in a system where
  no libraries and no patron categories are defined
- Alternatively, carefully review the changes in
  koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Sentences fixed for translation purposes

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15345: Translatability: fix issue in facets (Availability')
Marc Véron [Wed, 9 Dec 2015 17:36:21 +0000 (18:36 +0100)]
 Bug 15345: Translatability: fix issue in facets (Availability')

This patch fixes an issue with a splitted sentence in facets (Avalability)
that leads to weird translations e.g.:
German: 'Zeige nur Verfügbar Exemplare'
French: 'Montrer seulement disponible exemplaires'

Additionally, the link "Show all items" gets it's own li tags to display
nicely like the other links in the facets column and it removes superfluous
dots.

To test in OPAC and Staff client:
- Apply patch
- Do a search that results in more than one available items
- In column "Refine your search", click on "Limit to currently available
  items"
- Verify that the message "Showing only available items" and the link
  "Show all items" display nicely.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
use_zebra_facets set to 0 in koha-conf.xml to test. Works as described

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 14515 (QA Followup) fix letter.pl available fields.
Barton Chittenden [Tue, 6 Oct 2015 13:54:41 +0000 (06:54 -0700)]
 Bug 14515 (QA Followup) fix letter.pl available fields.

Add bibliotiems to the 'available fields' list for
module 'Holds' (aka reserves).

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 14515: Add biblioitems to messages in C4/Reserves.pm
Barton Chittenden [Thu, 9 Jul 2015 20:23:49 +0000 (13:23 -0700)]
 Bug 14515: Add biblioitems to messages in C4/Reserves.pm

http://bugs.koha-community.org/show_bug.cgi?id=14515

Signed-off-by: Danielle Aloia <daloia@nyam.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 11084 [QA Followup] - Document limitations of test mode
Kyle M Hall [Wed, 22 Apr 2015 13:11:21 +0000 (09:11 -0400)]
 Bug 11084 [QA Followup] - Document limitations of test mode

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 11084 [QA Followup] - Suppress userenv warning
Kyle M Hall [Wed, 22 Apr 2015 12:58:08 +0000 (08:58 -0400)]
 Bug 11084 [QA Followup] - Suppress userenv warning

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 11084 [QA Followup]
Kyle M Hall [Thu, 16 Apr 2015 11:50:09 +0000 (07:50 -0400)]
 Bug 11084 [QA Followup]

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 11084 - Delete biblios on Leader 05 == d
Kyle M Hall [Sun, 20 Oct 2013 18:02:52 +0000 (14:02 -0400)]
 Bug 11084 - Delete biblios on Leader 05 == d

Position 05 of the leader in MARC 21 indicates the record's status.
A lower case 'd' indicates that the record is to be deleted
(http://www.loc.gov/marc/authority/adleader.html).

This patch adds a cronjob script that may be run nightly to delete
records where position 05 of the leader is set to 'd'.

Test Plan:
1) Edit one or more records, and set the leader position 05 to 'd'.
2) Run misc/cronjobs/delete_records_via_leader.pl -c -v
3) Those records should either be deleted, or an error message should
   state why they were not.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Works as advertised. Edited a record with an item to have leader05 = d,
then ran delete_records_via_leader.pl with -c and got a message that
the record could not be deleted because of the item. Removed the item
and the script deleted the record. Tried with another record with an
item, this time with the -i option and the record was deleted.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 14638: Update Serials Help
Nicole C. Engard [Mon, 3 Aug 2015 14:17:21 +0000 (09:17 -0500)]
 Bug 14638: Update Serials Help

The serials help file was out of date for 3.18+

To test:

* apply patch
* Go to serials > new subscription
* Click help
* Confirm help correct

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years agoBug 15213 - fix buttons on patron lists
Liz Rea [Fri, 20 Nov 2015 02:08:25 +0000 (15:08 +1300)]
Bug 15213 - fix buttons on patron lists

To test:
go to tools -> patron lists
notice that the buttons are not misaligned anymore

You may need to force refresh the page to see the original issue, and to see it fixed.

http://bugs.koha-community.org/show_bug.cgi?id=15223

With patch buttons display nicely.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 15230: Remove unused file circ/stats.pl and stats.tt from system
Marc Véron [Fri, 20 Nov 2015 18:05:02 +0000 (19:05 +0100)]
Bug 15230: Remove unused file circ/stats.pl and stats.tt from system

This patch removes stats.pl and stats.tt from system.

To test:
- Verify that both files are not used and that the only reference in
  koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt
  is commented out.
- Apply patch
- Verify that the files are deleted and the reference is removed.
- git grep 'stats.pl', verify that there are no more references to
  this file.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
See the following commit for more info on this script:
  commit 60105bd692a07639f275543365acfca4f464c1a2
  Date:   Tue Jul 8 20:02:34 2008 -0500
    fix for 2008: Daily reconciliation report broken

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 13838 - Redirect to 'expired holds' tab after cancelling a hold
Kyle M Hall [Mon, 20 Apr 2015 19:31:11 +0000 (12:31 -0700)]
Bug 13838 - Redirect to 'expired holds' tab after cancelling a hold

When canceling a hold from the holds over tab, you are redirected back to the holds waiting tab. Instead, we should the librarian should continue to see the list of holds past the waiting length.

Test Plan:
1) Apply this patch
2) Cancel a hold from the "Holds over" tab on circ/waitingreserves.pl
3) Note you are redirected back to the holds over tab

Signed-off-by: Tom Misilo <misilot@fit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 15193 - Perl scripts missing exec permission
Fridolin Somers [Mon, 16 Nov 2015 12:07:07 +0000 (13:07 +0100)]
Bug 15193 - Perl scripts missing exec permission

Some perl scripts have 644 permissions instead of 755.

I think some are special like install-CPAN.pl.

This patch corrects some common perl scripts.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 14971: fix RIS export
Bernardo Gonzalez Kriegel [Thu, 3 Dec 2015 12:19:17 +0000 (09:19 -0300)]
Bug 14971: fix RIS export

This patch removes a limit in RIS.pm print_isbn sub.

To test:
1) Find in opac a book with an isbn with length(isbn) > 10
(with dashes or isbn13)
2) Export record to RIS format, check truncated SN field
in exported file
3) Apply the patch
4) Export again, no more truncation

Signed-off-by: jvr <jvr@fct.unl.pt>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 15202: Fix date display when transferring an order
Katrin Fischer [Sun, 22 Nov 2015 01:31:10 +0000 (02:31 +0100)]
Bug 15202: Fix date display when transferring an order

The date a basket was created was not displayed
according to the dateformat system preference.

Also fixes wording of the message shown when there
are no baskets for a chosen vendor.

To test:
- Create an order with an order line
- Click on the "Transfer" link on the basket
  summary page
- Search for a vendor without open baskets
- Verify change of message shown:
  "There are no open baskets for this vendor."
- Choose another vendor with open baskets
- Verify the creation date of the basket is
  displayed correctly formatted.

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
5 years agoBug 14846 - Items with no holdingbranch causes svc/holds to crash
Blou [Thu, 17 Sep 2015 15:33:38 +0000 (11:33 -0400)]
Bug 14846 - Items with no holdingbranch causes svc/holds to crash

When trying to display the holds for a user, if an item has no
holdingbranch, it causes the svc/holds service to crash and the display
to freeze.

Tentative steps to reproduce on any DB:
1) put 1 or more items on hold for a given user.
2) go into the database and set the item.holdingbranch to NULL
3) In the user's page, in checkouts (circulation.pl), click the tab that
   should be written 1 Hold(s)
4) It will be "Processing" indefinitely.

The cause is the svc/holds code that crashes.  The fix will validate
that there's an holdingbranch before proceding with the code.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 15325: Fix --table option of rebuild_zebra.pl
Julian Maurice [Mon, 7 Dec 2015 14:25:25 +0000 (15:25 +0100)]
Bug 15325: Fix --table option of rebuild_zebra.pl

Option's value given on command line was never used and 'biblioitems'
was used instead.

Test plan:
1. git checkout master
2. perl misc/migration_tools/rebuild_zebra.pl -b -t items --where "price = 42"
3. You should see errors printed on screen about an unknown column
4. Apply patch
5. perl misc/migration_tools/rebuild_zebra.pl -b -t items --where "price = 42"
6. No errors \o/

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 15244: t/db_dependent/Reserves.t depends on external data/configuration
Marc Véron [Tue, 1 Dec 2015 19:22:27 +0000 (20:22 +0100)]
Bug 15244: t/db_dependent/Reserves.t depends on external data/configuration

Test 14 in t/db_dependent/Reserves.t fails if syspref LocalHoldsPriority is
set to "[Give] priority for filling holds to patrons whose...

To verify:
- Set syspref as above and run test. Test 14 fails.
- Set syspref to [Don't give] and run test agein, it passes OK.

To test:
- Apply patch
- Run test again with syspref set / not set
Expected result: In both cases test should pass

(AMended to change bug title)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 15216: Returns - Show collection description
Katrin Fischer [Wed, 25 Nov 2015 23:29:34 +0000 (00:29 +0100)]
Bug 15216: Returns - Show collection description

The table of returns displays the collection code
instead of the description. This patch fixes that.

Same as first patch:

To test:
- Check out some items
- Return the items
- Verify the changes in the table of returned items

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 15216: Returns - Show branch names and item type description
Katrin Fischer [Sun, 22 Nov 2015 01:23:11 +0000 (02:23 +0100)]
Bug 15216: Returns - Show branch names and item type description

Changes the table with returned items to display the branch
names for home and holding branch and the itemtype description
instead of the codes.

To test:
- Check out some items
- Return the items
- Verify the changes in the table of returned items

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 11038: Enable use of IntranetUserCSS on staff client login page
Bernardo Gonzalez Kriegel [Sat, 28 Nov 2015 14:33:37 +0000 (11:33 -0300)]
Bug 11038: Enable use of IntranetUserCSS on staff client login page

This patch enable use of IntranetUserCss on staff client
login page.

To test:
1) Add something to IntranetUserCSS to modify login page,
for example

 #login h1 a {
   height:30px;
 }

2) Logout from staff client, no changes on login page.
3) Apply the patch
4) Reload, now logo is cut in half :)
Bonus) Login again an try changing image, add

 #login h1 {
  background: url(http://example.com/img/other-logo.png) no-repeat top center;
 }

and fix height. Logout and check

This also affects 3.20 and perhaps earlier versions.
Re-upload to fix examples

Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 9184: Acq - Don't show authority batches when ordering from staged file
Katrin Fischer [Sun, 22 Nov 2015 00:18:04 +0000 (01:18 +0100)]
Bug 9184: Acq - Don't show authority batches when ordering from staged file

When ordering from a staged file, the list of files
should only include imports of bilbiographic and
no authority data.

To test - start without the patch:
1) Stage an authority file
2) Stage a bilbiographic file
3) Create a new basked in acquisitions
4) Create a new order line selecting "From a staged file"
5) Verify that both files are shown
6) Apply patch
7) Verify that only the bibliographc file shows
   in the list now

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 14599 - Saved auth login and password are used in patron creation from
Fridolin Somers [Mon, 23 Nov 2015 08:19:06 +0000 (09:19 +0100)]
Bug 14599 - Saved auth login and password are used in patron creation from

If one save the login and password used to authenticate in staff interface, when creating a new patron, those login and password are filled in the corresponding inputs in the form.
This behaviour is awkward from web browser.

A trick is provided by http://stackoverflow.com/questions/10738090/why-firefox-autocomplete-even-with-different-input-name

I found that the best way is to use an hidden disabled input between userid and password.

Test plan :

- Log into Koha
- Allow the browser to save the userid/password
- Be sure that you have only one userid/password for this Koha
- Loggout
- Re log to check the browser autocomplets the authentication form
- Create a new patron
=> Without patch your saved userid/password have been added to the form
=> With patch your saved userid/password have not been added to the form

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This is not elegant but it works.
Note that the problem does not exist with Chromium

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 14349: Checkouts and Fines tab missing category description on the left
Katrin Fischer [Sun, 22 Nov 2015 02:25:58 +0000 (03:25 +0100)]
Bug 14349: Checkouts and Fines tab missing category description on the left

When navigating the tabs in the patron account, for 2 tabs the
patron category description is missing above the tabs.

To test:
- Go to a patron account in staff
- Click through the tabs
- Verify that for Checkouts and Fines the category description
  is missing above the tabs
- Apply patch
- Verify the description is now shown

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 15290: SQL reports headers encoding problem
Tomas Cohen Arazi [Thu, 3 Dec 2015 14:23:54 +0000 (11:23 -0300)]
Bug 15290: SQL reports headers encoding problem

To test:

- Create an SQL report with column names containing UTF characters
- Run the report
=> FAIL: The column names are double encoded
- Export the report
=> FAIL: The column names are double encoded in the exported file
- Apply the patch
- Re-run the report (reload works)
=> SUCCESS: Encoding correct
- Export the report
=> SUCCESS: Encoding correct
- Sign off :-D

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 15290: (follow-up)SQL reports headers encoding problem
Hector Castro [Thu, 3 Dec 2015 19:20:40 +0000 (13:20 -0600)]
Bug 15290: (follow-up)SQL reports headers encoding problem

Fix SQL row data and headers enconding problem

To test:
-Apply patches
-Follow previous test plan
-Notice the headers and row data is displayed in UTF-8
 without double encoding
-Save in Comma separated text, Tab seprated text, and Open Document.
-Verify in the three options the file exported is Ok

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agonew Debian package maintainer
Galen Charlton [Sat, 5 Dec 2015 01:26:11 +0000 (01:26 +0000)]
new Debian package maintainer

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
5 years agoBug 12152: Holds to pull report - Display location descriptions
Jonathan Druart [Wed, 25 Nov 2015 16:40:37 +0000 (16:40 +0000)]
Bug 12152: Holds to pull report - Display location descriptions

...instead of their code

Test plan:
Same as before, confirm the the location codes are replaced with their
descriptions.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBug 12152: Holds to pull report - Show branch names and item type descriptions
Katrin Fischer [Sun, 22 Nov 2015 02:38:30 +0000 (03:38 +0100)]
Bug 12152: Holds to pull report - Show branch names and item type descriptions

The 'Holds to pull' report shows branch and itemtype codes without
this patch. With the patch, names and descriptions should display.

To test:
- Make sure there are some holds for available items in your system
- Go to Circulation > Holds to pull
- Verify changes mentioned above in the list of holds shown

Signed-off-by: David Cook <dcook@prosentient.com.au>
Works as described, although as Magnus mentioned, Locations
still use codes instead of descriptions.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoBUG 11602: [ENH] Fix localcover display
Nicholas van Oudtshoorn [Thu, 15 May 2014 05:27:48 +0000 (13:27 +0800)]
BUG 11602: [ENH] Fix localcover display

Adds a css class of thumbnail to local covers.
Don't show the 1px "No image found" image
(since we'll ususally try another image provider)

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Box with "No cover image availabe" fixed when syspref OPACLocalCoverImages
set to display

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
5 years agoBug 13024 [QA Followup] - Add nonpublic note to relatives' checkouts
Kyle M Hall [Tue, 1 Dec 2015 17:49:55 +0000 (17:49 +0000)]
Bug 13024 [QA Followup] - Add nonpublic note to relatives' checkouts

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
5 years agoBug 13024 - Nonpublic note not appearing in the staff client
Kyle M Hall [Fri, 24 Apr 2015 14:41:58 +0000 (10:41 -0400)]
Bug 13024 - Nonpublic note not appearing in the staff client

The nonpublic note for items is not displayed in the staff client. It
should be displayed in the following areas:
1) Checkouts (circulation.pl)
2) Checkins (returns.pl)
3) Record details ( moredetail.pl )

Test Plan:
1) Ensure your non-public note field is mapped to the
   items.itemnotes_nonpublic database column
2) Edit an item, add a test nonpublic note
3) Check out the item, verify the note is visible in the checkouts table
4) Check in the item, verify the note is visible in the checkins table
5) View the item details, verify the note is visible and editable
   if your account has the rights to edit items

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
5 years agoBug 15250: Fix Perl error on acqisition stats page
Katrin Fischer [Wed, 25 Nov 2015 17:18:04 +0000 (18:18 +0100)]
Bug 15250: Fix Perl error on acqisition stats page

To test:
- Go to reports -> Acquisitions statistics
- Populate with the following values:

   Acquisitions statistics
      Received on.
         Row:    checked
         Column: checked
         From:   01/01/2015
         To:     Un-selected

    Cell value
       Count items

    Output: To screen into the browser: checked

- Running the report will trigger the following error:

   Software error:
   Can't locate object method "field" via package "aqorders.datereceived" (perhaps you forgot to load "aqorders.datereceived"?) at /usr/share/koha/intranet/cgi-bin/reports/acquisitions_stats.pl line 293.

- Apply the patch and repeat test
- Verify the report now works correctly

Note: Patch was created from notes and suggested
      fix on the bug report, written by Barton Chittenden.

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
5 years agoBug 15256: Fix items table display on the detail page
Jonathan Druart [Wed, 25 Nov 2015 17:08:43 +0000 (17:08 +0000)]
Bug 15256: Fix items table display on the detail page

Bug 14966 fixed a bug but introduced another one: With
IndependentBranches set to 'prevent', if the librarian (without the
superlibrarian permission) can edit items but not all, the table is
broken.  DataTables raises the following warning: "DataTables warning:
table id=DataTables_Table_1 - Requested unknown parameter '8' for row0."
And does not display correctly.

Test plan:
1/ Create a biblio record with 1+ items located in different places.
2/ Create/use a patron with the permission to edit items
3/ Set the IndependentBranches pref to 'prevent'
4/ With this patron logged in, go on the record detail page.
Without this patch, the display is broken (only 1 edit link and 1 td
missing, DataTables raises a warning).
With this patch, the display is correct.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  See the warning, and the broken table. Solved by this patch.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
5 years agoDBRev 3.23.00.000: 2016 Year of the Monkey
Brendan Gallagher [Mon, 30 Nov 2015 15:58:18 +0000 (07:58 -0800)]
DBRev 3.23.00.000: 2016 Year of the Monkey

5 years agoKoha 3.22 and beyond v3.22.00
Tomas Cohen Arazi [Thu, 26 Nov 2015 14:57:54 +0000 (11:57 -0300)]
Koha 3.22 and beyond

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoRelease notes for 3.22
Tomas Cohen Arazi [Thu, 26 Nov 2015 14:51:24 +0000 (11:51 -0300)]
Release notes for 3.22

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoTranslation updates for Koha 3.22.0 release
Bernardo Gonzalez Kriegel [Thu, 26 Nov 2015 01:05:34 +0000 (22:05 -0300)]
Translation updates for Koha 3.22.0 release

Two new languages: Occitan and Malayalam

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 15242: Missing subroutine in overdue_notices.pl
Nick Clemens [Tue, 24 Nov 2015 19:23:53 +0000 (19:23 +0000)]
Bug 15242: Missing subroutine in overdue_notices.pl

This patch changes the call to parse_overdues_letter to use the full
namespace to ensure the subroutine can be found.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 15207: Avoid warnings when adding constraint course_reserves_ibfk_2
Jonathan Druart [Wed, 25 Nov 2015 13:49:51 +0000 (13:49 +0000)]
Bug 15207: Avoid warnings when adding constraint course_reserves_ibfk_2

Bug 14205 added a new foreign key on the course_reserve table.
As this dbrev has been backported to the stable version (3.20.x), the
next dbrev should take care of this existing constraint to avoid
warnings.

Test plan:
1/ replace the modified dbrev with 3.21.00.XXX to make sure it will be
executed
2/ Make sure you have the KEY and the FK on the course_reserves table:
sql> alter table course_reserves add CONSTRAINT `course_reserves_ibfk_2`
FOREIGN KEY (`ci_id`) REFERENCES `course_items` (`ci_id`) ON DELETE
CASCADE ON UPDATE CASCADE;
sql> alter table course_reserves ADD KEY `course_reserves_ibfk_2` (`ci_id`);

3/ SHOW CREATE TABLE course_reserves
should show that the table is not in sync with the kohastructure.sql file
4/ Execute the dbrev
5/ SHOW CREATE TABLE course_reserves
should show that the table is in sync with the kohastructure.sql file

Repeat 4 and 5, confirm you don't get any error.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 14298: Do not insert the permission if already exists.
Jonathan Druart [Wed, 25 Nov 2015 13:29:05 +0000 (13:29 +0000)]
Bug 14298: Do not insert the permission if already exists.

To avoid a warning on updating from 3.20.x to 3.22, use "insert ignore
into".

This patch is not useful for 3.20.x.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 11431: (follow-up) Update database
Jonathan Druart [Wed, 25 Nov 2015 13:17:52 +0000 (13:17 +0000)]
Bug 11431: (follow-up) Update database

This patch specifies the collate for the new audio_alerts table to the updatedb entry.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 15062: Holds queue with Transport Cost Matrix will transfer item even if transfer...
Kyle M Hall [Mon, 26 Oct 2015 12:30:57 +0000 (08:30 -0400)]
Bug 15062: Holds queue with Transport Cost Matrix will transfer item even if transfers disabled

If the transfer of an item from Library A to Library B is disabled in
the Transport Cost Matrix, but the only item on a record is from Library
A, the holds queue will request a transfer of that item from Library A
to Library B even though the rules state such a transfer is not allowed!

Test Plan:
1) Enable the transport cost matrix
2) For simplicity, leave all cells disabled on it, save this state.
   This state means that only items at each location should fill
   holds where the pickup library is that same location.
3) Create a record with one item, set its home and holding branch
   to Library A
4) Create a hold for pickup at Library B
5) Rebuild the holds queue
6) Note the transfer request for the item to Library B
7) Apply this patch
8) Rebuild the holds queue
9) Note the transfer request is gone

Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 15062: Regression tests
Kyle M Hall [Thu, 19 Nov 2015 12:50:45 +0000 (12:50 +0000)]
Bug 15062: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 15198: Change wording of OpacSuppression system preference
David Cook [Tue, 17 Nov 2015 06:18:05 +0000 (17:18 +1100)]
Bug 15198: Change wording of OpacSuppression system preference

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Paragraph rewording successfully

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 15198: Make OpacSuppression work even if there are no records suppressed
David Cook [Tue, 17 Nov 2015 02:03:59 +0000 (13:03 +1100)]
Bug 15198: Make OpacSuppression work even if there are no records suppressed

This patch adds the Zebra special attribute 14 to ccl.properties and
opac-search.pl, so that we can turn on OpacSuppression and still return
results even if there are no records in Zebra for the Suppress index.

_TEST PLAN_

Before applying:

1) Make sure that you have no suppressed records indexed in Zebra
2) Turn on OpacSuppression system preference

3) Search using a keyword which should bring up records
4) Note that no records are returned in the results
5) Change UseQueryParser system preference to "Try"
6) Repeat steps 3-4

Apply the patch.

After applying:

7) Repeat step 3 (ie search using a keyword which should bring up records)
8) Confirm that records are appearing in the results!
9) Change UseQueryParser system preference to "Do not try"
10) Repeat step 3
11) Confirm that records are appearing in the results!

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised. No more, won't need to have at least one record with the
value "1" in the field mapped with this index. All records in OPAC returned.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 14264: Fix export of late orders when translated
Jonathan Druart [Sun, 24 May 2015 15:52:25 +0000 (17:52 +0200)]
Bug 14264: Fix export of late orders when translated

Bug 7298 tried to fix this issue, but it was not correct.
We have 3 files in acqui/csv:
basketgroup.tt, basket.tt and lateorders.tt
The first 2 don't contain translatable string, and are not modified on
translating the templates (`translate install`)
On the contrary, lateorders.tt has some strings to translate ('Author:',
'Published by:', etc.). After being translated, all carriage returns
between TT tags are removed.

Test plan:
1/ choose a language and update + translate the templates
for instance:
  cd misc/translate;
  ./translate update es-ES; ./translate install es-ES
2/ Go to acqui/lateorders.pl using this language
3/ Generate a csv for 1+ late orders and confirm the first line only
contains the headers.

Signed-off-by: Laurence Lefaucheur <laurence.lefaucheur@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 15218: (QA followup) Fix wording of comment
Kyle M Hall [Fri, 20 Nov 2015 14:12:54 +0000 (14:12 +0000)]
Bug 15218: (QA followup) Fix wording of comment

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 15218: (Plack) Make processes that rely on background jobs run in CGI mode
Tomas Cohen Arazi [Fri, 20 Nov 2015 03:08:45 +0000 (00:08 -0300)]
Bug 15218: (Plack) Make processes that rely on background jobs run in CGI mode

This patch adds an entry to the plack-related apache configuration so the
problematic scripts (that fail under plack/starman) are not processed through
Plack but in CGI mode instead.

To test:
- Follow the setup steps from bug 15032
- Add the line from this patch to /etc/koha/apache-shared-intranet-plack.conf
 (if you are on kohadevbox you should probably change the filesystem path to
  /home/vagrant/kohaclone/tools/background-job-process.pl)
- Do the full import process of MARC data.
=> SUCCESS: It works as expected.
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 15215: Remove warning due to misuse of UNIVERSAL
Colin Campbell [Thu, 19 Nov 2015 12:15:34 +0000 (12:15 +0000)]
Bug 15215: Remove warning due to misuse of UNIVERSAL

Calling UNIVERSAL's internal methods will cause a depreciation
warning in perls less that 5.22 as of 5.22 the warning is a fatal
error causing compilation to abort

Replace the use UNIVERSAL with UNIVERSAL::can to work around the
buggy construct perldoc UNIVERSAL::can for more info

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
No more worning/error
No qa errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 14101: Unit tests
Holger Meißner [Tue, 22 Sep 2015 12:03:33 +0000 (14:03 +0200)]
Bug 14101: Unit tests

This patch adds new test cases to check if CanBookBeRenewed provides
correct return values and error codes for premature renewals. Both manual
and automatic renewals and different settings for 'No renewal before'
are tested.

To test:
1) prove t/db_dependent/Circulation.t

Sponsored-by: Hochschule für Gesundheit (hsg), Germany
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 14101: Automatic renewals exactly on due date
Holger Meißner [Tue, 2 Jun 2015 13:39:21 +0000 (15:39 +0200)]
Bug 14101: Automatic renewals exactly on due date

If no value for 'no renewal before' is specified, automatic renewal now
falls back on the due date. Also 'no renewal before' can now be zero, so
both automatic and manual renewals can be delayed until due date.

Test plan:

1) Create some circulation rules with different settings for 'No renewal
   before' and 'Automatic renewal'. Both daily and hourly loans should
   work.

2) Try to renew both manually and automatically before and after a renewal
   should be possible. You can run misc/cronjobs/automatic_renewals.pl for
   automatic renewal.

3) Confirm that:
   * Both automatic and manual renewal with 'No renewal before' set
     to 0 do not happen before the due date (exact DateTime).
   * Manual renewal with 'No renewal before' set to undef (enter empty
     string) is unrestricted.
   * Automatic renewal with 'No renewal before' set to undef does not
     happen before the due date.

Sponsored-by: Hochschule für Gesundheit (hsg), Germany
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 4502: Changing wording again...
Jonathan Druart [Tue, 22 Sep 2015 11:11:34 +0000 (12:11 +0100)]
Bug 4502: Changing wording again...

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Just a string patch, others are signed.
No errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 4502: An attempt to make things more sensible.
Mark Tompsett [Mon, 6 Apr 2015 23:50:30 +0000 (19:50 -0400)]
Bug 4502: An attempt to make things more sensible.

The reason the budget_period_id was not defined was because in
two cases it was not passed! This patch adds those missing
parameters. And as a result, cuts out the attempt to default the
authcat to '' unless the budget_period_id is defined.

Additionally, the start and end months don't seem to be passed,
so rather than have it blow up, checking them forces the else
case logic.

budget_period_id is the budget id. If you have two budgets,
you can craft a URL to work with budget_period_id matching
those two ids. Anything else should trigger the new error which
was modified to reflect more of what the problem is.

Follow the test plan in comment #6. Feel free to also to attempt
crafting URLs and triggering errors.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Well, works and does not explode any more
No errors

To trigger the new message simply put /cgi-bin/koha/admin/aqplan.pl
on your staff page, an intriguing 'Planning for by Asort1' appears :)

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 4502: Catch software error if no active budget defined
Jonathan Druart [Tue, 24 Mar 2015 14:54:37 +0000 (15:54 +0100)]
Bug 4502: Catch software error if no active budget defined

TEST PLAN
---------
0) Back up your database.
1) In mysql client:
   > DROP DATABASE {your koha database name};
   > CREATE DATABASE {your koha database name};
   > QUIT;
2) Go to the staff client, and install all the default
   and optional things -- except patrons. :)
3) Log into staff client.
4) Create a patron -> New Patron -> Staff
5) Enter data and Save
6) More -> Set Permissions
7) Make superlibrarian
8) Log out
9) Log in as new superlibrarian
10) Acquisitions -> Budgets -> New Budget
11) Enter a non-active budget with some funds.
    -- Once saved, it should list in the inactive budgets.
12) Click on the name.
13) Click on one of the Planning submenu options.
14) Click the 'Submit' button in the Filter area.
    -- This should trigger the blow up.
15) Apply the patch
16) Repeat steps 12-15
    -- The kaboom is avoided and a nice message given.

NOTE: This does not solve all the problems in this ugly, ugly
      module area. It does solve the one thing it is meant to:
      that nasty kaboom.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 15047: 655 URL not clickable in opac-detail.
Winona Salesky [Thu, 22 Oct 2015 13:22:47 +0000 (09:22 -0400)]
Bug 15047: 655 URL not clickable in opac-detail.

Test Plan:

1) Apply this patch
2) Ensure you are using the default XSLT setting for the staff and opac  record details
3) Find or create a record with MARC tags 655
4) Perform an opac search and select records with 655 field, select record and review details page.
5) Check that 655 field is clickable.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised. 655 field clickable

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 15091: DEBT is IMPOSSIBLE, not NEEDSCONFIRMATION
Jonathan Druart [Thu, 5 Nov 2015 12:10:19 +0000 (12:10 +0000)]
Bug 15091: DEBT is IMPOSSIBLE, not NEEDSCONFIRMATION

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 15091: Do not allow to use batch checkout if checkout is not allowed
Jonathan Druart [Thu, 5 Nov 2015 09:58:34 +0000 (09:58 +0000)]
Bug 15091: Do not allow to use batch checkout if checkout is not allowed

If the noissue param is passed to the template, the batch checkout
should not be allowed.

This patch globally fixes the problem raised by bug 15091.
A generic message "cannot check out" is displayed and some more specific
ones could be added later.
For now it only trigger the "fine balance is over the limit" message.

Test plan:
Confirm there is no regression on the original behavior and that the
issue raised on bug 15091 is fixed.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 15091: Batch Checkout: Set titles above result tables
Marc Véron [Tue, 3 Nov 2015 19:06:25 +0000 (20:06 +0100)]
Bug 15091: Batch Checkout: Set titles above result tables

This patch is to clarify the results that are displayed while performing
a batch checkout.

It is not the full solution for what is described in the video in
comment #2, but it tells the user what the information in the table
is about.

A second patch is planned to address the case where the issues are confirmed
but not can be fulfilled because the user's fines reach the threshold while
checking out the items.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 13411: (QA followup) Add logging
Kyle M Hall [Mon, 2 Mar 2015 14:06:58 +0000 (06:06 -0800)]
Bug 13411: (QA followup) Add logging

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 13411: Koha's SIP server returns not ok for checking in items that are not checke...
Kyle M Hall [Thu, 27 Aug 2015 14:56:22 +0000 (10:56 -0400)]
Bug 13411: Koha's SIP server returns not ok for checking in items that are not checked out

If an item is not checked out when a checkin via SIP2 is attempted,
Koha's SIP server sends back an "ok" of 0, and the AF message "Item
not checked out". I am not entirely sure this is good and correct
behavior by the SIP2 protocol.

In particular, this will cause SIP2 book sorting devices to fail on
all items that are not checked out, causing them all to be put into
the "special handling" been that should be reserved for things like
items checked in at the wrong library and items on hold.

Test Plan:
1) Apply the patch for bug 13159 so you can use the new enhanced
   SIP2 command line emulator
2) Use a command similar to the following to check in an item:
   sip_cli_emulator.pl -a localhost -su <sip user> -sp <sip password> -l <instituation id> --item <barcode> -m checkin
3) Note the 3rd character is 0, and there is an AF field saying the item is not checked out
4) Apply this patch
5) Restart the SIP server
6) Repeat steps 2-3, note that nothing has changed
7) In the SIP config file, Add the parameter checked_in_ok="1" to the SIP account you are using.
8) Restart the SIP server
9) Repeat steps 2-3, note that this time the 3rd character is 1, and you do not recieve the item not checked out message.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 12072: DBRev 3.21.00.056
Tomas Cohen Arazi [Thu, 19 Nov 2015 23:15:03 +0000 (20:15 -0300)]
Bug 12072: DBRev 3.21.00.056

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 12072: Make datepicker and templates to be aware of dmydot format
Marc Véron [Wed, 18 Nov 2015 16:33:33 +0000 (17:33 +0100)]
Bug 12072: Make datepicker and templates to be aware of dmydot format

This patch is to display corrextly the new dmydot date format e.g. after
using the datepicker or in messages for the user, in following files:

- koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc
- koha-tmpl/intranet-tmpl/prog/en/includes/date-format.inc
- koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
- koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt
- koha-tmpl/opac-tmpl/bootstrap/en/includes/calendar.inc
- tools/holidays.pl

To test:
- Apply patch
- Make sure that you have syspref dateformat set to dmydot
- Use datepicker in OPAC (modify birth date), verify that after
  choosing a date, it is displayed correctly in the datepicker
- Use datepicker at several places in OPAC, verify that after choosing
  a date the date displays properly in datepicker and that the dater format
  is properly indicated (e.g. near birth date or near "Specify due date").
- Verify that datepicker works well with hoiday editing and that "From date:"
  displays properly

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 12072: Add system preference for New dateformat dd.mm.yyyy (dmydot)
Marc Véron [Sat, 7 Mar 2015 07:38:04 +0000 (08:38 +0100)]
Bug 12072: Add system preference for New dateformat dd.mm.yyyy (dmydot)

Note: This feature depends on Bug 14870 'Delete C4/Dates from system'

System preferences:
To test:
- apply the patch
- run updatedatabase.pl
- go to Admin > Sysprefs > I18N, change dateformat to dd.mm.yyyy, save
- verify that the value was saved

Date handling:
- go through the staff client and verify that dates behave as expected.
- go through Opac and verify that dates behave as expected.

  The Bugs where Bug 14870 depends on contain test plans that can be
  used for the overall testing.

Note: Make sure that you reset the dateformat to the former value after
      testing.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Works as expected

Amended to apply on top of Bug 15166 11.11.2015/mv

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 14870: QA follow-up - fixing tiny typo
Katrin Fischer [Thu, 19 Nov 2015 13:47:43 +0000 (14:47 +0100)]
Bug 14870: QA follow-up - fixing tiny typo

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 14870: (followup) Remove superfluous C4::Dates from fix_accountlines_rmdupfines_b...
Marc Véron [Wed, 18 Nov 2015 10:48:09 +0000 (11:48 +0100)]
Bug 14870: (followup) Remove superfluous C4::Dates from fix_accountlines_rmdupfines_bug8253.pl

This patch removes C4::Dates from fix_accountlines_rmdupfines_bug8253.pl

To test:
- Apply patch
- Check code for uses of C4::Dates (date_format)

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 14870: (followup) Remove stray C4::Dates
Marc Véron [Wed, 18 Nov 2015 07:57:27 +0000 (08:57 +0100)]
Bug 14870: (followup) Remove stray C4::Dates

(See comment #23)

This patch removes stray C4::Dates (date_fromat...) from
C4/Items.pm
C4/Log.pm
C4/Serials.pm
serials/acqui-search-result.pl
t/DateUtils.t
t/db_dependent/Items/GetItemsForInventory.t
tools/koha-news.pl

Some of them were inside comments etc.

To test:
- git grep 'C4::Dates' should give no result
- git grep 'format_d' should give no result
  Exception: in one cron job there exists an own sub format_date, and occurences not
             related to C4::Dates
- Search for regressions

http://bugs.koha-community.org/show_bug.cgi?id=14870
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
serials/acqui-search-results.pl looks like it should be revisited,
containing code that might not be needed. Searching a vendor
in serials still works witout a problem.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 14870: (followup) Remove mention of C4::Dates from C4/Debug.pm
Marc Véron [Sun, 8 Nov 2015 22:26:25 +0000 (23:26 +0100)]
Bug 14870: (followup) Remove mention of C4::Dates from C4/Debug.pm

C4::Dates is mentioned as example in C4/Debug.pm. This patch removes it.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 14870: (followup) Remove stray C4::Dates from reports files
Marc Véron [Sun, 8 Nov 2015 22:09:10 +0000 (23:09 +0100)]
Bug 14870: (followup) Remove stray C4::Dates from reports files

This patch removes stray C4::Dates from following files:

reports/borrowers_stats.pl
To test: Verify that C4::Dates is not used in the file

reports/guided_reports.pl:
To test:
- Run a saved report with date input and with date range input, e.g.
- Verify that you are asked for date range or date and that the results
  are the same as without patch

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 14870: (followup) Remove stray C4::Dates from circ/returns.pl
Marc Véron [Sun, 8 Nov 2015 21:14:59 +0000 (22:14 +0100)]
Bug 14870: (followup) Remove stray C4::Dates from circ/returns.pl

This patch removes 1 remaining / stray occurence of C4::Dates from
circ/returns.pl

To test:
- Apply patch
- Go to Home > Circulation > Check in
- Verfiy that check-ins with overriding return dates work as before.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 14870: Remove C4::Dates from plack.psgi and koha.psgi
Hector Castro [Sun, 8 Nov 2015 03:43:56 +0000 (21:43 -0600)]
Bug 14870: Remove C4::Dates from plack.psgi and koha.psgi

Remove C4::Dates from .psgi files from preloaded modules, placing
Koha::DateUtils instead

http://bugs.koha-community.org/show_bug.cgi?id=14870
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 14870: Remove t/Dates.t from Koha
Hector Castro [Sat, 7 Nov 2015 16:56:23 +0000 (10:56 -0600)]
Bug 14870: Remove t/Dates.t from Koha

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 14870: Remove C4/Dates.pm from Koha
Hector Castro [Fri, 6 Nov 2015 16:42:53 +0000 (10:42 -0600)]
Bug 14870: Remove C4/Dates.pm from Koha

http://bugs.koha-community.org/show_bug.cgi?id=14870
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 15208: Followup to reorder words
Bernardo Gonzalez Kriegel [Wed, 18 Nov 2015 13:44:03 +0000 (10:44 -0300)]
Bug 15208: Followup to reorder words

It think it's better to put the shelf name first

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
5 years agoBug 15208: Ease translation for shelves messages
Bernardo Gonzalez Kriegel [Wed, 18 Nov 2015 13:18:14 +0000 (10:18 -0300)]
Bug 15208: Ease translation for shelves messages

This string patch only puts <span>...</span>
around shelves messages. It split a monster
translation string into its components.
This kind of string to translate is error-prone.

Also fixed a typo on opac, 'deleteing'

To test:
1) Search for 'An error occurred when updating this list'
on your preferred language translation file for staff
or opac
(xx-YY-staff-prog.po or xx-YY-opac-bootstrap.po)
You will see a 'big' string to translate

2) Apply the patch

3) Update translation files for your language

4) Search again, big one is gone and there are
new individual strings to translate.

Sorry for not spotting this before string freeze

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>