koha.git
11 years agoMerge remote branch 'kc/new/bug_5227' into kcmaster
Chris Cormack [Thu, 4 Nov 2010 19:02:34 +0000 (08:02 +1300)]
Merge remote branch 'kc/new/bug_5227' into kcmaster

11 years agoMerge remote branch 'kc/new/signoffs' into kcmaster
Chris Cormack [Thu, 4 Nov 2010 07:14:28 +0000 (20:14 +1300)]
Merge remote branch 'kc/new/signoffs' into kcmaster

Conflicts:
installer/data/mysql/updatedatabase.pl

Updated updatedatabase.pl to handle new version number

11 years agoBug 5363 - Removing unused module (C4::Cache::FastMemcached)
Chris Cormack [Wed, 3 Nov 2010 20:31:03 +0000 (16:31 -0400)]
Bug 5363 - Removing unused module (C4::Cache::FastMemcached)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 4141: fix upgrade of OPAC XSLT parameters from 3.0.x
Galen Charlton [Wed, 3 Nov 2010 17:49:00 +0000 (13:49 -0400)]
bug 4141: fix upgrade of OPAC XSLT parameters from 3.0.x

Note that OPACXSLTResultsDisplay and OPACXSLTDetailsDisplay
are boolean parameters in 3.2.x, not string parameters.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoUpdating version number and fixing the xxx in updatedatabase ... my bad
Chris Cormack [Wed, 3 Nov 2010 17:28:24 +0000 (06:28 +1300)]
Updating version number and fixing the xxx in updatedatabase ... my bad

11 years agoMerge remote branch 'kc/new/bug2567' into kcmaster
Chris Cormack [Wed, 3 Nov 2010 08:21:02 +0000 (21:21 +1300)]
Merge remote branch 'kc/new/bug2567' into kcmaster

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoMerge remote branch 'kc/new/bug_5308' into kcmaster
Chris Cormack [Wed, 3 Nov 2010 03:52:21 +0000 (16:52 +1300)]
Merge remote branch 'kc/new/bug_5308' into kcmaster

11 years agoMerge remote branch 'kc/new/merge_help' into kcmaster
Chris Cormack [Wed, 3 Nov 2010 01:58:40 +0000 (14:58 +1300)]
Merge remote branch 'kc/new/merge_help' into kcmaster

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoMerge remote branch 'kc/new/bug_4991' into kcmaster
Chris Cormack [Wed, 3 Nov 2010 01:48:37 +0000 (14:48 +1300)]
Merge remote branch 'kc/new/bug_4991' into kcmaster

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoMerge remote branch 'kc/new/bug_5301' into kcmaster
Chris Cormack [Tue, 2 Nov 2010 17:54:50 +0000 (06:54 +1300)]
Merge remote branch 'kc/new/bug_5301' into kcmaster

11 years agoBug 5192 Enhancement to add new index for 658 curriculum field
dev2 [Fri, 29 Oct 2010 11:53:34 +0000 (07:53 -0400)]
Bug 5192 Enhancement to add new index for 658 curriculum field

Creates new curriculum index for 658 subfields a,b,c and search option in Advanced search (under More Options).  Also modifies the installer files to make 658abc display (they were hidden in the frameworks) and to create the new indexes.

The 658 already displays as part of the staff/OPAC subject display line.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5243: avoid crash when saving authority records on certain setups
Galen Charlton [Thu, 28 Oct 2010 12:09:47 +0000 (08:09 -0400)]
bug 5243: avoid crash when saving authority records on certain setups

This does not seem to occur on all platforms - C4::Search
exports SimpleSearch() by default - but adding the 'C4::Search::'
qualifier certainly doesn't hurt things.

Patch by Fridolyn Somers <fridolyn.somers@gmail.com>

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5149: follow-up - remove extraneous character in link
Galen Charlton [Tue, 2 Nov 2010 02:09:10 +0000 (22:09 -0400)]
bug 5149: follow-up - remove extraneous character in link

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5149 fix broken link to noItemTypeImages preference
Nicole Engard [Tue, 2 Nov 2010 02:09:09 +0000 (22:09 -0400)]
bug 5149 fix broken link to noItemTypeImages preference

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5110 move NewItemsDefaultLocation to cataloging tab
Nicole Engard [Sat, 30 Oct 2010 20:29:24 +0000 (16:29 -0400)]
bug 5110 move NewItemsDefaultLocation to cataloging tab

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 4963, sys prefs need date hints and/or picker
Owen Leonard [Sat, 30 Oct 2010 20:25:19 +0000 (16:25 -0400)]
Fix for Bug 4963, sys prefs need date hints and/or picker

This patch adds the standard date format hint used elsewhere
in the interface.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 4254 - adding new patron advanced notice doesn't save
ByWater Solutions [Sat, 30 Oct 2010 13:50:29 +0000 (09:50 -0400)]
Bug 4254 - adding new patron advanced notice doesn't save

This was due to poorly constructed SQL which returned duplicate values for
certain fields. This patch corrects that SQL.

NOTE: There is also a formatting problem with the message prefs display table
when it is displayed in moremember.pl. This is due to there being no logic to
tell the table in that context to display checkboxes as appropriate. This patch
does not fix that. Bug 5328 has been opened for this problem.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 5082 - Not translatable name of default framework 'Default' in MARCdetail...
Owen Leonard [Sat, 30 Oct 2010 05:52:50 +0000 (01:52 -0400)]
Fix for Bug 5082 - Not translatable name of default framework 'Default' in MARCdetail.tmpl

This patch also fixes an unreported bug where switching from any
other framework to 'Default' would bring up no MARC data.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 4980 - Acq: pull down 'Restrict access to:' for funds not translatable
Owen Leonard [Sat, 30 Oct 2010 05:52:49 +0000 (01:52 -0400)]
Fix for Bug 4980 - Acq: pull down 'Restrict access to:' for funds not translatable

Applied Owen's patch to current head, updated de-DE translation. The pull down values are now  translated.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 5142, Untranslatable strings in tag review template
Owen Leonard [Sat, 30 Oct 2010 05:52:48 +0000 (01:52 -0400)]
Fix for Bug 5142, Untranslatable strings in tag review template

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 5056, Untranslatable strings in members.js
Owen Leonard [Sat, 30 Oct 2010 05:52:47 +0000 (01:52 -0400)]
Fix for Bug 5056, Untranslatable strings in members.js

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 5136, Replace SQL with call to GetAuthorisedValues
Owen Leonard [Sat, 30 Oct 2010 05:36:57 +0000 (01:36 -0400)]
Fix for Bug 5136, Replace SQL with call to GetAuthorisedValues

An embedded query in circulation.pl for BOR_NOTES authorized
values can be replaced with a call to GetAuthorisedValues

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 5135 - Authorized value input maxlength should match table column
Owen Leonard [Sat, 30 Oct 2010 05:33:42 +0000 (01:33 -0400)]
Fix for Bug 5135 - Authorized value input maxlength should match table column

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 4991: follow-up tweaks
Galen Charlton [Sat, 30 Oct 2010 04:40:15 +0000 (00:40 -0400)]
bug 4991: follow-up tweaks

* make some strings translatable
* display library name instead of code in add/edit
  holiday panel
* minor textual fixes to hints

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoFix for Bug 4991, Overhaul of Calendar interface
Owen Leonard [Mon, 12 Jul 2010 20:41:28 +0000 (16:41 -0400)]
Fix for Bug 4991, Overhaul of Calendar interface

- Put hints, key, and existing holidays into right column
- Style entry form for added clarity and consistency with other
  forms in Koha
- Change the way dynamically displayed hints are shown to better
  match existing static hints in Koha's interface
- Add branch name (instead of branch code) for clarity
- Add the ability to add and edit holiday titles (previously
  only description could be edited).
- Add links to the list of existing single-day holidays and
  exceptions which opens the calendar to that month/year

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 5171 change 'edit items' to read 'edit item' when next to 1 item
Nicole Engard [Sat, 30 Oct 2010 04:48:19 +0000 (00:48 -0400)]
bug 5171 change 'edit items' to read 'edit item' when next to 1 item

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5168 change link text from holdings to items
Nicole Engard [Sat, 30 Oct 2010 04:48:18 +0000 (00:48 -0400)]
bug 5168 change link text from holdings to items

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix bug 3811; Index language as word
Jared CAMINS-ESAKOV [Sat, 30 Oct 2010 03:49:15 +0000 (23:49 -0400)]
Fix bug 3811; Index language as word

An incorrect definition in record.abs was resulting in searches on languages returning incorrect results.  By changing the indexing mode from numeric to word, this patch fixes that problem.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5311: correction to database update
Galen Charlton [Sat, 30 Oct 2010 03:49:14 +0000 (23:49 -0400)]
bug 5311: correction to database update

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoUpdate language mappings to fix Bug 5311
Jared Camins-Esakov [Sat, 30 Oct 2010 03:49:13 +0000 (23:49 -0400)]
Update language mappings to fix Bug 5311

This patch updates the language_rfc4646_to_iso639 mapping table with the
correct mappings for several languages that were not mapped correctly to
the codes used in MARC, including Finnish (which was not mapped at all),
and Armenian (which was mapped to an obsolete code). This patch also
changes English and French to use the proper three-letter codes, which
will eliminate false positives when, for example, limiting by French
brings up results in Afrikaans.

This patch adds the changes to the updatedatabase.pl script, and removes
the incorrectly specified DBversion in the previous patch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5190: improve linking to MARC field documentation
Galen Charlton [Sat, 30 Oct 2010 02:35:44 +0000 (22:35 -0400)]
bug 5190: improve linking to MARC field documentation

* zero-pad tag numbers as needed
* handle special case for linking to UNIMARC 0XX vs. 1-8XX
* add a wrapper function
* add comment about the poor linkability of IFLA's UNIMARC documentation

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5190: link to MARC21/UNIMARC online doc in the bib editor
Galen Charlton [Sat, 30 Oct 2010 02:35:43 +0000 (22:35 -0400)]
bug 5190: link to MARC21/UNIMARC online doc in the bib editor

Patch from  Tomás Cohen Arazi <tomascohen@gmail.com>

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5326 fix link to old prefs editor on patron attributes
Nicole Engard [Sat, 30 Oct 2010 00:28:49 +0000 (20:28 -0400)]
bug 5326 fix link to old prefs editor on patron attributes

on the patron attributes page if you have ExtendedPatronAttributes
turned off the error points you to the old sys prefs editor - this
patch fixes that

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5326 fix extended patron attribute error
Nicole Engard [Sat, 30 Oct 2010 00:28:48 +0000 (20:28 -0400)]
bug 5326 fix extended patron attribute error

the error message if you have ExtendedPatronAttributes turned
off linked to the old sys prefs editor, link has been updated.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 5137, Remove obsolete code counting issues by item type in circ
Owen Leonard [Fri, 29 Oct 2010 12:37:41 +0000 (08:37 -0400)]
Fix for Bug 5137, Remove obsolete code counting issues by item type in circ

The removed section of code contained a "my $dbh = C4::Context->dbh"
which was required for the query of BOR_NOTES. That line has been
moved accordingly.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 5008 - "Remove" link missing when Cart in expanded view
Owen Leonard [Fri, 29 Oct 2010 12:29:02 +0000 (08:29 -0400)]
Fix for Bug 5008 - "Remove" link missing when Cart in expanded view

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 4986 move serials prefs from cataloging tab to serials tab
Nicole Engard [Fri, 29 Oct 2010 12:23:41 +0000 (08:23 -0400)]
bug 4986 move serials prefs from cataloging tab to serials tab

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 5114 - Can't edit basket in Internet Explorer
Owen Leonard [Fri, 29 Oct 2010 12:15:37 +0000 (08:15 -0400)]
Fix for Bug 5114 - Can't edit basket in Internet Explorer

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5019 remove link to funds
Nicole Engard [Fri, 29 Oct 2010 12:10:44 +0000 (08:10 -0400)]
bug 5019 remove link to funds

This patch renames the link to budgets to say 'budgets & funds'
and removes the links to funds (which went no where).

This patch also adds the acq menu to the budget pages.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5177 Selecting default sort result by syspref
Frédéric Demians [Fri, 29 Oct 2010 11:47:33 +0000 (07:47 -0400)]
Bug 5177 Selecting default sort result by syspref

Syspref .pref file was defining a code for descending order which wasn't
expected by .tmpl files... 'desc' instead of 'dsc'.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoMerge remote branch 'kc/new/bug_5162' into kcmaster
Chris Cormack [Tue, 2 Nov 2010 01:41:07 +0000 (14:41 +1300)]
Merge remote branch 'kc/new/bug_5162' into kcmaster

11 years agobug 5162: follow-up patch to not clear hidden input setting attribute type
Galen Charlton [Fri, 29 Oct 2010 11:40:37 +0000 (07:40 -0400)]
bug 5162: follow-up patch to not clear hidden input setting attribute type

Otherwise, can't saved new attributes set from a cloned
input or select control.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 5162, patron attributes 'new' link should create blank value
Owen Leonard [Fri, 29 Oct 2010 11:40:36 +0000 (07:40 -0400)]
Fix for Bug 5162, patron attributes 'new' link should create blank value

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoMerge remote branch 'kc/new/for-3.4/enh_bulkmarcimport' into kcmaster
Chris Cormack [Tue, 2 Nov 2010 01:38:52 +0000 (14:38 +1300)]
Merge remote branch 'kc/new/for-3.4/enh_bulkmarcimport' into kcmaster

11 years agoMerge remote branch 'kc/new/for-3.4/spelling' into kcmaster
Chris Cormack [Mon, 1 Nov 2010 22:33:49 +0000 (11:33 +1300)]
Merge remote branch 'kc/new/for-3.4/spelling' into kcmaster

11 years agobug 5050 move language prefs to I18N/L10N tab
Nicole Engard [Thu, 28 Oct 2010 15:53:51 +0000 (11:53 -0400)]
bug 5050 move language prefs to I18N/L10N tab

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5151 removed bolded terms in breadcrumbs
Nicole Engard [Thu, 28 Oct 2010 15:42:12 +0000 (11:42 -0400)]
bug 5151 removed bolded terms in breadcrumbs

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5237: Testing renewals on patron barcodes with + signs at the end
Liz Rea [Thu, 28 Oct 2010 14:00:03 +0000 (10:00 -0400)]
bug 5237: Testing renewals on patron barcodes with + signs at the end

According to notes in bug, patch was originally by Chris Cormack.

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5163 change title of holds to pull page
Nicole Engard [Thu, 28 Oct 2010 13:52:47 +0000 (09:52 -0400)]
bug 5163 change title of holds to pull page

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5258 change 'order' to 'order line' on receive page
Nicole Engard [Thu, 28 Oct 2010 13:45:04 +0000 (09:45 -0400)]
bug 5258 change 'order' to 'order line' on receive page

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5224 Remove the adjective Shopping from basket
Colin Campbell [Thu, 28 Oct 2010 13:39:09 +0000 (09:39 -0400)]
Bug 5224 Remove the adjective Shopping from basket

New orders breadcrumbs were using the inappropriate term
Shopping basket whereas basket is used elsewhere

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBUG 5239 add space between number and words in acq search
Nicole Engard [Thu, 28 Oct 2010 13:35:15 +0000 (09:35 -0400)]
BUG 5239 add space between number and words in acq search

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 5221 - Preselect tab containing itemtype/authval image in use
Owen Leonard [Thu, 28 Oct 2010 13:29:23 +0000 (09:29 -0400)]
Fix for Bug 5221 - Preselect tab containing itemtype/authval image in use

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoMerge remote branch 'kc/new/bug_5236' into kcmaster
Chris Cormack [Mon, 1 Nov 2010 22:10:39 +0000 (11:10 +1300)]
Merge remote branch 'kc/new/bug_5236' into kcmaster

11 years agoFix for Bug 5236 - "hide my tags" link does nothing
Owen Leonard [Thu, 28 Oct 2010 13:23:11 +0000 (09:23 -0400)]
Fix for Bug 5236 - "hide my tags" link does nothing

Removing the link. The suggested functionality doesn't
seem useful.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoEnhancement 5074 (Adding possibility to cleanup_database.pl to purge only older sessi...
Marcel de Rooy [Thu, 28 Oct 2010 13:05:20 +0000 (09:05 -0400)]
Enhancement 5074 (Adding possibility to cleanup_database.pl to purge only older sessions) [UPDATED for master]

Currently, the misc/cronjobs script cleanup_database truncates the session table (deleting all records, including active sessions).
With an additional parameter sessdays, this behavior could be changed or (perhaps better) extended. If the parameter sessdays is passed along with a number of days, the script only deletes older session records. This is accomplished by examining the values of lasttime, atime or ctime in the record.
So, calling the script like:
  ./cleanup_database.pl -v -sessions -sessdays 7
will only delete sessions records older than 7 days. The "old style" call
  ./cleanup_database.pl -v -sessions
still works too and truncates the table as before.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoMerge remote branch 'galen/bug5308' into bug_5308
Chris Cormack [Mon, 1 Nov 2010 19:52:43 +0000 (08:52 +1300)]
Merge remote branch 'galen/bug5308' into bug_5308

11 years agobug 5301: improve escaping of XML characters in bib output
Galen Charlton [Wed, 27 Oct 2010 12:24:04 +0000 (08:24 -0400)]
bug 5301: improve escaping of XML characters in bib output

<, >, ', or " in an item call number will no longer make
the bib displays break when using XSLT mode.

Added a new routine to C4::Koha, xml_escape(), to implement
converting &, <, >, ', and " to their corresponding
entities.

Patch loosely based on work done by Daniel Latrémolière <daniel.latremoliere@bulac.fr>

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5318: fix value of r4 rank weight
Galen Charlton [Wed, 27 Oct 2010 12:24:03 +0000 (08:24 -0400)]
bug 5318: fix value of r4 rank weight

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoremove unused template include
Galen Charlton [Wed, 27 Oct 2010 11:48:22 +0000 (07:48 -0400)]
remove unused template include

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5308: add foreign key constraints as well
Galen Charlton [Mon, 1 Nov 2010 12:23:35 +0000 (08:23 -0400)]
bug 5308: add foreign key constraints as well

Follows up on previous patch to require that routing
list entries be linked to subscriptions and patrons.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 5308: subscriptionroutinglist more strict
Srdjan Jankovic [Fri, 15 Oct 2010 00:58:00 +0000 (13:58 +1300)]
bug 5308: subscriptionroutinglist more strict

borrowernumber and subscriptionid NOT NULL, UNIQUE(subscriptionid, borrowernumber)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoMerge remote branch 'kc/new/background_jobs_tested' into kcmaster
Chris Cormack [Mon, 1 Nov 2010 08:03:06 +0000 (21:03 +1300)]
Merge remote branch 'kc/new/background_jobs_tested' into kcmaster

11 years agoMerge branch 'signoffs' into kcmaster
Chris Cormack [Mon, 1 Nov 2010 07:52:42 +0000 (20:52 +1300)]
Merge branch 'signoffs' into kcmaster

11 years agoBug 5227 [3.4] Enhance the label batch edit interface
Chris Nighswonger [Tue, 26 Oct 2010 13:10:57 +0000 (09:10 -0400)]
Bug 5227 [3.4] Enhance the label batch edit interface

This patch adds the ability to enter items into label batches via
barcode scanning

Work sponsored by Tamil - http://www.tamil.fr

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 5223, 'related subjects' should read 'subjects'
Owen Leonard [Tue, 26 Oct 2010 13:28:50 +0000 (09:28 -0400)]
Fix for Bug 5223, 'related subjects' should read 'subjects'

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 4261 - keyword mapping should show which framework the map is for
Owen Leonard [Tue, 26 Oct 2010 13:00:51 +0000 (09:00 -0400)]
Fix for Bug 4261 - keyword mapping should show which framework the map is for

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agohistory updates - recent releases
Galen Charlton [Mon, 1 Nov 2010 02:35:12 +0000 (22:35 -0400)]
history updates - recent releases

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5327: follow-up to fix SIP tests
Galen Charlton [Sun, 31 Oct 2010 22:25:47 +0000 (18:25 -0400)]
bug 5327: follow-up to fix SIP tests

* removed t/SIP_SIPServer.t - despite the file name,
  C4/SIP/SIPserver.pm is not actually a module and
  cannot be 'used' or 'required'
* set module search path so that t/SIP_ILS.t and
  t/SIP_Sip.t will pass

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5327: More basic unit tests for C4 modules
Katrin Fischer [Sun, 31 Oct 2010 22:25:46 +0000 (18:25 -0400)]
Bug 5327: More basic unit tests for C4 modules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoHistory updates
Chris Cormack [Sun, 31 Oct 2010 22:25:21 +0000 (18:25 -0400)]
History updates

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoremove extraneous semicolon
Galen Charlton [Sun, 31 Oct 2010 04:46:39 +0000 (00:46 -0400)]
remove extraneous semicolon

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoUpdated links in Main Page Help
Brian Engard [Sun, 31 Oct 2010 04:46:38 +0000 (00:46 -0400)]
Updated links in Main Page Help

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5327: Add unit test for ItemType.pm
Nate Curulla [Sun, 31 Oct 2010 09:15:22 +0000 (05:15 -0400)]
Bug 5327: Add unit test for ItemType.pm

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 2567: let 008/15-17 and 008/24-27 be set
Galen Charlton [Mon, 25 Oct 2010 14:16:19 +0000 (10:16 -0400)]
bug 2567: let 008/15-17 and 008/24-27 be set

Fixes bug where the MARC21 008 plugin was falsely
claiming that it set the illustration and nature of
contents positions by deriving it from other fields
in the bib records.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agotweak wording of merge target
Galen Charlton [Sat, 30 Oct 2010 05:13:23 +0000 (01:13 -0400)]
tweak wording of merge target

Since the merge functionality is for merging biblio
records, not items, made the language more precise.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoadd missing help file for merging records
Nicole Engard [Sat, 30 Oct 2010 05:13:22 +0000 (01:13 -0400)]
add missing help file for merging records

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agounit test stub for Z3950.pm
Daniel Grobani [Sat, 30 Oct 2010 02:44:27 +0000 (22:44 -0400)]
unit test stub for Z3950.pm

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoCreate Unit Test for ImportBatch
Brian Engard [Sat, 30 Oct 2010 03:39:26 +0000 (23:39 -0400)]
Create Unit Test for ImportBatch

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoMerge remote branch 'kc/new/bug5075' into kcmaster
Chris Cormack [Sat, 30 Oct 2010 07:32:45 +0000 (20:32 +1300)]
Merge remote branch 'kc/new/bug5075' into kcmaster

11 years agobug 5146: patron import files require header row
Galen Charlton [Thu, 28 Oct 2010 11:57:32 +0000 (07:57 -0400)]
bug 5146: patron import files require header row

Fixed help text on this point as well as options for
supplying dates in the input file.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5327: Add basic unit tests to some C4 modules
Magnus Enger [Sat, 30 Oct 2010 04:42:59 +0000 (00:42 -0400)]
Bug 5327: Add basic unit tests to some C4 modules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5327: Add basic unit tests to some C4 modules
Katrin Fischer [Sat, 30 Oct 2010 03:53:45 +0000 (23:53 -0400)]
Bug 5327: Add basic unit tests to some C4 modules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agocreate unit test files
Nicole Engard [Sat, 30 Oct 2010 03:41:25 +0000 (23:41 -0400)]
create unit test files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoAdding a simple test for Service.pm
Liz Rea [Sat, 30 Oct 2010 02:44:26 +0000 (22:44 -0400)]
Adding a simple test for Service.pm

At the advisement of the great Chris Cormack. (thanks for the lesson)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5322 - Added pwgen dependency
Robin Sheat [Sat, 30 Oct 2010 01:23:43 +0000 (21:23 -0400)]
Bug 5322 - Added pwgen dependency

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5309: tweak so that background progress doesn't exit immediately
Galen Charlton [Tue, 26 Oct 2010 16:14:46 +0000 (12:14 -0400)]
bug 5309: tweak so that background progress doesn't exit immediately

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agofix use of outdated boilerplate
Galen Charlton [Tue, 26 Oct 2010 15:28:21 +0000 (11:28 -0400)]
fix use of outdated boilerplate

* New code *must* have an accurate copyright statement;
  it isn't 2000-2002 any more.
* Enable warnings in new code, don't do

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 5309: Adjust progres bar
Srdjan Jankovic [Fri, 15 Oct 2010 00:53:11 +0000 (13:53 +1300)]
bug 5309: Adjust progres bar

Also added some test facilities
wr73785

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug5027: skip unticked checkboxes when submitting in the background.
Srdjan Jankovic [Tue, 12 Oct 2010 17:03:26 +0000 (13:03 -0400)]
bug5027: skip unticked checkboxes when submitting in the background.

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoFix for Bug 5075 - Terms not highlighted w/ xslt on
Owen Leonard [Thu, 9 Sep 2010 16:07:44 +0000 (12:07 -0400)]
Fix for Bug 5075 - Terms not highlighted w/ xslt on

- XSLT didn't contain the class markup which acts as a hook
  for the JavaScript highlighting system.
- Standard results page also contained a typo which
  prevented data other than title and author from
  being highlighted

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoFix for Bug 5223, 'related subjects' should read 'subjects'
Owen Leonard [Wed, 15 Sep 2010 20:26:21 +0000 (16:26 -0400)]
Fix for Bug 5223, 'related subjects' should read 'subjects'

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 5227 [3.4] Enhance the label batch edit interface
Chris Nighswonger [Sat, 25 Sep 2010 15:14:14 +0000 (17:14 +0200)]
Bug 5227 [3.4] Enhance the label batch edit interface

This patch adds the ability to enter items into label batches via
barcode scanning

Work sponsored by Tamil - http://www.tamil.fr

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoFix for Bug 4261 - keyword mapping should show which framework the map is for
Owen Leonard [Tue, 12 Oct 2010 00:56:41 +0000 (20:56 -0400)]
Fix for Bug 4261 - keyword mapping should show which framework the map is for

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoFix for Bug 5254 - no need to scroll left to right on acq z search
Owen Leonard [Wed, 6 Oct 2010 16:13:02 +0000 (12:13 -0400)]
Fix for Bug 5254 - no need to scroll left to right on acq z search

- Adding inline preview/import menu to match cataloging z39.50 search
- Improving behavior of inline menu on both pages
- Adding white space to ISBN/ISSN output on both pages to allow
  line breaks, improving table width and horizontal scrolling.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 5235 : circ receipt should include name
Nicole Engard [Tue, 21 Sep 2010 12:10:34 +0000 (08:10 -0400)]
bug 5235 : circ receipt should include name

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 5315: Remove references to obsolete variable nbstatements
Colin Campbell [Fri, 22 Oct 2010 13:08:57 +0000 (14:08 +0100)]
Bug 5315: Remove references to obsolete variable nbstatements

Trying to see the wood from the trees

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 3211: fix some errors that crept into the cleanup
Galen Charlton [Mon, 25 Oct 2010 15:04:46 +0000 (11:04 -0400)]
bug 3211: fix some errors that crept into the cleanup

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoFurther fixes for Bug 3211, cataloging value plugin forms should be valid XHTML
Owen Leonard [Mon, 26 Jul 2010 16:35:56 +0000 (12:35 -0400)]
Further fixes for Bug 3211, cataloging value plugin forms should be valid XHTML

- Adding page heading
- Adding "Cancel" link to close popup
- Correctly marking up <label> <input> pairs
- Correctly escaping JavaScript blocks
- General markup corrections

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 5128: fix syntax errors in previous patch
Galen Charlton [Fri, 22 Oct 2010 12:19:45 +0000 (08:19 -0400)]
bug 5128: fix syntax errors in previous patch

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>