koha.git
13 years agoSort libraries by name in holds queue's select input.
Ryan Higgins [Thu, 11 Sep 2008 18:17:24 +0000 (13:17 -0500)]
Sort libraries by name in holds queue's select input.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoChange missing from previous commit re:Bug 2600.
Owen Leonard [Thu, 11 Sep 2008 14:55:52 +0000 (09:55 -0500)]
Change missing from previous commit re:Bug 2600.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoMarkup correction; Fix for Bug 2600, "HTML tags in titles not escaped in list of...
Owen Leonard [Thu, 11 Sep 2008 14:54:04 +0000 (09:54 -0500)]
Markup correction; Fix for Bug 2600, "HTML tags in titles not escaped in list of returned items."

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoRefining keyboard shortcuts javascript.
Owen Leonard [Thu, 11 Sep 2008 14:53:48 +0000 (09:53 -0500)]
Refining keyboard shortcuts javascript.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoSome formatting fixes for bookcount.tmpl and issuehistory.tmpl. Linking to moredetail...
Owen Leonard [Wed, 10 Sep 2008 19:02:20 +0000 (14:02 -0500)]
Some formatting fixes for bookcount.tmpl and issuehistory.tmpl. Linking to moredetail.pl from issuehistory.pl (just as barcode on detail.pl links to moredetail.pl).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2596: remove URL escaping added by previous patch
Galen Charlton [Wed, 17 Sep 2008 02:58:13 +0000 (21:58 -0500)]
bug 2596: remove URL escaping added by previous patch

If URL in an href comes from a MARC record, it should not
be URL-escaped - otherwise, link is interpreted as relative
to MARCdetail.pl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix for Bug 2596, "restore ability to hyperlink URL fields in MARC detail display"
Owen Leonard [Wed, 10 Sep 2008 13:11:07 +0000 (08:11 -0500)]
Fix for Bug 2596, "restore ability to hyperlink URL fields in MARC detail display"

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix for Bug 2592, "hyphens being added to marc view isbn." Also removing truncation...
Owen Leonard [Tue, 9 Sep 2008 20:21:07 +0000 (15:21 -0500)]
Fix for Bug 2592, "hyphens being added to marc view isbn." Also removing truncation of subfield descriptions.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2588: fixed several links to open in new window when OPACURLOpenInNewWindow is ON
Danny Bouman [Tue, 9 Sep 2008 20:05:35 +0000 (16:05 -0400)]
bug 2588: fixed several links to open in new window when OPACURLOpenInNewWindow is ON

Fixed several links on the OPAC Detail page to open in a new window when the OPACURLOpenInNewWindow system preference is ON.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoCan't escape title variable as HTML because of search term highlighting.
Owen Leonard [Tue, 9 Sep 2008 19:54:04 +0000 (14:54 -0500)]
Can't escape title variable as HTML because of search term highlighting.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoTrying again: Standardizing styling of error messages; other markup corrections.
Owen Leonard [Tue, 9 Sep 2008 19:53:49 +0000 (14:53 -0500)]
Trying again: Standardizing styling of error messages; other markup corrections.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug Fixing : 2581 Problem With HomeBranchOrHoldingBranch (count items management)
Henri-Damien LAURENT [Thu, 4 Sep 2008 14:34:41 +0000 (16:34 +0200)]
Bug Fixing : 2581 Problem With HomeBranchOrHoldingBranch (count items management)

Using $item->{$hbranch} rather than $item->{homebranch}

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBugs 2541 and 2587 - AddIssue must return date object as intended.
Joe Atzberger (siptest [Thu, 11 Sep 2008 03:30:04 +0000 (22:30 -0500)]
Bugs 2541 and 2587 - AddIssue must return date object as intended.

SIP actually relied on the AddIssue return that was not reliable.
AddRenew also updated to return C4::Dates object for datedue.

Please note, any running SIPServer will have to be restarted
*immediately* after applying this patch, because although Koha
C4 behaves as normal, the SIP server runs as a Net::Server with
components cached.  Changes will not be applied until SIPServer
restarts, and so checkout actions may fail until then.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2594: fixing SQL statement to populate patron information in offline circulation db
Andrew Moore [Tue, 9 Sep 2008 17:51:35 +0000 (12:51 -0500)]
bug 2594: fixing SQL statement to populate patron information in offline circulation db

The offline circulation tool can use all of the patron information, not just their ID
numbers. This patch populates the offline circulation database with patron information.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofix extra <td> introduced in previous patch
Galen Charlton [Tue, 9 Sep 2008 16:16:59 +0000 (11:16 -0500)]
fix extra <td> introduced in previous patch

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agocommenting out debug warns
Galen Charlton [Tue, 9 Sep 2008 16:08:07 +0000 (11:08 -0500)]
commenting out debug warns

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoCorrection to previous commit, removing debugging.
Owen Leonard [Tue, 9 Sep 2008 15:54:23 +0000 (10:54 -0500)]
Correction to previous commit, removing debugging.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFormatting itemtype icon section with tabs to match authorized value interface.
Owen Leonard [Tue, 9 Sep 2008 15:26:48 +0000 (10:26 -0500)]
Formatting itemtype icon section with tabs to match authorized value interface.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoRemove double conditional, fix one FIXME.
Joe Atzberger [Mon, 8 Sep 2008 17:49:40 +0000 (12:49 -0500)]
Remove double conditional, fix one FIXME.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoMinor cleanup, updated POD.
Joe Atzberger [Mon, 8 Sep 2008 17:49:39 +0000 (12:49 -0500)]
Minor cleanup, updated POD.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoA few more en-US spelling corrections; Markup corrections; Standardizing on "email...
Owen Leonard [Tue, 9 Sep 2008 15:26:40 +0000 (10:26 -0500)]
A few more en-US spelling corrections; Markup corrections; Standardizing on "email" instead of "e-mail"; Copying isbn-formatting from opac-detail.pl to detail.pl;

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2585: fix search links for names (XSLT OPAC display)
Galen Charlton [Fri, 5 Sep 2008 15:52:20 +0000 (10:52 -0500)]
bug 2585: fix search links for names (XSLT OPAC display)

Fix malformed OPAC search syntax that caused this bug:

When using the default stylesheet for MARC21 XSLT OPAC details display, the
search links for name headings (from 100, 700, 710, 710, 111, and 711) that are
linked to authority records don't work.  When the user clicks on such a link,
they are directed to the advanced search form instead of the search results.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoCorrect application of noissues flag in SIP.
Joe Atzberger (siptest [Fri, 5 Sep 2008 22:50:15 +0000 (17:50 -0500)]
Correct application of noissues flag in SIP.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug2580: category name and home library will now correctly display on all patron...
Danny Bouman [Thu, 4 Sep 2008 15:50:58 +0000 (11:50 -0400)]
bug2580: category name and home library will now correctly display on all patron tabs

This patch fixes several improperly named variables and includes the home library variable on the pages that were missing it. The category
description was added to the GetMemberDetails function since a couple of the pages using that function required the variable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug fix 2590 :
Henri-Damien LAURENT [Mon, 8 Sep 2008 15:45:07 +0000 (17:45 +0200)]
bug fix 2590 :

seems that when itemtypeimagelocation returns undef, the hash is messed up.
put it at the end of the hash and everything is fine.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobugfix: need to return something if an itemtype doesn't have an image
Michael Hafen [Thu, 28 Aug 2008 20:58:21 +0000 (14:58 -0600)]
bugfix: need to return something if an itemtype doesn't have an image

I noticed that on the search pages if an itemtype doesn't have an image it's information doesn't make it out the the template.  I don't understand why, but this fixes it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofix for bug 2577: Cannot delete patron in IE
Jesse Weaver [Tue, 2 Sep 2008 22:53:27 +0000 (17:53 -0500)]
fix for bug 2577: Cannot delete patron in IE

Internet Explorer seems to have a problem with JS array and object constructors that have a comma at the end. There may be other JavaScript files that have this problem.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoRemove unnecessary EXPR.
Joe Atzberger [Tue, 2 Sep 2008 23:48:15 +0000 (18:48 -0500)]
Remove unnecessary EXPR.

There are two problems with this EXPR:
 (1) It's unnecessary, and
 (2) It's an EXPR.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoHTML fixes for matching-rules.tmpl
Galen Charlton [Wed, 3 Sep 2008 01:20:28 +0000 (20:20 -0500)]
HTML fixes for matching-rules.tmpl

* maxnorms, maxoffset => maxlength
* no escape attribute in <input> elements

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoHTML validation adjustments to about.pl
Joe Atzberger [Wed, 3 Sep 2008 20:49:54 +0000 (15:49 -0500)]
HTML validation adjustments to about.pl

Corrects the Tidy errors:
line 428 column 19 - Error: "tr" not finished but containing element ended
line 428 column 19 - Error: end tag for "tr" omitted, but OMITTAG NO was specified
line 426 column 25 - Info: start tag was here
line 452 column 31 - Error: end tag for "strong" omitted, but OMITTAG NO was specified
line 452 column 12 - Info: start tag was here
line 518 column 17 - Error: document type does not allow element "ul" here; missing one of "object", "applet", "map", "iframe", "button", "ins", "del" start-tag
line 525 column 17 - Error: document type does not allow element "ul" here; missing one of "object", "applet", "map", "iframe", "button", "ins", "del" start-tag

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2582 [2/2]: fix NULL issues.issuedate
Galen Charlton [Thu, 4 Sep 2008 17:23:47 +0000 (12:23 -0500)]
bug 2582 [2/2]: fix NULL issues.issuedate

Corrects loans whose issuedate was set to NULL
during a renewal as follows:

* First, tries to extract the loan date from
  the statistics table.
* For any remaining rows,  sets the issue date
  to the date of the last renewal.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2582 [1/2]: don't set issuedate during renewal
Galen Charlton [Thu, 4 Sep 2008 17:23:46 +0000 (12:23 -0500)]
bug 2582 [1/2]: don't set issuedate during renewal

Changed so that issues.issuedate is never modified
during a renewal, since that column records the original
date of the loan.  Changed the name and interpretation
of the $issuedate parameter of AddRenewal() to
$lastreneweddate, allowing (e.g.) offline circulation
to set the date of the renewal without changing the
issue date.

As a result of the original bug, issues.issuedate can be
set to NULL for loans that were renewed via the OPAC,
self checkout, or the staff interface when explicitly
renewing a loan.  Loans that were renewed by checking
the item out to the same patron will have the issue date
changed to the date of the last renewal.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoremove debug warn
Galen Charlton [Tue, 2 Sep 2008 21:52:06 +0000 (16:52 -0500)]
remove debug warn

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoValidation fix, include required "type" in link tag.
Joe Atzberger [Tue, 2 Sep 2008 22:39:12 +0000 (17:39 -0500)]
Validation fix, include required "type" in link tag.

This removes validation warnings like:
  Warning: <link> inserting "type" attribute

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoDocumentation update (test-single not single-test)
Joe Atzberger [Tue, 2 Sep 2008 23:08:34 +0000 (18:08 -0500)]
Documentation update (test-single not single-test)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug fixing : 2516
Henri-Damien LAURENT [Fri, 29 Aug 2008 16:15:20 +0000 (18:15 +0200)]
Bug fixing : 2516

There was a problem with names ordering in circ/circulation.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFixing markup errors, tweaking show/hide javascript.
Owen Leonard [Fri, 29 Aug 2008 14:06:03 +0000 (09:06 -0500)]
Fixing markup errors, tweaking show/hide javascript.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoMore markup corrections for better validation.
Owen Leonard [Fri, 29 Aug 2008 14:06:11 +0000 (09:06 -0500)]
More markup corrections for better validation.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoPutting icon sets into tabs. Makes the interface more compact, and much better when...
Owen Leonard [Fri, 29 Aug 2008 14:05:52 +0000 (09:05 -0500)]
Putting icon sets into tabs. Makes the interface more compact, and much better when editing authorized values for which icons are inappropriate.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2569: added the zipcode to display along with the patron address
Danny Bouman [Thu, 28 Aug 2008 19:22:39 +0000 (15:22 -0400)]
bug 2569: added the zipcode to display along with the patron address

Added the zipcode to display along with the patron address when you are viewing a Patron from the intranet.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofixing permission
Galen Charlton [Tue, 2 Sep 2008 21:34:41 +0000 (16:34 -0500)]
fixing permission

13 years agochange link to moredetail.pl. In other places it's called with itemnumber=
Michael Hafen [Fri, 22 Aug 2008 23:26:17 +0000 (17:26 -0600)]
change link to moredetail.pl. In other places it's called with itemnumber=

Change the link to moredetail.pl from item= to itemnumber=
I saw the link on boraccount.pl as itemnumber= and thought it should be that way here too.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdd/Change link to item details (catalogue/moredetail.pl) for circulation and patron...
Michael Hafen [Fri, 22 Aug 2008 23:24:43 +0000 (17:24 -0600)]
Add/Change link to item details (catalogue/moredetail.pl) for circulation and patron details

This adds the link to item details to circulation.pl
and changes the link on member details to include the itemnumber and #item... in the link.

Forgot the returns.pl.  Will do that in the next patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdded link to catalogue/moredetail.pl on the returns page for each returned item
Michael Hafen [Fri, 22 Aug 2008 23:24:44 +0000 (17:24 -0600)]
Added link to catalogue/moredetail.pl on the returns page for each returned item

Had to add itemnumber to the hash of returned item information.

Links to moredetail.pl with itemnumber and #item in the url.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agomodification to show the library and not the username of the person at OPAC.
Henri-Damien LAURENT [Thu, 28 Aug 2008 15:48:13 +0000 (17:48 +0200)]
modification to show the library and not the username of the person at OPAC.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2568: set default value of intranetuserjs to blank
Galen Charlton [Thu, 28 Aug 2008 13:46:04 +0000 (08:46 -0500)]
bug 2568: set default value of intranetuserjs to blank

The intranetuserjs syspref allows a Koha administrator
to insert arbitrary JavaScript into the staff page header.
Now that this syspref is functional again, this patch
changes the installation scripts so that the default
value is blank - any JavaScript we ship with Koha should
be in the templates, not in a syspref.

Documentation changes: none per se.  However, I do want to
point out that the intranetuserjs syspref is a bit of a
dangerous one - enter a value with incorrect syntax, and
you could make it difficult to access the staff interface -
and should probably be marked as an advanced option.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix for Bug 2557, "Guarantor information - error messaee when clicking borrower#...
Owen Leonard [Tue, 26 Aug 2008 19:06:02 +0000 (14:06 -0500)]
Fix for Bug 2557, "Guarantor information - error messaee when clicking borrower# link." Also correcting a couple of minor markup errors.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFixing tablesorter, display of renew links
Owen Leonard [Mon, 25 Aug 2008 16:14:36 +0000 (11:14 -0500)]
Fixing tablesorter, display of renew links

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoSpelling corrections: organisation->organization, authorise->authorize, catalogue...
Owen Leonard [Mon, 25 Aug 2008 18:38:56 +0000 (13:38 -0500)]
Spelling corrections: organisation->organization, authorise->authorize, catalogue->catalog

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoIf itemnumber is sent to catalogue/moredetail.pl use it
Michael Hafen [Fri, 29 Aug 2008 19:36:51 +0000 (13:36 -0600)]
If itemnumber is sent to catalogue/moredetail.pl use it

If itemnumber is part of the url for catalogue/moredetail.pl
put it to use.
This happens in members/boraccount.pl if a fine is attached to a
barcode.

This patch makes moredetail.pl show only the item specified by
itemnumber.

Implements some changes to the patch suggested on
patches@koha.org
give visual cue on UI and a link out.
More friendly pruning of the other items.

Thanks to Galen Charlton and Joe Atzberger

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoRevert "If itemnumber is sent to catalogue/moredetail.pl use it"
Galen Charlton [Tue, 2 Sep 2008 20:36:02 +0000 (15:36 -0500)]
Revert "If itemnumber is sent to catalogue/moredetail.pl use it"

Applied wrong version of patch.  Oops.

This reverts commit 9eb1465b2874a8a65195065bed083d26614ca287.

13 years agoFines fixes: apparent problems with fines prevent processing.
Joe Atzberger [Tue, 26 Aug 2008 03:57:01 +0000 (22:57 -0500)]
Fines fixes: apparent problems with fines prevent processing.

CalcFine returned values that mismatched expectations in fines.pl.

fines.pl refactored: added debugging, prevent needless recreation of
Calendar objects by storing them in hash by branch.
Still outstanding problems with fines, including the output of a field
that has no other references in Koha (so is always undef) and the
incorrect description of FinesMode.

Calendar exported "new" erroneously.  I also cleaned up the queries to
avoid needlessly compiling additional statement handles.

Please test and consider application to 3.0 maintenance.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoIf itemnumber is sent to catalogue/moredetail.pl use it
Michael Hafen [Thu, 21 Aug 2008 21:55:27 +0000 (15:55 -0600)]
If itemnumber is sent to catalogue/moredetail.pl use it

If itemnumber is part of the url for catalogue/moredetail.pl put it to use.
This happens in members/boraccount.pl if a fine is attached to a barcode.

This patch makes moredetail.pl show only the item specified by itemnumber.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2466: fix clearing item field
Galen Charlton [Tue, 26 Aug 2008 15:33:00 +0000 (10:33 -0500)]
bug 2466: fix clearing item field

When editing an item in the cataloging and serials
item editors, clearing a field now works.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2466: regression test
Galen Charlton [Tue, 26 Aug 2008 15:32:59 +0000 (10:32 -0500)]
bug 2466: regression test

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoUsage option correction (-h not -n)
Joe Atzberger [Wed, 27 Aug 2008 18:32:31 +0000 (13:32 -0500)]
Usage option correction (-h not -n)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoMinor SIP cleanup, conditionalize warnings.
Joe Atzberger [Wed, 27 Aug 2008 14:44:28 +0000 (09:44 -0500)]
Minor SIP cleanup, conditionalize warnings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2419: require Exporter
Joe Atzberger [Wed, 27 Aug 2008 14:32:26 +0000 (09:32 -0500)]
Bug 2419: require Exporter

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2552: correct issue history display
Galen Charlton [Mon, 25 Aug 2008 17:13:38 +0000 (12:13 -0500)]
bug 2552: correct issue history display

The loan history for a bib can be incorrect if the bib's
biblioitemnumber is not the same as its biblionumber.
This was due to a bad join in GetBiblioIssues().

Credit to Michael Hafen for patching a similar bug,
which inspired me to check for other bad joins.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoUpdate INSTALL.debian to mention a2dissite default
MJ Ray [Tue, 26 Aug 2008 23:22:14 +0000 (00:22 +0100)]
Update INSTALL.debian to mention a2dissite default

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoStyle correction in member entry form; Enabling intranetuserjs in doc-head-close...
Owen Leonard [Fri, 22 Aug 2008 20:41:33 +0000 (15:41 -0500)]
Style correction in member entry form; Enabling intranetuserjs in doc-head-close.inc.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofix number two for bug 1204: Lists of issues and overdues on opac-user.pl
Jesse Weaver [Mon, 25 Aug 2008 16:51:25 +0000 (11:51 -0500)]
fix number two for bug 1204: Lists of issues and overdues on opac-user.pl

This makes opac-user.pl sort the output from GetPendingIssues itself, by descend
ing due date.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug: bookcount.pl pulls wrong title. Problem is sql joins on wrong columns
Michael Hafen [Fri, 22 Aug 2008 17:12:47 +0000 (11:12 -0600)]
bug: bookcount.pl pulls wrong title. Problem is sql joins on wrong columns

the sql seems to assume that biblionumber and biblioitemnumber are always the same, which in my case they aren't.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix for Bug 2424: Altering layout of advanced search screen to make it compatible...
Owen Leonard [Wed, 30 Jul 2008 13:24:20 +0000 (08:24 -0500)]
Fix for Bug 2424: Altering layout of advanced search screen to make it compatible with Internet Explorer 6. Documentarians: this will require an updated screenshot.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix for Bug 2548, "Links to Reports that No Longer Exist in Side Menu." Some links...
Owen Leonard [Mon, 25 Aug 2008 16:14:27 +0000 (11:14 -0500)]
Fix for Bug 2548, "Links to Reports that No Longer Exist in Side Menu." Some links were left behind after removal from reports-home.tmpl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoSpelling correction. Fixes Bug 2501.
Owen Leonard [Mon, 25 Aug 2008 16:14:45 +0000 (11:14 -0500)]
Spelling correction. Fixes Bug 2501.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2545: fix XSLTDetailsDisplay
Galen Charlton [Fri, 22 Aug 2008 00:59:45 +0000 (19:59 -0500)]
bug 2545: fix XSLTDetailsDisplay

Corrected so that when XSLTDetailsDisplay is ON but
XSLTResultsDisplay is OFF, the portion of the OPAC bib
details page that's derived from the MARC bib record
is no longer missing.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix itemtype image problem in moremember.pl
Jesse Weaver [Fri, 22 Aug 2008 15:54:31 +0000 (10:54 -0500)]
Fix itemtype image problem in moremember.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2509: fix file permissions
Galen Charlton [Thu, 21 Aug 2008 21:39:45 +0000 (16:39 -0500)]
bug 2509: fix file permissions

Following suggestion by Vincent Danjean for Debian
packaging, 0755 -> 0644 for non-executable
files.

Also removed shebang from a few modules in C4.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2540: allow download of report
Galen Charlton [Thu, 21 Aug 2008 15:48:31 +0000 (10:48 -0500)]
bug 2540: allow download of report

$error return C4::Reports::execute_query is
always defined.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofix for bug 1101: Renew All for the OPAC
Jesse Weaver [Thu, 21 Aug 2008 16:52:11 +0000 (11:52 -0500)]
fix for bug 1101: Renew All for the OPAC

This adds a Renew All form to the OPAC, and updates opac-renew.pl to take multiple item= parameters.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoissues_stats returns empty results if row/column = items.ccode/datetime
Joe Atzberger [Wed, 20 Aug 2008 20:40:44 +0000 (15:40 -0500)]
issues_stats returns empty results if row/column = items.ccode/datetime

Also added ESCAPE="HTML" to column/row headers because users may define
collections that include ampersands, like:
    B&T Rental--Fiction
The Tidy error associated would be:
    line 574 column 29 - Error: general entity "T" not defined and no default entity

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofix for bug 1771: Template errors with remote itemtype image
Jesse Weaver [Wed, 20 Aug 2008 18:21:50 +0000 (13:21 -0500)]
fix for bug 1771: Template errors with remote itemtype image

This adds a new function, getitemtypeimagelocation, that returns the image
unmodified for absolute urls and returns the proper intranet or opac path
otherwise. It also updates all of the relevant files to use that function.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofix for bug 2488: OPACItemsResultsDisplay/singlebranchmode
Jesse Weaver [Tue, 19 Aug 2008 22:11:20 +0000 (17:11 -0500)]
fix for bug 2488: OPACItemsResultsDisplay/singlebranchmode

This patch changes the template slighly so that these two system preferences do not conflict.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix for minor error in shelfbrowser queries
Jesse Weaver [Tue, 19 Aug 2008 22:11:21 +0000 (17:11 -0500)]
Fix for minor error in shelfbrowser queries

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofix for bug 2477: Improve Speed of the Shelf Browser
Jesse Weaver [Tue, 19 Aug 2008 19:01:23 +0000 (14:01 -0500)]
fix for bug 2477: Improve Speed of the Shelf Browser

This patch updates the queries for the shelf browser in opac-detail.pl for a
slight performance gain. It also adds a param for dateformat to C4::Auth to
fix a warning.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoRemoving strange dot file
Vincent Danjean [Fri, 15 Aug 2008 19:19:01 +0000 (21:19 +0200)]
Removing strange dot file

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoStill fixing permission and first line of scripts
Vincent Danjean [Fri, 15 Aug 2008 20:49:36 +0000 (22:49 +0200)]
Still fixing permission and first line of scripts

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoNo 'BOM' marker for a script file
Vincent Danjean [Fri, 15 Aug 2008 19:06:19 +0000 (21:06 +0200)]
No 'BOM' marker for a script file

'#!' must be the first characters

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoShebang line must be the first of the file
Vincent Danjean [Fri, 15 Aug 2008 19:03:04 +0000 (21:03 +0200)]
Shebang line must be the first of the file

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdd support for DESTDIR
Vincent Danjean [Fri, 15 Aug 2008 18:29:55 +0000 (20:29 +0200)]
Add support for DESTDIR

Distributions (such as Debian) needs a staging area when building the package

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2503: fix minor XHTML errors
Galen Charlton [Thu, 21 Aug 2008 00:26:59 +0000 (19:26 -0500)]
bug 2503: fix minor XHTML errors

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2503: comment out unneeded warns
Galen Charlton [Thu, 21 Aug 2008 00:23:46 +0000 (19:23 -0500)]
bug 2503: comment out unneeded warns

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2503: fix call to AddIssue()
Galen Charlton [Thu, 21 Aug 2008 00:21:08 +0000 (19:21 -0500)]
bug 2503: fix call to AddIssue()

The due date parameter must be a C4::Dates object,
not a date string.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2503: refactoring and bugfixing on create_koc_db.pl
Andrew Moore [Wed, 20 Aug 2008 16:21:52 +0000 (11:21 -0500)]
bug 2503: refactoring and bugfixing on create_koc_db.pl

This is the script that generates the patron and holdings database for the offline circ module. I
touched up a few parts of it:

* fixed the database syntax to squash a bug or two
* extracted some methods for readability and reuse
* added some documentation
* added a --file and --force command line argument
* made it die if DBD::SQLite is not present. That module is required for this feature.

Here's an example crontab line that will generate the borrowers.db file each midnight.

0 0 * * * create_koc_db.pl --file /tmp/borrowers.db

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2503: moving offline circulation db generator to misc/cronjobs directory
Andrew Moore [Wed, 20 Aug 2008 16:21:51 +0000 (11:21 -0500)]
bug 2503: moving offline circulation db generator to misc/cronjobs directory

This script generates a sqlite database of patron and holdings data for the offline circulation tool.
It's a cronjob, so it should go into misc/cronjobs

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdded offline circ sqlite database generator.
Kyle Hall [Wed, 20 Aug 2008 16:21:50 +0000 (11:21 -0500)]
Added offline circ sqlite database generator.

Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2503: updating process_koc.pl to interpret new versions of import file
Andrew Moore [Wed, 20 Aug 2008 16:21:49 +0000 (11:21 -0500)]
bug 2503: updating process_koc.pl to interpret new versions of import file

The file format for the .koc files has changed a few times, and this patch brings
us up to date with the current version.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2503: tests for C4::Circulation
Andrew Moore [Wed, 20 Aug 2008 16:21:48 +0000 (11:21 -0500)]
bug 2503: tests for C4::Circulation

I'm adding some tests for C4::Circulation methods that I'm altering
to allow the offline circulation tool to use C4::Circulation to upload
its data. These test a bit of the old functionality and try to show
that the new functionality does what I think it does.

C4::Circ::Addissue to tests issuedate
 these also test AddRenewal.
tests for C4::Circ::MarkIssueReturned

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2503: removing Force* subs and replacing them with calls to C4::Circulation subs
Andrew Moore [Wed, 20 Aug 2008 16:21:47 +0000 (11:21 -0500)]
bug 2503: removing Force* subs and replacing them with calls to C4::Circulation subs

The offline circulation file processor originally used its own methods to
insert circulation data. This patch takes advantage of the updated
C4::Circulation methods that allow us to specify dates in the past.
This makes the offline circulation file processor use C4::Circulation
functions instead of its own and removes the deprecated subs.

moving from ForceIssue to AddIssue
replacing ForceRenewal with AddRenewal
moving from ForceReturn to MarkIssueReturned
removing deprecated Force* subs
fixing a few bugs in process_koc.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2503: adding dates to some C4:Circulation methods to allow offline circulation...
Andrew Moore [Wed, 20 Aug 2008 16:21:46 +0000 (11:21 -0500)]
bug 2503: adding dates to some C4:Circulation methods to allow offline circulation tool to specify dates other than today

When uploading an offline circulation file, some actions may need to take place
in the past. This patch adds date parameters to some C4::Circulation methods
to allow us to set dates on them

added issuedate to C4::Circulation::AddIssue
adding issuedate to C4::Circulation::AddRenewal
adding returdate to C4::Circulation::MarkIssueReturned

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2503: documentation improvements in C4::Circulation
Andrew Moore [Wed, 20 Aug 2008 16:21:45 +0000 (11:21 -0500)]
bug 2503: documentation improvements in C4::Circulation

These are some documentation changes that I made to C4::Circulation as
I was writing tests for it.

moved around the docs for CanBookBeIssued. It was in the wrong spot in the file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoIntegrated version of the Koha Offline Circulation file uploader. It needs some testi...
Kyle Hall [Wed, 20 Aug 2008 16:21:44 +0000 (11:21 -0500)]
Integrated version of the Koha Offline Circulation file uploader. It needs some testing and cleanup, but it works.

Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2530 : create new date object in javascript function instead of modifying passed...
Ryan Higgins [Tue, 19 Aug 2008 18:51:09 +0000 (13:51 -0500)]
bug 2530 : create new date object in javascript function instead of modifying passed-in reference.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofix for bug 2528: installation fails with confusing error message
Jesse Weaver [Mon, 18 Aug 2008 17:37:55 +0000 (12:37 -0500)]
fix for bug 2528: installation fails with confusing error message

This makes the dns check happen earlier, and fail humanely if there is a problem.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug #2429, bad HTML from unclosed <head>.
Joe Atzberger [Mon, 18 Aug 2008 17:11:56 +0000 (12:11 -0500)]
Bug #2429, bad HTML from unclosed <head>.

Also some cleanup of opac-showmarc script including removing bogus
dependencies (DBI, CGI methods).  Should consider using C4::XSLT if
applicable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFixing a couple of minor markup issues.
Owen Leonard [Tue, 19 Aug 2008 15:08:13 +0000 (10:08 -0500)]
Fixing a couple of minor markup issues.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2527: avoid targeting of items on hold shelf
Galen Charlton [Fri, 15 Aug 2008 21:38:22 +0000 (16:38 -0500)]
bug 2527: avoid targeting of items on hold shelf

SQL fix to properly ensure that if an item is on
the hold shelf, it will not be used for request
targeting, which applies only to items that are
not already on the hold shelf.

Prior to this fix, when checking out an item on the
hold shelf that fills patron A's hold request, it
was possible for that request to not be marked as
filled if another patron had an item-level request
on the item; the second patron's request was
incorrectly targeted by that item.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2524: improving the submitted test reports
Andrew Moore [Fri, 15 Aug 2008 18:17:14 +0000 (13:17 -0500)]
Bug 2524: improving the submitted test reports

switching from 'prove' to 'perl' to run the test scripts when we're preparing
them to be submitted to smolder. Prove adds an additional summary at the end
of the test run which confuses the TAP parser in smolder. It thinks that an
additional test has been run, and it fails it.

Then, I added a '-' before the command in the Makefile. THat's so that even
if 'perl' returns a failing code (because some tess failed), the rest of the
rules are run and a report gets submitted. Othewise, only passing reports
get sent.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2525: fixing tests for misc/cronjobs/longoverdue.pl
Andrew Moore [Fri, 15 Aug 2008 16:40:05 +0000 (11:40 -0500)]
bug 2525: fixing tests for misc/cronjobs/longoverdue.pl

This patch fixes the tests so that they include the new required parameters for longoverdues.pl.

This patch also doesn't include a test script that accidently got in the last one.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>