koha.git
13 years agoFix for LL Bug 405: Syndetics Enhanced Content: some cover imags are being generated...
Joshua Ferraro [Thu, 5 Mar 2009 22:29:01 +0000 (16:29 -0600)]
Fix for LL Bug 405: Syndetics Enhanced Content: some cover imags are being generated as IMGs but show as broken images

Adds new template variable to test for enhanced content identifiers

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix for LL Bug 404: Syndetics Enhanced Content: Excerpts show with embedded HTML...
Joshua Ferraro [Thu, 5 Mar 2009 19:30:29 +0000 (13:30 -0600)]
Fix for LL Bug 404: Syndetics Enhanced Content: Excerpts show with embedded HTML tags and entity references

XMLout needed the NoEscape option set

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoSyndetics Enhancement: adds upc/oclc to the functions to retrive non-image data
Joshua Ferraro [Thu, 5 Mar 2009 16:10:06 +0000 (10:10 -0600)]
Syndetics Enhancement: adds upc/oclc to the functions to retrive non-image data

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoSyndetics and Amazon bugfix enhancements
Joshua Ferraro [Thu, 5 Mar 2009 00:48:41 +0000 (18:48 -0600)]
Syndetics and Amazon bugfix enhancements

This patch resolves a number of problems related to Enhanced Content:

1. Previously, there was no syspref for controlling whether or not to display
Amazon.com cover images apart from other content. This had the side effect
of preventing use of amazon.com content alongside use of another provider's
images. This patch introduces AmazonCoverImages and OPACAmazonCoverImages,
and changes the name of AmazonContent to AmazonEnabled.

So, for instance, you can now enable OPACAmazonSimilarItems yet utilize
SyndeticsCoverImages for displaying those similar items.

NOTE TO DOCUMENTATION TEAM: please update references to AmazonContent
and OPACAmazonContent to comply with the above.

2. Fixes some semantically incorrect uses of AmazonContent (now OPACAmazonEnabled)
on the OPAC side.

3. Resolves once and for all, the normalization of ISBN,UPC,EAN and OCLC numbers
for all enhanced content elements; These elements can be normalized using the
new functions in C4::Koha; I've replaced use of the various previously used
variables $xisbn,$norm_isbn,$clean_isbn, etc with $isbn, and the template
variable normalized_isbn.

We finally have a single, consistant place to retrieve normalize values for
these fields given a particular record.

4. Adds Syndetics attribution statements to display of all Syndetics content
'enhanced content provide by Syndetics' or 'Enhanced Description from Syndetics'

5. Adds an option to view the large cover image on the detail page on the OPAC
when using SyndeticsCoverImages; this option is controlled by a new system
preference: SyndeticsCoverImageSize which has two values: MC (medium) LC (large)

6. Adds UPC and OCLC numbers for Syndetics enhanced content queries especially
helpful for finding enhanced content for DVD and Music materials

7. Adds capability to display Syndetics images to opac-user for checkouts and overdues

8. Updates to systempreferences.sql, and updatedatabase.pl database revision 015

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoSecond patch to address LL Bug 367 Titles without ISBNs display "no cover image avail...
Joshua Ferraro [Mon, 16 Feb 2009 16:42:36 +0000 (10:42 -0600)]
Second patch to address LL Bug 367 Titles without ISBNs display "no cover image available" while titles with ISBNS that don't match a Syndetics cover display nothing

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdd Syndetics AuthorNotes, Awards, Series
Joshua Ferraro [Mon, 16 Feb 2009 16:28:00 +0000 (10:28 -0600)]
Add Syndetics AuthorNotes, Awards, Series

This patch also includes a new function to retrieve the index
page from Syndetics and parse it for available content prior to
retrieving content; this is done to speed up syndetics content
by not retrieving content that doesn't exist for an item. However,
Syndetics continues to be a very slow service compared to Amazon.com
and other enhanced content services

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix for LL bug 367 Titles without ISBNs display "no cover image available"
Joshua Ferraro [Thu, 12 Feb 2009 18:59:22 +0000 (12:59 -0600)]
Fix for LL bug 367 Titles without ISBNs display "no cover image available"

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdds Syndetics Reviews
Joshua Ferraro [Sun, 8 Feb 2009 18:59:21 +0000 (12:59 -0600)]
Adds Syndetics Reviews

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdds support for Syndetics Excerpts and Editions
Joshua Ferraro [Fri, 6 Feb 2009 22:52:27 +0000 (16:52 -0600)]
Adds support for Syndetics Excerpts and Editions

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdd Syndetics Summaries and TOC
Joshua Ferraro [Fri, 6 Feb 2009 20:34:32 +0000 (14:34 -0600)]
Add Syndetics Summaries and TOC

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdding Syndetics Cover Images to OPAC Detail Page, including shelf browser
Joshua Ferraro [Fri, 6 Feb 2009 19:31:54 +0000 (13:31 -0600)]
Adding Syndetics Cover Images to OPAC Detail Page, including shelf browser

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdds Syndetics Cover Images to Results Page on OPAC
Joshua Ferraro [Fri, 6 Feb 2009 19:11:06 +0000 (13:11 -0600)]
Adds Syndetics Cover Images to Results Page on OPAC

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdd System Prefs for Syndetics to Auth
Joshua Ferraro [Fri, 6 Feb 2009 19:06:47 +0000 (13:06 -0600)]
Add System Prefs for Syndetics to Auth

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoMove Amazon.pm to External/ directory
Joshua Ferraro [Fri, 6 Feb 2009 18:52:08 +0000 (12:52 -0600)]
Move Amazon.pm to External/ directory

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoDatabase Revisions for Syndetics Solutions Enhanced Content
Joshua Ferraro [Fri, 6 Feb 2009 18:27:16 +0000 (12:27 -0600)]
Database Revisions for Syndetics Solutions Enhanced Content

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix for Bug 3031, Standardize OPAC login form labels.
Owen Leonard [Wed, 11 Mar 2009 23:52:31 +0000 (18:52 -0500)]
Fix for Bug 3031, Standardize OPAC login form labels.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofix error introduced in a previous commit
Galen Charlton [Wed, 11 Mar 2009 15:28:44 +0000 (10:28 -0500)]
fix error introduced in a previous commit

Change to GetReservesFromBiblionumber() had effect
of causing all requests of constrainttype other
than 'o' to not be included in result.

while ($foo) {
    $bar or next;
    # do stuff
    # do other stuff
}

is not equivalent to

while ($foo) {
    if ($bar) {
        # do stuff
    }
    # do other stuff

}

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 3028: remove reservefix.pl cronjob
Galen Charlton [Wed, 11 Mar 2009 14:09:30 +0000 (09:09 -0500)]
bug 3028: remove reservefix.pl cronjob

Removed cronjob, which was written to work around
a bug in 2.2 that no longer applies and is specific
to a single library in any event.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoTest for LCCN splitting.
Joe Atzberger [Sat, 7 Mar 2009 00:27:50 +0000 (18:27 -0600)]
Test for LCCN splitting.

This test establishes what LCCN splitting is required to do
to be considered successful.  See Bug 2691.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoCorrecting delete patron button to use TMPL_VAR instead of DOM query. Fixes Bug 3014...
Owen Leonard [Sat, 7 Mar 2009 16:34:42 +0000 (10:34 -0600)]
Correcting delete patron button to use TMPL_VAR instead of DOM query. Fixes Bug 3014, Can't delete restricted patron from circulation screen.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix for Bug 3015: Check-in screen displays branch name inconsistently
Owen Leonard [Sat, 7 Mar 2009 17:41:50 +0000 (11:41 -0600)]
Fix for Bug 3015: Check-in screen displays branch name inconsistently

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoChanges to tabindex values to improve keyboard access.
Owen Leonard [Mon, 9 Mar 2009 13:38:06 +0000 (08:38 -0500)]
Changes to tabindex values to improve keyboard access.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoSort collection codes by description for dropdown.
Joe Atzberger [Mon, 9 Mar 2009 18:51:58 +0000 (13:51 -0500)]
Sort collection codes by description for dropdown.

Collection code descriptions were otherwise displaying in an
unsorted order.  The result was not readable for any sufficiently
large number of ccodes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix for Bug 3027, Hide RSS option in patron messaging. Also includes some markup...
Owen Leonard [Wed, 11 Mar 2009 13:24:57 +0000 (08:24 -0500)]
Fix for Bug 3027, Hide RSS option in patron messaging. Also includes some markup cleanup.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoCorrect perldoc
Joe Atzberger [Mon, 9 Mar 2009 18:51:57 +0000 (13:51 -0500)]
Correct perldoc

Indentations misformatted for code blocks.  Also updated reference to
GetBranchesLoop.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoUI tweaks to OPAC holds screen following addition of multiple holds functionality...
Owen Leonard [Mon, 9 Mar 2009 19:27:39 +0000 (14:27 -0500)]
UI tweaks to OPAC holds screen following addition of multiple holds functionality. Addition of subtitle and copy number to output.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2691 - LCCN split (for labels)
Joe Atzberger [Mon, 9 Mar 2009 20:19:31 +0000 (15:19 -0500)]
Bug 2691 - LCCN split (for labels)

This corresponds with the test I submitted earlier and essentially
overrides the partial improvement from Nighswonger under Bug 2500.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoResubmitting: tweaks to search results page, including using amazonisbn to pull cover...
Owen Leonard [Mon, 9 Mar 2009 19:51:25 +0000 (14:51 -0500)]
Resubmitting: tweaks to search results page, including using amazonisbn to pull cover image and inline display of itemtype images to improve display.

The previous method for displaying itemtype images relied on setting a background-image for a list item. This method didn't take into account the possibility of varying sizes for images, resulting in overlap with some images. This patch also includes some changes to improve readability of holdings information.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFixed a typo that kept branches out of the Advance Notice and Item Due notifications.
Daniel Sweeney [Mon, 9 Mar 2009 21:44:36 +0000 (16:44 -0500)]
Fixed a typo that kept branches out of the Advance Notice and Item Due notifications.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoResubmitting: fixes print statements with missing 'STDERR' in Auth_with_ldap.pm,
Mason James [Tue, 10 Mar 2009 01:50:53 +0000 (14:50 +1300)]
Resubmitting: fixes print statements with missing 'STDERR' in Auth_with_ldap.pm,

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #3025) multiple check-in of a multiple times reserved item go wrong
Nahuel ANGELINETTI [Tue, 10 Mar 2009 14:28:17 +0000 (15:28 +0100)]
(bug #3025) multiple check-in of a multiple times reserved item go wrong

This patch check that an item is not "Waiting" before do something in GetOtherReserves(because is the item is waiting, we don't need to do something).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2617: Add strict (and warnings), partial fix.
Joe Atzberger [Tue, 10 Mar 2009 21:41:00 +0000 (16:41 -0500)]
Bug 2617: Add strict (and warnings), partial fix.

These are some of the simpler scripts to add strict to.
Corrected perldoc for Bookfund.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoInstallAuth doesn't have setlanguagecookie to export.
Joe Atzberger [Tue, 10 Mar 2009 21:40:59 +0000 (16:40 -0500)]
InstallAuth doesn't have setlanguagecookie to export.

Only installer/install uses InstallAuth, and it gets setlanguagecookie
from C4::Export.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoTrivial correction to comment.
Joe Atzberger [Tue, 10 Mar 2009 21:40:58 +0000 (16:40 -0500)]
Trivial correction to comment.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdd larger values to numerical limit.
Joe Atzberger [Mon, 9 Mar 2009 18:58:28 +0000 (13:58 -0500)]
Add larger values to numerical limit.

Client requested additional values in dropdown for numerical limit.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFixing catalogue_out errors.
Joe Atzberger [Tue, 10 Mar 2009 21:41:01 +0000 (16:41 -0500)]
Fixing catalogue_out errors.

This script ran against biblioitems.itemtype instead of items.itype.
With that corrected, biblioitems is not used by the query.

Report also failed to check whether the item was currently checked out
(i.e., in the issues table) before declaring it an inactive,
uncirculating item!

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBranchoverdues circ report reworking.
Joe Atzberger [Tue, 27 Jan 2009 00:24:10 +0000 (18:24 -0600)]
Branchoverdues circ report reworking.

branchoverdues.pl
~ Removed unused variables.
~ Use elsif where applicable.
~ Added many FIXMEs.
~ Added help description.
~ Changed link to more accurate description.
~ REFACTORED branchoverdues-specific function in C4 for obvious consolidation.

This report is still of questionable value, since it's dataset has such strange
hardcoded limitations.  It is not clear that "FU" type fines and notifys=0 are
reliable or useful indicators to query on, in hardcoded form.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2854) add the possibility to make a fuzzy search on the barcode
Nahuel Angelinetti [Tue, 9 Dec 2008 16:28:41 +0000 (17:28 +0100)]
(bug #2854) add the possibility to make a fuzzy search on the barcode

This patch add a field that permit to make a "like" and "not like" filter on barcode in the catalog report.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoRemove outmoded (and possibly dangerous) cronjob.
Joe Atzberger [Fri, 6 Mar 2009 20:19:56 +0000 (14:19 -0600)]
Remove outmoded (and possibly dangerous) cronjob.

This script is superceded by rebuild_zebra and the sync_items scripts.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2863) add the borrowers branchcodes in suggestion list
Nahuel ANGELINETTI [Fri, 12 Dec 2008 16:47:25 +0000 (17:47 +0100)]
(bug #2863) add the borrowers branchcodes in suggestion list

Not a big patch, just add the borrower branchcode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agomerge_authority : Bug fixing
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:19 +0000 (14:58 +0100)]
merge_authority : Bug fixing

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofix permissions error
Galen Charlton [Fri, 6 Mar 2009 19:17:04 +0000 (13:17 -0600)]
fix permissions error

13 years agofix the sql request to work in all mysqls
Nahuel Angelinetti [Thu, 4 Dec 2008 15:45:30 +0000 (16:45 +0100)]
fix the sql request to work in all mysqls

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoLibraries (branches) should be sorted by branchname.
Joe Atzberger [Tue, 30 Dec 2008 19:50:15 +0000 (13:50 -0600)]
Libraries (branches) should be sorted by branchname.

The display sorted by code, resulting in nonsensical order
for the users, who don't know or see the codes.  Note,
this data should come from GetBranchesLoop, when that
function is availabled (from a separate patch).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAllow all argument forms to GetBranchesLoops.
Joe Atzberger [Tue, 30 Dec 2008 19:42:10 +0000 (13:42 -0600)]
Allow all argument forms to GetBranchesLoops.

Allow arguments to be specified in the negative (i.e. 0).
Allow function to be called with no arguments.

This supercedes the patch titled:
Allow GetBranchesLoop to intuit IndependantBranches if not specified in argument.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAllow GetBranchesLoop to intuit IndependantBranches if not specified in argument.
Joe Atzberger [Thu, 18 Dec 2008 03:35:21 +0000 (21:35 -0600)]
Allow GetBranchesLoop to intuit IndependantBranches if not specified in argument.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdd GetBranchLoop since so many pages use exactly the same code.
Joe Atzberger [Thu, 30 Oct 2008 05:07:40 +0000 (00:07 -0500)]
Add GetBranchLoop since so many pages use exactly the same code.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agocatalogue_out report cleanup.
Joe Atzberger [Thu, 18 Dec 2008 03:36:05 +0000 (21:36 -0600)]
catalogue_out report cleanup.

Warnings enabled, comparison adjusted to accomodate undef.
Hardcoded CGI::scrolling_list removed.
Sort order on item types corrected.  Unused dependencies commented out.
GetBranchesLoop used instead of copy/paste code.

NOTE: CSV output is not fixed by this patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdd mc-loc definition for ccl.properties.
Ryan Higgins [Thu, 8 Jan 2009 18:03:42 +0000 (13:03 -0500)]
Add mc-loc definition for ccl.properties.

Advances search limit by shelving location doesn't work due to
missing ccl definition in default installation.  Once updated,
the zebradb will need to be reindexed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2811)[3.2] fix opac-renew.pl part
Nahuel ANGELINETTI [Wed, 7 Jan 2009 13:33:23 +0000 (14:33 +0100)]
(bug #2811)[3.2] fix opac-renew.pl part

This patch only fix a "security" failure that permit a user to renew his loan using directly the opac-renew.pl url.
Now, we check that opacrenewalallowed is set to on to permit the renewal in opac.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAddReserve had bogus prepare statement.
Joe Atzberger [Tue, 13 Jan 2009 23:11:06 +0000 (17:11 -0600)]
AddReserve had bogus prepare statement.

This patch was not fully tested because the actual behavior intended
by constraints 'o' and 'e' was apparently never implemented here.
But it had no chance of success as with:
    my $sth = $dbh->prepare("");

This uses the inteneded query, removes unneeded $sth->finish calls and
fixes *some* redeclaration of my $variables in the same scope, as
would be needed to run under warnings pragma.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBasic cleanup of fixup_cardnumber
Joe Atzberger [Wed, 21 Jan 2009 01:18:23 +0000 (19:18 -0600)]
Basic cleanup of fixup_cardnumber

Avoid warning on syspref "checkdigit" undefined.
Functionality essentially unchanged.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2904: fix display of URLs in UNIMARC
Galen Charlton [Fri, 6 Mar 2009 18:17:39 +0000 (12:17 -0600)]
bug 2904: fix display of URLs in UNIMARC

This based on a patch by Nahuel ANGELINETTI; done to
merge changes with Mason's patch for 2951.  The original
patch description is:

in the previous patch the field used for link "name" was 856$z, but the unimarc doesn't specify this, it say to use the 856$2 fi
This patch make koha to use the 856$2."

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agocorrected patch for bug 2951
Mason James [Thu, 12 Feb 2009 23:15:57 +0000 (12:15 +1300)]
corrected patch for bug 2951

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofollowup to library transfer limits: DB rev => 014
Galen Charlton [Wed, 4 Mar 2009 22:15:33 +0000 (16:15 -0600)]
followup to library transfer limits: DB rev => 014

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofollowup: assign BranchTransferLimitsType to Circulation
Galen Charlton [Wed, 4 Mar 2009 22:15:34 +0000 (16:15 -0600)]
followup: assign BranchTransferLimitsType to Circulation

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoThis patch allows the Branch Transfer Limits feature to limit transfers either by...
koha [Wed, 4 Mar 2009 22:15:32 +0000 (16:15 -0600)]
This patch allows the Branch Transfer Limits feature to limit transfers either by itemtype ( like the original commit ) or collection code ( new feature ).

[Note inserted by RM: this patch is by Kyle Hall]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2703: Changed spent.pl select statment to include joins between tables.
James Winter [Wed, 4 Mar 2009 20:57:01 +0000 (15:57 -0500)]
bug 2703: Changed spent.pl select statment to include joins between tables.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2991: Request hold on multiple items at one time.
Stephen Edwards [Thu, 5 Mar 2009 00:10:03 +0000 (19:10 -0500)]
bug 2991: Request hold on multiple items at one time.

Updated the results, cart, and shelf pages to include a button
or link to initiate a hold request based on checked items.

Updated the request CGI scripts to handle multiple biblio items.

Updated the reserve confirmation page to display multiple items,
with an optional list of copies for each one.

Turned on warnings in opac/opac-reserve.pl and fixed resulting
warnings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoMarkup and style corrections.
Owen Leonard [Thu, 5 Mar 2009 20:37:49 +0000 (14:37 -0600)]
Markup and style corrections.

Corrects case of "onclick" and creates new style for "send" link rather than re-using inapplicable toolbar ID.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2772: bad image location
Nahuel Angelinetti [Mon, 10 Nov 2008 16:16:16 +0000 (17:16 +0100)]
bug 2772: bad image location

This patch make Page.pm to use the getitemtypeinfo function to generate the imageurl, and check (in the template) if an
image is set.
Before this patch, always the "Alt" information was shown, because the url wasn't right.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2978) fix differents bugs in marc editor
Nahuel ANGELINETTI [Mon, 23 Feb 2009 11:12:49 +0000 (12:12 +0100)]
(bug #2978) fix differents bugs in marc editor

This patch fix two bugs:

 * tag duplication
If you try to duplicate an autority tag, the javascript call is kept, and the id is not modified, and fields are not emptied.

 * openAuth() call
The id called on duplicated fields is not the great id.
And the different values sent to auth_finder.pl to pre-fetch datas from firstname, etc... send values from all same tags, and not from the selected tag.
(cherry picked from commit 40115eb110c94935e1b3fe6ba3a3c9ea35a473a4)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2933) change popup names containing space chars
Nahuel ANGELINETTI [Thu, 29 Jan 2009 14:29:19 +0000 (15:29 +0100)]
(bug #2933) change popup names containing space chars

This patch change all call to open.window that have a window identifier which contains space chars.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoUsing openAuth function for authorities Searching
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:11 +0000 (14:58 +0100)]
Using openAuth function for authorities Searching

Adding two js functions :
getSubfieldcode(tagsubfieldid)  returns the subfieldcode from tagsubfieldid
(tag_XXX_subfield_Y_WWWW_TTTT returns Y)
getTagInputnameFilter(tagsubfieldid)
(tag_XXX_subfield_Y_WWWW_TTTT returns tag_XXX_subfield_._WWWW)

I think those two functions are much useful when cataloguing.

openAuth now takes all the information for Heading search of authorities.

TODO A javascript DOM Navigation would be better.
This js works, but is surely slower than DOM would be.
Still, it seems that our DOM tree is quite hard to decode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #3011) csv export doesn't fill all the fields
Nahuel ANGELINETTI [Fri, 6 Mar 2009 11:25:05 +0000 (12:25 +0100)]
(bug #3011) csv export doesn't fill all the fields

This patch just fix the script which export to csv the overdue, and field the missing fields

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2840: Delete a hidden tag that is not needed and create an error
Nahuel Angelinetti [Wed, 3 Dec 2008 11:41:11 +0000 (12:41 +0100)]
bug 2840: Delete a hidden tag that is not needed and create an error

The bug exists because for each table line, an hidden field was set, with subscriptionid, but it's not used by the script and
create a bug "Request-URI Too Large".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2883 - longoverdue cronjob fails to implement required functionality.
Joe Atzberger [Mon, 29 Dec 2008 16:51:45 +0000 (10:51 -0600)]
Bug 2883 - longoverdue cronjob fails to implement required functionality.

This does not fix all problems recorded in 2883 (see all the FIXME's), but
it does improve the script's basic feedback to an intelligible level.
It also adjusts the documentation and examples to correct bogus usage
instructions.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAllow LDAP test to bail if LDAP disabled.
Joe Atzberger [Fri, 23 Jan 2009 17:57:57 +0000 (11:57 -0600)]
Allow LDAP test to bail if LDAP disabled.

Also added more feedback and the ability to override KOHA_CONF
"useldapserver" value with ENV variable KOHA_USELDAPSERVER.

This patch should be considered for inclusion to 3.0 stable branch
because it prevents unnecessary failure of test battery.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2996) update unimarc 105 plugin to the actual norm
Nahuel ANGELINETTI [Thu, 5 Mar 2009 11:12:49 +0000 (12:12 +0100)]
(bug #2996) update unimarc 105 plugin to the actual norm

This patch add some codes which have been added to the norm:
* Religious Text
* dissertation or thesis
* booklet
(cherry picked from commit 673bd0d832c7aba6d8ef642bd420504eee2cc23b)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2996) fix and improve 100 and 105 unimarc plugins
Nahuel ANGELINETTI [Tue, 3 Mar 2009 12:57:19 +0000 (13:57 +0100)]
(bug #2996) fix and improve 100 and 105 unimarc plugins

This plugins need some stuffs for the users to help them to choose, like show the codes, add some codes, etc...
(cherry picked from commit 75e6ac4a03503c2ed5940fff93f43f730f96488f)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoTranslating UNIMARC plugins in English
Henri-Damien LAURENT [Mon, 24 Nov 2008 21:31:24 +0000 (22:31 +0100)]
Translating UNIMARC plugins in English

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
(cherry picked from commit 839c87a48cfc1aa3e37705fd7cc8d902d0b6bfb9)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdded a require C4::Heading to resolve a circular dependency.
Daniel Sweeney [Wed, 4 Mar 2009 22:53:06 +0000 (16:53 -0600)]
Added a require C4::Heading to resolve a circular dependency.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago- perltidy corrects broken indentation on 'if' block.
Mason James [Mon, 26 Jan 2009 00:05:30 +0000 (13:05 +1300)]
- perltidy corrects broken indentation on 'if' block.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug-2923: replaces 'renew/not renew' text with nice 'renew/return 'yui buttons.
Mason James [Thu, 22 Jan 2009 23:13:42 +0000 (12:13 +1300)]
bug-2923: replaces 'renew/not renew' text with nice 'renew/return 'yui buttons.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofix for bug-2923, corrects renew status in SCO
Mason James [Thu, 22 Jan 2009 22:04:50 +0000 (11:04 +1300)]
fix for bug-2923, corrects renew status in SCO

 - removes unneeded  HTML::Template::Pro
 - some indent/newline tidies

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoTrivial comment typos corrected.
Joe Atzberger [Wed, 21 Jan 2009 01:18:24 +0000 (19:18 -0600)]
Trivial comment typos corrected.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAutoselect marcflavour in marc import
Nahuel ANGELINETTI [Tue, 20 Jan 2009 14:59:23 +0000 (15:59 +0100)]
Autoselect marcflavour in marc import

This patch is writted by Paul Poulain.
It auto-select the marcflavour from syspref in the stage marc import.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoPrevent warning if intranetuserjs is already NULL/undefined.
Joe Atzberger [Sat, 17 Jan 2009 00:31:54 +0000 (18:31 -0600)]
Prevent warning if intranetuserjs is already NULL/undefined.

Warning would look like:
updatedatabase.pl: Use of uninitialized value in string eq
at /home/user/koha/installer/data/mysql/updatedatabase.pl line 2141.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoCorrect capitalization on CGI::Session::Serialize::yaml
Joe Atzberger [Sat, 17 Jan 2009 00:31:55 +0000 (18:31 -0600)]
Correct capitalization on CGI::Session::Serialize::yaml

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2917) editing authority marc field structure doesn't workl
Nahuel ANGELINETTI [Tue, 20 Jan 2009 12:46:58 +0000 (13:46 +0100)]
(bug #2917) editing authority marc field structure doesn't workl

This patch add a field in the ->execute() statement which was missing.
The sql request have 8 args, and only 7 was passed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFixes command-line 'number' arg in bulkauthimport.pl.
Mason James [Fri, 16 Jan 2009 10:07:12 +0000 (23:07 +1300)]
Fixes command-line 'number' arg in bulkauthimport.pl.

for HEAD and 3.0.x

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2961) be xhtml valid
Nahuel ANGELINETTI [Wed, 4 Mar 2009 16:14:50 +0000 (17:14 +0100)]
(bug #2961) be xhtml valid

This little patch just fix the previous patch to be xhtml valid(onclick instead of onClick)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2961) add a button to add manually the next issue
Nahuel ANGELINETTI [Fri, 13 Feb 2009 16:15:31 +0000 (17:15 +0100)]
(bug #2961) add a button to add manually the next issue

This patch add a button in "Serial Collection" to add manually the next issue. And improve the function GetNextExpected
to retrieve at least something.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2962) escape searchbox, and change the search from tag clouds
Nahuel ANGELINETTI [Mon, 16 Feb 2009 10:03:42 +0000 (11:03 +0100)]
(bug #2962) escape searchbox, and change the search from tag clouds

This patch escape the searchbox to permit to have quotes in searchs.
And make exacts search on autorities from subject tag cloud.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoKohabug 2500 Fiction Call Number Splitting Enhancement/Bugfix
Chris Nighswonger [Thu, 26 Feb 2009 20:43:35 +0000 (15:43 -0500)]
Kohabug 2500 Fiction Call Number Splitting Enhancement/Bugfix

The current regexp used to split fiction call numbers does not handle the '.' char well. This patch corrects the regexp so that it behaves as expected.

This patch should be ported to the 3.0.x branch.

[fbcbug 5]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdding Copy Number column to table of item information on holds pages.
Owen Leonard [Thu, 26 Feb 2009 19:39:54 +0000 (13:39 -0600)]
Adding Copy Number column to table of item information on holds pages.

Fixes Bug 2753, Hold screen needs to show copy number.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2924 fixed rebuild_zebra.pl to work when export is skipped
Brian Harrington [Mon, 2 Mar 2009 21:08:13 +0000 (16:08 -0500)]
bug 2924 fixed rebuild_zebra.pl to work when export is skipped

reindexing now occurs if there are $num_records_exported or if
$skip_export is set

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2986: tweak authtype index for MARC21 (GRS-1)
Galen Charlton [Wed, 4 Mar 2009 14:19:02 +0000 (08:19 -0600)]
bug 2986: tweak authtype index for MARC21 (GRS-1)

Following a similar patch for UNIMARC, tweak the
authtype index for MARC21 authorities if the GRS-1
Zebra filter is in use.

Note that it is recommended that *DOM* mode indexing
be used for MARC21 authorities; if you're using DOM mode,
it is not necessary to rebuild the index.  However, if
you're using the GRS-1 definitions (record.abs), it will
be necessary to reindex the authority records using

misc/migration_tools/rebuild_zebra.pl -a -r

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix bug #2986 - Authority search
Frederic Demians [Thu, 26 Feb 2009 09:57:43 +0000 (10:57 +0100)]
Fix bug #2986 - Authority search

On authorities-home.pl page, when you do search, you don't have any
result. Looking in log file, you see a Zebra error:

  Unsupported Use attribute (114) authtype Bib-1

This patch modify record.abs UNIMARC definition.
The same may have to be done for MARC21 record.abs.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofixes missing 'STDERR', causing 500 error below..
Mason James [Mon, 2 Mar 2009 03:29:54 +0000 (16:29 +1300)]
fixes missing 'STDERR', causing 500 error below..

 malformed header from script. Bad header=## checkpw - checking LDAP: mainpage.pl,

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2992: don't display MARC codes in search results
Galen Charlton [Fri, 27 Feb 2009 21:39:43 +0000 (15:39 -0600)]
bug 2992: don't display MARC codes in search results

Two fields (type of continuing resource and literary
form for sound recordings) in the MARC21 XSLT search
results stylesheet display the code from the 008
position (/21 and /31, respectively) in addition to a
descriptive label.  As a MARC code is meaningless to
patrons, this patch removes the code.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2998) fix search sorting containing "="
Nahuel ANGELINETTI [Tue, 3 Mar 2009 16:48:15 +0000 (17:48 +0100)]
(bug #2998) fix search sorting containing "="

just modify the way to parse the actual args

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoUpdate autobarcode syspref for french framework
Nahuel ANGELINETTI [Tue, 3 Mar 2009 13:16:17 +0000 (14:16 +0100)]
Update autobarcode syspref for french framework

This patch just update the syspref to use incremental|annual|hbyymmincr|OFF instead of "YesNo".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2995) Set a default encoding for e-mails
Nahuel ANGELINETTI [Tue, 3 Mar 2009 10:16:24 +0000 (11:16 +0100)]
(bug #2995) Set a default encoding for e-mails

Just set a default encoding as utf8 if none is provided.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agochanges to OPAC results and detail XSLT
Galen Charlton [Wed, 11 Feb 2009 23:01:01 +0000 (17:01 -0600)]
changes to OPAC results and detail XSLT

Various changes to OPAC search results and bib
detail display for MARC21.

* Search results

[1] 245 subfields will be displayed in order $a, $b, $h, then
    rest of subfields in the order they appear in the record.
[2] New edition field from 250$a, displayed under author
[3] New other title field from 246$a$b, displayed under call number

* Bib details

[1] 245 subfields will be displayed in order $a, $b, $h, then
    rest of subfields in the order they appear in the record.
[2] New edition field from 250$a$b, displayed under publisher
[3] New description field from 300$a$b$c$e$g, under the edition.
[4] New other title field from the 246$i$a$b$h$f$g$n$p, above the
    uniform title field.
[6] All 6XX fields are displayed in the subjects field.
[7] '--' now separates subdivisions in subject headings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agodisplay library name instead of code in limit description
Galen Charlton [Wed, 25 Feb 2009 19:29:41 +0000 (13:29 -0600)]
display library name instead of code in limit description

The OPAC and staff search results page will now display
the library name instead of the library code in the limit
part of the search description, e.g.,

"kw,wrdl: cat branch:Centerville" instead of
"kw,wrdl: cat branch:CPL"

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoResubmitting: Change to how email link is displayed for on-hold items
Owen Leonard [Thu, 26 Feb 2009 20:50:40 +0000 (14:50 -0600)]
Resubmitting: Change to how email link is displayed for on-hold items

Email link should only display when the on-hold item is being checked in at its destination branch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agominor corrections to check-url.pl
Galen Charlton [Thu, 26 Feb 2009 21:15:53 +0000 (15:15 -0600)]
minor corrections to check-url.pl

* removed ersataz YAML::XS dependency
* use 'return' instead of 'return undef'
* minor language changes

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoURLs checker enhancement (bug #2959)
Frederic Demians [Tue, 17 Feb 2009 09:23:13 +0000 (10:23 +0100)]
URLs checker enhancement (bug #2959)

Improve URLs checker script in the way (half way) pointed out by Galen:

- A C4::URL::Checker class handle URL checking. This class is not yet
  in a separate file in C4 directory. This class would be easily
  extended to accomodate authorities URLs checking.
- Script output can now be formatted in CSV or HTML. HTML version
  link directly to MARC biblio record editor.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2968 - SIP ACS_STATUS message (98) misreported config.
Joe Atzberger [Thu, 19 Feb 2009 16:20:07 +0000 (10:20 -0600)]
Bug 2968 - SIP ACS_STATUS message (98) misreported config.

The *_ok methods in ILS.pm were targeting the wrong depth.
This also resolves a longstanding FIXME on to_bool() warning like:
    Argument "\x{66}\x{61}..." isn't numeric in numeric ne (!=) at /ILS.pm line 94.

The example_institution_dump.sh essentially provides the proof test case for this patch.
Run it before/after on SIPconfig.xml where "MAIN" has checkout="true" and checkin="true".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>