koha.git
11 years agoBug 5611: Simple typo fix in the comments
Chris Cormack [Wed, 12 Jan 2011 19:17:27 +0000 (08:17 +1300)]
Bug 5611: Simple typo fix in the comments

11 years agoBug 5611 Tidy up C4::Scrubber
Colin Campbell [Wed, 12 Jan 2011 16:53:22 +0000 (16:53 +0000)]
Bug 5611 Tidy up C4::Scrubber

Remove the unneeded package variables
Remove unnecessary variables
Removed some cargo-cult programming
Tidied the indentation from mix of tabs & spaces
Add a Test that we actually return the required class
of object

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5611 INIT block causes failure with mod perl
Bryce Sanchez [Wed, 12 Jan 2011 16:53:21 +0000 (16:53 +0000)]
Bug 5611 INIT block causes failure with mod perl

Per module INIT Blocks are not run in mod_perl so their
variables are not visible. A lexical var is adequate
for this purpose

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5601 :: Add tests for bugfix
Colin Campbell [Wed, 12 Jan 2011 06:34:22 +0000 (07:34 +0100)]
Bug 5601 :: Add tests for bugfix

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5601 Fix processing of DueDate return
Colin Campbell [Wed, 12 Jan 2011 06:34:21 +0000 (07:34 +0100)]
Bug 5601 Fix processing of DueDate return

item duedate is not a datetime entity but a string retrieved
direct from the db that only needs restructuring
checkout was doing so but item_info was pretending it was in secs
(actually Item.pm manipulated then overwrote it!!)
assume the date in the db is correct (otherwise madness ensues)
dont try to second guess it
As duedates do not yet include a time element assume end of day
as a safety first

[F. Demians] I confirm Joe Atzberger diagnostic. That's a bug reported by a
library. I've tested Colin Campell solution. It fixes the bug.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5055 Use standard file paths in crontab.example
Magnus Enger [Wed, 5 Jan 2011 21:06:54 +0000 (22:06 +0100)]
Bug 5055 Use standard file paths in crontab.example

This is a revised patch, removing the lines pertaining to logrotate.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 4131 have subscription so edit routing if one exists
Nicole Engard [Tue, 11 Jan 2011 07:33:51 +0000 (02:33 -0500)]
bug 4131 have subscription so edit routing if one exists

Changes the template variable checked in serials-menu.inc for determining where to
show 'Create Routing List' or 'Edit Routing List' to hasRouting.

Also adds the $hasRouting variable to serials/routing.pl and serials/routing-preview.pl,
for completeness.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5486 remove note about HomeOrHoldingBranch being removed soon
Nicole Engard [Tue, 11 Jan 2011 06:55:21 +0000 (01:55 -0500)]
bug 5486 remove note about HomeOrHoldingBranch being removed soon

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5603: advance_notice.pl uninitialized element in hash
Ian Walls [Sat, 8 Jan 2011 22:25:56 +0000 (17:25 -0500)]
Bug 5603: advance_notice.pl uninitialized element in hash

Changings one of the LEFT JOINS in C4::Members::Messaging::GetMessagingPreferences
to a JOIN to prevent NULL message_transport_types from being returned

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 2142 : Bumping database version
Chris Cormack [Tue, 11 Jan 2011 19:47:57 +0000 (08:47 +1300)]
Bug 2142 : Bumping database version

11 years agoBug 2142: reinstate maxItemInSearchResults systempreference
Ian Walls [Sat, 8 Jan 2011 22:24:41 +0000 (17:24 -0500)]
Bug 2142: reinstate maxItemInSearchResults systempreference

Reinstates the deleted maxItemsInSearchResults system preference, which was erroneously thought to no longer be utilized.
It's removal has led to bug 4430

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5492 update import patrons page title
Nicole Engard [Tue, 11 Jan 2011 06:52:56 +0000 (01:52 -0500)]
bug 5492 update import patrons page title

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5604 additional icons in the Seshat icon set
Nicole Engard [Tue, 11 Jan 2011 06:36:40 +0000 (01:36 -0500)]
bug 5604 additional icons in the Seshat icon set

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 4945 - Patron search is limited by default to the currently logged-in...
Owen Leonard [Tue, 4 Jan 2011 14:04:41 +0000 (09:04 -0500)]
Fix for Bug 4945 - Patron search is limited by default to the currently logged-in library

I couldn't figure out how (or whether) GetBranchesLoop could be
convinced to return a list of branches without selecting one, so
I swapped GetBranchesLoop with GetBranches. This will preselect
a branch only if a branch has been submitted as part of a query.

This does NOT preselect the correct branch when IndependantBranches
is turned on.

I also added a template variable which is true if a query has
been submitted with a branch or a category so that the extra
form fields can be displayed, reminding the user that they
added limiters to their query.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years ago(bug #3737) fix title search in order history
Nahuel ANGELINETTI [Mon, 10 Jan 2011 16:37:02 +0000 (16:37 +0000)]
(bug #3737) fix title search in order history

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBumping database number to 011
Chris Cormack [Mon, 10 Jan 2011 19:12:59 +0000 (08:12 +1300)]
Bumping database number to 011

11 years agoMerge remote branch 'kc/new/bug_5186' into kcmaster
Chris Cormack [Mon, 10 Jan 2011 19:10:52 +0000 (08:10 +1300)]
Merge remote branch 'kc/new/bug_5186' into kcmaster

11 years agoBug 5186: Follow-up - Fixing wrong database number
Katrin Fischer [Thu, 23 Sep 2010 23:24:19 +0000 (01:24 +0200)]
Bug 5186: Follow-up - Fixing wrong database number

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoMerge remote branch 'kc/new/bug_5240' into kcmaster
Chris Cormack [Sun, 9 Jan 2011 20:16:50 +0000 (09:16 +1300)]
Merge remote branch 'kc/new/bug_5240' into kcmaster

11 years agoMerge remote branch 'kc/new/bug_5186' into kcmaster
Chris Cormack [Sun, 9 Jan 2011 20:14:22 +0000 (09:14 +1300)]
Merge remote branch 'kc/new/bug_5186' into kcmaster

11 years agoMerge remote branch 'kc/new/bug_4838' into kcmaster
Chris Cormack [Sun, 9 Jan 2011 20:13:17 +0000 (09:13 +1300)]
Merge remote branch 'kc/new/bug_4838' into kcmaster

11 years agoMerge remote branch 'kc/new/enh/bug_5560' into kcmaster
Chris Cormack [Sun, 9 Jan 2011 20:11:50 +0000 (09:11 +1300)]
Merge remote branch 'kc/new/enh/bug_5560' into kcmaster

11 years agoBug 5589: Remove duplicated Exports in Suggestions.pm
Colin Campbell [Fri, 7 Jan 2011 11:44:03 +0000 (11:44 +0000)]
Bug 5589: Remove duplicated Exports in Suggestions.pm

Rather bizarrely Suggestions.pm was setting up @EXPORT, @ISA
and $VERSION twice. Have removed one invocation

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 4984, Invalid XHTML in staff client search results
Owen Leonard [Wed, 5 Jan 2011 08:24:53 +0000 (03:24 -0500)]
Fix for Bug 4984, Invalid XHTML in staff client search results

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoAdditional fix for Bug 3550, Use GetRecordValue to get the subtitle
Owen Leonard [Fri, 7 Jan 2011 10:34:11 +0000 (05:34 -0500)]
Additional fix for Bug 3550, Use GetRecordValue to get the subtitle

- Adding subtitle to Hold Ratio report output
- Sorting by default on ratio, descending
- Adding author
- Removing description

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5480 Some usual UNIMARC cataloguing plugins doesn't work anymore
Frédéric Demians [Mon, 20 Dec 2010 13:13:41 +0000 (14:13 +0100)]
Bug 5480 Some usual UNIMARC cataloguing plugins doesn't work anymore

[3.2] To be applied

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoMerge remote branch 'kc/new/enh/bug_4820' into kcmaster
Chris Cormack [Fri, 7 Jan 2011 01:27:06 +0000 (14:27 +1300)]
Merge remote branch 'kc/new/enh/bug_4820' into kcmaster

11 years agoFollow-up on fix for Bug 4820, Alter layout of Circulation and fines rules page
Owen Leonard [Thu, 6 Jan 2011 21:03:07 +0000 (16:03 -0500)]
Follow-up on fix for Bug 4820, Alter layout of Circulation and fines rules page

One instance of "default" usage missed in the original update

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFollow up on fix for Bug 5570, item types not showing on other editions
Owen Leonard [Thu, 6 Jan 2011 21:31:00 +0000 (16:31 -0500)]
Follow up on fix for Bug 5570, item types not showing on other editions

Fix for the staff client.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 5570 - item types not showing on other editions
Owen Leonard [Tue, 4 Jan 2011 17:47:29 +0000 (12:47 -0500)]
Fix for Bug 5570 - item types not showing on other editions

The item type which shows on other editions is the biblio-level
itemtype. XISBN.pm had some item-handling code, but I'm
removing it because it is unused. The editions tab should
now display item type only if item-level itemtypes are not
enabled.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 5006 - Invalid XHTML in record matching rules template
Owen Leonard [Wed, 5 Jan 2011 08:26:30 +0000 (03:26 -0500)]
Fix for Bug 5006 - Invalid XHTML in record matching rules template

- Rework JavaScript clone routines to use jQuery, to take
  label "for" into account, to handle incrementing label,
  and to properly place cloned blocks at the bottom of the group
- Rework JavaScript delete routines to use jQuery, to take
  block label numbers into account, and to show the "add"
  link if you have deleted the last block.
- Correcting markup which nests <div> inside <fieldset>
- Ensuring labels' "for" attribute matches input IDs
- Adding "required" style to required fields

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5583 Rename fieldnumber to blocknumber
Colin Campbell [Thu, 6 Jan 2011 11:37:19 +0000 (11:37 +0000)]
Bug 5583 Rename fieldnumber to blocknumber

Variable fieldnumber does not refer to a field
It is the ISBD block number
Rename to blocknumber
Say what we mean adds to maintainability

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5582 Pass tag nums as a string to Doc Popup
Colin Campbell [Thu, 6 Jan 2011 11:15:41 +0000 (11:15 +0000)]
Bug 5582 Pass tag nums as a string to Doc Popup

Add quotes around tag number when calling doc popup
Otherwise numbers with leading zeroes are interpreted
as octal e.g. 020 returns doc for 016

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5585: fix display of current date on receipts and slips
Galen Charlton [Wed, 5 Jan 2011 16:19:57 +0000 (11:19 -0500)]
bug 5585: fix display of current date on receipts and slips

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 4950 - checkbox should be removed when can't place a hold
Owen Leonard [Wed, 5 Jan 2011 05:27:14 +0000 (00:27 -0500)]
Fix for Bug 4950 - checkbox should be removed when can't place a hold

- Hiding form controls for titles which can't be placed on hold
- Highlighting hold blocked message for better visibility
- Showing table of blocked holds even if none can be placed on
  hold: hiding the table hides the messages explaining why
  titles can't be placed on hold
- Removing an unused line from the script which was leaving errors
  in the error log
- Consolidating error messages into one box which were displaying
  in two.
- Correcting link to unused opac-userdetails.pl

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 3347 - Inconsistencies with tables in opac-shelves.tmpl
Owen Leonard [Wed, 5 Jan 2011 04:51:54 +0000 (23:51 -0500)]
Fix for Bug 3347 - Inconsistencies with tables in opac-shelves.tmpl

Changes to list contents view to make it consistent with search results

My intention is to make the OPAC more consistent in the way it displays
lists of items, whether it be in search results, lists, etc. This patch
adds data to the list contents output and reformats it to that end.

The other significant change is the removal of jQuery table sorting.
Since list contents are both sorted and paginated on the server
side. Adding a client-side sort to one page of many doesn't make sense.

Other changes include:

- Change "Your lists" to "Your private lists"
- Remove "sort by" column because it seems unnecessary
- Adding logic to control display of count (item or items
  rather than item(s)
- Styling pagination bar and placing at the bottom of the page,
  consistent with other instances of pagination navigation

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 5571 - tags as bulleted list too long
Owen Leonard [Wed, 5 Jan 2011 01:31:37 +0000 (20:31 -0500)]
Fix for Bug 5571 - tags as bulleted list too long

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5419: make reason checkouts blocked stand out
Nicole Engard [Thu, 30 Dec 2010 16:57:06 +0000 (11:57 -0500)]
bug 5419: make reason checkouts blocked stand out

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5497: make all library fields available to circ receipt/slips
Galen Charlton [Tue, 4 Jan 2011 19:38:44 +0000 (14:38 -0500)]
bug 5497: make all library fields available to circ receipt/slips

This allows the receipt template to be more readily customized
to include the library's address, phone number, email address, etc.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 3918 - Add to order lists inconsistent
Owen Leonard [Tue, 4 Jan 2011 19:31:46 +0000 (14:31 -0500)]
Fix for Bug 3918 - Add to order lists inconsistent

- Added new include to contain add to basket options
- Minor markup corrections

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5375 (Update date/time last transaction (MARC 005) when saving authority record)
Marcel de Rooy [Thu, 16 Dec 2010 01:12:28 +0000 (20:12 -0500)]
Bug 5375 (Update date/time last transaction (MARC 005) when saving authority record)

Update 005 date/time when saving authority record for MARC21 and UNIMARC.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5374 (update transaction date when saving biblio) RESENT with small fix
Marcel de Rooy [Wed, 15 Dec 2010 23:11:28 +0000 (18:11 -0500)]
Bug 5374 (update transaction date when saving biblio) RESENT with small fix

Currently, the plugin marc21_field_005 and its unimarc opponent fill field 005
when this field gets focus. This implies that updating a record without
touching this field does not update 005.
At the same time, a user could accidentally delete a character in the 005 when
having focus. This mutilated field value will be saved however.

I would suggest to add a few lines to ModBiblioMarc in Biblio.pm to ascertain
that adding or updating a record always updates 005 in marc21 as well as
unimarc.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoMerge remote branch 'kc/new/bug_5563' into kcmaster
Chris Cormack [Mon, 3 Jan 2011 09:03:28 +0000 (22:03 +1300)]
Merge remote branch 'kc/new/bug_5563' into kcmaster

11 years agobug 5562 change 'issues' to read 'checkouts'
Nicole Engard [Thu, 30 Dec 2010 16:59:20 +0000 (11:59 -0500)]
bug 5562 change 'issues' to read 'checkouts'

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5563 change note about cover images on enhanced content
Nicole Engard [Thu, 30 Dec 2010 17:02:15 +0000 (12:02 -0500)]
bug 5563 change note about cover images on enhanced content

on the enhanced content tab of system
preferences it says that Koha will pick
the first cover image - but in fact it
shows them all - that note needs to be
updated to properly warn of the expected
behavior.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoReimplemented fix for bug 5556, OPAC does not display the type of authority
Owen Leonard [Thu, 30 Dec 2010 17:07:11 +0000 (12:07 -0500)]
Reimplemented fix for bug 5556, OPAC does not display the type of authority

Formatting Janusz's suggested changes as a patch.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoReimplement fix for bug 5557 - Link to logs for user with view_system_logs permission
Owen Leonard [Thu, 30 Dec 2010 17:20:33 +0000 (12:20 -0500)]
Reimplement fix for bug 5557 - Link to logs for user with view_system_logs permission

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBumping database version to 3.03.00.010
Chris Cormack [Sat, 1 Jan 2011 20:30:23 +0000 (09:30 +1300)]
Bumping database version to 3.03.00.010

11 years agobug 5040 fix misspelling of distance in marc21 framework
Nicole Engard [Thu, 30 Dec 2010 17:32:37 +0000 (12:32 -0500)]
bug 5040 fix misspelling of distance in marc21 framework

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 4942 - add validation to patron administration
Robin Sheat [Fri, 31 Dec 2010 14:18:55 +0000 (09:18 -0500)]
bug 4942 - add validation to patron administration

This validation requires an enrollment period or a date to be provided
before the form will save, which will prevent invalid dates getting into
the system.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agobug 5045 - Help works even when the referrer is being stripped
Robin Sheat [Fri, 31 Dec 2010 16:19:17 +0000 (11:19 -0500)]
bug 5045 - Help works even when the referrer is being stripped

This fix puts the URL of the source page as a parameter to help.pl,
which will override the referrer value, if it's provided. This deals
with people sitting behind proxies that strip the referrer information
out.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 3665, adding another submit button as in OPAC
Owen Leonard [Thu, 30 Dec 2010 11:33:46 +0000 (06:33 -0500)]
Fix for Bug 3665, adding another submit button as in OPAC

This is the only change proposed in Bug 3665 which hasn't
already been implemented by someone else. It adds a submit
button under the first section of the advanced search page
just like the OPAC advanced search has.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 4820, Alter layout of Circulation and fines rules page for clarity
Owen Leonard [Thu, 30 Dec 2010 11:31:23 +0000 (06:31 -0500)]
Fix for Bug 4820, Alter layout of Circulation and fines rules page for clarity

I propose some changes to the issuing rules interface to improve usability:

 - Better define and delineate the sub-sections on the page:
   - Default checkout and hold policy
   - Checkout limit by patron category
   - Holds policy by item type

 - Repeat the current library name, when selected, for clarity: "Default
   checkout and hold policy for Athens" rather than "Default checkout and
   hold policy for this library"

 - Use the phrase "all libraries" when no library is selected. "Default
   library" seems ambiguous. "All libraries" better defines how the rule
   will be applied: to all libraries in the absence of a more specific rule.

 - Use the term "all" instead of "default" in cases where a rule will apply
   to all categories or item types.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5550 - correct filename referenced in docs
Robin Sheat [Wed, 29 Dec 2010 01:20:19 +0000 (14:20 +1300)]
Bug 5550 - correct filename referenced in docs

Spotted by Reed Wade.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 5560 - pagination option for lists
Owen Leonard [Wed, 29 Dec 2010 22:04:45 +0000 (17:04 -0500)]
Fix for Bug 5560 - pagination option for lists

This patch doesn't enable per-list pagination options,
but makes OPAC and staff client list display obey
the OPACnumSearchResults and numSearchResults system
preferences instead

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5526: Follow up patch removing a warn statement
Chris Cormack [Wed, 29 Dec 2010 07:36:37 +0000 (20:36 +1300)]
Bug 5526: Follow up patch removing a warn statement

11 years agoFix for Bug 5526, List of lists should be in alphabetical order by list name
Owen Leonard [Mon, 20 Dec 2010 15:56:11 +0000 (09:56 -0600)]
Fix for Bug 5526, List of lists should be in alphabetical order by list name

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5542: Availability code commented out - Uncommenting
Chris Cormack [Thu, 23 Dec 2010 19:35:53 +0000 (08:35 +1300)]
Bug 5542: Availability code commented out - Uncommenting

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 5540, editing slip news changes to librarian interface
Owen Leonard [Fri, 24 Dec 2010 18:39:13 +0000 (13:39 -0500)]
Fix for Bug 5540, editing slip news changes to librarian interface

The script checks for a language-specific OPAC message and, if none
is found, preselects none of the "display location" options. This
results in the first item in the <select> behing highlighted by
default, "Librarian interface." If we want to select "slip," we
must add an explicit check for it.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for bug 5451, can add tags with userlogin turned off
Owen Leonard [Fri, 17 Dec 2010 23:11:43 +0000 (18:11 -0500)]
Fix for bug 5451, can add tags with userlogin turned off

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5531: adding some missing sysprefs
Chris Cormack [Wed, 22 Dec 2010 02:06:51 +0000 (15:06 +1300)]
Bug 5531: adding some missing sysprefs

11 years agoBug 5531: Updated Polish, Ukranian and Russian syspref files
Chris Cormack [Wed, 22 Dec 2010 01:59:11 +0000 (14:59 +1300)]
Bug 5531: Updated Polish, Ukranian and Russian syspref files

Retrieved from
http://git.koha-community.org/gitweb/?p=wip/koha-chris_n.git;a=commit;h=f23969c7e1cb87d4bd9552e3d6bc85cc948dedd9

11 years agoBug 5531: further fix for fr-FR files
Chris Cormack [Wed, 22 Dec 2010 01:44:33 +0000 (14:44 +1300)]
Bug 5531: further fix for fr-FR files

11 years agoBased on Chris Nighswonger french unimarc_standard_sysprefs.sql
Henri-Damien LAURENT [Tue, 21 Dec 2010 23:00:17 +0000 (00:00 +0100)]
Based on Chris Nighswonger french unimarc_standard_sysprefs.sql

11 years agoMerge remote branch 'kc/new/enh/bug_5530' into kcmaster
Chris Cormack [Tue, 21 Dec 2010 22:37:09 +0000 (11:37 +1300)]
Merge remote branch 'kc/new/enh/bug_5530' into kcmaster

11 years agoBug 5530 Follow up
Frédéric Demians [Tue, 21 Dec 2010 21:12:44 +0000 (22:12 +0100)]
Bug 5530 Follow up

With this patch, I don't see any other place where the old sysprefs editors
(systemprefences.pl) is used anymore.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5506 Shorten .po file comment lines
Frédéric Demians [Tue, 21 Dec 2010 20:42:41 +0000 (21:42 +0100)]
Bug 5506 Shorten .po file comment lines

In opac/staff templates .po files, we have comment lines contextualizing
extracted text in templates. Path to template are absolute. For example, we can
have:

  #: /home/katrin/kohaclone/koha-tmpl/intranet-tmpl/prog/en/...
     modules/cataloguing/addbiblio.tmpl:585

The first part of the pathname is useless. With this patch, we just keep
relative path to tempalte from Koha template main directory. The above example
becomes:

  #: intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl:585

To be applied on [3.2]

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5331, fixing Italian sysprefs.sql
Chris Cormack [Tue, 21 Dec 2010 10:01:30 +0000 (23:01 +1300)]
Bug 5331, fixing Italian sysprefs.sql

11 years agoBug 5531: Fixing german sysprefs file
Chris Cormack [Tue, 21 Dec 2010 09:47:05 +0000 (22:47 +1300)]
Bug 5531: Fixing german sysprefs file

11 years agoMerge remote branch 'kc/new/enh/bug_5489' into kcmaster
Chris Cormack [Tue, 21 Dec 2010 08:43:51 +0000 (21:43 +1300)]
Merge remote branch 'kc/new/enh/bug_5489' into kcmaster

11 years agoBug 5530: Fixing a link to systempreferences.pl instead of preferences.pl
Chris Cormack [Tue, 21 Dec 2010 08:19:23 +0000 (21:19 +1300)]
Bug 5530: Fixing a link to systempreferences.pl instead of preferences.pl

11 years agomybranch not exported (merge pb)
Paul POULAIN [Sat, 30 Oct 2010 02:48:04 +0000 (04:48 +0200)]
mybranch not exported (merge pb)

11 years agobranch transfer limits
Henri-Damien LAURENT [Wed, 27 Oct 2010 11:05:38 +0000 (00:05 +1300)]
branch transfer limits

11 years ago(MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support...
Stéphane Delaune [Wed, 1 Sep 2010 07:45:56 +0000 (09:45 +0200)]
(MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support for branch_transfer_limits.pl

11 years ago(MT #1654) followup : corrects tablesorting for authorised_values.pl
Stéphane Delaune [Tue, 31 Aug 2010 15:07:09 +0000 (17:07 +0200)]
(MT #1654) followup : corrects tablesorting for authorised_values.pl

11 years ago(MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support...
Stéphane Delaune [Tue, 31 Aug 2010 13:44:11 +0000 (15:44 +0200)]
(MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support for auth_tag_structure.pl

11 years ago(MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support...
Stéphane Delaune [Tue, 31 Aug 2010 13:11:23 +0000 (15:11 +0200)]
(MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support for marctagstructure.pl

11 years ago(MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support...
Stéphane Delaune [Tue, 31 Aug 2010 12:21:48 +0000 (14:21 +0200)]
(MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support for cities.pl

11 years ago(MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support...
Stéphane Delaune [Tue, 31 Aug 2010 12:14:59 +0000 (14:14 +0200)]
(MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support for categorie.pl

11 years ago(MT #1654) followup : corrects tablesorting for authorised_values and itemtypes
Stéphane Delaune [Tue, 31 Aug 2010 12:01:39 +0000 (14:01 +0200)]
(MT #1654) followup : corrects tablesorting for authorised_values and itemtypes

11 years ago(MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support...
Stéphane Delaune [Tue, 31 Aug 2010 11:50:38 +0000 (13:50 +0200)]
(MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support for itemtypes.pl

11 years ago(MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support...
Stéphane Delaune [Tue, 31 Aug 2010 11:31:44 +0000 (13:31 +0200)]
(MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support for branches.pl

11 years ago(MT #1654) Adding jquery.tablesorter and jquery.tablesorter.pager support for authori...
Stéphane Delaune [Tue, 31 Aug 2010 09:59:26 +0000 (11:59 +0200)]
(MT #1654) Adding jquery.tablesorter and jquery.tablesorter.pager support for authorised_values.pl

11 years ago(MT #1577) complete langages checkbox for unique id
Stéphane Delaune [Wed, 1 Sep 2010 11:59:31 +0000 (13:59 +0200)]
(MT #1577) complete langages checkbox for unique id

11 years agoMT4009: followup removing systempreferences
Henri-Damien LAURENT [Tue, 29 Jun 2010 07:55:12 +0000 (09:55 +0200)]
MT4009: followup removing systempreferences

searching a systempreferences was disabled owed to the fact that it is now systempreferences which is used.

11 years agoRemoving usage of preferences.pl
Paul Poulain [Wed, 16 Jun 2010 09:27:32 +0000 (11:27 +0200)]
Removing usage of preferences.pl

11 years agoFollowup admin/categorie.pl
Henri-Damien LAURENT [Thu, 18 Mar 2010 03:43:52 +0000 (04:43 +0100)]
Followup admin/categorie.pl

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
11 years agoMT 2310 : New subfield for fields < 10 is now in a tab
Matthias Meusburger [Tue, 8 Dec 2009 16:08:53 +0000 (17:08 +0100)]
MT 2310 : New subfield for fields < 10 is now in a tab

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
11 years agoMT 2446 : Cancel authority edition for a field goes back to this field
Matthias Meusburger [Thu, 3 Dec 2009 15:53:14 +0000 (16:53 +0100)]
MT 2446 : Cancel authority edition for a field goes back to this field

11 years agoMerge remote branch 'kc/new/enh/bug_5106' into kcmaster
Chris Cormack [Tue, 21 Dec 2010 07:52:28 +0000 (20:52 +1300)]
Merge remote branch 'kc/new/enh/bug_5106' into kcmaster

11 years agoBug 5106: Tidy up code in opac-showmarc.pl
Chris Cormack [Tue, 21 Dec 2010 04:12:49 +0000 (17:12 +1300)]
Bug 5106: Tidy up code in opac-showmarc.pl

11 years agoProposed fix for Bug 5106 - Simplify MARC view choices in the OPAC (Conflict marker...
Owen Leonard [Mon, 20 Dec 2010 19:11:26 +0000 (20:11 +0100)]
Proposed fix for Bug 5106 - Simplify MARC view choices in the OPAC (Conflict marker fix 2nd try)

- Eliminates the "Extended MARC View" tab
- Points the "MARC View" tab to opac-MARCDetail.pl as it is when XSLT is off
- Offers a "view plain" link on opac-MARCDetail.pl. Clicking this link
  replaces the standard labeled MARC view with an unformatted view similar to the
  one displayed in the pop-up modal MARC view.
- When viewing the "plain view," clicking the "view labeled" link will return
  you to the standard labeled MARC view.
- Adds a new XSL file for displaying MARC data in a slightly-more-formatted
  manner (compared to one big <pre></pre> block).

Removed a conflict marker line from Owen's patch (Marcel).

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 4838 Allow to choose which authority heading to copy into biblio record
Frédéric Demians [Mon, 20 Dec 2010 14:09:49 +0000 (15:09 +0100)]
Bug 4838 Allow to choose which authority heading to copy into biblio record

With this patch, in biblio record data entry form, when ... is clicked for an
authority controlled field, it's possible to select which heading repetion to
copy if the authority has repeated headings.

When there is just one authority repetition, the first one is displayed to
choose, as previously.

This patch is REQUIRED by French libraries following SUDOC UNIMARC format, and
cataloguing multilingual materials ie all Higher Educational and Research
libraries.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoMerge remote branch 'kc/new/bug_5035' into kcmaster
Chris Cormack [Tue, 21 Dec 2010 03:48:42 +0000 (16:48 +1300)]
Merge remote branch 'kc/new/bug_5035' into kcmaster

11 years agobug 5035 remove default opaccolorstylesheet value for new installs
Nicole Engard [Mon, 20 Dec 2010 13:22:42 +0000 (13:22 +0000)]
bug 5035 remove default opaccolorstylesheet value for new installs

Per the bug, the color.css file is blank and so this preference
should have no value by default. This patch only fixes this for
new installs. There is no way to know if people have added values
to the color.css file in existing installs, so removing that value
in those cases might break things.

This patch does not remove the blank color.css file, it only
edits the default system preference.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5186 - allow tax rates to be set to zero (master)
Robin Sheat [Fri, 17 Dec 2010 03:40:57 +0000 (22:40 -0500)]
Bug 5186 - allow tax rates to be set to zero (master)

This allows the tax rate for a vendor to be set to zero. Previously, a
zero meant that the system default was used. Now, zero means no tax, and
to have it be the default the field should simply be left empty.
Additionally:
* this will now show on the vendor display if the tax value is from the
  system default
* this includes a database update that changes all the existing 0.00 tax
  settings to be NULL, which preserves existing behaviour.
* this now saves the tax value supplied for new vendors

Note: this patch applies against master

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5522 - allow google preview to open in a new window
Robin Sheat [Fri, 17 Dec 2010 03:34:13 +0000 (22:34 -0500)]
Bug 5522 - allow google preview to open in a new window

If the OPACURLOpenInNewWindow system is set, then google preview links
will obey it.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoMerge remote branch 'kc/new/enh/bug_2965' into kcmaster
Chris Cormack [Mon, 20 Dec 2010 19:51:31 +0000 (08:51 +1300)]
Merge remote branch 'kc/new/enh/bug_2965' into kcmaster

11 years agoBug 2965: Follow up - fixing problem with barcode field
Katrin Fischer [Mon, 20 Dec 2010 19:24:31 +0000 (20:24 +0100)]
Bug 2965: Follow up - fixing problem with barcode field

The scanned barcode stayed in the checkout field instead of being
deleted after checkout or confirmation.

This patch reverts the template change, so the barcode is deleted.

Please test!

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoMerge remote branch 'kc/new/enh/bug_4473' into kcmaster
Chris Cormack [Mon, 20 Dec 2010 19:34:51 +0000 (08:34 +1300)]
Merge remote branch 'kc/new/enh/bug_4473' into kcmaster