koha.git
13 years ago[25/40] More work on label export coded and interface. Adding icons for all export...
Chris Nighswonger [Wed, 12 Aug 2009 21:05:40 +0000 (17:05 -0400)]
[25/40] More work on label export coded and interface. Adding icons for all export formats & general dressing up.

13 years ago[24/40] Adding single/multiple label printing to label export code and interface.
Chris Nighswonger [Tue, 1 Sep 2009 18:13:39 +0000 (14:13 -0400)]
[24/40] Adding single/multiple label printing to label export code and interface.

This adds single/multiple label printing by item number along with new CSV and XML export code.

13 years ago[23/40] Initial work on label export interface.
Chris Nighswonger [Mon, 10 Aug 2009 20:32:01 +0000 (16:32 -0400)]
[23/40] Initial work on label export interface.

13 years ago[22/40] General code cleanup of new labels module code.
Chris Nighswonger [Mon, 10 Aug 2009 16:45:43 +0000 (12:45 -0400)]
[22/40] General code cleanup of new labels module code.

13 years ago[21/40] Adding de-duplicating method and associated label edit batch code.
Chris Nighswonger [Tue, 1 Sep 2009 18:05:52 +0000 (14:05 -0400)]
[21/40] Adding de-duplicating method and associated label edit batch code.

13 years ago[20/40] Work on label printing code.
Chris Nighswonger [Wed, 5 Aug 2009 19:53:40 +0000 (15:53 -0400)]
[20/40] Work on label printing code.

13 years ago[19/40] Various tweaks to the interface cosmetics, form validation scripts, css,...
Chris Nighswonger [Wed, 5 Aug 2009 15:31:06 +0000 (11:31 -0400)]
[19/40] Various tweaks to the interface cosmetics, form validation scripts, css, etc.

13 years ago[18/40] Work on label item search.
Chris Nighswonger [Sat, 29 Aug 2009 05:26:13 +0000 (01:26 -0400)]
[18/40] Work on label item search.

13 years ago[17/40] Work on C4::Labels::Lib::html_table api to add link field option
Chris Nighswonger [Tue, 1 Sep 2009 18:18:52 +0000 (14:18 -0400)]
[17/40] Work on C4::Labels::Lib::html_table api to add link field option

13 years ago[16/40] Improvements to label management interface code.
Chris Nighswonger [Thu, 30 Jul 2009 04:14:58 +0000 (00:14 -0400)]
[16/40] Improvements to label management interface code.

13 years ago[15/40] Initial work on label batch edit interface.
Chris Nighswonger [Tue, 1 Sep 2009 16:33:52 +0000 (12:33 -0400)]
[15/40] Initial work on label batch edit interface.

13 years ago[14/40] Work on batch management interface.
Chris Nighswonger [Tue, 1 Sep 2009 16:29:39 +0000 (12:29 -0400)]
[14/40] Work on batch management interface.

13 years ago[13/40] Work on profile editor interface.
Chris Nighswonger [Tue, 28 Jul 2009 18:44:24 +0000 (14:44 -0400)]
[13/40] Work on profile editor interface.

13 years ago[12/40] Work on label managment interface.
Chris Nighswonger [Sat, 25 Jul 2009 03:03:50 +0000 (23:03 -0400)]
[12/40] Work on label managment interface.

13 years ago[11/40] Work on layout editor interface.
Chris Nighswonger [Sat, 25 Jul 2009 03:03:05 +0000 (23:03 -0400)]
[11/40] Work on layout editor interface.

13 years ago[10/40] Work on Label Tool Homepage.
Chris Nighswonger [Sat, 25 Jul 2009 03:02:09 +0000 (23:02 -0400)]
[10/40] Work on Label Tool Homepage.

13 years ago[9/40] Work on template interface.
Chris Nighswonger [Tue, 1 Sep 2009 16:17:10 +0000 (12:17 -0400)]
[9/40] Work on template interface.

13 years ago[8/40] Adding new layout management page
Chris Nighswonger [Mon, 20 Jul 2009 17:24:49 +0000 (13:24 -0400)]
[8/40] Adding new layout management page

This moves the layouts off of the labels tool start page to bring it into
conformity with the other parts of this tool.

13 years ago[7/40] Adding C4::Labels::Lib module
Chris Nighswonger [Mon, 20 Jul 2009 17:23:16 +0000 (13:23 -0400)]
[7/40] Adding C4::Labels::Lib module

Library of often used label related linear functions

13 years ago[6/40] Adding C4::Labels::Label Module
Chris Nighswonger [Mon, 20 Jul 2009 17:22:21 +0000 (13:22 -0400)]
[6/40] Adding C4::Labels::Label Module

Creates and manipulates Label objects

13 years ago[5/40] Adding C4::Labels::PDF module
Chris Nighswonger [Fri, 3 Jul 2009 13:29:33 +0000 (09:29 -0400)]
[5/40] Adding C4::Labels::PDF module

This module provides a very light wrapper for PDF::Reuse and PDF::Reuse::Barcode
to make them a psuedo-class and allow OO-like calls. (AKA... a hack.)

13 years ago[4/40] Work on C4::Labels::Batch module
Chris Nighswonger [Fri, 3 Jul 2009 13:28:51 +0000 (09:28 -0400)]
[4/40] Work on C4::Labels::Batch module

13 years ago[3/40] Work on C4::Labels::Profile module and tests
Chris Nighswonger [Wed, 1 Jul 2009 04:00:22 +0000 (00:00 -0400)]
[3/40] Work on C4::Labels::Profile module and tests

13 years ago[2/40] Work on C4::Labels::Template and associated tests
Chris Nighswonger [Tue, 1 Sep 2009 15:01:29 +0000 (11:01 -0400)]
[2/40] Work on C4::Labels::Template and associated tests

This commit also contains some work on C4::Labels::Layout as well

13 years ago[1/40] Work on C4::Labels::Layout module and tests
Chris Nighswonger [Mon, 29 Jun 2009 15:24:51 +0000 (11:24 -0400)]
[1/40] Work on C4::Labels::Layout module and tests

NOTE: This patch is the first of 40 which almost completely re-factor the
label creator code into a hopefully more scalable form. The new format is
a move in direction of OO handling labels, batches, templates, layouts, and
profiles as objects thus permitting easier implementation of features and
enhancements. It should be possible to export label data in any format one
might choose with the simple addition of a script similar to those included
which produce pdf, csv, and xml format.

One of the larger improvements is a change in workflow that results in template,
layout, and start label selection occurring just before export.

There are also various bugfixes and smaller interface improvements woven into it.

It should be noted that this patch series removes the patron card creator feature
for the present. This feature was only partially completed. A completed variation
will be submitted as a separate patch series to follow in the near future.

The following bugs and enhancements are fixed by this series of patches:

2944 Search to add items to a label batch broken
2061 labels_conf DB values: NULL vs. 0
2511 CSV format string is not cleared when unselected in the label layout editor
2515 Re-factor C4::Labels::DrawSpineText
2823 Label Generator not generating barcodes
3171 Problem due to internationalization in label-create-template.tmpl in de-DE and possibly others
3180 Active settings for label settings should be set at print time only

This work was sponsored by Foundations Bible College & Seminary, Dunn, NC USA

13 years agobug 3564 follow: ensure NoZebra is passed to templates
Galen Charlton [Mon, 31 Aug 2009 02:05:38 +0000 (22:05 -0400)]
bug 3564 follow: ensure NoZebra is passed to templates

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobugfix error if memcached_servers is empty in koha-conf.xml
Michael Hafen [Wed, 26 Aug 2009 22:43:59 +0000 (16:43 -0600)]
bugfix error if memcached_servers is empty in koha-conf.xml

XML::Simple returns by default an empty hash ref if it encounters an xml tag
with no attributes or content.  If memcached_servers is empty, as the installer
sets it when this feature is disabled, then we get the empty hash ref.

In checking if memcached_servers is set the empty hash ref evaluates as true.
I.E.

  $servers = C4::Context->config('memcached_servers');
  if ($servers) {

so we get a comiler error from memcached trying to resolve the nonexistant
server address.

13 years agoHide links to stop words management if NoZebra is ON. (Bug 3564)
Owen Leonard [Fri, 28 Aug 2009 14:16:14 +0000 (09:16 -0500)]
Hide links to stop words management if NoZebra is ON. (Bug 3564)

13 years agoAn additional icon for the Bridge set, "E Video, " contributed by John A. Graziano...
Owen Leonard [Sat, 29 Aug 2009 14:18:39 +0000 (09:18 -0500)]
An additional icon for the Bridge set, "E Video, " contributed by John A. Graziano Memorial Library

13 years agoBug 3547: Staff client call number searches right index now
Nicole Engard [Mon, 24 Aug 2009 03:15:23 +0000 (23:15 -0400)]
Bug 3547: Staff client call number searches right index now

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years ago(bug #3546) fix issues_stats
Nahuel ANGELINETTI [Mon, 24 Aug 2009 11:56:52 +0000 (13:56 +0200)]
(bug #3546) fix issues_stats

This fix the order of columns.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoAdding some caching to C4::Biblio, to GetMarcStructure
Chris Cormack [Tue, 25 Aug 2009 04:46:18 +0000 (16:46 +1200)]
Adding some caching to C4::Biblio, to GetMarcStructure

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoAdding sponsoring libraries, will try to go back and backfill
Chris Cormack [Mon, 24 Aug 2009 11:11:05 +0000 (23:11 +1200)]
Adding sponsoring libraries, will try to go back and backfill

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agograceful degradation if memcached option is not configured in koha-conf.xml
Galen Charlton [Mon, 24 Aug 2009 11:52:46 +0000 (07:52 -0400)]
graceful degradation if memcached option is not configured in koha-conf.xml

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoUpdating the Makefile so memcached configuration can be added to the koha-conf.xml...
Chris Cormack [Mon, 24 Aug 2009 08:49:11 +0000 (20:49 +1200)]
Updating the Makefile so memcached configuration can be added to the koha-conf.xml file

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoFailing gracefully if Memoize::Memcached is not installed
Chris Cormack [Mon, 24 Aug 2009 03:37:00 +0000 (15:37 +1200)]
Failing gracefully if Memoize::Memcached is not installed

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoStarting work on memoizing expensive functions with Memoize::Memcached
Chris Cormack [Mon, 24 Aug 2009 00:31:49 +0000 (12:31 +1200)]
Starting work on memoizing expensive functions with Memoize::Memcached

A patch will follow with the changes to the koha-conf.xml and with instructions on installing memcached

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3481: add deleditems.permanent_location (DB rev 052)
Galen Charlton [Mon, 24 Aug 2009 00:51:52 +0000 (20:51 -0400)]
bug 3481: add deleditems.permanent_location (DB rev 052)

Whenever a column is added to items, it must also be added
to deleteditems - otherwise, whenever an item is deleted,
it will not be saved to deleteditems.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoassigned typo fixes to DBrev 051
Galen Charlton [Mon, 24 Aug 2009 00:35:04 +0000 (20:35 -0400)]
assigned typo fixes to DBrev 051

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoFixed minor typos in new system preferences.
Nicole Engard [Sun, 23 Aug 2009 16:18:34 +0000 (12:18 -0400)]
Fixed minor typos in new system preferences.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoadded newlines back to sample_notices.sql
Galen Charlton [Mon, 24 Aug 2009 00:25:27 +0000 (20:25 -0400)]
added newlines back to sample_notices.sql

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 2611, 1934 followup - DBrevs 049 and 050
Galen Charlton [Mon, 24 Aug 2009 00:21:27 +0000 (20:21 -0400)]
bug 2611, 1934 followup - DBrevs 049 and 050

Assigned DBrevs as follows:

049: additional correction per bug 2611
050: OPACSearchForTitleIn system preference

Also fixed syntax errors in code for 050.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoREVISED: Fixed some typos and language in the sample notices.
Nicole Engard [Sun, 23 Aug 2009 10:49:18 +0000 (06:49 -0400)]
REVISED: Fixed some typos and language in the sample notices.

Realized that we don't want to update the notices in existing installs
as this would overwrite any changes and customizations libraries
may have made.

Original commit: 10b7bab4445c92f7f647be53e4b0ea858cbb2a84

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBug 1934: Add system preference to handle editing of 'More searches'
Nicole Engard [Sun, 23 Aug 2009 09:41:34 +0000 (05:41 -0400)]
Bug 1934: Add system preference to handle editing of 'More searches'

This preference allows librarians to control which links appear
in the 'More Searches' box on the opac detail page. If the
preference is left blank the 'More Searches' menu will not apear
on the opac detail page at all.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoChanged catlogue to catalog per the standard
Nicole Engard [Wed, 19 Aug 2009 03:01:40 +0000 (23:01 -0400)]
Changed catlogue to catalog per the standard

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoFixed some typos and language in the sample notices.
Nicole Engard [Sun, 16 Aug 2009 21:45:47 +0000 (17:45 -0400)]
Fixed some typos and language in the sample notices.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBUG 2611: Changed catalogue to catalog and fixed capitalization.
Nicole Engard [Sun, 16 Aug 2009 21:23:03 +0000 (17:23 -0400)]
BUG 2611: Changed catalogue to catalog and fixed capitalization.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 2611, 2761 followup
Galen Charlton [Sun, 23 Aug 2009 23:06:06 +0000 (19:06 -0400)]
bug 2611, 2761 followup

* set DB changes as revs 047 and 048
* ensured that itemcallnumber was widened to 255 in items and
  tmp_holdsqueue
* adjusted DB update descriptions

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBUG 2611: Changed catalogue to catalog and fixed capitalization.
Nicole Engard [Sun, 16 Aug 2009 21:23:03 +0000 (17:23 -0400)]
BUG 2611: Changed catalogue to catalog and fixed capitalization.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBUG 2761 Fix max length of itemcallnumber to 255
Nicole Engard [Sun, 16 Aug 2009 17:51:39 +0000 (13:51 -0400)]
BUG 2761 Fix max length of itemcallnumber to 255

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3464 followup - fix glitches
Galen Charlton [Sun, 23 Aug 2009 22:37:19 +0000 (18:37 -0400)]
bug 3464 followup - fix glitches

* Fixed 'counry' typo
* added country and B_country to deleteborrowers

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3464: set to DBrev 046 for new borrowers columns
Galen Charlton [Sun, 23 Aug 2009 22:20:25 +0000 (18:20 -0400)]
bug 3464: set to DBrev 046 for new borrowers columns

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3464: Takes columns country and B_country of table borrowers into account in...
Sébastien Hinderer [Sun, 2 Aug 2009 05:50:08 +0000 (07:50 +0200)]
bug 3464: Takes columns country and B_country of table borrowers into account in related operations.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoDatabase structure modification.
Sébastien Hinderer [Sat, 1 Aug 2009 11:05:55 +0000 (13:05 +0200)]
Database structure modification.

Adds the country and B_country columns to the borrowers table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3539: tweaked English description of HidePatronName syspref
Galen Charlton [Sun, 23 Aug 2009 17:57:26 +0000 (13:57 -0400)]
bug 3539: tweaked English description of HidePatronName syspref

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBug 3539, Adding a systempreference to hide borrowers name on the catalogue detail...
Chris Cormack [Wed, 19 Aug 2009 08:21:13 +0000 (20:21 +1200)]
Bug 3539, Adding a systempreference to hide borrowers name on the catalogue detail page, and holds page

Squashed commit of the following:

commit e9dd6e1dee03fe3503f7995b57510f9edfe6b333
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Wed Aug 19 08:14:53 2009 +0000

    Version number

commit df3ee5473e79b760a91c62b96d7ce19229e0fd27
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Wed Aug 19 08:08:11 2009 +0000

    French systempref

commit c4b036e4e43947d7d1fb9f2e18e460788cb4e1ec
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Wed Aug 19 00:25:33 2009 +0000

    Code to update the database, and updating the sysprefs.sql

commit f74b942c24d5e9c33a4ec0e5ac706a0e347eb1a7
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Tue Aug 18 02:07:22 2009 +0000

    Now hides the name on the detail screen too

commit 53c80dbef88e360a4bbb78ecff3a6ca6ec401398
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Tue Aug 18 01:35:19 2009 +0000

    Allowing the librarians to choose to hide the borrowers name on holds

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3485: fixed updatedatbase (also DBRev 043->044)
Galen Charlton [Sun, 23 Aug 2009 17:23:21 +0000 (13:23 -0400)]
bug 3485: fixed updatedatbase (also DBRev 043->044)

* Fixed case of copy-and-pastitis in DBrev descrieption
* Inserted description for new syspref

NOTE: Please do not leave the system preference description blank
in the updatedatabase entry - even for non-English users, an English
description is more useful than a blank one.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3485: Clear Borrower record after checkout.
PTFS Contractor [Sun, 26 Jul 2009 18:56:01 +0000 (19:56 +0100)]
bug 3485: Clear Borrower record after checkout.

Button added to clear the last Borrower record after transaction is complete
To enable, turn on the syspref DisplayClearScreenButton.

This work was sponsored by Middletown Township Public Library, Middletown, NJ USA

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3481: imporve cart_to_shelf.pl
Galen Charlton [Sun, 23 Aug 2009 17:06:00 +0000 (13:06 -0400)]
bug 3481: imporve cart_to_shelf.pl

Use revised CartToShelf() to insure that indexer
knows to reindex affected bib records.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3481 followup - ensure permanent location is stored when updating item
Galen Charlton [Sun, 23 Aug 2009 16:53:06 +0000 (12:53 -0400)]
bug 3481 followup - ensure permanent location is stored when updating item

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3481 followup - improve CartToShelf
Galen Charlton [Sun, 23 Aug 2009 16:51:12 +0000 (12:51 -0400)]
bug 3481 followup - improve CartToShelf

* added POD
* removed optional $barcode argument - in all cases,
  itemnumber is known, and we should stick with
  itemnumber when retrieving an existing item
* use ModItem to do the update so that indexer
  will know to reindex bib - otherwise, can't
  do an accurate search of items that are on
  the shelving cart.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3481 followup - set temporary processing location
Galen Charlton [Sun, 23 Aug 2009 16:49:17 +0000 (12:49 -0400)]
bug 3481 followup - set temporary processing location

Ensure that the temporary processing location is always
set regardless of whether one item is added or multiple
copies are added at once.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agocosmetic fix - use $itemnumber as argument to GetItems when available
Galen Charlton [Sun, 23 Aug 2009 16:48:34 +0000 (12:48 -0400)]
cosmetic fix - use $itemnumber as argument to GetItems when available

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3481 followup - add new sysprefs to circulation section
Galen Charlton [Sun, 23 Aug 2009 16:47:52 +0000 (12:47 -0400)]
bug 3481 followup - add new sysprefs to circulation section

13 years agobug 3481 followup - fix database update
Galen Charlton [Sun, 23 Aug 2009 16:46:28 +0000 (12:46 -0400)]
bug 3481 followup - fix database update

Set items.permanent_location to the current value
of items.location - otherwise, the item shelving location
could get blanked as existing items are checked in.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3481: Allow Item Temporary Locations for Processing and Shelving.
Colin Campbell [Mon, 27 Jul 2009 15:33:00 +0000 (16:33 +0100)]
bug 3481: Allow Item Temporary Locations for Processing and Shelving.

Allows temporary locations corresponding to 'in processing' and 'shelving'
so that newly-created items, and newly-returned items do not show
immediately as a available. Three new system preferences govern the usage
of these features.

NewItemsDefaultLocation. If system pref NewItemsDefaultLocation is set to a location code,
 all newly catalogued items will be set to the location set in this preference.
 Location code must be a valid LOC authorized value type.

InProcessingToShelvingCart. if the system pref InProcessingToShelvingCart is turned on,
any items run through returns.pl with a location code for 'PROC', will be modified to
have a new location code of 'CART'.

ReturnToShelvingCart.  If the syspref ReturnToShelvingCart is turned on,
all items returned other than confirmed holds will have a new location code of 'CART'.
Any item issued is automatically taken of the shelving cart.

Adds a cron script shelf_to_cart.pl which should be run hourly.
Updates all items with a location of CART to the item's permanent location.

The original location code is stored in the new items column 'permanent_location'.

Original Author: PTFS Contractor <dbavousett@ptfs.com>

This work co-sponsored by
  Middletown Township Public Library, Middletown, NJ USA  and
  East Brunswick Public Library, East Brunswick, NJ USA

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agofix how patron_flagged gets set for opac-user.tmpl
Galen Charlton [Sun, 23 Aug 2009 15:26:35 +0000 (11:26 -0400)]
fix how patron_flagged gets set for opac-user.tmpl

Remove unneeded variable and get value from $borr->{'flagged'}
directly, avoiding glitch where $borr->{'flagged'} could be
set after old $patron_flagged variable was set.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3493: DBrev 041->042 (added OPACFineNoRenewals)
Galen Charlton [Sun, 23 Aug 2009 14:16:41 +0000 (10:16 -0400)]
bug 3493: DBrev 041->042 (added OPACFineNoRenewals)

Also changed default value of OPACFineNoRenewals to 99999
when upgrading existing databases so that there's no (likely)
sudden change in OPAC behavior.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoPrevent OPAC renewals if fines are over limit
Jesse Weaver [Sun, 26 Jul 2009 12:28:47 +0000 (13:28 +0100)]
Prevent OPAC renewals if fines are over limit

This introduces a new system preference, OPACFineNoRenewals, that sets a
limit on the total fines a patron can have before they can no longer
renew their own books. opac-user.pl has been updated to obey this limit.

This work sponsered by East Brunswick Public Library, East Brunswick, NJ USA

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoimplement bailing out of AddReturn if IndependantBranches is on
Galen Charlton [Sun, 23 Aug 2009 14:01:19 +0000 (10:01 -0400)]
implement bailing out of AddReturn if IndependantBranches is on

If IndependantBranches is ON and user attempts to return an
item at a library other than the item's home library, bail out.
This action, which was previously just a suggestion in the code,
is now required to ensure that the item doesn't get its
holdingbranch set to the library at which the attempt to return
the item was made.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3409 followup - fix use of $hbr
Galen Charlton [Sun, 23 Aug 2009 13:53:56 +0000 (09:53 -0400)]
bug 3409 followup - fix use of $hbr

$hbr in this context is a branch code, not an
item field.

Also added use of C4::Debug;

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoAddReturn now always updates holdingbranch
Galen Charlton [Sun, 23 Aug 2009 13:51:50 +0000 (09:51 -0400)]
AddReturn now always updates holdingbranch

Prior to this patch, this was done only when returning
an item after it had been out on loan.  Even if the
item had not been on loan, the fact that it was checked
in means that it is now in fact at the new holding library.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3409 follow: fix crash if holdingbranch is undef
Galen Charlton [Sun, 23 Aug 2009 13:19:49 +0000 (09:19 -0400)]
bug 3409 follow: fix crash if holdingbranch is undef

Make _GetCircControlBranch() default to the item's home library
in the case where it otherwise would have returned the item's
holding library but that field is null.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3409 followup: renamed _GetCirculationBranch
Galen Charlton [Sun, 23 Aug 2009 13:03:11 +0000 (09:03 -0400)]
bug 3409 followup: renamed _GetCirculationBranch

New name is  _GetCircControlBranch so as not to confuse
the library that a circulation transaction is taking
place at with the library that is supposed to control
circulation policy lookup.

Also fixed formatting errors in _GetCircControlBranch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3409 followup: always set holdinglibrary to library last seen at
Galen Charlton [Sun, 23 Aug 2009 12:53:39 +0000 (08:53 -0400)]
bug 3409 followup: always set holdinglibrary to library last seen at

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBug fix 3409 : Adding an internal function to C4::Circulation
Henri-Damien LAURENT [Thu, 13 Aug 2009 12:58:26 +0000 (14:58 +0200)]
Bug fix 3409 : Adding an internal function to C4::Circulation

This patch add the use of CircControl and HomeOrHoldingBranch for return and transfert rules.
* ItemHomeLibrary goes to item{HomeOrHoldingBranch}
* PatronLibrary goes to the borrower library
* PickupLibrary depends where the items was checked out, and the actual library.

This add a little improvment that does not re-request each time the circcontrol syspref.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years ago(bug #2829) fix some mistakes extracting editor segment
Nahuel ANGELINETTI [Wed, 19 Aug 2009 13:22:24 +0000 (15:22 +0200)]
(bug #2829) fix some mistakes extracting editor segment

This patch fix how to extract the editor segment, and improve ISBN10/13 support.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBUG 3371: ISBN no longer shows twice when more options on
Nicole Engard [Sat, 22 Aug 2009 14:30:36 +0000 (10:30 -0400)]
BUG 3371: ISBN no longer shows twice when more options on

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBUG #3533: Fix documentation link in news for new installs
Nicole Engard [Sat, 22 Aug 2009 14:05:49 +0000 (10:05 -0400)]
BUG #3533: Fix documentation link in news for new installs

This patch only fixes the link for new installs, not for
updates.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoCleaned up display on reports page
Nicole Engard [Wed, 19 Aug 2009 01:31:03 +0000 (21:31 -0400)]
Cleaned up display on reports page

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoAdds helpful note to Home Phone and Home Email fields to remind staff which fields...
Liz Rea [Tue, 18 Aug 2009 14:47:08 +0000 (09:47 -0500)]
Adds helpful note to Home Phone and Home Email fields to remind staff which fields are shown on transit slips.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBug 2652 - This patch is an extension of the slip printing feature
Darrell Ulm [Wed, 19 Aug 2009 16:39:32 +0000 (12:39 -0400)]
Bug 2652 - This patch is an extension of the slip printing feature

and will print a SHORT SLIP of today's checkouts only.
 I also enhanced the normal slip to print the overdues separately as well as today's
 checkouts. There is another button on the print CIRC menu. Easily another quick key
 can be added, one for the regular slip and one for the short slip, i.e. today's
 only.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoAvoid numeric comparisons with leading zeroes
Colin Campbell [Thu, 20 Aug 2009 10:12:57 +0000 (11:12 +0100)]
Avoid numeric comparisons with leading zeroes

Numbers in perl with leading zeros are interpreted in octal
Ensure that comparisons are done using string operators
or where appropriate use the MARC::Field method

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoAdding Katrin to the tranlsation tab on the about page
Chris Cormack [Thu, 20 Aug 2009 10:40:19 +0000 (22:40 +1200)]
Adding Katrin to the tranlsation tab on the about page

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBug 3420: Revised follow-up patch for 'patrons with no checkouts'
Garry Collum [Thu, 20 Aug 2009 19:22:57 +0000 (15:22 -0400)]
Bug 3420: Revised follow-up patch for 'patrons with no checkouts'

Comments out all warnings that were used for debugging.

Enables warnigns and fixes the resulting warnings.

This patch replaces the previous follow-up patch for bug 3420.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBug 2889: Adds table highlighting to the Authority search results.
Garry Collum [Thu, 20 Aug 2009 22:07:08 +0000 (18:07 -0400)]
Bug 2889: Adds table highlighting to the Authority search results.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoEdits to the about page : Adding a couple of missing developers, and adding ohloh...
Chris Cormack [Thu, 20 Aug 2009 22:27:42 +0000 (10:27 +1200)]
Edits to the about page : Adding a couple of missing developers, and adding ohloh links, still more links to go

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBug 2505: Enables warnings in reserveratios.pl
Garry Collum [Thu, 20 Aug 2009 23:32:18 +0000 (19:32 -0400)]
Bug 2505: Enables warnings in reserveratios.pl

Also fixes resulting warnings.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoRemove utility script replaced by a test case
Frédéric Demians [Mon, 17 Aug 2009 18:35:27 +0000 (20:35 +0200)]
Remove utility script replaced by a test case

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBug 3532 show lost, damaged statuses on patron record
Jane Wagner [Mon, 17 Aug 2009 14:14:44 +0000 (10:14 -0400)]
Bug 3532 show lost, damaged statuses on patron record

The patron record Details tab list of checkouts does not show lost, long overdue, claims returned, or damaged status, only that an item is overdue.  Added a check for lost and damaged statuses and a display of any matching statuses to the patron Details tab.

(revised version to drop unneeded lines from moremember.tmpl file)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoTest case identifying incoherences between 'en' sysprefs and translated ones
Frédéric Demians [Mon, 17 Aug 2009 18:35:26 +0000 (20:35 +0200)]
Test case identifying incoherences between 'en' sysprefs and translated ones

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoFollow up patch for the about patch, changing management team to release team
Chris Cormack [Mon, 17 Aug 2009 10:52:04 +0000 (22:52 +1200)]
Follow up patch for the about patch, changing management team to release team

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoUpdating about page, some are bound to be missed, please send additional patches
Chris Cormack [Sat, 15 Aug 2009 22:18:16 +0000 (10:18 +1200)]
Updating about page, some are bound to be missed, please send additional patches

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBug 3420: Fixes 'Patrons with no checkouts' report.
Garry Collum [Sat, 15 Aug 2009 13:50:24 +0000 (09:50 -0400)]
Bug 3420: Fixes 'Patrons with no checkouts' report.

Fixed typo in SQL statement.  Commented out some unused SQL statements.

Removed limit for itemtype (column not available in results) and added limit for branchcode.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agofixed glitch in display of current time filter in OPAC top issues
Galen Charlton [Sat, 15 Aug 2009 13:45:38 +0000 (09:45 -0400)]
fixed glitch in display of current time filter in OPAC top issues

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoTranslating unimarc_leader plugin in english
Henri-Damien LAURENT [Thu, 13 Aug 2009 13:07:03 +0000 (15:07 +0200)]
Translating unimarc_leader plugin in english

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobugfix invalid comparison to ceilingDueDate in CalcDateDue()
Michael Hafen [Thu, 13 Aug 2009 22:12:33 +0000 (16:12 -0600)]
bugfix invalid comparison to ceilingDueDate in CalcDateDue()

The comparison to check the ceilingDueDate is done in the syspref format,
which isn't a good comparison.  This changes to code so the comparison is done
using iso format.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBug 2505: Enabled warnings in opac-topissues.pl
Garry Collum [Fri, 14 Aug 2009 00:31:39 +0000 (20:31 -0400)]
Bug 2505: Enabled warnings in opac-topissues.pl

Fixed resulting warnings and fixed a small bug with the timeLimit drop-down box.  It would not retain its value on subsequent pages if 'no Limit' was selected as an option.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBug 2553: Alphabetizes library and itemtype dropdown lists in Lost Items report.
Garry Collum [Fri, 14 Aug 2009 20:14:48 +0000 (16:14 -0400)]
Bug 2553: Alphabetizes library and itemtype dropdown lists in Lost Items report.

Form - Fixes alphabetization of dropdowns.

Results - Fixes format of "Date last seen" to be the system date preference.  Adds highlighting to the table.

Enables warnings. Pages generated no warnings.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoUpdated Help Files - Part 4
Nicole Engard [Sat, 15 Aug 2009 01:00:33 +0000 (20:00 -0500)]
Updated Help Files - Part 4

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>