koha.git
5 years agoBug 16169: Change prototype for C4::Biblio::TransformMarcToKoha
Jonathan Druart [Wed, 30 Mar 2016 10:58:31 +0000 (11:58 +0100)]
Bug 16169: Change prototype for C4::Biblio::TransformMarcToKoha

subroutines should not take $dbh in parameter.
C4::Biblio::TransformMarcToKoha has it and does not use it.

Test plan:
Look at the patch and confirm that all occurrences of
TransformMarcToKoha have been modified.

Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 16168: Eliminate unneeded C4::Context->dbh calls in C4/Biblio.pm
Jacek Ablewicz [Wed, 30 Mar 2016 10:21:03 +0000 (12:21 +0200)]
Bug 16168: Eliminate unneeded C4::Context->dbh calls in C4/Biblio.pm

Right now, ->dbh calls are actually quite expensive (they involve
DB connection health checks, each and every time). Some speed-sensitive
subroutines inside C4/Biblio.pm (GetMarcStructure, GetAuthorisedValueDesc)
have this statement

    my $dbh = C4::Context->dbh;

on top of the code, but they don't always/don't usually need DB
handle - not at that stage at least. This trivial patch eliminates
unneeded ->dbh calls in those subroutines. With it, average
GetMarcStructure() running time goes down from 14 miliseconds
to 9 miliseconds (on top of Bug 16166), it also makes catalogue
search profiling a bit easier.

Test plan:

1) apply patch
2) ensure that catalogue searches are still working
3) run t/*Biblio* tests

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 16183: Confirm message upon deleting patron messages
Aleisha [Thu, 31 Mar 2016 21:42:06 +0000 (21:42 +0000)]
Bug 16183: Confirm message upon deleting patron messages

To test:
1) Go to a patron circulation page and add a message
2) Click '[Delete]'
3) Confirm that a confirm dialog shows up and 'Cancel' and 'OK' do what
   is expected.

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 16193: Typo in Automatic item modifications by age
Aleisha [Mon, 4 Apr 2016 00:48:11 +0000 (00:48 +0000)]
Bug 16193: Typo in Automatic item modifications by age

To test:
1) Go to Tools -> Automatic item modifications by age
2) Click Edit
3) Add a rule if you have none, otherwise notice button 'Submit theses
   rules' and typo (theses)
4) Apply patch, refresh page
5) Confirm button now says 'Submit these rules' (typo is fixed)

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 16199: Remove C4::Ris::charconv
Jonathan Druart [Tue, 5 Apr 2016 06:52:50 +0000 (07:52 +0100)]
Bug 16199: Remove C4::Ris::charconv

This subroutine always returns what has been sent in parameter.
It is unecessary and can be removed.

Test plan:
  prove t/Ris.t
should not be noisy

Export a catalogue record in Ris should generate the same file with and
without this patch

NOTE: With/Without were identical in my testing.
      t/Ris.t is nicely silenced.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 16205 - MARC editor settings menu should use a Font Awesome icon
Owen Leonard [Tue, 5 Apr 2016 15:43:58 +0000 (11:43 -0400)]
Bug 16205 - MARC editor settings menu should use a Font Awesome icon

When I added the MARC editor settings menu in Bug 15859 I accidentally
used a Glyphicon. This patch corrects it to use a Font Awesome icon.

To test, apply the patch and open the basic cataloging editor. The
"Settings" menu should use a Font Awesome icon instead of a Glyphicon.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Icons changed
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Works as expected, no qa errors

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15928 - Show unlinked guarantor
Nick Clemens [Fri, 26 Feb 2016 21:08:55 +0000 (21:08 +0000)]
Bug 15928 - Show unlinked guarantor

To test:
1 - Add guarantor data to patron account by typing it in but do not 'Set to patron'
2 - Note it is not displayed on patron details
3 - Apply patch
4 - Note the info is displayed
5 - Test that linked guarantors show as expected

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Amended-patch: Correct some indents/spaces

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 16191: t/Ris.t is noisy
Mark Tompsett [Fri, 1 Apr 2016 21:59:29 +0000 (17:59 -0400)]
Bug 16191: t/Ris.t is noisy

TEST PLAN
---------
1) prove t/Ris.t
   -- very noisy
2) apply patch
3) prove t/Ris.t
   -- just one confusing noise.
4) run koha qa test tools

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years ago Bug 16171 - Show many media in html5media tabs
Alex Arnaud [Wed, 30 Mar 2016 14:49:10 +0000 (16:49 +0200)]
 Bug 16171 - Show many media in html5media tabs

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16184 - Report bor_issues_top shows incorrect number of rows
Mason James [Fri, 1 Apr 2016 02:56:34 +0000 (15:56 +1300)]
 Bug 16184 - Report bor_issues_top shows incorrect number of rows

TEST PLAN
---------
1) Have at least 6 patrons with checkouts and some checkins.
2) Reports -> Patrons with the most checkouts
3) Click 'Submit' (default is 5)
   -- more than 5 entries listed.
4) Apply patch
5) Refresh page
   -- only 5 entries listed.
6) Run koha qa test tools

NOTE: While this works, I'd be much happier with a refactor
      as it would also speed up the report. See comment #5.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16214: Fix typo 'To.jon' -> 'To.json'
Julian Maurice [Wed, 6 Apr 2016 14:12:16 +0000 (16:12 +0200)]
 Bug 16214: Fix typo 'To.jon' -> 'To.json'

Bug 15722 introduces a regression in serials patron search results,
causing the surname to not be displayed

To reproduce:
1. Create a routing list for a subscription
2. Click on "Add recipients" button
3. Run a search
4. Check that surname is not displayed

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 7736: (QA followup) Remove obsolete Schema module
Colin Campbell [Wed, 6 Apr 2016 17:45:42 +0000 (18:45 +0100)]
 Bug 7736: (QA followup) Remove obsolete Schema module

msg_invoice is not used merged into patch in error

Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16198: Fix regression in OPAC suggestions
Jonathan Druart [Tue, 5 Apr 2016 07:27:46 +0000 (08:27 +0100)]
 Bug 16198: Fix regression in OPAC suggestions

Introduced by
  commit d564d3732d95455b4626dfa8ca711cd658003c17
  Bug 15629: Koha::Libraries - Remove GetBranchInfo

If the branchcodesuggestedby is not defined, the find won't return
anything and ->branchname on an undefined value will raise
  Can't call method "branchname" on an undefined value at
  /home/katrin/kohaclone/opac/opac-suggestions.pl line 153.

Test plan:
-Staff
Create a patron
Use this patron to create a suggestion
Delete the patron

-OPAC
Logout and trigger opac/opac-suggestions.pl

Without this patch, you will get an error
With this patch applied, everything should be ok

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Works ok following test plan
No errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16215: Missing closing quote in checkout template
Owen Leonard [Wed, 6 Apr 2016 14:31:09 +0000 (10:31 -0400)]
 Bug 16215: Missing closing quote in checkout template

This patch adds a missing closing quote to the circulation template.

To see the affect of this bug:

- Log in to Koha with an account which does not have the
  'force_checkout' permission.
- Locate a barcode which is checked out to a patron.
- Open a different patron account for checkout.
- Try to check out the barcode to that different patron.

You see a "Cannot check out" dialog which breaks the structure of the
rest of the page.

To test, apply the patch and repeat the steps above. The issue should be
fixed.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years agoDBRev fix - "" was wrong smartquotes. fixed
Brendan A Gallagher [Tue, 5 Apr 2016 16:21:03 +0000 (16:21 +0000)]
DBRev fix - "" was wrong smartquotes.  fixed

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years agoDBrev adding in the missing update DBversion = "3.23.00.046";
Brendan A Gallagher [Tue, 5 Apr 2016 15:57:05 +0000 (15:57 +0000)]
DBrev adding in the missing update DBversion = "3.23.00.046";

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16194: Do not consider xslt as valid theme dir in LangInstaller.pm
Bernardo Gonzalez Kriegel [Mon, 4 Apr 2016 13:59:37 +0000 (10:59 -0300)]
 Bug 16194: Do not consider xslt as valid theme dir in LangInstaller.pm

Bug 15527 add an xslt dir, LangInstaller.pm must ingnore that dir.

To test:
1) Verify the problem on current master
Update translation for any lang, will see errors

2) Apply the patch

3) Update again, no errors

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Works as expected.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 14633: Patch to control.ini to add or dependency to libapache2-mpm-itk
John Seymour [Thu, 11 Feb 2016 03:38:15 +0000 (22:38 -0500)]
 Bug 14633: Patch to control.ini to add or dependency to libapache2-mpm-itk

The other attachment was not a patch which could be applied by
'git bz'. This corrects that.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
debian/update-control will need to be run after this is applied, but
it works well
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15967: Use the email template if the print template does not exist
Jonathan Druart [Mon, 4 Apr 2016 10:31:21 +0000 (11:31 +0100)]
 Bug 15967: Use the email template if the print template does not exist

From commit 581759e985c170db0edb4a895cda641930e5ac11
 Bug 14133: Print notices should be generated with the print
 template

"""
IMPORTANT NOTE: This test plan does not take into account the notices
generated for the staff ("These messages were not sent directly to the
patrons."). However the behavior will also change, the print template
will be used in all cases. Is it what we want?
"""

Yes, it is what we want. But if the print template does not exist, the
notice is not generated, we'd like to get the email template instead.

Test plan:
- Remove the print template for the letter you use for overdues
- Define an overdue rule to send an email
- Remove the email address for the patron which has overdues
- Execute the overdue_notices script
The staff should get an email notice and a print notice (using the
email template) should be generated for the patron

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15967: Fix regression from bug 14133 - notify the library if patron is not
Jonathan Druart [Thu, 3 Mar 2016 08:58:06 +0000 (08:58 +0000)]
 Bug 15967: Fix regression from bug 14133 - notify the library if patron is not

Regression introduced by bug 14133, see but 14133 comment 13.

Test plan:
Without this patch applied, if a patron cannot be notified (no email
address or sms number), the print notice generated for the library was
not.
With this patch applied, the print notice should be generated using the
print template

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years agoBug 7736: (QA followup) Add missing body id and class
Tomas Cohen Arazi [Mon, 4 Apr 2016 12:59:34 +0000 (09:59 -0300)]
Bug 7736: (QA followup) Add missing body id and class

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoUpdating the Schema for bugs 7736 and 15630
Brendan A Gallagher [Fri, 1 Apr 2016 22:05:12 +0000 (22:05 +0000)]
Updating the Schema for bugs 7736 and 15630

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15630 - Make Edifact module pluggable
Kyle M Hall [Mon, 21 Dec 2015 13:05:45 +0000 (13:05 +0000)]
 Bug 15630 - Make Edifact module pluggable

Koha's EDIFACT module works great for many European vendors,
but does not work will for US vendors, which have a much different
interpretation of 'standard'. In fact, each vendor may require
different arrangements of values in EDIFACT messages. It would be
impossible to encompass all these requirements within Koha's EDIFACT
module itself. Instead, we should allow the module to be pluggable, so
versions of the module can be developed for vendors that require EDIFACT
messages that don't conform to the standard set by Koha's EDIFACT
module.

Test Plan:
1) Apply this patch
2) Run updatedatabase
3) Enable Koha plugins
4) Install the Edifact stub plugin available at
   https://github.com/bywatersolutions/koha-plugin-edifact-stub
5) Edit the EDI Vendor account, assign the plugin to a Vendor EDI account
6) Test EDI functionality ( ORDER, INVOICE ), there should be no errors
   or changes to the EDIFACT message input or output

Signed-off-by: Jason DeShaw <JDeShaw@cityoffargo.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years agoBug 7736 - RM followup fixing/removing </title> on .tt
Brendan A Gallagher [Fri, 1 Apr 2016 21:20:56 +0000 (21:20 +0000)]
Bug 7736 - RM followup fixing/removing </title> on .tt

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years agoDBRev Bug 7736 - Edifact QUOTE and ORDER functionality
Brendan A Gallagher [Fri, 1 Apr 2016 20:54:09 +0000 (20:54 +0000)]
DBRev Bug 7736 - Edifact QUOTE and ORDER functionality

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 7736 amend edi_cron.pl to use new style call to Context
Colin Campbell [Fri, 18 Mar 2016 11:31:41 +0000 (11:31 +0000)]
 Bug 7736 amend edi_cron.pl to use new style call to Context

Bug 9006 changed the api for retrieving config values
from C4::Context after the removal of Autoload
This changes the syntax used to retrieve logdir to reflect
the correct syntax

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 7736 [QA Followup] - Fix spelling and pod errors
Kyle M Hall [Fri, 11 Mar 2016 14:01:24 +0000 (14:01 +0000)]
 Bug 7736 [QA Followup] - Fix spelling and pod errors

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 7736 [QA Followup] - Fix SQL, Add description field for Library EANs
Kyle M Hall [Fri, 11 Mar 2016 11:58:47 +0000 (11:58 +0000)]
 Bug 7736 [QA Followup] - Fix SQL, Add description field for Library EANs

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 7736 [QA Followup] - Fix column headers, values and spelling
Kyle M Hall [Thu, 10 Mar 2016 19:35:02 +0000 (19:35 +0000)]
 Bug 7736 [QA Followup] - Fix column headers, values and spelling

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 7736 [QA Followup] - Fix collation
Kyle M Hall [Thu, 10 Mar 2016 16:58:09 +0000 (16:58 +0000)]
 Bug 7736 [QA Followup] - Fix collation

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 7736 Add Edifact order fields to Acquisition.t
Zeno Tajoli [Tue, 27 Oct 2015 11:32:52 +0000 (12:32 +0100)]
 Bug 7736 Add Edifact order fields to Acquisition.t

Modification in Acquisition.t to support in test the new fields
of the table aqorders:
line_item_id, suppliers_reference_number,
suppliers_reference_qualifier, suppliers_report

Original patch by Zeno Tajoli
I amended to include the report field (ColinC)

Signed-off-by: Paul Johnson <p.johnson@staffs.ac.uk>
Signed-off-by: Sally Healey <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 7736: Support Ordering via Edifact EDI messages
Colin Campbell [Wed, 20 Jan 2016 11:31:31 +0000 (11:31 +0000)]
 Bug 7736: Support Ordering via Edifact EDI messages

Add support for processing incoming Edifact Quotes, Invoices
and order responses and generating and transmission of
Edifact Orders.
Basic workflow is that an incoming quote generates an aquisition
basket in Koha, with each line corresponding to an order record

The user can then generate an edifact order from this (or another)
basket, which is transferred to the vendor's site

The supplier generates an invoice on despatch and this will
result in corresponding invoices being generated in Koha
The orderlines on the invoice are receipted automatically.

We also support order response messages. This may include
simple order acknowledgements, supplier reports/amendments
on availability. Cancellation messages cause the koha order
to be cancelled, other messages are recorded against the order

Which messages are to be supported/processed is specifiable on a
vendor by vendor basis via the admin screens

You can also specify auto order i.e. to generate orders from quotes
without user intervention - This reflects existing
workflows where most work is done on the suppliers website
then generating a dummy quote

Received messages are stored in the edifact_messages table
and the original can be viewed via the online

Database changes are in installer/data/mysql/atomicchanges/edifact.sql
Note new perl dependencies:
    Net::SFTP:Foreign
    Text::Unidecode

Signed-off-by: Paul Johnson <p.johnson@staffs.ac.uk>
Signed-off-by: Sally Healey <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 10612: (QA followup)
Nick Clemens [Thu, 31 Mar 2016 15:53:31 +0000 (15:53 +0000)]
 Bug 10612: (QA followup)

Rename not_borrowered_since to not_borrowed_since

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 10612 - Unit tests
Nick Clemens [Wed, 30 Mar 2016 21:06:49 +0000 (21:06 +0000)]
 Bug 10612 - Unit tests

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 10612: Follow-up - correcting icon to be Font Awesome
Katrin Fischer [Mon, 28 Mar 2016 20:31:37 +0000 (22:31 +0200)]
 Bug 10612: Follow-up - correcting icon to be Font Awesome

- check print icon on the patron list summary page is correct

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 10612 [Follow-up] Combine and clarify menu items
Owen Leonard [Wed, 9 Mar 2016 16:48:39 +0000 (11:48 -0500)]
 Bug 10612 [Follow-up] Combine and clarify menu items

This follow-up patch for Bug 10612 moves all list operations into one
menu while (hopefully) clarifying the labels for each.

Also in this patch: Changed datatables sorting configuration to use the
"nosort" attribute.

To test, apply the patch and go to Tools -> Patron lists.

- On a patron list with no patrons, confirm that the "Actions"
  menu lists "Add patrons," "Edit list," and "Delete list."
- On a patron list containing one or more patrons, confirm that the
  "Actions" menu /also/ has these options: "Print patron cards," "Batch
  edit patrons," and "Batch delete patrons."
- Confirm that the "actions" column is not sortable.
- Test logging in as a user who has various combinations of permission
  to batch edit and batch delete.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 10612 - Add ability to delete patrons with batch patron deletion tool
Kyle M Hall [Wed, 11 Jun 2014 12:11:48 +0000 (08:11 -0400)]
 Bug 10612 - Add ability to delete patrons with batch patron deletion tool

This patch adds the ability to select a patron list for deletetion
when using the Batch patron deletion/anonymization tool. It also adds
buttons to the the patron lists table to access both the batch deletion
and batch modification directly from the lists view.

This is a squash of previous patches but now adds a patron_list_id
parameter to C4::Members::GetBorrowersToExpunge and uses that routine to
fetch patrons from a list.

Test Plan:
1) Apply this patch
2) Create a list of patrons with the new Patron Lists feature
3) Try using the batch edit link form the lists table
4) Try using the batch delete link from the lists table
5) Verify previous functionality has not changed

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Patron batches are correctly passed to the edit and delete pages.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years agoDBRev Bug 10988 - Allow login via Google OAuth2 (OpenID Connect)
Brendan A Gallagher [Fri, 1 Apr 2016 19:46:47 +0000 (19:46 +0000)]
DBRev Bug 10988 - Allow login via Google OAuth2 (OpenID Connect)

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 10988: Tabs vs Spaces qa failure patch
Mark Tompsett [Mon, 8 Feb 2016 22:54:12 +0000 (17:54 -0500)]
 Bug 10988: Tabs vs Spaces qa failure patch

Run Koha QA Test tools and discovered this failed because of tabs.
Rather than fail this and wait forever for it to get fixed, this
patches it, and I'll mark it as signed off anyways.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 10988 - Fix some wording Fix some outdated wording in googleopenidconnect
Nicholas van Oudtshoorn [Mon, 11 Jan 2016 09:01:02 +0000 (17:01 +0800)]
 Bug 10988 - Fix some wording Fix some outdated wording in googleopenidconnect

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 10988 - Fixes for comments 57 and 58
Nicholas van Oudtshoorn [Mon, 11 Jan 2016 08:47:41 +0000 (16:47 +0800)]
 Bug 10988 - Fixes for comments 57 and 58

    Test Plan (remains the same):
     0) Back up your database
     1) Apply all these patches
     2) In your mysql client use your Koha database and execute:
        > DELETE FROM systempreferences;
        > SOURCE ~/kohaclone/installer/data/mysql/sysprefs.sql;
        -- Should be no errors.
        > SELECT * FROM systempreferences LIKE 'GoogleO%';
        -- Should see 4 entries.
        > QUIT;
     3) Restore your database
     4) Run ./installer/data/mysql/updatedatabase.pl;
     5) In your mysql client use your Koha database and execute:
        > SELECT * FROM systempreferences LIKE 'GoogleO%';
        -- Should see the same 4 entries.
     6) Log into the staff client
     7) Home -> Koha administration -> Global system preferences
     8) -> OPAC
        -- make sure your OPACBaseURL is set (e.g. https://opac.koha.ca)
     9) -> Administration
        -- There should be a 'Google OAuth2' section with the ability
           to set those 4 system preferences.
    10) In a new tab, go to https://console.developers.google.com/project
    11) Click 'Create Project'
    12) Type in a project name that won't freak users out, like your
        library name (e.g. South Pole Library).
    13) Click the 'Create' button.
    14) Click the 'APIs & auth' in the left frame.
    15) Click 'Credentials'
    16) Click 'Create new Client ID'
    17) Select 'Web application' and click 'Configure consent screen'.
    18) Select the Email Address.
    19) Put it a meaningful string into the Product Name
        (e.g. South Pole Library Authentication)
    20) Fill in the other fields as desired (or not)
    21) Click 'Save'
    22) Change the 'AUTHORIZED JAVASCRIPT ORIGINS' to your OPACBaseURL.
        (http://library.yourDNS.org)
    23) Change the 'AUTHORIZED REDIRECT URIS' to point to the new
        googleoauth2 script
        (http://library.yourDNS.org/cgi-bin/koha/svc/auth/googleopenidconnect)
    24) Click 'Create Client ID'
    25) Copy and paste the 'CLIENT ID' into the GoogleOAuth2ClientID
        system preference.
    26) Copy and paste the 'CLIENT SECRET' into the GoogleOAuth2ClientSecret
        system preference.
    27) Change the GoogleOpenIDConnect preference to 'Use'.
    28) Click 'Save all Administration preferences'
    29) In the OPAC, click 'Log in to your account'.
        -- You should get a confirmation request, if you are
            already logged in, OR a login screen if you are not.
        -- You need to have the primary email address set to one
           authenticated by Google in order to log in.
    30) Run koha qa test tools

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 11807: (follow-up) remove date conversions
Joonas Kylmälä [Mon, 31 Aug 2015 09:41:34 +0000 (09:41 +0000)]
 Bug 11807: (follow-up) remove date conversions

To test

1/ Apply both patches

2/ This patch lets you easily configure mappings for categorycode values.
These mapping will be used when updating the user's account after a successful LDAP login.

Here is an example configuration :

<config>
  <ldapserver id="ldapserver>
    <mapping>
      <categorycode is="usertype">STU</categorycode>
      ...
    </mapping>

    <categorycode_mapping>
      <categorycode value="STU">STUDENT</categorycode>
      <categorycode value="EMP">EMPLOYEE</categorycode>
    </categorycode_mapping>
  </ldapserver>
</config>

3/ With this configuration, LDAP users with the usertype value "EMP" on the LDAP server should have the "EMPLOYEE" categorycode in Koha.

Signed-off-by: Chris <chris@bigballofwax.co.nz>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 11807 : Add support for categorycode conversions when updating an user using...
Frédérick [Wed, 19 Feb 2014 17:02:41 +0000 (12:02 -0500)]
 Bug 11807 : Add support for categorycode conversions when updating an user using a LDAP server.

To test

1/ Apply both patches

2/ This patch lets you easily configure mappings for categorycode values.
These mapping will be used when updating the user's account after a successful LDAP login.

Here is an example configuration :

<config>
  <ldapserver id="ldapserver>
    <mapping>
      <categorycode is="usertype">STU</categorycode>
      ...
    </mapping>

    <categorycode_mapping>
      <categorycode value="STU">STUDENT</categorycode>
      <categorycode value="EMP">EMPLOYEE</categorycode>
    </categorycode_mapping>
  </ldapserver>
</config>

3/ With this configuration, LDAP users with the usertype value "EMP" on the LDAP server should have the "EMPLOYEE" categorycode in Koha.

Signed-off-by: Chris <chris@bigballofwax.co.nz>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16068: Do not cache overridden prefs
Jonathan Druart [Tue, 15 Mar 2016 09:38:20 +0000 (09:38 +0000)]
 Bug 16068: Do not cache overridden prefs

These prefs do not need to be cached, a quick access to $ENV permit to
get the value.

Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16173: db_structure.t shouldn't have a fixed number of tests
Tomas Cohen Arazi [Wed, 30 Mar 2016 15:46:30 +0000 (12:46 -0300)]
 Bug 16173: db_structure.t shouldn't have a fixed number of tests

This patch makes db_structure.t more flexible regarding how many tests are run.
This is important because it would fail on each db structure change, masking potential
real problems.

To test:
- Run
  $ prove t/db_dependent/db_structure.t
=> FAIL: the number of tests ran doesn't match what is expected
- Apply the patch
- Run
  $ prove t/db_dependent/db_structure.t
=> SUCCESS: Tests count is not an issue [1]
- Sign off

[1] Right now the tests run successfuly, they might fail if a real bug is introduced
on the DB structure, in the meantime.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16185: t/db_dependent/Reports_Guided.t is failing
Mark Tompsett [Fri, 1 Apr 2016 13:31:41 +0000 (09:31 -0400)]
 Bug 16185: t/db_dependent/Reports_Guided.t is failing

TEST PLAN
---------
1) prove t/db_dependent/Reports_Guided.t
   -- fails
   -- note the failure has a scalar function-like bracketing
2) apply patch
3) prove t/db_dependent/Reports_Guided.t
   -- passes
4) git diff origin/master
   -- note all scalars have been changed to not have
      function-like brackets which could be incorrectly
      parsed.
5) run koha qa test tools

Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15745: C4::Matcher gets CCL parsing error if term contains ? (question mark)
David Cook [Fri, 5 Feb 2016 05:09:45 +0000 (16:09 +1100)]
 Bug 15745: C4::Matcher gets CCL parsing error if term contains ? (question mark)

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi>
Also fixes ! and +
Rebased to master
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
It makes perfect sense and works as expected. This part of the code is too
under-tested so no point requiring a regression test for such a simple change.

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16174: (QA followup) Fix remaining tests
Tomas Cohen Arazi [Thu, 31 Mar 2016 14:21:14 +0000 (11:21 -0300)]
 Bug 16174: (QA followup) Fix remaining tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16174: icondirectories.t broken due to bug 15527
Tomas Cohen Arazi [Wed, 30 Mar 2016 19:11:19 +0000 (16:11 -0300)]
 Bug 16174: icondirectories.t broken due to bug 15527

This patch fixes it.

To test:
- Run
  $ prove xt/author/icondirectories.t
=> FAIL: Tests fail:
   Failed test 'opac_icon_directory: koha-tmpl/opac-tmpl/xslt/itemtypeimg exists'
- Apply the patch
- Run
  $ prove xt/author/icondirectories.t
=> SUCCESS: Tests pass and don't raise warnings.
- Sign off

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16174: Warning in tt_valid.t due to bug 15527
Tomas Cohen Arazi [Wed, 30 Mar 2016 18:15:02 +0000 (15:15 -0300)]
 Bug 16174: Warning in tt_valid.t due to bug 15527

Bug 15527 introduced a new directory (xslt) on the top level OPAC templates
directory. The tt_valid.t script should include that top level dir on the list
of excluded dirs so it doesn't look for themes there.

To test:
- Run
  $ prove xt/tt_valid.t
=> FAIL: You get the following warning:
Can't stat koha-tmpl/opac-tmpl/xslt/en: No such file or directory
 at xt/tt_valid.t line 8
- Apply the patch
- Run
  $ prove xt/tt_valid.t
=> SUCCESS: Tests pass and don't raise warnings.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16176: Fix a test about OpenLibrarySearch
Jonathan Druart [Thu, 31 Mar 2016 07:27:02 +0000 (08:27 +0100)]
 Bug 16176: Fix a test about OpenLibrarySearch

Introduced by bug 6624: When C4::UsageStats::BuildReport is modified,
the tests should be too.

Test plan:
  prove t/db_dependent/UsageStats.t
should return green

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Note that if we maintain this list of sysprefs at two places, we will
probably have this test failing regularly..

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16177: Fix tests for ColumnsSsettings.t
Jonathan Druart [Thu, 31 Mar 2016 07:59:29 +0000 (08:59 +0100)]
 Bug 16177: Fix tests for ColumnsSsettings.t

This failure has been introduced by
  commit 243b797dd11bc0ac1f475195ab765ffbf2220f8b
    Bug 15285: Update common files

This is because the cannot_be_modified key is not always created by
C4::Utils::DataTables::ColumnsSettings subroutines

Test plan:
  prove t/db_dependent/ColumnsSettings.t
should return green
And you can also test a table where the feature is set and a column
cannot be modified from the admin page.

NOTE: Works as described. I was pondering this potential
      solution when I found it in bugzilla.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16178: Fix tests for xt/single_quotes.t
Jonathan Druart [Thu, 31 Mar 2016 08:06:14 +0000 (09:06 +0100)]
 Bug 16178: Fix tests for xt/single_quotes.t

Caused by
  commit 9c5c1bc9f104b125e06b3805ce510024e6ad34ac
    Bug 15206: Make strings translatable

Test plan:
  prove xt/single_quotes.t
should return green

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16056: Do not crash when searching for an authority if zebra's index is not...
Jonathan Druart [Mon, 21 Mar 2016 15:25:41 +0000 (15:25 +0000)]
 Bug 16056: Do not crash when searching for an authority if zebra's index is not up-to-date

This patch fixes a regression introduced by
commit 7e70202d34d75f988fbaea9b911347417c203aac
  Bug 15381: Remove GetAuthType and GetAuthTypeCode

This first version will reintroduce the same behavior as before bug
15381: the record will be displayed even if it's no in the DB

Test plan:
Search for authorities
delete one
The zebra's index is not updated yet and the results will contain the
record you have deleted.

Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16129: Remove URL::Encode dependency
Tomas Cohen Arazi [Tue, 22 Mar 2016 20:17:59 +0000 (17:17 -0300)]
 Bug 16129: Remove URL::Encode dependency

This patch makes the PayPal integration feature independent from the
URL::Encode library, which is absent in some supported distributions.

It uses the URI package which is already a Koha dependency.

To test:
- Apply the patch
- Notice there are no deps for URL::Encode
- Follow the steps from the original patch
=> SUCCESS: It works as expected
- Sign-off :-D

Note: I deleted the line in which $amount_to_pay was url-encoded, because that's
one of the things query_form does (and the variable is only used as a parameter to it).

Sponsored-by: ByWater Solutions
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16138: Restart plack when rotating logfiles
Tomas Cohen Arazi [Wed, 23 Mar 2016 18:53:01 +0000 (15:53 -0300)]
 Bug 16138: Restart plack when rotating logfiles

On log rotation Starman/Plack keeps failing (Auth.pm related problems) due to
permission issues:

Could not compile /usr/share/koha/opac/cgi-bin/opac/opac-search.pl: Can't locate Authen/CAS/Client/Response/Failure.pm
:   ./Authen/CAS/Client/Response/Failure.pm: Permission denied at /usr/share/perl/5.20/base.pm line 97.
        ...propagated at /usr/share/perl/5.20/base.pm line 106.
BEGIN failed--compilation aborted at /usr/share/perl5/Authen/CAS/Client/Response.pm line 68.
Compilation failed in require at /usr/share/perl5/Authen/CAS/Client.pm line 8.
BEGIN failed--compilation aborted at /usr/share/perl5/Authen/CAS/Client.pm line 8.
Compilation failed in require at /usr/share/koha/lib/C4/Auth_with_cas.pm line 25.
BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Auth_with_cas.pm line 25.
Compilation failed in require at /usr/share/koha/lib/C4/Auth.pm line 63.
BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Auth.pm line 90.
Compilation failed in require at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34.
BEGIN failed--compilation aborted at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34.

As we do with zebra daemons, starman should be restarted as it doesn't handle log file rotation
gracefully[1].

I'm not sure how to reproduce it on a dev environment.

[1] https://github.com/miyagawa/Starman/issues/55

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16186: t/db_dependent/Circulation_Issuingrule.t is failing
Mark Tompsett [Fri, 1 Apr 2016 14:19:45 +0000 (10:19 -0400)]
 Bug 16186: t/db_dependent/Circulation_Issuingrule.t is failing

TEST PLAN
---------
1) prove t/db_dependent/Circulation_Issuingrule.t
   -- fails
2) apply patch
3) prove t/db_dependent/Circulation_Issuingrule.t
   -- pass
4) git diff origin/master -- t/db_dependent/Circulation_Issuingrule.t
   -- notice that bug 5876 and bug 9129 combined to cause this
5) run koha qa test tools

Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years agoBug 15889: LDAP authentication: Only update mapped attributes
Alex Arnaud [Wed, 24 Feb 2016 09:13:40 +0000 (10:13 +0100)]
Bug 15889: LDAP authentication: Only update mapped attributes

Test plan:

- Update your configuration file to use LDAP authentication and enable update
  (<update>1</update>) option,
- login with an existing user with extended attrbitutes that are not in
LDAP mapping,
- check that all attributes are still here.

Signed-off-by: Chris <chrisc@catalyst.net.nz>
Signed-off-by: Philippe Blouin <philippe.blouin@inlibro.com>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
5 years ago Bug 14257: Follow-up - Add documentation, fix typo, fix test
Katrin Fischer [Wed, 30 Mar 2016 06:12:56 +0000 (08:12 +0200)]
 Bug 14257: Follow-up - Add documentation, fix typo, fix test

- t/db_dependent/ILSDI_Services.t was failing for me as I had
  issues in my database, fixed with another delete line
- QA tools found a typo - comparision
- Added documentation of the new parameter to the ilsdi.pl page

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 14257 - Add show_attributes to GetPatronInfo
Martin Persson [Mon, 9 Nov 2015 13:34:40 +0000 (14:34 +0100)]
 Bug 14257 - Add show_attributes to GetPatronInfo

This patch adds the ability to query the extended patron
attributes via the ILSDI web service's GetPatronInfo service.

Example: ilsdi.pl?service=GetPatronInfo&patron_id=3&show_attributes=1

A new element <attributes> will be added if there
are any attributes available from the database.

We need to discuss the security implications of showing the
attributes. At present it will allow querying of non-public
(OPAC-visible) information. We might want to change this.

Sponsored-By: Halland County Library
Test plan:

* Configure Koha to make use of extended attributes:
  Under 'Administration' -> 'Global system preferences' ->
  'Patrons' tab -> Set 'ExtendedPatronAttributes' to 'Enable',
  press save and switch to 'Web services' tab.

* Enable the ILS-DI service:
  Under 'Administration' -> 'Global system preferences' ->
  'Web services' tab -> 'ILS-DI' section:
  Set 'ILS-DI' to 'Enable' and save.

* Create an attribute to query:
  Under 'Administration' -> 'Patrons and circulation' ->
  'Patron attribute types' press 'New patron attribute type':
  Enter a type code, like 'DOORCODE', description and assign
  a category that your test patron is a member of, then save.

* Set value for test user:
  Locate the test patron, the new attribute should be listed
  under 'Additional attributes and identifiers'.
  Click 'Edit' and assign a value, like '1337' and save.

* Query the ILS-DI service:
  http://127.0.1.1/cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=1&show_attributes=1
  The output XML should have an element named 'attributes'
  containing the data you entered.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 14257 - Add show_attributes to GetPatronInfo
Martin Persson [Thu, 12 Nov 2015 15:14:04 +0000 (16:14 +0100)]
 Bug 14257 - Add show_attributes to GetPatronInfo

Added unit tests to for GetBorrowerAttributes and GetPatronInfo.

Sponsored-By: Halland County Library
Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 14512 - Add support for AV field to Koha's SIP2 Server
Kyle M Hall [Thu, 9 Jul 2015 13:53:31 +0000 (09:53 -0400)]
 Bug 14512 - Add support for AV field to Koha's SIP2 Server

Koha's SIP2 server should have support for the AV field ( field items ).
The biggest problem with this field is that its' contents are not really
defined in SIP2 protocol specification. All it says is "this field
should be sent for each fine item". Due to this, I think the contents of
the field need to be configurable at the login level, so that the
contents can be defined based on the SIP2 devices requirements for the
AV field.

Test Plan:
1) Apply this patch
2) Find a patron with outstanding fines
3) Run a patron information request using misc/sip_cli_emulator.pl using the new -s option with the value "   Y      "
4) Note there is an AV field for each fee containing the description and amount
5) Edit your sip config, add an av_field_template parameter to the login you are using such as
    av_field_template="TEST [% accountline.description %] [% accountline.amountoutstanding | format('%.2f') %]"
6) Restart your SIP server
7) Repeat the patron information request
8) Note your custom AV field is being used!

Signed-off-by: Chris Davis <cgdavis@uintah.utah.gov>
Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15931: Replace relative path with /cgi-bin/koha/
Jonathan Druart [Thu, 24 Mar 2016 22:09:07 +0000 (22:09 +0000)]
 Bug 15931: Replace relative path with /cgi-bin/koha/

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15931: Removing link to records if authority is not used by any records
Aleisha [Mon, 29 Feb 2016 00:42:28 +0000 (00:42 +0000)]
 Bug 15931: Removing link to records if authority is not used by any records

EDIT:
Fixing typo: records(s) -> record(s)
On details page, if authority is not used in any records, the page will display a more used friendly message: "This authority is not used in any records."

To test:
1) Do an authority search on authorities-home.pl. Notice that authorities not used in any records have a clickable link (under 'Used in:' column) which redirects to a catalog search with no results
2) Go back to your authority search results on authorities-home.pl and click 'Details'. Notice that under the auth name, there is a 'Used in X records' link that again returns a catalog search with no results.
3) Apply patch
4) Repeat steps 1, 2. Authorities not used in any records should no longer have clickable links and links to authorities which are used in records should work as expected.
5) Confirm it now says record(s) instead of records(s)
6) Confirm that on detail page for an authority which is not used by any records, it now says more friendly message.

Sponsored-by: Catalyst IT
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16058: Delete individual news item from koha-news.pl
Aleisha [Tue, 29 Mar 2016 02:29:26 +0000 (02:29 +0000)]
 Bug 16058: Delete individual news item from koha-news.pl

This patch adds a confirm message for deleting a news item from the home page in the staff client. It also gives the ability to delete an individual news item from koha-news.pl with a confirm message. The buttons on koha-news.pl are now styled as font awesome buttons.

To test:
1) Go to main intranet page. Click 'Delete' for a news item.
2) Confirm that Cancel stops the Delete, and OK deletes the item and takes you to tools/koha-news.pl
3) Confirm that the buttons (Edit and Delete) on koha-news.pl are now styled as font awesome buttons and the buttons don't wrap on a narrow browser.
4) Confirm that the column heading for the buttons is now "Actions".
5) Confirm that clicking Delete triggers a confirm message. Confirm that Cancel stops the Delete, and OK deletes the item and it no longer shows in the News table or anywhere else.

Sponsored-by: Catalyst IT
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Amended-patch: just split the td on several lines for readability.

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years agoDBrev Bug 16070 - Empty (undef) system preferences may cause some issues
Brendan A Gallagher [Thu, 31 Mar 2016 19:56:00 +0000 (19:56 +0000)]
DBrev Bug 16070 - Empty (undef) system preferences may cause some issues
in combination with memcache

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16070: Add atomic update file
Jonathan Druart [Thu, 17 Mar 2016 10:58:16 +0000 (10:58 +0000)]
 Bug 16070: Add atomic update file

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16070: Default value for sysprefs should be an empty string
Jonathan Druart [Tue, 15 Mar 2016 10:05:06 +0000 (10:05 +0000)]
 Bug 16070: Default value for sysprefs should be an empty string

The default value for sysprefs should not be NULL but an empty string.
When a pref is cleared, it's set to an empty string, so it does not make
sense to create it with an undefined value.

The main purpose of this patch is to remove the warning in logs when a
pref is accessed for the first time and the cache is not yet populated.
It also ensures that the behavior will be the same for the first access
and the others.

Test plan:
SELECT COUNT(*) FROM systempreferences WHERE value IS NULL;
Should not return any results after the update DB entry executed.

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16092: Fix error dialog and introduce the Font Awesome icons when delete a branc...
Hector Castro [Thu, 17 Mar 2016 16:42:10 +0000 (10:42 -0600)]
 Bug 16092: Fix error dialog and introduce the Font Awesome icons when delete a branch category

Also change admin/branch.pl   type => 'error' to type => 'alert' to fit
with wiki <https://wiki.koha-community.org/wiki/Interface_patterns#Errors_and_messages>

To test:
1) Go to Admin -> Libraries and groups
2) Try to delete a library with patrons and bib items
3) See the error message in yellow
4) Try to delete a branch category/group without any library attached
   to it
5) Apply patch and repeat steps 1 to 4. Notice about the changes
6) Test buttons Yes, delete and No, do not delete and verify that they
   work as expected

Signed-off-by: Marc Véron <veron@veron.ch>
NOTE: Patch rebased and reword title according with QA comment 4

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16152: Rename column to Actions
Aleisha [Tue, 29 Mar 2016 06:59:12 +0000 (06:59 +0000)]
 Bug 16152: Rename column to Actions

To test:
1) Go to Tools -> Label Creator -> Manage label batches
2) Confirm table heading is now 'Actions'

Sponsored-by: Catalyst IT
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16153: Adding "actions" class to Label Creator table actions so the buttons...
Aleisha [Tue, 29 Mar 2016 07:09:10 +0000 (07:09 +0000)]
 Bug 16153: Adding "actions" class to Label Creator table actions so the buttons dont wrap

To test:
1) Go to Tools -> Label Creator
2) Confirm that the actions column for the table on each management page (Manage label batches, Manage layouts, Manage label templates, Manage printer profiles) does not wrap on narrow browser windows.

Sponsored-by: Catalyst IT
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16163: Show message if there are no dictionary definitions
Aleisha [Tue, 29 Mar 2016 23:51:02 +0000 (23:51 +0000)]
 Bug 16163: Show message if there are no dictionary definitions

To test:
1) Go to Reports -> View dictionary
2) Ensure you have no definitions
3) A message should show saying 'There are no saved definitions. Add a definition to the dictionary.'
4) Click the link to add a definition. Confirm this takes you to the form to add a new definition.

Sponsored-by: Catalyst IT
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 11498 - Prevent bypassing sco timeout with print dialog
Marc Véron [Wed, 10 Feb 2016 16:21:40 +0000 (17:21 +0100)]
 Bug 11498 - Prevent bypassing sco timeout with print dialog

This patch prevents bypassing the self check timeout with the print dialog.

To test:
- Set syspref 'WebVasedSelfCheck' to 'Enable'
- Set syspref 'SelfCheckoutReceivePrompt' to 'Show'
- Set syspref 'SelfCheckTimeout' to 20 seconds
- Apply patch
- Go to SCO page (/cgi-bin/koha/sco/sco-main.pl)
- Enter card number
- Click 'Finish'. Dialog "Would you like to pritn a receipt?' appears.
- Confirm printing without waiting 20 seconds
  => Result: Print slip, SCO page shows 'Please enter your card number'
- Enter card number again
- Click 'Finish'. Dialog "Would you like to pritn a receipt?' appears.
- Wait > 20 seconds (value of SelfCheckTimeout) and then confirm.
  => Result: Message appears "Timeout while waiting for print confirmation"
- Click on OK.
  => Result: Self checkout page refreshes (shows 'Please enter your card number')

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
https://bugs.koha-community.org/show_bug.cgi?id=11497

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 13132: Add confirm dialog for deleting reports from the reports toolbar
Aleisha [Tue, 29 Mar 2016 23:27:23 +0000 (23:27 +0000)]
 Bug 13132: Add confirm dialog for deleting reports from the reports toolbar

To test:

1) Go to Reports -> Use saved (or build a new one if you have none saved)
2) Click on the Actions drop down and confirm that when you click Delete from here, a confirm message shows up. Click Cancel.
3) Click Show in the drop down menu
4) Click Delete in the Reports toolbar. Confirm you now get a confirm message. Clicking Cancel will cancel the delete, and clicking OK deletes the report and takes you to the saved reports page.

Spponsored-by: Catalyst IT
Signed-off-by: Magnus Enger <magnus@libriotech.no>
After applying the patch I get a JavaScript popup confirmation when
I click on the delete button, in the Show, Edit and Run views. Nice!

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15323: Use fixtures for the active currency
Jonathan Druart [Wed, 30 Mar 2016 10:30:01 +0000 (11:30 +0100)]
 Bug 15323: Use fixtures for the active currency

  prove t/Prices.t
fails after bug 15084 has been pushed
It's caused by
  commit 1538e9ecf47642c4974693ff499c3e95e4d71977
    Bug 15084: Replace C4::Budgets::GetCurrencies with
    Koha::Acquisition::Currencies->search

Koha::Number::Price->_format_params calls
Koha::Acquisition::Currencies->get_active, which requests the DB.
The currency data should be mocked.

Test plan:
sudo service mysql stop
prove t/Prices.t
 should return green

Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Patch works as expected and passes the qa-tools tests.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years agofixing DBrev Bug 16103
Brendan A Gallagher [Thu, 31 Mar 2016 17:54:46 +0000 (17:54 +0000)]
fixing DBrev Bug 16103

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 15793 - UX of circulation patron search with long lists of returned borrowers
Aleisha [Wed, 23 Mar 2016 21:53:44 +0000 (21:53 +0000)]
 Bug 15793 - UX of circulation patron search with long lists of returned borrowers

Okay how about this:
This patch has no floating toolbar or names styled as links. I've removed the radio buttons. The row is clickable and will redirect you to the user's page.

EDIT: This patch makes the cursor a pointer when hovering over the patrons. The row will also be highlighted on hover to make it even clearer.
EDIT2: Removes unnecessary 'Select' button

To test:
1) Put in a patron search that will bring back a long list of patrons (ie the letter 'a')
2) Select a patron by clicking anywhere on the row - confirm you are taken to the correct patron page

Sponsored-by: Catalyst IT
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Submit button removed, patron selection on this screen much better for long lists (and short ones as well.)

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years agoUpdate Schema Bug 16004 - Replace items.new with items.new_status
Brendan A Gallagher [Thu, 31 Mar 2016 17:10:59 +0000 (17:10 +0000)]
Update Schema Bug 16004 - Replace items.new with items.new_status

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years agoDBrev Bug 16004 - Replace items.new with items.new_status
Brendan A Gallagher [Thu, 31 Mar 2016 17:06:26 +0000 (17:06 +0000)]
DBrev Bug 16004 - Replace items.new with items.new_status

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16004: [QA Follow-up] Tiny change for unit test and help file
Marcel de Rooy [Fri, 25 Mar 2016 10:46:58 +0000 (11:46 +0100)]
 Bug 16004: [QA Follow-up] Tiny change for unit test and help file

Unit test: Added a few lines to add the CPL branch the test depends on.
Help file: Changed a few occurrences for new to new_status

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16004: Replace items.new with items.new_status
Jonathan Druart [Tue, 8 Mar 2016 09:53:35 +0000 (09:53 +0000)]
 Bug 16004: Replace items.new with items.new_status

The items.new column is badly named, the Koha::Item->new accessor will
never returns this value, but the constructor will be called instead.
This patch renames it with new_status to avoid the ambiguity.

Test plan:
0/ Do not apply this patch
1/ Define some rules in the "Automatic item modifications by age" tool
with at least one items.new field used
2/ Apply this patch
3/ Execute the update DB entry
4/ Reload the tool page and confirm that the changes have been taken
into account

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16172: fix OAI Server tests broken by bug 15946
Tomas Cohen Arazi [Wed, 30 Mar 2016 15:22:03 +0000 (12:22 -0300)]
 Bug 16172: fix OAI Server tests broken by bug 15946

This patch makes t/db_dependent/OAI/Server.t test for the correct
schema and metadata namespace.

To test:
- Run
  $ prove t/db_dependent/OAI/Server.t
=> FAIL: Tests fail due to differences in the output.
- Apply the patch
- Run
  $ prove t/db_dependent/OAI/Server.t
=> SUCCESS: Tests now pass
- Sign off

Regards

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Updating the Schema files
Brendan A Gallagher [Thu, 31 Mar 2016 15:51:33 +0000 (15:51 +0000)]
 Updating the Schema files

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years agoDBrev updates for Bug 16007 - Correction of 'Remove columns branchcode,
Brendan A Gallagher [Thu, 31 Mar 2016 15:08:02 +0000 (15:08 +0000)]
DBrev updates for Bug 16007 - Correction of 'Remove columns branchcode,
      categorytype from table overduerules_transport_types'

Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16007: Simplify the DB entry
Jonathan Druart [Wed, 23 Mar 2016 16:59:02 +0000 (16:59 +0000)]
 Bug 16007: Simplify the DB entry

- No need to check if the table exists
- No need to check if the column exists, just remove the warning

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16007: Adding back column 'letternumber' to table 'overduerules_transport_types'
charles [Mon, 21 Mar 2016 19:01:36 +0000 (15:01 -0400)]
 Bug 16007: Adding back column 'letternumber' to table 'overduerules_transport_types'

Bug 13624 definitely broke the master by removing the column `overduerules_transport_type`.`letternumber` from kohastructure.sql.
This patch aims to fix the problem by adding the column back on systems which had their 'letternumber' removed.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16160: Fix t/../www/search_utf8.t for layout change
Tomas Cohen Arazi [Tue, 29 Mar 2016 20:00:59 +0000 (17:00 -0300)]
 Bug 16160: Fix t/../www/search_utf8.t for layout change

Some of the include files in tools/manage-marc-import.tt introduced a new form object
so the form index for the tests needed to be changed to match the new layout.

While testing this I also found that due to the new record_type input in stage-marc-import.tt
the tests would fail if run on an instance with already imported stuff (i.e. the import id
was defaulting to zero). This might have been the cause of some random failures in jenkins
befire we started to DROP / re-CREATE the DB.

To test:
- Run (on kohadevbox:ansible)
  $ sudo koha-shell kohadev
  $ cd kohaclone
  $ prove t/db_dependent/www/search_utf8.t
=> FAIL: mainsubmitform is not found, and the tests hang
- Apply the patch
- re-run the tests:
 $ prove t/db_dependent/www/search_utf8.t
=> SUCCESS: Tests now pass!
- Sign off

Regards

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 14158: www search tests - Cleanup at the end
Jonathan Druart [Wed, 30 Mar 2016 09:55:02 +0000 (10:55 +0100)]
 Bug 14158: www search tests - Cleanup at the end

When something wrong happen, the parent process is waiting for the
children to finish, but they have been zombified and the test hangs.

To fix that, we should ensure that the cleanup is correctly done and
that the processes are correctly killed.

Test plan:
export KOHA_USER=koha
export KOHA_PASS=koha
export KOHA_INTRANET_URL=http://do_not_exist_but_its_expected
export KOHA_OPAC_URL=http://another_url
prove t/db_dependent/www/search_utf8.t

Without this patch, the tests will hang
With the patch applied, they won't!

Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16011 reintroduced VERSION variable needs declaration
Colin Campbell [Tue, 29 Mar 2016 12:35:23 +0000 (13:35 +0100)]
 Bug 16011 reintroduced VERSION variable needs declaration

$VERSION reintroduced into External/BakerTaylor.pm but was
not declared. Causes tests to fail.
Readd VERSION to the package vars

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16151: Restore the ability to place holds from lists at the OPAC
Jonathan Druart [Tue, 29 Mar 2016 07:14:33 +0000 (08:14 +0100)]
 Bug 16151: Restore the ability to place holds from lists at the OPAC

This patch fixes a bug introduced by bug 14544.
Holds can not be placed from lists at the OPAC, the action results in a
crash:
Can't call method "field" on an undefined value at
/home/koha/src/C4/Items.pm line 1504.
 at /home/koha/src/opac/opac-reserve.pl line 601

Before 14544, the checkboxes were named 'ACT-$BIBNUM', something like
REM-4242. Now we can retrieve the biblionumber from the value.

Test plan:
Select a public list
check some titles and click on the 'Place hold' link
you should able to process the reservation

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years ago Bug 16044: Populate the L1 cache when L2 is fetched
Jonathan Druart [Thu, 24 Mar 2016 20:47:47 +0000 (20:47 +0000)]
 Bug 16044: Populate the L1 cache when L2 is fetched

The whole patch set is not very pertinent if the L1 cache is not
populated when L2 is fetched!
This patch fixes this inconsistency.

Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com>
Signed-off-by: Jacek Ablewicz <abl@biblos.pk.edu.pl>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>
5 years agoBug 14304: RDA: OPAC display link in XSLT for 264 field to reflect Zebra indexing
Hector Castro [Fri, 5 Feb 2016 14:44:54 +0000 (08:44 -0600)]
Bug 14304: RDA: OPAC display link in XSLT for 264 field to reflect Zebra indexing

This patch add display link in XSLT for field 264/bug 14198 and reflect the
Zebra index 'Provider' in detail page for OPAC screen.

To test: follow previous test plan

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 14304: RDA: Intranet display link in XSLT for 264 field to reflect Zebra indexing
Hector Castro [Fri, 5 Feb 2016 06:40:51 +0000 (00:40 -0600)]
Bug 14304: RDA: Intranet display link in XSLT for 264 field to reflect Zebra indexing

This patch add display link in XSLT for 264 for bug 14198 and reflect the
Zebra indexing 'Provider' in detail page for Intranet.

Test plan
1) Update zebra index if no Provider: index exist
2) Do a search by Provider:
3) Goto detail page for a record with 264
4) Look that there no display link for 264 field.
5) Apply the patch
6) Reload the page, notice about the link, click the link an confirm
   the new index Provider works fine
7) Test with multiple records with 260 and 264, if you prefer follow test plan
   for bug 14734
8) Access an RCAA2 record just with 260 field
9) Notice that 260 has been updated with Provider index too.
NOTE: The intention of Provider index -according with documentation- is
to collect multiples fields including 260, 264, 270, and 257

Sponsored-by: Universidad de El Salvador
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15413: Adding colons where appropriate
Aleisha [Tue, 22 Dec 2015 23:16:31 +0000 (23:16 +0000)]
Bug 15413: Adding colons where appropriate

To test:

Apply patch and go to pretty much every page on the Intranet - look out
for labels on forms etc where there should be colons but aren't. If you
see any that I've missed but I'm 99% sure I got all of them! Make sure
to click through some forms where creating a new thing involves
continuing the submission on multiple pages.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Rebased on current master and checked all changed pages.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 16139: Renaming 'Unseen since' column to 'Last seen'
Aleisha [Wed, 23 Mar 2016 22:25:33 +0000 (22:25 +0000)]
Bug 16139: Renaming 'Unseen since' column to 'Last seen'

To test:
1) Go to Tools -> Inventory/Stocktaking
2) Submit empty form to bring back all records (or specify, up to you)
3) Notice column name 'Unseen since'
4) Apply patch and go back to Inventory/Stocktaking, resubmit form
5) Confirm column name is now 'Last seen' and makes more sense

Sponsored-by: Catalyst IT
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 16141: Making Transfers to Receive action a button
Aleisha [Thu, 24 Mar 2016 00:37:10 +0000 (00:37 +0000)]
Bug 16141: Making Transfers to Receive action a button

To test:

1) Go to Circ -> Transfer to Receive
2) Confirm 'Cancel transfer' now shows as a button and works as expected

Sponsored-by: Catalyst IT
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 16142: Making 'Order' a button for New Order Suggestions
Aleisha [Thu, 24 Mar 2016 01:20:30 +0000 (01:20 +0000)]
Bug 16142: Making 'Order' a button for New Order Suggestions

To test:

1) Go to Acquisitions and find a vendor
2) Add to a basket from a suggestion
3) Confirm that 'Order' next to the suggestions looks like a button and works as expected

Sponsored-by: Catalyst IT
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 14076: Do not use CGI->param in list context - opac-authorities-home.pl
Jonathan Druart [Fri, 12 Feb 2016 11:49:28 +0000 (11:49 +0000)]
Bug 14076: Do not use CGI->param in list context - opac-authorities-home.pl

See bug 15809 for more info on why we should not use CGI->param in list
context.

Note: I have not found any places where several values for the same
params are passed to this script but, just in case, this patch won't
change this ability.

Test plan:
Do an authority search at the OPAC
Test with several values of the form.
Confirm that the results are always the same before and after this
patch.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 15838 - Subscription duplicating: Reset fields from SubscriptionDuplicateDroppedI...
Alex Arnaud [Wed, 17 Feb 2016 11:27:14 +0000 (12:27 +0100)]
Bug 15838 - Subscription duplicating: Reset fields from SubscriptionDuplicateDroppedInput syspef by getting them using name instead of id

How I tested:
Verified bug with start and end date (were not cleared without patch).
After applying the patch all fields defined in SubscriptionDuplicateDroppedInput
were cleared as expected.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
5 years agoBug 16145: Regression: Bug 15632 broke display of library name on circulation messages
Jonathan Druart [Thu, 24 Mar 2016 21:28:21 +0000 (21:28 +0000)]
Bug 16145: Regression: Bug 15632 broke display of library name on circulation messages

Wrong var loop used!

Test plan:
Add a message for a patron on the checkouts page.
The library name should be displayed.

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com