koha.git
7 years agoBug 14266: Trim the email address in the pl script
Jonathan Druart [Tue, 26 May 2015 11:05:51 +0000 (13:05 +0200)]
Bug 14266: Trim the email address in the pl script

The original concern of bug 14266 was to provide a compatibility for
<IE9.
But actually we don't need to trim the email address template side.
It will even better to trim it in the perl script, so that the email
will be trimed even if JS is disabled.

Test plan:
1/ Share a list and does not provide any email address
2/ Submit
=> The form is not submited, no alert/message is displayed (same as
before this patch).
3/ Share a list and provide an email address with spaces before and
after
4/ Submit
=> You should receive the email

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Test output compliant with expected test plan outcome.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14266: Replace trim() with $.trim() in opac-shareshelf.tt
David Cook [Mon, 25 May 2015 04:07:27 +0000 (14:07 +1000)]
Bug 14266: Replace trim() with $.trim() in opac-shareshelf.tt

This patch replaces trim() with $.trim() which is supported
in versions of IE older than IE9.

Revised test plan
=================

Before applying patch:

0) Use IE 8 or Document Mode 8 in a newer IE using F12 Developer Tools
1) Set OpacAllowSharingPrivateLists to "Allow" in Global System Preferences
2) Create a private list in the OPAC
3) Add a record to the private list
4) Click "Share" or "Share list" on one of the list screens
5) Type in an email address and click "Send"
6) Note the error in the console log
7) The page should submit

Apply the patch:

7) Hold shift + refresh the browser to update any Javascript cache
8) Try to "Share" the list again
9) Note that the form submit after clicking "Send" and
that there are no errors in the console log

http://bugs.koha-community.org/show_bug.cgi?id=14266

Signed-off-by: Indranil Das Gupta <indradg@gmail.com>
Remarks: Works as per revised test plan
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14113: Silence t/Dates.t warnings and cleanup output.
Mark Tompsett [Fri, 1 May 2015 20:31:47 +0000 (16:31 -0400)]
Bug 14113: Silence t/Dates.t warnings and cleanup output.

The expectation of a user not freaking out over 'Illegal date'
messages is not sensible. Catch the messages, give a nicer
message.

Also, compress the veritical spacing on the output.

TEST PLAN
---------
1) $ prove t/Dates.t
   -- notice Illegal date messages, and extra lines between
      some sectional messages.
2) Apply patch
3) $ prove t/Dates.t
   -- Notice how nice and clean it is?
      Try it with -v to see all the output, including the
      expected warning type messages.
4) run koha qa test tools.

Test Remarks : complies with test plan.
Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>a
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14115: Silence warnings in t/Label*
Mark Tompsett [Fri, 1 May 2015 21:56:07 +0000 (17:56 -0400)]
Bug 14115: Silence warnings in t/Label*

Two functions were triggering noisy warnings while testing:
_get_text_fields and _split_lccn.

TEST PLAN
----------
1) $ prove t/Label*
   -- several warnings
2) apply patch
3) $ prove t/Label*
   -- no warnings
4) koha qa test tools.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Nicer, no koha-qa errors

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14116: Silence noisy output for t/Scrubber.
Mark Tompsett [Sat, 2 May 2015 01:16:56 +0000 (21:16 -0400)]
Bug 14116: Silence noisy output for t/Scrubber.

Why diag or print out things, unless it is -v?
And why print anything except success or failure type messages?
This cleans up the output.

TEST PLAN
---------
1) $ prove t/Scrubber.t
   -- there's some noise.
2) apply patch
3) $ prove t/Scrubber.t
   -- noise issue resolved.
      Output is still reasonable for -v.
4) koha qa test tools

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14117: Silence warnings t/SearchPazPar2.t
Mark Tompsett [Sat, 2 May 2015 01:36:23 +0000 (21:36 -0400)]
Bug 14117: Silence warnings t/SearchPazPar2.t

The use of relative URLS (null actually), triggers warnings.
Catch them, instead of letting them loose.

TEST PLAN
---------
1) $ prove t/Search_PazPar2.t
   -- noise for each test currently.
2) apply patch
3) $ prove t/Search_PazPar2.t
   -- No noise, and extra tests added.
      -v shows caught warning tests.
4) koha qa test tools.

Signed-off-by: Indranil Das Gupta <indradg@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14120: Fixing t/db_dependent/Auth.t noise
Mark Tompsett [Sat, 2 May 2015 04:02:04 +0000 (00:02 -0400)]
Bug 14120: Fixing t/db_dependent/Auth.t noise

TEST PLAN
---------
1) $ prove t/db_dependent/Auth.t
   -- warnings
2) Apply this patch
3) $ prove t/db_dependent/Auth.t
   -- only one specific type of warning
4) Apply bug 5010 patch
5) $ prove t/db_dependent/Auth.t
   -- noisy is eliminated
6) koha qa test tools.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
With patch only one warn
With 5010 no more warns
No errors

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 12066: New renew page in staff client doesn't record branch in statistics
Kyle M Hall [Wed, 20 May 2015 15:31:18 +0000 (11:31 -0400)]
Bug 12066: New renew page in staff client doesn't record branch in statistics

Test Plan:
1) Apply this patch
2) Renew an item via circ/renew.pl
3) Note the branch code of your logged in library is set as the
   branch in the generated statistic line

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Tested pre and post patch, now branch is saved
No errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 13946: Change order status 'Pending' to 'Ordered'
Katrin Fischer [Mon, 25 May 2015 09:22:07 +0000 (11:22 +0200)]
Bug 13946: Change order status 'Pending' to 'Ordered'

The order status after closing the basket is 'ordered' in the
database, but displays as 'pending' in the staff interface.

As we use 'pending' when you have to review a suggestion, this
clashes in translations and the meaning is different. The patch
renames 'pending' for the order status to 'Ordered' to be more
clear.

To test:
- Verfiy 'Ordered' shows in the pull down on the acq advanced
  search and search still works correctly
- Verify the results table also display 'Ordered' as the status

Signed-off-by: Cédric Vita <cedric.vita@dracenie.com>
Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14275: Remove CGI::scrolling_list from guided_reports.pl
Bernardo Gonzalez Kriegel [Tue, 26 May 2015 14:00:02 +0000 (11:00 -0300)]
Bug 14275: Remove CGI::scrolling_list from guided_reports.pl

Remove an instance of CGI::scrolling_list from this file

To test:
1) Go to Reports, Guided report wizard, New SQL report

2) Create a report with some auth value list, e.g.

SELECT surname,firstname FROM borrowers WHERE branchcode=<<Enter patrons library|branches>>

Save

3) Clic on 'Run this report", look at the dropdown, that will be changed

4) Apply the patch

5) Reload, check dropdown and any regression

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14112: Silence warnings in t/Charset.t
Mark Tompsett [Fri, 22 May 2015 13:02:23 +0000 (09:02 -0400)]
Bug 14112: Silence warnings in t/Charset.t

After Jonathan said this was the wrong way to correct the issue,
www.utf8-chartable.de made it clear to me that the \c3\a9 were
missing x's.

TEST PLAN
---------
1) prove t/Charset.t
   -- noise
2) apply patch
3) prove t/Charset.t
   -- no noise
4) koha qa test tools

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 7143: Release team for 3.22
Marcel de Rooy [Mon, 25 May 2015 10:18:02 +0000 (12:18 +0200)]
Bug 7143: Release team for 3.22

See: http://wiki.koha-community.org/wiki/Roles_for_3.22
The 3.20 roles are moved to the Development section. Note that we did
not add the Bug wranglers role under Development until now. If that
should change, please provide a follow-up.

Test plan:
Verify that all roles are covered correctly.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Seems correct for me, no errors.

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 12176: Fix for missing field_value in select
Marcel de Rooy [Sat, 23 May 2015 12:01:57 +0000 (14:01 +0200)]
Bug 12176: Fix for missing field_value in select

As Jonathan Druart discovered, we were still missing an important attribute
in the selects. Var mv.name was not filled, so the name was empty with nice
side-effects :)
While fixing this, it was also possible to delete some unused vars that Bernardo
already mentioned before: $attributes and $attributes_no_value.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
For me the simptom was different, when saving an edited item
fields were mangled beyond repear :(
No alert for empty mandatory fields.

But this last patch fix the problem.
Tested add/edit items
Cleaner pl file :)
No errors

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 12176: [QA Follow-up] Capitalization typo after eleventh hour
Marcel de Rooy [Wed, 20 May 2015 14:42:34 +0000 (16:42 +0200)]
Bug 12176: [QA Follow-up] Capitalization typo after eleventh hour

While cleaning up, still found this super tiny string typo :)
Yes, Tag Editor should now be Tag editor.

Test plan :)
Git grep on Tag editor and Tag Editor

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 12176: [QA Follow-up] Small additem adjustments
Marcel de Rooy [Wed, 20 May 2015 12:56:48 +0000 (14:56 +0200)]
Bug 12176: [QA Follow-up] Small additem adjustments

Adjusting a few small things and making qa tools happy:

[1] Remove .hidden after [% avalue %] in additem.tt. (Typo)
[2] A closer look revealed that mv.avalue is useless too. An input element
    does not contain any content. Putting it after the hidden element
    in a non-visible context has no meaning.
[3] Change handling of select attributes readonly and disabled.
[4] Remove unused variable $attributes_no_value_textarea
[5] Removed a comment with TODO referring to this report.
[6] Moving a duplicated TT variable (mv.javascript) outside IF statement.
[7] And finally could not resist this one: Moving strings Tag editor and
    No popup from script to template.  Plugins++
    NOTE: Most item plugins redirect click to focus. In that case there is
    no popup, but unfortunately the text Tag editor comes up.
    When you remove or rename function Click, No popup comes up. So it works.

Sorry that this small list kept growing :)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 12176: Remove HTML from additem.pl
Bernardo Gonzalez Kriegel [Tue, 19 May 2015 16:06:34 +0000 (13:06 -0300)]
Bug 12176: Remove HTML from additem.pl

This patch removes HTML code from additem.pl.

To test:
1. Check no regressions on Add/Edit/Save items
2. Update translation files for a language,
   check new strings "Tag editor" & "No popup" on staff PO file
3. Check it passes xt/tt_valid.t

Patch partially rebased, part rewritten.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 13899: (QA followup) POD and usage message fixes
Tomas Cohen Arazi [Tue, 26 May 2015 14:42:48 +0000 (11:42 -0300)]
Bug 13899: (QA followup) POD and usage message fixes

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
asd

7 years agoBug 13899: Changing license to GPLv3
Julian FIOL [Mon, 27 Apr 2015 07:21:26 +0000 (09:21 +0200)]
Bug 13899: Changing license to GPLv3

koha-qa should be good :

 OK misc/devel/coverage.pl
   OK   critic
   OK   forbidden patterns
   OK   pod
   OK   valid

 OK C4/Installer/PerlDependencies.pm
   OK   critic
   OK   forbidden patterns
   OK   pod
   OK   valid

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
No koha-qa errors.
Test plan not explicitly stated,
script run and generates a lot of data :)

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 13899: Add changes as asked in Comment 5
Julian FIOL [Wed, 15 Apr 2015 08:51:16 +0000 (10:51 +0200)]
Bug 13899: Add changes as asked in Comment 5

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Fixed a small conflict on PerlDependencies.pm

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 13899: Adding misc/devel/coverage.pl
Julian FIOL [Tue, 24 Mar 2015 10:46:10 +0000 (11:46 +0100)]
Bug 13899: Adding misc/devel/coverage.pl

It's a script making a cover on all modules to see
which ones are not tested yet. It uses Devel::Cover

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoRevert "Bug 6679: Fix 11 perlcritic violations in C4/Dates.pm"
Tomas Cohen Arazi [Tue, 26 May 2015 17:17:08 +0000 (14:17 -0300)]
Revert "Bug 6679: Fix 11 perlcritic violations in C4/Dates.pm"

This reverts commit 2ee1a35dfa91892474a7d10f8783dd95edbe7696.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoRevert "Bug 6679: Fix 9 perlcritic violations in C4/TmplTokenType.pm"
Tomas Cohen Arazi [Tue, 26 May 2015 17:16:58 +0000 (14:16 -0300)]
Revert "Bug 6679: Fix 9 perlcritic violations in C4/TmplTokenType.pm"

This reverts commit 09787ec8b09cf3cf90cb5d6ff96c77dc0d314c58.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoRevert "Bug 6679: Fix 6 perlcritic violations in C4/Reports/Guided.pm"
Tomas Cohen Arazi [Tue, 26 May 2015 17:16:50 +0000 (14:16 -0300)]
Revert "Bug 6679: Fix 6 perlcritic violations in C4/Reports/Guided.pm"

This reverts commit e592536d97483b88dceabedfaec9fefcefbcda2f.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoRevert "Bug 6679: Fix 2 perlcritic violations in C4/Installer/PerlModules.pm"
Tomas Cohen Arazi [Tue, 26 May 2015 17:16:41 +0000 (14:16 -0300)]
Revert "Bug 6679: Fix 2 perlcritic violations in C4/Installer/PerlModules.pm"

This reverts commit 7fbc7467b53784b41e1ef2db7a95ed69235c9c5e.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoRevert "Bug 6679: Fixing code so it passes basic Perl:::Critic tests"
Tomas Cohen Arazi [Tue, 26 May 2015 17:16:31 +0000 (14:16 -0300)]
Revert "Bug 6679: Fixing code so it passes basic Perl:::Critic tests"

This reverts commit 8b9a555cc9391b841472ca11a0f48edcd4819a2f.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoRevert "Bug 6679: (follow-up) fix 9 perlcritic violations in C4/TmplTokenType.pm"
Tomas Cohen Arazi [Tue, 26 May 2015 17:16:21 +0000 (14:16 -0300)]
Revert "Bug 6679: (follow-up) fix 9 perlcritic violations in C4/TmplTokenType.pm"

This reverts commit 8554ce273cd24bcef738ebf76aeaa79db87403e1.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoRevert "Bug 6679: Fix 3 perlcritic violations in C4/Record.pm"
Tomas Cohen Arazi [Tue, 26 May 2015 17:16:06 +0000 (14:16 -0300)]
Revert "Bug 6679: Fix 3 perlcritic violations in C4/Record.pm"

This reverts commit a04e8a8bfcff1d6c8e09a98086f108fac76d6e2d.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 12160: DBRev 3.21.00.002
Tomas Cohen Arazi [Tue, 26 May 2015 13:59:54 +0000 (10:59 -0300)]
Bug 12160: DBRev 3.21.00.002

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 12160: Rename opacuserjs with OPACUserJS
Jonathan Druart [Mon, 27 Apr 2015 14:06:37 +0000 (16:06 +0200)]
Bug 12160: Rename opacuserjs with OPACUserJS

Test plan:
Same as previous patch for opacuserjs

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
NOTE: Worked before and after updatedatabase.pl, though after
      is less confusing to the programmer unaware of case-insensitivity.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 12160: Rename intranetuserjs with IntranetUserJS
Jonathan Druart [Mon, 27 Apr 2015 13:55:31 +0000 (15:55 +0200)]
Bug 12160: Rename intranetuserjs with IntranetUserJS

To match IntranetUserCSS, intranetuserjs should be renamed
IntranetUserJS.

Test plan:
1/ Be sure there is no occurrence of intranetuserjs
2/ Confirm the pref still works as before

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
NOTE: Worked before and after updatedatabase.pl, though after
      is less confusing to the person unaware of case insensitivity.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14025: Fix 865u-links in the OPAC for NORMARC
Magnus Enger [Wed, 29 Apr 2015 19:28:50 +0000 (21:28 +0200)]
Bug 14025: Fix 865u-links in the OPAC for NORMARC

The display of links found in 856$u for NORMARC has not been keeping up with
the one for MARC21, and several sysprefs have not been implemented. This
patch tries to fix that.

Affected sysprefs:
- OPACURLOpenInNewWindow
- URLLinkText
- OPACDisplay856uAsImage
- OPACTrackClicks

To test:
- Make sure you have a record with a URL in 856$u and marcflavor = NORMARC.
  (It does not have to be a full NORMARC setup or a NORMARC record, just make
  sure you are viewing the record through the NORMARC XSLT files.)
- View the record both in a result list and in detail view
- Check that the 4 involved sysprefs affect the display in the expected ways

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Tested on NORMARC setup and XSLTs
Works as described, each syspref works
No koha-qa errors

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Since it only affects NORMAC, I trust in Magnus :)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 6679: Fix 3 perlcritic violations in C4/Record.pm
Mason James [Tue, 26 Jun 2012 14:41:20 +0000 (02:41 +1200)]
Bug 6679: Fix 3 perlcritic violations in C4/Record.pm

Expression form of "eval" at line 358, column 5.  See page 161 of PBP.  (Severity: 5)
Expression form of "eval" at line 367, column 5.  See page 161 of PBP.  (Severity: 5)
Expression form of "eval" at line 510, column 3.  See page 161 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Fixed conflict

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 6679: (follow-up) fix 9 perlcritic violations in C4/TmplTokenType.pm
Jonathan Druart [Tue, 9 Dec 2014 08:48:58 +0000 (09:48 +0100)]
Bug 6679: (follow-up) fix 9 perlcritic violations in C4/TmplTokenType.pm

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 6679: Fixing code so it passes basic Perl:::Critic tests
Mason James [Mon, 24 Sep 2012 23:21:43 +0000 (11:21 +1200)]
Bug 6679: Fixing code so it passes basic Perl:::Critic tests

opac/ilsdi.pl: Stricture disabled at line 217, column 17.  See page 429 of PBP.  (Severity: 5)

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 6679: Fix 2 perlcritic violations in C4/Installer/PerlModules.pm
Mason James [Tue, 26 Jun 2012 17:07:46 +0000 (05:07 +1200)]
Bug 6679: Fix 2 perlcritic violations in C4/Installer/PerlModules.pm

Expression form of "eval" at line 71, column 9.  See page 161 of PBP.  (Severity: 5)

Expression form of "eval" at line 85, column 13.  See page 161 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 6679: Fix 6 perlcritic violations in C4/Reports/Guided.pm
Mason James [Tue, 26 Jun 2012 13:50:33 +0000 (01:50 +1200)]
Bug 6679: Fix 6 perlcritic violations in C4/Reports/Guided.pm

- Subroutine prototypes used at line 376, column 1.  See page 194 of PBP.  (Severity: 5)

- Bareword file handle opened at line 757, column 2.  See pages 202,204 of PBP.  (Severity: 5)

- Two-argument "open" used at line 757, column 2.  See page 207 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 6679: Fix 9 perlcritic violations in C4/TmplTokenType.pm
Mason James [Tue, 26 Jun 2012 13:08:34 +0000 (01:08 +1200)]
Bug 6679: Fix 9 perlcritic violations in C4/TmplTokenType.pm

- Subroutine prototypes used at line 86, column 1.  See page 194 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 6679: Fix 11 perlcritic violations in C4/Dates.pm
Mason James [Tue, 26 Jun 2012 13:04:36 +0000 (01:04 +1200)]
Bug 6679: Fix 11 perlcritic violations in C4/Dates.pm

- Subroutine prototypes used at line 82, column 1.  See page 194 of PBP.  (Severity: 5)

- "return" statement with explicit "undef" at line 102, column 28.  See page 199 of PBP.  (Severity: 5)

- Expression form of "eval" at line 108, column 20.  See page 161 of PBP.  (Severity: 5)

- Variable declared in conditional statement at line 126, column 5.  Declare variables outside of the condition.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14203: Message for non-existent lang removal
Indranil Das Gupta [Thu, 14 May 2015 19:42:11 +0000 (01:12 +0530)]
Bug 14203: Message for non-existent lang removal

A trivial string patch to update the error message displayed to
user if koha-translate is used to attempt removal of a language
that is not installed.

Test plan
=========

1/ attempt to remove a non-existent language by
   <installdir>/debian/scripts/koha-translate --remove <langcode>
2/ it should show "Error: the selected language is not already
   installed."
3/ apply patch
4/ repeat step 1; it should show "Error: the selected language is
   not installed."

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14184: Undefined $term causes noisy warns in C4/CourseReserves.pm
Aleisha [Tue, 12 May 2015 02:08:17 +0000 (02:08 +0000)]
Bug 14184: Undefined $term causes noisy warns in C4/CourseReserves.pm

This patch sets $term to be an empty string.

Test plan
=========

1/ enable 'UseCourseReserves' syspref in Circulation preferences
2/ in a terminal, run a `tail -f ` on your instance's opac-error.log
3/ go to the opac, click on 'Course reserve' tab to go to
   opac-course-reserves.pl
4/ notice the warning - "opac-course-reserves.pl: Use of uninitialized
   value $term" appear in the `tail`ed opac-error.log
5/ apply the patch
6/ reload the page (opac-course-reserves.pl)
7/ page works but the warning in step #4 is no longer logged
8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error

Remarks: Testing result match expected test plan output. The QA tests
         pass with "OK" for the commit.

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14185: Undefined $limit causes warn in opac/opac-readingrecord.pl
Aleisha [Tue, 12 May 2015 03:01:35 +0000 (03:01 +0000)]
Bug 14185: Undefined $limit causes warn in opac/opac-readingrecord.pl

This patch sets $limit to be an empty string.

Test plan
=========

1/ login into the opac using your user account credentials
2/ in a terminal, run a `tail -f ` on your instance's opac-error.log
3/ go back to the opac, click on 'your reading history' tab to go to
   opac-readingrecord.pl
4/ notice the warning - "opac-readingrecord.pl: Use of uninitialized
   value $limit" appear in the `tail`ed opac-error.log
5/ apply the patch
6/ reload the page (opac-readingrecord.pl)
7/ page works but the warning in step #4 is no longer logged
8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error

Remarks: Testing result match expected test plan output. The QA tests
         pass with "OK" for the commit.

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14186 [QA Followup]: Undefined $reservedfor causes warn in opac-reserve.pl
Indranil Das Gupta [Thu, 14 May 2015 01:53:16 +0000 (07:23 +0530)]
Bug 14186 [QA Followup]: Undefined $reservedfor causes warn in opac-reserve.pl

This is a followup for Bug 14186 that removes the extraneous tab
char on line 470, so that the patch can clear QA tools.

This patch sets $reservedfor to an empty string.

Test plan
=========

1/ in a terminal, run `tail -f ` on your instance's opac-error.log
2/ go to the opac and search from an item that exists on the Koha
   instance.
3/ Select the title (if more than one title is returned) and click on
   'Place hold' link to go to opac-reserve.pl
4/ notice the warning - "opac-reserve.pl: Use of uninitialized value
   $reservedfor" appear in the `tail`ed opac-error.log
5/ apply the patch
6/ reload the page (opac-reserve.pl)
7/ page works but the warning in step #4 is no longer thrown up
8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error

Remarks: Testing result match expected test plan output. The QA tests
         pass with "OK" for the commit.

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14186: Undefined $reservedfor causes warn in opac-reserve.pl
Aleisha [Tue, 12 May 2015 03:30:46 +0000 (03:30 +0000)]
Bug 14186: Undefined $reservedfor causes warn in opac-reserve.pl

This patch sets $reservedfor to an empty string.

Test plan
=========

1/ in a terminal, run `tail -f ` on your instance's opac-error.log
2/ go to the opac and search from an item that exists on the Koha
   instance.
3/ Select the title (if more than one title is returned) and click on
   'Place hold' link to go to opac-reserve.pl
4/ notice the warning - "opac-reserve.pl: Use of uninitialized value
   $reservedfor" appear in the `tail`ed opac-error.log
5/ apply the patch
6/ reload the page (opac-reserve.pl)
7/ page works but the warning in step #4 is no longer thrown up
8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error

Remarks: The QA test failed - "forbidden pattern: tab char (line 470)".

         Marking this as 'FAILED QA'

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14262: change the build-git-snapshot version to 3.21
Robin Sheat [Sun, 24 May 2015 04:41:57 +0000 (16:41 +1200)]
Bug 14262: change the build-git-snapshot version to 3.21

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14255: minor edits to history.txt to facilitate automatic updates to the website
Liz Rea [Fri, 22 May 2015 03:23:31 +0000 (15:23 +1200)]
Bug 14255: minor edits to history.txt to facilitate automatic updates to the website

All this really does is remove whitespace at the end of the lines, and correct a weirdly tabbed entry. There aren't any content changes.

To test:

Just have a look at the patch and see that it's done those things. Not sure much needs to be done.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoDBRev 3.21.00.000: El tiempo vuela
Tomas Cohen Arazi [Tue, 26 May 2015 13:41:30 +0000 (10:41 -0300)]
DBRev 3.21.00.000: El tiempo vuela

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14059: Deleting 'issues' table before processing the tests
Julian FIOL [Tue, 5 May 2015 07:31:17 +0000 (09:31 +0200)]
Bug 14059: Deleting 'issues' table before processing the tests

It's suppose to avoid foreign key trouble

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
No error

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
7 years agoBug 14059: Delete all export of get_column_names
Julian FIOL [Mon, 4 May 2015 07:28:49 +0000 (09:28 +0200)]
Bug 14059: Delete all export of get_column_names

This deals with my concerns raised in comment #2.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
7 years agoBug 14059: Testing C4::Creators::Lib
Julian FIOL [Mon, 13 Apr 2015 14:54:09 +0000 (16:54 +0200)]
Bug 14059: Testing C4::Creators::Lib

Testing C4::Creators::Lib at 100%
Deleting get_column_names subroutine (never used)

    TEST PLAN
    ---------
    1. Apply patch
    2. prove -v t/db_dependent/Creators/Lib.t
    -- All 644 tests should run successfully without
    any error or warning

    TEST PLAN OPTIONAL
    ------------------

    Check with bug 13899 to see the coverage of this module.

    Coverage BEFORE this patch :
    Statement  :  11,6%
    Branch     :   0,0%
    Condition  :    N/A
    Subroutine :  36,0%

    Coverage AFTER this patch :
    Statement  : 100,0%
    Branch     : 100,0%
    Condition  :    N/A
    Subroutine : 100,0%

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
7 years agoBug 14130: Update columns.def
Katrin Fischer [Mon, 4 May 2015 20:08:04 +0000 (22:08 +0200)]
Bug 14130: Update columns.def

- Updates columns.def with new columns in items
- Adds some descriptions
- Corrects some existing column descrpitions

To test:
- Read the patch to see what has been changed
- Run the guided report builder for the 'circulation'
  module
- Observe changes show up

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Changes show up, no errors

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
7 years ago(RM followup) .mailmap updates
Tomas Cohen Arazi [Fri, 22 May 2015 20:01:57 +0000 (17:01 -0300)]
(RM followup) .mailmap updates

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
7 years agoKoha 3.20 is here v3.20.00
Tomas Cohen Arazi [Fri, 22 May 2015 15:55:09 +0000 (12:55 -0300)]
Koha 3.20 is here

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
7 years agoRelease notes for 3.20
Tomas Cohen Arazi [Fri, 22 May 2015 15:44:35 +0000 (12:44 -0300)]
Release notes for 3.20

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
7 years agoTranslation updates for Koha 3.20.0 release
Bernardo Gonzalez Kriegel [Fri, 22 May 2015 13:06:15 +0000 (10:06 -0300)]
Translation updates for Koha 3.20.0 release

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
7 years agoBug 14106: (QA followup) avoid failures if no instances created
Tomas Cohen Arazi [Fri, 22 May 2015 15:28:14 +0000 (12:28 -0300)]
Bug 14106: (QA followup) avoid failures if no instances created

If there are no instances already created on install/upgrade, the
koha-common.postinst script hungs in the absence of files to fix
and keeps waiting for user input.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
7 years agoBug 14106: patch existing zebra configs with new modulePath
Robin Sheat [Fri, 22 May 2015 01:48:13 +0000 (13:48 +1200)]
Bug 14106: patch existing zebra configs with new modulePath

This patches the zebra configuration of existing Koha installations so
that their modulePath will work on newer Debian (and presumably Ubuntu)
releases.

Testing:
* Install a package built with this patch onto a system with instances
  created by an older Koha version.
* Check that the files in /etc/koha/sites/*/zebra-*.cfg have the new
  modulePath: directive rather than the old one.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14106: fill up the zebra config with a list of modulePaths
Robin Sheat [Thu, 21 May 2015 03:48:06 +0000 (15:48 +1200)]
Bug 14106: fill up the zebra config with a list of modulePaths

This adds the full list of paths that debian might use for zebra to the
search path for modules.

It also means we can say we support s390x architecture. Whatever that is.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14145: Noisy warns in admin/preferences.pl
Mark Tompsett [Sat, 9 May 2015 05:31:37 +0000 (01:31 -0400)]
Bug 14145: Noisy warns in admin/preferences.pl

The problem with the odd number of hashes happens when not everything is selected.
The grep returns undef, because it isn't found in @values.
By turning the grep into a ternary-operator truth value, we can set a value (1 or 0) expressly.

The next problem is when nothing is selected in these multiple lists, $value is
undefined, so you can't split it. By splitting the definition of @values from
the actual splitting, we can split only if $value is defined, thus eliminating the
warning message.

TEST PLAN
---------
1) back up your koha error log file
2) blank your koha error log file
3) log in to the staff client
4) Home -> Koha administration -> Global system preferences
5) Click on every tab, EXCEPT local use.
6) notice the koha error log file has warnings.
7) blank the koha error log file again
8) apply this patch
9) Click on every tab, EXCEPT local use, again.
10) notice the koha error log file has no warnings.
11) koha qa test tools.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
I like more this version
Works as described
No koha-qa errors

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
To reproduce: go on the OPAC tab, OpacAdvSearchMoreOptions  or
OpacAdvSearchOptions should not have all options selected.
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14124: Add 'Unimarc only' note to IdRef system preference
Tomas Cohen Arazi [Wed, 6 May 2015 17:04:29 +0000 (14:04 -0300)]
Bug 14124: Add 'Unimarc only' note to IdRef system preference

This patch adds a note to the IdRef service syspref making it
clear that the feature is only available for UNIMARC setups.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Added a missing 'is'
No errors

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14254 - Unclosed <option> element in unimarc_field_116.tt
Bernardo Gonzalez Kriegel [Thu, 21 May 2015 23:25:41 +0000 (20:25 -0300)]
Bug 14254 - Unclosed <option> element in unimarc_field_116.tt

Unclosed <option>

To test:
1) Unimarc install
2) Edit a record
3) Edit 116 field, 10 position, Technique (prints) 3
4) Select litography, save
5) Run plugin again, will see litography/option>
6) Apply the patch
7) Check again, now is right (clean cache)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14118: Silence warnings t/DataTables/Members.t
Mark Tompsett [Sat, 2 May 2015 02:14:21 +0000 (22:14 -0400)]
Bug 14118: Silence warnings t/DataTables/Members.t

After cleaning 'prove t' up. 'prove -r t' was attempted next.
A couple uninitialized variable warning were triggered.

TEST PLAN
----------
1) prove t/DataTables/Members.t
   -- warnings.
2) apply patch
3) prove t/DataTables/Members.t
   -- no warnings.
4) koha qa test tools.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Cleaned. No errors

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14114: Silence warns and cleanup t/Debug.t
Mark Tompsett [Fri, 1 May 2015 21:09:58 +0000 (17:09 -0400)]
Bug 14114: Silence warns and cleanup t/Debug.t

TEST PLAN
---------
1) $ prove t/Debug.t
   -- What's with this BEFORE and AFTER stuff?!
2) apply patch
3) $ prove t/Debug.t
   -- cleaner, and you only get fuller output with -v.
4) koha qa test tools

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Cleaner, no koha-qa errors

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 13486: Apache version empty in about page if Apache 2.4
Tomas Cohen Arazi [Thu, 5 Feb 2015 17:31:55 +0000 (14:31 -0300)]
Bug 13486: Apache version empty in about page if Apache 2.4

This patch makes about.pl query the running Apache version using
the apache2ctl command. I tested it on Apache 2.2 and is backwards
compatible (it is present in both).

To test:
( On an Apache 2.4 setup )
- Go to the about page
=> FAIL: "Apache version:" is empty
- Apply the patch
- Reload the page
=> SUCCESS: "Apache version:" shows the correct version.
- Sign off :-D

If you have an Apache 2.2 setup to try it, verify that there are no regressions
(trivial because you can run apache2ctl manually and verify the first result is the expecte).

Regards

PS. I even changed the order in which Apache version is tested because
most people is using Debian/Ubuntu and it was the last option.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Tested with apache 2.2/2.4, no errors

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Only tested with 2.4
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 13650: Remove parens from links to fix searches
Winona Salesky [Thu, 29 Jan 2015 20:13:37 +0000 (14:13 -0600)]
Bug 13650: Remove parens from links to fix searches

This patch will resolve the issue of not being able to
search with parens in a subject heading by editing the xslt

To test:

* Apply patch
* Search Koha for a title with ( ) in the subject
* Click the subject
* Results should be returned
* Repeat in OPAC and Staff client

Signed-off-by: Nick <Nick@quechelibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14072: Followup: extra space
Mirko Tietgen [Wed, 20 May 2015 11:05:10 +0000 (13:05 +0200)]
Bug 14072: Followup: extra space

Detele extra space in sample notice

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14072: Update German web installer for 3.20
Katrin Fischer [Thu, 14 May 2015 15:28:29 +0000 (17:28 +0200)]
Bug 14072: Update German web installer for 3.20

- translates new notice ACQ_NOTIF_ON_RECEIV
- translates new permissions

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Tested German install till "Gratulation, die Installation ist abgeschlossen"
No errors

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Same results noted as above.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Tested installation, checked new translations in Koha and deleted an extra
space in the ACQ_NOTIF_ON_RECEIV notice

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 11925: Check ages limits when creating/updating patrons
Jonathan Druart [Tue, 28 Apr 2015 09:45:46 +0000 (11:45 +0200)]
Bug 11925: Check ages limits when creating/updating patrons

The check on the ages limits is only done when the dateofbirth field is
mandatory, which does not make any sense.
This check should be done when the field is filled.

Test plan:
1/ Remove the dateofbirth field from the BorrowerMandatoryField pref
2/ Create a patron category for teenager (say between 12-17y)
3/ Try to create a patron in this category outside the range of the ages
limits.
You should not be able to do it.

Signed-off-by: Christopher Brannon <cbrannon@cdalibary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14195: (followup) increment number of tests
Bernardo Gonzalez Kriegel [Thu, 14 May 2015 18:36:56 +0000 (15:36 -0300)]
Bug 14195: (followup) increment number of tests

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14195: TestBuilder - A random string should not be longer than the DB field
Jonathan Druart [Wed, 13 May 2015 14:39:59 +0000 (16:39 +0200)]
Bug 14195: TestBuilder - A random string should not be longer than the DB field

t::lib::TestBuilder::_gen_text does not use correctly the regex and the
max parameter to generate the random string (String::Random).

This can cause future tests to fail.

http://bugs.koha-community.org/show_bug.cgi?id=14195
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Script tested, problem occurs, patch fixes it.
Bad number on commit subject
No errors

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14231: changes required for 3.20 release
Robin Sheat [Wed, 10 Dec 2014 04:33:14 +0000 (17:33 +1300)]
Bug 14231: changes required for 3.20 release

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 5338: (QA followup) update the tests for the new reports
Tomas Cohen Arazi [Tue, 19 May 2015 16:47:31 +0000 (13:47 -0300)]
Bug 5338: (QA followup) update the tests for the new reports

This patch fixes the unit tests related to guided reports.
It is needed now that there are more options available.

It also fixes a wrong 'savedsql' key (should be 'sql') that
caused the tests to print warnings.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 13687: Move hold policy check into CanItemBeReserved
Julian Maurice [Tue, 10 Feb 2015 10:34:01 +0000 (11:34 +0100)]
Bug 13687: Move hold policy check into CanItemBeReserved

This way ILS-DI HoldItem and HoldTitle services also benefit from this
check

Test plan:

1/ Define some default holds policies by item type in
/admin/smart-rules.pl
2/ Use ILS-DI HoldItem service and check that those rules are respected
3/ Check that staff and opac hold behaviour is unchanged regarding
these rules.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes tests and QA script. No regressions found,
improves the ILS-DI HoldItem response.
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 10299: authority plugin - authority field are reversed
Jonathan Druart [Thu, 16 Apr 2015 13:52:33 +0000 (15:52 +0200)]
Bug 10299: authority plugin - authority field are reversed

If you click the plugin next to an authority field that is already
populated it takes the values from the field and puts them in the search
in the reverse order.

Test plan:
1/ Edit a biblio
2/ Fill the subfield for an authority field (for instance 650$v, 650$x,
650$y, etc.)
3/ Click on the authority plugin
Before this patch, the values were concatenated in the reverse order.
With this patch, it should not.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work as described, no koha-qa errors

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 5338: DBRev 3.19.00.043
Tomas Cohen Arazi [Tue, 19 May 2015 13:29:55 +0000 (10:29 -0300)]
Bug 5338: DBRev 3.19.00.043

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 5338: Add the "SER" report group for all languages.
Jonathan Druart [Wed, 4 Mar 2015 11:26:59 +0000 (12:26 +0100)]
Bug 5338: Add the "SER" report group for all languages.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
7 years agoBug 5338: Use insert ignore to avoid a warning if 'SER' already exists
Jonathan Druart [Wed, 4 Mar 2015 11:26:34 +0000 (12:26 +0100)]
Bug 5338: Use insert ignore to avoid a warning if 'SER' already exists

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
7 years agoBug 5338: Add "Serials" to the report group list
Jonathan Druart [Wed, 14 Jan 2015 09:55:19 +0000 (10:55 +0100)]
Bug 5338: Add "Serials" to the report group list

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 5338: Serials Report
Jonathan Druart [Thu, 5 Apr 2012 13:44:32 +0000 (15:44 +0200)]
Bug 5338: Serials Report

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 7380: Add tests for TT plugins
Jonathan Druart [Fri, 17 Apr 2015 15:40:07 +0000 (17:40 +0200)]
Bug 7380: Add tests for TT plugins

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 7380: Rename filter to avoid confusion
Jonathan Druart [Tue, 14 Apr 2015 10:05:45 +0000 (12:05 +0200)]
Bug 7380: Rename filter to avoid confusion

The branchcode and categorycode parameter names are too common and are
confusing.
To remove the ambiguity, this patch renames them with branchcode_filter
and categorycode_filter.

Test plan:
1/ Go on the patron home page (members-home.pl)
2/ Fill the library and category dropdown list in the header search
3/ The patron result list appears and the filters (on the right) are
correctly set with what you have selected.
Make sure the ones in the header are also correctly selected.
4/ Click on a patron
5/ On the patron detail page (moremember.pl), the dropdown lists in the
header are not preselected.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 7380: Refactor the patron search box header
Jonathan Druart [Tue, 15 Jul 2014 10:44:23 +0000 (12:44 +0200)]
Bug 7380: Refactor the patron search box header

A lot of page uses the patron search box header include (git grep
patron-search.inc for the list) and the branch and category lists are
not generated for all of them.

For instance, on a patron detail page, there is a [+] link, but nothing
append on clicking on it.

This patch add a new template plugin "Categories" to get all patron
categories from the templates.

Test plan:
1/ Verify the [+] is working on all patron page (if that works for 2,
that should work for all).
2/ Launch a search from the header box and verify the library and
category dropdown lists select the correct value.
3/ Launch a search on the patron search page (patron home) and verify
the search is working correctly on selecting a category and/or a library

Followed test plan. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14200: GetNormalizedISBN failing to normalize valid ISBNs in some cases
Kyle M Hall [Thu, 14 May 2015 10:20:00 +0000 (06:20 -0400)]
Bug 14200: GetNormalizedISBN failing to normalize valid ISBNs in some cases

For some reason the regular expression used to split the multiple ISBN
fields can fail which keeps Business::ISBN from being able to parse out
and return a valid isbn. Using split() instead of the regex fixes the
issue.

Test Plan:
1) Apply the unit test patch first
2) prove t/Koha.t
3) Note the failures
4) Apply the second patch
5) prove t/Koha.t
6) Note all tests pass

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Karen Bryant <kbryant@ccpl-fl.net>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14200: Regression tests
Kyle M Hall [Thu, 14 May 2015 10:19:39 +0000 (06:19 -0400)]
Bug 14200: Regression tests

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Karen Bryant <kbryant@ccpl-fl.net>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 11607: Don't display all items in a single line
Jonathan Druart [Wed, 24 Dec 2014 12:09:27 +0000 (13:09 +0100)]
Bug 11607: Don't display all items in a single line

If the *DGST notices are sent in HTML, the items are displayed in a
single line.

To reproduce:
1/ Define a *DGST notice using the <<items.content>> pattern.
2/ Checkout at least 2 items to a patron and set the due date as today.
3/ Launch the advance_notices.pl and process_message_queue.pl cronjobs.
4/ Verify the email you will receive separates the items with a line
break.

Verify you don't find a regression for non-html letters.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Note: the display in the notices tab is misleading here,
needs to be verified checking the sent emails or database
entries in message_queue.
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 10947: Fix editing the default authority type
Jonathan Druart [Wed, 22 Apr 2015 11:45:44 +0000 (13:45 +0200)]
Bug 10947: Fix editing the default authority type

The default authority type cannot be defined.
The authtypecode is en empty string and the tests should be done on
"defined", not "exist".

Test plan:
Edit the default authority type, save it.

Note: There is no way to create an authority with an empty string, with
you deleted you won't be able to recreate it.

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 9892: [QA Follow-up] Typo and updated usage
Marcel de Rooy [Fri, 8 May 2015 07:25:37 +0000 (09:25 +0200)]
Bug 9892: [QA Follow-up] Typo and updated usage

Corrected specifield.
Updated usage statement on use of delimiter pref.
Clarified the CONDITION explanation somewhat..

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 9892: Make export_borrowers.pl using the delimiter pref
Jonathan Druart [Thu, 9 Apr 2015 13:49:14 +0000 (15:49 +0200)]
Bug 9892: Make export_borrowers.pl using the delimiter pref

The original concern of bug 9892 was that this borrowers export script
cannot handle tabulation to separate columns.

With this patch, the delimiter preference is used as separator for the
output, to be consistent with others scripts.

This should be highlighted on the release, it can produce change in
behaviors.

Test plan:
Confirm that the 'delimiter' pref is used for the output, but you are able
to overwrite it with the 'separator' parameter

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Works as expected, respect preference but is supeseeded by cmd line
No koha-qa errors

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 10011: Save branch limitations on creating a new patron category
Jonathan Druart [Fri, 10 Apr 2015 11:51:31 +0000 (13:51 +0200)]
Bug 10011: Save branch limitations on creating a new patron category

The code was just badly placed.
It should be executed on update but also on insert.

Test plan:
1/ Create a new patron category and select 1+ branch limitations
2/ Confirm it's correctly saved
3/ Edit it and change the branch limitations
4/ Confirm it's correctly saved

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
NOTE: Not a C4 or Koha library, so tests not required. Though,
      this code could be cleaned up and have the DB stuff put
      into some sort of library with tests to prevent regression.
      However, that dream is beyond the scope of this bug.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14213: Cataloging plugin in cloned field does not work
Marcel de Rooy [Mon, 18 May 2015 08:31:26 +0000 (10:31 +0200)]
Bug 14213: Cataloging plugin in cloned field does not work

A code change for report 10480 in cataloging.js does not work well in case
you clone a field with a plugin on a subfield.
The events (click, focus, etc.) do not work on the subfield of the clone.

This patch corrects the situation by finding the right html element for
adding event binding.
NOTE: The test plan uses EXAMPLE.pl since many old plugins do not operate
on the correct field value when cloning. This is corrected in bug 13437.

Test plan:
[1] Attach EXAMPLE.pl to field 007, 246h and 260c.
    In sql for 007: update marc_subfield_structure set
        value_builder='EXAMPLE.pl' where tagfield='007' and tagsubfield='@';
[2] Clone field 007. Verify that focus and click operate on both fields.
    Check also that the plugin works on the value corresponding with
    the button you clicked.
[3] Clone field 246. Do the same checks on both subfields $h.
[4] Clone subfield 260c. Do the same checks again.

Test Remarks:
============

1/ Setup a new framework (B213) based off 'Default' and fired off
   an SQL statement to update value_builder values for 007, 246$h
   and 269$c (UPDATE `marc_subfield_structure` SET value_builder
   = 'EXAMPLE.pl' WHERE frameworkcode = 'B213' AND ( (tagfield =
   '007' AND tagsubfield = '@') OR ( tagfield LIKE '246' AND
   tagsubfield = 'h') OR (tagfield = '260' AND tagsubfield = 'c'))

2/ Tested step 2, 3 and 4 of the given test plan above. The missing
   plugin support in the cloned fields were noted.

3/ Applied patch

4/ Re-tested steps 2, 3 and 4 as before. The defined plugins were
   correctly cloned and found to be functional.

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 7143: [QA Follow-up] Restoring lost </li> tag
Marcel de Rooy [Tue, 19 May 2015 12:12:10 +0000 (14:12 +0200)]
Bug 7143: [QA Follow-up] Restoring lost </li> tag

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 7143: Small fix on the 3.20 release team
Tomas Cohen Arazi [Tue, 12 May 2015 15:08:49 +0000 (12:08 -0300)]
Bug 7143: Small fix on the 3.20 release team

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Magnus is alone, no errors

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 12109: Fix tab on the auth subfield configuration page
Jonathan Druart [Mon, 27 Apr 2015 15:16:32 +0000 (17:16 +0200)]
Bug 12109: Fix tab on the auth subfield configuration page

There is a condition in the template to not display the "New" tab if the
user is editing a control field.
But it results in a broken template.
Looking at the biblio frameworks, the New tab exists even for control
fields.

This patch only fixes the html structure, but a complete fix should be
provide, for auth and biblio, if we want not to let the ability to
create subfields for control fields.

Test plan:
Edit subfields for a control field
(admin/marc_subfields_structure.pl?op=add_form&tagfield=001&frameworkcode= for instance)
and confirm that the view is now fixed.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
NOTE: Checked LDR, 001, and 008.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14152: Re-check required dependencies during upgrade process
Chris Nighswonger [Tue, 5 May 2015 19:00:30 +0000 (15:00 -0400)]
Bug 14152: Re-check required dependencies during upgrade process

This code causes the installer to re-check dependencies during the
upgrade process.

Test Plan
---------
1) Log in to staff client
2) Koha Administration -> Global system preferences -> Local
3) Change Version to previous version -- DO NOT HIT SAVE YET!
4) In command line: sudo apt-get purge libpdf-fromhtml-perl
   NOTE: This could be ANY required library. I chose
         PDF::FromHTML, because it has been a thorn in my side.
5) NOW! Hit the 'Save' button.
6) Log in, etc. etc...
   -- Blows up on redirect to log in.
7) In command line, add it back (I had to compile my own so,
   I used sudo dpkg -i /path/to/libpdf-fromhtml-perl...)
8) Apply patch
9) Edit the C4/Installer/PerlDependencies.pm to make
   PDF::FromHTML required. See also bug 14103.
10) Log in to staff client
11) Koha Administration -> Global system preferences -> Local
12) Change Version to previous version -- DO NOT HIT SAVE YET!
13) In command line: sudo apt-get purge libpdf-fromhtml-perl
14) NOW! Hit the 'Save' button.
15) Log in, etc. etc...
16) Once warned you are missing it, add it back at the command line.
17) Click 'Recheck'
    -- Proceeds as expected now.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 8399: Display tab number on the mandatory field alert (authority)
Jonathan Druart [Tue, 31 Mar 2015 13:29:49 +0000 (15:29 +0200)]
Bug 8399: Display tab number on the mandatory field alert (authority)

A wrong variable scope was used here, the number value is contained in
the BIG_LOOP (note for later: change this variable name...).

Test plan:
1/ Define 1+ mandatory fields for an authority type
2/ Create an authority and don't fill the mandatory fields
3/ Try to save: the popup alert should display the number of the tab.

Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 8399: No need to truncate the marc field text to 22 chars
Jonathan Druart [Tue, 14 Apr 2015 09:23:21 +0000 (11:23 +0200)]
Bug 8399: No need to truncate the marc field text to 22 chars

The text for the marc field are truncated to 22 chars when displaying an
error on mandatory fields.
This limitation is useless and this patch removes it.

Test plan:
Create a mandatory subfield and set a long text (more than 22 chars)
edit or add an authority, click on save.
You should get the error displayed with the full text

Note that this patch modifies the same code for biblio.
Test plan is the same for biblio.

Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 8480: (RM followup) DBIx updates
Tomas Cohen Arazi [Mon, 18 May 2015 14:24:12 +0000 (11:24 -0300)]
Bug 8480: (RM followup) DBIx updates

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 8480: DBRev 3.19.00.042
Tomas Cohen Arazi [Mon, 18 May 2015 14:20:02 +0000 (11:20 -0300)]
Bug 8480: DBRev 3.19.00.042

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 8480: Add constraint on auth_subfield_structure.authtypecode
Jonathan Druart [Tue, 31 Mar 2015 11:18:21 +0000 (13:18 +0200)]
Bug 8480: Add constraint on auth_subfield_structure.authtypecode

In order not to have useless entries in the auth_subfield_structure
table, this patch modifies the DB structure to add a foreign key on the
authtypecode column.
Note that the auth_tag_structure already has this constraint.

Test plan:
0/ Don't apply this patch
1/ Create a now authority type 'RM_ME'
2/ Look at the MARC structure, to create the subfield structure and
populate the auth_subfield_structure table.
3/ Delete the authority type
4/ Using your SQL cli:
 SELECT COUNT(*) FROM auth_subfield_structure WHERE authtypecode='RM_ME';
=> The data are still in this table.
5/ Apply this patch
6/ Execute the updatedb entry
7/ Confirm the entries in the auth_subfield_structure table related to
RM_ME have been deleted
8/ Repeat 1, 2 and 3 and verify the auth_subfield_structure entries have
been correctly removed.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
- Works exactly as described in the (very good) test plan.
- After authority type deletion, auth_subfield_structure still contains
  entries for deleted authority type. Applying the patch clean the
  previously undeleted records in auth_subfield_strucute. Now deleting a
  authority type cleans propertly all appropriate records in
  auth_subfield_structure.
- Fix a merge conflict

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 14172: Acq: Orders without items missing from 'spent' list
Katrin Fischer [Fri, 15 May 2015 10:19:16 +0000 (12:19 +0200)]
Bug 14172: Acq: Orders without items missing from 'spent' list

If the item for an order had been deleted since or there was never
an item created for the order (subscription orders) those records
where missing from the "Spent" page in acquisitions.

Patch corrects the SQL to list the correct records.

To test:
- Create different orders for one fund and receive them
  - normal order with a few items
  - subscription order (no item)
  - normal order with an item, delete the item after receiving
  - include some freight cost in one of the invoices
- Compare the amount spent shown on the acq start page
  with the amount shown at the end of the 'spent' page
- Without the patch, the amounts don't match and not all
  received titles are listed
- With the patch, amounts should match and list shoudl be complete

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
7 years agoBug 13591: Pass OPACBaseURL to rss creation process
Colin Campbell [Tue, 10 Mar 2015 12:15:28 +0000 (12:15 +0000)]
Bug 13591: Pass OPACBaseURL to rss creation process

Links in rss templates were hardcoded to library.org.nz. Should pass and
use the system's OPACBaseURL.

Tested and verified.

Signed-off-by: Eivin Giske Skaaren <eskaaren@yahoo.no>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>