koha.git
13 years agoremove editor settings
Galen Charlton [Wed, 4 Feb 2009 20:47:10 +0000 (14:47 -0600)]
remove editor settings

Me, I use ed(1) for everything...

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoreconciled DB revs: now at 013
Galen Charlton [Wed, 4 Feb 2009 20:19:51 +0000 (14:19 -0600)]
reconciled DB revs: now at 013

13 years agobug 341: Use the Right Branch
John Beppu [Tue, 3 Feb 2009 22:02:14 +0000 (16:02 -0600)]
bug 341: Use the Right Branch

When sending circulation alerts, use the branch that the
event happened on instead of $item->{homebranch}.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 324: Setting to_address
John Beppu [Tue, 3 Feb 2009 22:02:13 +0000 (16:02 -0600)]
bug 324: Setting to_address

- Enqueue the messages with a to_address.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 323: Item Circulation Alerts UI Fixes
John Beppu [Tue, 3 Feb 2009 22:02:12 +0000 (16:02 -0600)]
bug 323: Item Circulation Alerts UI Fixes

- fixed cross browser issues.  (IE and Safari don't let you say
  someobject.class, presumably because "class" is a keyword that's reserved
  for future versions of JS.  Firefox and Opera allow it.)

- added text to the grid for added clarity.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago[Checkout Slips Part 3 14/16] SQL
John Beppu [Tue, 3 Feb 2009 22:02:11 +0000 (16:02 -0600)]
[Checkout Slips Part 3 14/16] SQL

- fixed syntax errors (thanks Dan)
- made sample_notices.sql mandatory

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoTests for New Modules
John Beppu [Tue, 3 Feb 2009 22:02:10 +0000 (16:02 -0600)]
Tests for New Modules

- KohaTest::Category
- KohaTest::ItemCirculationAlertPreference
- KohaTest::ItemType
- KohaTest::Message

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoPerl Modules
John Beppu [Tue, 3 Feb 2009 22:02:09 +0000 (16:02 -0600)]
Perl Modules

- C4::Letters:EnqueueLetter() is aware of new fields in message_queue table
- C4::Circulation::SendCirculationAlert() actually works
- C4::Category cleanup
- C4::ItemType cleanup
- C4::Message is a new module.
  It presents yet another way to interact with the message_queue.
  You can now take messages that have already been queued and modify
  their contents before they're sent out.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBrand New UI for Alert Configuration
John Beppu [Tue, 3 Feb 2009 22:02:08 +0000 (16:02 -0600)]
Brand New UI for Alert Configuration

- grid layout (javascript required now)
- makes distinction between checkin and checkout messages
- no longer have to click on a button to submit the branch selection form

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoRemoved RSS Option from UI
John Beppu [Tue, 3 Feb 2009 22:02:07 +0000 (16:02 -0600)]
Removed RSS Option from UI

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoRevised Schema
John Beppu [Tue, 3 Feb 2009 22:02:06 +0000 (16:02 -0600)]
Revised Schema

- removed 'rss' transport
- made the messages non-digest
- updated the default text of the templates in the letters table
- [table] item_circulation_alert_preferences
  - added notification column
  - removed is_enabled column
- [table] message_queue
  - added metadata column
  - added letter_code column

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agowhitespace cleanup
John Beppu [Tue, 3 Feb 2009 22:02:05 +0000 (16:02 -0600)]
whitespace cleanup

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoSending Circulation Alerts part 1
John Beppu [Tue, 3 Feb 2009 22:02:04 +0000 (16:02 -0600)]
Sending Circulation Alerts part 1

- Added code to AddIssue to send an alert when appropriate.
- Added code to AddReturn to send an alert when appropriate.
- Added a sub called SendCirculationAlert() that DOESN'T ACTUALLY WORK YET.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoNew C4 Modules
John Beppu [Tue, 3 Feb 2009 22:02:03 +0000 (16:02 -0600)]
New C4 Modules

* C4::Category
  - patron categories as objects
  - an all() method to return all the categories as a list
* C4::ItemType
  - itemtypes as objects
  - an all() method to return all the item types as a list
* C4::ItemCirculationAlertPreference
  - wrapper around the item_circulation_alert_preference table
  - create() and delete() methods for easy manipulation of the preferences
  - I regret giving it such a long name.
  - The item_type column should've been named itemtype to make it
    more similar to pre-existing tables.  Oh well.

(C4::Category and C4::ItemType were made so that I wouldn't have to
write SQL inside my CGI scripts.
Their main purpose is to provide an easy way to get a list of
patron categories and item types.
Do not be fooled by the amount of POD.
There's actually very little code in these modules.)

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBranch Level Notification Config
John Beppu [Tue, 3 Feb 2009 22:02:02 +0000 (16:02 -0600)]
Branch Level Notification Config

- This will allow admins to disable notifications for any combination of
  branch, patron category, and item_type.
- Still working on this...

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoPOD for C4::Members::Messaging
John Beppu [Tue, 3 Feb 2009 22:01:59 +0000 (16:01 -0600)]
POD for C4::Members::Messaging

- fixed typos and formatting.
- added notes on how to add new kinds of messages.
- added notes on the tables being used.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoMessaging Preferences for Intranet
John Beppu [Tue, 3 Feb 2009 22:02:00 +0000 (16:02 -0600)]
Messaging Preferences for Intranet

- Added ability to modify per-user messaging preferences.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoMessaging Preferences for OPAC
John Beppu [Tue, 3 Feb 2009 22:02:01 +0000 (16:02 -0600)]
Messaging Preferences for OPAC

- Added ability to request a messaging config change.
  (Apparently, users aren't allowed to directly change these settings.)

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoSchema Changes for Email Checkout Slips
John Beppu [Tue, 3 Feb 2009 22:01:58 +0000 (16:01 -0600)]
Schema Changes for Email Checkout Slips

- new table, item_circulation_alert_preferences
- new data:
  - letter -- 2 new templates
  - message_transport_types -- feed
  - message_attributes -- Item Check-in and Item Checkout
  - message_transports -- for each attribute and for each transport_type...

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoShowing totals for charges and replacement costs on patron detail screen and print...
Owen Leonard [Tue, 3 Feb 2009 20:59:55 +0000 (14:59 -0600)]
Showing totals for charges and replacement costs on patron detail screen and print view.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoMove opaclanguagesdisplay to I18N/L10N tab where opaclanguages pref is.
Owen Leonard [Tue, 3 Feb 2009 21:00:06 +0000 (15:00 -0600)]
Move opaclanguagesdisplay to I18N/L10N tab where opaclanguages pref is.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2938)[follow previous] Add new report in menus
Nahuel ANGELINETTI [Mon, 2 Feb 2009 08:28:27 +0000 (09:28 +0100)]
(bug #2938)[follow previous] Add new report in menus

Just adding the new report in miscellaneous menus

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2938) add a serials subscriptions report
Nahuel ANGELINETTI [Fri, 30 Jan 2009 16:20:26 +0000 (17:20 +0100)]
(bug #2938) add a serials subscriptions report

this patch add a report for serials.
It's have to limit branch/bookseller, and excluding expired serials.
It's possible to export in CSV format.
This patch will have another, to add this report in menus.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofixes SQL typo and return value in GetImportBatchStatus()
Mason James [Mon, 2 Feb 2009 12:33:21 +0000 (01:33 +1300)]
fixes SQL typo and return value in GetImportBatchStatus()

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoPrevent js failure if syspref "gist" is undefined.
Joe Atzberger [Wed, 21 Jan 2009 01:18:22 +0000 (19:18 -0600)]
Prevent js failure if syspref "gist" is undefined.

The javascript is malformed and therefore fails the onsubmit check if
gist does not receive a value.  This patch allows failover to default 0.
Also removed an unused dbh.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoMinor rework of template js.
Joe Atzberger [Wed, 21 Jan 2009 01:18:25 +0000 (19:18 -0600)]
Minor rework of template js.

Lines explicitly ended with semicolons.  Allow some better behavior if TMPL_VAR's
are undefined or zero.

Note FIXME added.  I believe this is part of the fragmentary integration of
Katipo code for GST.  Would be obliged if someone with access there can confirm.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2870, fixes non-populating of guarantor fields
Mason James [Wed, 28 Jan 2009 12:28:52 +0000 (01:28 +1300)]
bug 2870, fixes non-populating of guarantor fields

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoDelete a "=" added lastly and make this script not working
Nahuel ANGELINETTI [Wed, 28 Jan 2009 13:57:18 +0000 (14:57 +0100)]
Delete a "=" added lastly and make this script not working

It seems no one use this script, because it cannot work.
This patch delete a "=".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoCleanup and perltidy.
Joe Atzberger [Wed, 28 Jan 2009 19:25:48 +0000 (13:25 -0600)]
Cleanup and perltidy.

Add "use warnings", remove unused variables and unnecessary finish/disconnect
at the end.  This script could be improved to run only on tables that need to
be altered instead of touching all of them.  It should also probably contain
warnings to the effect that it does not rescue your DATA that was forced into
whatever encoding the table used previously.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoObsolete harness for tests, replaced by make and other test structures.
Joe Atzberger [Wed, 28 Jan 2009 19:39:43 +0000 (13:39 -0600)]
Obsolete harness for tests, replaced by make and other test structures.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoholds policy followup - fix column definition
Galen Charlton [Thu, 15 Jan 2009 21:26:20 +0000 (15:26 -0600)]
holds policy followup - fix column definition

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofollowup to holds policies - fix itype
Galen Charlton [Thu, 15 Jan 2009 21:26:18 +0000 (15:26 -0600)]
followup to holds policies - fix itype

Overriding items.itype from biblioitems.itemtype
is needed only with item-level_itypes is OFF.

[LL bug 321]

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoCorrected several typos that caused the installer to fail when creating the Koha...
Daniel Sweeney [Thu, 15 Jan 2009 21:26:19 +0000 (15:26 -0600)]
Corrected several typos that caused the installer to fail when creating the Koha schema.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobump DB rev 011 -> 012
Galen Charlton [Thu, 15 Jan 2009 21:26:16 +0000 (15:26 -0600)]
bump DB rev 011 -> 012

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agolanguage fix: "branch" => "library"
Galen Charlton [Thu, 15 Jan 2009 21:26:17 +0000 (15:26 -0600)]
language fix: "branch" => "library"

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoDatabase updates for hold policies
Jesse Weaver [Thu, 15 Jan 2009 21:26:15 +0000 (15:26 -0600)]
Database updates for hold policies

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoDatabase changes and new sysprefs for holds policies
Jesse Weaver [Thu, 15 Jan 2009 21:26:14 +0000 (15:26 -0600)]
Database changes and new sysprefs for holds policies

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdd holds policies
Jesse Weaver [Thu, 15 Jan 2009 21:26:13 +0000 (15:26 -0600)]
Add holds policies

This adds holds policy creation support to smart rules and read support to
C4/Circulation.pm, and the two reservation pages. It also adds a system
preference, AllowHoldPolicyOverride, to control whether the staff can override
these policies.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoUnescape some double quotes, that make a validation error.
Nahuel ANGELINETTI [Wed, 7 Jan 2009 15:23:14 +0000 (16:23 +0100)]
Unescape some double quotes, that make a validation error.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoRelated to earlier patch: adding body id to add flexibility to CSS customizations.
Owen Leonard [Fri, 9 Jan 2009 02:03:53 +0000 (20:03 -0600)]
Related to earlier patch: adding body id to add flexibility to CSS customizations.

This patch adds a different id to opac-shelves, opac-suggestions, and opac-tags based on whether or not the user is logged in, allowing for changes to style based on logged-in status.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2908 followup - use "list", not "shelf"
Galen Charlton [Mon, 12 Jan 2009 22:16:47 +0000 (16:16 -0600)]
bug 2908 followup - use "list", not "shelf"

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2909) fix the attachment base64 encoding
Nahuel ANGELINETTI [Mon, 12 Jan 2009 09:45:53 +0000 (10:45 +0100)]
(bug #2909) fix the attachment base64 encoding

this patch change the attachment encoding, else if the file is too large, koha throws an error.
This solution was found on koha list in a Joshua's e-mail

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2908) adding send shelf by e-mail feature
Nahuel ANGELINETTI [Mon, 12 Jan 2009 09:36:31 +0000 (10:36 +0100)]
(bug #2908) adding send shelf by e-mail feature

This patch add the form for sending shelf by e-mail, and add a button in shelves that allow the user to send a shelf.
It's an approximate copy of the send basket feature.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobump DB rev 010 -> 011
Galen Charlton [Mon, 12 Jan 2009 21:16:58 +0000 (15:16 -0600)]
bump DB rev 010 -> 011

13 years agoBug 2578: remove unwanted intranetuserjs syspref - Database revision 3.01.00.011
Andrew Moore [Mon, 29 Dec 2008 19:37:24 +0000 (13:37 -0600)]
Bug 2578: remove unwanted intranetuserjs syspref - Database revision 3.01.00.011

The default syspref setting for intranetuserjs should be empty. At one
time, an unwanted value accidently got put in there. This removes the
syspref only if it equals the unwanted value.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2687 followup: Increase maxlength attribute to support 64 characters
Danny Bouman [Thu, 20 Nov 2008 14:35:26 +0000 (09:35 -0500)]
bug 2687 followup: Increase maxlength attribute to support 64 characters

Modified the borrower attribute and borrower password fields to support a maxlength of 64 characters.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2687: Increased length of borrower attribute fields
Danny Bouman [Wed, 19 Nov 2008 20:58:42 +0000 (15:58 -0500)]
bug 2687: Increased length of borrower attribute fields

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2904) support of 856$u and 856$z in UNIMARC
Nahuel ANGELINETTI [Fri, 9 Jan 2009 09:54:30 +0000 (10:54 +0100)]
(bug #2904) support of 856$u and 856$z in UNIMARC

This patch change the linktext as the label of the link(in 856$z), and set the url from the 856$u.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2902 Public shelves do not display when user not logged in.
Allen Reinmeyer [Fri, 9 Jan 2009 02:11:02 +0000 (20:11 -0600)]
Bug 2902 Public shelves do not display when user not logged in.

An ending </div> was not placed correctly and encompassed both
privateshelves and publicshelves

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoPrevent multiple warnings per notice filling cron logs.
Joe Atzberger [Fri, 9 Jan 2009 17:15:38 +0000 (11:15 -0600)]
Prevent multiple warnings per notice filling cron logs.

If a value being substituted in was NULL, then warnings like this
would be emailed to the crontab owner (or MAILTO):

Use of uninitialized value in substitution (s///) at /home/user/kohaclone/C4/Letters.pm line 508.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2505: more warnings fixes in C4/Context.pm
Galen Charlton [Fri, 9 Jan 2009 18:16:43 +0000 (12:16 -0600)]
bug 2505: more warnings fixes in C4/Context.pm

* more portable way to determine uname for
  crash messages
* C4::Context->userenv now returns undef instead
  of 0 if no userenv has been set yet; returning
  undef when necessary is almost always better
  than returning a scalar when a hashref is
  normally expected.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoEnable use warnings;, clean up complainy functions, fix a few tab/space formatting...
stan [Thu, 1 Jan 2009 17:39:33 +0000 (12:39 -0500)]
Enable use warnings;, clean up complainy functions, fix a few tab/space formatting issues.

Refactoring KOHAVERSION to be less crufty, enabling use warnings, change formatting slightly in places.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoWEBSERVER_HOST and WEBSERVER_HOST added
Marc Chantreux [Thu, 8 Jan 2009 01:02:07 +0000 (01:02 +0000)]
WEBSERVER_HOST and WEBSERVER_HOST added

comments added too

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofollowup to patch for bug 2900
Galen Charlton [Thu, 8 Jan 2009 20:18:24 +0000 (14:18 -0600)]
followup to patch for bug 2900

Previous patch broke date comparison that sets
overdue flag - now that ISO-formatted date
strings are being compared, must use "it"
instead of "<".

"2009-01-02" lt "2009-01-08" is true
"2009-01-02" <  "2009-01-08" is *false*

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2900: fix GetPendingIssues.
Joe Atzberger [Thu, 8 Jan 2009 03:47:36 +0000 (21:47 -0600)]
Bug 2900: fix GetPendingIssues.

GetPendingIssues did several bad things:
~ select * on a 4 table join,
~ including multiple namespace collisions,
~ including large fields marc and marcxml from biblioitems,
~ return ($count, \@array_being_counted).

Not everything is fixed here (see FIXMEs), but the situation is
improved considerably, with bug 2900 resolved.  The "timestamp"
namespace collision in query should be resolved by separate patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2747: avoid warning if items.itype is NULL
Galen Charlton [Wed, 7 Jan 2009 21:32:35 +0000 (15:32 -0600)]
bug 2747: avoid warning if items.itype is NULL

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2747 for staff interface itemtype display.
Joe Atzberger [Wed, 7 Jan 2009 20:57:28 +0000 (14:57 -0600)]
Bug 2747 for staff interface itemtype display.

Prefer accuracy over graphical icon.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoGetAuthValCode calls were positioned inside the loop,
Joe Atzberger [Wed, 7 Jan 2009 20:57:29 +0000 (14:57 -0600)]
GetAuthValCode calls were positioned inside the loop,

despite the same values being supplied each time.  Then
the conditional assignments would repeat the same calls again!
That means execution was liable to query the DB at least once
and as many as four times per item.  With a large number of items
this is an unnecessary burden.  By moving the calls outside
the loop, we can guarantee that we never have to call the DB for
that info more than twice (once for lost, once for damaged).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofix permission error introduced in a previous patch
Galen Charlton [Wed, 7 Jan 2009 03:03:40 +0000 (21:03 -0600)]
fix permission error introduced in a previous patch

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2752 - comment out problematic DELETE op.
Joe Atzberger [Mon, 8 Dec 2008 16:01:23 +0000 (10:01 -0600)]
Bug 2752 - comment out problematic DELETE op.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agojavascript redirect when selecting a patron on circulation.pl Patron Selection Screen
Michael Hafen [Wed, 27 Aug 2008 22:46:57 +0000 (16:46 -0600)]
javascript redirect when selecting a patron on circulation.pl Patron Selection Screen

This adds a little javascript to the Patron Selection form input after searching for a patron to check out to.
On click it redirects to checking out to the clicked patron.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoPut patron Privilege 'updatecharges' to use on fines pages
Michael Hafen [Thu, 13 Nov 2008 23:11:35 +0000 (16:11 -0700)]
Put patron Privilege 'updatecharges' to use on fines pages

This changes the flags required for the fines pages to include the
updatecharges flag.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoHiding SMS messaging preferences if there is no SMSSendDriver defined in system prefe...
Owen Leonard [Tue, 21 Oct 2008 19:57:27 +0000 (14:57 -0500)]
Hiding SMS messaging preferences if there is no SMSSendDriver defined in system preferences.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoHiding SMS settings in OPAC if SMSSendDriver is not defined. Fixes Bug 2455, remove...
Owen Leonard [Tue, 21 Oct 2008 20:15:26 +0000 (15:15 -0500)]
Hiding SMS settings in OPAC if SMSSendDriver is not defined. Fixes Bug 2455, remove SMS column from patron messaging preferences if SMSSendDriver is not defined

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2842: ->regexp('syspref') failed for users of iso dateformat.
Joe Atzberger [Thu, 4 Dec 2008 04:33:02 +0000 (22:33 -0600)]
Bug 2842: ->regexp('syspref') failed for users of iso dateformat.

Sticky due date and patron import were the two areas affected.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoDates expanding to expose some time (HH:MM:SS) granularity.
Joe Atzberger [Fri, 19 Sep 2008 00:02:48 +0000 (19:02 -0500)]
Dates expanding to expose some time (HH:MM:SS) granularity.

t/Dates.t is essentially restored from its previous state with
the revision that it now does not use C4::Context or check syspref
for the default date format.  Instead it sets the C4::Dates default
directly, taking cue from command line argument or ENV.  ISO format
revised to accept "T" separator and "Z" (zulu) terminator. POD
expanded and corrected.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoa more readable way to test an array size.
Nahuel Angelinetti [Wed, 15 Oct 2008 09:03:25 +0000 (11:03 +0200)]
a more readable way to test an array size.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2505: enable warnings for admin/authorized_values.pl
Galen Charlton [Wed, 7 Jan 2009 01:43:35 +0000 (19:43 -0600)]
bug 2505: enable warnings for admin/authorized_values.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoauthorized_values cleanup
Joe Atzberger [Fri, 12 Dec 2008 21:28:01 +0000 (15:28 -0600)]
authorized_values cleanup

Moving towards being able to enable warnings.  Use one dbh, and stop
redeclaring it in each conditional chunk.  ($sth still need to be cleaned.)
Toggle in script removed (tmpl should use loop context var __odd__).
$sth->finish calls removed where unnecessary.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoREFACTOR: correcting indirect object method syntax
Andrew Moore [Wed, 17 Dec 2008 22:31:25 +0000 (16:31 -0600)]
REFACTOR: correcting indirect object method syntax

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2505: turning on "warnings" in catalogue/detail.pl
Andrew Moore [Wed, 17 Dec 2008 22:32:46 +0000 (16:32 -0600)]
Bug 2505: turning on "warnings" in catalogue/detail.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoA few more tweaks to the OPAC detail view menu
Owen Leonard [Wed, 31 Dec 2008 20:28:27 +0000 (14:28 -0600)]
A few more tweaks to the OPAC detail view menu

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoProviding options for adding to order when existing record search has failed.
Owen Leonard [Wed, 31 Dec 2008 20:28:38 +0000 (14:28 -0600)]
Providing options for adding to order when existing record search has failed.

I've duplicated the "Add to Order" block on the search results page to display after a user has searched for an existing record to add to an order. This block is displayed whether or not results were found on the assumption that a non-empty result set may not contain the desired result. Changes to neworderbiblio.pl allow supplier name to appear in breadcrumb nav.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agopatch followup: restore test in GetMarcItem
Galen Charlton [Wed, 7 Jan 2009 00:54:08 +0000 (18:54 -0600)]
patch followup: restore test in GetMarcItem

Change made to GetMarcItem to quell a warning
changed sense of a test; defined($foo) is *not*
the same as $foo ne ''.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2505: more warnings fixes to C4/Biblio.pm
Galen Charlton [Tue, 6 Jan 2009 14:59:09 +0000 (08:59 -0600)]
bug 2505: more warnings fixes to C4/Biblio.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFix for Bug 2700, Keeping Data When Adding Multiple Items
Owen Leonard [Tue, 4 Nov 2008 16:21:47 +0000 (10:21 -0600)]
Fix for Bug 2700, Keeping Data When Adding Multiple Items

When cloning the set of inputs, the new js
increments the IDs of each form field (to keep them unique) and automatically
selects the option that was selected in the cloned group.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2505: enable warnings for labels/label-print-pdf.pl
Galen Charlton [Mon, 5 Jan 2009 22:33:41 +0000 (16:33 -0600)]
bug 2505: enable warnings for labels/label-print-pdf.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoLabels Cleanup (Part 2 of Many)
Joe Atzberger [Wed, 3 Dec 2008 15:31:50 +0000 (09:31 -0600)]
Labels Cleanup (Part 2 of Many)

CalcNextLabelPos pulled out of each subblock.
Print of header and initial structure deferred until later to allow fatals_to_browser to
display any fatal errors encountered in data preparation.  This does not fix Unicode "wide character" crashes.
Created subroutine for debug dump lines.
Comparisons corrected (numerical not string compare).

Note: this script is still insecure with NO AUTH CHECK.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoBug 2505: adding warnings to C4/Biblio.pm
Andrew Moore [Wed, 17 Dec 2008 22:28:04 +0000 (16:28 -0600)]
Bug 2505: adding warnings to C4/Biblio.pm

I added 'use warnings' to C4::Biblio and made a handful of changes to
reduce the number of warnings emitted.

One notable spot is the change in the regex in
C4::Biblio::GetNoZebraIndexes. I have replaced the parens with a character
class. The parens change the way 'split' works, making it return elements
for each delimiter. We did not want those elements returned, and they
only resulted in "'' => undef" being added to the final hash. They also
resulted in two "undefined" warnings for each pass through the loop. I've
included a simple test for this function.

There may be a few warnings still emitted in spots, but either I haven't
seen them yet, or I have chosen to not fix them yet because they require
too much change.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoUsing Warns would cause problems with NoZebra
Henri-Damien LAURENT [Wed, 19 Nov 2008 13:58:16 +0000 (14:58 +0100)]
Using Warns would cause problems with NoZebra

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobarcodedecode() did not always return barcode
Joe Atzberger [Fri, 2 Jan 2009 20:35:03 +0000 (14:35 -0600)]
barcodedecode() did not always return barcode

This patch amends the function to return barcode, in particular when
filter is not defined.  It also adds an optional 2nd argument to
allow the filter to be specified by caller, enabling testing.

Non-DB-dependent test script included.  Note: T-prefix style
barcode filter is not documented, and drops the first nonzero
digit after the T.  This seems mistaken, but is not corrected here
to avoid any surprises.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAllow AddIssue to log SIP transactions distinct from others.
Joe Atzberger (siptest [Tue, 28 Oct 2008 18:37:37 +0000 (13:37 -0500)]
Allow AddIssue to log SIP transactions distinct from others.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoLabels Cleanup (Part 1 of Many)
Joe Atzberger [Wed, 3 Dec 2008 15:31:49 +0000 (09:31 -0600)]
Labels Cleanup (Part 1 of Many)

Consolidated error catching after evals.
Removed unnecessary $sth->finish calls and some unused variables.
Pulled query for itemtype mappings outside DrawSpineText and added
a class level caching variable to eliminate repeated queries for
*each piece of text* on *each label*!  This was a major performance
downside.

Note: this does not fix Unicode problems, but it does add some notes
on unsuccessful attempted workaround using utf8::encode.

C4::Labels should likely be broken up to separate out the pieces that
do not touch the database (wrappers of PDF::Reuse) and those that are
CRUD API for table data.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoremove TMPL_IF EXPR in member.tmpl
Galen Charlton [Wed, 31 Dec 2008 21:52:44 +0000 (15:52 -0600)]
remove TMPL_IF EXPR in member.tmpl

Quells following error message in Apache log:

EXPR:at pos 8: non-initialized variable overdues,
referer: http://example.edu/cgi-bin/koha/members/members-home.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoperltidy lables/label-item-search.pl
Galen Charlton [Wed, 31 Dec 2008 21:34:26 +0000 (15:34 -0600)]
perltidy lables/label-item-search.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agobug 2505: turn on warnings in labels/label-item-search.pl
Galen Charlton [Wed, 31 Dec 2008 21:31:32 +0000 (15:31 -0600)]
bug 2505: turn on warnings in labels/label-item-search.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofollowup to Mason's labels patch
Galen Charlton [Wed, 31 Dec 2008 20:46:09 +0000 (14:46 -0600)]
followup to Mason's labels patch

* fix XHTML errors
* fix problems with paging through results list

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoThe current searching in labels is a bit minimal, and current only does keyword searc...
Mason James [Wed, 12 Nov 2008 06:55:39 +0000 (19:55 +1300)]
The current searching in labels is a bit minimal, and current only does keyword searching.

there is some old 2.2 code for more complete labels-searching, thats been commented out

ive logged a 'bug' for this - 2777

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2777

this fix...
  - enables the index-searching functionality
  - adds date-ranges
  - uses the numSearchResults syspref, not a hardcoded '20'
  - rewrote old 2.2 page-num code, (didnt work for 3.x)
  - some indent and whitepages tidys.
  - unused 2.2 search-code removed.

Mason

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2881) preselect default sorting
Nahuel ANGELINETTI [Tue, 23 Dec 2008 14:00:27 +0000 (15:00 +0100)]
(bug #2881) preselect default sorting

This patch just set a variable with the name of default sorting, and value 1

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFormatting changes for OPAC xslt and staff client catalog detail pages. Fixes Bug...
Owen Leonard [Tue, 21 Oct 2008 16:13:36 +0000 (11:13 -0500)]
Formatting changes for OPAC xslt and staff client catalog detail pages. Fixes Bug 2704, 440 Display Issues.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years ago(bug #2887) Change the "Cart" box from js to tmpl
Nahuel ANGELINETTI [Mon, 29 Dec 2008 11:27:06 +0000 (12:27 +0100)]
(bug #2887) Change the "Cart" box from js to tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoremove disused script admin/letter.pl
Galen Charlton [Wed, 31 Dec 2008 16:28:03 +0000 (10:28 -0600)]
remove disused script admin/letter.pl

Was moved to tools/letter.pl in 2006, but old
(and nonfunctional) version was left in place.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoremoving *.old files
Galen Charlton [Wed, 31 Dec 2008 16:23:34 +0000 (10:23 -0600)]
removing *.old files

Don't need to do this when modifying a script --
this is what Git is for.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoAdds the ability to reference itemcallnumber within XSLT
Joshua Ferraro [Tue, 23 Dec 2008 22:17:58 +0000 (16:17 -0600)]
Adds the ability to reference itemcallnumber within XSLT

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agofollowup to prior patch: remove $toggle from script
Galen Charlton [Wed, 31 Dec 2008 16:10:02 +0000 (10:10 -0600)]
followup to prior patch: remove $toggle from script

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoRemove "toggle" from template, use loop_context_vars __odd__ instead.
Joe Atzberger [Tue, 30 Dec 2008 17:20:14 +0000 (11:20 -0600)]
Remove "toggle" from template, use loop_context_vars __odd__ instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoFixes bug #2875
Frederic Demians [Tue, 30 Dec 2008 06:54:44 +0000 (07:54 +0100)]
Fixes bug #2875

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoMinor updates to minor cronjob script.
Joe Atzberger [Tue, 30 Dec 2008 17:20:15 +0000 (11:20 -0600)]
Minor updates to minor cronjob script.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agocrontab.example - add back some useful comments
Galen Charlton [Wed, 31 Dec 2008 15:44:06 +0000 (09:44 -0600)]
crontab.example - add back some useful comments

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
13 years agoExpand crontab.example
Joe Atzberger [Tue, 30 Dec 2008 17:20:16 +0000 (11:20 -0600)]
Expand crontab.example

Default overdues to "triggered" mode (-t).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>