koha.git
11 years agoMerge remote branch 'kc/master'
Chris Cormack [Sun, 31 Oct 2010 21:56:05 +0000 (10:56 +1300)]
Merge remote branch 'kc/master'

11 years agoremove extraneous semicolon
Galen Charlton [Sun, 31 Oct 2010 04:46:39 +0000 (00:46 -0400)]
remove extraneous semicolon

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoUpdated links in Main Page Help
Brian Engard [Sun, 31 Oct 2010 04:46:38 +0000 (00:46 -0400)]
Updated links in Main Page Help

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5327: Add unit test for ItemType.pm
Nate Curulla [Sun, 31 Oct 2010 09:15:22 +0000 (05:15 -0400)]
Bug 5327: Add unit test for ItemType.pm

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agounit test stub for Z3950.pm
Daniel Grobani [Sat, 30 Oct 2010 02:44:27 +0000 (22:44 -0400)]
unit test stub for Z3950.pm

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoCreate Unit Test for ImportBatch
Brian Engard [Sat, 30 Oct 2010 03:39:26 +0000 (23:39 -0400)]
Create Unit Test for ImportBatch

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoMerge remote branch 'kc/new/bug5075' into kcmaster
Chris Cormack [Sat, 30 Oct 2010 07:32:45 +0000 (20:32 +1300)]
Merge remote branch 'kc/new/bug5075' into kcmaster

11 years agobug 5146: patron import files require header row
Galen Charlton [Thu, 28 Oct 2010 11:57:32 +0000 (07:57 -0400)]
bug 5146: patron import files require header row

Fixed help text on this point as well as options for
supplying dates in the input file.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5327: Add basic unit tests to some C4 modules
Magnus Enger [Sat, 30 Oct 2010 04:42:59 +0000 (00:42 -0400)]
Bug 5327: Add basic unit tests to some C4 modules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5327: Add basic unit tests to some C4 modules
Katrin Fischer [Sat, 30 Oct 2010 03:53:45 +0000 (23:53 -0400)]
Bug 5327: Add basic unit tests to some C4 modules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agocreate unit test files
Nicole Engard [Sat, 30 Oct 2010 03:41:25 +0000 (23:41 -0400)]
create unit test files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoAdding a simple test for Service.pm
Liz Rea [Sat, 30 Oct 2010 02:44:26 +0000 (22:44 -0400)]
Adding a simple test for Service.pm

At the advisement of the great Chris Cormack. (thanks for the lesson)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoBug 5322 - Added pwgen dependency
Robin Sheat [Sat, 30 Oct 2010 01:23:43 +0000 (21:23 -0400)]
Bug 5322 - Added pwgen dependency

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
11 years agoFix for Bug 5075 - Terms not highlighted w/ xslt on
Owen Leonard [Thu, 9 Sep 2010 16:07:44 +0000 (12:07 -0400)]
Fix for Bug 5075 - Terms not highlighted w/ xslt on

- XSLT didn't contain the class markup which acts as a hook
  for the JavaScript highlighting system.
- Standard results page also contained a typo which
  prevented data other than title and author from
  being highlighted

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 3211: fix some errors that crept into the cleanup
Galen Charlton [Mon, 25 Oct 2010 15:04:46 +0000 (11:04 -0400)]
bug 3211: fix some errors that crept into the cleanup

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoFurther fixes for Bug 3211, cataloging value plugin forms should be valid XHTML
Owen Leonard [Mon, 26 Jul 2010 16:35:56 +0000 (12:35 -0400)]
Further fixes for Bug 3211, cataloging value plugin forms should be valid XHTML

- Adding page heading
- Adding "Cancel" link to close popup
- Correctly marking up <label> <input> pairs
- Correctly escaping JavaScript blocks
- General markup corrections

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 5128: fix syntax errors in previous patch
Galen Charlton [Fri, 22 Oct 2010 12:19:45 +0000 (08:19 -0400)]
bug 5128: fix syntax errors in previous patch

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoupdate AUTHOR in Makefile.PL v3.02.00
Galen Charlton [Fri, 22 Oct 2010 06:07:22 +0000 (02:07 -0400)]
update AUTHOR in Makefile.PL

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoDB revision 3.02.00.004 - general release of Koha 3.2.0
Galen Charlton [Fri, 22 Oct 2010 05:46:44 +0000 (01:46 -0400)]
DB revision 3.02.00.004 - general release of Koha 3.2.0

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoRelease notes for Koha 3.2.0
Galen Charlton [Fri, 22 Oct 2010 05:45:28 +0000 (01:45 -0400)]
Release notes for Koha 3.2.0

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agostandardize name of ILS-DI:AuthorizedIPs syspref
Galen Charlton [Fri, 22 Oct 2010 04:17:18 +0000 (00:17 -0400)]
standardize name of ILS-DI:AuthorizedIPs syspref

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoupdated to installation instructions
Galen Charlton [Fri, 22 Oct 2010 03:40:08 +0000 (23:40 -0400)]
updated to installation instructions

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 3597: DelItemCheck now refuses to delete items in transit for holds
Galen Charlton [Fri, 22 Oct 2010 03:01:34 +0000 (23:01 -0400)]
bug 3597: DelItemCheck now refuses to delete items in transit for holds

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 3597: "delete all items" no longer deletes checked out or waiting items
Galen Charlton [Fri, 22 Oct 2010 02:56:04 +0000 (22:56 -0400)]
bug 3597: "delete all items" no longer deletes  checked out or waiting items

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 5128: leave record.abs to French defaults
Galen Charlton [Fri, 22 Oct 2010 02:42:27 +0000 (22:42 -0400)]
bug 5128: leave record.abs to French defaults

Compromise so that the majority of the English UNIMARC
framework can be accepted into 3.2.

Non-French UNIMARC users should observe the comment
at the bottom of record.abs.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 5128 [3.2] Unimarc default for holdings. Written with French default
Zeno Tajoli [Fri, 8 Oct 2010 15:54:56 +0000 (17:54 +0200)]
Bug 5128 [3.2] Unimarc default for holdings. Written with French default

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 4972 Fix table creations failing due to foreign key checks
Colin Campbell [Thu, 8 Jul 2010 15:19:17 +0000 (16:19 +0100)]
Bug 4972 Fix table creations failing due to foreign key checks

create tables were failing with cryptic 1005 error from mysql
wrapped creation of aqbasketgroups and aqcontract in
FOREIGN_KEY_CHECKS=0 and FOREIGN_KEY_CHECKS=1

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 3881: remove unused OpacPrivacy syspref
Galen Charlton [Fri, 22 Oct 2010 02:17:15 +0000 (22:17 -0400)]
bug 3881: remove unused OpacPrivacy syspref

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agofixing various links to point to *.koha-community.org
Galen Charlton [Fri, 22 Oct 2010 02:08:24 +0000 (22:08 -0400)]
fixing various links to point to *.koha-community.org

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 3756: remove disused system preference from database
Galen Charlton [Fri, 22 Oct 2010 01:50:27 +0000 (21:50 -0400)]
bug 3756: remove disused system preference from database

This leaves a few system preferences displayed on the
local use tab in the syspref editor that should be displayed
elsewhere, but all of the ones left are actually in use.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoUpdate changelog and build script in preperation for 3.2.0 release
Robin Sheat [Fri, 22 Oct 2010 00:28:24 +0000 (13:28 +1300)]
Update changelog and build script in preperation for 3.2.0 release

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4176: remove references to unimplemented system preference MIME
Galen Charlton [Fri, 22 Oct 2010 01:36:45 +0000 (21:36 -0400)]
bug 4176: remove references to unimplemented system preference MIME

The intended functionality of this system preference was never
implemented.  To avoid template changes prior to 3.2.0, put in
hard-coded string 'CSV' to (accurately) identify the type of
the output files in the affected reports.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 3756: remove more references to disused sysprefs
Galen Charlton [Fri, 22 Oct 2010 01:21:21 +0000 (21:21 -0400)]
bug 3756: remove more references to disused sysprefs

OPACSubscriptionDisplay
OPACDisplayExtendedSubInfo
OAI-PMH:Set
OAI-PMH:Subset
ILS-DI:AuthorizedIPs
libraryAddress
kohaspsuggest
OrderPdfTemplate
marc
acquisitions

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoremove last vestiges of NOTMARC mode
Galen Charlton [Fri, 22 Oct 2010 01:06:52 +0000 (21:06 -0400)]
remove last vestiges of NOTMARC mode

MARC, the metadata exchange format for the 20th century!

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 3756: start removing references to disused sysprefs
Galen Charlton [Fri, 22 Oct 2010 00:35:35 +0000 (20:35 -0400)]
bug 3756: start removing references to disused sysprefs

holdCancelLength
PINESISBN
sortbynonfiling
TemplateEncoding

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoremove two disused functions
Galen Charlton [Fri, 22 Oct 2010 00:31:13 +0000 (20:31 -0400)]
remove two disused functions

html2marc and html2marcxml are not used, and html2marcxml
is the last user of the dead syspref TemplateEncoding

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoremove a couple duplicate lines
Galen Charlton [Fri, 22 Oct 2010 00:14:17 +0000 (20:14 -0400)]
remove a couple duplicate lines

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years ago(bug 3536) fix homeorholdingbranch on return
Henri-Damien LAURENT [Thu, 9 Sep 2010 18:54:12 +0000 (14:54 -0400)]
(bug 3536) fix homeorholdingbranch on return

this patch create a new systempreference "homeorholdingbranch"-like used only for returns.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
An additional edit was made to circ/returns.pl by Ian Walls of ByWater Solutions to force the dialog message for the return to
use the branch specified by the new HomeOrHoldingBranchReturn system preference, rather than always Homebranch.
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 5303 Overdue notices subject is improperly encoded
Frédéric Demians [Wed, 13 Oct 2010 19:43:55 +0000 (21:43 +0200)]
Bug 5303 Overdue notices subject is improperly encoded

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoFixing a double count of a developer and adding a new one to the history
Chris Cormack [Thu, 21 Oct 2010 02:30:17 +0000 (15:30 +1300)]
Fixing a double count of a developer and adding a new one to the history

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 4305 - prevent errors when handling invalid ISBN13 values
Robin Sheat [Wed, 20 Oct 2010 07:13:15 +0000 (20:13 +1300)]
Bug 4305 - prevent errors when handling invalid ISBN13 values

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoMerge branch 'translation' of git://git.workbuffer.org/git/koha into to-push
Galen Charlton [Thu, 21 Oct 2010 21:25:45 +0000 (17:25 -0400)]
Merge branch 'translation' of git://git.workbuffer.org/git/koha into to-push

11 years agoTranslations
Chris Cormack [Thu, 21 Oct 2010 21:12:19 +0000 (10:12 +1300)]
Translations

11 years agoBug 4472 Fix &nbsp; handling for UNIMARC intranet XSL
Frédéric Demians [Sun, 17 Oct 2010 14:18:23 +0000 (16:18 +0200)]
Bug 4472 Fix &nbsp; handling for UNIMARC intranet XSL

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 3164: fix OPAC holds in SingleBranchMode
Galen Charlton [Sun, 17 Oct 2010 17:17:06 +0000 (13:17 -0400)]
bug 3164: fix OPAC holds in SingleBranchMode

Account for case where no branch is explicitly supplied.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoMerge remote branch 'kc/master'
Chris Cormack [Thu, 14 Oct 2010 20:50:18 +0000 (09:50 +1300)]
Merge remote branch 'kc/master'

11 years agoAdd one new speech, bugfix a few other history lines
MJ Ray [Thu, 14 Oct 2010 16:45:37 +0000 (17:45 +0100)]
Add one new speech, bugfix a few other history lines

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years ago(MT #3697) Fixed GetAuthorityRecords
Jean-André Santoni [Wed, 26 May 2010 07:33:26 +0000 (09:33 +0200)]
(MT #3697) Fixed GetAuthorityRecords

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years ago[MT3696] Fixed ILSDI GetAvailability call
Jean-André Santoni [Wed, 26 May 2010 07:20:43 +0000 (09:20 +0200)]
[MT3696] Fixed ILSDI GetAvailability call
(cherry picked from commit 96552d64727dc6fc2525cc9c0c6ece0c718b999d)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years ago(MT #3698) Fixed ILSDI GetRecords
Jean-André Santoni [Wed, 26 May 2010 07:43:58 +0000 (09:43 +0200)]
(MT #3698) Fixed ILSDI GetRecords
(cherry picked from commit f69061357a75a5e024fe6379a1a48f8755a2b6db)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoremove scratch files from the it-IT SQL files
Galen Charlton [Tue, 12 Oct 2010 20:30:22 +0000 (16:30 -0400)]
remove scratch files from the it-IT SQL files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoadd new lenny dependency libmodule-install-perl to the apt-get-debian-lenny.sh script
Liz Rea [Tue, 12 Oct 2010 14:19:17 +0000 (09:19 -0500)]
add new lenny dependency libmodule-install-perl to the apt-get-debian-lenny.sh script

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoadd Italian installer SQL to test cases
Galen Charlton [Tue, 12 Oct 2010 14:18:46 +0000 (10:18 -0400)]
add Italian installer SQL to test cases

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoItalian installer SQL
Galen Charlton [Tue, 12 Oct 2010 14:18:11 +0000 (10:18 -0400)]
Italian installer SQL

Created by Zeno Tajoli <tajoli@cilea.it>.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agofix step to install Indexdata apt key
Galen Charlton [Tue, 12 Oct 2010 12:48:50 +0000 (08:48 -0400)]
fix step to install Indexdata apt key

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoUpdates to INSTALL.debian documentation for 3.2.
Liz Rea [Mon, 11 Oct 2010 20:31:10 +0000 (16:31 -0400)]
Updates to INSTALL.debian documentation for 3.2.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoAdding a temporary workaround to keep template tests from borking on very large templates
Chris Nighswonger [Thu, 7 Oct 2010 03:31:57 +0000 (23:31 -0400)]
Adding a temporary workaround to keep template tests from borking on very large templates

NOTE: This should be properly fixed at some point in 3.4

This may help:

http://www.perlmonks.org/?node_id=150748

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 5288 - Update package dependencies, control source details
Robin Sheat [Thu, 7 Oct 2010 02:57:52 +0000 (15:57 +1300)]
Bug 5288 - Update package dependencies, control source details

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agomark 3.2.0 release candidate - DBrev 3.01.00.999 v3.02.00-rc
Galen Charlton [Thu, 7 Oct 2010 01:26:58 +0000 (21:26 -0400)]
mark 3.2.0 release candidate - DBrev 3.01.00.999

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agodefer rotating collections
Galen Charlton [Thu, 7 Oct 2010 01:12:20 +0000 (21:12 -0400)]
defer rotating collections

Disabling rotating collections for 3.2.0 release; after more testing,
candidate for 3.4 as well as backport into 3.2.1.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agotranslator hack to avoid failure on opac-opensearch.tmpl
Galen Charlton [Thu, 7 Oct 2010 01:01:23 +0000 (21:01 -0400)]
translator hack to avoid failure on opac-opensearch.tmpl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agofurther correction to the invocation of unzip
Galen Charlton [Wed, 6 Oct 2010 23:55:01 +0000 (19:55 -0400)]
further correction to the invocation of unzip

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoTighten system call to unzip
Ian Walls [Wed, 6 Oct 2010 20:25:19 +0000 (16:25 -0400)]
Tighten system call to unzip

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoadd explicit type to <input> elements missing it
Galen Charlton [Wed, 6 Oct 2010 21:43:28 +0000 (17:43 -0400)]
add explicit type to <input> elements missing it

Quells a warning from xt/author/translatable-templates.t

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agobug 4472: in a hackish fashion, quiet warnings about DOCTYPE in the XSLT
Galen Charlton [Wed, 6 Oct 2010 21:42:46 +0000 (17:42 -0400)]
bug 4472: in a hackish fashion, quiet warnings about DOCTYPE in the XSLT

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoMerge branch 'translation' of git://git.workbuffer.org/git/koha into master
Galen Charlton [Wed, 6 Oct 2010 20:26:37 +0000 (16:26 -0400)]
Merge branch 'translation' of git://git.workbuffer.org/git/koha into master

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoUpdated spanish files
Chris Cormack [Wed, 6 Oct 2010 19:51:24 +0000 (08:51 +1300)]
Updated spanish files

11 years agoAnother fix for Bug 2704, 440 Display Issues
Owen Leonard [Tue, 13 Jul 2010 16:44:03 +0000 (12:44 -0400)]
Another fix for Bug 2704, 440 Display Issues

Removing the check for 490 @ind1=0 since the
alternative 8xx tag will not display anyway

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoMerge remote branch 'koha-fbc/k_bug_5284' into master
Galen Charlton [Wed, 6 Oct 2010 17:45:52 +0000 (13:45 -0400)]
Merge remote branch 'koha-fbc/k_bug_5284' into master

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 5284 - Generic report covering various problems with the labels/patron card tests
Chris Nighswonger [Wed, 6 Oct 2010 17:41:34 +0000 (13:41 -0400)]
Bug 5284 - Generic report covering various problems with the labels/patron card tests

This patch removes a very incomplete test script which was really not even formed into
a test routine.

Note: In all probability, the labels tests could be adapted to test patroncards as well.

11 years agoMerge remote branch 'koha-fbc/k_bug_5284' into master
Galen Charlton [Wed, 6 Oct 2010 17:38:33 +0000 (13:38 -0400)]
Merge remote branch 'koha-fbc/k_bug_5284' into master

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 5284 - Generic report covering various problems with the labels/patron card tests
Chris Nighswonger [Wed, 6 Oct 2010 17:33:16 +0000 (13:33 -0400)]
Bug 5284 - Generic report covering various problems with the labels/patron card tests

This patch fixes the C4::Labels::Template tests

11 years agoBug 5284 - Generic report covering various problems with the labels/patron card tests
Chris Nighswonger [Wed, 6 Oct 2010 17:28:18 +0000 (13:28 -0400)]
Bug 5284 - Generic report covering various problems with the labels/patron card tests

This patch fixes the C4::Labels::Profile tests

11 years agoBug 4472 Fix how &nbsp; are injected into XSL files
Frédéric Demians [Sun, 11 Jul 2010 15:53:21 +0000 (17:53 +0200)]
Bug 4472 Fix how &nbsp; are injected into XSL files

tmpl_process is patched to handle properly specific XML directives.
UNIMARC XSL files are modified to gain knowledge of HTML &nbsp; entity
which isn't the case by default. It may be necessary to do the same
thing for MARC21 XSL.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 5284 - Generic report covering various problems with the labels/patron card tests
Chris Nighswonger [Wed, 6 Oct 2010 17:17:32 +0000 (13:17 -0400)]
Bug 5284 - Generic report covering various problems with the labels/patron card tests

This patch fixes the C4::Labels::Layout tests

11 years agoFollowup to Bug 4305: multiple ISBNS in biblioitems.isbn breaks patron
Ian Walls [Wed, 6 Oct 2010 16:46:26 +0000 (12:46 -0400)]
Followup to Bug 4305: multiple ISBNS in biblioitems.isbn breaks patron

This patch adds a scrub for ' | ' when the ISBN comes from the
biblioitems table, in the event that Koha has attempted to store
multiple ISBNs in the field.  The ISBN presented to Business::ISBN will
now be something it can handle.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agofix invalid invocation of GetBranches in test case
Galen Charlton [Wed, 6 Oct 2010 16:54:05 +0000 (12:54 -0400)]
fix invalid invocation of GetBranches in test case

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 5284 - Generic report covering various problems with the labels/patron card tests
Chris Nighswonger [Wed, 6 Oct 2010 16:52:55 +0000 (12:52 -0400)]
Bug 5284 - Generic report covering various problems with the labels/patron card tests

This patch fixes the C4::Labels::Batch tests

11 years agoBug 5013: Advanced patron search category pull down broken
Katrin Fischer [Thu, 16 Sep 2010 15:02:23 +0000 (11:02 -0400)]
Bug 5013: Advanced patron search category pull down broken

The pull down for category in patron's advanced search was only showing any and no patron categories.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agomore test case fixes
Galen Charlton [Wed, 6 Oct 2010 15:55:37 +0000 (11:55 -0400)]
more test case fixes

SQLHelper.t - clean up after itself better
Context.t - fix reporting of test plan

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agocleanup of DB-dependent fund test cases
Galen Charlton [Wed, 6 Oct 2010 15:13:07 +0000 (11:13 -0400)]
cleanup of DB-dependent fund test cases

* remove test that was adding a second active budget period,
  which was throwing off later tests
* updated to reflect current API

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agofix typo/thinko in list test
Galen Charlton [Wed, 6 Oct 2010 14:55:44 +0000 (10:55 -0400)]
fix typo/thinko in list test

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agovarious improvements to t/db_dependent/VirtualShelves.t
Galen Charlton [Wed, 6 Oct 2010 14:39:57 +0000 (10:39 -0400)]
various improvements to t/db_dependent/VirtualShelves.t

* updated to reflect recent (and old) changes to the API
* corrected test plan
* adopted Test::More
* correctly handle and test functionality to not add duplicate
  bibs to a list

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoremoved AddToShelfFromBiblio from C4::VirtualShelves
Galen Charlton [Wed, 6 Oct 2010 14:38:09 +0000 (10:38 -0400)]
removed AddToShelfFromBiblio from C4::VirtualShelves

Back in the day, lists could contain item records instead or in addition
to bibs, but that hasn't been the case for a while.  Therefore, removed
AddToShelfFromBiblio, which does exactly the same thing that AddToShelf does.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agofix test plan and false test errors in Search.t
Galen Charlton [Wed, 6 Oct 2010 13:51:55 +0000 (09:51 -0400)]
fix test plan and false test errors in Search.t

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agofix test plan for SQLHelper.t
Galen Charlton [Wed, 6 Oct 2010 13:44:18 +0000 (09:44 -0400)]
fix test plan for SQLHelper.t

Also removed incorrect comments about test case numbers - we should
just let Test::More number them.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoFix for Bug 2377 - Review tags: format date according to system preference
Owen Leonard [Tue, 17 Aug 2010 13:01:58 +0000 (09:01 -0400)]
Fix for Bug 2377 - Review tags: format date according to system preference

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoMerge branch 'test_cases' of /home/koha/koha1/dev into to-push
Galen Charlton [Wed, 6 Oct 2010 13:23:42 +0000 (09:23 -0400)]
Merge branch 'test_cases' of /home/koha/koha1/dev into to-push

11 years agofix typo in INSTALL.debian
Galen Charlton [Wed, 6 Oct 2010 13:20:10 +0000 (09:20 -0400)]
fix typo in INSTALL.debian

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agouse Test::More for t/Koha.t
Galen Charlton [Wed, 6 Oct 2010 13:15:36 +0000 (09:15 -0400)]
use Test::More for t/Koha.t

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoFix for Bug 5100, Incorrect link to System Preferences
Owen Leonard [Fri, 6 Aug 2010 19:03:12 +0000 (15:03 -0400)]
Fix for Bug 5100, Incorrect link to System Preferences

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoFix for Bug 5156 - JavaScript error when adding list
Owen Leonard [Thu, 19 Aug 2010 14:53:44 +0000 (10:53 -0400)]
Fix for Bug 5156 - JavaScript error when adding list

JavaScript referenced nonexistent form name

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agofixes bug 4385
Ian Walls [Tue, 10 Aug 2010 06:47:59 +0000 (08:47 +0200)]
fixes bug 4385

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 5264 (Retain additional bibliographic subfields when merging authorities) [for...
Marcel de Rooy [Thu, 30 Sep 2010 08:03:16 +0000 (08:03 +0000)]
Bug 5264 (Retain additional bibliographic subfields when merging authorities) [for master only]

The current code in AuthoritiesMarc.pm rewrites all subfields from the report
tag in the authority record to fields in related bibliographic records when
merging authorities. Additional subfields in the biblio records (e.g. relator
code or term) are lost in the process.

This patch retains the original algorithm but restores the additional subfields
from the original biblio record when rewriting the linked marc fields.

The problem also exists in 3.0. Two separate patches have been submitted.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoFixing non placeholder sql in UpdateGuarantees
Chris Cormack [Sun, 1 Aug 2010 09:29:58 +0000 (21:29 +1200)]
Fixing non placeholder sql in UpdateGuarantees

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 5089: Add German translation of borrowerRelationship and BorrowersTitles values
Katrin Fischer [Wed, 4 Aug 2010 16:12:48 +0000 (18:12 +0200)]
Bug 5089: Add German translation of borrowerRelationship and BorrowersTitles values

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoFix for Bug 5093 - JavaScript error in IE8 when choosing authority record
Owen Leonard [Thu, 5 Aug 2010 19:55:01 +0000 (15:55 -0400)]
Fix for Bug 5093 - JavaScript error in IE8 when choosing authority record

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 5092: No results when searching by LC Call Number: in Z39.50 Server
Katrin Fischer [Sun, 8 Aug 2010 19:19:41 +0000 (21:19 +0200)]
Bug 5092: No results when searching by LC Call Number: in Z39.50 Server

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoFix for Bug 2947, value_builder scripts using authnotrequired
Owen Leonard [Tue, 17 Aug 2010 13:29:25 +0000 (09:29 -0400)]
Fix for Bug 2947, value_builder scripts using authnotrequired

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
11 years agoBug 3630 Impossible to perform Scan Indexes search
Frédéric Demians [Wed, 25 Aug 2010 07:51:21 +0000 (09:51 +0200)]
Bug 3630 Impossible to perform Scan Indexes search

This is a quick fix. The way scan indexes performs should be improved in
3.4. There are several issues:

  - No paging
  - The interface is the same as for biblio records search result and so
    is unusable: for example you have a button to place a hold or you
    can sort by Popularity which is irrelevant for index terms.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>