koha.git
16 years agoAuth.pm should have "CAN_user_updatecharges" (plural), and this change to InstallAuth...
Joe Atzberger [Tue, 4 Dec 2007 23:40:43 +0000 (17:40 -0600)]
Auth.pm should have "CAN_user_updatecharges" (plural), and this change to InstallAuth.pm should catch it.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoChange to patron-renewal javascript to fix issues described in Bug 1620
Owen Leonard [Tue, 4 Dec 2007 23:40:42 +0000 (17:40 -0600)]
Change to patron-renewal javascript to fix issues described in Bug 1620

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFixing typo in value_builder/dateaccessioned.pl; Adding error message output to addit...
Owen Leonard [Tue, 4 Dec 2007 23:40:41 +0000 (17:40 -0600)]
Fixing typo in value_builder/dateaccessioned.pl; Adding error message output to additem.tmpl (fixes Bug 1636, Can't delete from additems.pl).

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMoving "Check Out" from the action toolbar to the view menu
Owen Leonard [Tue, 4 Dec 2007 23:40:40 +0000 (17:40 -0600)]
Moving "Check Out" from the action toolbar to the view menu

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoRemoving parameters permission requirement on about.pl, minor markup change to member...
Owen Leonard [Tue, 4 Dec 2007 23:40:39 +0000 (17:40 -0600)]
Removing parameters permission requirement on about.pl, minor markup change to member-flags.tmpl.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMembers.pm - respond to $debug, some formatting and reduction of duplicative code.
Joe Atzberger [Tue, 4 Dec 2007 23:36:03 +0000 (17:36 -0600)]
Members.pm - respond to $debug, some formatting and reduction of duplicative code.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAuth.t - running this test will fail unless Auth.pm patches get trough.
Joe Atzberger [Sun, 2 Dec 2007 19:41:46 +0000 (13:41 -0600)]
Auth.t - running this test will fail unless Auth.pm patches get trough.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAuth_with_ldap : module and test final touches.
Joe Atzberger [Sun, 2 Dec 2007 19:41:45 +0000 (13:41 -0600)]
Auth_with_ldap : module and test final touches.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agomoremember.pl - Dates.pm "syspref" made explicit. Scripts should not call C4::Context...
Joe Atzberger [Thu, 29 Nov 2007 23:43:13 +0000 (17:43 -0600)]
moremember.pl - Dates.pm "syspref" made explicit. Scripts should not call C4::Context->preference('dateformat').

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoLDAP - further integration
Joe Atzberger [Thu, 29 Nov 2007 23:43:12 +0000 (17:43 -0600)]
LDAP - further integration

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoDates.pm - ongoing integration, acqui/histsearch.pl
Joe Atzberger [Thu, 29 Nov 2007 23:43:11 +0000 (17:43 -0600)]
Dates.pm - ongoing integration, acqui/histsearch.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoLog.pm: reduce duplicative code in conditional
Joe Atzberger [Thu, 29 Nov 2007 23:43:09 +0000 (17:43 -0600)]
Log.pm: reduce duplicative code in conditional

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAuth.pm -- just the start of trying to make Auth intelligible and extensible
Joe Atzberger [Thu, 29 Nov 2007 23:43:07 +0000 (17:43 -0600)]
Auth.pm -- just the start of trying to make Auth intelligible and extensible

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoDates.pm -- Comment and perldoc cleanup.
Joe Atzberger [Thu, 29 Nov 2007 23:43:06 +0000 (17:43 -0600)]
Dates.pm -- Comment and perldoc cleanup.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBig LDAP changes, module test for Context.pm, still more yet to come.
Joe Atzberger [Thu, 29 Nov 2007 23:43:05 +0000 (17:43 -0600)]
Big LDAP changes, module test for Context.pm, still more yet to come.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoadding back CDATA for validation
Joshua Ferraro [Tue, 4 Dec 2007 23:25:47 +0000 (17:25 -0600)]
adding back CDATA for validation

16 years agoContext.pm: obvious code consolidation, perldoc corrections.
Joe Atzberger [Thu, 29 Nov 2007 23:43:04 +0000 (17:43 -0600)]
Context.pm: obvious code consolidation, perldoc corrections.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofixing virtual shelves (unfinished)
Paul POULAIN [Wed, 28 Nov 2007 22:00:56 +0000 (16:00 -0600)]
fixing virtual shelves (unfinished)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoLetters.pm: Minor change. Unsure if this is "the right" move, but pretty sure the...
Joe Atzberger [Thu, 29 Nov 2007 23:43:10 +0000 (17:43 -0600)]
Letters.pm: Minor change. Unsure if this is "the right" move, but pretty sure the line does not make sense as is.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoChanges to address Bug 774 (z3950 search results window not resizable)
Owen Leonard [Tue, 4 Dec 2007 21:00:11 +0000 (15:00 -0600)]
Changes to address Bug 774 (z3950 search results window not resizable)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoChanges to fix Bug 1335 (Min password length is hardcoded in template error message...
Owen Leonard [Tue, 4 Dec 2007 21:00:10 +0000 (15:00 -0600)]
Changes to fix Bug 1335 (Min password length is hardcoded in template error message). Script now checks for passes to the template the value of minPasswordLength system preference so the user knows beforehand what the requirements are, and so that the error message can contain the correct value.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoPassing "adultborrower" variable to the template so that "Add Child" button can be...
Owen Leonard [Tue, 4 Dec 2007 21:00:09 +0000 (15:00 -0600)]
Passing "adultborrower" variable to the template so that "Add Child" button can be displayed in the toolbar when appropriate. Fixes Bug 1510.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoCorrections to page title, breadcrumbs, heading
Owen Leonard [Tue, 4 Dec 2007 21:00:08 +0000 (15:00 -0600)]
Corrections to page title, breadcrumbs, heading

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoChanges to image-load check (used for patron images and amazon book covers) to tweak...
Owen Leonard [Tue, 4 Dec 2007 21:00:07 +0000 (15:00 -0600)]
Changes to image-load check (used for patron images and amazon book covers) to tweak when the script checked for loaded images (now window.load() instead of document.ready())

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFinishing changes to sidebar menu (change to boraccount.pl, as with moremember.pl...
Owen Leonard [Tue, 4 Dec 2007 21:00:06 +0000 (15:00 -0600)]
Finishing changes to sidebar menu (change to boraccount.pl, as with moremember.pl, is to add flag so that menu can highlight current page).

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFixing some menu formatting
Owen Leonard [Tue, 4 Dec 2007 21:00:05 +0000 (15:00 -0600)]
Fixing some menu formatting

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMinor corrections to form layouts
Owen Leonard [Tue, 4 Dec 2007 21:00:04 +0000 (15:00 -0600)]
Minor corrections to form layouts

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoTrying again for layout fixes and template corrections for opac-advsearch.
Owen Leonard [Tue, 4 Dec 2007 21:00:03 +0000 (15:00 -0600)]
Trying again for layout fixes and template corrections for opac-advsearch.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdding "clearfix" class, used to add clearning to element without use of break or...
Owen Leonard [Tue, 4 Dec 2007 21:00:02 +0000 (15:00 -0600)]
Adding "clearfix" class, used to add clearning to element without use of break or other additional markup.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFix to get this working with the modules in 3.0
Chris Cormack [Tue, 4 Dec 2007 18:54:03 +0000 (12:54 -0600)]
Fix to get this working with the modules in 3.0

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobib_profile web svc: report biblioitems.itemtype subfield as non-mandatory
Galen Charlton [Tue, 4 Dec 2007 17:28:27 +0000 (11:28 -0600)]
bib_profile web svc: report biblioitems.itemtype subfield as non-mandatory

Per discussion with Chris Catalfo, biblios will optionally
supply this subfield (942$c) but is not required to do so,
as Koha automatically creates the biblioitem anyway.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofixing dateaccessioned plugin
Joshua Ferraro [Tue, 4 Dec 2007 19:44:31 +0000 (13:44 -0600)]
fixing dateaccessioned plugin

16 years agoBug 1620
Chris Cormack [Mon, 3 Dec 2007 23:54:56 +0000 (17:54 -0600)]
Bug 1620

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoRemoving debugging from javascript, accidentally comitted.
Owen Leonard [Mon, 3 Dec 2007 23:02:40 +0000 (17:02 -0600)]
Removing debugging from javascript, accidentally comitted.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoSome fixes for "delete" menu items in toolbars to ensure that redirects are handled...
Owen Leonard [Mon, 3 Dec 2007 23:02:39 +0000 (17:02 -0600)]
Some fixes for "delete" menu items in toolbars to ensure that redirects are handled properly. Adding borrowernumber hidden field to some templates in order to enable delete button on all member-related pages.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoChanges to CSS to allow for bug 1357 fix. Trying again after previous patch wouldn...
Owen Leonard [Mon, 3 Dec 2007 23:02:38 +0000 (17:02 -0600)]
Changes to CSS to allow for bug 1357 fix. Trying again after previous patch wouldn't apply

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoTrying again on some changes that wouldn't patch earlier
Owen Leonard [Mon, 3 Dec 2007 23:02:37 +0000 (17:02 -0600)]
Trying again on some changes that wouldn't patch earlier

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFix for bug 1632
Chris Cormack [Mon, 3 Dec 2007 20:35:39 +0000 (14:35 -0600)]
Fix for bug 1632

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoUncommenting delete code as deleting now works fine
Chris Cormack [Mon, 3 Dec 2007 20:05:16 +0000 (14:05 -0600)]
Uncommenting delete code as deleting now works fine

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofix minor XHTML validation issues
Galen Charlton [Mon, 3 Dec 2007 19:45:29 +0000 (13:45 -0600)]
fix minor XHTML validation issues

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFix for re-enrollment not working
Chris Cormack [Mon, 3 Dec 2007 01:14:20 +0000 (19:14 -0600)]
Fix for re-enrollment not working

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFix for renewing
Chris Cormack [Sun, 2 Dec 2007 23:10:29 +0000 (17:10 -0600)]
Fix for renewing

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFix for missing toolbar on member pages
Chris Cormack [Sun, 2 Dec 2007 23:05:34 +0000 (17:05 -0600)]
Fix for missing toolbar on member pages

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFix for bug 1575
Chris Cormack [Sun, 2 Dec 2007 22:14:21 +0000 (16:14 -0600)]
Fix for bug 1575

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agodisable actions in moremember based on staff_access permission
Ryan Higgins [Sun, 2 Dec 2007 09:56:45 +0000 (03:56 -0600)]
disable actions in moremember based on staff_access permission

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdd Staff member type. Add permissions checks for bug# 1269
Ryan Higgins [Sun, 2 Dec 2007 02:56:27 +0000 (20:56 -0600)]
Add Staff member type. Add permissions checks for bug# 1269

and related permissions on memberentry and mods.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoadding userflag to allow modification of staff borrowers.
Ryan Higgins [Sun, 2 Dec 2007 02:50:02 +0000 (20:50 -0600)]
adding userflag to allow modification of staff borrowers.

will add Staff category type in subsequent commit

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoSlight mod to getuserflags and haspermission in prep for perms bugfix
Ryan Higgins [Sun, 2 Dec 2007 02:35:38 +0000 (20:35 -0600)]
Slight mod to getuserflags and haspermission in prep for perms bugfix

Also adding some pod

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoadding Staff Borrower to handle Bug 1269
Ryan Higgins [Sun, 25 Nov 2007 22:31:01 +0000 (16:31 -0600)]
adding Staff Borrower to handle Bug 1269

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agowarn on attempts to add duplicate item barcodes during batch import
Galen Charlton [Sun, 2 Dec 2007 19:41:44 +0000 (13:41 -0600)]
warn on attempts to add duplicate item barcodes during batch import

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobug 1615: AddItem() now sets issues, renewals, and reserves
Galen Charlton [Sun, 2 Dec 2007 19:41:43 +0000 (13:41 -0600)]
bug 1615: AddItem() now sets issues, renewals, and reserves

When an item was created,  the renewals, issues, and reserves columns
were not set from the MARC data.  This was noticed particularly
in the context of batch loads, where a user might supply
data for those fields.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobumped up MARC Perl module requirements
Galen Charlton [Sun, 2 Dec 2007 19:41:42 +0000 (13:41 -0600)]
bumped up MARC Perl module requirements

MARC::File::XML => 0.88 as part of fixing bug 1504
in turn MARC::Charset => 0.98 and MARC::Record => 2.00.

Previous required version of MARC::Record was 1.38, but
since that is three years old, assuming that most Koha
3.0 dev and testing has been done with version 2.0.0.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobug 1570: return to same tab if cancelling preference edit
Galen Charlton [Sun, 2 Dec 2007 19:41:41 +0000 (13:41 -0600)]
bug 1570: return to same tab if cancelling preference edit

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoShouldn't opac-advsearch use masthead as other templates ?
Paul POULAIN [Fri, 30 Nov 2007 16:23:23 +0000 (10:23 -0600)]
Shouldn't opac-advsearch use masthead as other templates ?

Anyway, masthead-basic is badly broken atm

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFixing layout of guarantor display/search and correcting javascript handling of those...
Owen Leonard [Fri, 30 Nov 2007 16:50:24 +0000 (10:50 -0600)]
Fixing layout of guarantor display/search and correcting javascript handling of those form fields.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoA few corrections, reformatting display slightly
Owen Leonard [Fri, 30 Nov 2007 16:50:23 +0000 (10:50 -0600)]
A few corrections, reformatting display slightly

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoSome changes to unimarc record.abs
Paul POULAIN [Fri, 30 Nov 2007 16:23:24 +0000 (10:23 -0600)]
Some changes to unimarc record.abs

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBug fixing : infinite loop when repeated operator + distinguishing operators
Henri-Damien LAURENT [Fri, 30 Nov 2007 16:14:11 +0000 (10:14 -0600)]
Bug fixing : infinite loop when repeated operator + distinguishing operators

limits would provide with unnecessary repeated "and"
Thus causing wild loop
So removing them.
aud was transformed into author when it qualified audience.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agosmall fix in README.txt
Henri-Damien LAURENT [Fri, 30 Nov 2007 16:14:10 +0000 (10:14 -0600)]
small fix in README.txt

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBug Fixing : NZsearch
root [Fri, 30 Nov 2007 16:14:09 +0000 (10:14 -0600)]
Bug Fixing : NZsearch

parenthesis introduce a priority.
yr:XXXX-YYYY is now processed correctly.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agochanging haspermission() to require that user has ALL requiredflags, not ANYOF requir...
Ryan Higgins [Thu, 29 Nov 2007 23:43:03 +0000 (17:43 -0600)]
changing haspermission() to require that user has ALL requiredflags, not ANYOF requiredflags

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoUNIMARC specific : itemtype is now known as itype
Paul POULAIN [Thu, 29 Nov 2007 20:22:59 +0000 (14:22 -0600)]
UNIMARC specific : itemtype is now known as itype

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoit appears that hidelostitems can be true here and not set to 1 in syspref
Paul POULAIN [Thu, 29 Nov 2007 20:22:58 +0000 (14:22 -0600)]
it appears that hidelostitems can be true here and not set to 1 in syspref

in syspref it appears as "OFF", but in opac-search it's considered as true.
Changing the test to be sure syspref & opac-search consider the same thing

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoHTML::Template => HTML::Template::Pro
Paul POULAIN [Thu, 29 Nov 2007 20:22:57 +0000 (14:22 -0600)]
HTML::Template => HTML::Template::Pro

HTML::Template is no more used, some were remaining,
fixing the "use ...;" to H::T::Pro only

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agomerging in changes to staff css
Joshua Ferraro [Sun, 2 Dec 2007 20:51:10 +0000 (14:51 -0600)]
merging in changes to staff css

16 years agoadding yellow style for search term
Paul POULAIN [Wed, 28 Nov 2007 22:00:55 +0000 (16:00 -0600)]
adding yellow style for search term

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agowhen the result has an author as search term, the link contained the <span style...
Paul POULAIN [Wed, 28 Nov 2007 22:00:53 +0000 (16:00 -0600)]
when the result has an author as search term, the link contained the <span style="term"> in it

this fix add a author_nospan, that contains the author in it's native form

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agomaterial type is mc, not mt, synch'ing opac with staff
Paul POULAIN [Fri, 30 Nov 2007 10:10:21 +0000 (11:10 +0100)]
material type is mc, not mt, synch'ing opac with staff

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFix for bug 1613 making sure the zebraqueue is updated when an item is
Chris Cormack [Thu, 29 Nov 2007 00:28:32 +0000 (18:28 -0600)]
Fix for bug 1613 making sure the zebraqueue is updated when an item is

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoremoved extraneous warns
Galen Charlton [Thu, 29 Nov 2007 03:13:33 +0000 (21:13 -0600)]
removed extraneous warns

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobugfix: do not store item tags when saving old copy of bib
Galen Charlton [Thu, 29 Nov 2007 03:13:32 +0000 (21:13 -0600)]
bugfix: do not store item tags when saving old copy of bib

If a MARC batch was imported, then reverted, the 952s
from the saved copied of the bib were added back
when the bib was replaced, leading to duplication

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoChange from kados to XISBN.pm ("handle no response from ThingISBN"), and change to...
Owen Leonard [Thu, 29 Nov 2007 03:13:31 +0000 (21:13 -0600)]
Change from kados to XISBN.pm ("handle no response from ThingISBN"), and change to similar items markup in detail.tmpl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoTrying new format for OPAC resident search bar and menus. Also making correction...
Owen Leonard [Thu, 29 Nov 2007 03:13:30 +0000 (21:13 -0600)]
Trying new format for OPAC resident search bar and menus. Also making correction to opac-detail similar items markup, although it's probably still not working yet.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoIf LibraryName was not specified, the opac layout was broken. Adding a default (...
Owen Leonard [Thu, 29 Nov 2007 03:13:29 +0000 (21:13 -0600)]
If LibraryName was not specified, the opac layout was broken. Adding a default ("Koha Online Catalog") to the template in case LibraryName is empty.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMinor style tweaks here and there.
Owen Leonard [Thu, 29 Nov 2007 03:13:28 +0000 (21:13 -0600)]
Minor style tweaks here and there.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMore work on returns messages.
Owen Leonard [Thu, 29 Nov 2007 03:13:27 +0000 (21:13 -0600)]
More work on returns messages.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFocusing Check-In tab on returns.pl
Owen Leonard [Thu, 29 Nov 2007 03:13:26 +0000 (21:13 -0600)]
Focusing Check-In tab on returns.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofixing problem with adv search on staff client
Joshua Ferraro [Wed, 28 Nov 2007 18:46:38 +0000 (12:46 -0600)]
fixing problem with adv search on staff client

Issue was that language limit was being set with a
relation (=) but no operand

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobug 1614: revise GetMarcItem so that info dervies from items table
Galen Charlton [Tue, 27 Nov 2007 22:00:39 +0000 (16:00 -0600)]
bug 1614: revise GetMarcItem so that info dervies from items table

This should help make the items table more authoritative, and ensures
that the items editor does not blank circulation fields such as
issues.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoContinuing reformatting of returns.tmpl; Correcting javascript error in request.tmpl.
Owen Leonard [Tue, 27 Nov 2007 20:53:27 +0000 (14:53 -0600)]
Continuing reformatting of returns.tmpl; Correcting javascript error in request.tmpl.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAttempting to pretty up confirmations and messages in returns; Adding some variables...
Owen Leonard [Tue, 27 Nov 2007 20:53:06 +0000 (14:53 -0600)]
Attempting to pretty up confirmations and messages in returns; Adding some variables to the template output; Fixing layout in circulation.tmpl for patrons without messages; Minor correction to OPAC css.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoTweaking display of MARC records in the OPAC
Owen Leonard [Tue, 27 Nov 2007 20:52:48 +0000 (14:52 -0600)]
Tweaking display of MARC records in the OPAC

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoCorrecting breadcrumbs
Owen Leonard [Tue, 27 Nov 2007 20:52:39 +0000 (14:52 -0600)]
Correcting breadcrumbs

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdding auto-fill links for variable types
Owen Leonard [Tue, 27 Nov 2007 20:52:29 +0000 (14:52 -0600)]
Adding auto-fill links for variable types

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMinor changes to systempreferences markup, including re-adding edit link on system...
Owen Leonard [Tue, 27 Nov 2007 20:52:21 +0000 (14:52 -0600)]
Minor changes to systempreferences markup, including re-adding edit link on system pref variable, very helpful if the display runs off the right side of the screen.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMoving holdings, description, editions, and related into tabs, enabling AmazonSimilar...
Owen Leonard [Tue, 27 Nov 2007 20:52:10 +0000 (14:52 -0600)]
Moving holdings, description, editions, and related into tabs, enabling AmazonSimilarItems global preference for the staff client (but not working?)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoIncremental changes to reviews, similar items
Owen Leonard [Tue, 27 Nov 2007 20:51:49 +0000 (14:51 -0600)]
Incremental changes to reviews, similar items

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoimproved terminology for WITHDRAWN authorized value
Galen Charlton [Tue, 27 Nov 2007 20:29:32 +0000 (14:29 -0600)]
improved terminology for WITHDRAWN authorized value

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobugfix: handle subfield $0 in MARC for an item
Galen Charlton [Tue, 27 Nov 2007 20:08:06 +0000 (14:08 -0600)]
bugfix: handle subfield $0 in MARC for an item

Note: C4::Biblio::GetMarcFromKohaField returns (0, 0) if
the kohafield is not defined in the MARC framework, but
in may places the return value is not checked correctly
and does not recognize a subfield $0 (zero).  It
would be better if GetMarcFromKohaField returned (undef, undef)
in that circumstance, but because of the number of places
where that function is used, the changed is deferred for
post 3.0.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobug 1616: handle NULL in damaged, wthdrawn, or itemlost columns
Galen Charlton [Tue, 27 Nov 2007 20:08:05 +0000 (14:08 -0600)]
bug 1616: handle NULL in damaged, wthdrawn, or itemlost columns

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMARC21 framework: changed 'items.withdrawn' to 'items.wthdrawn'
Galen Charlton [Tue, 27 Nov 2007 20:08:04 +0000 (14:08 -0600)]
MARC21 framework: changed 'items.withdrawn' to 'items.wthdrawn'

The correct field is 'items.wthdrawn', not 'items.withdrawn'.
Spelling may be corrected in post-3.0 version.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobug 1616: update bib MARC and zebraqueue on item update
Galen Charlton [Tue, 27 Nov 2007 16:28:09 +0000 (10:28 -0600)]
bug 1616: update bib MARC and zebraqueue on item update

Fixed so that when using updateitem.pl to change an
item's lost, damaged, or withdrawn status, the
bib's MARC XML is updated and an entry is added
to zebraqueue.

As part of the fix, C4::Biblio::ModItemInMarconefield
now works correctly.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoadding template code for AmazonSimilarItems et al
Joshua Ferraro [Tue, 27 Nov 2007 03:26:51 +0000 (21:26 -0600)]
adding template code for AmazonSimilarItems et al

Test this by having the following ISBNs in your system:

0152018484
0152053530

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofixing langauge limit indexes were removed
Joshua Ferraro [Mon, 26 Nov 2007 14:59:52 +0000 (08:59 -0600)]
fixing langauge limit indexes were removed

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMARC import: part 6 of large file support
Galen Charlton [Mon, 26 Nov 2007 22:30:26 +0000 (16:30 -0600)]
MARC import: part 6 of large file support

Added background job and AJAX progress updates
to MARC commit job.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMARC import: part 5 of large file support
Galen Charlton [Mon, 26 Nov 2007 21:40:57 +0000 (15:40 -0600)]
MARC import: part 5 of large file support

Staging job now gets moved to background so that
it does not get killed if it takes longer
than the Apache timeout.

Added AJAX monitoring of job status.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoC4::UploadedFile -- simplified serialization
Galen Charlton [Mon, 26 Nov 2007 21:40:56 +0000 (15:40 -0600)]
C4::UploadedFile -- simplified serialization

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMARC import: part 4 of large file support
Galen Charlton [Mon, 26 Nov 2007 21:40:55 +0000 (15:40 -0600)]
MARC import: part 4 of large file support

* Added C4::BackgroundJob to monitor tracking of
  background jobs
* start modifying stage-marc-import to use it

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMore work on editions in the OPAC; Need both a staff client and OPAC system pref...
Owen Leonard [Mon, 26 Nov 2007 21:00:57 +0000 (15:00 -0600)]
More work on editions in the OPAC; Need both a staff client and OPAC system pref for turning on and off XISBN stuff.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMoving system preferences search (yay!) into resident search form
Owen Leonard [Mon, 26 Nov 2007 21:00:32 +0000 (15:00 -0600)]
Moving system preferences search (yay!) into resident search form

Signed-off-by: Joshua Ferraro <jmf@liblime.com>