koha.git
8 years agoBug 8679 [REVISED] Remove usage of Amazon API
Owen Leonard [Mon, 27 Aug 2012 20:04:48 +0000 (16:04 -0400)]
Bug 8679 [REVISED] Remove usage of Amazon API

This patch removes the AmazonReviews and AmazonSimilarItems
features from the OPAC and staff client. With on Amazon
feature remaining, cover images, the *AmazonEnabled preference
is also removed in favor of checking the *AmazonCoverImages
preference. Two other system preferences, AWSAccessKeyID and
AWSPrivateKey are removed as they were required only by the
removed features.

Handling of book cover images from Amazon is unchanged.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Turned on amazon covers in opac and staff client and all
worked as expected. Then tested to make sure other cover image
services still worked and they do.

Signing off.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8172: Followup: Removes useless empty params
Jonathan Druart [Mon, 2 Jul 2012 14:14:35 +0000 (16:14 +0200)]
Bug 8172: Followup: Removes useless empty params

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8172 - Missing dereference marker for buildQuery parameter in addbooks.pl Added...
Mark Tompsett [Fri, 29 Jun 2012 14:24:50 +0000 (22:24 +0800)]
Bug 8172 - Missing dereference marker for buildQuery parameter in addbooks.pl Added a dereference to an array parameter of buildQuery.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
8 years agoBug 8329 - GetLostItems in C4::Items.pm has a SELECT * Provided a smaller list based...
Mark Tompsett [Fri, 29 Jun 2012 14:40:24 +0000 (22:40 +0800)]
Bug 8329 - GetLostItems in C4::Items.pm has a SELECT * Provided a smaller list based on reports/itemlost.tt

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8395: Fix sort order in parcel.tt (summary)
Jonathan Druart [Mon, 23 Jul 2012 09:46:01 +0000 (11:46 +0200)]
Bug 8395: Fix sort order in parcel.tt (summary)

Signed-off-by: Marc Veron <veron@veron.ch>
Patch behaves as expected.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8513: OPAC detail page broken with XSLT
Fridolyn SOMERS [Mon, 30 Jul 2012 12:36:33 +0000 (14:36 +0200)]
Bug 8513: OPAC detail page broken with XSLT

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8547 - JS error in star ratings breaks IE
Robin Sheat [Wed, 1 Aug 2012 12:23:14 +0000 (14:23 +0200)]
Bug 8547 - JS error in star ratings breaks IE

Writing code with best practices in mind breaks IE. Thanks Internet
Explorer. Now go DiaF.

Signed-off-by: Marc Veron <veron@veron.ch>
Tested with with IE 7.0.5730.13 on Windows XP, no JS errors, stars display and behave as expected

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(Aslo tested it does not break FF)

8 years agoBug 8572: invalid auth shouldn't cause error
Jared Camins-Esakov [Sat, 4 Aug 2012 17:48:00 +0000 (13:48 -0400)]
Bug 8572: invalid auth shouldn't cause error

Prior to this patch, attempting to view an invalid authority in the
OPAC gave a system error instead of a 404. With this patch, the user
will just get a 404, as is the case with invalid bibs.

To test:
1) Try to view an invalid authority by going to:
   /cgi-bin/koha/opac-authoritiesdetail.pl?authid=999999999999
   (presuming that you don't have an authority with authid 999999999999
   in your database) before and after applying this patch

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8636: Add missing dependencies
Jared Camins-Esakov [Mon, 13 Aug 2012 22:16:27 +0000 (18:16 -0400)]
Bug 8636: Add missing dependencies

Cache::Memcached::Fast is used for caching
Test::YAML::Valid is used for tests
Signed-off-by: Marc Veron <veron@veron.ch>
Dependencies appear as expected...
...and I see that they are not instaled yet on my server  :-)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8162: allow packages to work on Ubuntu Precise
Robin Sheat [Fri, 20 Jul 2012 10:20:47 +0000 (12:20 +0200)]
Bug 8162: allow packages to work on Ubuntu Precise

The newer version of MySQL in Ubuntu 12.04 installs a default
'localhost' user with no username. Due to the way that MySQL looks up
user details when you connect, if you connect from localhost and the
user was only created with a wildcard host (%), the anonymous localhost
user will be found instead. This means that your username is lost for
the connection, and you have no privileges.

This patch creates a second user with a hostname of 'localhost'. This
will not work if your database is on a remote server, but you probably
know what you are doing if that's the case. Patches to determine this
server's name relative to the MySQL server are welcome (or even ideas on
how to do it.)

It also fixes up a couple of other small things:
* make koha-remove stop zebra properly
* stop the warning that the password file is missing on create

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Works as promised.

8 years agoMerge remote-tracking branch 'origin/new/bug_8268'
Paul Poulain [Tue, 28 Aug 2012 16:03:34 +0000 (18:03 +0200)]
Merge remote-tracking branch 'origin/new/bug_8268'

8 years agoBug 8268: improve error checking
Jared Camins-Esakov [Wed, 1 Aug 2012 14:30:45 +0000 (16:30 +0200)]
Bug 8268: improve error checking

Valid download attempts were being denied thanks to an incorrect
regular expression. This patch fixes that, and makes it easier to
understand what's going on in the code.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8268 follow-up: rewrite config correctly
Jared Camins-Esakov [Sat, 28 Jul 2012 01:45:47 +0000 (21:45 -0400)]
Bug 8268 follow-up: rewrite config correctly

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Problem fixed.

8 years agoBug 8576: Software error on authority edition when using merge
Fridolyn SOMERS [Mon, 6 Aug 2012 13:01:09 +0000 (15:01 +0200)]
Bug 8576: Software error on authority edition when using merge

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8495: Fix JS error when creating a new order
Julian Maurice [Tue, 24 Jul 2012 10:24:11 +0000 (12:24 +0200)]
Bug 8495: Fix JS error when creating a new order

bug introduced by bug 7178
(http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7178)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
8 years agoBug 8607: FIX overdues_notices script: $date is not replaced
Jonathan Druart [Thu, 9 Aug 2012 13:40:53 +0000 (15:40 +0200)]
Bug 8607: FIX overdues_notices script: $date is not replaced

The script is unusable.
The variable $date is not replaced with its content.

Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 5600: very tiny follow-up to pass perlcritic
Julian Maurice [Fri, 3 Aug 2012 15:00:06 +0000 (17:00 +0200)]
Bug 5600: very tiny follow-up to pass perlcritic

open was called with 2 arguments instead of 3

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 5600 follow-up: Fix commandline check in order to work under Plack
Julian Maurice [Fri, 3 Aug 2012 14:26:34 +0000 (16:26 +0200)]
Bug 5600 follow-up: Fix commandline check in order to work under Plack

With plackup, @ARGV can contains elements so we can't check the size of
@ARGV to tell whether we are in command line mode or not.
Instead we check environment variable GATEWAY_INTERFACE.

Also fix the use of a global variable in a subroutine

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 5600: Command line interface for tools/export.pl
Julian Maurice [Wed, 6 Jun 2012 13:28:18 +0000 (15:28 +0200)]
Bug 5600: Command line interface for tools/export.pl

export.pl [--format=format] [--date=date] [--dont_export_items]
  [--deleted_barcodes] [--clean] --filename=outputfile

    * format is either 'xml' or 'marc' (default)
    * date should be entered as the 'dateformat' syspref is set
      (dd/mm/yyyy for metric, yyyy-mm-dd for iso, mm/dd/yyyy for us)
    * records exported are the ones that have been modified since 'date'
    * if --deleted_barcodes is used, a list of barcodes of items deleted
      since 'date' is produced (or from all deleted items if no date is
      specified)
    * --clean removes NSE/NSB

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 3383 - Followup - Switch from GetMemberDetails to GetMember
Kyle M Hall [Mon, 2 Jul 2012 16:19:23 +0000 (12:19 -0400)]
Bug 3383 - Followup - Switch from GetMemberDetails to GetMember

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 3383 - Item due reminder digests - cannot display title information
Kyle M Hall [Wed, 4 Apr 2012 13:56:11 +0000 (09:56 -0400)]
Bug 3383 - Item due reminder digests - cannot display title information

Adds the ability to use branches.* fields in digest notices and
have them be parsed correctly. Also adds a warning to the notices
editor for digests.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I like the idea to show a warning, but I would perhaps move
it under the message body label to be more obvious.

Patch works nicely, branch data of my user's home library
is displayed in the notice.

9 years agoBug 7628: Escape '+' characters for categorycode
Jonathan Druart [Fri, 20 Jul 2012 08:48:27 +0000 (10:48 +0200)]
Bug 7628: Escape '+' characters for categorycode

uri escape the following characters:
    &, @, /, ;, :, =, +, ? and $

Signed-off-by: Marc Veron <veron@veron.ch>
Test and sign off second patch (independently from first patch).

Added categories like '+zwoelf' or '? Test' before applying the patch.
Deletion was not possible.

After applying patch deletion is possible, patch works as expected.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 7628 - Required format is not enforced for Patron Categories
Marc Veron [Wed, 18 Jul 2012 05:57:36 +0000 (07:57 +0200)]
Bug 7628 - Required format is not enforced for Patron Categories

Enforces category code with allowed characters only.

Test plan:

- Before applying patch, create a category code like Test+

- Try to delete category with this code -> does not work

- Apply patch

- Try to create category with code containg other characters than letters, numbers, - and _

- Result: You are not allowed to do so, appropriate message pops up

Signed-off-by: David Cook <dcook@prosentient.com.au>
9 years agoBug 8263 follow-up DBRev number
Paul Poulain [Fri, 3 Aug 2012 10:30:04 +0000 (12:30 +0200)]
Bug 8263 follow-up DBRev number

9 years ago8263 Consistent stylesheet prefs
Marcel de Rooy [Mon, 18 Jun 2012 09:42:50 +0000 (11:42 +0200)]
8263 Consistent stylesheet prefs

This patch makes the use of opaccolorstylesheet and opaclayoutstylesheet more consistent. They may be: 1) just a file name, 2) a complete local path or 3) a full URL starting with http: for a remote css file.
This makes the syspref opacstylesheet that was only used for a remote css file obsolete.

June 20, 2012 Rebased.
July 18, 2012: Regex allows https too (thanks to Owen Leonard).

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years ago8263 Make OPAC stylesheet preferences more consistent (dbrev)
Marcel de Rooy [Mon, 18 Jun 2012 11:53:59 +0000 (13:53 +0200)]
8263 Make OPAC stylesheet preferences more consistent (dbrev)

This patch handles the dbrev for this report. It optionally saves the value of the former opacstylesheet pref into opaclayoutstylesheet.

June 21, 2012 & July 4, 2012: Rebased.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
9 years agoBug 8544 - make the RSS icon CSS-changeable
Robin Sheat [Tue, 31 Jul 2012 20:58:50 +0000 (22:58 +0200)]
Bug 8544 - make the RSS icon CSS-changeable

This gives the RSS bits on the search results some CSS classes so it can
be modified with CSS or javascript.

Updated: added also to the RSS icon shown when no results are found.
Signed-off-by: Marc Veron <veron@veron.ch>
Patch behaves as expected.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8385: Dirty patch to make tt_valid.t happy
Jonathan Druart [Wed, 1 Aug 2012 13:35:21 +0000 (15:35 +0200)]
Bug 8385: Dirty patch to make tt_valid.t happy

A problem in routine text_replace_tag (tmpl_process3.pl) have to be
fixed to prevent this kind of patch :)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 6448 follow-up, DBrev number
Paul Poulain [Thu, 2 Aug 2012 16:49:59 +0000 (18:49 +0200)]
Bug 6448 follow-up, DBrev number

9 years agoBug 6448 [2/3] Barcodes::EAN13 autoBarcode
Dobrica Pavlinusic [Wed, 28 Mar 2012 12:43:35 +0000 (14:43 +0200)]
Bug 6448 [2/3] Barcodes::EAN13 autoBarcode

Implement auto-incrementing EAN-13 barcodes

To make this work, C4::Barcodes::next was modified to call process_tail with
new incremented value so that process_tail can generate correct checksum.
Since process_tail is currenlty not used by any barcodes, this change is safe.

C4::Barcodes is used by addbiblio.pl when adding multiple records, while value_builder
is used in all other cases.

Test scenario:

1. prove t/Barcodes_EAN13.t

2. KOHA_CONF=/etc/koha/sites/fer/koha-conf.xml prove t/db_dependent/Barcodes.t
   this will check C4::Barcode implementataion

3. in systempreference change autoBarcode to incremental EAN-13 barcode

4. edit two items of any biblio assigning barcodes and verify that numbers
   are increasing. Have in mind that last digit is check digit, and it
   doesn't increment, but is calculated from barcode itself. Example with
   checksum in brackets: 000000086275[2], 000000086276[9], 000000086277[6]

5. Add Item and verify that it gets assigned next barcode

6. Add & Duplicate item and verify barcode increase

7. Add Multiple Copies and verify that barcode increase for each copy

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 6448 [1/3] EAN-13/UPC-A itemBarcodeInputFilter
Dobrica Pavlinusic [Tue, 27 Mar 2012 22:38:34 +0000 (00:38 +0200)]
Bug 6448 [1/3] EAN-13/UPC-A itemBarcodeInputFilter

This filter which check validity of EAN-13 barcode and padd it with zeros
up to full 13 digit number. This will also expand 12 digit UPC-A barcodes
to EAN-13 automatically which is useful for older barcode readers which tend
to ignore first zero in EAN-13 if they have just UPC-A support.

It should be noted that EAN-13 or UPC-A product codes printed on books are not
good choice for barcodes in Koha since each item has to have unique barcode.

Test scenario:

1. prove t/Circulation_barcodedecode.t
   this checks expansion of 12 digit UPC-A to 13 digit EAN-13 and zero padding

2. in systempreferences search for itemBarcodeInputFilter and select EAN-13

3. edit one item and assign it valid EAN-13 barcode, eg. 0000000695152, check it out

4. test checkin with just 695152 to test leading zero expansion

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 6448 [3/3] EAN-13 barcode labels
Dobrica Pavlinusic [Sat, 4 Jun 2011 12:23:20 +0000 (14:23 +0200)]
Bug 6448 [3/3] EAN-13 barcode labels

Current implementation doesn't scale barcodes because low-price
CCD barcode readers are very sensitive about size

Test scenario:

1. in Tools > Labels create or edit Layout and select EAN13 as barcode
   type

2. export one of existing batches using EAN13 layout and verify that
   generated pdf file contains barcodes

3. print pdf file and test it with barcode reader

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agobug 8477 follow-up for [HTML4] coding guideline
Paul Poulain [Thu, 2 Aug 2012 15:40:07 +0000 (17:40 +0200)]
bug 8477 follow-up for [HTML4] coding guideline

9 years agoBug 8477: Displays home/holding branches on return page
Adrien Saurat [Thu, 19 Jul 2012 13:39:41 +0000 (15:39 +0200)]
Bug 8477: Displays home/holding branches on return page

Signed-off-by: Mirko Tietgen <5p4m@gmx.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8455 - Followup - perltidy renewscript.pl
Kyle M Hall [Wed, 18 Jul 2012 14:10:59 +0000 (10:10 -0400)]
Bug 8455 - Followup - perltidy renewscript.pl

Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8455 - Check ins processed through "Check Out" tab of the Patron Record ignore...
David Cook [Tue, 17 Jul 2012 08:30:13 +0000 (18:30 +1000)]
Bug 8455 - Check ins processed through "Check Out" tab of the Patron Record ignore Circulation System Preferences

If you check-in an item through the "Check Out" tab of the Patron Record, the return/check-in ignores the "InProcessingToShelvingCart" and "ReturnToShelvingCart" circulation system preferences. Or rather, there just isn't any logic to handle them in the renewscript.pl file.

I'm pretty much just bringing the code straight across from returns.pl, although some minor changes need to be made due to context.

Both system preferences are important to include, since you can check-out an in processing item to a patron. While a regular check-in will clear the in processing status, a check-in through the Patron module will cause the item to have its status returned to "In Processing" rather than going to "Shelving Cart", if the preference is set, of course.

To test the scenario, turn on one of (or both of) these settings and try checking books in through the Circulation module and the Patron module.

Before the patch, you will see that only the Circulation module will change the shelving location.

After the patch, you should see identical behaviour.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
http://bugs.koha-community.org/show_bug.cgi?id=7189

9 years agoBug 8463 - Koha/SearchEngine/Solr/Search.pm fails perlcritic test
Mason James [Wed, 18 Jul 2012 02:04:50 +0000 (14:04 +1200)]
Bug 8463 - Koha/SearchEngine/Solr/Search.pm fails perlcritic test

modified:   Koha/SearchEngine/Solr/Search.pm

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 4198 - Followup - PerlTidy authorities-home.pl
Kyle M Hall [Thu, 5 Jul 2012 14:36:39 +0000 (10:36 -0400)]
Bug 4198 - Followup - PerlTidy authorities-home.pl

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 4198 - deleting an authority refreshes the page
Kyle M Hall [Thu, 5 Jul 2012 14:33:40 +0000 (10:33 -0400)]
Bug 4198 - deleting an authority refreshes the page

Makes clicking a Delete link refresh the search that
was performed so that the results are still on the screen.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Works as advertised. Very usefull. Still the issue that indexing being
not in real time, the search result displays the just deleted authority.
But there is no way to do better.

9 years agoMerge remote-tracking branch 'origin/new/bug_6720'
Paul Poulain [Thu, 2 Aug 2012 13:40:31 +0000 (15:40 +0200)]
Merge remote-tracking branch 'origin/new/bug_6720'

9 years agoBug 6720 follow-up: fix error when auth has been deleted
Jared Camins-Esakov [Thu, 2 Aug 2012 13:18:39 +0000 (09:18 -0400)]
Bug 6720 follow-up: fix error when auth has been deleted

Thanks to Paul Poulain for finding the problem and proposing a solution.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8520: fix authority display in staff client
Jared Camins-Esakov [Mon, 30 Jul 2012 13:25:30 +0000 (09:25 -0400)]
Bug 8520: fix authority display in staff client

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoAdded a URI filter to encode a cardnumber for borrowers as to not break patronimage.pl
Elliott Davis [Wed, 11 Jul 2012 10:52:53 +0000 (05:52 -0500)]
Added a URI filter to encode a cardnumber for borrowers as to not break patronimage.pl

To Test:

Add a + (or any char that would need to be encoded) to a card number of a patron with an image attached.
Go to member/moremember.pl.
If the patrons image is there, you are golden.

http://bugs.koha-community.org/show_bug.cgi?id=8421
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 7470: Followup: Changes mailto links
Jonathan Druart [Fri, 30 Mar 2012 13:50:03 +0000 (15:50 +0200)]
Bug 7470: Followup: Changes mailto links

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 7470 follow-up: adding comments to avoid removal of this file
Paul Poulain [Thu, 2 Aug 2012 12:14:26 +0000 (14:14 +0200)]
Bug 7470 follow-up: adding comments to avoid removal of this file

it is unused by Koha itself, but must be here for babeltheque customers !

9 years agoBug 7470: Followup Move Babeltheque css into a specific file
Jonathan Druart [Mon, 23 Apr 2012 07:30:48 +0000 (09:30 +0200)]
Bug 7470: Followup Move Babeltheque css into a specific file

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8427 - Patron search results not consistent
Kyle M Hall [Thu, 12 Jul 2012 11:55:06 +0000 (07:55 -0400)]
Bug 8427 - Patron search results not consistent

Simple fix, removed the directive to order by surname, and the system
now orders by surname, then firstname.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8432 follow-up, fixing error in T::T variable scope
Paul Poulain [Thu, 2 Aug 2012 11:25:24 +0000 (13:25 +0200)]
Bug 8432 follow-up, fixing error in T::T variable scope

9 years agoBug 8432: Change serials results display
Jonathan Druart [Fri, 13 Jul 2012 09:26:36 +0000 (11:26 +0200)]
Bug 8432: Change serials results display

The original author of this patch is : Julian Maurice

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 6655 - Sorting order of serial issues in OPAC
Meenakshi.R [Wed, 23 May 2012 05:07:19 +0000 (10:37 +0530)]
Bug 6655 - Sorting order of serial issues in OPAC

Works as advertised.

Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 7839 follow-up fixing HTML4 coding guideline error
Paul Poulain [Thu, 2 Aug 2012 10:06:05 +0000 (12:06 +0200)]
Bug 7839 follow-up fixing HTML4 coding guideline error

(Capital cases only on 1st word)

9 years agoBug 7839 [ENH] : Add tab in patron record to show patron's routing lists
David Cook [Mon, 2 Jul 2012 00:16:46 +0000 (10:16 +1000)]
Bug 7839 [ENH] : Add tab in patron record to show patron's routing lists

dcook: fixed SQL error and removed blank targets

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Thanks. Works as described. Valuable addition on patron information
page.

Ideas of enhancement:

- For some library, and some patron, the routing lists table could be
  very long, and a paged table would be a plus.
- In the table, a new Vendor column.
- The possibility to sort the table entries by Title and Vendor column.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8405 : add IntranetBiblioDefaultView and BiblioDefaultView in XSLT.pm
Gaetan Boisson [Tue, 10 Jul 2012 09:20:04 +0000 (11:20 +0200)]
Bug 8405 : add IntranetBiblioDefaultView and BiblioDefaultView in XSLT.pm

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8408 - Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals...
Kyle M Hall [Tue, 10 Jul 2012 14:57:46 +0000 (10:57 -0400)]
Bug 8408 - Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals is set to blank

If OpacRenewalAllowed is set to "Don't allow" and OPACFineNoRenewals is set to blank ( i.e. disabled ).
A user who owes any fines, when logged in to the OPAC will receive the following message:

    Please note: You have more than 0.00 in fines.

This is a rather odd message, and is not very sensible. The message should either be modified or removed altogether.

This patch modifies the message to the following:

    Please note: You currently owe $fines in fines

where $fines in the formatted amount the borrower currently owes
in fines.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8518 - Self checkout does not display debt amount if syspref AllowFineOverride...
Marc Veron [Sun, 29 Jul 2012 07:30:54 +0000 (09:30 +0200)]
Bug 8518 - Self checkout does not display debt amount if syspref AllowFineOverride is set to allow

If the patron has depts that prevent issuing and the system preference 'AllowFineOverride' is set to 'allow', the amount is not displayed in the user message.

Additionally, patch adds currency symbol to amount.

Test plan:
Do self checkout with patron who has debts that are over the limit.
Test with and without preference 'AllowFineOverride' set.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoAdd Street Address searchfields set to patrons search header widget
MJ Ray [Fri, 27 Jul 2012 15:57:38 +0000 (16:57 +0100)]
Add Street Address searchfields set to patrons search header widget

http://bugs.koha-community.org/show_bug.cgi?id=8516
Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8503: Software error in edit items with EasyAnalyticalRecords
Fridolyn SOMERS [Wed, 25 Jul 2012 12:11:08 +0000 (14:11 +0200)]
Bug 8503: Software error in edit items with EasyAnalyticalRecords

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Solves software error when editing items for record with invalid
analytic.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoMerge remote-tracking branch 'origin/new/bug_7955'
Paul Poulain [Wed, 1 Aug 2012 14:07:08 +0000 (16:07 +0200)]
Merge remote-tracking branch 'origin/new/bug_7955'

9 years agoBug 7955: Followup : Check the syspref value (avoid sql injection)
Jonathan Druart [Tue, 10 Jul 2012 14:00:54 +0000 (16:00 +0200)]
Bug 7955: Followup : Check the syspref value (avoid sql injection)

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Works as expected. Fields with disallowed characters do not show up.
Added 'if $debug' to an pseudo-unconditional warn.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8207 follow-up DBrev
Paul Poulain [Wed, 1 Aug 2012 13:46:38 +0000 (15:46 +0200)]
Bug 8207 follow-up DBrev

9 years agoBug 8207: Allow see also fields in auths to link to thesauri
Jared Camins-Esakov [Thu, 28 Jun 2012 22:29:12 +0000 (18:29 -0400)]
Bug 8207: Allow see also fields in auths to link to thesauri

Right now if you were to link a field in an authority to a thesaurus, it
would not work properly. The authority type frameworks require some
adjustments to allow see also headings to be linked to thesauri (such as
adding subfield $9).

This patch adds subfield $9 and thesaurus links to existing installs
for those 5xx fields (under MARC21 and NORMARC only) which do not yet
have any subfield $9 or thesauri configured, as well as adding that to
new English language installs. There will be a follow-up patch adding
the subfields to new non-English language install files later, once
it is clear that the changes proposed and demonstrated in the English
files are accepable to the community.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested frameworks install cleanly on a new installation.

Tested database update and made sure, that configuration and subfields
of a field were not changed if
- a $9 subfield already existed for a 5xx field
- a $9 subfield and a link to another thesaurus in $a existed
- no $9 but a link to another thesaurus in $a existed

This seems safe to me.

9 years agoMerge remote-tracking branch 'origin/new/bug_8204'
Paul Poulain [Wed, 1 Aug 2012 12:59:23 +0000 (14:59 +0200)]
Merge remote-tracking branch 'origin/new/bug_8204'

9 years agoBug 8204 follow-up: quiet warn
Jared Camins-Esakov [Fri, 27 Jul 2012 11:53:06 +0000 (07:53 -0400)]
Bug 8204 follow-up: quiet warn

Also removes unnecessary variable declaration. Thanks to Jonathan Druart
for spotting it.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
9 years agoBug 7143: Updating history and about file
Chris Cormack [Thu, 26 Jul 2012 11:00:18 +0000 (23:00 +1200)]
Bug 7143: Updating history and about file

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoMerge remote-tracking branch 'origin/new/bug_8233'
Paul Poulain [Wed, 1 Aug 2012 11:53:43 +0000 (13:53 +0200)]
Merge remote-tracking branch 'origin/new/bug_8233'

9 years agoBug 8233: We can't load test on Koha::SearchEngine::*
Jonathan Druart [Wed, 25 Jul 2012 12:19:48 +0000 (14:19 +0200)]
Bug 8233: We can't load test on Koha::SearchEngine::*

As a temporary measure, don't try to load the search engine modules
in t/00-load.t.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
9 years agoMerge remote-tracking branch 'origin/new/bug_8486'
Paul Poulain [Wed, 1 Aug 2012 10:38:23 +0000 (12:38 +0200)]
Merge remote-tracking branch 'origin/new/bug_8486'

9 years agoBug 8486 - Follow up making the tests db independent
Chris Cormack [Sat, 28 Jul 2012 08:07:36 +0000 (20:07 +1200)]
Bug 8486 - Follow up making the tests db independent

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Makes the test db independant by specifying the date format. Thus, there is no call to ->preference() that retrieve a systempreference

9 years agoBug 8204: fix UNIMARC display
Jared Camins-Esakov [Thu, 26 Jul 2012 15:49:36 +0000 (11:49 -0400)]
Bug 8204: fix UNIMARC display

UNIMARC display of authorities in the OPAC wasn't working due to
changes in the BuildSummary function since the code was originally
developed.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8204: Add user friendly authority view to OPAC
Jared Camins-Esakov [Thu, 31 May 2012 11:24:29 +0000 (07:24 -0400)]
Bug 8204: Add user friendly authority view to OPAC

Up until now, the only authority view in the OPAC was a
rather-unfriendly expanded MARC view. This patch adds a user-friendly
view similar to the biblio details view.

Specific features to be aware of:
* Right-to-left text in the MARC21 880 field will show up in the
  appropriate location with the appropriate alignment and wrapping
* There is very little CSS styling. Any suggestions for how to make
  the display more attractive would be gratefully received.

To test:
1) Do a search for an authority in the OPAC.
2) Choose an authority record to view.
3) Observe that the view is more user-friendly and polished.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works very nicely now. The old view is still available, but the
user is presented with a nicer non-MARC view first.

9 years agoBug 8208 follow-up: move Clear and Create new buttons out of results
Jared Camins-Esakov [Mon, 9 Jul 2012 12:56:27 +0000 (08:56 -0400)]
Bug 8208 follow-up: move Clear and Create new buttons out of results

Turns "Clear" and "Create new" links into buttons that are visible
before a search is performed, so that the user does not have to do
a search just to clear the field or create a new authority. This
commit also changes the formatting from textual links to buttons.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Nicer and more logical display.
Allows creating of a new authority without doing a search first
or when no results were found.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8208: Add fast-add link to auth finder plugin
Jared Camins-Esakov [Mon, 2 Jul 2012 16:51:08 +0000 (12:51 -0400)]
Bug 8208: Add fast-add link to auth finder plugin

When performing subject analysis, it is not uncommon to find that an
authority record you need does not exist. This commit adds a link in
the search results to enable the cataloger to create an authority on
the fly and have the heading populated by the new authority.

To test:
1. Use the auth finder plugin the cataloguing module to search for a
   heading you do not have an authority record for.
2. Click the "Create new" link.
3. Fill in your authority and save it.
4. Note that the heading field was populated with the data you entered
   in the authority record.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
1) Added a new authority using the plugin
2) Used an existing authority using the plugin
3) Created a new authority in the authority module

All worked nicely.

9 years agoBug 7153 - Show Open Library as Search Target in "More Searches" in OPAC detail page
Savitra sirohi [Sat, 5 Nov 2011 04:21:03 +0000 (00:21 -0400)]
Bug 7153 - Show Open Library as Search Target in "More Searches" in OPAC detail page

Update syspref OPACSearchForTitleIn to include Open Library as a target in More Searches in the OPAC detail page

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8470: remove depreciated H:T:P test
Mason James [Wed, 18 Jul 2012 05:24:29 +0000 (17:24 +1200)]
Bug 8470: remove depreciated H:T:P test

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 7420 tiny bugfix
Paul Poulain [Wed, 25 Jul 2012 16:31:50 +0000 (18:31 +0200)]
Bug 7420 tiny bugfix

The printing at the end, in verbose mode was not displaying variables properly because the print was '' and not ""

9 years agoBug 7420 follow-up DBRev number
Paul Poulain [Wed, 25 Jul 2012 16:31:10 +0000 (18:31 +0200)]
Bug 7420 follow-up DBRev number

9 years ago[PATCH] bug_7420: Added overduefinescap to issuingrules
Elliott Davis [Wed, 11 Jul 2012 03:38:28 +0000 (22:38 -0500)]
[PATCH] bug_7420: Added overduefinescap to issuingrules

Replaced existing MaxFine syspref logic with overduefinescap.
Repurposed MaxFine to be the overall overdue limit for all items
overdue. Implemented new MaxFine logic in UpdateFine().

Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
Tested according to Srdjan's test plan and everything worked like he said it would.  I set fined equal to $2 and max fine equal to $1.      When I ran the fines script for overdue items fines assessed were only $1.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agobug 8486 tiny follow-up, removing `
Paul Poulain [Wed, 25 Jul 2012 14:55:30 +0000 (16:55 +0200)]
bug 8486 tiny follow-up, removing `

9 years agoBug 8486 Merge Calendar test files
Colin Campbell [Wed, 25 Jul 2012 09:55:56 +0000 (10:55 +0100)]
Bug 8486 Merge Calendar test files

Moves the tests previously in t/Kalendar.t to t/Calendar.t
and removes the old file.
Note the existing minimal test of C4/Calendar still called in
t/Calendar

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8486 Correct calculation of days_between
Colin Campbell [Tue, 24 Jul 2012 14:16:10 +0000 (15:16 +0100)]
Bug 8486 Correct calculation of days_between

Thee were errors in the calculation used for days_between
which caused incorrect values to be returned
Added tests to validate calculation

NB Tests still need to be provided for the hourly
calculations

9 years agoMerge remote-tracking branch 'origin/new/bug_7889'
Paul Poulain [Wed, 25 Jul 2012 13:08:50 +0000 (15:08 +0200)]
Merge remote-tracking branch 'origin/new/bug_7889'

9 years agoBug 7889 - Use standard style for errors and messages
Owen Leonard [Fri, 18 May 2012 12:57:15 +0000 (08:57 -0400)]
Bug 7889 - Use standard style for errors and messages

Correcting the markup of error messages in three places:
catalogue merge, CSV profile editing, and opac comments.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years ago7368 Adjustments for Perl dependencies
Marcel de Rooy [Wed, 18 Jul 2012 13:03:36 +0000 (15:03 +0200)]
7368 Adjustments for Perl dependencies

HTML::FormatText is used by Template::Plugin::HtmlToText which is called in the template for opac-sendbasket.pl.
This is not a core Perl 5.10 module. I had to install it additionally on a test server. So I am adding it to PerlDependencies.
I just picked an old version 1.23 that I still could find as min_ver.

Changed the version information for Test::Strict too (not required, only for tests).

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 7302 tiny follow-up removing </td><td>
Paul Poulain [Tue, 24 Jul 2012 16:34:52 +0000 (18:34 +0200)]
Bug 7302 tiny follow-up removing </td><td>

to have the Export as CSV in the same cell as other buttons

9 years agoBug 7302: Followup: rename "Client number" column with "Account number"
Jonathan Druart [Mon, 11 Jun 2012 08:29:23 +0000 (10:29 +0200)]
Bug 7302: Followup: rename "Client number" column with "Account number"

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 7302: Export basketgroup as CSV
Jonathan Druart [Thu, 16 Feb 2012 13:32:03 +0000 (14:32 +0100)]
Bug 7302: Export basketgroup as CSV

Adds new action export for basketgroup.
This action is available only if your basketgroup is closed.
This export generates a csv file with order informations.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested together with bug 5356.

9 years agoBug 8376: New script to export borrowers misc/export_borrowers.pl
Julian Maurice [Fri, 6 Jul 2012 10:31:48 +0000 (12:31 +0200)]
Bug 8376: New script to export borrowers misc/export_borrowers.pl

This script prints to standard output what is returned by
GetMemberDetails in CSV format.
Exported fields can be specified with option -f. If no -f option is
specified, all fields are exported.

Signed-off-by: Gaetan Boisson <gaetan.boisson@biblibre.com>
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Amended with some code to better handle bad data.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8434 - Notice generation fails for Advanced Notices, Item Due, and Overdues when...
David Cook [Fri, 13 Jul 2012 01:50:04 +0000 (11:50 +1000)]
Bug 8434 - Notice generation fails for Advanced Notices, Item Due, and Overdues when run in shell (due to error in Letters.pm)

Patch introduces a check for C4::Context->userenv in Letters.pm, so that script doesn't fail when it calls to C4::Context->userenv->{branch}, when run from shell.

Without the check, Advanced Notices, Item Due, and Overdues fail to generate.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 7367 - One "the" too many
Magnus Enger [Mon, 23 Jul 2012 11:26:19 +0000 (13:26 +0200)]
Bug 7367 - One "the" too many

On line 123 it says "of the the last". One "the" is probably enough.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoMerge remote-tracking branch 'origin/new/bug_8062'
Paul Poulain [Tue, 24 Jul 2012 15:31:07 +0000 (17:31 +0200)]
Merge remote-tracking branch 'origin/new/bug_8062'

9 years ago8062 Followup for HTML::FormatText
Marcel de Rooy [Wed, 18 Jul 2012 13:58:37 +0000 (15:58 +0200)]
8062 Followup for HTML::FormatText

The dependency is not used in opac-sendbasket. But there is a require of HTML::FormatText in the code of Template::Plugin::HTMLToText.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
9 years agoBug 8392: Avoid having an untranslatable age range
Frédéric Demians [Mon, 9 Jul 2012 15:45:11 +0000 (17:45 +0200)]
Bug 8392: Avoid having an untranslatable age range

Currently, error message reports an age range in English. For example '0 to
17'. With this patch, the 'to' is not in the .pl file anymore.

Ruth could you sign-off this fix?

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8392: Category age ranges not being enforced
D Ruth Bavousett [Mon, 9 Jul 2012 14:18:03 +0000 (10:18 -0400)]
Bug 8392: Category age ranges not being enforced

This patch works around the redefinition of an array that was causing the
enforcement of age ranges to not-happen.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
I can confirm the bug and the solution.

9 years agoBug 8440: Dates does not appear in suggestions management
Fridolyn SOMERS [Fri, 13 Jul 2012 14:23:02 +0000 (16:23 +0200)]
Bug 8440: Dates does not appear in suggestions management

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8414 - Intranet header toplinks display white rather than blue in < IE8
David Cook [Wed, 11 Jul 2012 23:13:10 +0000 (09:13 +1000)]
Bug 8414 - Intranet header toplinks display white rather than blue in < IE8

Removes IE7 hash hack which caused head toplinks to display white rather than dark blue against light blue background

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8448 - Holds Awaiting Pickup : Cancelling a hold on a waiting item with multiple...
David Cook [Mon, 16 Jul 2012 04:13:31 +0000 (14:13 +1000)]
Bug 8448 - Holds Awaiting Pickup : Cancelling a hold on a waiting item with multiple holds displays a blank screen instead of a warning prompt

When you cancel a hold in the "Hold Waiting" tab of Holds Awaiting Pickup, you should be prompted to retain or transfer the hold for the next patron in the queue. However, instead of seeing this prompt, you are just shown white screen that fails to alert you to the fact that there are more holds on that item!

There is a missing FOREACH reference in waitingreserves.tt. The template tries to directly reference the hash within the cancel_results array, but we need to access the array before we can access the hash.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8442 - labels creator fixes for plack
Dobrica Pavlinusic [Thu, 19 Jul 2012 17:12:13 +0000 (19:12 +0200)]
Bug 8442 - labels creator fixes for plack

- remove all exit(1) and replace them with __END__ which benefits CGI
- insert correct =cut markers at end of POD (required for CGI::Compile
  under plack to correctly parse source code and exeute it)
- scope variables with our which are used inside sub for plack

Signed-off-by: Mirko Tietgen <5p4m@gmx.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBugFix - ReturnToShelvingCart
Kyle M Hall [Thu, 8 Oct 2009 12:13:13 +0000 (12:13 +0000)]
BugFix - ReturnToShelvingCart

If the ReturnToShelvingCart syspref is on, and something needs to go in transit,
the shelving cart setting is overriding the transit.

What seems to be happening is this:
  * Item is checked in, and flagged as needing to go in transit from A to B.
  * Item is immediately flagged as shelving cart, though.  Current display says both shelving cart and in transit.
  * After the cart-to-shelf script runs, item comes out of transit and
    shows as being available at the destination library, although it hasn't
    arrived yet and no one has manually checked it in.

http://bugs.koha-community.org/show_bug.cgi?id=3701

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8439 - Printing basketgroup does not work on plack
Dobrica Pavlinusic [Mon, 16 Jul 2012 10:43:24 +0000 (12:43 +0200)]
Bug 8439 - Printing basketgroup does not work on plack

scope $input CGI object with our for plack

Signed-off-by: Mirko Tietgen <5p4m@gmx.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
9 years agoBug 8476: Little bug in OPAC XSLT on OPACURLOpenInNewWindow
Fridolyn SOMERS [Thu, 19 Jul 2012 13:29:12 +0000 (15:29 +0200)]
Bug 8476: Little bug in OPAC XSLT on OPACURLOpenInNewWindow

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
I know where it comes from: vim cut-and-paste...

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>