From 86d96899a4a0a0de90af8f17c273fd205316a9e7 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Tue, 23 Feb 2016 09:16:13 -0500
Subject: [PATCH] Bug 15884 - Vendor contract deletion warning is incorrectly
 styled
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

When deleting a contract in  Acquisitions -> Vendor -> Contracts, the
deletion confirmation message is not styled with the standard "dialog
alert" <div>. This patch modifies the confirmation markup to match the
standard.

To test, apply the patch and go to Acquisitions -> [ a vendor] ->
Contracts

- Try deleting a contract. The confirmation box should have the standard
  "dialog alert" class.
- Test the 'confirm' and 'cancel' actions and make sure both complete
  correctly.

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
---
 .../prog/en/modules/admin/aqcontract.tt       | 20 ++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqcontract.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqcontract.tt
index 684d69fb99..382caf1c4a 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqcontract.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqcontract.tt
@@ -142,9 +142,8 @@ function Check(ff) {
                 </form>
             [% END %]
             [% IF ( delete_confirm ) %]
-                <form action="[% script_name %]" method="post">
-                    <fieldset>
-                        <legend>Confirm deletion of contract [% contractnumber %]</legend>
+                    <div class="dialog alert">
+                        <h3>Confirm deletion of contract <i>[% contractname %]</i></h3>
                         <table>
                             <tr><th scope="row">Contract number:</th><td>[% contractnumber %]</td></tr>
                             <tr><th scope="row">Contract name:</th><td>[% contractname %]</td></tr>
@@ -153,15 +152,18 @@ function Check(ff) {
                             <tr><th scope="row">Contract end date:</th><td>[% contractenddate | $KohaDates %]</td></tr>
                             <tr><th scope="row">Vendor:</th><td>[% booksellername %]</td></tr>
                         </table>
-                        <fieldset class="action">
+                        <form action="[% script_name %]" method="post">
                             <input type="hidden" name="op" value="delete_confirmed" />
                             <input type="hidden" name="booksellerid" value="[% booksellerid %]" />
                             <input type="hidden" name="contractnumber" value="[% contractnumber %]" />
-                            <input type="submit" value="Delete this contract" />
-                            <a class="cancel" href="/cgi-bin/koha/admin/aqcontract.pl?booksellerid=[% booksellerid %]&amp;contractnumber=[% contractnumber %]">Cancel</a>
-                        </fieldset>
-                    </fieldset>
-                </form>
+                            <button type="submit" class="approve"><i class="fa fa-fw fa-check"></i> Yes, delete contract</button>
+                        </form>
+                        <form action="/cgi-bin/koha/admin/aqcontract.pl" method="get">
+                            <input type="hidden" name="booksellerid" value="[% booksellerid %]" />
+                            <input type="hidden" name="contractnumber" value="[% contractnumber %]" />
+                            <button type="submit" class="deny"><i class="fa fa-fw fa-remove"></i> No, do not delete</button>
+                        </form>
+                    </div>
             [% END %]
             [% IF ( delete_confirmed ) %]
                 <h3>Contract deleted</h3>
-- 
2.20.1