From acfbfcb7d9b6bef3186adc9b93ead44fc58ce420 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 26 Apr 2013 14:20:49 -0400 Subject: [PATCH] Bug 9266 - Untranslated strings in tags moderation MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit There are a couple of English strings in tags moderation JavaScript which are not properly enclosed in the _() function enabling translation. As a result, clicking a translated 'Approve' or 'Reject' button in the table of tags would change the button's neighbor's label to the English string. This patch corrects it. To test, apply the patch and regenerate a translation to test with. Go to Tools -> Tags and find a list of tags to moderate (pending, approved, or rejected). When you click on an 'Approve' or 'Reject' tag in the table of tags, the buttons in each Approve/Reject pair should retain their correct translated label. For instance, looking at approved tags in French: [ Approuvé ] [ Rejeter ] Clicking the "Rejetee" button should change the state to: [ Approuver ] [ Rejetée ] Clicking "Approuver" should return the buttons to the first state. Signed-off-by: Chris Cormack Signed-off-by: Mason James Signed-off-by: Jared Camins-Esakov --- koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt index a3b1e224b6..acd412b90b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt @@ -96,7 +96,7 @@ td input,td input[type="submit"] { font-size: 85%; padding: 1px; } "data": {ok: $(event.target).attr("title")}, "success": count_approve // success_approve }); - $(event.target).next(".rej").removeAttr("disabled").attr("value","Reject").css("color","#000"); + $(event.target).next(".rej").removeAttr("disabled").attr("value",_("Reject")).css("color","#000"); $(event.target).attr( "value",_("Approved")).attr("disabled","disabled").css("color","#666"); return false; // cancel submit } @@ -105,7 +105,7 @@ td input,td input[type="submit"] { font-size: 85%; padding: 1px; } "data": {rej: $(event.target).attr("title")}, "success": count_reject // success_reject }); - $(event.target).prev(".ok").removeAttr("disabled").attr("value","Approve").css("color","#000"); + $(event.target).prev(".ok").removeAttr("disabled").attr("value",_("Approve")).css("color","#000"); $(event.target).attr( "value",_("Rejected")).attr("disabled","disabled").css("color","#666"); return false; // cancel submit } -- 2.20.1