From 762399e8edb787e5ae0fa5a9459aed6fafa07dd5 Mon Sep 17 00:00:00 2001 From: Matt Blenkinsop Date: Thu, 23 May 2024 09:23:10 +0000 Subject: [PATCH] Bug 36937: Remove warning from unit tests This patch fixes a warning in the unit tests Test plan: 1) prove t/db_dependent/api/v1/password_validation.t 2) There will be a warning in the output - 'Use of uninitialized value $status in numeric eq (==)' 3) Apply patch 4) Re-run the test 5) The warning will disappear Signed-off-by: Jonathan Druart Signed-off-by: David Nind Signed-off-by: Martin Renvoize (cherry picked from commit 5e7572ad7a86cb39d901088367f76b212d64989e) Signed-off-by: Lucas Gass (cherry picked from commit 227a5619a4097c8667a004d38b6e7e2eb2640221) Signed-off-by: Fridolin Somers --- Koha/REST/V1/Auth/Password.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Koha/REST/V1/Auth/Password.pm b/Koha/REST/V1/Auth/Password.pm index 189dcc80d5..339229477d 100644 --- a/Koha/REST/V1/Auth/Password.pm +++ b/Koha/REST/V1/Auth/Password.pm @@ -73,7 +73,7 @@ sub validate { return try { my ( $status, $THE_cardnumber, $THE_userid, $patron ) = C4::Auth::checkpw( $identifier, $password ); unless ( $status && $status > 0 ) { - my $error_response = $status == -2 ? 'Password expired' : 'Validation failed'; + my $error_response = ($status && $status == -2) ? 'Password expired' : 'Validation failed'; return $c->render( status => 400, openapi => { error => $error_response } -- 2.39.5