From eea7b7493506bc7d6095f41b4f02f1be357432d5 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 19 Oct 2018 12:06:43 -0300 Subject: [PATCH] Bug 21621: Remove incorrect GROUP BY from tools/letter.pl Fix: 'koha_kohadev.letter.name' isn't in GROUP BY DBD::mysql::db selectall_arrayref failed: 'koha_kohadev.letter.name' isn't in GROUP BY [for Statement "SELECT branchcode, module, code, name, branchname FROM letter LEFT OUTER JOIN branches USING (branchcode) GROUP BY branchcode,module,code ORDER BY module, code, branchcode"] at /home/vagrant/kohaclone/tools/letter.pl line 383. Test plan: - Copy some default notice templates for specific libraries - List the different notice templates - Confirm that notices appear only one, with "all libraries" you will see all Signed-off-by: Pierre-Marc Thibault Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens (cherry picked from commit 0cffb0f7589aa52d65bda9a8a4934790a141f3a0) Signed-off-by: Martin Renvoize --- tools/letter.pl | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/letter.pl b/tools/letter.pl index d1c95bcf19..caaeb0e212 100755 --- a/tools/letter.pl +++ b/tools/letter.pl @@ -377,7 +377,6 @@ sub retrieve_letters { } $sql .= " WHERE ".join(" AND ", @where) if @where; - $sql .= " GROUP BY branchcode,module,code"; $sql .= " ORDER BY module, code, branchcode"; return $dbh->selectall_arrayref($sql, { Slice => {} }, @args); -- 2.39.5