From 0e34f36d47fb2a5e7834b5f6b73e453d487d67b7 Mon Sep 17 00:00:00 2001 From: Andrew Fuerste-Henry Date: Thu, 30 Apr 2020 19:35:51 +0000 Subject: [PATCH] Bug 25335: group by authorised_value in addbiblio.pl To Test: 1- Edit your default framework, connect any subfield outside of the 952 to an authorised value (for example, connect the 942$n to the Yes_No auth value) 2 - Find a record in that framework 3 - Edit the record and find your subfield 4 - The subfield shows a dropdown with no contents 5 - check plack log, see "DBD::mysql::st execute failed: 'koha_kohadev.authorised_values.authorised_value' isn't in GROUP BY " 6 - apply patch, restart all 7 - reload edit record page, see your auth value dropdown has contents Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize --- cataloguing/addbiblio.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl index cd53c66e70..7d48842c6a 100755 --- a/cataloguing/addbiblio.pl +++ b/cataloguing/addbiblio.pl @@ -484,7 +484,7 @@ sub build_tabs { $query .= qq{ LEFT JOIN authorised_values_branches ON ( id = av_id )} if $branch_limit; $query .= " WHERE category = ?"; $query .= " AND ( branchcode = ? OR branchcode IS NULL )" if $branch_limit; - $query .= " GROUP BY lib ORDER BY lib, lib_opac"; + $query .= " GROUP BY authorised_value,lib ORDER BY lib, lib_opac"; my $authorised_values_sth = $dbh->prepare( $query ); # in this array, we will push all the 10 tabs -- 2.39.5