From b39910f15aad2d0cb83e9520ec736a3234abaffc Mon Sep 17 00:00:00 2001
From: Garry Collum <gcollum@gmail.com>
Date: Thu, 11 Jun 2009 20:42:37 -0400
Subject: [PATCH] Bug 2889: Removed unused toggle variable from
 pcard-member-search.pl. Added table highlighting to .tmpl.

Removed unused toggle variable form pcard-member-search.pl.

Added highlighting to pcard-members-search.tmpl and fixed some XHMTL errors.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
---
 .../prog/en/modules/labels/pcard-members-search.tmpl   | 10 +++++++---
 labels/pcard-member-search.pl                          |  3 ---
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/pcard-members-search.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/pcard-members-search.tmpl
index 93972cc7b0..8c155835f4 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/pcard-members-search.tmpl
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/pcard-members-search.tmpl
@@ -85,9 +85,9 @@ function add_item3(borrowernumber){
 <input type="hidden" name="batch_id" value="<!-- TMPL_VAR NAME="batch_id" -->" />
 <input type="hidden" name="type" value="<!-- TMPL_VAR NAME="type" -->" />
 <label for="member">Name</label>
-<input name="member" />
+<input id="member" name="member" />
 <label for="category">Category code</label>
-<input name="category" />
+<input id="category" name="category" />
 <input type="submit" value="Search" /></p>
 </form>
 
@@ -100,7 +100,7 @@ function add_item3(borrowernumber){
 
     <table style="float: left; margin: .5em 0;">
     <tr>
-    <th><label for="patron<!-- TMPL_VAR NAME="borrowernumber" -->" style="font-weight:bold;">Select</label></th>
+    <th><label style="font-weight:bold;">Select</label></th>
     <th><a href="pcard-member-search.pl?member=<!--TMPL_VAR Name="member" -->&amp;category=<!--TMPL_VAR Name="category_type" -->&amp;batch_id=<!-- TMPL_VAR NAME="batch_id" -->&amp;type=<!-- TMPL_VAR NAME="type" -->&amp;orderby=cardnumber">Card</a></th>
     <th><a href="pcard-member-search.pl?member=<!--TMPL_VAR Name="member" -->&amp;category=<!--TMPL_VAR Name="category_type" -->&amp;batch_id=<!-- TMPL_VAR NAME="batch_id" -->&amp;type=<!-- TMPL_VAR NAME="type" -->&amp;orderby=surname">Name</a></th>
     <th><a href="pcard-member-search.pl?member=<!--TMPL_VAR Name="member" -->&amp;category=<!--TMPL_VAR Name="category_type" -->&amp;batch_id=<!-- TMPL_VAR NAME="batch_id" -->&amp;type=<!-- TMPL_VAR NAME="type" -->&amp;orderby=borrowers.categorycode">Category</a></th>
@@ -110,7 +110,11 @@ function add_item3(borrowernumber){
     <th></th>
     </tr>
     <!-- TMPL_LOOP NAME="resultsloop" -->
+    <!-- TMPL_UNLESS NAME="__odd__" -->
+    <tr class="highlight">
+    <!-- TMPL_ELSE -->
     <tr>
+    <!-- /TMPL_UNLESS -->
     <td> <input type="checkbox" name="borrowernumber" id="patron<!-- TMPL_VAR NAME="borrowernumber" -->" value="<!-- TMPL_VAR NAME="borrowernumber" -->" />	</td>
     <td><!-- TMPL_VAR NAME="cardnumber" --></td>
     <td style="white-space: nowrap;"><a href="/cgi-bin/koha/members/morepcard-member-search.pl?borrowernumber=<!-- TMPL_VAR NAME="borrowernumber" -->"><!-- TMPL_VAR NAME="surname" -->, <!-- TMPL_VAR NAME="firstname" --></a> <br /> <!-- TMPL_VAR NAME="address" --><!-- TMPL_IF NAME="address2" --><br /><!-- TMPL_VAR NAME="address2" --><!-- /TMPL_IF --><!-- TMPL_IF NAME="city" --><br /><!-- TMPL_VAR NAME=city --><!-- /TMPL_IF --></td>
diff --git a/labels/pcard-member-search.pl b/labels/pcard-member-search.pl
index 5620a547b1..1ff5cf1bb0 100755
--- a/labels/pcard-member-search.pl
+++ b/labels/pcard-member-search.pl
@@ -95,14 +95,12 @@ else
 
 
 my @resultsdata;
-my $toggle = 0;
 my $to=($count>($startfrom*$resultsperpage)?$startfrom*$resultsperpage:$count);
 for (my $i=($startfrom-1)*$resultsperpage; $i < $to; $i++){
   #find out stats
   my ($od,$issue,$fines)=GetMemberIssuesAndFines($results->[$i]{'borrowernumber'});
 
   my %row = (
-    toggle => $toggle,
     count => $i+1,
     borrowernumber => $results->[$i]{'borrowernumber'},
     cardnumber => $results->[$i]{'cardnumber'},
@@ -125,7 +123,6 @@ for (my $i=($startfrom-1)*$resultsperpage; $i < $to; $i++){
     sort2 => $results->[$i]{'sort2'},
     dateexpiry => C4::Dates->new($results->[$i]{'dateexpiry'},'iso')->output('syspref'),
     );
-  if ( $toggle ) { $toggle = 0; } else {$toggle = 1; }
   push(@resultsdata, \%row);
 }
 my $base_url =
-- 
2.39.5