]> git.koha-community.org Git - koha.git/commit
Bug 28294: Remove updateWrongTransfer
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 17 May 2021 16:14:16 +0000 (17:14 +0100)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Thu, 7 Nov 2024 17:49:36 +0000 (18:49 +0100)
commit8b08d4f0950d733286f9509be68a749df95f2022
tree9430ef5e828eea3dd2cdff772c1abf085cdf461a
parent27b780ce62312847b0e1235da073dcf681c86fd3
Bug 28294: Remove updateWrongTransfer

This patch removes the last remaining use of updateWrongTransfer and the
method itself.

We replace it with a call to request_transfer that passes the 'replace'
reason of 'WrongTransfer' through to Koha::Item::Transfer->cancel.

Test plan
1/ git grep updateWrongTransfer to confirm there are no more uses of the
method.
2/ Confirm an incorrect transfer still behaves as expected at
circulation returns.

Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
C4/Circulation.pm
C4/Items.pm
C4/RotatingCollections.pm
Koha/Item.pm
Koha/StockRotationItem.pm
circ/returns.pl
t/db_dependent/Circulation.t
t/db_dependent/Koha/Item.t