]> git.koha-community.org Git - koha.git/commit
Bug 27422: YouTube videos are HTTPS only
authorTomas Cohen Arazi <tomascohen@theke.io>
Wed, 3 Feb 2021 22:50:29 +0000 (19:50 -0300)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Mon, 22 Feb 2021 02:02:04 +0000 (03:02 +0100)
commite45a1f6fa63483be81b55293c309b7328ce6fbcd
treea9fac9272ba2474ffc20f60ab8547d006884633c
parent231dfeb37e43d9ecba9b4ea86a0380dbe7cc3535
Bug 27422: YouTube videos are HTTPS only

This patch hardcodes HTTPS as the protocol to use when generating
YouTube content embedding. It is the supported protocol and without this
patch it falls back to 'http', or it can be 'ftp' depending on the first
indicator of the 856 field. They are all not supported so hardcoding it.

To test:
1. Have a record with 856 $uhttps://youtu.be/sMNkDPFycNU
2. Enable the HTML5MediaYouTube and HTML5Media sysprefs
3. Open the OPAC detailed view of the record
4. Open the Multimedia tab
=> FAIL: There's no embedded video
5. Apply this patch
6. Restart all
7. Repeat 4
=> SUCCESS: There's a live performance of Heroes del Silencio!
8. Sign off :-D

Sponsored-by: Banco Central de la República Argentina
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit ca5efc9aa45c3c7893a09cf0067718fdaab63507)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit ed2765ddc38c7c19461806b996319aed147c188f)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
(cherry picked from commit c0135fdbe3678e39c61a4b8ca258fa675dde8d3a)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
C4/HTML5Media.pm