]> git.koha-community.org Git - koha.git/commit
Bug 3264 UnCloneField() / minus button in MARC editor can clear all subfields (author...
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 19 Jan 2012 08:50:03 +0000 (09:50 +0100)
committerChris Nighswonger <chris.nighswonger@gmail.com>
Mon, 20 Feb 2012 03:27:53 +0000 (22:27 -0500)
commit7f4888c46ea4da211f50a6b2d47ede580d3aad68
treeed62796e98b22ddc9b6fbd0d8bf059b427f20ae0
parent3bd714cc157b2f2e48970ae899ace42e202c1b14
Bug 3264 UnCloneField() / minus button in MARC editor can clear all subfields (authorities AND biblio)

All subfields following the removed subfield were not saved.
Problem is in C4/Biblio routine TransformHtmlToMarc.
If the field is emptied, the param list contains a code param but no subfield
param. The while loop handling the subfields could not handle that. Also added
a FIXME because the whole routine depends on an assumption about the order of
cgi parameters that is not strictly guaranteed.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
I was unable to replicate the problem, but can confirm that the patch does
not break anything under any of the following platforms/browsers:
Mac OS X 10.6.8:
Chrome 16.0.912.77
Firefox 9.0.1

Windows 7:
Firefox 3.6.3
Firefox 9.0.1
IE 8.0.7600.16385

Ubuntu 11.10
Firefox 8.0
Chromium 15.0.874.106 (Developer Build 107270 Linux)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 795dc61f7526c3810173139004c741dc8c810382)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
(cherry picked from commit 0e53191ad686a58f2595dc4ecbe8c73566c93c0f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
C4/Biblio.pm