From 979d284bae9536a018e2b106e1110c4021476490 Mon Sep 17 00:00:00 2001 From: Thomas Klausner Date: Mon, 21 Feb 2022 12:35:15 +0100 Subject: [PATCH] Bug 30142: Remove spaces from ElasticSearch mapping MARC fields MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit A first step to "validate" the MARC mappings: Remove all whitespace, so if a user enters "245a " (with a trailing whitespace, which can easily happen when copy/pasting) we only store "245a" in the DB. This is neccessary, because the ES indexer will throw an exception in an invalid MARC mapping. Test Plan: * Go to /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl * Go to the Bibliographic Records Tab * Enter "100 a b c " (notice the whitespaces!) in the first "mapping" field * Scroll down and save * Go back to the Bibliographic Records Tab * The spaces are still there Now apply the patch * Repeat the above steps * After saving you should see "100abc" without any spaces in the "mapping" field Sponsored-by: Steiermärkische Landesbibliothek Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens Signed-off-by: Fridolin Somers Signed-off-by: Kyle M Hall (cherry picked from commit 0dbb236d891b69f09ab06a62e2679755ea36621c) Signed-off-by: Andrew Fuerste-Henry --- admin/searchengine/elasticsearch/mappings.pl | 3 +++ 1 file changed, 3 insertions(+) diff --git a/admin/searchengine/elasticsearch/mappings.pl b/admin/searchengine/elasticsearch/mappings.pl index 11cd8c75fc..3d8d220ddf 100755 --- a/admin/searchengine/elasticsearch/mappings.pl +++ b/admin/searchengine/elasticsearch/mappings.pl @@ -158,7 +158,10 @@ if ( $op eq 'edit' ) { my $search_field = Koha::SearchFields->find({ name => $search_field_name }, { key => 'name' }); $mandatory_after++ if $search_field->mandatory && !defined $seen_fields{$search_field_name}; $seen_fields{$search_field_name} = 1; + # TODO Check mapping format + $mapping_marc_field =~ s/\s//g; + my $marc_field = Koha::SearchMarcMaps->find_or_create({ index_name => $index_name, marc_type => $marc_type, -- 2.39.5